From nobody Sun Apr 26 21:37:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20976C433EF for ; Wed, 22 Jun 2022 09:29:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354732AbiFVJ3X (ORCPT ); Wed, 22 Jun 2022 05:29:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355742AbiFVJ3T (ORCPT ); Wed, 22 Jun 2022 05:29:19 -0400 Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 472223669F for ; Wed, 22 Jun 2022 02:29:18 -0700 (PDT) Received: by mail-oi1-x244.google.com with SMTP id k24so20427501oij.2 for ; Wed, 22 Jun 2022 02:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xzFZy7EobE569rOuuG/ggjMqoyz7vEjB3IIrzWyAvt8=; b=Yi2rupt2gqO0TXPAhwMzEoXicOGPWzkZYLtKaqwX5sv5fjgIYq3rZb3R/vgBXYmIjq giyViDEHu+DCwEPCXcny9wrQgUo0AtT4tMBMiXpAlPLpARr1X5ZNFdxuf39m9miwt0QP AOgTSvfi6Bn8v737usTipbLNyeA2oPBzM+vR/bVl4/ABFZT2VIarzXwTaunUbFYIpf+q cmRrkYX4ZVJcBznk5CsEbbqXT9EC2zdVg/4CNrtbtZw9bN0IZS9h9FUXIiw9wtXveqO9 tgkGxhBfAgbSaOJQzWi/w0ERFqJyEmsof4c7r6ExDzYMEHlnMU/jd4khiWK3l5NUBxId 3wVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xzFZy7EobE569rOuuG/ggjMqoyz7vEjB3IIrzWyAvt8=; b=Un++GP1NdgsV0xOdac6+THx+6i9EDRcbUDyHh8o23DSCXZHa3eK1FrrQ+U1Eq+ESyP f418HyNc6n06qA3WJyREC3+stjSt/PyH07iTkuHr+l2YoKQO2HVB+/H1EkjhXHxEDbZq +ANJT/3E5EXDCjco+krfbmaTIjp/g/NMgyRDL6aWdYeQ3uk837sg37LdcGQ6cCsoq4Qi h8OUOgyWPr60jnCH97cfw6S9QudLrQ3R/PKUSta97NlMOCVW4izbv12TVKupbJLbRxwF 2rRhu+yqmttBGCqMjIjwaHVbjFUeY52aiUkXQRLztTQP6OwYg7iI9AUPhZnmBge478FM DQsA== X-Gm-Message-State: AOAM531+r3i/NnZoI4DrpJ4bqlCHsDFtXlOk3RG0NCKbhNZzGSLeihe+ dyEDMePM2O/Fz9VE/2ahWsIwqMY6GSY= X-Google-Smtp-Source: ABdhPJwXl4mJ3gLaWz5a2mal8GQQEvRZB4IXNkgmCdIoGKbfL20IbEcvlw+rsFyYz12pL5dSVHvcwg== X-Received: by 2002:a05:6808:1598:b0:32e:ff1f:1dbf with SMTP id t24-20020a056808159800b0032eff1f1dbfmr20777596oiw.259.1655890157618; Wed, 22 Jun 2022 02:29:17 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id dt13-20020a0568705a8d00b00101afc7b263sm8584818oab.9.2022.06.22.02.29.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 02:29:17 -0700 (PDT) From: Rebecca Mckeever To: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand , Rebecca Mckeever Subject: [PATCH v3 1/4] memblock tests: add user-provided arguments to Makefile Date: Wed, 22 Jun 2022 04:29:06 -0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add VERBOSE and MEMBLOCK_DEBUG user-provided arguments. VERBOSE will enable verbose output from Memblock simulator. MEMBLOCK_DEBUG will enable memblock_dbg() messages. Update the help message to include VERBOSE and MEMBLOCK_DEBUG. Update the README to include VERBOSE. The README does not include all available options and refers to the help message for the remaining options. Therefore, omit MEMBLOCK_DEBUG from README. Reviewed-by: David Hildenbrand Signed-off-by: Rebecca Mckeever --- tools/testing/memblock/Makefile | 4 ++++ tools/testing/memblock/README | 10 +++++++++- tools/testing/memblock/scripts/Makefile.include | 10 ++++++++++ 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/tools/testing/memblock/Makefile b/tools/testing/memblock/Makef= ile index a698e24b35e7..9fde49ad73bd 100644 --- a/tools/testing/memblock/Makefile +++ b/tools/testing/memblock/Makefile @@ -45,6 +45,10 @@ help: @echo ' clean - Remove generated files and symlinks in the directory' @echo '' @echo 'Configuration:' + @echo ' make VERBOSE=3D1 - enable verbose output, which incl= udes the' + @echo ' names of functions being tested and= the' + @echo ' number of test cases passing' + @echo ' make MEMBLOCK_DEBUG=3D1 - enable memblock_dbg() messages' @echo ' make NUMA=3D1 - simulate enabled NUMA' @echo ' make MOVABLE_NODE=3D1 - override `movable_node_is_enabled= `' @echo ' definition to simulate movable NUMA= nodes' diff --git a/tools/testing/memblock/README b/tools/testing/memblock/README index ca6afcff013a..058146b528a5 100644 --- a/tools/testing/memblock/README +++ b/tools/testing/memblock/README @@ -34,7 +34,15 @@ To run the tests, build the main target and run it: $ make && ./main =20 A successful run produces no output. It is also possible to override diffe= rent -configuration parameters. For example, to simulate enabled NUMA, use: +configuration parameters. For example, to include verbose output, specify = the +VERBOSE flag when building the main target: + +$ make VERBOSE=3D1 + +This will print information about which functions are being tested and the +number of test cases that passed. + +To simulate enabled NUMA, use: =20 $ make NUMA=3D1 =20 diff --git a/tools/testing/memblock/scripts/Makefile.include b/tools/testin= g/memblock/scripts/Makefile.include index 641569ccb7b0..4401f79bed4c 100644 --- a/tools/testing/memblock/scripts/Makefile.include +++ b/tools/testing/memblock/scripts/Makefile.include @@ -17,3 +17,13 @@ ifeq ($(32BIT_PHYS_ADDR_T), 1) CFLAGS +=3D -m32 -U CONFIG_PHYS_ADDR_T_64BIT LDFLAGS +=3D -m32 endif + +# Enable verbose testing output +ifeq ($(VERBOSE), 1) + CFLAGS +=3D -D VERBOSE +endif + +# Enable memblock_dbg() messages +ifeq ($(MEMBLOCK_DEBUG), 1) + CFLAGS +=3D -D MEMBLOCK_DEBUG +endif --=20 2.34.1 From nobody Sun Apr 26 21:37:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEFA6C433EF for ; Wed, 22 Jun 2022 09:29:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357227AbiFVJ3q (ORCPT ); Wed, 22 Jun 2022 05:29:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354548AbiFVJ3d (ORCPT ); Wed, 22 Jun 2022 05:29:33 -0400 Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C36A39156 for ; Wed, 22 Jun 2022 02:29:23 -0700 (PDT) Received: by mail-oi1-x242.google.com with SMTP id s124so20469518oia.0 for ; Wed, 22 Jun 2022 02:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NjEJw8V66v+QBo+QSP0shtQ8MR8Th49KB/OkiTXLCOw=; b=EwJFusfH61kBtuxy4yjUDjRmCcXG89VXbk2r2I5JIf6fcKtkHow1NhZKzWvl5tUJI0 HO2PJQ9Y5Sc/Xs+pXNGJriSQPrZm0AxpBKP7779QrPD62rpXBufHOa2ZXq429fd7OjWs IPUIK8WcAx04UHcAonEkdQ6Q1VBybDMuWIvdbU15eZz/JsaPhsf8E1wYBdczNu1U7+Iz qDTxBiacArEw47cR161cyFKq0xCXhGeGdYfHPKijp0Lmu9Yl1htsaoTjgQkeRxz2T78K ZilyQeDw9X+DJgf0H8The+l6CJGPDrdWVys9oDe52EUaKAyJmwEYW7Re6poASZlzbLlx IrKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NjEJw8V66v+QBo+QSP0shtQ8MR8Th49KB/OkiTXLCOw=; b=51scyJ0uKlQO6mPYuD3b+Ei4pVnSL2CJ317IgSUG7S+8gUoKZnXXCbzxjdLdqBEHht DQSblF7KZnEjq+UjRfaiRjfCD0pG7J+aL4cynZexG9S8h+oOFSdmX13obuYTNf/Ay2eB ASKA3yI3CiUhKuWxMU5e1pjmqE+BNDFoA3oFI37xiQ3r2KsHsGca95/BDhlBrIifK00g B+a9v9rO2zCMIei8nifeFkEKWTFfy8LJt5aOWXtvaC0wdQDGcjW7X38nO2MrwHaPx4/7 +rPKX9QjZ0LZSjguI9JVaKfkbqVFUagXQ53HwW/FjMK+mrjurqj4STUGasYkHE//V+6m RMPQ== X-Gm-Message-State: AOAM532trC1wD2jc9Y486dv239c2tgNEEfo4OQkdx8p7qkCTkFvCaSzm 5XVQfarDbnE8j6DSCJ/ExXE= X-Google-Smtp-Source: ABdhPJyEG35PEx76HLbDgaEBQRo8SAILg4hW8caVl+m7zcLQ9UJkCw9teYAciyy53HE9HBwFIWXbaQ== X-Received: by 2002:a05:6808:11c2:b0:2f9:b58f:5ac7 with SMTP id p2-20020a05680811c200b002f9b58f5ac7mr22656879oiv.132.1655890162035; Wed, 22 Jun 2022 02:29:22 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id j200-20020acaebd1000000b0032e7205619asm10653102oih.15.2022.06.22.02.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 02:29:21 -0700 (PDT) From: Rebecca Mckeever To: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand , Rebecca Mckeever Subject: [PATCH v3 2/4] memblock tests: add verbose output to memblock tests Date: Wed, 22 Jun 2022 04:29:07 -0500 Message-Id: <004e021cc3cb7be8749361b3b1cb324459b9cb9f.1655889641.git.remckee0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add and use functions for printing verbose testing output. If the Memblock simulator was compiled with VERBOSE=3D1: prefix_push() appends the given string to a prefix string that will be printed in the test functions. prefix_pop() removes the last prefix from the prefix string. prefix_reset() clears the prefix string. test_fail() prints a message after a test fails containing the test number of the failing test and the prefix. test_pass() prints a message after a test passes containing its test number and the prefix. test_print() prints the given formatted output string. If the Memblock simulator was not compiled with VERBOSE=3D1, these functions do nothing. Add the assert wrapper macros ASSERT_EQ(), ASSERT_NE(), and ASSERT_LT(). If the assert condition fails, these macros call test_fail() before executing assert(). Signed-off-by: Rebecca Mckeever --- tools/testing/memblock/tests/alloc_api.c | 241 ++++++++---- .../memblock/tests/alloc_helpers_api.c | 135 +++++-- tools/testing/memblock/tests/alloc_nid_api.c | 371 ++++++++++++------ tools/testing/memblock/tests/basic_api.c | 365 ++++++++++++----- tools/testing/memblock/tests/common.c | 58 +++ tools/testing/memblock/tests/common.h | 54 +++ 6 files changed, 880 insertions(+), 344 deletions(-) diff --git a/tools/testing/memblock/tests/alloc_api.c b/tools/testing/membl= ock/tests/alloc_api.c index d1aa7e15c18d..96df033d4300 100644 --- a/tools/testing/memblock/tests/alloc_api.c +++ b/tools/testing/memblock/tests/alloc_api.c @@ -10,6 +10,8 @@ static int alloc_top_down_simple_check(void) struct memblock_region *rgn =3D &memblock.reserved.regions[0]; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_2; phys_addr_t expected_start; =20 @@ -19,12 +21,15 @@ static int alloc_top_down_simple_check(void) =20 allocated_ptr =3D memblock_alloc(size, SMP_CACHE_BYTES); =20 - assert(allocated_ptr); - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D expected_start); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, expected_start); + + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -55,6 +60,8 @@ static int alloc_top_down_disjoint_check(void) struct region r1; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t r2_size =3D SZ_16; /* Use custom alignment */ phys_addr_t alignment =3D SMP_CACHE_BYTES * 2; @@ -73,15 +80,18 @@ static int alloc_top_down_disjoint_check(void) =20 allocated_ptr =3D memblock_alloc(r2_size, alignment); =20 - assert(allocated_ptr); - assert(rgn1->size =3D=3D r1.size); - assert(rgn1->base =3D=3D r1.base); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn1->size, r1.size); + ASSERT_EQ(rgn1->base, r1.base); =20 - assert(rgn2->size =3D=3D r2_size); - assert(rgn2->base =3D=3D expected_start); + ASSERT_EQ(rgn2->size, r2_size); + ASSERT_EQ(rgn2->base, expected_start); =20 - assert(memblock.reserved.cnt =3D=3D 2); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 2); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -101,6 +111,8 @@ static int alloc_top_down_before_check(void) struct memblock_region *rgn =3D &memblock.reserved.regions[0]; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + /* * The first region ends at the aligned address to test region merging */ @@ -114,12 +126,15 @@ static int alloc_top_down_before_check(void) =20 allocated_ptr =3D memblock_alloc(r2_size, SMP_CACHE_BYTES); =20 - assert(allocated_ptr); - assert(rgn->size =3D=3D total_size); - assert(rgn->base =3D=3D memblock_end_of_DRAM() - total_size); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->size, total_size); + ASSERT_EQ(rgn->base, memblock_end_of_DRAM() - total_size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -141,6 +156,8 @@ static int alloc_top_down_after_check(void) struct region r1; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t r2_size =3D SZ_512; phys_addr_t total_size; =20 @@ -158,12 +175,15 @@ static int alloc_top_down_after_check(void) =20 allocated_ptr =3D memblock_alloc(r2_size, SMP_CACHE_BYTES); =20 - assert(allocated_ptr); - assert(rgn->size =3D=3D total_size); - assert(rgn->base =3D=3D r1.base - r2_size); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->size, total_size); + ASSERT_EQ(rgn->base, r1.base - r2_size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -186,6 +206,8 @@ static int alloc_top_down_second_fit_check(void) struct region r1, r2; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t r3_size =3D SZ_1K; phys_addr_t total_size; =20 @@ -204,12 +226,15 @@ static int alloc_top_down_second_fit_check(void) =20 allocated_ptr =3D memblock_alloc(r3_size, SMP_CACHE_BYTES); =20 - assert(allocated_ptr); - assert(rgn->size =3D=3D r2.size + r3_size); - assert(rgn->base =3D=3D r2.base - r3_size); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->size, r2.size + r3_size); + ASSERT_EQ(rgn->base, r2.base - r3_size); =20 - assert(memblock.reserved.cnt =3D=3D 2); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 2); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -231,6 +256,8 @@ static int alloc_in_between_generic_check(void) struct region r1, r2; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t gap_size =3D SMP_CACHE_BYTES; phys_addr_t r3_size =3D SZ_64; /* @@ -254,12 +281,15 @@ static int alloc_in_between_generic_check(void) =20 allocated_ptr =3D memblock_alloc(r3_size, SMP_CACHE_BYTES); =20 - assert(allocated_ptr); - assert(rgn->size =3D=3D total_size); - assert(rgn->base =3D=3D r1.base - r2.size - r3_size); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->size, total_size); + ASSERT_EQ(rgn->base, r1.base - r2.size - r3_size); + + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, total_size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D total_size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -281,6 +311,8 @@ static int alloc_small_gaps_generic_check(void) { void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t region_size =3D SZ_1K; phys_addr_t gap_size =3D SZ_256; phys_addr_t region_end; @@ -296,7 +328,10 @@ static int alloc_small_gaps_generic_check(void) =20 allocated_ptr =3D memblock_alloc(region_size, SMP_CACHE_BYTES); =20 - assert(!allocated_ptr); + ASSERT_EQ(allocated_ptr, NULL); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -309,6 +344,8 @@ static int alloc_all_reserved_generic_check(void) { void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + setup_memblock(); =20 /* Simulate full memory */ @@ -316,7 +353,10 @@ static int alloc_all_reserved_generic_check(void) =20 allocated_ptr =3D memblock_alloc(SZ_256, SMP_CACHE_BYTES); =20 - assert(!allocated_ptr); + ASSERT_EQ(allocated_ptr, NULL); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -338,6 +378,8 @@ static int alloc_no_space_generic_check(void) { void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + setup_memblock(); =20 phys_addr_t available_size =3D SZ_256; @@ -348,7 +390,10 @@ static int alloc_no_space_generic_check(void) =20 allocated_ptr =3D memblock_alloc(SZ_1K, SMP_CACHE_BYTES); =20 - assert(!allocated_ptr); + ASSERT_EQ(allocated_ptr, NULL); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -369,6 +414,8 @@ static int alloc_limited_space_generic_check(void) struct memblock_region *rgn =3D &memblock.reserved.regions[0]; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t available_size =3D SZ_256; phys_addr_t reserved_size =3D MEM_SIZE - available_size; =20 @@ -379,12 +426,15 @@ static int alloc_limited_space_generic_check(void) =20 allocated_ptr =3D memblock_alloc(available_size, SMP_CACHE_BYTES); =20 - assert(allocated_ptr); - assert(rgn->size =3D=3D MEM_SIZE); - assert(rgn->base =3D=3D memblock_start_of_DRAM()); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->size, MEM_SIZE); + ASSERT_EQ(rgn->base, memblock_start_of_DRAM()); + + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, MEM_SIZE); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D MEM_SIZE); + test_pass(); + prefix_pop(); =20 return 0; } @@ -399,14 +449,19 @@ static int alloc_no_memory_generic_check(void) struct memblock_region *rgn =3D &memblock.reserved.regions[0]; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + reset_memblock_regions(); =20 allocated_ptr =3D memblock_alloc(SZ_1K, SMP_CACHE_BYTES); =20 - assert(!allocated_ptr); - assert(rgn->size =3D=3D 0); - assert(rgn->base =3D=3D 0); - assert(memblock.reserved.total_size =3D=3D 0); + ASSERT_EQ(allocated_ptr, NULL); + ASSERT_EQ(rgn->size, 0); + ASSERT_EQ(rgn->base, 0); + ASSERT_EQ(memblock.reserved.total_size, 0); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -421,16 +476,21 @@ static int alloc_bottom_up_simple_check(void) struct memblock_region *rgn =3D &memblock.reserved.regions[0]; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + setup_memblock(); =20 allocated_ptr =3D memblock_alloc(SZ_2, SMP_CACHE_BYTES); =20 - assert(allocated_ptr); - assert(rgn->size =3D=3D SZ_2); - assert(rgn->base =3D=3D memblock_start_of_DRAM()); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->size, SZ_2); + ASSERT_EQ(rgn->base, memblock_start_of_DRAM()); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D SZ_2); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, SZ_2); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -459,6 +519,8 @@ static int alloc_bottom_up_disjoint_check(void) struct region r1; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t r2_size =3D SZ_16; /* Use custom alignment */ phys_addr_t alignment =3D SMP_CACHE_BYTES * 2; @@ -477,16 +539,19 @@ static int alloc_bottom_up_disjoint_check(void) =20 allocated_ptr =3D memblock_alloc(r2_size, alignment); =20 - assert(allocated_ptr); + ASSERT_NE(allocated_ptr, NULL); =20 - assert(rgn1->size =3D=3D r1.size); - assert(rgn1->base =3D=3D r1.base); + ASSERT_EQ(rgn1->size, r1.size); + ASSERT_EQ(rgn1->base, r1.base); =20 - assert(rgn2->size =3D=3D r2_size); - assert(rgn2->base =3D=3D expected_start); + ASSERT_EQ(rgn2->size, r2_size); + ASSERT_EQ(rgn2->base, expected_start); =20 - assert(memblock.reserved.cnt =3D=3D 2); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 2); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -506,6 +571,8 @@ static int alloc_bottom_up_before_check(void) struct memblock_region *rgn =3D &memblock.reserved.regions[0]; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t r1_size =3D SZ_512; phys_addr_t r2_size =3D SZ_128; phys_addr_t total_size =3D r1_size + r2_size; @@ -516,12 +583,15 @@ static int alloc_bottom_up_before_check(void) =20 allocated_ptr =3D memblock_alloc(r1_size, SMP_CACHE_BYTES); =20 - assert(allocated_ptr); - assert(rgn->size =3D=3D total_size); - assert(rgn->base =3D=3D memblock_start_of_DRAM()); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->size, total_size); + ASSERT_EQ(rgn->base, memblock_start_of_DRAM()); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -542,6 +612,8 @@ static int alloc_bottom_up_after_check(void) struct region r1; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t r2_size =3D SZ_512; phys_addr_t total_size; =20 @@ -559,12 +631,15 @@ static int alloc_bottom_up_after_check(void) =20 allocated_ptr =3D memblock_alloc(r2_size, SMP_CACHE_BYTES); =20 - assert(allocated_ptr); - assert(rgn->size =3D=3D total_size); - assert(rgn->base =3D=3D r1.base); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->size, total_size); + ASSERT_EQ(rgn->base, r1.base); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -588,6 +663,8 @@ static int alloc_bottom_up_second_fit_check(void) struct region r1, r2; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t r3_size =3D SZ_1K; phys_addr_t total_size; =20 @@ -606,12 +683,15 @@ static int alloc_bottom_up_second_fit_check(void) =20 allocated_ptr =3D memblock_alloc(r3_size, SMP_CACHE_BYTES); =20 - assert(allocated_ptr); - assert(rgn->size =3D=3D r2.size + r3_size); - assert(rgn->base =3D=3D r2.base); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->size, r2.size + r3_size); + ASSERT_EQ(rgn->base, r2.base); =20 - assert(memblock.reserved.cnt =3D=3D 2); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 2); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -619,6 +699,7 @@ static int alloc_bottom_up_second_fit_check(void) /* Test case wrappers */ static int alloc_simple_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_top_down_simple_check(); memblock_set_bottom_up(true); @@ -629,6 +710,7 @@ static int alloc_simple_check(void) =20 static int alloc_disjoint_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_top_down_disjoint_check(); memblock_set_bottom_up(true); @@ -639,6 +721,7 @@ static int alloc_disjoint_check(void) =20 static int alloc_before_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_top_down_before_check(); memblock_set_bottom_up(true); @@ -649,6 +732,7 @@ static int alloc_before_check(void) =20 static int alloc_after_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_top_down_after_check(); memblock_set_bottom_up(true); @@ -659,6 +743,7 @@ static int alloc_after_check(void) =20 static int alloc_in_between_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_in_between_generic_check(); memblock_set_bottom_up(true); @@ -669,6 +754,7 @@ static int alloc_in_between_check(void) =20 static int alloc_second_fit_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_top_down_second_fit_check(); memblock_set_bottom_up(true); @@ -679,6 +765,7 @@ static int alloc_second_fit_check(void) =20 static int alloc_small_gaps_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_small_gaps_generic_check(); memblock_set_bottom_up(true); @@ -689,6 +776,7 @@ static int alloc_small_gaps_check(void) =20 static int alloc_all_reserved_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_all_reserved_generic_check(); memblock_set_bottom_up(true); @@ -699,6 +787,7 @@ static int alloc_all_reserved_check(void) =20 static int alloc_no_space_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_no_space_generic_check(); memblock_set_bottom_up(true); @@ -709,6 +798,7 @@ static int alloc_no_space_check(void) =20 static int alloc_limited_space_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_limited_space_generic_check(); memblock_set_bottom_up(true); @@ -719,6 +809,7 @@ static int alloc_limited_space_check(void) =20 static int alloc_no_memory_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_no_memory_generic_check(); memblock_set_bottom_up(true); @@ -729,6 +820,12 @@ static int alloc_no_memory_check(void) =20 int memblock_alloc_checks(void) { + static const char func_testing[] =3D "memblock_alloc"; + + prefix_reset(); + prefix_push(func_testing); + test_print("Running %s tests...\n", func_testing); + reset_memblock_attributes(); dummy_physical_memory_init(); =20 @@ -746,5 +843,7 @@ int memblock_alloc_checks(void) =20 dummy_physical_memory_cleanup(); =20 + prefix_pop(); + return 0; } diff --git a/tools/testing/memblock/tests/alloc_helpers_api.c b/tools/testi= ng/memblock/tests/alloc_helpers_api.c index 963a966db461..f6eaed540427 100644 --- a/tools/testing/memblock/tests/alloc_helpers_api.c +++ b/tools/testing/memblock/tests/alloc_helpers_api.c @@ -21,6 +21,8 @@ static int alloc_from_simple_generic_check(void) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_16; phys_addr_t min_addr; =20 @@ -31,14 +33,17 @@ static int alloc_from_simple_generic_check(void) allocated_ptr =3D memblock_alloc_from(size, SMP_CACHE_BYTES, min_addr); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); + + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, min_addr); =20 - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D min_addr); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -64,6 +69,8 @@ static int alloc_from_misaligned_generic_check(void) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_32; phys_addr_t min_addr; =20 @@ -75,14 +82,17 @@ static int alloc_from_misaligned_generic_check(void) allocated_ptr =3D memblock_alloc_from(size, SMP_CACHE_BYTES, min_addr); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); =20 - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D memblock_end_of_DRAM() - SMP_CACHE_BYTES); + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, memblock_end_of_DRAM() - SMP_CACHE_BYTES); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -110,6 +120,8 @@ static int alloc_from_top_down_high_addr_check(void) struct memblock_region *rgn =3D &memblock.reserved.regions[0]; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_32; phys_addr_t min_addr; =20 @@ -120,12 +132,15 @@ static int alloc_from_top_down_high_addr_check(void) =20 allocated_ptr =3D memblock_alloc_from(size, SMP_CACHE_BYTES, min_addr); =20 - assert(allocated_ptr); - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D memblock_end_of_DRAM() - SMP_CACHE_BYTES); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, memblock_end_of_DRAM() - SMP_CACHE_BYTES); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -151,6 +166,8 @@ static int alloc_from_top_down_no_space_above_check(voi= d) struct memblock_region *rgn =3D &memblock.reserved.regions[0]; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t r1_size =3D SZ_64; phys_addr_t r2_size =3D SZ_2; phys_addr_t total_size =3D r1_size + r2_size; @@ -165,12 +182,15 @@ static int alloc_from_top_down_no_space_above_check(v= oid) =20 allocated_ptr =3D memblock_alloc_from(r1_size, SMP_CACHE_BYTES, min_addr); =20 - assert(allocated_ptr); - assert(rgn->base =3D=3D min_addr - r1_size); - assert(rgn->size =3D=3D total_size); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->base, min_addr - r1_size); + ASSERT_EQ(rgn->size, total_size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -186,6 +206,8 @@ static int alloc_from_top_down_min_addr_cap_check(void) struct memblock_region *rgn =3D &memblock.reserved.regions[0]; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t r1_size =3D SZ_64; phys_addr_t min_addr; phys_addr_t start_addr; @@ -199,12 +221,15 @@ static int alloc_from_top_down_min_addr_cap_check(voi= d) =20 allocated_ptr =3D memblock_alloc_from(r1_size, SMP_CACHE_BYTES, min_addr); =20 - assert(allocated_ptr); - assert(rgn->base =3D=3D start_addr); - assert(rgn->size =3D=3D MEM_SIZE); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->base, start_addr); + ASSERT_EQ(rgn->size, MEM_SIZE); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D MEM_SIZE); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, MEM_SIZE); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -230,6 +255,8 @@ static int alloc_from_bottom_up_high_addr_check(void) struct memblock_region *rgn =3D &memblock.reserved.regions[0]; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_32; phys_addr_t min_addr; =20 @@ -240,12 +267,15 @@ static int alloc_from_bottom_up_high_addr_check(void) =20 allocated_ptr =3D memblock_alloc_from(size, SMP_CACHE_BYTES, min_addr); =20 - assert(allocated_ptr); - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D memblock_start_of_DRAM()); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, memblock_start_of_DRAM()); + + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -270,6 +300,8 @@ static int alloc_from_bottom_up_no_space_above_check(vo= id) struct memblock_region *rgn =3D &memblock.reserved.regions[0]; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t r1_size =3D SZ_64; phys_addr_t min_addr; phys_addr_t r2_size; @@ -284,12 +316,15 @@ static int alloc_from_bottom_up_no_space_above_check(= void) =20 allocated_ptr =3D memblock_alloc_from(r1_size, SMP_CACHE_BYTES, min_addr); =20 - assert(allocated_ptr); - assert(rgn->base =3D=3D memblock_start_of_DRAM()); - assert(rgn->size =3D=3D r1_size); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->base, memblock_start_of_DRAM()); + ASSERT_EQ(rgn->size, r1_size); + + ASSERT_EQ(memblock.reserved.cnt, 2); + ASSERT_EQ(memblock.reserved.total_size, r1_size + r2_size); =20 - assert(memblock.reserved.cnt =3D=3D 2); - assert(memblock.reserved.total_size =3D=3D r1_size + r2_size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -304,6 +339,8 @@ static int alloc_from_bottom_up_min_addr_cap_check(void) struct memblock_region *rgn =3D &memblock.reserved.regions[0]; void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t r1_size =3D SZ_64; phys_addr_t min_addr; phys_addr_t start_addr; @@ -315,12 +352,15 @@ static int alloc_from_bottom_up_min_addr_cap_check(vo= id) =20 allocated_ptr =3D memblock_alloc_from(r1_size, SMP_CACHE_BYTES, min_addr); =20 - assert(allocated_ptr); - assert(rgn->base =3D=3D start_addr); - assert(rgn->size =3D=3D r1_size); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(rgn->base, start_addr); + ASSERT_EQ(rgn->size, r1_size); + + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, r1_size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D r1_size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -328,6 +368,7 @@ static int alloc_from_bottom_up_min_addr_cap_check(void) /* Test case wrappers */ static int alloc_from_simple_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_from_simple_generic_check(); memblock_set_bottom_up(true); @@ -338,6 +379,7 @@ static int alloc_from_simple_check(void) =20 static int alloc_from_misaligned_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_from_misaligned_generic_check(); memblock_set_bottom_up(true); @@ -348,6 +390,7 @@ static int alloc_from_misaligned_check(void) =20 static int alloc_from_high_addr_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_from_top_down_high_addr_check(); memblock_set_bottom_up(true); @@ -358,6 +401,7 @@ static int alloc_from_high_addr_check(void) =20 static int alloc_from_no_space_above_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_from_top_down_no_space_above_check(); memblock_set_bottom_up(true); @@ -368,6 +412,7 @@ static int alloc_from_no_space_above_check(void) =20 static int alloc_from_min_addr_cap_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_from_top_down_min_addr_cap_check(); memblock_set_bottom_up(true); @@ -378,6 +423,12 @@ static int alloc_from_min_addr_cap_check(void) =20 int memblock_alloc_helpers_checks(void) { + static const char func_testing[] =3D "memblock_alloc_from"; + + prefix_reset(); + prefix_push(func_testing); + test_print("Running %s tests...\n", func_testing); + reset_memblock_attributes(); dummy_physical_memory_init(); =20 diff --git a/tools/testing/memblock/tests/alloc_nid_api.c b/tools/testing/m= emblock/tests/alloc_nid_api.c index 6390206e50e1..601f4a7ee30d 100644 --- a/tools/testing/memblock/tests/alloc_nid_api.c +++ b/tools/testing/memblock/tests/alloc_nid_api.c @@ -21,6 +21,8 @@ static int alloc_try_nid_top_down_simple_check(void) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_128; phys_addr_t min_addr; phys_addr_t max_addr; @@ -36,15 +38,18 @@ static int alloc_try_nid_top_down_simple_check(void) b =3D (char *)allocated_ptr; rgn_end =3D rgn->base + rgn->size; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); + + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, max_addr - size); + ASSERT_EQ(rgn_end, max_addr); =20 - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D max_addr - size); - assert(rgn_end =3D=3D max_addr); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -72,6 +77,8 @@ static int alloc_try_nid_top_down_end_misaligned_check(vo= id) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_128; phys_addr_t misalign =3D SZ_2; phys_addr_t min_addr; @@ -88,15 +95,18 @@ static int alloc_try_nid_top_down_end_misaligned_check(= void) b =3D (char *)allocated_ptr; rgn_end =3D rgn->base + rgn->size; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); =20 - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D max_addr - size - misalign); - assert(rgn_end < max_addr); + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, max_addr - size - misalign); + ASSERT_LT(rgn_end, max_addr); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -122,6 +132,8 @@ static int alloc_try_nid_exact_address_generic_check(vo= id) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_1K; phys_addr_t min_addr; phys_addr_t max_addr; @@ -137,15 +149,18 @@ static int alloc_try_nid_exact_address_generic_check(= void) b =3D (char *)allocated_ptr; rgn_end =3D rgn->base + rgn->size; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); + + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, min_addr); + ASSERT_EQ(rgn_end, max_addr); =20 - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D min_addr); - assert(rgn_end =3D=3D max_addr); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -173,6 +188,8 @@ static int alloc_try_nid_top_down_narrow_range_check(vo= id) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_256; phys_addr_t min_addr; phys_addr_t max_addr; @@ -186,14 +203,17 @@ static int alloc_try_nid_top_down_narrow_range_check(= void) min_addr, max_addr, NUMA_NO_NODE); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); + + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, max_addr - size); =20 - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D max_addr - size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -222,6 +242,8 @@ static int alloc_try_nid_low_max_generic_check(void) { void *allocated_ptr =3D NULL; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_1K; phys_addr_t min_addr; phys_addr_t max_addr; @@ -234,7 +256,10 @@ static int alloc_try_nid_low_max_generic_check(void) allocated_ptr =3D memblock_alloc_try_nid(size, SMP_CACHE_BYTES, min_addr, max_addr, NUMA_NO_NODE); =20 - assert(!allocated_ptr); + ASSERT_EQ(allocated_ptr, NULL); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -259,6 +284,8 @@ static int alloc_try_nid_min_reserved_generic_check(voi= d) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t r1_size =3D SZ_128; phys_addr_t r2_size =3D SZ_64; phys_addr_t total_size =3D r1_size + r2_size; @@ -278,14 +305,17 @@ static int alloc_try_nid_min_reserved_generic_check(v= oid) min_addr, max_addr, NUMA_NO_NODE); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); =20 - assert(rgn->size =3D=3D total_size); - assert(rgn->base =3D=3D reserved_base); + ASSERT_EQ(rgn->size, total_size); + ASSERT_EQ(rgn->base, reserved_base); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -310,6 +340,8 @@ static int alloc_try_nid_max_reserved_generic_check(voi= d) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t r1_size =3D SZ_64; phys_addr_t r2_size =3D SZ_128; phys_addr_t total_size =3D r1_size + r2_size; @@ -327,14 +359,17 @@ static int alloc_try_nid_max_reserved_generic_check(v= oid) min_addr, max_addr, NUMA_NO_NODE); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); + + ASSERT_EQ(rgn->size, total_size); + ASSERT_EQ(rgn->base, min_addr); =20 - assert(rgn->size =3D=3D total_size); - assert(rgn->base =3D=3D min_addr); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, total_size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D total_size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -364,6 +399,8 @@ static int alloc_try_nid_top_down_reserved_with_space_c= heck(void) char *b; struct region r1, r2; =20 + prefix_push(__func__); + phys_addr_t r3_size =3D SZ_64; phys_addr_t gap_size =3D SMP_CACHE_BYTES; phys_addr_t total_size; @@ -389,17 +426,20 @@ static int alloc_try_nid_top_down_reserved_with_space= _check(void) min_addr, max_addr, NUMA_NO_NODE); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); + + ASSERT_EQ(rgn1->size, r1.size + r3_size); + ASSERT_EQ(rgn1->base, max_addr - r3_size); =20 - assert(rgn1->size =3D=3D r1.size + r3_size); - assert(rgn1->base =3D=3D max_addr - r3_size); + ASSERT_EQ(rgn2->size, r2.size); + ASSERT_EQ(rgn2->base, r2.base); =20 - assert(rgn2->size =3D=3D r2.size); - assert(rgn2->base =3D=3D r2.base); + ASSERT_EQ(memblock.reserved.cnt, 2); + ASSERT_EQ(memblock.reserved.total_size, total_size); =20 - assert(memblock.reserved.cnt =3D=3D 2); - assert(memblock.reserved.total_size =3D=3D total_size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -427,6 +467,8 @@ static int alloc_try_nid_reserved_full_merge_generic_ch= eck(void) char *b; struct region r1, r2; =20 + prefix_push(__func__); + phys_addr_t r3_size =3D SZ_64; phys_addr_t total_size; phys_addr_t max_addr; @@ -451,14 +493,17 @@ static int alloc_try_nid_reserved_full_merge_generic_= check(void) min_addr, max_addr, NUMA_NO_NODE); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); =20 - assert(rgn->size =3D=3D total_size); - assert(rgn->base =3D=3D r2.base); + ASSERT_EQ(rgn->size, total_size); + ASSERT_EQ(rgn->base, r2.base); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -489,6 +534,8 @@ static int alloc_try_nid_top_down_reserved_no_space_che= ck(void) char *b; struct region r1, r2; =20 + prefix_push(__func__); + phys_addr_t r3_size =3D SZ_256; phys_addr_t gap_size =3D SMP_CACHE_BYTES; phys_addr_t total_size; @@ -514,17 +561,20 @@ static int alloc_try_nid_top_down_reserved_no_space_c= heck(void) min_addr, max_addr, NUMA_NO_NODE); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); + + ASSERT_EQ(rgn1->size, r1.size); + ASSERT_EQ(rgn1->base, r1.base); =20 - assert(rgn1->size =3D=3D r1.size); - assert(rgn1->base =3D=3D r1.base); + ASSERT_EQ(rgn2->size, r2.size + r3_size); + ASSERT_EQ(rgn2->base, r2.base - r3_size); =20 - assert(rgn2->size =3D=3D r2.size + r3_size); - assert(rgn2->base =3D=3D r2.base - r3_size); + ASSERT_EQ(memblock.reserved.cnt, 2); + ASSERT_EQ(memblock.reserved.total_size, total_size); =20 - assert(memblock.reserved.cnt =3D=3D 2); - assert(memblock.reserved.total_size =3D=3D total_size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -554,6 +604,8 @@ static int alloc_try_nid_reserved_all_generic_check(voi= d) void *allocated_ptr =3D NULL; struct region r1, r2; =20 + prefix_push(__func__); + phys_addr_t r3_size =3D SZ_256; phys_addr_t gap_size =3D SMP_CACHE_BYTES; phys_addr_t max_addr; @@ -576,7 +628,10 @@ static int alloc_try_nid_reserved_all_generic_check(vo= id) allocated_ptr =3D memblock_alloc_try_nid(r3_size, SMP_CACHE_BYTES, min_addr, max_addr, NUMA_NO_NODE); =20 - assert(!allocated_ptr); + ASSERT_EQ(allocated_ptr, NULL); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -592,6 +647,8 @@ static int alloc_try_nid_top_down_cap_max_check(void) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_256; phys_addr_t min_addr; phys_addr_t max_addr; @@ -605,14 +662,17 @@ static int alloc_try_nid_top_down_cap_max_check(void) min_addr, max_addr, NUMA_NO_NODE); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); + + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, memblock_end_of_DRAM() - size); =20 - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D memblock_end_of_DRAM() - size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -628,6 +688,8 @@ static int alloc_try_nid_top_down_cap_min_check(void) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_1K; phys_addr_t min_addr; phys_addr_t max_addr; @@ -641,14 +703,17 @@ static int alloc_try_nid_top_down_cap_min_check(void) min_addr, max_addr, NUMA_NO_NODE); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); =20 - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D memblock_end_of_DRAM() - size); + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, memblock_end_of_DRAM() - size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -673,6 +738,8 @@ static int alloc_try_nid_bottom_up_simple_check(void) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_128; phys_addr_t min_addr; phys_addr_t max_addr; @@ -689,15 +756,18 @@ static int alloc_try_nid_bottom_up_simple_check(void) b =3D (char *)allocated_ptr; rgn_end =3D rgn->base + rgn->size; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); + + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, min_addr); + ASSERT_LT(rgn_end, max_addr); =20 - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D min_addr); - assert(rgn_end < max_addr); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -725,6 +795,8 @@ static int alloc_try_nid_bottom_up_start_misaligned_che= ck(void) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_128; phys_addr_t misalign =3D SZ_2; phys_addr_t min_addr; @@ -742,15 +814,18 @@ static int alloc_try_nid_bottom_up_start_misaligned_c= heck(void) b =3D (char *)allocated_ptr; rgn_end =3D rgn->base + rgn->size; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); + + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, min_addr + (SMP_CACHE_BYTES - misalign)); + ASSERT_LT(rgn_end, max_addr); =20 - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D min_addr + (SMP_CACHE_BYTES - misalign)); - assert(rgn_end < max_addr); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -778,6 +853,8 @@ static int alloc_try_nid_bottom_up_narrow_range_check(v= oid) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_256; phys_addr_t min_addr; phys_addr_t max_addr; @@ -792,14 +869,17 @@ static int alloc_try_nid_bottom_up_narrow_range_check= (void) NUMA_NO_NODE); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); =20 - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D memblock_start_of_DRAM()); + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, memblock_start_of_DRAM()); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -829,6 +909,8 @@ static int alloc_try_nid_bottom_up_reserved_with_space_= check(void) char *b; struct region r1, r2; =20 + prefix_push(__func__); + phys_addr_t r3_size =3D SZ_64; phys_addr_t gap_size =3D SMP_CACHE_BYTES; phys_addr_t total_size; @@ -855,17 +937,20 @@ static int alloc_try_nid_bottom_up_reserved_with_spac= e_check(void) NUMA_NO_NODE); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); =20 - assert(rgn1->size =3D=3D r1.size); - assert(rgn1->base =3D=3D max_addr); + ASSERT_EQ(rgn1->size, r1.size); + ASSERT_EQ(rgn1->base, max_addr); =20 - assert(rgn2->size =3D=3D r2.size + r3_size); - assert(rgn2->base =3D=3D r2.base); + ASSERT_EQ(rgn2->size, r2.size + r3_size); + ASSERT_EQ(rgn2->base, r2.base); =20 - assert(memblock.reserved.cnt =3D=3D 2); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 2); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -899,6 +984,8 @@ static int alloc_try_nid_bottom_up_reserved_no_space_ch= eck(void) char *b; struct region r1, r2; =20 + prefix_push(__func__); + phys_addr_t r3_size =3D SZ_256; phys_addr_t gap_size =3D SMP_CACHE_BYTES; phys_addr_t total_size; @@ -925,20 +1012,23 @@ static int alloc_try_nid_bottom_up_reserved_no_space= _check(void) NUMA_NO_NODE); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); + + ASSERT_EQ(rgn3->size, r3_size); + ASSERT_EQ(rgn3->base, memblock_start_of_DRAM()); =20 - assert(rgn3->size =3D=3D r3_size); - assert(rgn3->base =3D=3D memblock_start_of_DRAM()); + ASSERT_EQ(rgn2->size, r2.size); + ASSERT_EQ(rgn2->base, r2.base); =20 - assert(rgn2->size =3D=3D r2.size); - assert(rgn2->base =3D=3D r2.base); + ASSERT_EQ(rgn1->size, r1.size); + ASSERT_EQ(rgn1->base, r1.base); =20 - assert(rgn1->size =3D=3D r1.size); - assert(rgn1->base =3D=3D r1.base); + ASSERT_EQ(memblock.reserved.cnt, 3); + ASSERT_EQ(memblock.reserved.total_size, total_size); =20 - assert(memblock.reserved.cnt =3D=3D 3); - assert(memblock.reserved.total_size =3D=3D total_size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -954,6 +1044,8 @@ static int alloc_try_nid_bottom_up_cap_max_check(void) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_256; phys_addr_t min_addr; phys_addr_t max_addr; @@ -968,14 +1060,17 @@ static int alloc_try_nid_bottom_up_cap_max_check(voi= d) NUMA_NO_NODE); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); + + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, min_addr); =20 - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D min_addr); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -991,6 +1086,8 @@ static int alloc_try_nid_bottom_up_cap_min_check(void) void *allocated_ptr =3D NULL; char *b; =20 + prefix_push(__func__); + phys_addr_t size =3D SZ_1K; phys_addr_t min_addr; phys_addr_t max_addr; @@ -1005,14 +1102,17 @@ static int alloc_try_nid_bottom_up_cap_min_check(vo= id) NUMA_NO_NODE); b =3D (char *)allocated_ptr; =20 - assert(allocated_ptr); - assert(*b =3D=3D 0); + ASSERT_NE(allocated_ptr, NULL); + ASSERT_EQ(*b, 0); + + ASSERT_EQ(rgn->size, size); + ASSERT_EQ(rgn->base, memblock_start_of_DRAM()); =20 - assert(rgn->size =3D=3D size); - assert(rgn->base =3D=3D memblock_start_of_DRAM()); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -1020,6 +1120,7 @@ static int alloc_try_nid_bottom_up_cap_min_check(void) /* Test case wrappers */ static int alloc_try_nid_simple_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_try_nid_top_down_simple_check(); memblock_set_bottom_up(true); @@ -1030,6 +1131,7 @@ static int alloc_try_nid_simple_check(void) =20 static int alloc_try_nid_misaligned_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_try_nid_top_down_end_misaligned_check(); memblock_set_bottom_up(true); @@ -1040,6 +1142,7 @@ static int alloc_try_nid_misaligned_check(void) =20 static int alloc_try_nid_narrow_range_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_try_nid_top_down_narrow_range_check(); memblock_set_bottom_up(true); @@ -1050,6 +1153,7 @@ static int alloc_try_nid_narrow_range_check(void) =20 static int alloc_try_nid_reserved_with_space_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_try_nid_top_down_reserved_with_space_check(); memblock_set_bottom_up(true); @@ -1060,6 +1164,7 @@ static int alloc_try_nid_reserved_with_space_check(vo= id) =20 static int alloc_try_nid_reserved_no_space_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_try_nid_top_down_reserved_no_space_check(); memblock_set_bottom_up(true); @@ -1070,6 +1175,7 @@ static int alloc_try_nid_reserved_no_space_check(void) =20 static int alloc_try_nid_cap_max_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_try_nid_top_down_cap_max_check(); memblock_set_bottom_up(true); @@ -1080,6 +1186,7 @@ static int alloc_try_nid_cap_max_check(void) =20 static int alloc_try_nid_cap_min_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_try_nid_top_down_cap_min_check(); memblock_set_bottom_up(true); @@ -1090,6 +1197,7 @@ static int alloc_try_nid_cap_min_check(void) =20 static int alloc_try_nid_min_reserved_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_try_nid_min_reserved_generic_check(); memblock_set_bottom_up(true); @@ -1100,6 +1208,7 @@ static int alloc_try_nid_min_reserved_check(void) =20 static int alloc_try_nid_max_reserved_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_try_nid_max_reserved_generic_check(); memblock_set_bottom_up(true); @@ -1110,6 +1219,7 @@ static int alloc_try_nid_max_reserved_check(void) =20 static int alloc_try_nid_exact_address_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_try_nid_exact_address_generic_check(); memblock_set_bottom_up(true); @@ -1120,6 +1230,7 @@ static int alloc_try_nid_exact_address_check(void) =20 static int alloc_try_nid_reserved_full_merge_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_try_nid_reserved_full_merge_generic_check(); memblock_set_bottom_up(true); @@ -1130,6 +1241,7 @@ static int alloc_try_nid_reserved_full_merge_check(vo= id) =20 static int alloc_try_nid_reserved_all_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_try_nid_reserved_all_generic_check(); memblock_set_bottom_up(true); @@ -1140,6 +1252,7 @@ static int alloc_try_nid_reserved_all_check(void) =20 static int alloc_try_nid_low_max_check(void) { + test_print("\tRunning %s...\n", __func__); memblock_set_bottom_up(false); alloc_try_nid_low_max_generic_check(); memblock_set_bottom_up(true); @@ -1150,6 +1263,12 @@ static int alloc_try_nid_low_max_check(void) =20 int memblock_alloc_nid_checks(void) { + static const char func_testing[] =3D "memblock_alloc_try_nid"; + + prefix_reset(); + prefix_push(func_testing); + test_print("Running %s tests...\n", func_testing); + reset_memblock_attributes(); dummy_physical_memory_init(); =20 @@ -1170,5 +1289,7 @@ int memblock_alloc_nid_checks(void) =20 dummy_physical_memory_cleanup(); =20 + prefix_pop(); + return 0; } diff --git a/tools/testing/memblock/tests/basic_api.c b/tools/testing/membl= ock/tests/basic_api.c index a7bc180316d6..f223a9a57be7 100644 --- a/tools/testing/memblock/tests/basic_api.c +++ b/tools/testing/memblock/tests/basic_api.c @@ -4,21 +4,30 @@ #include "basic_api.h" =20 #define EXPECTED_MEMBLOCK_REGIONS 128 +#define FUNC_ADD "memblock_add" +#define FUNC_RESERVE "memblock_reserve" +#define FUNC_REMOVE "memblock_remove" +#define FUNC_FREE "memblock_free" =20 static int memblock_initialization_check(void) { - assert(memblock.memory.regions); - assert(memblock.memory.cnt =3D=3D 1); - assert(memblock.memory.max =3D=3D EXPECTED_MEMBLOCK_REGIONS); - assert(strcmp(memblock.memory.name, "memory") =3D=3D 0); + prefix_push(__func__); =20 - assert(memblock.reserved.regions); - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.memory.max =3D=3D EXPECTED_MEMBLOCK_REGIONS); - assert(strcmp(memblock.reserved.name, "reserved") =3D=3D 0); + ASSERT_NE(memblock.memory.regions, NULL); + ASSERT_EQ(memblock.memory.cnt, 1); + ASSERT_EQ(memblock.memory.max, EXPECTED_MEMBLOCK_REGIONS); + ASSERT_EQ(strcmp(memblock.memory.name, "memory"), 0); =20 - assert(!memblock.bottom_up); - assert(memblock.current_limit =3D=3D MEMBLOCK_ALLOC_ANYWHERE); + ASSERT_NE(memblock.reserved.regions, NULL); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.memory.max, EXPECTED_MEMBLOCK_REGIONS); + ASSERT_EQ(strcmp(memblock.reserved.name, "reserved"), 0); + + ASSERT_EQ(memblock.bottom_up, false); + ASSERT_EQ(memblock.current_limit, MEMBLOCK_ALLOC_ANYWHERE); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -40,14 +49,19 @@ static int memblock_add_simple_check(void) .size =3D SZ_4M }; =20 + prefix_push(__func__); + reset_memblock_regions(); memblock_add(r.base, r.size); =20 - assert(rgn->base =3D=3D r.base); - assert(rgn->size =3D=3D r.size); + ASSERT_EQ(rgn->base, r.base); + ASSERT_EQ(rgn->size, r.size); + + ASSERT_EQ(memblock.memory.cnt, 1); + ASSERT_EQ(memblock.memory.total_size, r.size); =20 - assert(memblock.memory.cnt =3D=3D 1); - assert(memblock.memory.total_size =3D=3D r.size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -69,18 +83,27 @@ static int memblock_add_node_simple_check(void) .size =3D SZ_16M }; =20 + prefix_pop(); + prefix_push("memblock_add_node"); + prefix_push(__func__); + reset_memblock_regions(); memblock_add_node(r.base, r.size, 1, MEMBLOCK_HOTPLUG); =20 - assert(rgn->base =3D=3D r.base); - assert(rgn->size =3D=3D r.size); + ASSERT_EQ(rgn->base, r.base); + ASSERT_EQ(rgn->size, r.size); #ifdef CONFIG_NUMA - assert(rgn->nid =3D=3D 1); + ASSERT_EQ(rgn->nid, 1); #endif - assert(rgn->flags =3D=3D MEMBLOCK_HOTPLUG); + ASSERT_EQ(rgn->flags, MEMBLOCK_HOTPLUG); + + ASSERT_EQ(memblock.memory.cnt, 1); + ASSERT_EQ(memblock.memory.total_size, r.size); =20 - assert(memblock.memory.cnt =3D=3D 1); - assert(memblock.memory.total_size =3D=3D r.size); + test_pass(); + prefix_pop(); + prefix_pop(); + prefix_push(FUNC_ADD); =20 return 0; } @@ -113,18 +136,23 @@ static int memblock_add_disjoint_check(void) .size =3D SZ_8K }; =20 + prefix_push(__func__); + reset_memblock_regions(); memblock_add(r1.base, r1.size); memblock_add(r2.base, r2.size); =20 - assert(rgn1->base =3D=3D r1.base); - assert(rgn1->size =3D=3D r1.size); + ASSERT_EQ(rgn1->base, r1.base); + ASSERT_EQ(rgn1->size, r1.size); + + ASSERT_EQ(rgn2->base, r2.base); + ASSERT_EQ(rgn2->size, r2.size); =20 - assert(rgn2->base =3D=3D r2.base); - assert(rgn2->size =3D=3D r2.size); + ASSERT_EQ(memblock.memory.cnt, 2); + ASSERT_EQ(memblock.memory.total_size, r1.size + r2.size); =20 - assert(memblock.memory.cnt =3D=3D 2); - assert(memblock.memory.total_size =3D=3D r1.size + r2.size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -162,17 +190,22 @@ static int memblock_add_overlap_top_check(void) .size =3D SZ_512M }; =20 + prefix_push(__func__); + total_size =3D (r1.base - r2.base) + r1.size; =20 reset_memblock_regions(); memblock_add(r1.base, r1.size); memblock_add(r2.base, r2.size); =20 - assert(rgn->base =3D=3D r2.base); - assert(rgn->size =3D=3D total_size); + ASSERT_EQ(rgn->base, r2.base); + ASSERT_EQ(rgn->size, total_size); + + ASSERT_EQ(memblock.memory.cnt, 1); + ASSERT_EQ(memblock.memory.total_size, total_size); =20 - assert(memblock.memory.cnt =3D=3D 1); - assert(memblock.memory.total_size =3D=3D total_size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -210,17 +243,22 @@ static int memblock_add_overlap_bottom_check(void) .size =3D SZ_1G }; =20 + prefix_push(__func__); + total_size =3D (r2.base - r1.base) + r2.size; =20 reset_memblock_regions(); memblock_add(r1.base, r1.size); memblock_add(r2.base, r2.size); =20 - assert(rgn->base =3D=3D r1.base); - assert(rgn->size =3D=3D total_size); + ASSERT_EQ(rgn->base, r1.base); + ASSERT_EQ(rgn->size, total_size); + + ASSERT_EQ(memblock.memory.cnt, 1); + ASSERT_EQ(memblock.memory.total_size, total_size); =20 - assert(memblock.memory.cnt =3D=3D 1); - assert(memblock.memory.total_size =3D=3D total_size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -255,15 +293,20 @@ static int memblock_add_within_check(void) .size =3D SZ_1M }; =20 + prefix_push(__func__); + reset_memblock_regions(); memblock_add(r1.base, r1.size); memblock_add(r2.base, r2.size); =20 - assert(rgn->base =3D=3D r1.base); - assert(rgn->size =3D=3D r1.size); + ASSERT_EQ(rgn->base, r1.base); + ASSERT_EQ(rgn->size, r1.size); + + ASSERT_EQ(memblock.memory.cnt, 1); + ASSERT_EQ(memblock.memory.total_size, r1.size); =20 - assert(memblock.memory.cnt =3D=3D 1); - assert(memblock.memory.total_size =3D=3D r1.size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -279,19 +322,28 @@ static int memblock_add_twice_check(void) .size =3D SZ_2M }; =20 + prefix_push(__func__); + reset_memblock_regions(); =20 memblock_add(r.base, r.size); memblock_add(r.base, r.size); =20 - assert(memblock.memory.cnt =3D=3D 1); - assert(memblock.memory.total_size =3D=3D r.size); + ASSERT_EQ(memblock.memory.cnt, 1); + ASSERT_EQ(memblock.memory.total_size, r.size); + + test_pass(); + prefix_pop(); =20 return 0; } =20 static int memblock_add_checks(void) { + prefix_reset(); + prefix_push(FUNC_ADD); + test_print("Running %s tests...\n", FUNC_ADD); + memblock_add_simple_check(); memblock_add_node_simple_check(); memblock_add_disjoint_check(); @@ -300,6 +352,8 @@ static int memblock_add_checks(void) memblock_add_within_check(); memblock_add_twice_check(); =20 + prefix_pop(); + return 0; } =20 @@ -320,11 +374,16 @@ static int memblock_reserve_simple_check(void) .size =3D SZ_128M }; =20 + prefix_push(__func__); + reset_memblock_regions(); memblock_reserve(r.base, r.size); =20 - assert(rgn->base =3D=3D r.base); - assert(rgn->size =3D=3D r.size); + ASSERT_EQ(rgn->base, r.base); + ASSERT_EQ(rgn->size, r.size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -356,18 +415,23 @@ static int memblock_reserve_disjoint_check(void) .size =3D SZ_512M }; =20 + prefix_push(__func__); + reset_memblock_regions(); memblock_reserve(r1.base, r1.size); memblock_reserve(r2.base, r2.size); =20 - assert(rgn1->base =3D=3D r1.base); - assert(rgn1->size =3D=3D r1.size); + ASSERT_EQ(rgn1->base, r1.base); + ASSERT_EQ(rgn1->size, r1.size); + + ASSERT_EQ(rgn2->base, r2.base); + ASSERT_EQ(rgn2->size, r2.size); =20 - assert(rgn2->base =3D=3D r2.base); - assert(rgn2->size =3D=3D r2.size); + ASSERT_EQ(memblock.reserved.cnt, 2); + ASSERT_EQ(memblock.reserved.total_size, r1.size + r2.size); =20 - assert(memblock.reserved.cnt =3D=3D 2); - assert(memblock.reserved.total_size =3D=3D r1.size + r2.size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -406,17 +470,22 @@ static int memblock_reserve_overlap_top_check(void) .size =3D SZ_1G }; =20 + prefix_push(__func__); + total_size =3D (r1.base - r2.base) + r1.size; =20 reset_memblock_regions(); memblock_reserve(r1.base, r1.size); memblock_reserve(r2.base, r2.size); =20 - assert(rgn->base =3D=3D r2.base); - assert(rgn->size =3D=3D total_size); + ASSERT_EQ(rgn->base, r2.base); + ASSERT_EQ(rgn->size, total_size); + + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, total_size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D total_size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -455,17 +524,22 @@ static int memblock_reserve_overlap_bottom_check(void) .size =3D SZ_128K }; =20 + prefix_push(__func__); + total_size =3D (r2.base - r1.base) + r2.size; =20 reset_memblock_regions(); memblock_reserve(r1.base, r1.size); memblock_reserve(r2.base, r2.size); =20 - assert(rgn->base =3D=3D r1.base); - assert(rgn->size =3D=3D total_size); + ASSERT_EQ(rgn->base, r1.base); + ASSERT_EQ(rgn->size, total_size); + + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, total_size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D total_size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -502,15 +576,20 @@ static int memblock_reserve_within_check(void) .size =3D SZ_64K }; =20 + prefix_push(__func__); + reset_memblock_regions(); memblock_reserve(r1.base, r1.size); memblock_reserve(r2.base, r2.size); =20 - assert(rgn->base =3D=3D r1.base); - assert(rgn->size =3D=3D r1.size); + ASSERT_EQ(rgn->base, r1.base); + ASSERT_EQ(rgn->size, r1.size); + + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, r1.size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D r1.size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -527,19 +606,28 @@ static int memblock_reserve_twice_check(void) .size =3D SZ_2M }; =20 + prefix_push(__func__); + reset_memblock_regions(); =20 memblock_reserve(r.base, r.size); memblock_reserve(r.base, r.size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D r.size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, r.size); + + test_pass(); + prefix_pop(); =20 return 0; } =20 static int memblock_reserve_checks(void) { + prefix_reset(); + prefix_push(FUNC_RESERVE); + test_print("Running %s tests...\n", FUNC_RESERVE); + memblock_reserve_simple_check(); memblock_reserve_disjoint_check(); memblock_reserve_overlap_top_check(); @@ -547,6 +635,8 @@ static int memblock_reserve_checks(void) memblock_reserve_within_check(); memblock_reserve_twice_check(); =20 + prefix_pop(); + return 0; } =20 @@ -581,16 +671,21 @@ static int memblock_remove_simple_check(void) .size =3D SZ_4M }; =20 + prefix_push(__func__); + reset_memblock_regions(); memblock_add(r1.base, r1.size); memblock_add(r2.base, r2.size); memblock_remove(r1.base, r1.size); =20 - assert(rgn->base =3D=3D r2.base); - assert(rgn->size =3D=3D r2.size); + ASSERT_EQ(rgn->base, r2.base); + ASSERT_EQ(rgn->size, r2.size); =20 - assert(memblock.memory.cnt =3D=3D 1); - assert(memblock.memory.total_size =3D=3D r2.size); + ASSERT_EQ(memblock.memory.cnt, 1); + ASSERT_EQ(memblock.memory.total_size, r2.size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -626,15 +721,20 @@ static int memblock_remove_absent_check(void) .size =3D SZ_1G }; =20 + prefix_push(__func__); + reset_memblock_regions(); memblock_add(r1.base, r1.size); memblock_remove(r2.base, r2.size); =20 - assert(rgn->base =3D=3D r1.base); - assert(rgn->size =3D=3D r1.size); + ASSERT_EQ(rgn->base, r1.base); + ASSERT_EQ(rgn->size, r1.size); + + ASSERT_EQ(memblock.memory.cnt, 1); + ASSERT_EQ(memblock.memory.total_size, r1.size); =20 - assert(memblock.memory.cnt =3D=3D 1); - assert(memblock.memory.total_size =3D=3D r1.size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -674,6 +774,8 @@ static int memblock_remove_overlap_top_check(void) .size =3D SZ_32M }; =20 + prefix_push(__func__); + r1_end =3D r1.base + r1.size; r2_end =3D r2.base + r2.size; total_size =3D r1_end - r2_end; @@ -682,11 +784,14 @@ static int memblock_remove_overlap_top_check(void) memblock_add(r1.base, r1.size); memblock_remove(r2.base, r2.size); =20 - assert(rgn->base =3D=3D r1.base + r2.base); - assert(rgn->size =3D=3D total_size); + ASSERT_EQ(rgn->base, r1.base + r2.base); + ASSERT_EQ(rgn->size, total_size); + + ASSERT_EQ(memblock.memory.cnt, 1); + ASSERT_EQ(memblock.memory.total_size, total_size); =20 - assert(memblock.memory.cnt =3D=3D 1); - assert(memblock.memory.total_size =3D=3D total_size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -724,17 +829,23 @@ static int memblock_remove_overlap_bottom_check(void) .size =3D SZ_256M }; =20 + prefix_push(__func__); + total_size =3D r2.base - r1.base; =20 reset_memblock_regions(); memblock_add(r1.base, r1.size); memblock_remove(r2.base, r2.size); =20 - assert(rgn->base =3D=3D r1.base); - assert(rgn->size =3D=3D total_size); + ASSERT_EQ(rgn->base, r1.base); + ASSERT_EQ(rgn->size, total_size); + + ASSERT_EQ(memblock.memory.cnt, 1); + ASSERT_EQ(memblock.memory.total_size, total_size); + + test_pass(); + prefix_pop(); =20 - assert(memblock.memory.cnt =3D=3D 1); - assert(memblock.memory.total_size =3D=3D total_size); return 0; } =20 @@ -774,6 +885,8 @@ static int memblock_remove_within_check(void) .size =3D SZ_1M }; =20 + prefix_push(__func__); + r1_size =3D r2.base - r1.base; r2_size =3D (r1.base + r1.size) - (r2.base + r2.size); total_size =3D r1_size + r2_size; @@ -782,26 +895,35 @@ static int memblock_remove_within_check(void) memblock_add(r1.base, r1.size); memblock_remove(r2.base, r2.size); =20 - assert(rgn1->base =3D=3D r1.base); - assert(rgn1->size =3D=3D r1_size); + ASSERT_EQ(rgn1->base, r1.base); + ASSERT_EQ(rgn1->size, r1_size); + + ASSERT_EQ(rgn2->base, r2.base + r2.size); + ASSERT_EQ(rgn2->size, r2_size); =20 - assert(rgn2->base =3D=3D r2.base + r2.size); - assert(rgn2->size =3D=3D r2_size); + ASSERT_EQ(memblock.memory.cnt, 2); + ASSERT_EQ(memblock.memory.total_size, total_size); =20 - assert(memblock.memory.cnt =3D=3D 2); - assert(memblock.memory.total_size =3D=3D total_size); + test_pass(); + prefix_pop(); =20 return 0; } =20 static int memblock_remove_checks(void) { + prefix_reset(); + prefix_push(FUNC_REMOVE); + test_print("Running %s tests...\n", FUNC_REMOVE); + memblock_remove_simple_check(); memblock_remove_absent_check(); memblock_remove_overlap_top_check(); memblock_remove_overlap_bottom_check(); memblock_remove_within_check(); =20 + prefix_pop(); + return 0; } =20 @@ -835,16 +957,21 @@ static int memblock_free_simple_check(void) .size =3D SZ_1M }; =20 + prefix_push(__func__); + reset_memblock_regions(); memblock_reserve(r1.base, r1.size); memblock_reserve(r2.base, r2.size); memblock_free((void *)r1.base, r1.size); =20 - assert(rgn->base =3D=3D r2.base); - assert(rgn->size =3D=3D r2.size); + ASSERT_EQ(rgn->base, r2.base); + ASSERT_EQ(rgn->size, r2.size); + + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, r2.size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D r2.size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -880,15 +1007,20 @@ static int memblock_free_absent_check(void) .size =3D SZ_128M }; =20 + prefix_push(__func__); + reset_memblock_regions(); memblock_reserve(r1.base, r1.size); memblock_free((void *)r2.base, r2.size); =20 - assert(rgn->base =3D=3D r1.base); - assert(rgn->size =3D=3D r1.size); + ASSERT_EQ(rgn->base, r1.base); + ASSERT_EQ(rgn->size, r1.size); + + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, r1.size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D r1.size); + test_pass(); + prefix_pop(); =20 return 0; } @@ -928,17 +1060,22 @@ static int memblock_free_overlap_top_check(void) .size =3D SZ_8M }; =20 + prefix_push(__func__); + total_size =3D (r1.size + r1.base) - (r2.base + r2.size); =20 reset_memblock_regions(); memblock_reserve(r1.base, r1.size); memblock_free((void *)r2.base, r2.size); =20 - assert(rgn->base =3D=3D r2.base + r2.size); - assert(rgn->size =3D=3D total_size); + ASSERT_EQ(rgn->base, r2.base + r2.size); + ASSERT_EQ(rgn->size, total_size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -973,17 +1110,22 @@ static int memblock_free_overlap_bottom_check(void) .size =3D SZ_32M }; =20 + prefix_push(__func__); + total_size =3D r2.base - r1.base; =20 reset_memblock_regions(); memblock_reserve(r1.base, r1.size); memblock_free((void *)r2.base, r2.size); =20 - assert(rgn->base =3D=3D r1.base); - assert(rgn->size =3D=3D total_size); + ASSERT_EQ(rgn->base, r1.base); + ASSERT_EQ(rgn->size, total_size); =20 - assert(memblock.reserved.cnt =3D=3D 1); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 1); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } @@ -1024,6 +1166,8 @@ static int memblock_free_within_check(void) .size =3D SZ_1M }; =20 + prefix_push(__func__); + r1_size =3D r2.base - r1.base; r2_size =3D (r1.base + r1.size) - (r2.base + r2.size); total_size =3D r1_size + r2_size; @@ -1032,26 +1176,35 @@ static int memblock_free_within_check(void) memblock_reserve(r1.base, r1.size); memblock_free((void *)r2.base, r2.size); =20 - assert(rgn1->base =3D=3D r1.base); - assert(rgn1->size =3D=3D r1_size); + ASSERT_EQ(rgn1->base, r1.base); + ASSERT_EQ(rgn1->size, r1_size); =20 - assert(rgn2->base =3D=3D r2.base + r2.size); - assert(rgn2->size =3D=3D r2_size); + ASSERT_EQ(rgn2->base, r2.base + r2.size); + ASSERT_EQ(rgn2->size, r2_size); =20 - assert(memblock.reserved.cnt =3D=3D 2); - assert(memblock.reserved.total_size =3D=3D total_size); + ASSERT_EQ(memblock.reserved.cnt, 2); + ASSERT_EQ(memblock.reserved.total_size, total_size); + + test_pass(); + prefix_pop(); =20 return 0; } =20 static int memblock_free_checks(void) { + prefix_reset(); + prefix_push(FUNC_FREE); + test_print("Running %s tests...\n", FUNC_FREE); + memblock_free_simple_check(); memblock_free_absent_check(); memblock_free_overlap_top_check(); memblock_free_overlap_bottom_check(); memblock_free_within_check(); =20 + prefix_pop(); + return 0; } =20 diff --git a/tools/testing/memblock/tests/common.c b/tools/testing/memblock= /tests/common.c index 62d3191f7c9a..e55b2a8bf0ff 100644 --- a/tools/testing/memblock/tests/common.c +++ b/tools/testing/memblock/tests/common.c @@ -4,8 +4,12 @@ =20 #define INIT_MEMBLOCK_REGIONS 128 #define INIT_MEMBLOCK_RESERVED_REGIONS INIT_MEMBLOCK_REGIONS +#define PREFIXES_LEN_MAX 256 +#define DELIM ": " +#define DELIM_LEN strlen(DELIM) =20 static struct test_memory memory_block; +static char __maybe_unused prefixes[PREFIXES_LEN_MAX]; =20 void reset_memblock_regions(void) { @@ -46,3 +50,57 @@ void dummy_physical_memory_cleanup(void) { free(memory_block.base); } + +#ifdef VERBOSE +void test_fail(void) +{ + ksft_test_result_fail(": %sfailed\n", prefixes); +} + +void test_pass(void) +{ + ksft_test_result_pass(": %spassed\n", prefixes); +} + +void test_print(const char *fmt, ...) +{ + int saved_errno =3D errno; + va_list args; + + va_start(args, fmt); + errno =3D saved_errno; + vprintf(fmt, args); + va_end(args); +} + +void prefix_reset(void) +{ + memset(prefixes, 0, PREFIXES_LEN_MAX); +} + +void prefix_push(const char *prefix) +{ + int prefix_max =3D PREFIXES_LEN_MAX - strlen(prefixes) - DELIM_LEN - 1; + + assert(strlen(prefix) <=3D prefix_max); + strncat(prefixes, prefix, prefix_max); + strncat(prefixes, DELIM, PREFIXES_LEN_MAX - strlen(prefixes) - 1); +} + +void prefix_pop(void) +{ + char *ptr; + + ptr =3D strrchr(prefixes, DELIM[0]); + if (!ptr) + prefixes[0] =3D 0; + else + *(ptr) =3D 0; + + ptr =3D strrchr(prefixes, DELIM[0]); + if (!ptr) + prefixes[0] =3D 0; + else + *(ptr + DELIM_LEN) =3D 0; +} +#endif /* VERBOSE */ diff --git a/tools/testing/memblock/tests/common.h b/tools/testing/memblock= /tests/common.h index 619054d03219..bdddb5f72871 100644 --- a/tools/testing/memblock/tests/common.h +++ b/tools/testing/memblock/tests/common.h @@ -7,9 +7,47 @@ #include #include #include +#include +#include <../selftests/kselftest.h> =20 #define MEM_SIZE SZ_16K =20 +/** + * ASSERT_EQ(): + * Check the condition + * @_expected =3D=3D @_seen + * If false, print failed test message (if in VERBOSE mode) and then assert + */ +#define ASSERT_EQ(_expected, _seen) do { \ + if ((_expected) !=3D (_seen)) \ + test_fail(); \ + assert((_expected) =3D=3D (_seen)); \ +} while (0) + +/** + * ASSERT_NE(): + * Check the condition + * @_expected !=3D @_seen + * If false, print failed test message (if in VERBOSE mode) and then assert + */ +#define ASSERT_NE(_expected, _seen) do { \ + if ((_expected) =3D=3D (_seen)) \ + test_fail(); \ + assert((_expected) !=3D (_seen)); \ +} while (0) + +/** + * ASSERT_LT(): + * Check the condition + * @_expected < @_seen + * If false, print failed test message (if in VERBOSE mode) and then assert + */ +#define ASSERT_LT(_expected, _seen) do { \ + if ((_expected) >=3D (_seen)) \ + test_fail(); \ + assert((_expected) < (_seen)); \ +} while (0) + /* * Available memory registered with memblock needs to be valid for allocs * test to run. This is a convenience wrapper for memory allocated in @@ -31,4 +69,20 @@ void setup_memblock(void); void dummy_physical_memory_init(void); void dummy_physical_memory_cleanup(void); =20 +#ifdef VERBOSE +void test_fail(void); +void test_pass(void); +void test_print(const char *fmt, ...); +void prefix_reset(void); +void prefix_push(const char *prefix); +void prefix_pop(void); +#else +static inline void test_fail(void) {} +static inline void test_pass(void) {} +static inline void test_print(const char *fmt, ...) {} +static inline void prefix_reset(void) {} +static inline void prefix_push(const char *prefix) {} +static inline void prefix_pop(void) {} +#endif /* VERBOSE */ + #endif --=20 2.34.1 From nobody Sun Apr 26 21:37:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D3DBC43334 for ; Wed, 22 Jun 2022 09:29:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355667AbiFVJ3m (ORCPT ); Wed, 22 Jun 2022 05:29:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356754AbiFVJ3c (ORCPT ); Wed, 22 Jun 2022 05:29:32 -0400 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDD8E396AE for ; Wed, 22 Jun 2022 02:29:24 -0700 (PDT) Received: by mail-ot1-x341.google.com with SMTP id s20-20020a056830439400b0060c3e43b548so12633982otv.7 for ; Wed, 22 Jun 2022 02:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DfXx6OUKFv9lmYSVpe2VK14vOIkFTYrGx9cnZE6j00U=; b=mUFh8eRq4qQBRgjBDWi3lpzdhCpt1bXMCv9galxgsLml+K45xfP7UjqZXIy9RuhagS XUqMzrrmcYIKCfsGkH0NOHLyUMo6/CtqoK9DOQJ7Piih2sJS5fbzWNK7EhTuyNaxx88r MEBil20mlTGEWwTZxmnW8OVTQ8lvH4Fyxz/0Z2MwZMSpiva1vO21WL60Z9NjcLq6auQ6 PtmhFI+5TDJXLcFtOP3CT9FVrKte1y2v34vAf6r4xHQpaBrqlw9sbKuuiGmk99u7/oME hhzzPILM94kzYPCu86ZDcYRQj1K20CBPaOHsHOgIVgoHg8kyO5E8mzgVTFXP6xOxbKFG tJwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DfXx6OUKFv9lmYSVpe2VK14vOIkFTYrGx9cnZE6j00U=; b=xrBaL6mB28hZP1lLjuum5dZvfdn3CByMzdOmha2YfClvLECfA8wkKBsYo2sQHknSzf btvaZkkuTRDxg70LEtEwQHfe+8CixFyQLS2gVYsSm06gJtKxxRDtsFXzB5EuZP7kkvuE LQpiviUf5InimUsLkAHDIhgRidTtdfPjmK7+ndsSLpzEksmQngnhGPv7kolqKPfcLGD5 xN0UhdqepDtRiKjpbnGjLWzOWHxrdDEvKtoIyil447hVSCiefmPbEKkOGIMyEpEjE1D/ vssL+Dg3KNvRGmlfjBZX7CBycsNDkStg0wgIOWNAKExymWT8IJu2GzAwfVKpi+kg0Sp1 nZBQ== X-Gm-Message-State: AJIora9k1P1PHzAt4KnPa5tsY182JlQ9lPUxadCfUuG1UWJQXv9xWMCM 35dW1IkpZ+hOj8SGh35HiH40TlYQc40= X-Google-Smtp-Source: AGRyM1sVGvUWz0BD8tejsjDQkqxdmNwvMms1D0vqtRylPH4AAbRLuj4vjhqcFhAGnzGbBhtD8XX4gg== X-Received: by 2002:a05:6830:2016:b0:60c:468:e30 with SMTP id e22-20020a056830201600b0060c04680e30mr1065968otp.271.1655890164154; Wed, 22 Jun 2022 02:29:24 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id r23-20020a056830419700b0060c03836d04sm10867095otu.77.2022.06.22.02.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 02:29:24 -0700 (PDT) From: Rebecca Mckeever To: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand , Rebecca Mckeever Subject: [PATCH v3 3/4] memblock tests: set memblock_debug to enable memblock_dbg() messages Date: Wed, 22 Jun 2022 04:29:08 -0500 Message-Id: <39c5c97d2b5c1ab88b7bbbf02633f840fd5dfcdf.1655889641.git.remckee0@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" If Memblock simulator was compiled with MEMBLOCK_DEBUG=3D1, set memblock_debug to 1 so that memblock_dbg() will print debug information when memblock functions are tested in Memblock simulator. Signed-off-by: Rebecca Mckeever --- tools/testing/memblock/internal.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/int= ernal.h index 94b52a8718b5..c2a492c05e0c 100644 --- a/tools/testing/memblock/internal.h +++ b/tools/testing/memblock/internal.h @@ -2,6 +2,13 @@ #ifndef _MM_INTERNAL_H #define _MM_INTERNAL_H =20 +/* + * Enable memblock_dbg() messages + */ +#ifdef MEMBLOCK_DEBUG +static int memblock_debug =3D 1; +#endif + struct page {}; =20 void memblock_free_pages(struct page *page, unsigned long pfn, --=20 2.34.1 From nobody Sun Apr 26 21:37:17 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D5E1C43334 for ; Wed, 22 Jun 2022 09:29:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357490AbiFVJ3v (ORCPT ); Wed, 22 Jun 2022 05:29:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357194AbiFVJ3d (ORCPT ); Wed, 22 Jun 2022 05:29:33 -0400 Received: from mail-oa1-x42.google.com (mail-oa1-x42.google.com [IPv6:2001:4860:4864:20::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B39B639818 for ; Wed, 22 Jun 2022 02:29:26 -0700 (PDT) Received: by mail-oa1-x42.google.com with SMTP id 586e51a60fabf-101cdfddfacso13585507fac.7 for ; Wed, 22 Jun 2022 02:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=kgkz2geQkKSUBJ36TO4bMC7bsJTG+GAVBJsvT9CSBn9zuR5zMQSGJqFNU/NxCoypsG YKY6Z1OqMwJwtgltM2b41HxcYYggPdYm7hADc2xLgRUlSuFbTm/SLaXwApAQ38sYyYVN Rlkr6xzYisk1urfGmn1vSFDMDViFWPBMkHQbdtENTBptf2EUTypLl0dqBhPsLOHmyfJG aVP3QYlqRRdnQdEtw+G2Kj17iyMDdyLP2bYmYWNu2RO6ClH9Kyf3rc8XUEVUx/32jGpc aJheEMs8MYn2InAf33kX+FzAynFaxSq/fsvhu2H9frszzCarnNr7YKzJ/4EwsY6iQuzx KvcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hDwC4vjOEjWZbqEneYaa93PfkH0X3bD2FesquY/4DR0=; b=cbnJT66CvxRbHKW/tB+eE0D9aEr/WMsMMzzNcybBjDzIuxdlf7WLF8mhu2q6kTDtOl 8TEUH0G9gM+XDmCfAAwkXdR/WIx4L19IfX/0NeNqjh1h8HP74Ih8QlX9Qb44tWU+T5VY 5wWqQPKcAnLUhtH4VUFMBTPYO/Drf5z+6K/En979lHNGTml+h2WvsC7CHvFN5h4alm9X NhMCTh1dRpFpVqQV9MDk2//mMCMzoRHIeOAf1LEoM5uAW5DBwPBOlpGp7IyWAsBc71LV cigNuxnhjmNBe5rOI0m+l/YX9rZP/Ha95+BZ8ZN96bQ/kf9NDW4C65ynNbBj3Ua28kIc hcFg== X-Gm-Message-State: AJIora8WFisfwBiTKcBsk8C15sfbMbMXT2Id5wE6WvgM0TAtBb/Gbx2X Ho7BG4q0eekN2rBoc3qyzok= X-Google-Smtp-Source: AGRyM1vyCM96jx9X9mBgzkkjXQofVpIOX84M/3iQuwrvMEEX47TER/TEa1XYYtSucqBkXWRPsm73pg== X-Received: by 2002:a05:6870:390d:b0:101:ab20:2763 with SMTP id b13-20020a056870390d00b00101ab202763mr1409224oap.233.1655890166077; Wed, 22 Jun 2022 02:29:26 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id p10-20020a0568301d4a00b0060be7487954sm10854113oth.26.2022.06.22.02.29.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 02:29:25 -0700 (PDT) From: Rebecca Mckeever To: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: David Hildenbrand , Rebecca Mckeever Subject: [PATCH v3 4/4] memblock tests: remove completed TODO items Date: Wed, 22 Jun 2022 04:29:09 -0500 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove completed items from TODO list. Signed-off-by: Rebecca Mckeever --- tools/testing/memblock/TODO | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/tools/testing/memblock/TODO b/tools/testing/memblock/TODO index cd1a30d5acc9..33044c634ea7 100644 --- a/tools/testing/memblock/TODO +++ b/tools/testing/memblock/TODO @@ -1,25 +1,17 @@ TODO =3D=3D=3D=3D=3D =20 -1. Add verbose output (e.g., what is being tested and how many tests cases= are - passing) - -2. Add flags to Makefile: - + verbosity level - + enable memblock_dbg() messages (i.e. pass "-D CONFIG_DEBUG_MEMORY_INI= T" - flag) - -3. Add tests trying to memblock_add() or memblock_reserve() 129th region. +1. Add tests trying to memblock_add() or memblock_reserve() 129th region. This will trigger memblock_double_array(), make sure it succeeds. *Important:* These tests require valid memory ranges, use dummy physical memory block from common.c to implement them. It is also v= ery likely that the current MEM_SIZE won't be enough for these test cases. Use realloc to adjust the size accordingly. =20 -4. Add test cases using this functions (implement them for both directions= ): +2. Add test cases using this functions (implement them for both directions= ): + memblock_alloc_raw() + memblock_alloc_exact_nid_raw() + memblock_alloc_try_nid_raw() =20 -5. Add tests for memblock_alloc_node() to check if the correct NUMA node i= s set +3. Add tests for memblock_alloc_node() to check if the correct NUMA node i= s set for the new region --=20 2.34.1