From nobody Mon Apr 20 05:55:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68F6EC43334 for ; Wed, 22 Jun 2022 04:53:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356977AbiFVExN (ORCPT ); Wed, 22 Jun 2022 00:53:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356941AbiFVExJ (ORCPT ); Wed, 22 Jun 2022 00:53:09 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B74F16244 for ; Tue, 21 Jun 2022 21:53:08 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id c205so8297767pfc.7 for ; Tue, 21 Jun 2022 21:53:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=siwRRlWSHlqBGRmLfqz7WxH0j7k4YZlDP6vTKzeSc6c=; b=CoRfui3AvkifJVNvTBqxSBEUD1RYlSXklq1JdozIQVHQLvRrzsjtovZ6Isp0zGwCMx DlGkQdi7McDlD7RLEBXitXtLnQiHq99dxMG1x0Cph1euVOhRRelQlHa/6Q9a/Kn2m64R /bFjlHnkKZaz519snylg4U/yjnub5c9OFZNIHCtDGAxxsGD7w/dR0xN7DS0o9ClkrIVy yISryMCuR61H52bL+z5G/JvXswHwHkIMFh42GU24bCdBSVnwMndMfE02R87i3RHy/ufV qCfoNusCj/ZOTQzYFhqs8epqOED/FrCxnben1Wbe4fKCU1bQRQPHZzwFzdDvCoZ4wgqU P7bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=siwRRlWSHlqBGRmLfqz7WxH0j7k4YZlDP6vTKzeSc6c=; b=b+E7PJco91epqSBcM3ArD2QoUOYKYarh5lj0n4R5AafS/2dgK/ihBM4F8NR15gsifG l2irFIHvLsIYRKoecMFRea9kMAjnXTxtQlEE9uCyilr7V6gTIeSfwGiU/facYjpVf0+1 gZBsk0UQoQ1igHk3qRX06PR7RENYqIRtrO5N3PsVr0IFqxkr12NKqrh6A+dn2K2pco1/ rrQ1W7YSPIkVa/iNaukMLBuxtYqzqpI8DaRfy2tv8WG/+Di8jbnB0EARPK6nl22jmpDS tyzCQlXSoTKm17inF6/rtXJ8v3CUlvbyDxKcfrotwzs3a8vlo59Q3+lhC6vf++SekcvO nsRg== X-Gm-Message-State: AJIora85c6gHtpq9mQgcwS1M+ykGLuiOmN6kzYpWfgrdyzE2Zq1qPrgL e2oskKtMjnbPWqjBQ6vKTsY= X-Google-Smtp-Source: AGRyM1sdcPcXr3djCCbq3GGXESutAPLO30Bkk1Op95VLl9vFeB8PwZCYQFGaNzHT7jnyDX0WLathSg== X-Received: by 2002:a63:78cb:0:b0:40c:e4e0:dfde with SMTP id t194-20020a6378cb000000b0040ce4e0dfdemr1381517pgc.87.1655873588301; Tue, 21 Jun 2022 21:53:08 -0700 (PDT) Received: from localhost (c-67-180-87-133.hsd1.ca.comcast.net. [67.180.87.133]) by smtp.gmail.com with ESMTPSA id gf23-20020a17090ac7d700b001ec9f9fe028sm5564482pjb.46.2022.06.21.21.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 21:53:07 -0700 (PDT) From: Chang Yu To: Larry.Finger@lwfinger.net Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Chang Yu Subject: [PATCH 1/5] staging: r8188eu: Fixed a function declaration coding style issue Date: Tue, 21 Jun 2022 21:52:30 -0700 Message-Id: <778c21724752f2de136d82b31c9ffc2bf35ced55.1655872968.git.marcus.yu.56@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Added an identifier name for function definition argument 'struct timer_list *' as per checkpatch.pl Note that for the same line checkpatch.pl will also complain "extern should be avoided in .c". I am not very familiar with the codebase so I decided not to move the declaration to a header file. Signed-off-by: Chang Yu Tested-by: Philipp Hortmann # Edimax N150=20 --- drivers/staging/r8188eu/core/rtw_recv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r818= 8eu/core/rtw_recv.c index 36ea79586992..7e2f5c2f9111 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -24,7 +24,7 @@ static u8 rtw_rfc1042_header[] =3D { 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 }; =20 -void rtw_signal_stat_timer_hdl(struct timer_list *); +void rtw_signal_stat_timer_hdl(struct timer_list *t); =20 void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv) { --=20 2.36.1 From nobody Mon Apr 20 05:55:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE3EC433EF for ; Wed, 22 Jun 2022 04:53:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356988AbiFVExR (ORCPT ); Wed, 22 Jun 2022 00:53:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356930AbiFVExL (ORCPT ); Wed, 22 Jun 2022 00:53:11 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BED46244 for ; Tue, 21 Jun 2022 21:53:10 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id 128so8018835pfv.12 for ; Tue, 21 Jun 2022 21:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=miDHh8TIXvhG9iaGpB6jefg7h3ay42uNe8cnWKGwUNM=; b=H6++axkvJgfmn6n3LaeDwik2qAP91cPX6DQctcDvpgU3kkAk+jCelu+FO8wdZfLNNB lWha5g2gfEYAMNBiq0hhdWD1na1d8OkqCzZDpAbTYFDDZVY/G6rnJm1Y3AScVQh9Sefy lPVxWHIQr8NYwfAgTKHBff33VgMiO6xNmpeCSNSlhuxLO6Qgzb06148N5XO3OiTSnNhz uEizQwa/LOb6D9DOL4HzowJ/L9MluKz7prOYrjE9/2osMcc9dB7AxEt5UmeiuBROsT6n 5MI30fGl5UC8/n4ypmTGfhzlcpyG22lrgjnk7WZUdTqIt0iQP0qNS+Q+1hBD9DNYmKmB 3NSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=miDHh8TIXvhG9iaGpB6jefg7h3ay42uNe8cnWKGwUNM=; b=ee+xR9akKp9oLSPHW5q7Rp2Nzj+gKdEuSvYrWg8CCVupdlMWWp5AY1BpJTnse2IRr5 /tdpavPbve81EPiNyYFpiQVHil++R+UKkggsoonJXVRWL8JPxgzH4bGLSKgfgdXedqxL wm3fwnyVJlDOFRoDscAOcsFrVKbFQr2Y1DPodFEXT6oV9Ec6ZxASZmhuJHguqqIzNxy2 gs4YXMDSpn7LPh12DCGr6N9fpuTLioenMs+74otFtNAmTSnnArFRMWTAc3kzlwI/nNIX Pz4K68zBb4vnVN2mLejI2QtM/DXZNET/XZwGrKrWLqoYkQGeftjnZVPf1sK7/dTafzga cRRQ== X-Gm-Message-State: AJIora9ypN6YQkHmNOfZhbfHjmu07DffOTagea2p/Y8beY9n2ajawUQw Brk9Cgtabu6s4RXVfFpXCQgG/d8A+SpK1A== X-Google-Smtp-Source: AGRyM1sfWuGFQ0cMtpUQWtwL/DSxT6D90LTQzU8iTv8hKDvHwDOE5PCYCmL1jj+1hsXVdN3jKYTqyQ== X-Received: by 2002:a05:6a00:16c7:b0:520:6ede:2539 with SMTP id l7-20020a056a0016c700b005206ede2539mr33230812pfc.46.1655873590035; Tue, 21 Jun 2022 21:53:10 -0700 (PDT) Received: from localhost (c-67-180-87-133.hsd1.ca.comcast.net. [67.180.87.133]) by smtp.gmail.com with ESMTPSA id j2-20020a170902da8200b00163e4410b82sm333812plx.239.2022.06.21.21.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 21:53:09 -0700 (PDT) From: Chang Yu To: Larry.Finger@lwfinger.net Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Chang Yu Subject: [PATCH 2/5] staging: r8188eu: Fixed two brace coding style issues Date: Tue, 21 Jun 2022 21:52:31 -0700 Message-Id: X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Removed two pairs of unnecessary curly braces as per checkpatch.pl Signed-off-by: Chang Yu Tested-by: Philipp Hortmann # Edimax N150=20 --- drivers/staging/r8188eu/core/rtw_recv.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r818= 8eu/core/rtw_recv.c index 7e2f5c2f9111..38b7905dc88f 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -1365,13 +1365,12 @@ static int amsdu_to_msdu(struct adapter *padapter, = struct recv_frame *prframe) a_len -=3D nSubframe_Length; if (a_len !=3D 0) { padding_len =3D 4 - ((nSubframe_Length + ETH_HLEN) & (4 - 1)); - if (padding_len =3D=3D 4) { + if (padding_len =3D=3D 4) padding_len =3D 0; - } =20 - if (a_len < padding_len) { + if (a_len < padding_len) goto exit; - } + pdata +=3D padding_len; a_len -=3D padding_len; } --=20 2.36.1 From nobody Mon Apr 20 05:55:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD1EDC43334 for ; Wed, 22 Jun 2022 04:53:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356249AbiFVExT (ORCPT ); Wed, 22 Jun 2022 00:53:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356976AbiFVExM (ORCPT ); Wed, 22 Jun 2022 00:53:12 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12AF662C8 for ; Tue, 21 Jun 2022 21:53:12 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id 128so8018835pfv.12 for ; Tue, 21 Jun 2022 21:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BxvmsU5m8dUdexI+F5twWDTTNh+JWXM865vqfEysxx0=; b=Mq7oXFbEQcnHGEQtngIIAPELIYUoo/5Gwkd5Sphhu2G4H4b9vVYsVcRnVM9uKmBoZv hyPio4D9Sew8/ko03NSJiWydLl4XfJ4yhMh0Dplh27Z3IxJhg8Kf9xigGM1SCQygMTrE SWY0wDknwKDwUYMm4fOjil784KcmTncjqT8XMsMBwqY8EbPtlsBNfAelbLBvpwU27fK7 cHe7V8sgV0WZGxuIWEXfy49JlS5f2AmEpFJBFEk/vIia6YPkoB/QzNJD2FFf6B8Kk8n9 17vMbJIajX0U2wvKgyFwwHaEL3qz/u+ME+/0BxA2t1hVlHKCBq0tUWuIsJQne+m2nyHo DhjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BxvmsU5m8dUdexI+F5twWDTTNh+JWXM865vqfEysxx0=; b=ajJ/ZIKTOoTpYLOrokhQauhFg2ioyP/Rz1YpZjkKbaGJngBFNhPU789KWZIBO4maJ5 jGTT5OnqU3yf5GrT1k/iIy2B6aCYbDbcOrxvk/r/zxV5016MRsQuaeOJo6O9iply4Gri nwVuJFet8nkPN8igYgNQiElAZSVETS4FqyX/xlSlYFbZNlKc85CuR52WySC3iSYjFZ/7 mt0H9hw0avhTAJKsX6SZM8kjWaRzNY971Ilpxh3NB1c4KG/jrUAav8Aklt6DcZZjhQqw mE5DbgpM5/q4qO4iQobUuC5qbJcx4WfNKjUqcnBQjQBh/Bl2zCjz4zCst9SfKQN6JWGf NTpw== X-Gm-Message-State: AJIora8oRicTl6RBRgWmyuiUqPR5iuD+YrURkdrrE5pxMXxyC9t0gtJ9 B80kF0v+l0FYJ5DsejMoVT0= X-Google-Smtp-Source: AGRyM1unzEkZ+0rqye8e6MIZjZeRlNhrkw9JMlqQKIVoGDonvDQ/bOvFhlSiBjcYbjQGDVLFcKun5A== X-Received: by 2002:a63:fc01:0:b0:403:af21:9729 with SMTP id j1-20020a63fc01000000b00403af219729mr1377939pgi.54.1655873591805; Tue, 21 Jun 2022 21:53:11 -0700 (PDT) Received: from localhost (c-67-180-87-133.hsd1.ca.comcast.net. [67.180.87.133]) by smtp.gmail.com with ESMTPSA id h4-20020a62de04000000b0051bb61c0eacsm3938518pfg.20.2022.06.21.21.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 21:53:11 -0700 (PDT) From: Chang Yu To: Larry.Finger@lwfinger.net Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Chang Yu Subject: [PATCH 3/5] staging: r8188eu: Fixed two whitespace coding style issues Date: Tue, 21 Jun 2022 21:52:32 -0700 Message-Id: <68cb57799d9139740f94eed9080e2d08c522e74c.1655872968.git.marcus.yu.56@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Replaced spaces with tabs as per checkpatch.pl Signed-off-by: Chang Yu Tested-by: Philipp Hortmann # Edimax N150=20 --- drivers/staging/r8188eu/core/rtw_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r818= 8eu/core/rtw_recv.c index 38b7905dc88f..d42ff210ee81 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -17,11 +17,11 @@ static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] =3D {0x80, 0x= f3}; =20 /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */ static u8 rtw_bridge_tunnel_header[] =3D { - 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8 + 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8 }; =20 static u8 rtw_rfc1042_header[] =3D { - 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 + 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 }; =20 void rtw_signal_stat_timer_hdl(struct timer_list *t); --=20 2.36.1 From nobody Mon Apr 20 05:55:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8476CC43334 for ; Wed, 22 Jun 2022 04:53:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357021AbiFVEx2 (ORCPT ); Wed, 22 Jun 2022 00:53:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356979AbiFVExP (ORCPT ); Wed, 22 Jun 2022 00:53:15 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BADE62C8 for ; Tue, 21 Jun 2022 21:53:14 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id z14so15093602pgh.0 for ; Tue, 21 Jun 2022 21:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eJjZkSNiCRUyDH8c9+KjX8Rp6orUrFEEu//TCWlvtVw=; b=EfAakUfvTvHPwmYtL/U0emYHaoaYi4U1zj6JFpfvCt1DK0rBhB8+VIii/TYJVSTHIt wS+iqsC1S5kfCgx7Y/729oPRp3bi4sMSm5WYhlEQCJJaSal9dHiXHt0SigdNvrP3q9pO sNLyG7gPp2hWNy96rUoz62ajN+whP3P/B9lh9LCKk9KRpy1t8Ube6mkwKraJGn8kF0HB we8YOhzQTsWahhkCp/+zAtUPaSONRT6OmXo03YktF5kCSrsCXd9sFeXXNAFDqFFlYw9v KMXE2RlF0x1tYr/Z46ltmBRTkkPPlk4yvLT+nBTmTPw2ESoV/uUNDVZ9qX8TI6pozllq dMAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eJjZkSNiCRUyDH8c9+KjX8Rp6orUrFEEu//TCWlvtVw=; b=PQvYtBX0JOUYcSc9GTTi/zwfnCp9MxYTFUrPCcJqedprmnaMBfGIS3tIVf015fWG0N Pba52B3W+HrNUlWAqDUCNACMUpVnz4Zw2Yf9upoiUX+Xk1qqS4zi5MWH9WQOd+mwYWZF t/8lrSrQR7ltc7K8M8nGvVBHnRABIqaHQ0fhyPIg/j9QQ2g/dQ5bi5dXfaR/F/hJLIla 96Se6iY3rNffseA/XjPKuwqknq3S9g/USRzljOAe1izS4OwzpgugUQP8S5DkfPOlZS8O btxi2QTLYld9meIrD3aSIMJ7koeXBF31db1WsMjkNJ3l18laqKtIM3w+f2ZTa+247HIN Q+0g== X-Gm-Message-State: AJIora+PDnvmq6mev2F57gYgjcHEroql8X/FKNIPP5lKyh+uu5siCXlm FXloIScfx8a0vKzJcp8Cmos= X-Google-Smtp-Source: AGRyM1u79SZByc9RiPlW8G1ORiWRgJ5CCetm87jXTERa2WEMJzRDpxgIR+IXo8NQ8FQ1/VMa9mYF7A== X-Received: by 2002:a05:6a00:cce:b0:525:3bd3:b62c with SMTP id b14-20020a056a000cce00b005253bd3b62cmr5127731pfv.67.1655873593775; Tue, 21 Jun 2022 21:53:13 -0700 (PDT) Received: from localhost (c-67-180-87-133.hsd1.ca.comcast.net. [67.180.87.133]) by smtp.gmail.com with ESMTPSA id p14-20020a170902e74e00b00163bfaf0b17sm11660222plf.233.2022.06.21.21.53.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 21:53:13 -0700 (PDT) From: Chang Yu To: Larry.Finger@lwfinger.net Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Chang Yu Subject: [PATCH 4/5] staging: r8188eu: Fixed comment style Date: Tue, 21 Jun 2022 21:52:33 -0700 Message-Id: X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fixed block comments style as per checkpatch.pl and kernel coding style guide. Signed-off-by: Chang Yu Tested-by: Philipp Hortmann # Edimax N150=20 --- drivers/staging/r8188eu/core/rtw_recv.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r818= 8eu/core/rtw_recv.c index d42ff210ee81..14dd2344fa4b 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -204,12 +204,12 @@ int rtw_enqueue_recvframe(struct recv_frame *precvfra= me, struct __queue *queue) } =20 /* -caller : defrag ; recvframe_chk_defrag in recv_thread (passive) -pframequeue: defrag_queue : will be accessed in recv_thread (passive) - -using spinlock to protect - -*/ + * caller : defrag ; recvframe_chk_defrag in recv_thread (passive) + * pframequeue: defrag_queue : will be accessed in recv_thread (passive) + * + * using spinlock to protect + * + */ =20 void rtw_free_recvframe_queue(struct __queue *pframequeue, struct __queue= *pfree_recv_queue) { @@ -1745,9 +1745,11 @@ static int recv_func(struct adapter *padapter, struc= t recv_frame *rframe) !psecuritypriv->busetkipkey) { rtw_enqueue_recvframe(rframe, &padapter->recvpriv.uc_swdec_pending_queu= e); if (recvpriv->free_recvframe_cnt < NR_RECVFRAME / 4) { - /* to prevent from recvframe starvation, + /* + * to prevent from recvframe starvation, * get recvframe from uc_swdec_pending_queue to - * free_recvframe_cnt */ + * free_recvframe_cnt + */ rframe =3D rtw_alloc_recvframe(&padapter->recvpriv.uc_swdec_pending_qu= eue); if (rframe) goto do_posthandle; --=20 2.36.1 From nobody Mon Apr 20 05:55:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11084C43334 for ; Wed, 22 Jun 2022 04:53:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356632AbiFVExh (ORCPT ); Wed, 22 Jun 2022 00:53:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356985AbiFVExQ (ORCPT ); Wed, 22 Jun 2022 00:53:16 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A95C62C8 for ; Tue, 21 Jun 2022 21:53:16 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id g10-20020a17090a708a00b001ea8aadd42bso15649264pjk.0 for ; Tue, 21 Jun 2022 21:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Oisc3ypggyVnyacN2ACuhTwt037Hx2/ibOP/qwTmzmU=; b=PVrUG220AsrmlyFyxNgPrSWgswrgOZf8ZNb+VHT7wS+RW3rSrqHyF+DlzZyDveDd4Q SSI23m2ke1gsb3DASZa1iSCbcnJ9GFgDgX98JSmWHsEJ4ePFxVLHljwGvchcvH8zQ3it /R7kWJ4qmFb1QV7ceejbyMy3OuPXpQA7pZeu7zc2sGkLBVZY3kyQga2RLvGhG4G4spih tiuwlezt2jbeffgfiMtQ2TMvOFIm8RGZ5QD4q7SvAddNrdFj8xigbauGk7WaroEqyLNf w5NFce1bAzLgjtUrHqP0SwnsvEC8dt16DPPIHqwjRF4fDaS0bEGPKF0igtW6PFLKFzLk xGJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Oisc3ypggyVnyacN2ACuhTwt037Hx2/ibOP/qwTmzmU=; b=gBWq2yNJuTw6S9nHvOItI47ZbgEA5zA+wPkxsENAjp2xAH+Q88M9MqrAj1Ji7g8vxD tWIMOfLmNIhkdT3iw1w4yxxzieqi7agutPGlBVE23XKktj0PKC+at7mThuo3jNCQJZyg BaIlwACy+DZPKJmdMId4jCFFxZu33h/G9K9lXdbjDn9jXzOPp2qQhH/t3NkstM7YDh/Z 6cmsyxYYVEB42NtFVtnGPhem9yTjuzJnQVbGSD/cpQtOsb1VBPqhSq/rrViyZJyhcWLQ bHUpodBnmOPqsALxJ8K69xbe7n7I9eCIcTDSDX9gjlvQGLy8wVaHb5S/89P7O8odXgeO uBWA== X-Gm-Message-State: AJIora8Y6+F17x7xg89VBZDQ5Z7smhEIbA+zXOvsnXlrQLWYPr7Gelwp IWEKBOH3T4vf3UnRAH6Bo5XCX76suO4gDQ== X-Google-Smtp-Source: AGRyM1tT/GLbMa+q3rLUJIL3USM5y4dOGHfH6GxOWQWV4OcuSThJ7MBwIuWxdOMNMuE693UmFNU6iQ== X-Received: by 2002:a17:902:d504:b0:16a:4846:3f46 with SMTP id b4-20020a170902d50400b0016a48463f46mr1596164plg.159.1655873595633; Tue, 21 Jun 2022 21:53:15 -0700 (PDT) Received: from localhost (c-67-180-87-133.hsd1.ca.comcast.net. [67.180.87.133]) by smtp.gmail.com with ESMTPSA id j1-20020a170903028100b0015e8d4eb24fsm11542908plr.153.2022.06.21.21.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 21:53:15 -0700 (PDT) From: Chang Yu To: Larry.Finger@lwfinger.net Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Chang Yu Subject: [PATCH 5/5] staging: r8188eu: Fixed some blank line coding style issues Date: Tue, 21 Jun 2022 21:52:34 -0700 Message-Id: X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Added blank lines after variable declarations as per checkpatch.pl Signed-off-by: Chang Yu Tested-by: Philipp Hortmann # Edimax N150=20 --- drivers/staging/r8188eu/core/rtw_recv.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r818= 8eu/core/rtw_recv.c index 14dd2344fa4b..cc91638a085d 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -237,6 +237,7 @@ u32 rtw_free_uc_swdec_pending_queue(struct adapter *ada= pter) { u32 cnt =3D 0; struct recv_frame *pending_frame; + while ((pending_frame =3D rtw_alloc_recvframe(&adapter->recvpriv.uc_swdec= _pending_queue))) { rtw_free_recvframe(pending_frame, &adapter->recvpriv.free_recv_queue); cnt++; @@ -327,6 +328,7 @@ static struct recv_frame *decryptor(struct adapter *pad= apter, struct recv_frame =20 if (prxattrib->encrypt > 0) { u8 *iv =3D precv_frame->rx_data + prxattrib->hdrlen; + prxattrib->key_index =3D (((iv[3]) >> 6) & 0x3); =20 if (prxattrib->key_index > WEP_KEYS) { @@ -777,6 +779,7 @@ static int sta2ap_data_frame(struct adapter *adapter, } } else { u8 *myhwaddr =3D myid(&adapter->eeprompriv); + if (memcmp(pattrib->ra, myhwaddr, ETH_ALEN)) { ret =3D RTW_RX_HANDLED; goto exit; @@ -1022,6 +1025,7 @@ static int validate_recv_frame(struct adapter *adapte= r, struct recv_frame *precv =20 if (pmlmeext->sitesurvey_res.state =3D=3D SCAN_PROCESS) { int ch_set_idx =3D rtw_ch_set_search_ch(pmlmeext->channel_set, rtw_get_o= per_ch(adapter)); + if (ch_set_idx >=3D 0) pmlmeext->channel_set[ch_set_idx].rx_count++; } @@ -1049,6 +1053,7 @@ static int validate_recv_frame(struct adapter *adapte= r, struct recv_frame *precv retval =3D validate_recv_data_frame(adapter, precv_frame); if (retval =3D=3D _FAIL) { struct recv_priv *precvpriv =3D &adapter->recvpriv; + precvpriv->rx_drop++; } } @@ -1312,9 +1317,11 @@ static int amsdu_to_msdu(struct adapter *padapter, s= truct recv_frame *prframe) struct rx_pkt_attrib *pattrib; unsigned char *data_ptr; struct sk_buff *sub_skb, *subframes[MAX_SUBFRAME_COUNT]; + struct recv_priv *precvpriv =3D &padapter->recvpriv; struct __queue *pfree_recv_queue =3D &precvpriv->free_recv_queue; int ret =3D _SUCCESS; + nr_subframes =3D 0; =20 pattrib =3D &prframe->attrib; --=20 2.36.1