From nobody Sun Apr 26 09:35:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D4FC433EF for ; Sun, 19 Jun 2022 19:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234554AbiFSTm6 (ORCPT ); Sun, 19 Jun 2022 15:42:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233518AbiFSTmx (ORCPT ); Sun, 19 Jun 2022 15:42:53 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08F8F6250 for ; Sun, 19 Jun 2022 12:42:53 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id o18so951179plg.2 for ; Sun, 19 Jun 2022 12:42:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lnwBlfKsLcAz6io0BTwqY0usDb2Nda3s24yxh9Wy1vs=; b=Ig0kvXXHf61H2AJL6sWPLdtzgUeN7hX9Y81ip+5VYrCz0eaZTiSv/KQiwbV+lTOaTf pf9thO2GRs7hjeNMdlebIwegofPk/9fVnsFtClaISQ/jULIcj6dzydGvLGEOAgz6vlOZ hLqJ28hWh6wcYgz7gFEr2We/DAPjqbg7NpS/iof7iqohExxFad6WmDOkUdGXQX0B5jDR zdXHl1hkMmkY0qW7t9VDQ+WcE+vCL9t8A6RGbSNeEy6MiSc1HkF2OGlF5uh5VjkWt88a erjeeABx4srqKpuH3ya+IMRo2vhpxC1X6OEIAlC3wTsJ9EOTYxWZQ2Vd2gNzR826Ow3X i+Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lnwBlfKsLcAz6io0BTwqY0usDb2Nda3s24yxh9Wy1vs=; b=1ECnS6hriutQ6YeKazCg26G0TSu2M3NFvVZcKuUm5oYT2WLDQ0WiPkQ3/qK01nHKeg cWDKU8d84qrefxw2At6/qbhRC2ue8QpGBzBHv6U1fT24OMiYgLGN8AhBrFVb5Xb8tc3n QoPybkNKYstxHA5JBDJcRLYtr6ZXqDoBXu1SVOACEAlGOrd8Il/z2+B8X1rdJaNP7Jsz C1Qvrpj1D2sY9ylaGYF4nmmFHPEZ0p4YSJek/L7R6DGtfRuSRNt5Kug8IEbSNajO6oK/ VTtysdzO7BGZb4xOKbI4ZWuPF0jQGRRbuyWdFGzcOYajcdOdv8nDpOWZywAhgIIXIWvZ RJbw== X-Gm-Message-State: AJIora/ZzM/JLN+yhRyzawGT+s8QhppNIoL+cDjEfF4fQTvQ1tREVFPc pmA8lWMmv7HTRD4tX2gQMUAGgYI9hjOqQr9+ X-Google-Smtp-Source: AGRyM1u/kMveQHb5unIS+o39fAdYB7p0WXj1hjykHwdfWYZ4Ca4PRIB2OBzQVBJGkmh3oOnPiQeM9A== X-Received: by 2002:a17:90a:4209:b0:1df:b907:ed3d with SMTP id o9-20020a17090a420900b001dfb907ed3dmr23188142pjg.40.1655667772515; Sun, 19 Jun 2022 12:42:52 -0700 (PDT) Received: from localhost (c-67-180-87-133.hsd1.ca.comcast.net. [67.180.87.133]) by smtp.gmail.com with ESMTPSA id b8-20020a170902650800b00167942e0ee9sm7150970plk.61.2022.06.19.12.42.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jun 2022 12:42:52 -0700 (PDT) From: Chang Yu To: Larry.Finger@lwfinger.net, paskripkin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Chang Yu Subject: [PATCH v2 1/5] Staging: r8188eu: core: rtw_xmit: Fixed some whitespace coding style issues Date: Sun, 19 Jun 2022 12:42:27 -0700 Message-Id: <841716cec5032ad706fbee8677e1b67aec8ad736.1655666628.git.marcus.yu.56@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Removed superfluous blank lines and added blank lines after variable declarations as per checkpath.pl Signed-off-by: Chang Yu Tested-by: Philipp Hortmann # Edimax N150=20 --- drivers/staging/r8188eu/core/rtw_xmit.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r818= 8eu/core/rtw_xmit.c index 3d8e9dea7651..1aa284453ab2 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -16,16 +16,13 @@ static u8 RFC1042_OUI[P80211_OUI_LEN] =3D { 0x00, 0x00,= 0x00 }; =20 static void _init_txservq(struct tx_servq *ptxservq) { - INIT_LIST_HEAD(&ptxservq->tx_pending); rtw_init_queue(&ptxservq->sta_pending); ptxservq->qcnt =3D 0; - } =20 void _rtw_init_sta_xmit_priv(struct sta_xmit_priv *psta_xmitpriv) { - memset((unsigned char *)psta_xmitpriv, 0, sizeof(struct sta_xmit_priv)); spin_lock_init(&psta_xmitpriv->lock); _init_txservq(&psta_xmitpriv->be_q); @@ -34,7 +31,6 @@ void _rtw_init_sta_xmit_priv(struct sta_xmit_priv *psta_x= mitpriv) _init_txservq(&psta_xmitpriv->vo_q); INIT_LIST_HEAD(&psta_xmitpriv->legacy_dz); INIT_LIST_HEAD(&psta_xmitpriv->apsd); - } =20 s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padap= ter) @@ -300,6 +296,7 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * /* check HT op mode */ if (pattrib->ht_en) { u8 htopmode =3D pmlmeinfo->HT_protection; + if ((pmlmeext->cur_bwmode && (htopmode =3D=3D 2 || htopmode =3D=3D 3))= || (!pmlmeext->cur_bwmode && htopmode =3D=3D 3)) { pattrib->vcs_mode =3D RTS_CTS; @@ -450,6 +447,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p /* The following is for DHCP and ARP packet, we use cck1M to tx these p= ackets and let LPS awake some time */ /* to prevent DHCP protocol fail */ u8 tmp[24]; + _rtw_pktfile_read(&pktfile, &tmp[0], 24); pattrib->dhcp_pkt =3D 0; if (pktfile.pkt_len > 282) {/* MINIMUM_DHCP_PACKET_SIZE) { */ @@ -1069,7 +1067,6 @@ void rtw_update_protection(struct adapter *padapter, = u8 *ie, uint ie_len) } break; } - } =20 void rtw_count_tx_stats(struct adapter *padapter, struct xmit_frame *pxmit= frame, int sz) @@ -1316,7 +1313,6 @@ void rtw_free_xmitframe_queue(struct xmit_priv *pxmit= priv, struct __queue *pfram rtw_free_xmitframe(pxmitpriv, pxmitframe); } spin_unlock_bh(&pframequeue->lock); - } =20 s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxm= itframe) @@ -1515,7 +1511,6 @@ void rtw_init_hwxmits(struct hw_xmit *phwxmit, int en= try) =20 for (i =3D 0; i < entry; i++, phwxmit++) phwxmit->accnt =3D 0; - } =20 static int rtw_br_client_tx(struct adapter *padapter, struct sk_buff **psk= b) --=20 2.36.1 From nobody Sun Apr 26 09:35:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A65C43334 for ; Sun, 19 Jun 2022 19:43:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235704AbiFSTnC (ORCPT ); Sun, 19 Jun 2022 15:43:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234252AbiFSTmz (ORCPT ); Sun, 19 Jun 2022 15:42:55 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09A045586 for ; Sun, 19 Jun 2022 12:42:55 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id m2so753606plx.3 for ; Sun, 19 Jun 2022 12:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5yhbMYbX4HtRbzfEZJFo8LMvIa5s7zM2myB/V/KkweM=; b=Yy/mGjXKRM7R5k3PY1YFCGE0du4sujyFxeyANLLNCMTtbH+D1CVDSswsskmtK+2a/p CSXJAYS+qcRgqAkaJJQzi5RhFrbmGgmJgyvpIKzpT0b3CyFId/bpE2aKxRY0kzoP60ht PVbiE9Uq17Q40A3LJOFPb+PlphuYJkVXMjfQUDwKxkOOjpzyaeP/jyJ2LnlkIc5OmAGW gqegbLrPTZxaGRf4mxCKcWv+14YVoLqkZDQhexsuX6UM6ayn9Y2i/QzRINuMhP24x0bH VjptmHic8Vin1k4LoyHZpDwYakw44xBlJuEFM+TsXXHBgtpV2gh+K+pN/HTNH0xDEJHa hbLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5yhbMYbX4HtRbzfEZJFo8LMvIa5s7zM2myB/V/KkweM=; b=1VJWmVhJd4Zhs8gjGEAb/fDJBOWtMtSwjdp4cS0P8WlRNLllCf83LyFj7aPhADrHMa kQAufe5ADdwZWLR1O+EYS+NoXsdhmvfFaFbFZS3/1cY2/1XOIJha2Oa7eXiRg8donDfe 48wHJggB9bOlrEbUSgXdn23SzgNOTqWUyPaGRmIo8CXhCDonef5v9txKFlGdPbDidcUP sFo5lGV4z9lUWwDahR9F6Enx3i3X7hIhAGyi06AZqKFUCBoLw9EvmZ1NU65oYPcYAc8K mMK5Y257sLwsTpE54AfcCCw9/QEj/B5uXUOooa+hbXK88FtkPk5Uev+hal5NhkE3vhXg VjUg== X-Gm-Message-State: AJIora8/jZNuVVmDB+bazZ/OUpLjyHBckbhE9MgUu6PaOAkyY+YJzaAC wqyQjJE3weDWX67ucHsjBjQ= X-Google-Smtp-Source: AGRyM1vQ72ZXZU1v51U4BZ0gIX1RMl7fcXKPbeGXpZBkq5C5G/h3PY58XOL60Q4LLgg5AKHC6zEMAg== X-Received: by 2002:a17:90b:4c07:b0:1e8:2961:e318 with SMTP id na7-20020a17090b4c0700b001e82961e318mr22787751pjb.151.1655667774538; Sun, 19 Jun 2022 12:42:54 -0700 (PDT) Received: from localhost (c-67-180-87-133.hsd1.ca.comcast.net. [67.180.87.133]) by smtp.gmail.com with ESMTPSA id p12-20020a637f4c000000b003fc4001fd5fsm7483584pgn.10.2022.06.19.12.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jun 2022 12:42:54 -0700 (PDT) From: Chang Yu To: Larry.Finger@lwfinger.net, paskripkin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Chang Yu Subject: [PATCH v2 2/5] Staging: r8188eu: core: rtw_xmit: Fixed two indentation coding style issues. Date: Sun, 19 Jun 2022 12:42:28 -0700 Message-Id: <6b0e3efe83bf06ea60cdbe27f31f6f3aa1058f01.1655666628.git.marcus.yu.56@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fixed two indentation issues. Signed-off-by: Chang Yu Tested-by: Philipp Hortmann # Edimax N150=20 --- drivers/staging/r8188eu/core/rtw_xmit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r818= 8eu/core/rtw_xmit.c index 1aa284453ab2..2bc059808a71 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -626,7 +626,7 @@ static s32 xmitframe_addmic(struct adapter *padapter, s= truct xmit_frame *pxmitfr if (pframe[1] & 2) /* From Ds =3D=3D 1 */ rtw_secmicappend(&micdata, &pframe[24], 6); else - rtw_secmicappend(&micdata, &pframe[10], 6); + rtw_secmicappend(&micdata, &pframe[10], 6); } else { /* ToDS =3D=3D 0 */ rtw_secmicappend(&micdata, &pframe[4], 6); /* DA */ if (pframe[1] & 2) /* From Ds =3D=3D 1 */ @@ -1737,7 +1737,7 @@ int xmitframe_enqueue_for_sleeping_sta(struct adapter= *padapter, struct xmit_fra bool bmcst =3D is_multicast_ether_addr(pattrib->ra); =20 if (!check_fwstate(pmlmepriv, WIFI_AP_STATE)) - return ret; + return ret; =20 if (pattrib->psta) psta =3D pattrib->psta; --=20 2.36.1 From nobody Sun Apr 26 09:35:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C695BC43334 for ; Sun, 19 Jun 2022 19:43:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236209AbiFSTnG (ORCPT ); Sun, 19 Jun 2022 15:43:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234498AbiFSTm6 (ORCPT ); Sun, 19 Jun 2022 15:42:58 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5CD66343 for ; Sun, 19 Jun 2022 12:42:56 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id g10-20020a17090a708a00b001ea8aadd42bso8437617pjk.0 for ; Sun, 19 Jun 2022 12:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yjFKNxuzMVouA/d7fakclf85AnSbfILJPYcTGegW5qw=; b=UwCbSawCcCT1UcHKQ3M2FG2+4vDf7xUy5BppVWuP8zcEKMltcHzlCAU9goZZhKkMuK GfjHBPV8O9uLFM2m9jImf+0vJfn4Sl07FyTaDimQwH7vHiqg87j+tfXRYOCOYFPYyUWt 608BGhM6JUS1iTw7GI1JxTlUYSwTlphnMW9L461Fo25xd3kZf8LUCfAL5WC/I50THChc b9iQQenIDMvMqRnqmHhFDWwh/AvdAS/BeE1jkF1Z1DFJmctUDJmcHs/tXr5dbNLWELMY iCoXmQyZROu8bUcW0fHaKdKf+saodmPhJvQUied7GtTgkM3pJ0feN5cBPwNpyAwYZwgu Brhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yjFKNxuzMVouA/d7fakclf85AnSbfILJPYcTGegW5qw=; b=rtIRzqlrneQHL8v8WSrBOReJZjE6Z9zZTkxFRkq5vWgHJHpb1SHfLwix5QNMyFtsmq cDpElj71UFlJNZKrxSa/jILxfD9CP++tfUhuLoLZQoyYAu85pLOn4FbtR6wepT8Ff+iC XrPVSxMK/9ilbbTH1/PhmbRxGnWTxp1GyfUtsfWpvNF+dlJgecQBDbIAJmf1qwDwY0Fx X94Rye0zdoyjULyc/Wm167dJZvBzsLJq8O1gODiyFxd4FtqJyF0Q53L7U0PmEvst+SsT G8ONlTZo7fbs746pW18MhV1L3pS+w4u/4j8fNP3BRRU9KEwtnhOaaI5lTF96Xn/n/ddo O+jg== X-Gm-Message-State: AJIora9AwggmFia8OhGYjHEIMHImB9en/setWn6s53ZQJveo9qSvOCwl +XPoNzaiJbcldsLALPAMmcM= X-Google-Smtp-Source: AGRyM1sB6AxmQpzfGNf7BsMzM2Ds5TDND0OugBJof33s1XvvM2leHIW8TPCsJ7tM0vdaZnhc0TKb0Q== X-Received: by 2002:a17:902:bc84:b0:167:80c6:aedd with SMTP id bb4-20020a170902bc8400b0016780c6aeddmr20759705plb.97.1655667776376; Sun, 19 Jun 2022 12:42:56 -0700 (PDT) Received: from localhost (c-67-180-87-133.hsd1.ca.comcast.net. [67.180.87.133]) by smtp.gmail.com with ESMTPSA id q3-20020a170902edc300b0016370e1af6bsm7129923plk.128.2022.06.19.12.42.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jun 2022 12:42:55 -0700 (PDT) From: Chang Yu To: Larry.Finger@lwfinger.net, paskripkin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Chang Yu Subject: [PATCH v2 3/5] Staging: r8188eu: core: rtw_xmit: Fixed some spelling errors in the comments Date: Sun, 19 Jun 2022 12:42:29 -0700 Message-Id: <8d2f49631551b53ad970c9165cceb845c4d60b75.1655666628.git.marcus.yu.56@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fixed the spelling of "broadcast" and "update" in the comments. Signed-off-by: Chang Yu Tested-by: Philipp Hortmann # Edimax N150=20 --- drivers/staging/r8188eu/core/rtw_xmit.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r818= 8eu/core/rtw_xmit.c index 2bc059808a71..73eb2f01c176 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -957,7 +957,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, st= ruct sk_buff *pkt, struct } =20 if (bmcst) { - /* don't do fragment to broadcat/multicast packets */ + /* don't do fragment to broadcast/multicast packets */ mem_sz =3D _rtw_pktfile_read(&pktfile, pframe, pattrib->pktlen); } else { mem_sz =3D _rtw_pktfile_read(&pktfile, pframe, mpdu_len); @@ -1765,8 +1765,8 @@ int xmitframe_enqueue_for_sleeping_sta(struct adapter= *padapter, struct xmit_fra =20 pstapriv->tim_bitmap |=3D BIT(0);/* */ pstapriv->sta_dz_bitmap |=3D BIT(0); - - update_beacon(padapter, _TIM_IE_, NULL, false);/* tx bc/mc packets afte= r upate bcn */ + /* tx bc/mc packets after update bcn */ + update_beacon(padapter, _TIM_IE_, NULL, false); =20 ret =3D true; } @@ -1816,7 +1816,7 @@ int xmitframe_enqueue_for_sleeping_sta(struct adapter= *padapter, struct xmit_fra pstapriv->tim_bitmap |=3D BIT(psta->aid); =20 if (psta->sleepq_len =3D=3D 1) { - /* upate BCN for TIM IE */ + /* update BCN for TIM IE */ update_beacon(padapter, _TIM_IE_, NULL, false); } } @@ -2085,7 +2085,7 @@ void xmit_delivery_enabled_frames(struct adapter *pad= apter, struct sta_info *pst if ((psta->sleepq_ac_len =3D=3D 0) && (!psta->has_legacy_ac) && (wmmps_a= c)) { pstapriv->tim_bitmap &=3D ~BIT(psta->aid); =20 - /* upate BCN for TIM IE */ + /* update BCN for TIM IE */ update_beacon(padapter, _TIM_IE_, NULL, false); } } --=20 2.36.1 From nobody Sun Apr 26 09:35:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4015CC433EF for ; Sun, 19 Jun 2022 19:43:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236367AbiFSTnK (ORCPT ); Sun, 19 Jun 2022 15:43:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234474AbiFSTnA (ORCPT ); Sun, 19 Jun 2022 15:43:00 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD1476267 for ; Sun, 19 Jun 2022 12:42:58 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id p5so2648630pjt.2 for ; Sun, 19 Jun 2022 12:42:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p64PM6E0TGRLi7vOtiUccETzM6tLKB5mp4MOcHiJCCA=; b=otsj+QWi/QqeRrqbbivddkYBK20Ow+ZA4auexlE+f5RNCTdE/E4TEHi/VQFGmqpD+N ilyCyLzeA48sbbxX6wqYF0Y+Gn3kcTNLVuGjhClY+TRss1eJwShYgMb0o2ga6d0U1Up6 3m7+Bu8X7P8k5/l0NndJoFXmQ26IaYFyZn9vt2j91Pe41JqeKF/OdnC1GiC7RUzqtHq6 ks423bAssMsHYdHbysdQnP3VlXmpo9QteOvJl9IS9GefCqLo8rSZI18y31iSgqLAKzjf jDhWB6hQu9ZX60ExUevPFytfiIlP8R35yuwerqZH4v+Qas+OmxuV9Kao6UEbbATCpYQb urow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p64PM6E0TGRLi7vOtiUccETzM6tLKB5mp4MOcHiJCCA=; b=RkrunJKBDWKVgkrvozmqDGq2Kt9tHgnRpCM6eBNrsiXMehEWIJobWWDVUBkfZlRBiM g/F5EUyxPVXhGTYRBnZ1DQD3IAAJbbje6JIgTyhJS7dcKogPsMjxjV7fWniECzzCRyOj YErTHDgiuurQ6pu2Cd1OnJHgBzB5/H2wUptWaf2VfHjRznDatv6+/5JsHADLpQ3orchb uEbnW766Ht3mD5CpFOvykHPS93GBRBmvNMmPen8NKhwx0pVv/6Pd/3WnSmNQQkAmUemP llpassh2gF3icV53J22qAaz07HBk8MV6VoDrFh+aCkgZoD5r+7GIOOIF9o9jqKPvjIFG izhw== X-Gm-Message-State: AJIora+ViGv1arg0TRZXOCEdsNyjUs0JlfE/PWSwfUXiYSRlttARHQ4u MIhCyKjzEd/m8jOzIy7hcEnqouA5LN4iRk7b X-Google-Smtp-Source: AGRyM1tTEVPq8AxeR+Q/BVmPnVdkXz2lZ/RQFuYV0erbmazTI/xk0cGSEi1l1XGP5xwHiWwxFuuUrQ== X-Received: by 2002:a17:90b:17c7:b0:1e8:5136:c32a with SMTP id me7-20020a17090b17c700b001e85136c32amr22873247pjb.43.1655667778131; Sun, 19 Jun 2022 12:42:58 -0700 (PDT) Received: from localhost (c-67-180-87-133.hsd1.ca.comcast.net. [67.180.87.133]) by smtp.gmail.com with ESMTPSA id z4-20020a62d104000000b005180c127200sm7370805pfg.24.2022.06.19.12.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jun 2022 12:42:57 -0700 (PDT) From: Chang Yu To: Larry.Finger@lwfinger.net, paskripkin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Chang Yu Subject: [PATCH v2 4/5] Staging: r8188eu: core: rtw_xmit: Fixed a brace coding style issue Date: Sun, 19 Jun 2022 12:42:30 -0700 Message-Id: X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Removed superfluous brackets around a if clause as per checkpatch.pl Signed-off-by: Chang Yu Tested-by: Philipp Hortmann # Edimax N150=20 --- drivers/staging/r8188eu/core/rtw_xmit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r818= 8eu/core/rtw_xmit.c index 73eb2f01c176..6797335f7855 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -952,9 +952,8 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, st= ruct sk_buff *pkt, struct mpdu_len -=3D llc_sz; } =20 - if ((pattrib->icv_len > 0) && (pattrib->bswenc)) { + if ((pattrib->icv_len > 0) && (pattrib->bswenc)) mpdu_len -=3D pattrib->icv_len; - } =20 if (bmcst) { /* don't do fragment to broadcast/multicast packets */ --=20 2.36.1 From nobody Sun Apr 26 09:35:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA233C433EF for ; Sun, 19 Jun 2022 19:43:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233518AbiFSTnM (ORCPT ); Sun, 19 Jun 2022 15:43:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234744AbiFSTnB (ORCPT ); Sun, 19 Jun 2022 15:43:01 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 686076350 for ; Sun, 19 Jun 2022 12:43:00 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id s185so2738733pgs.3 for ; Sun, 19 Jun 2022 12:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1QG1QV5jcE/qCLfJfakMMrZfmCDBIgHiC1TqIeZ6eiw=; b=Bg5wNP2vtH4T5PvHSN81HgF4Uq+0i1xgkp7/rVE1jy1X7tSe1mgVoMRU34u5KY6iMP XMYUI5pRSUiHRzHyYcXZyP+5PmaKwWlA/owFceB9cXDNkWntzekvzSDCpbvFqaJcNyhp zzvYj/jDCf9PbS7McbEgvyEgSf7afOhu+tZXwFWQIPocHx720KDHhGMpDvcwRvfosY7s uWNdPZtMOGsKtT1bqJZdSqwBaPi5IMvm/6flXaE8T7hPaSRf5hHMVZg570GWmcXmWQD7 H1yLXbefH6NIGPYxYyr959h/+CJjY8H0EfikLjQLkCqUd2VCgm15pCkrLSglyi0Y38vg Qs0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1QG1QV5jcE/qCLfJfakMMrZfmCDBIgHiC1TqIeZ6eiw=; b=InLt9nsLbGKyPPBeJAb0T+PsPNTeXqvSOeHsCVUz1vdgUo3QzCK+/A36DXyQNBspNg IP0IjzsyJSb1/UVLntNOzC86AkEt5g04Di5qFCkhLTd5MCFNpjsFtCLjMvtaXVZiJVkC 1wQSHNiTyIbr5GoqSc006AP5hNgIEvmTT4M3GV2KsvI3/DA4uw/CVvLFlyNeiM09GUPK vmQzsBRZFIpbQs5fN60LrksvctqqepLl+4Pr4objtZdR7SwmBlYjqBVnY+nOayOkD5LN UI0fk9VBEmTC1qCQcQaj4K8+qPCfG6gV3Sli2P7fggQxVzdmGbQUZMdnBhMCk4017ZgJ V7qg== X-Gm-Message-State: AJIora+fyGWyUyTOzJOHD+3d8PqdWz2ZBRfK29dzkC7fkL+g5tGs53ZZ //r7Dqq+sCrGSeDAPEnBKeE= X-Google-Smtp-Source: AGRyM1vZOBA2oL/DgQZnkKqx/28nVDqd8GC8NhYH4bNg9UxNtjFJlAKA+akFEVtuVNGCjb7xRWETHw== X-Received: by 2002:a63:7d44:0:b0:40c:8cb1:eeaa with SMTP id m4-20020a637d44000000b0040c8cb1eeaamr6450551pgn.597.1655667779852; Sun, 19 Jun 2022 12:42:59 -0700 (PDT) Received: from localhost (c-67-180-87-133.hsd1.ca.comcast.net. [67.180.87.133]) by smtp.gmail.com with ESMTPSA id i185-20020a626dc2000000b0051bf9159d2dsm7406414pfc.208.2022.06.19.12.42.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jun 2022 12:42:59 -0700 (PDT) From: Chang Yu To: Larry.Finger@lwfinger.net, paskripkin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Chang Yu Subject: [PATCH v2 5/5] Staging: r8188eu: core: rtw_xmit: Fixed a coding style issue Date: Sun, 19 Jun 2022 12:42:31 -0700 Message-Id: X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Moved the constant ETH_P_IP to the right hand side of the comparison as per checkpatch.pl Signed-off-by: Chang Yu Tested-by: Philipp Hortmann # Edimax N150=20 --- drivers/staging/r8188eu/core/rtw_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r818= 8eu/core/rtw_xmit.c index 6797335f7855..943422141c8b 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -443,7 +443,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p =20 pattrib->pktlen =3D pktfile.pkt_len; =20 - if (ETH_P_IP =3D=3D pattrib->ether_type) { + if (pattrib->ether_type =3D=3D ETH_P_IP) { /* The following is for DHCP and ARP packet, we use cck1M to tx these p= ackets and let LPS awake some time */ /* to prevent DHCP protocol fail */ u8 tmp[24]; --=20 2.36.1