From nobody Mon Apr 27 07:24:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7AC5C433EF for ; Wed, 15 Jun 2022 17:17:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348767AbiFORRR (ORCPT ); Wed, 15 Jun 2022 13:17:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346469AbiFORRJ (ORCPT ); Wed, 15 Jun 2022 13:17:09 -0400 Received: from challenge-bot.com (challenge-bot.com [IPv6:2602:fffa:fff:108a:0:16:3e15:92b8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7AC9381B7 for ; Wed, 15 Jun 2022 10:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=challenge-bot.com; s=20180430; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=FgBxiGnfGrCDvBNxSUTPi2WkWIMaKs3eEhesYlN4HNQ=; b=Ud8UiChSQh/KM827G6GFOfbKFR Z726YXmATZMgmO0rLFjWphayLhbEKitum67LIhMoYIv2xUkpjrbd9Tj2OlypC9CCdFpTr4DJFedrf KHQbTpYJuGTb6O89HtlQYJMrOUZTRSd2dzSCBNI3Z1kQVa2NzH0YQqzM/41nigBDdgFc=; Received: from ozzloy by challenge-bot.com with local (Exim 4.92) (envelope-from ) id 1o1Wdd-0005iU-PG; Wed, 15 Jun 2022 10:17:05 -0700 From: daniel watson To: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Daniel Watson Subject: [PATCH v3 1/4] staging: r8188eu: call rtw_IOL_append_WB_cmd directly Date: Wed, 15 Jun 2022 10:17:00 -0700 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Daniel Watson Call rtw_IOL_append_WB_cmd directly, instead of using wrapper macro. Delete wrapper macro, which is not needed. Signed-off-by: Daniel Watson --- Changes in v2: - Make the commit message clearer Changes in v3: - fix typo in first line "Call rtf..." -> "Call rtw..." Note: This code has not been run on hardware. drivers/staging/r8188eu/core/rtw_iol.c | 2 +- drivers/staging/r8188eu/include/rtw_iol.h | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_iol.c b/drivers/staging/r8188= eu/core/rtw_iol.c index af8e84a41b851..8c990b1af5a70 100644 --- a/drivers/staging/r8188eu/core/rtw_iol.c +++ b/drivers/staging/r8188eu/core/rtw_iol.c @@ -67,7 +67,7 @@ bool rtw_IOL_applied(struct adapter *adapter) return false; } =20 -int _rtw_IOL_append_WB_cmd(struct xmit_frame *xmit_frame, u16 addr, u8 val= ue, u8 mask) +int rtw_IOL_append_WB_cmd(struct xmit_frame *xmit_frame, u16 addr, u8 valu= e, u8 mask) { struct ioreg_cfg cmd =3D {8, IOREG_CMD_WB_REG, 0x0, 0x0, 0x0}; =20 diff --git a/drivers/staging/r8188eu/include/rtw_iol.h b/drivers/staging/r8= 188eu/include/rtw_iol.h index fb88ebc1dabb1..a648f9ba50a62 100644 --- a/drivers/staging/r8188eu/include/rtw_iol.h +++ b/drivers/staging/r8188eu/include/rtw_iol.h @@ -41,16 +41,14 @@ int rtw_IOL_append_END_cmd(struct xmit_frame *xmit_fram= e); void read_efuse_from_txpktbuf(struct adapter *adapter, int bcnhead, u8 *content, u16 *size); =20 -int _rtw_IOL_append_WB_cmd(struct xmit_frame *xmit_frame, u16 addr, - u8 value, u8 mask); +int rtw_IOL_append_WB_cmd(struct xmit_frame *xmit_frame, u16 addr, + u8 value, u8 mask); int _rtw_IOL_append_WW_cmd(struct xmit_frame *xmit_frame, u16 addr, u16 value, u16 mask); int _rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr, u32 value, u32 mask); int _rtw_IOL_append_WRF_cmd(struct xmit_frame *xmit_frame, u8 rf_path, u16 addr, u32 value, u32 mask); -#define rtw_IOL_append_WB_cmd(xmit_frame, addr, value, mask) \ - _rtw_IOL_append_WB_cmd((xmit_frame), (addr), (value) ,(mask)) #define rtw_IOL_append_WW_cmd(xmit_frame, addr, value, mask) \ _rtw_IOL_append_WW_cmd((xmit_frame), (addr), (value),(mask)) #define rtw_IOL_append_WD_cmd(xmit_frame, addr, value, mask) \ --=20 2.34.1 From nobody Mon Apr 27 07:24:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CEECC433EF for ; Wed, 15 Jun 2022 17:17:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349289AbiFORRV (ORCPT ); Wed, 15 Jun 2022 13:17:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346528AbiFORRJ (ORCPT ); Wed, 15 Jun 2022 13:17:09 -0400 Received: from challenge-bot.com (challenge-bot.com [IPv6:2602:fffa:fff:108a:0:16:3e15:92b8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E47F3616F for ; Wed, 15 Jun 2022 10:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=challenge-bot.com; s=20180430; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WlExQDboUBB3aNQneLRIPLnOzP5E0AYkRUI3hfSOlME=; b=HV/XIvbpsy1UqyiqTKVjmbuB1j W1B/ypp3/YgWPgrMxBfByt9CrJhoRad85QVdoyGzggPKq51b01XC63aYMBM0/MB7531pmVrRfXnWP UyAfn8WTjoegm/jmRSKP78DVQK2jqBh2iEOXAefUuxSD5GdSATLIzYAZ1YVynVG/IBSw=; Received: from ozzloy by challenge-bot.com with local (Exim 4.92) (envelope-from ) id 1o1Wdd-0005ic-VR; Wed, 15 Jun 2022 10:17:05 -0700 From: daniel watson To: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Daniel Watson Subject: [PATCH v3 2/4] staging: r8188eu: call rtw_IOL_append_WW_cmd directly Date: Wed, 15 Jun 2022 10:17:01 -0700 Message-Id: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Daniel Watson Call rtw_IOL_append_WW_cmd directly, instead of using wrapper macro. Delete wrapper macro, which is not needed. Signed-off-by: Daniel Watson --- Changes in v2: - Make the commit message clearer Changes in v3: - None Note: This code has not been run on hardware. drivers/staging/r8188eu/core/rtw_iol.c | 2 +- drivers/staging/r8188eu/include/rtw_iol.h | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_iol.c b/drivers/staging/r8188= eu/core/rtw_iol.c index 8c990b1af5a70..7292bab126074 100644 --- a/drivers/staging/r8188eu/core/rtw_iol.c +++ b/drivers/staging/r8188eu/core/rtw_iol.c @@ -81,7 +81,7 @@ int rtw_IOL_append_WB_cmd(struct xmit_frame *xmit_frame, = u16 addr, u8 value, u8 return rtw_IOL_append_cmds(xmit_frame, (u8 *)&cmd, cmd.length); } =20 -int _rtw_IOL_append_WW_cmd(struct xmit_frame *xmit_frame, u16 addr, u16 va= lue, u16 mask) +int rtw_IOL_append_WW_cmd(struct xmit_frame *xmit_frame, u16 addr, u16 val= ue, u16 mask) { struct ioreg_cfg cmd =3D {8, IOREG_CMD_WW_REG, 0x0, 0x0, 0x0}; =20 diff --git a/drivers/staging/r8188eu/include/rtw_iol.h b/drivers/staging/r8= 188eu/include/rtw_iol.h index a648f9ba50a62..c99d7d5151099 100644 --- a/drivers/staging/r8188eu/include/rtw_iol.h +++ b/drivers/staging/r8188eu/include/rtw_iol.h @@ -43,14 +43,12 @@ void read_efuse_from_txpktbuf(struct adapter *adapter, = int bcnhead, =20 int rtw_IOL_append_WB_cmd(struct xmit_frame *xmit_frame, u16 addr, u8 value, u8 mask); -int _rtw_IOL_append_WW_cmd(struct xmit_frame *xmit_frame, u16 addr, - u16 value, u16 mask); +int rtw_IOL_append_WW_cmd(struct xmit_frame *xmit_frame, u16 addr, + u16 value, u16 mask); int _rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr, u32 value, u32 mask); int _rtw_IOL_append_WRF_cmd(struct xmit_frame *xmit_frame, u8 rf_path, u16 addr, u32 value, u32 mask); -#define rtw_IOL_append_WW_cmd(xmit_frame, addr, value, mask) \ - _rtw_IOL_append_WW_cmd((xmit_frame), (addr), (value),(mask)) #define rtw_IOL_append_WD_cmd(xmit_frame, addr, value, mask) \ _rtw_IOL_append_WD_cmd((xmit_frame), (addr), (value), (mask)) #define rtw_IOL_append_WRF_cmd(xmit_frame, rf_path, addr, value, mask) \ --=20 2.34.1 From nobody Mon Apr 27 07:24:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A10DC433EF for ; Wed, 15 Jun 2022 17:17:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348841AbiFORRM (ORCPT ); Wed, 15 Jun 2022 13:17:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346601AbiFORRJ (ORCPT ); Wed, 15 Jun 2022 13:17:09 -0400 Received: from challenge-bot.com (challenge-bot.com [IPv6:2602:fffa:fff:108a:0:16:3e15:92b8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 336783CFC9 for ; Wed, 15 Jun 2022 10:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=challenge-bot.com; s=20180430; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4v2/1KwhSvqv2suvBMHiQguilpthdQzKOkqbljh5bEg=; b=LV0sE5lxklmV9BKWMcIW6+x3jA nwmQMwpEUy1B3JN+Zaj6kj2bfnZh6LYwEj2I/Phhb/xyt98higyjweQuaRCbp+tudbHn5bh9yrK45 VED/BhQsrTvFkHY/T5rQDrRviJnx4urXxi5oPzXXMv9akpcZeUeLIfprCku510EvEisc=; Received: from ozzloy by challenge-bot.com with local (Exim 4.92) (envelope-from ) id 1o1Wde-0005ik-63; Wed, 15 Jun 2022 10:17:06 -0700 From: daniel watson To: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Daniel Watson Subject: [PATCH v3 3/4] staging: r8188eu: call rtw_IOL_append_WD_cmd directly Date: Wed, 15 Jun 2022 10:17:02 -0700 Message-Id: <005bbee3575555135be26be9b80a9ceb35d6069f.1655312169.git.ozzloy@challenge-bot.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Daniel Watson Call rtw_IOL_append_WD_cmd directly, instead of using wrapper macro. Delete wrapper macro, which is not needed. Signed-off-by: Daniel Watson --- Changes in v2: - Make the commit message clearer Changes in v3: - None Note: This code has not been run on hardware. drivers/staging/r8188eu/core/rtw_iol.c | 2 +- drivers/staging/r8188eu/include/rtw_iol.h | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_iol.c b/drivers/staging/r8188= eu/core/rtw_iol.c index 7292bab126074..b7ee3833c908c 100644 --- a/drivers/staging/r8188eu/core/rtw_iol.c +++ b/drivers/staging/r8188eu/core/rtw_iol.c @@ -95,7 +95,7 @@ int rtw_IOL_append_WW_cmd(struct xmit_frame *xmit_frame, = u16 addr, u16 value, u1 return rtw_IOL_append_cmds(xmit_frame, (u8 *)&cmd, cmd.length); } =20 -int _rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr, u32 va= lue, u32 mask) +int rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr, u32 val= ue, u32 mask) { struct ioreg_cfg cmd =3D {8, IOREG_CMD_WD_REG, 0x0, 0x0, 0x0}; =20 diff --git a/drivers/staging/r8188eu/include/rtw_iol.h b/drivers/staging/r8= 188eu/include/rtw_iol.h index c99d7d5151099..9ad467759ef1c 100644 --- a/drivers/staging/r8188eu/include/rtw_iol.h +++ b/drivers/staging/r8188eu/include/rtw_iol.h @@ -45,12 +45,10 @@ int rtw_IOL_append_WB_cmd(struct xmit_frame *xmit_frame= , u16 addr, u8 value, u8 mask); int rtw_IOL_append_WW_cmd(struct xmit_frame *xmit_frame, u16 addr, u16 value, u16 mask); -int _rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr, - u32 value, u32 mask); +int rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr, + u32 value, u32 mask); int _rtw_IOL_append_WRF_cmd(struct xmit_frame *xmit_frame, u8 rf_path, u16 addr, u32 value, u32 mask); -#define rtw_IOL_append_WD_cmd(xmit_frame, addr, value, mask) \ - _rtw_IOL_append_WD_cmd((xmit_frame), (addr), (value), (mask)) #define rtw_IOL_append_WRF_cmd(xmit_frame, rf_path, addr, value, mask) \ _rtw_IOL_append_WRF_cmd((xmit_frame),(rf_path), (addr), (value), (mask)) =20 --=20 2.34.1 From nobody Mon Apr 27 07:24:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E1FAC433EF for ; Wed, 15 Jun 2022 17:17:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241082AbiFORRa (ORCPT ); Wed, 15 Jun 2022 13:17:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346656AbiFORRK (ORCPT ); Wed, 15 Jun 2022 13:17:10 -0400 Received: from challenge-bot.com (challenge-bot.com [IPv6:2602:fffa:fff:108a:0:16:3e15:92b8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03F133CFD7 for ; Wed, 15 Jun 2022 10:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=challenge-bot.com; s=20180430; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=N9mphYMfxQdT/0wa00SOKNuuuPdp5vfec0Gt4uUXQqg=; b=bagIpW3kUL+GyBAUo/d8o9fdSv gvBq62hEWOCKCalxy4rp9pKGiPjWqpWoRWzJCNrLzMQWZ5ubRlrOvIfOwLiWUIJxlv/2dFd+PRVQe Tqr7pEXXX8RKW4yPT/IcjiOc8wGkpiOliqQJdhKAyz2DcJ/13VIB7YP5e3hcLmUEfQf0=; Received: from ozzloy by challenge-bot.com with local (Exim 4.92) (envelope-from ) id 1o1Wde-0005iz-Hp; Wed, 15 Jun 2022 10:17:06 -0700 From: daniel watson To: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Daniel Watson Subject: [PATCH v3 4/4] staging: r8188eu: call rtw_IOL_append_WRF_cmd directly Date: Wed, 15 Jun 2022 10:17:03 -0700 Message-Id: <4f26e0dd99e32738d7019ebcf680e7c73ed8ac8a.1655312169.git.ozzloy@challenge-bot.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Daniel Watson Call rtw_IOL_append_WRF_cmd directly, instead of using wrapper macro. Delete wrapper macro, which is not needed. Signed-off-by: Daniel Watson --- Changes in v2: - Make the commit message clearer Changes in v3: - None Note: This code has not been run on hardware. drivers/staging/r8188eu/core/rtw_iol.c | 2 +- drivers/staging/r8188eu/include/rtw_iol.h | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_iol.c b/drivers/staging/r8188= eu/core/rtw_iol.c index b7ee3833c908c..31e196ccd899a 100644 --- a/drivers/staging/r8188eu/core/rtw_iol.c +++ b/drivers/staging/r8188eu/core/rtw_iol.c @@ -109,7 +109,7 @@ int rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame= , u16 addr, u32 value, u3 return rtw_IOL_append_cmds(xmit_frame, (u8 *)&cmd, cmd.length); } =20 -int _rtw_IOL_append_WRF_cmd(struct xmit_frame *xmit_frame, u8 rf_path, u16= addr, u32 value, u32 mask) +int rtw_IOL_append_WRF_cmd(struct xmit_frame *xmit_frame, u8 rf_path, u16 = addr, u32 value, u32 mask) { struct ioreg_cfg cmd =3D {8, IOREG_CMD_W_RF, 0x0, 0x0, 0x0}; =20 diff --git a/drivers/staging/r8188eu/include/rtw_iol.h b/drivers/staging/r8= 188eu/include/rtw_iol.h index 9ad467759ef1c..099f5a075274c 100644 --- a/drivers/staging/r8188eu/include/rtw_iol.h +++ b/drivers/staging/r8188eu/include/rtw_iol.h @@ -47,10 +47,8 @@ int rtw_IOL_append_WW_cmd(struct xmit_frame *xmit_frame,= u16 addr, u16 value, u16 mask); int rtw_IOL_append_WD_cmd(struct xmit_frame *xmit_frame, u16 addr, u32 value, u32 mask); -int _rtw_IOL_append_WRF_cmd(struct xmit_frame *xmit_frame, u8 rf_path, - u16 addr, u32 value, u32 mask); -#define rtw_IOL_append_WRF_cmd(xmit_frame, rf_path, addr, value, mask) \ - _rtw_IOL_append_WRF_cmd((xmit_frame),(rf_path), (addr), (value), (mask)) +int rtw_IOL_append_WRF_cmd(struct xmit_frame *xmit_frame, u8 rf_path, + u16 addr, u32 value, u32 mask); =20 u8 rtw_IOL_cmd_boundary_handle(struct xmit_frame *pxmit_frame); =20 --=20 2.34.1