From nobody Mon Apr 27 10:04:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F93C433EF for ; Tue, 14 Jun 2022 15:59:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344523AbiFNP7b (ORCPT ); Tue, 14 Jun 2022 11:59:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243779AbiFNP7R (ORCPT ); Tue, 14 Jun 2022 11:59:17 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 534FC27B33 for ; Tue, 14 Jun 2022 08:59:16 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id x62so12279791ede.10 for ; Tue, 14 Jun 2022 08:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GpSEw9c3r7sQWr+egbMOGl5Yu6roLaX7F/5rz4bUGTw=; b=ev+JeJYBY/IfjhesmJo4M5OfE/Tk8HXWwSSXslzrDH3gDLtzs9Wx/r8VU4c3UfEGTT oDbe0qvBT8zlehwyDLdzN7e18bs2pIA+L1R9iFDhmZAZYJfw69zDu1abw6YDhFt+BFIU Qi/sUrpCVV9amBgB1PXCdGa8mrfX2OXgMYE+spzfLHXu54cyibgMyg93sEslnEjF14bB EB5dN8/VFd1GnGnQ6Yj+kQJzk7+44J74ZTXTg7Qq729V/ObSHu5zgmFe8VzjqAeYXAkc VPzCk42L6QOHFxhp9hK/KMtiHsFDYBMwE6ZQtwqPaO5jcbz5HJS38Y+EoDxJYHkS4YhO 7pEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GpSEw9c3r7sQWr+egbMOGl5Yu6roLaX7F/5rz4bUGTw=; b=iRpuVT2gat8KgDScrGE8FD3ofaXGulY209Djjc7ivwM1OqbXD4e0aRO+xZaXD6zjbl gXNN4y0RwhwF3sRTvlJF69Ml4V9awqjPyakD/P+6R+bUXnaJR4NUDzO/RVMMIioAMgk6 WMAK+5/8W/moHmYQy+Dy+LMGgpuvMDERxmqj/SvYUx0HGnvjSjRLSgTeSqLOl9c+TCU4 697RYgFpZ7ulv6DxyenWjfO2tsIUhvzXMV4m2qfo+hBsjqCUMIcNEyHxWkKC5aYjAZtz zk18LHISkIIHeIeQoAytcGXKuo8noCYnjqqOm9lxwac1RgMmev1779MTEfPdpo8H7kH+ yJyg== X-Gm-Message-State: AJIora83o5O0LoE0UNLBH8be4s212yxMSNCpEomC/RL7INcBq1eZNVn1 MLfxM/ri5x1tTzrP4ZbSyu0= X-Google-Smtp-Source: ABdhPJwNoT0Ob31bmrxxQpJr7W+KbgZ1IHbwDtGK9fNKcqLLS7rk4rkGYk7XNfskl2zOx6xkHpFkPA== X-Received: by 2002:a05:6402:350f:b0:42f:68f9:ae5 with SMTP id b15-20020a056402350f00b0042f68f90ae5mr7134117edd.36.1655222354856; Tue, 14 Jun 2022 08:59:14 -0700 (PDT) Received: from nam-dell.fritz.box ([2a02:8109:afbf:ed88:c58b:f186:2720:bdac]) by smtp.gmail.com with ESMTPSA id qk10-20020a170906d9ca00b006fed93bf71fsm5327928ejb.18.2022.06.14.08.59.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 08:59:14 -0700 (PDT) From: Nam Cao To: gregkh@linuxfoundation.org Cc: dan.carpenter@oracle.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, namcaov@gmail.com, phil@philpotter.co.uk, Larry.Finger@lwfinger.net, paskripkin@gmail.com Subject: [PATCH v3 1/2] staging: r8188eu: replace confusing macros Date: Tue, 14 Jun 2022 17:58:44 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The macro GET_TX_REPORT_TYPE1_RERTY_0 and similar macros are not obvious on what they are doing. Replace them with clearer codes. Signed-off-by: Nam Cao Reviewed-by: Dan Carpenter --- drivers/staging/r8188eu/hal/Hal8188ERateAdaptive.c | 12 ++++++------ .../staging/r8188eu/include/Hal8188ERateAdaptive.h | 13 ------------- 2 files changed, 6 insertions(+), 19 deletions(-) diff --git a/drivers/staging/r8188eu/hal/Hal8188ERateAdaptive.c b/drivers/s= taging/r8188eu/hal/Hal8188ERateAdaptive.c index 3cefdf90d6e0..1e04de3a6622 100644 --- a/drivers/staging/r8188eu/hal/Hal8188ERateAdaptive.c +++ b/drivers/staging/r8188eu/hal/Hal8188ERateAdaptive.c @@ -614,12 +614,12 @@ void ODM_RA_TxRPT2Handle_8188E(struct odm_dm_struct *= dm_odm, u8 *TxRPT_Buf, u16 =20 pRAInfo =3D &dm_odm->RAInfo[MacId]; if (valid) { - pRAInfo->RTY[0] =3D (u16)GET_TX_REPORT_TYPE1_RERTY_0(pBuffer); - pRAInfo->RTY[1] =3D (u16)GET_TX_REPORT_TYPE1_RERTY_1(pBuffer); - pRAInfo->RTY[2] =3D (u16)GET_TX_REPORT_TYPE1_RERTY_2((u8 *)pBuffer); - pRAInfo->RTY[3] =3D (u16)GET_TX_REPORT_TYPE1_RERTY_3(pBuffer); - pRAInfo->RTY[4] =3D (u16)GET_TX_REPORT_TYPE1_RERTY_4(pBuffer); - pRAInfo->DROP =3D (u16)GET_TX_REPORT_TYPE1_DROP_0(pBuffer); + pRAInfo->RTY[0] =3D le16_to_cpup((__le16 *)pBuffer); + pRAInfo->RTY[1] =3D pBuffer[2]; + pRAInfo->RTY[2] =3D pBuffer[3]; + pRAInfo->RTY[3] =3D pBuffer[4]; + pRAInfo->RTY[4] =3D pBuffer[5]; + pRAInfo->DROP =3D pBuffer[6]; pRAInfo->TOTAL =3D pRAInfo->RTY[0] + pRAInfo->RTY[1] + pRAInfo->RTY[2] + pRAInfo->RTY[3] + pRAInfo->RTY[4] + pRAInfo->DROP; diff --git a/drivers/staging/r8188eu/include/Hal8188ERateAdaptive.h b/drive= rs/staging/r8188eu/include/Hal8188ERateAdaptive.h index 20d73ca781e8..c571ad9478ea 100644 --- a/drivers/staging/r8188eu/include/Hal8188ERateAdaptive.h +++ b/drivers/staging/r8188eu/include/Hal8188ERateAdaptive.h @@ -22,19 +22,6 @@ le32_to_cpu((*(__le32 *)(__rxstatusdesc + 16)) #define GET_TX_RPT2_DESC_MACID_VALID_2_88E(__rxstatusdesc) \ le32_to_cpu((*(__le32 *)(__rxstatusdesc + 20)) - -#define GET_TX_REPORT_TYPE1_RERTY_0(__paddr) \ - le16_get_bits(*(__le16 *)__paddr, GENMASK(15, 0)) -#define GET_TX_REPORT_TYPE1_RERTY_1(__paddr) \ - LE_BITS_TO_1BYTE(__paddr + 2, 0, 8) -#define GET_TX_REPORT_TYPE1_RERTY_2(__paddr) \ - LE_BITS_TO_1BYTE(__paddr + 3, 0, 8) -#define GET_TX_REPORT_TYPE1_RERTY_3(__paddr) \ - LE_BITS_TO_1BYTE(__paddr + 4, 0, 8) -#define GET_TX_REPORT_TYPE1_RERTY_4(__paddr) \ - LE_BITS_TO_1BYTE(__paddr + 5, 0, 8) -#define GET_TX_REPORT_TYPE1_DROP_0(__paddr) \ - LE_BITS_TO_1BYTE(__paddr + 6, 0, 8) /* End rate adaptive define */ =20 int ODM_RAInfo_Init_all(struct odm_dm_struct *dm_odm); --=20 2.25.1 From nobody Mon Apr 27 10:04:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B082CC433EF for ; Tue, 14 Jun 2022 15:59:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343989AbiFNP71 (ORCPT ); Tue, 14 Jun 2022 11:59:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242623AbiFNP7S (ORCPT ); Tue, 14 Jun 2022 11:59:18 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBFC01CFE2 for ; Tue, 14 Jun 2022 08:59:16 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id n28so12283005edb.9 for ; Tue, 14 Jun 2022 08:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M3gbMv3CLEVw18Z0+GMlsuJYkcEWg9M+cqo68PHCY1Q=; b=M7DlVTelkdRHSDTdXFbXqRTjSfrVHM80gWUzdQlAvt08aiyANcUKt2xnHvWIr+Or/V n6qHxtuSWdt9ut4qX/tDFnF/GY9fm5ttHMpFHymlI1JkPNoBMLChV+buibbtUWVjo/wN 9K/0rmRExU2x20F4AejBPwpUCBY71lJMEM5PBJrtmkWEcL4AYmHI8VyvGMdOKQGmkfxk a38PKwQLbZn0fuAc9m0xSDLWCrwJzmPBXckQdQ9P7p7ZCxp2zlfpKzBNnFSGiq4xwyyB VXePc4WMNsCiClY3QJBFuez50bAj8T4Icp99/L3CacjhQKL3+IBROWHtnto+8DAFqbOx 0AoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M3gbMv3CLEVw18Z0+GMlsuJYkcEWg9M+cqo68PHCY1Q=; b=xVIZkji/MLwT/fYaHvHmV7ffGxAeJAdetrfyskytlPid0dGmHbOKnmsOBY//r9l1El jWbZ6tthb4wVquVjsurqyBKHjNwrQAKzE4CYoiNtH0NsoLTZG6lmBLi3QSU7iG/Oht0e 4NT2xDYuvvt7VqpV9m6SC+vgvHXkejjm98P0lLZtfxj0dhPhqWGuqiqmMfzjCN5WmEK9 Zjv0pUeJ4SvIk+5YujMHOcUYdiY2X/4iLu5teznq7/ID9YVfR4GU3XSf6mjGtN5VRzK3 Qfas9DalCjf3sK1Um202l93qMCrTCN65EVbFHMFqqne7AfNT4BtHhq22PchS7jIjWq25 yjxQ== X-Gm-Message-State: AJIora/HSP02dkoCNEzgdCT3oRVVOPT+RmHCXDjUM5b12yi7As7diByA 6ywit+GtjUnCxkObptTlRXg= X-Google-Smtp-Source: AGRyM1vAU0DxLPxLYMT9nMistjkeFzzHUlxwynL+MUrAjKN8Oez6KHUFzkRMcICzL3aFAJoVfPiGlA== X-Received: by 2002:a05:6402:388b:b0:42b:5f20:c616 with SMTP id fd11-20020a056402388b00b0042b5f20c616mr6903288edb.50.1655222355575; Tue, 14 Jun 2022 08:59:15 -0700 (PDT) Received: from nam-dell.fritz.box ([2a02:8109:afbf:ed88:c58b:f186:2720:bdac]) by smtp.gmail.com with ESMTPSA id qk10-20020a170906d9ca00b006fed93bf71fsm5327928ejb.18.2022.06.14.08.59.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 08:59:15 -0700 (PDT) From: Nam Cao To: gregkh@linuxfoundation.org Cc: dan.carpenter@oracle.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, namcaov@gmail.com, phil@philpotter.co.uk, Larry.Finger@lwfinger.net, paskripkin@gmail.com Subject: [PATCH v3 2/2] staging: r8188eu: remove unused macros Date: Tue, 14 Jun 2022 17:58:45 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove LE_BITS_TO_1BYTE and relevant macros because they are not used anywhere. Signed-off-by: Nam Cao Reviewed-by: Dan Carpenter --- drivers/staging/r8188eu/include/basic_types.h | 31 ------------------- 1 file changed, 31 deletions(-) diff --git a/drivers/staging/r8188eu/include/basic_types.h b/drivers/stagin= g/r8188eu/include/basic_types.h index cfd15ac1d9c0..0b71e2c6e41a 100644 --- a/drivers/staging/r8188eu/include/basic_types.h +++ b/drivers/staging/r8188eu/include/basic_types.h @@ -13,37 +13,6 @@ typedef void (*proc_t)(void *); /* TODO: Macros Below are Sync from SD7-Driver. It is necessary * to check correctness */ =20 -/* - * Call endian free function when - * 1. Read/write packet content. - * 2. Before write integer to IO. - * 3. After read integer from IO. -*/ - -/* Convert little data endian to host ordering */ -#define EF1BYTE(_val) \ - ((u8)(_val)) - -/* Create a bit mask */ -#define BIT_LEN_MASK_8(__bitlen) \ - (0xFF >> (8 - (__bitlen))) - -/*Description: - * Return 4-byte value in host byte ordering from - * 4-byte pointer in little-endian system. - */ -#define LE_P1BYTE_TO_HOST_1BYTE(__pstart) \ - (EF1BYTE(*((u8 *)(__pstart)))) - -/*Description: -Translate subfield (continuous bits in little-endian) of 4-byte -value to host byte ordering.*/ -#define LE_BITS_TO_1BYTE(__pstart, __bitoffset, __bitlen) \ - ( \ - (LE_P1BYTE_TO_HOST_1BYTE(__pstart) >> (__bitoffset)) & \ - BIT_LEN_MASK_8(__bitlen) \ - ) - #define N_BYTE_ALIGMENT(__value, __aligment) ((__aligment =3D=3D 1) ? \ (__value) : (((__value + __aligment - 1) / __aligment) * __aligment)) =20 --=20 2.25.1