From nobody Fri May 8 03:08:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24CF8C433EF for ; Thu, 12 May 2022 09:56:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352372AbiELJ4j (ORCPT ); Thu, 12 May 2022 05:56:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352341AbiELJ4S (ORCPT ); Thu, 12 May 2022 05:56:18 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1027D39681; Thu, 12 May 2022 02:56:16 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id l38-20020a05600c1d2600b00395b809dfbaso2391924wms.2; Thu, 12 May 2022 02:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qI3oXWeBiZQ3s0yJXR/Iw74/6l7ydEbTwN0ORi2PrK0=; b=KzEWi7vjnxdxQBJlJDO0DiuyF9DtJfntrDKUKeI93BZiV6D+RQWoCdzKw+i4jLb9bm xgwleuEEPQDLntBcJXA5PkBTXaHNvdz04neDI6FGLhdXBFolFF5XBccTM6wfRBLuuKLx W3+NIJueyMz0GwUPAIhs3KAgx7S7YyDZeN2s8/zN0Cj1eArabJzkNhPTvdSf/o7hfFki byBdeWwmXpwEr5yPIT+K2Evj4IHDvvueM9bCMNd/zQpcPbJMuJ62FCRvWoVv0Pq+kQ5J 7PAQAsaHZpZmh5LCSX9hokxYhh+prd50kEOtg+KmDK9EcDAai2iCtxs9CdmLF27mWzNT ZGXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qI3oXWeBiZQ3s0yJXR/Iw74/6l7ydEbTwN0ORi2PrK0=; b=Bv7leIMs8ig0npdy6E4juJuThacMpmOx2LulmP2lR7GtMduYpEm1Ha5GmHjL+TvPIj C9XMEp0LK9kr7tkhyhRrtaTxR6LshkuwWJXjtJTqrTiI1saCjMYf0DRJICAEdqRdLmJh POaUtoZMZ8kiq+sxPb4FylvBTLHytdSXKMspb3lKTaHfCXWuU0dowdtt61CaFtyiUikQ y6VFwtYejsT3Yfd0FUEa1vBOiq2vQd9ZQpTHg4rKJmB2RD3UBE56XJe+zGg3443+irAv WtQkPER71MxKogcgwFP/JTJHgROZ2wVrsVHAtq7l/KhF3VGv5SYQvQPBE5kaxxEKaNQX LHqg== X-Gm-Message-State: AOAM533/CjBo/NeE60TYS61C4jQEywVPqZmItC3ie7SB5pl119AD4Eq4 aPwu2ap4ZTxxta3pDFhSAfE= X-Google-Smtp-Source: ABdhPJy/QeQxp3dWsBwoanSCYPJ6iJInm5XAFqgaNwlAqEbT29lisDl26cEBlRq+b1dNjftuGwKQnA== X-Received: by 2002:a05:600c:3b04:b0:394:6150:db8f with SMTP id m4-20020a05600c3b0400b003946150db8fmr9149320wms.183.1652349374575; Thu, 12 May 2022 02:56:14 -0700 (PDT) Received: from alaa-emad ([197.57.250.210]) by smtp.gmail.com with ESMTPSA id d1-20020a05600c34c100b003942a244f3bsm2296610wmq.20.2022.05.12.02.56.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 02:56:14 -0700 (PDT) From: Alaa Mohamed To: netdev@vger.kernel.org Cc: outreachy@lists.linux.dev, roopa@nvidia.com, jdenham@redhat.com, sbrivio@redhat.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, vladimir.oltean@nxp.com, claudiu.manoil@nxp.com, alexandre.belloni@bootlin.com, shshaikh@marvell.com, manishc@marvell.com, razor@blackwall.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, GR-Linux-NIC-Dev@marvell.com, bridge@lists.linux-foundation.org, eng.alaamohamedsoliman.am@gmail.com Subject: [PATCH net-next v7 1/2] rtnetlink: add extack support in fdb del handlers Date: Thu, 12 May 2022 11:55:53 +0200 Message-Id: <9b124f0393a8ea2db2333235bbd7129ac08b8c34.1652348962.git.eng.alaamohamedsoliman.am@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add extack support to .ndo_fdb_del in netdevice.h and all related methods. Signed-off-by: Alaa Mohamed --- changes in V3: fix errors reported by checkpatch.pl --- changes in V4: fix errors reported by checkpatch.pl --- changes in V5: resubmit after rebase. --- changes in V6: update the kdoc on ice_fdb_del --- changes in V7: fix alignments in ocelot_port_fdb_del and vxlan_fdb_delete. --- drivers/net/ethernet/intel/ice/ice_main.c | 3 ++- drivers/net/ethernet/mscc/ocelot_net.c | 3 ++- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 3 ++- drivers/net/macvlan.c | 3 ++- drivers/net/vxlan/vxlan_core.c | 3 ++- include/linux/netdevice.h | 2 +- net/bridge/br_fdb.c | 3 ++- net/bridge/br_private.h | 3 ++- net/core/rtnetlink.c | 4 ++-- 9 files changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethern= et/intel/ice/ice_main.c index fde839ef0613..95f6c9610372 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -5674,11 +5674,12 @@ ice_fdb_add(struct ndmsg *ndm, struct nlattr __alwa= ys_unused *tb[], * @dev: the net device pointer * @addr: the MAC address entry being added * @vid: VLAN ID + * @extack: netlink extended ack */ static int ice_fdb_del(struct ndmsg *ndm, __always_unused struct nlattr *tb[], struct net_device *dev, const unsigned char *addr, - __always_unused u16 vid) + __always_unused u16 vid, struct netlink_ext_ack *extack) { int err; diff --git a/drivers/net/ethernet/mscc/ocelot_net.c b/drivers/net/ethernet/= mscc/ocelot_net.c index 247bc105bdd2..32d0a9e0a4b0 100644 --- a/drivers/net/ethernet/mscc/ocelot_net.c +++ b/drivers/net/ethernet/mscc/ocelot_net.c @@ -774,7 +774,8 @@ static int ocelot_port_fdb_add(struct ndmsg *ndm, struc= t nlattr *tb[], static int ocelot_port_fdb_del(struct ndmsg *ndm, struct nlattr *tb[], struct net_device *dev, - const unsigned char *addr, u16 vid) + const unsigned char *addr, u16 vid, + struct netlink_ext_ack *extack) { struct ocelot_port_private *priv =3D netdev_priv(dev); struct ocelot_port *ocelot_port =3D &priv->port; diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net= /ethernet/qlogic/qlcnic/qlcnic_main.c index d320567b2cca..28476b982bab 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c @@ -368,7 +368,8 @@ static int qlcnic_set_mac(struct net_device *netdev, vo= id *p) static int qlcnic_fdb_del(struct ndmsg *ndm, struct nlattr *tb[], struct net_device *netdev, - const unsigned char *addr, u16 vid) + const unsigned char *addr, u16 vid, + struct netlink_ext_ack *extack) { struct qlcnic_adapter *adapter =3D netdev_priv(netdev); int err =3D -EOPNOTSUPP; diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index b00bc8173abe..cb27631c3a4d 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -1021,7 +1021,8 @@ static int macvlan_fdb_add(struct ndmsg *ndm, struct = nlattr *tb[], static int macvlan_fdb_del(struct ndmsg *ndm, struct nlattr *tb[], struct net_device *dev, - const unsigned char *addr, u16 vid) + const unsigned char *addr, u16 vid, + struct netlink_ext_ack *extack) { struct macvlan_dev *vlan =3D netdev_priv(dev); int err =3D -EINVAL; diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c index 8a5e3a6d32d7..c58c48de4cf4 100644 --- a/drivers/net/vxlan/vxlan_core.c +++ b/drivers/net/vxlan/vxlan_core.c @@ -1280,7 +1280,8 @@ int __vxlan_fdb_delete(struct vxlan_dev *vxlan, /* Delete entry (via netlink) */ static int vxlan_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[], struct net_device *dev, - const unsigned char *addr, u16 vid) + const unsigned char *addr, u16 vid, + struct netlink_ext_ack *extack) { struct vxlan_dev *vxlan =3D netdev_priv(dev); union vxlan_addr ip; diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 7dccbfd1bf56..23731804a4b0 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -1513,7 +1513,7 @@ struct net_device_ops { struct nlattr *tb[], struct net_device *dev, const unsigned char *addr, - u16 vid); + u16 vid, struct netlink_ext_ack *extack); int (*ndo_fdb_del_bulk)(struct ndmsg *ndm, struct nlattr *tb[], struct net_device *dev, diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index 1a3d583fbc8e..e7f4fccb6adb 100644 --- a/net/bridge/br_fdb.c +++ b/net/bridge/br_fdb.c @@ -1253,7 +1253,8 @@ static int __br_fdb_delete(struct net_bridge *br, /* Remove neighbor entry with RTM_DELNEIGH */ int br_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[], struct net_device *dev, - const unsigned char *addr, u16 vid) + const unsigned char *addr, u16 vid, + struct netlink_ext_ack *extack) { struct net_bridge_vlan_group *vg; struct net_bridge_port *p =3D NULL; diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h index 6ae882cfae1c..06e5f6faa431 100644 --- a/net/bridge/br_private.h +++ b/net/bridge/br_private.h @@ -793,7 +793,8 @@ void br_fdb_update(struct net_bridge *br, struct net_br= idge_port *source, const unsigned char *addr, u16 vid, unsigned long flags); int br_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[], - struct net_device *dev, const unsigned char *addr, u16 vid); + struct net_device *dev, const unsigned char *addr, u16 vid, + struct netlink_ext_ack *extack); int br_fdb_delete_bulk(struct ndmsg *ndm, struct nlattr *tb[], struct net_device *dev, u16 vid, struct netlink_ext_ack *extack); diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 73f2cbc440c9..3130df52b56a 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -4240,7 +4240,7 @@ static int rtnl_fdb_del(struct sk_buff *skb, struct n= lmsghdr *nlh, ops =3D br_dev->netdev_ops; if (!del_bulk) { if (ops->ndo_fdb_del) - err =3D ops->ndo_fdb_del(ndm, tb, dev, addr, vid); + err =3D ops->ndo_fdb_del(ndm, tb, dev, addr, vid, extack); } else { if (ops->ndo_fdb_del_bulk) err =3D ops->ndo_fdb_del_bulk(ndm, tb, dev, vid, @@ -4258,7 +4258,7 @@ static int rtnl_fdb_del(struct sk_buff *skb, struct n= lmsghdr *nlh, ops =3D dev->netdev_ops; if (!del_bulk) { if (ops->ndo_fdb_del) - err =3D ops->ndo_fdb_del(ndm, tb, dev, addr, vid); + err =3D ops->ndo_fdb_del(ndm, tb, dev, addr, vid, extack); else err =3D ndo_dflt_fdb_del(ndm, tb, dev, addr, vid); } else { -- 2.36.1 From nobody Fri May 8 03:08:11 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62F1CC433F5 for ; Thu, 12 May 2022 09:56:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352374AbiELJ4p (ORCPT ); Thu, 12 May 2022 05:56:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352343AbiELJ4S (ORCPT ); Thu, 12 May 2022 05:56:18 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CDB93BF97; Thu, 12 May 2022 02:56:17 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id v12so6447711wrv.10; Thu, 12 May 2022 02:56:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YBtPuBqDP3daPNAlvcT1zBqVo4fpSgXbgBta3hDhOBQ=; b=F4WhnDem6d1RsMdSD8hOf2PQoTgOwN1i/3uuW0U4ksqByqNBW1wZ5PvFKVofytUkqz s3hY60LWSjJnltuYW/ODjAqPyXq7QhpJxhsbF3Fh10t9Unh1gqHB9KBbLeUcPfn3xkqB KkQU5eZrMNWPmNx0nYhi0275CFXzuP7qm/uxB8nDjNda54MsweGsgFJFJRwwxl98+FJJ wFJQbOXiSsfub6REPzOGE/UaP2TDAPGMEkvz2OvuOlQpW12b5XnjnPfabHAyk71mvxbb XR1nIszZKQXKaAlhCRlPxbX1MFblhs307Pn7qepv2DwMAl37dWYfkIOOtJyvBw2Cr0Jd LUdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YBtPuBqDP3daPNAlvcT1zBqVo4fpSgXbgBta3hDhOBQ=; b=scOPijHD5zbopQC+FG+1RHIqWd38IRC9/rVnNMkQMNuWtgphE4eugsUkPuXz3TJwUJ X+z/0UIxKGrLymF/a0T8NGkRpRpMua4XqWtFUHuH0aoajNKrXfWFPtPpQ8QAtYMvtfu5 Gl9fqsYvsVE0F2S3sqqGS/TfeirWuXC5/1dDjQXNmN1Kgqd1qvhMpSYZoVe7ekC21H1N PhDIIiVwACDtR9pZd8v9dy6C1f5A1b2NCDkff1iTbCRNwcQbBVC1jbBvdQP767Eiql/E QpriA+TW7lfG01+HH7wvXW930Xwp9MSif80AgNeR5DaG64cvs0OpRg96QmdpQW1UubIE UhEQ== X-Gm-Message-State: AOAM530/CZfVu5fKizRtEAg+oInZCwBVR6NPA97ToiU9DiHTKB2b1fW9 gVLWgkBVxi4qCXU4XjWqcx4= X-Google-Smtp-Source: ABdhPJxhKb5EstwZosgNL/R8XDmbinm081QfDMNdN0k7i1WWihDYWeu1Zt3D3fwvImYSpDzVZuoUdQ== X-Received: by 2002:a5d:4b0d:0:b0:20a:f3d9:336e with SMTP id v13-20020a5d4b0d000000b0020af3d9336emr28096436wrq.467.1652349375926; Thu, 12 May 2022 02:56:15 -0700 (PDT) Received: from alaa-emad ([197.57.250.210]) by smtp.gmail.com with ESMTPSA id i10-20020a5d630a000000b0020c5253d8d4sm3751915wru.32.2022.05.12.02.56.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 02:56:15 -0700 (PDT) From: Alaa Mohamed To: netdev@vger.kernel.org Cc: outreachy@lists.linux.dev, roopa@nvidia.com, jdenham@redhat.com, sbrivio@redhat.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, vladimir.oltean@nxp.com, claudiu.manoil@nxp.com, alexandre.belloni@bootlin.com, shshaikh@marvell.com, manishc@marvell.com, razor@blackwall.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, GR-Linux-NIC-Dev@marvell.com, bridge@lists.linux-foundation.org, eng.alaamohamedsoliman.am@gmail.com Subject: [PATCH net-next v7 2/2] net: vxlan: Add extack support to vxlan_fdb_delete Date: Thu, 12 May 2022 11:55:54 +0200 Message-Id: X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch adds extack msg support to vxlan_fdb_delete and vxlan_fdb_parse. extack is used to propagate meaningful error msgs to the user of vxlan fdb netlink api Signed-off-by: Alaa Mohamed --- changes in V2: - fix spelling vxlan_fdb_delete - add missing braces - edit error message --- changes in V3: fix errors reported by checkpatch.pl --- changes in V4: - fix errors reported by checkpatch.pl - edit commit message. --- changes in V5: - edit commit message --- changes in V7: fix checkpatch issue: CHECK:Alignment should match open parenthesis --- drivers/net/vxlan/vxlan_core.c | 38 ++++++++++++++++++++++++---------- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c index c58c48de4cf4..cb955bd79cb1 100644 --- a/drivers/net/vxlan/vxlan_core.c +++ b/drivers/net/vxlan/vxlan_core.c @@ -1129,19 +1129,25 @@ static void vxlan_fdb_dst_destroy(struct vxlan_dev = *vxlan, struct vxlan_fdb *f, static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan, union vxlan_addr *ip, __be16 *port, __be32 *src_vni, - __be32 *vni, u32 *ifindex, u32 *nhid) + __be32 *vni, u32 *ifindex, u32 *nhid, + struct netlink_ext_ack *extack) { struct net *net =3D dev_net(vxlan->dev); int err; if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] || - tb[NDA_PORT])) - return -EINVAL; + tb[NDA_PORT])) { + NL_SET_ERR_MSG(extack, + "DST, VNI, ifindex and port are mutually exclusive with NH_ID"); + return -EINVAL; + } if (tb[NDA_DST]) { err =3D vxlan_nla_get_addr(ip, tb[NDA_DST]); - if (err) + if (err) { + NL_SET_ERR_MSG(extack, "Unsupported address family"); return err; + } } else { union vxlan_addr *remote =3D &vxlan->default_dst.remote_ip; @@ -1157,24 +1163,30 @@ static int vxlan_fdb_parse(struct nlattr *tb[], str= uct vxlan_dev *vxlan, } if (tb[NDA_PORT]) { - if (nla_len(tb[NDA_PORT]) !=3D sizeof(__be16)) + if (nla_len(tb[NDA_PORT]) !=3D sizeof(__be16)) { + NL_SET_ERR_MSG(extack, "Invalid vxlan port"); return -EINVAL; + } *port =3D nla_get_be16(tb[NDA_PORT]); } else { *port =3D vxlan->cfg.dst_port; } if (tb[NDA_VNI]) { - if (nla_len(tb[NDA_VNI]) !=3D sizeof(u32)) + if (nla_len(tb[NDA_VNI]) !=3D sizeof(u32)) { + NL_SET_ERR_MSG(extack, "Invalid vni"); return -EINVAL; + } *vni =3D cpu_to_be32(nla_get_u32(tb[NDA_VNI])); } else { *vni =3D vxlan->default_dst.remote_vni; } if (tb[NDA_SRC_VNI]) { - if (nla_len(tb[NDA_SRC_VNI]) !=3D sizeof(u32)) + if (nla_len(tb[NDA_SRC_VNI]) !=3D sizeof(u32)) { + NL_SET_ERR_MSG(extack, "Invalid src vni"); return -EINVAL; + } *src_vni =3D cpu_to_be32(nla_get_u32(tb[NDA_SRC_VNI])); } else { *src_vni =3D vxlan->default_dst.remote_vni; @@ -1183,12 +1195,16 @@ static int vxlan_fdb_parse(struct nlattr *tb[], str= uct vxlan_dev *vxlan, if (tb[NDA_IFINDEX]) { struct net_device *tdev; - if (nla_len(tb[NDA_IFINDEX]) !=3D sizeof(u32)) + if (nla_len(tb[NDA_IFINDEX]) !=3D sizeof(u32)) { + NL_SET_ERR_MSG(extack, "Invalid ifindex"); return -EINVAL; + } *ifindex =3D nla_get_u32(tb[NDA_IFINDEX]); tdev =3D __dev_get_by_index(net, *ifindex); - if (!tdev) + if (!tdev) { + NL_SET_ERR_MSG(extack, "Device not found"); return -EADDRNOTAVAIL; + } } else { *ifindex =3D 0; } @@ -1226,7 +1242,7 @@ static int vxlan_fdb_add(struct ndmsg *ndm, struct nl= attr *tb[], return -EINVAL; err =3D vxlan_fdb_parse(tb, vxlan, &ip, &port, &src_vni, &vni, &ifindex, - &nhid); + &nhid, extack); if (err) return err; @@ -1292,7 +1308,7 @@ static int vxlan_fdb_delete(struct ndmsg *ndm, struct= nlattr *tb[], int err; err =3D vxlan_fdb_parse(tb, vxlan, &ip, &port, &src_vni, &vni, &ifindex, - &nhid); + &nhid, extack); if (err) return err; -- 2.36.1