From nobody Sun May 10 15:05:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E55DC433F5 for ; Sun, 1 May 2022 20:25:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354425AbiEAU3L (ORCPT ); Sun, 1 May 2022 16:29:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239469AbiEAU3G (ORCPT ); Sun, 1 May 2022 16:29:06 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83FCB3A728 for ; Sun, 1 May 2022 13:25:39 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id n10so7111135ejk.5 for ; Sun, 01 May 2022 13:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=otSZ1vNlbZZnefxXua2kl3gSYjKRO6kJyYuaC3ipspw=; b=JTO0wQlOqJpwRmwKi3r4/4pBPbTm0NQUtwE52bMaok+qwz6S+6KLrWp7lxu5BwzWid CUr6Vc24Lt0lypOrlaI1OsAENaJR9XLUXfi5M1bnuXAziTaLAM/I7bkdlvk2QBiroUlM JpMp4dok4VettjoBOsNIZKXFdw4+XLNvcOby38VO9atZ+lFSfO1kHCwjLHTBZBUK/Y6U k+vw1YBI3rsCP8ViybvKVskU2FB5K8CX92UNKn/3fwa4hfaSL1tqYUBrQe/XGDXNE+Iz zvA9TOBpeNDWaWPD+3kyOJVmsTdkahtFJhZdLNH1bsAaHrqHeVIlhHDui+J+K4aL6Rt6 +XsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=otSZ1vNlbZZnefxXua2kl3gSYjKRO6kJyYuaC3ipspw=; b=ODNXayI4zUSX1peFrgEdsj4p6d47DFK3bxliS6ErurnT9dsg04i+Q5YfpzdLQrUJ95 GtCn3znpGSRPxN7Ll00eYYt6BrVAsOUgFMDvg4SvHvWfCisY7r5ZTDvqOewX+saFUiFx gwGAKVBunMhSs8Ll0F/rPT1fDuqBp1bxjepZxFqrq/OVSTj9xpNxWr4LnlL3kG2asHZ3 s/I+SLhafAbjheWJoCIckRSZ0NrXDjU1qIsIaEjXCX+ygXLHDHskPackJwJXPnIGgl4/ XDZvhMZptTwA+7lgJt6QQvLD8pL0xwbat+2sa6UChs14L/1nfu1E80pnNz5TYEaBpkp7 NrZw== X-Gm-Message-State: AOAM532KCNKZANkt6Jw/bbtjG2YNhWqz1yXokI/UAmQ29vLKexh1hT6y AhiOyKg00Eg8ASylK1aAtRw= X-Google-Smtp-Source: ABdhPJyGIwncKgiS8FLl6mJ6K3tCH+7dtaGJ9w1yvlBORuHE3OQTwl4Zt62pJpGCol2+7Pu3e1DADg== X-Received: by 2002:a17:907:968f:b0:6db:a3c5:ae3e with SMTP id hd15-20020a170907968f00b006dba3c5ae3emr8898304ejc.770.1651436738031; Sun, 01 May 2022 13:25:38 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p54a074e9.dip0.t-ipconnect.de. [84.160.116.233]) by smtp.gmail.com with ESMTPSA id gz25-20020a170907a05900b006f3ef214e63sm2896059ejc.201.2022.05.01.13.25.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 May 2022 13:25:37 -0700 (PDT) Date: Sun, 1 May 2022 22:25:35 +0200 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] staging: vt6655: Rename function CARDbGetCurrentTSF Message-ID: <2b92db8d67e8dd1fc85b45efe3b32d2199371190.1651435890.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The name of the function uses CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann --- V1 -> v2: Changed function name to include driver name --- drivers/staging/vt6655/card.c | 10 +++++----- drivers/staging/vt6655/card.h | 2 +- drivers/staging/vt6655/device_main.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index 431890e6b8d2..c8372701bf43 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -11,7 +11,7 @@ * CARDbAddBasicRate - Add to BasicRateSet * CARDbIsOFDMinBasicRate - Check if any OFDM rate is in BasicRateSet * CARDqGetTSFOffset - Calculate TSFOffset - * CARDbGetCurrentTSF - Read Current NIC TSF counter + * vt6655_get_current_tsf - Read Current NIC TSF counter * CARDqGetNextTBTT - Calculate Next Beacon TSF counter * CARDvSetFirstNextTBTT - Set NIC Beacon time * CARDvUpdateNextTBTT - Sync. NIC Beacon time @@ -288,7 +288,7 @@ bool CARDbUpdateTSF(struct vnt_private *priv, unsigned = char byRxRate, u64 local_tsf; u64 qwTSFOffset =3D 0; =20 - CARDbGetCurrentTSF(priv, &local_tsf); + vt6655_get_current_tsf(priv, &local_tsf); =20 if (qwBSSTimestamp !=3D local_tsf) { qwTSFOffset =3D CARDqGetTSFOffset(byRxRate, qwBSSTimestamp, @@ -322,7 +322,7 @@ bool CARDbSetBeaconPeriod(struct vnt_private *priv, { u64 qwNextTBTT =3D 0; =20 - CARDbGetCurrentTSF(priv, &qwNextTBTT); /* Get Local TSF counter */ + vt6655_get_current_tsf(priv, &qwNextTBTT); /* Get Local TSF counter */ =20 qwNextTBTT =3D CARDqGetNextTBTT(qwNextTBTT, wBeaconInterval); =20 @@ -739,7 +739,7 @@ u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF= 1, u64 qwTSF2) * * Return Value: true if success; otherwise false */ -bool CARDbGetCurrentTSF(struct vnt_private *priv, u64 *pqwCurrTSF) +bool vt6655_get_current_tsf(struct vnt_private *priv, u64 *pqwCurrTSF) { void __iomem *iobase =3D priv->port_offset; unsigned short ww; @@ -807,7 +807,7 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv, void __iomem *iobase =3D priv->port_offset; u64 qwNextTBTT =3D 0; =20 - CARDbGetCurrentTSF(priv, &qwNextTBTT); /* Get Local TSF counter */ + vt6655_get_current_tsf(priv, &qwNextTBTT); /* Get Local TSF counter */ =20 qwNextTBTT =3D CARDqGetNextTBTT(qwNextTBTT, wBeaconInterval); /* Set NextTBTT */ diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h index 09e7f3f1cbed..340516b329e3 100644 --- a/drivers/staging/vt6655/card.h +++ b/drivers/staging/vt6655/card.h @@ -46,7 +46,7 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv, unsigned short wBeaconInterval); void CARDvUpdateNextTBTT(struct vnt_private *priv, u64 qwTSF, unsigned short wBeaconInterval); -bool CARDbGetCurrentTSF(struct vnt_private *priv, u64 *pqwCurrTSF); +bool vt6655_get_current_tsf(struct vnt_private *priv, u64 *pqwCurrTSF); u64 CARDqGetNextTBTT(u64 qwTSF, unsigned short wBeaconInterval); u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF1, u64 qwTSF2); unsigned char CARDbyGetPktType(struct vnt_private *priv); diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/= device_main.c index 12fd825c23fe..bb8a30eefc74 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -1603,7 +1603,7 @@ static u64 vnt_get_tsf(struct ieee80211_hw *hw, struc= t ieee80211_vif *vif) struct vnt_private *priv =3D hw->priv; u64 tsf; =20 - CARDbGetCurrentTSF(priv, &tsf); + vt6655_get_current_tsf(priv, &tsf); =20 return tsf; } --=20 2.25.1 From nobody Sun May 10 15:05:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE7AC433EF for ; Sun, 1 May 2022 20:25:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354725AbiEAU3V (ORCPT ); Sun, 1 May 2022 16:29:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354449AbiEAU3N (ORCPT ); Sun, 1 May 2022 16:29:13 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B4DF3DDEE for ; Sun, 1 May 2022 13:25:45 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id m20so24503230ejj.10 for ; Sun, 01 May 2022 13:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BIvoiMNV2suMEQS65MP5bpJiVeZk0XLREaqe1qAhSxU=; b=gyzFpCRv/U6BNSYqzAmCRmCXWJU6HqVl/ku7gQ61xyhMJsArJx68IDOG31jkezrlos 1R/jwbqbLWMw7I6d75FW1q5rcXnDuQso+Ei3JisvY3j7Wslf/xLHy4wGSFsP9cNMxLTK oPSz030zyXEmhcDe3m4MOM2yqTQPXpcQVPyRwfvPZYz8g9dOg3+1zLHCr3pQITztg5cZ qG77J0GKonbJWBTxi7vJ+MUqLjG114PwsYF5ZumdP83N73xnkPI6/AO7SWUg5I+UPgx3 MyOZx14ori+Si0YY4+j1jNUTOBeeHJ8RByp7TNVeO/27XYHSi5gWyh12npjf+aGgdyHE Zl7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BIvoiMNV2suMEQS65MP5bpJiVeZk0XLREaqe1qAhSxU=; b=BGSHT35ZLSNClWOZ0D75bVj7VITHAm6R7Mm11ba+IRX7O/XOf3la4UrG3mS3so+JJY kuzIfY+RCYm6V6uw2ORjGXQiKvP05tPPY6zvHqtdXYFLx/ARXMRgTUDUxjt3GLKFfNOn F8e1VlHsn6HmIxbM2iUgCJXTyqJ6w2FgzuhSHrdIB9B8iJ7Sv7ILiFZtb9xO16dDmUnl 0RRMP+RRJY9vEWLT385pZcwJmF4AbQ+Ux3VZNLxd03uMT5NCGZxMAPJ51G5ygJO1i1VO 0UMRhY9u2Uh3WEd3K8hvHdLOSn0cMKlVjx2QXcm8mgvOJY9gRsid6S/Xl99OHus6oh1B 2/2A== X-Gm-Message-State: AOAM5306XOuacI3magZbBIrIJpMUuNGZdtgVgHz0lipyjYqoT8zh1xL4 UF3i9qmVNl5yL0XoPs4nGA0= X-Google-Smtp-Source: ABdhPJwQ4YAhxPfsb4bkGuMLmzKYYXZmbLqsnhQuJiuw1zmdbo5kMZZSOTBa/RxC1eR570ihEAwpHA== X-Received: by 2002:a17:906:5d08:b0:6da:b4ea:937 with SMTP id g8-20020a1709065d0800b006dab4ea0937mr8849505ejt.446.1651436743984; Sun, 01 May 2022 13:25:43 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p54a074e9.dip0.t-ipconnect.de. [84.160.116.233]) by smtp.gmail.com with ESMTPSA id gx10-20020a1709068a4a00b006f3ef214e6bsm2829254ejc.209.2022.05.01.13.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 May 2022 13:25:43 -0700 (PDT) Date: Sun, 1 May 2022 22:25:41 +0200 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] staging vt6655: Replace unused return value of vt6655_get_current_tsf Message-ID: <62c83d78627196ec0ce2f5a562cb080a1c87a05a.1651435890.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace unused return value with u64 to increase readability, reduce address and dereference operators and omit pqwCurrTSF that uses CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann --- V1 -> V2: Updated this patch from changes of previous ones Updated below test Code for testing: void CARDvSetFirstNextTBTT(struct vnt_private *priv, unsigned short wBeaconInterval) ... qwNextTBTT =3D vt6655_get_current_tsf(priv); /* Get Local TSF counter */ dev_info(&priv->pcid->dev, "CARDvSetFirstNextTBTT 0x%016llx", qwNextTBTT); bool CARDbSetBeaconPeriod(struct vnt_private *priv, unsigned short wBeaconInterval) ... qwNextTBTT =3D vt6655_get_current_tsf(priv); /* Get Local TSF counter */ dev_info(&priv->pcid->dev, "CARDbSetBeaconPeriod 0x%016llx", qwNextTBTT); Log of the microsecond counter: vt6655 0000:01:05.0: CARDbSetBeaconPeriod 0x00 00 00 04 65 9f 75 d8 vt6655 0000:01:05.0: CARDvSetFirstNextTBTT 0x00 00 00 04 65 9f 75 e4 --- drivers/staging/vt6655/card.c | 18 ++++++++---------- drivers/staging/vt6655/card.h | 2 +- drivers/staging/vt6655/device_main.c | 2 +- 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index c8372701bf43..d3c47b37ad3b 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -288,7 +288,7 @@ bool CARDbUpdateTSF(struct vnt_private *priv, unsigned = char byRxRate, u64 local_tsf; u64 qwTSFOffset =3D 0; =20 - vt6655_get_current_tsf(priv, &local_tsf); + local_tsf =3D vt6655_get_current_tsf(priv); =20 if (qwBSSTimestamp !=3D local_tsf) { qwTSFOffset =3D CARDqGetTSFOffset(byRxRate, qwBSSTimestamp, @@ -320,9 +320,9 @@ bool CARDbUpdateTSF(struct vnt_private *priv, unsigned = char byRxRate, bool CARDbSetBeaconPeriod(struct vnt_private *priv, unsigned short wBeaconInterval) { - u64 qwNextTBTT =3D 0; + u64 qwNextTBTT; =20 - vt6655_get_current_tsf(priv, &qwNextTBTT); /* Get Local TSF counter */ + qwNextTBTT =3D vt6655_get_current_tsf(priv); /* Get Local TSF counter */ =20 qwNextTBTT =3D CARDqGetNextTBTT(qwNextTBTT, wBeaconInterval); =20 @@ -739,7 +739,7 @@ u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF= 1, u64 qwTSF2) * * Return Value: true if success; otherwise false */ -bool vt6655_get_current_tsf(struct vnt_private *priv, u64 *pqwCurrTSF) +u64 vt6655_get_current_tsf(struct vnt_private *priv) { void __iomem *iobase =3D priv->port_offset; unsigned short ww; @@ -753,12 +753,10 @@ bool vt6655_get_current_tsf(struct vnt_private *priv,= u64 *pqwCurrTSF) break; } if (ww =3D=3D W_MAX_TIMEOUT) - return false; + return 0; low =3D ioread32(iobase + MAC_REG_TSFCNTR); high =3D ioread32(iobase + MAC_REG_TSFCNTR + 4); - *pqwCurrTSF =3D le64_to_cpu(low + ((u64)high << 32)); - - return true; + return le64_to_cpu(low + ((u64)high << 32)); } =20 /* @@ -805,9 +803,9 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv, unsigned short wBeaconInterval) { void __iomem *iobase =3D priv->port_offset; - u64 qwNextTBTT =3D 0; + u64 qwNextTBTT; =20 - vt6655_get_current_tsf(priv, &qwNextTBTT); /* Get Local TSF counter */ + qwNextTBTT =3D vt6655_get_current_tsf(priv); /* Get Local TSF counter */ =20 qwNextTBTT =3D CARDqGetNextTBTT(qwNextTBTT, wBeaconInterval); /* Set NextTBTT */ diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h index 340516b329e3..22dc359a6565 100644 --- a/drivers/staging/vt6655/card.h +++ b/drivers/staging/vt6655/card.h @@ -46,7 +46,7 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv, unsigned short wBeaconInterval); void CARDvUpdateNextTBTT(struct vnt_private *priv, u64 qwTSF, unsigned short wBeaconInterval); -bool vt6655_get_current_tsf(struct vnt_private *priv, u64 *pqwCurrTSF); +u64 vt6655_get_current_tsf(struct vnt_private *priv); u64 CARDqGetNextTBTT(u64 qwTSF, unsigned short wBeaconInterval); u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF1, u64 qwTSF2); unsigned char CARDbyGetPktType(struct vnt_private *priv); diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/= device_main.c index bb8a30eefc74..4f26f5c7e84f 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -1603,7 +1603,7 @@ static u64 vnt_get_tsf(struct ieee80211_hw *hw, struc= t ieee80211_vif *vif) struct vnt_private *priv =3D hw->priv; u64 tsf; =20 - vt6655_get_current_tsf(priv, &tsf); + tsf =3D vt6655_get_current_tsf(priv); =20 return tsf; } --=20 2.25.1