From nobody Sun May 10 15:05:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 332ADC433EF for ; Sun, 1 May 2022 16:37:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349568AbiEAQkn (ORCPT ); Sun, 1 May 2022 12:40:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349450AbiEAQkf (ORCPT ); Sun, 1 May 2022 12:40:35 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E414B2FFD5 for ; Sun, 1 May 2022 09:37:08 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id a21so14282191edb.1 for ; Sun, 01 May 2022 09:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WZNze3B5Hambsa3tXM3ix5/LF3I4sB2tqfJXOa0YC20=; b=edjRiVazeRMftD/R1Vo1Pa/EQ2v0S/ji7qos+WtkwDtbChDphN5TE1bhIzylL4jIQC zcitQkSpUuur9FDznbsW4SRcL2ePCQSudmes+NuC+4+qGe62MMD2SMbjvfE+m7uale0G TJETJ0SVc9I6JSW4RgRce47aczto4mtJcV6ihx0a/p1GCLmXCYpiOLYC7diOg3Y4x8eX 2F1pBRdG2uBzzMEqs186+yUdtUx6C9rklo+VdSw26+c4Oz3L+akmi5ZWaw4qHsAEshSP DcDN3mBQFabjKlmX8E1k2TovejfCyZv4BnL/n5lSgpLKTIXyT8gAMvLrWeZws2H5YYJs kxtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WZNze3B5Hambsa3tXM3ix5/LF3I4sB2tqfJXOa0YC20=; b=bd96IE6vQWFEzeCyHrjxTX+n9PAyPwi3rTZosw03ZrTLOcLSNjhvduljRMuV2I9C+n a7e9CISCJzfnpNZO9e3nafQ6ZxvVzBvAv00PxOdHw68lJ3BNMDK6ma6VYmETQPA7rqS7 mJndF96/ODMb01xfg8Y1Zq4Irg5n56UNBWHtvCe/wj2XBvIwc8vfKoQKbBBtv7I4N2zi uYgJ13+YgRfsqLFLIMRtIf5DVFSJGyr3pfGY2FccOAyXTTK86MkBvPGK3EAOMBQHl14j tZohuFGG7WnMfIfAKliMYeIMuVnV2EK/6un4MaQL/sdNtM6m4dNFpEVzg+Y6KIjHs0C3 eUmQ== X-Gm-Message-State: AOAM532TGGXmN4leDBFzLDV4/sDt9T5U/TskSofea3hf/LR5HlGbisEn 3XpFPshXR6Ldc/PINf2Coos= X-Google-Smtp-Source: ABdhPJx19/wxA7wf0mvr1SSDq2Uj8zwDUiUyY70mmT2KpG3BV15XBbWkOHdeLImV9YQVYWZpZjn/nA== X-Received: by 2002:a05:6402:51d0:b0:426:110e:5d05 with SMTP id r16-20020a05640251d000b00426110e5d05mr9800204edd.384.1651423027505; Sun, 01 May 2022 09:37:07 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p54a074e9.dip0.t-ipconnect.de. [84.160.116.233]) by smtp.gmail.com with ESMTPSA id e26-20020a170906845a00b006f3ef214e6csm2706059ejy.210.2022.05.01.09.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 May 2022 09:37:07 -0700 (PDT) Date: Sun, 1 May 2022 18:37:05 +0200 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] staging: vt6655: Rename function CARDbGetCurrentTSF Message-ID: <1f38006d7eb18426a2336b7666d385021bf81faf.1651422181.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The name of the function uses CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann --- drivers/staging/vt6655/card.c | 10 +++++----- drivers/staging/vt6655/card.h | 2 +- drivers/staging/vt6655/device_main.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index ec6fd185d3fd..d1dfd96e13b7 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -11,7 +11,7 @@ * CARDbAddBasicRate - Add to BasicRateSet * CARDbIsOFDMinBasicRate - Check if any OFDM rate is in BasicRateSet * CARDqGetTSFOffset - Calculate TSFOffset - * CARDbGetCurrentTSF - Read Current NIC TSF counter + * card_get_current_tsf - Read Current NIC TSF counter * CARDqGetNextTBTT - Calculate Next Beacon TSF counter * CARDvSetFirstNextTBTT - Set NIC Beacon time * CARDvUpdateNextTBTT - Sync. NIC Beacon time @@ -288,7 +288,7 @@ bool CARDbUpdateTSF(struct vnt_private *priv, unsigned = char byRxRate, u64 local_tsf; u64 qwTSFOffset =3D 0; =20 - CARDbGetCurrentTSF(priv, &local_tsf); + card_get_current_tsf(priv, &local_tsf); =20 if (qwBSSTimestamp !=3D local_tsf) { qwTSFOffset =3D CARDqGetTSFOffset(byRxRate, qwBSSTimestamp, @@ -322,7 +322,7 @@ bool CARDbSetBeaconPeriod(struct vnt_private *priv, { u64 qwNextTBTT =3D 0; =20 - CARDbGetCurrentTSF(priv, &qwNextTBTT); /* Get Local TSF counter */ + card_get_current_tsf(priv, &qwNextTBTT); /* Get Local TSF counter */ =20 qwNextTBTT =3D CARDqGetNextTBTT(qwNextTBTT, wBeaconInterval); =20 @@ -739,7 +739,7 @@ u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF= 1, u64 qwTSF2) * * Return Value: true if success; otherwise false */ -bool CARDbGetCurrentTSF(struct vnt_private *priv, u64 *pqwCurrTSF) +bool card_get_current_tsf(struct vnt_private *priv, u64 *pqwCurrTSF) { void __iomem *iobase =3D priv->port_offset; unsigned short ww; @@ -811,7 +811,7 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv, void __iomem *iobase =3D priv->port_offset; u64 qwNextTBTT =3D 0; =20 - CARDbGetCurrentTSF(priv, &qwNextTBTT); /* Get Local TSF counter */ + card_get_current_tsf(priv, &qwNextTBTT); /* Get Local TSF counter */ =20 qwNextTBTT =3D CARDqGetNextTBTT(qwNextTBTT, wBeaconInterval); /* Set NextTBTT */ diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h index 09e7f3f1cbed..55fe039065db 100644 --- a/drivers/staging/vt6655/card.h +++ b/drivers/staging/vt6655/card.h @@ -46,7 +46,7 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv, unsigned short wBeaconInterval); void CARDvUpdateNextTBTT(struct vnt_private *priv, u64 qwTSF, unsigned short wBeaconInterval); -bool CARDbGetCurrentTSF(struct vnt_private *priv, u64 *pqwCurrTSF); +bool card_get_current_tsf(struct vnt_private *priv, u64 *pqwCurrTSF); u64 CARDqGetNextTBTT(u64 qwTSF, unsigned short wBeaconInterval); u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF1, u64 qwTSF2); unsigned char CARDbyGetPktType(struct vnt_private *priv); diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/= device_main.c index 12fd825c23fe..393430757700 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -1603,7 +1603,7 @@ static u64 vnt_get_tsf(struct ieee80211_hw *hw, struc= t ieee80211_vif *vif) struct vnt_private *priv =3D hw->priv; u64 tsf; =20 - CARDbGetCurrentTSF(priv, &tsf); + card_get_current_tsf(priv, &tsf); =20 return tsf; } --=20 2.25.1 From nobody Sun May 10 15:05:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80F98C433EF for ; Sun, 1 May 2022 16:37:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349517AbiEAQks (ORCPT ); Sun, 1 May 2022 12:40:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349465AbiEAQkn (ORCPT ); Sun, 1 May 2022 12:40:43 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC2B135A9F for ; Sun, 1 May 2022 09:37:14 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id kq17so23964261ejb.4 for ; Sun, 01 May 2022 09:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RuBggiuD5oIMX1zxUHB2r8PYsvHVOiwUMLDRoSntVGA=; b=kEI4bMTv9yBKbNra1uMzo8dPs26j5U7OZkrKy4pi5nBl+dDf/bBHWkKuPAlx68vh0x 4abWCI2OsVKX3c4rVZEtOX5tgeGimNRw+VtmvrNGbGiOei2tTQGURQsJ5fLAkGrSf0ar QxUFxpTdv6vpjgNBVUKqbZl0sLln1L1BLAL4994l5gfQ9Czv9gfJ4s12xvYI7b0iZvNg zel3iWURE5d7h2ApEb3LvlCOYc3rCzGIjs0D0m1j2JpZRhVq4a7Oxe0HOwukPQ3Fx3Fy 7DPEW8e++Iis662etdXQU7LOC/LXUV2tCf+Xujh/+cZUWXfmhWn//EkbGF7v8cqz/YRd cG9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RuBggiuD5oIMX1zxUHB2r8PYsvHVOiwUMLDRoSntVGA=; b=xpkua7CxzZK6w/Ns3KcOQ+z+4TJIXVj6EnvD7UmEFd8mJJnz25AKJfouaoI7Vw8SxD LuGTvBVfgEChd19e041ykrUi8wlCltCeVCzrtua9hLnE9JDLGvcV74sdyBKEIQqJYZVL 13CWeFiZLKOJJeh3HDJW7HFHaozNIjz2JJqCSt3UDEJAZeyJlJpJEs50DYk4QBJv4sBB YKiTdAzqWY3L3yvZuhuhoAVHaVIljjgYyf2a8O8xY1lXNlQ6T+pkXrcgFyF400St08bo CoWKUWyKpcd56+A58b1HUqX5RjChMB1rQ5eOjtHCt5frJkLlFOo/q30wlhogfDR/kxul aFxg== X-Gm-Message-State: AOAM5319TsFEjIdbfpE+4b6YC41HdbMeW1oFz8RkTJ2ho/hy2TGQ6buH RDxYml8lyuRq5MuALlZz6V8= X-Google-Smtp-Source: ABdhPJzVlsS7kY0LqUKGbcm93QmGrQldwvfk0YwnoGZ2O5Eine7HMN1rCeztlBv/5f8VvkG+ihQLnA== X-Received: by 2002:a17:906:3042:b0:6cd:20ed:7c5c with SMTP id d2-20020a170906304200b006cd20ed7c5cmr7934254ejd.241.1651423033482; Sun, 01 May 2022 09:37:13 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p54a074e9.dip0.t-ipconnect.de. [84.160.116.233]) by smtp.gmail.com with ESMTPSA id p14-20020a056402154e00b0042617ba63a8sm5482223edx.50.2022.05.01.09.37.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 May 2022 09:37:13 -0700 (PDT) Date: Sun, 1 May 2022 18:37:11 +0200 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] staging: vt6655: Replace unused return value of card_get_current_tsf Message-ID: <2533d7e6b64660e0c23e495a56737fc35b2f916b.1651422181.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace unused return value with u64 to increase readability, reduce address and dereference operators and omit pqwCurrTSF that uses CamelCase which is not accepted by checkpatch.pl Signed-off-by: Philipp Hortmann --- Diffs for testing: u64 qwNextTBTT; qwNextTBTT =3D card_get_current_tsf(priv); /* Get Local TSF counter= */ + dev_info(&priv->pcid->dev, "CARDbSetBeaconPeriod 0x%016llx", qwNext= TBTT); qwNextTBTT =3D CARDqGetNextTBTT(qwNextTBTT, wBeaconInterval); /* set HW beacon interval */ @@ -810,7 +810,7 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv, u64 qwNextTBTT; qwNextTBTT =3D card_get_current_tsf(priv); /* Get Local TSF counter= */ + dev_info(&priv->pcid->dev, "CARDvSetFirstNextTBTT 0x%016llx", qwNex= tTBTT); qwNextTBTT =3D CARDqGetNextTBTT(qwNextTBTT, wBeaconInterval); /* Set NextTBTT */ VNSvOutPortD(iobase + MAC_REG_NEXTTBTT, (u32)qwNextTBTT); Log: vt6655 0000:01:05.0: CARDbSetBeaconPeriod 0x00 00 00 01 4a 89 52 c4 vt6655 0000:01:05.0: CARDvSetFirstNextTBTT 0x00 00 00 01 4a 89 52 dc --- drivers/staging/vt6655/card.c | 20 +++++++++----------- drivers/staging/vt6655/card.h | 2 +- drivers/staging/vt6655/device_main.c | 2 +- 3 files changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index d1dfd96e13b7..50d70ebff83a 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -288,7 +288,7 @@ bool CARDbUpdateTSF(struct vnt_private *priv, unsigned = char byRxRate, u64 local_tsf; u64 qwTSFOffset =3D 0; =20 - card_get_current_tsf(priv, &local_tsf); + local_tsf =3D card_get_current_tsf(priv); =20 if (qwBSSTimestamp !=3D local_tsf) { qwTSFOffset =3D CARDqGetTSFOffset(byRxRate, qwBSSTimestamp, @@ -320,9 +320,9 @@ bool CARDbUpdateTSF(struct vnt_private *priv, unsigned = char byRxRate, bool CARDbSetBeaconPeriod(struct vnt_private *priv, unsigned short wBeaconInterval) { - u64 qwNextTBTT =3D 0; + u64 qwNextTBTT; =20 - card_get_current_tsf(priv, &qwNextTBTT); /* Get Local TSF counter */ + qwNextTBTT =3D card_get_current_tsf(priv); /* Get Local TSF counter */ =20 qwNextTBTT =3D CARDqGetNextTBTT(qwNextTBTT, wBeaconInterval); =20 @@ -739,7 +739,7 @@ u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF= 1, u64 qwTSF2) * * Return Value: true if success; otherwise false */ -bool card_get_current_tsf(struct vnt_private *priv, u64 *pqwCurrTSF) +u64 card_get_current_tsf(struct vnt_private *priv) { void __iomem *iobase =3D priv->port_offset; unsigned short ww; @@ -753,16 +753,14 @@ bool card_get_current_tsf(struct vnt_private *priv, u= 64 *pqwCurrTSF) break; } if (ww =3D=3D W_MAX_TIMEOUT) - return false; + return 0; low =3D ioread32(iobase + MAC_REG_TSFCNTR); high =3D ioread32(iobase + MAC_REG_TSFCNTR + 4); #ifdef __BIG_ENDIAN - *pqwCurrTSF =3D high + ((u64)low << 32); + return high + ((u64)low << 32); #else - *pqwCurrTSF =3D low + ((u64)high << 32); + return low + ((u64)high << 32); #endif - - return true; } =20 /* @@ -809,9 +807,9 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv, unsigned short wBeaconInterval) { void __iomem *iobase =3D priv->port_offset; - u64 qwNextTBTT =3D 0; + u64 qwNextTBTT; =20 - card_get_current_tsf(priv, &qwNextTBTT); /* Get Local TSF counter */ + qwNextTBTT =3D card_get_current_tsf(priv); /* Get Local TSF counter */ =20 qwNextTBTT =3D CARDqGetNextTBTT(qwNextTBTT, wBeaconInterval); /* Set NextTBTT */ diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h index 55fe039065db..7830a055b855 100644 --- a/drivers/staging/vt6655/card.h +++ b/drivers/staging/vt6655/card.h @@ -46,7 +46,7 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv, unsigned short wBeaconInterval); void CARDvUpdateNextTBTT(struct vnt_private *priv, u64 qwTSF, unsigned short wBeaconInterval); -bool card_get_current_tsf(struct vnt_private *priv, u64 *pqwCurrTSF); +u64 card_get_current_tsf(struct vnt_private *priv); u64 CARDqGetNextTBTT(u64 qwTSF, unsigned short wBeaconInterval); u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF1, u64 qwTSF2); unsigned char CARDbyGetPktType(struct vnt_private *priv); diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/= device_main.c index 393430757700..6989d8d04f2f 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -1603,7 +1603,7 @@ static u64 vnt_get_tsf(struct ieee80211_hw *hw, struc= t ieee80211_vif *vif) struct vnt_private *priv =3D hw->priv; u64 tsf; =20 - card_get_current_tsf(priv, &tsf); + tsf =3D card_get_current_tsf(priv); =20 return tsf; } --=20 2.25.1