From nobody Sun May 10 22:39:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48BEFC433EF for ; Thu, 21 Apr 2022 19:20:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391911AbiDUTXq (ORCPT ); Thu, 21 Apr 2022 15:23:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391869AbiDUTXd (ORCPT ); Thu, 21 Apr 2022 15:23:33 -0400 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D76AD4D249 for ; Thu, 21 Apr 2022 12:20:40 -0700 (PDT) Received: by mail-qk1-x733.google.com with SMTP id b68so4319763qkc.4 for ; Thu, 21 Apr 2022 12:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B8hL0jBT5xZ4aSX/GQ3ksV9bgLPofPyPWC/LZsNauFo=; b=XG8SJK33BDwMiVJqw1QQx/+w1u+bNOgMSY0Tm61NDdxthwyeJVFDjL2trbkS26WY7p jZL5SP/LnQPZ5kJd5XLSgnkgsncZhKVC409Hef4jfDFnY7IvAbw0Z6Jcw5ly8OpeIWvQ UGM+j2W6WexEmdSC3Ank/7x641c5dvG07g0kMxV7X1pkEbmYdgybn5q+Q26uI8tDQWVQ nmn/qpPE4yC3Ze4PkH0PVABDy0yahSoMSStaJFAjC060xRGBneViu6lkGSIScGSvoj1c tkpOvlSUT8q2dgbTtjyc3YTrif4+V03SHSnA70t3curI6Qdf3RU+8XqLy4XWfRjB984w Pjug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B8hL0jBT5xZ4aSX/GQ3ksV9bgLPofPyPWC/LZsNauFo=; b=lMfMOAsHyl3EuuKHOJDs7qBKDbIfzM4Gn9hq7j0nuT19qcgrt6QIh1Yc3jtKUzoBke KgD7NZpU8C2zreHzBRhNIjMQaNjiRHAmj4a/0OvZgfy1rQWxnruQ2+3CmHv7+UMq+/hk r+J/lH0AA9q1nx7iHYhZKYFVM3jotye9JJN6DGQSpxx464w7jR/2/LEAKAfF4iajP7dD VQMSUdl5lGzbjy99WzwMbVs7HZ73AEHyEleqozErdN+ga+gZHAZUQ8lKqXTENFlwGOWz y290IKpWxNYDaAOYpz/yeM1JX7z4tCyY+kF0nFA2Nz5yFbpyLa+aRGPb4rfb0Pmf0CSz FDYQ== X-Gm-Message-State: AOAM530LijcbCc3vYBiOYQ/xqVt9WtYdePm82sJSPHl6uvySoIWsuol6 k0sMUTH/eTd7spg0LbwhBRg= X-Google-Smtp-Source: ABdhPJz06GNbdRt8kpmS3Y9/FKz328cWWogMe2wv1AFvX0xYG0jQK8O4EbxTpjClD3KlnqRuCQpBHw== X-Received: by 2002:a05:620a:2681:b0:67e:933e:54b6 with SMTP id c1-20020a05620a268100b0067e933e54b6mr647276qkp.428.1650568840022; Thu, 21 Apr 2022 12:20:40 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id l9-20020a05622a174900b002f34421b01csm2567736qtk.23.2022.04.21.12.20.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 12:20:39 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH v4 1/7] staging: r8188eu: remove unnecessary braces in single statement block Date: Thu, 21 Apr 2022 15:20:26 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove braces for single statement block to minimize the number of empty lines, without loss of readability. Issue found with checkpatch. WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 3e9882f89f76..d3f4d7cdfa08 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -112,9 +112,8 @@ void _rtw_free_mlme_priv(struct mlme_priv *pmlmepriv) =20 rtw_free_mlme_priv_ie_data(pmlmepriv); =20 - if (pmlmepriv) { + if (pmlmepriv) vfree(pmlmepriv->free_bss_buf); - } =20 } =20 --=20 2.25.1 From nobody Sun May 10 22:39:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABBA4C433F5 for ; Thu, 21 Apr 2022 19:21:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229974AbiDUTXu (ORCPT ); Thu, 21 Apr 2022 15:23:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391876AbiDUTXh (ORCPT ); Thu, 21 Apr 2022 15:23:37 -0400 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 211F74D252 for ; Thu, 21 Apr 2022 12:20:42 -0700 (PDT) Received: by mail-qk1-x733.google.com with SMTP id y129so4318343qkb.2 for ; Thu, 21 Apr 2022 12:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fZneH4LjchLUspCBR6Lavef7yu8zFb5eswSR3q4Bedk=; b=VezwsUuuDcpjP96JaMyId6lbKh94k5PRoJc+VgRn6QMBC9LAJHOZyisA3pizrmw01f T5ph+dtxqVd05uSYw2FZmC51z9oYoOHt7shNjYlmux5X8Hceji+Z6GLtMM8y+9M2Uf3i j1n6U6ovQiub2n1Cc+GBkOpnyi//Rs75yS5AcnfFJfQNKsrp/macF8Li/BeYDRZrMukd RaIyCU9ExBnDm5TP3ZT+RSu9TlPZNKxqzGRM+2KSWIJNmt6hh9N60CczwMTl3Al6PUgB 7k5i+LMpPNieFV2FKWSEcvU/p/bI5Ric1vJDvoKeVfqIFP3Vp2qD+zmf4jdYQ1YOhruT mLLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fZneH4LjchLUspCBR6Lavef7yu8zFb5eswSR3q4Bedk=; b=WZ7gEcNrxsWqif8yNnSAvUdWL1Q5o5PVJfbbTeIdQDFHhii9np8NWrtYiE3/QGMlS1 53Jnwmf1nOPlJwDNziIV1rP+3sEGsdX14G5x4zEVq73zPD8l4K2HT2F5wXOxzQUNjSbK l4a/5gx359LTG6laOiwdJt0X32ibKqPNEBbkeZQoxBMOk/8dKrRcrfgnHvHYyfiOlMlr QeCJc6Byl6AeAx6F05XcoijUXudUUNLQaiKSveG0PeuAi5M6UoNxHWo5s2yNb6Jlq9WN SQ5/knIXNK5Zxssgih8IYte3s8GSfcpQLnDoy3KwQRd3XSC6lZUkzP6+re1lzL93pDJA CKQw== X-Gm-Message-State: AOAM532wwQe83uqQI6N3sb+AnfdBHee2cUI/hP/LbgILJ/RNr40CUQE+ mNvaU/BJCLdlBjEBoM81j30= X-Google-Smtp-Source: ABdhPJxGiRkrAoMbgBK8oGXrrEHyDpC98OxpXgGcmOOiQdDF6gJnxnFvNjVu92/aWttU1VqG1wUOwA== X-Received: by 2002:a05:620a:29d1:b0:69e:d2e2:b3ce with SMTP id s17-20020a05620a29d100b0069ed2e2b3cemr636184qkp.686.1650568841218; Thu, 21 Apr 2022 12:20:41 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id l9-20020a05622a174900b002f34421b01csm2567736qtk.23.2022.04.21.12.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 12:20:40 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH v4 2/7] staging: r8188eu: remove spaces before tabs Date: Thu, 21 Apr 2022 15:20:27 -0400 Message-Id: <1b1e8cda03ca5d3fdf26c511da76258f7a2ab8d5.1650568579.git.jhpark1013@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Delete spaces before tabs in the comments. Issue found with checkpatch. WARNING: please, no space before tabs Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index d3f4d7cdfa08..2cfd8e8d74a4 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -573,8 +573,8 @@ static void rtw_add_network(struct adapter *adapter, =20 /* select the desired network based on the capability of the (i)bss. */ /* check items: (1) security */ -/* (2) network_type */ -/* (3) WMM */ +/* (2) network_type */ +/* (3) WMM */ /* (4) HT */ /* (5) others */ static bool rtw_is_desired_network(struct adapter *adapter, struct wlan_ne= twork *pnetwork) @@ -909,9 +909,9 @@ static struct sta_info *rtw_joinbss_update_stainfo(stru= ct adapter *padapter, str memset((u8 *)&psta->dot11txpn, 0, sizeof(union pn48)); memset((u8 *)&psta->dot11rxpn, 0, sizeof(union pn48)); } - /* Commented by Albert 2012/07/21 */ - /* When doing the WPS, the wps_ie_len won't equal to 0 */ - /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitt= ed. */ + /* Commented by Albert 2012/07/21 */ + /* When doing the WPS, the wps_ie_len won't equal to 0 */ + /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitte= d. */ if (padapter->securitypriv.wps_ie_len !=3D 0) { psta->ieee8021x_blocked =3D true; padapter->securitypriv.wps_ie_len =3D 0; @@ -1634,8 +1634,8 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ /* */ /* Search by BSSID, */ /* Return Value: */ -/* -1 :if there is no pre-auth key in the table */ -/* >=3D 0 :if there is pre-auth key, and return the entry id */ +/* -1 :if there is no pre-auth key in the table */ +/* >=3D 0 :if there is pre-auth key, and return the entry id */ /* */ /* */ =20 --=20 2.25.1 From nobody Sun May 10 22:39:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5641BC433FE for ; Thu, 21 Apr 2022 19:21:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391866AbiDUTXw (ORCPT ); Thu, 21 Apr 2022 15:23:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391894AbiDUTXh (ORCPT ); Thu, 21 Apr 2022 15:23:37 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52C4E33882 for ; Thu, 21 Apr 2022 12:20:43 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id bb21so4011243qtb.3 for ; Thu, 21 Apr 2022 12:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jWtgrgCunJ7y2eDAedOrW5DZBPj0gqKyi2a7G2/e/4U=; b=kAW26HAITAbFAGVv0mM9r7y00YX31OV1dRygPiaqLdWdJzBeBEKEZNZHIxbLx9WOkW btvNY2sO6K/ieesQJ98dqudLJhtWtUUNyNSIRHfCnqZ5frxqHgAQz6NClgdRYAQRgZ6B laNadyJFcCsw67vkgQzjXdGJgo1CvPOPkD+YT4g6LeIzMMhM4uAe6SKlafNpsqb70fST ReP57qGKSUdcFmfRREz0jbqjLbgWoNciyjgTa1lVEnZXZHhwKHj8Hd/8NSubRJDOpl+R h4D+B5Fu/rXzQEpingwJDM0VKq51WLV7pRACX42n6WGxnAr5vxzv9qVoHAgkkVUpauiv eUGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jWtgrgCunJ7y2eDAedOrW5DZBPj0gqKyi2a7G2/e/4U=; b=tZ13ZVJEvEik7u6+IhINKJdHoWq/9PXA6kIWrcClWq+HFbn47VBzhd4Uvw35Q+o4Re Is1pMpAHHFpWBap1+b1RPejD0bviQ1Cpm2gGu42Lsg5e8Zfhz9pCQ1DpqZRoyHF7Y3C/ ZpxJLT1QxEDSFFafsrfh2lKGTZykIJhUXABD0FP8zUw1N9QctSBMw3TNTjOh1qB7movp uAYDqJtekG+hLmq4BJxTZvE3AiLlpMHuRdUWQ9yUZQroowyg999rgKlC7DgjaV8bWRpd nDFT0ebkeFFSWPoi8Kxs21SSp/XK0ABaFPJcGK/ckMzE5QFzz5tsR3mxysoY6QWOUbM6 dnEg== X-Gm-Message-State: AOAM533dtZEDH1y9FdgWkgmdsBAbBhuPVIUUIna06akhUAI+kYIWuYBw dTIme8SWf1jmdE9ahtIYnvA= X-Google-Smtp-Source: ABdhPJz0Sf/4uOw6SGvqQ+a5x/bu+v79Td0Vm9arvLkFPYfsQM5zt7PHM/U9bdPm1KqkX8vXTmshvQ== X-Received: by 2002:ac8:5a09:0:b0:2f1:ff1d:39df with SMTP id n9-20020ac85a09000000b002f1ff1d39dfmr731992qta.453.1650568842469; Thu, 21 Apr 2022 12:20:42 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id l9-20020a05622a174900b002f34421b01csm2567736qtk.23.2022.04.21.12.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 12:20:41 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com, Alison Schofield Subject: [PATCH v4 3/7] staging: r8188eu: remove 'added by' author comments Date: Thu, 21 Apr 2022 15:20:28 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Author comments "Added by Albert" and "Added by Annie" are sprinkled through the file. These comments are not useful and can be removed. Suggested-by: Alison Schofield Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 2cfd8e8d74a4..5adef9b9108d 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -909,7 +909,6 @@ static struct sta_info *rtw_joinbss_update_stainfo(stru= ct adapter *padapter, str memset((u8 *)&psta->dot11txpn, 0, sizeof(union pn48)); memset((u8 *)&psta->dot11rxpn, 0, sizeof(union pn48)); } - /* Commented by Albert 2012/07/21 */ /* When doing the WPS, the wps_ie_len won't equal to 0 */ /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitte= d. */ if (padapter->securitypriv.wps_ie_len !=3D 0) { @@ -1628,9 +1627,6 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ return ielength; } =20 -/* */ -/* Ported from 8185: IsInPreAuthKeyList(). (Renamed from SecIsInPreAuthKe= yList(), 2006-10-13.) */ -/* Added by Annie, 2006-05-07. */ /* */ /* Search by BSSID, */ /* Return Value: */ --=20 2.25.1 From nobody Sun May 10 22:39:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 149C6C433F5 for ; Thu, 21 Apr 2022 19:21:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391873AbiDUTXy (ORCPT ); Thu, 21 Apr 2022 15:23:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391898AbiDUTXh (ORCPT ); Thu, 21 Apr 2022 15:23:37 -0400 Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69B00496BC for ; Thu, 21 Apr 2022 12:20:44 -0700 (PDT) Received: by mail-qv1-xf2f.google.com with SMTP id dw17so4403791qvb.9 for ; Thu, 21 Apr 2022 12:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RsvCyHjEEdexsUzersCRTZshhGaPsOo9bh7mou5OagQ=; b=FkgurS7SauexiZ2xz+IYN6sCV8y8IctfMz6zJRR0B1i1HZUczTuqQ6Jal4cqrtpvCX GZZdHzXtpZX9SHLCLW7ThoFTfZpFT6jng+3sCIR0Jjuj2/NSY4u4QrehQ1G15w7Jahet d3Mi6iTAHXRlx28tDX2tC8O9CO+gNZbr7N6j8F0kQutBSYhM4LclnTWbkgBelEJW+fSY RcCbg/7n4TpsTU6h+kET+XYSKialRwMI8xRMF1eQed1KrEjB1eWXOi/iPR1gocRKwF6M 3IjFWZvSyOty7p04A+dYe0eVbuZsPLdhNa4ASbK1ep6l9YMxMxcQYh3HmX7tNxp14aen pO6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RsvCyHjEEdexsUzersCRTZshhGaPsOo9bh7mou5OagQ=; b=1zMGnNfm1E6yEHt3zilWaIOlbZEF9Xujsm4vHUMMUOhIiEoCtSU5ATo5Ckdsl+Uije x9B74PfMcIo/pBGALqSdu+ncHqmZbV4CEFRsFMYVq1SqzKMkVRWso2J62M4cIxPVSal8 09RCSxqNQvCwJaDFmE/866p79mYkWPu3Jp95Fpbk26uMZVPRN66ZMHCpwy5JMW35PXWp 7hL4oBlyFauOlQ6nATmP7r+JTk1bQhwHO28ez4suffRw21rmlOR/nHtcf3amTrohQ7uT UvawtAugr2A1hYEJfvjdhrj+a+ZLGoAzr2aQ7uw2lsPCHGz0bDaJwlLIJGcojrsKmoaE Qv8w== X-Gm-Message-State: AOAM530Lau/N/aB75Nd16ZnFqIbykdXnuBxjIMgizsO9PaGOZept9DLc yf5ixmRKEHNX6e3tMoS88/8= X-Google-Smtp-Source: ABdhPJwO0I3s7RxyUKvfBF8cqKZtNGNGlYfjd7FaVUq9letNDxcuYXA6OBmvU6zFcMxeaY8rdrBIiw== X-Received: by 2002:ad4:5aa3:0:b0:443:9ba7:3f27 with SMTP id u3-20020ad45aa3000000b004439ba73f27mr812991qvg.63.1650568843523; Thu, 21 Apr 2022 12:20:43 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id l9-20020a05622a174900b002f34421b01csm2567736qtk.23.2022.04.21.12.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 12:20:43 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH v4 4/7] staging: r8188eu: place constants on the right side of tests Date: Thu, 21 Apr 2022 15:20:29 -0400 Message-Id: <2fa0eaadcb7d3772fb1c4f67d4ba9e1620ffeb7a.1650568579.git.jhpark1013@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" To comply with the linux coding style, place constants on the right side of the test in comparisons. Issue found with checkpatch. WARNING: Comparisons should place the constant on the right side of the test. Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 5adef9b9108d..b943fb190e4c 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -721,7 +721,7 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) set_fwstate(pmlmepriv, _FW_UNDER_LINKING); pmlmepriv->to_join =3D false; s_ret =3D rtw_select_and_join_from_scanned_queue(pmlmepriv); - if (_SUCCESS =3D=3D s_ret) { + if (s_ret =3D=3D _SUCCESS) { _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else if (s_ret =3D=3D 2) { /* there is no need to wait for join */ _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); @@ -729,7 +729,8 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) } else { if (rtw_to_roaming(adapter) !=3D 0) { if (--pmlmepriv->to_roaming =3D=3D 0 || - _SUCCESS !=3D rtw_sitesurvey_cmd(adapter, &pmlmepriv->assoc_ssid,= 1, NULL, 0)) { + rtw_sitesurvey_cmd(adapter, &pmlmepriv->assoc_ssid, + 1, NULL, 0) !=3D _SUCCESS) { rtw_set_roaming(adapter, 0); rtw_free_assoc_resources(adapter, 1); rtw_indicate_disconnect(adapter); @@ -1970,7 +1971,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr issued =3D (phtpriv->agg_enable_bitmap >> priority) & 0x1; issued |=3D (phtpriv->candidate_tid_bitmap >> priority) & 0x1; =20 - if (0 =3D=3D issued) { + if (issued =3D=3D 0) { psta->htpriv.candidate_tid_bitmap |=3D BIT((u8)priority); rtw_addbareq_cmd(padapter, (u8)priority, pattrib->ra); } @@ -1997,19 +1998,19 @@ void _rtw_roaming(struct adapter *padapter, struct = wlan_network *tgt_network) else pnetwork =3D &pmlmepriv->cur_network; =20 - if (0 < rtw_to_roaming(padapter)) { + if (rtw_to_roaming(padapter) > 0) { memcpy(&pmlmepriv->assoc_ssid, &pnetwork->network.Ssid, sizeof(struct nd= is_802_11_ssid)); =20 pmlmepriv->assoc_by_bssid =3D false; =20 while (1) { do_join_r =3D rtw_do_join(padapter); - if (_SUCCESS =3D=3D do_join_r) { + if (do_join_r =3D=3D _SUCCESS) { break; } else { pmlmepriv->to_roaming--; =20 - if (0 < pmlmepriv->to_roaming) { + if (pmlmepriv->to_roaming > 0) { continue; } else { rtw_indicate_disconnect(padapter); --=20 2.25.1 From nobody Sun May 10 22:39:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E65C433EF for ; Thu, 21 Apr 2022 19:21:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391926AbiDUTYH (ORCPT ); Thu, 21 Apr 2022 15:24:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391899AbiDUTXh (ORCPT ); Thu, 21 Apr 2022 15:23:37 -0400 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D2034C7A6 for ; Thu, 21 Apr 2022 12:20:45 -0700 (PDT) Received: by mail-qt1-x836.google.com with SMTP id d14so4013703qtw.5 for ; Thu, 21 Apr 2022 12:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ul9FGVJ1sqTdARK0mUZLH5+vAqXgfv1Osb8Y+BayvnA=; b=PboPQS2k7qvXDrE1qoUSXr2+VaPYMTv45/YlkkbxdwUA9owtd9aItiTqTE4Wi5GvNq ZrzMhUzwkihHH0iR99HRnJOBjRQECZvU01YsruDLsSV6VVimkgIKpm5W/HB64MkeScMn CHpY7/80p2iqBHHRyKMrt8OfL4vwyCD83efJWF1+XlngJLKRFaY1zbfGTMsZnzDRaeq4 8k7Jktm+/DyQqfUO9sa+x0Ncn0GTU4gOdWtqDlGxci0MgRBDRHf913iCRLhkwD+X0I2p s3YxqejLxsNu2FiRHe09Xy/N/tByUvRd2K6SkV+GIgb9VH6ZRuBp8raJgw1vSJc32qsy WzXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ul9FGVJ1sqTdARK0mUZLH5+vAqXgfv1Osb8Y+BayvnA=; b=q0f+mStL5EiqOGlgxsfRF8XHzwAcYXqGJ6zC4ex1BHJXHl3RlkqEvnOsLh4rIvg3oJ PMrRZGERxW/t7cy2JwdGXVa3jvn3tAS7zZD+7JtEQirT3WcQvX3HxWCG2JLsZ4G9gipi Oh3wFAfJOYcnXi2pY+wY6/95a3fCrC7ogXCQrLSafW+rp9mz8P1T26Q3lxzgXmA5W9G1 bI9VO0oLSzYSFluQ2LaTMCXz3nIb82qwwtb17yhC0ChKwZk4C5gJIF/mhKxlu3+elf3Y scmi8SRmgHb+ICnP6tx/NtsthsyYg5zcOY66xGuGIsatg4MrpEdcsIJefK5Kcv81EzqT 9l4w== X-Gm-Message-State: AOAM53133t5z2qgcZZpH5c9iCI5myPck/CyfsSsGrKXnQLxNX22IiKcI zNqCFQ2rH2XYGBJVlMaWm1M= X-Google-Smtp-Source: ABdhPJydGXJP9BFb1WSRFH7cUBdCTIZqsh5XL7qhdz3craqFPk3UEPjmG7JCVH0Qt25hbQzNFkc5lA== X-Received: by 2002:a05:622a:446:b0:2e1:b95e:3b48 with SMTP id o6-20020a05622a044600b002e1b95e3b48mr758043qtx.310.1650568844562; Thu, 21 Apr 2022 12:20:44 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id l9-20020a05622a174900b002f34421b01csm2567736qtk.23.2022.04.21.12.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 12:20:44 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH v4 5/7] staging: r8188eu: replace spaces with tabs Date: Thu, 21 Apr 2022 15:20:30 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use tabs instead of spaces. Issue found with checkpatch. WARNING: suspect code indent for conditional statements Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index b943fb190e4c..7a90fe826d1d 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -722,7 +722,7 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) pmlmepriv->to_join =3D false; s_ret =3D rtw_select_and_join_from_scanned_queue(pmlmepriv); if (s_ret =3D=3D _SUCCESS) { - _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); + _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else if (s_ret =3D=3D 2) { /* there is no need to wait for join */ _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); rtw_indicate_connect(adapter); --=20 2.25.1 From nobody Sun May 10 22:39:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BD3EC433F5 for ; Thu, 21 Apr 2022 19:21:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391917AbiDUTX7 (ORCPT ); Thu, 21 Apr 2022 15:23:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391903AbiDUTXh (ORCPT ); Thu, 21 Apr 2022 15:23:37 -0400 Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94E1A4D257 for ; Thu, 21 Apr 2022 12:20:46 -0700 (PDT) Received: by mail-qv1-xf2a.google.com with SMTP id b17so4393200qvf.12 for ; Thu, 21 Apr 2022 12:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NMYq8qcFTxh0xZzr+s+ajhPy8SCulftSg3sqVf1Tdxo=; b=gFzJ2Ur0qLFC5+5sMie2YMAG4RMwHvM/T+9Lym1w/HUKyn3+4P2HF3HDL8aRGEgaI+ xWxwQZgyX3BlVwkzkkQeLpNsdoqHjzzj+taHP6nEWXVqEcDrE+lKIyrYOJFNXxlA+yZR RmB0zt7Ox2gUE4w3cFVrXGz58rgmYG0/3HCfNAlfvbSdmLSsG1CQuBOT5ssA8XsTe4CC vAFodrhA6RqD4rUtB4vUm4cJ5b4SKOQCaT0LJ+FXiQ4LuGLCnraBzQaNCzPsufKNUSdL kKoilSdywFMmXb38YWpdkZ9zXEIfimwCKK67LAePMWEHWLTWCWMIGI7zzRbHZOL81WsE vLfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NMYq8qcFTxh0xZzr+s+ajhPy8SCulftSg3sqVf1Tdxo=; b=na1fbQDwOypki+tvqLD1Juq9v1Fd91WLQJPUsDS57t4FhlOOgXZOLNJ7S2PO5b6s6C 5BWP7WltWsZOWmFpejJqOhDX8GHEo9fM9uFnadNtn9Q5cerLxwNJzGGn2kUxG6dPDxCM +EBzSCjBgMc9QLoPkJ9rld+GtUyxKqHPkiXXUZO9oQBdRJaEiksbz5AFtiykzWzW6cmj D9KcKWZ0PaMaV5j8r67GRndSMKpBmp0qRwGjFG3nlmR1Ga4OISekKXXW6Pugfz0gsRCw 0ztjZYw5bgJpN1+ZXEeTYtlo0suL91fj+WYkq1l5S1t1PvQeVK8wHV9ggNiRvTpbWPaj Ei3g== X-Gm-Message-State: AOAM5302JKgNFxoiAfLYGwHiOWpi2dDvLEXI7Dm42IV5YUE+amxUVKyM SWYtvxkorvBuGHE8Tc24Hq4= X-Google-Smtp-Source: ABdhPJy8ZQnVqfEMVHIa2M8cOx+4Hsi8pqtCHRwr1SURcmiQj9TJMj9Swa3206Oj/IQ5yBhQTace2w== X-Received: by 2002:a05:6214:c2b:b0:446:5060:2c33 with SMTP id a11-20020a0562140c2b00b0044650602c33mr811826qvd.3.1650568845665; Thu, 21 Apr 2022 12:20:45 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id l9-20020a05622a174900b002f34421b01csm2567736qtk.23.2022.04.21.12.20.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 12:20:45 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH v4 6/7] staging: r8188eu: correct typo in comments Date: Thu, 21 Apr 2022 15:20:31 -0400 Message-Id: <56b25e4394396823d52f1fe1b312c5a307aea0fc.1650568579.git.jhpark1013@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Correct misspellings in the comments. Issue found with checkpatch. Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 7a90fe826d1d..d422ce87ba7c 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -192,7 +192,7 @@ void _rtw_free_network_nolock(struct mlme_priv *pmlmepr= iv, struct wlan_network * /* return the wlan_network with the matching addr =20 - Shall be calle under atomic context... to avoid possible racing condition= ... + Shall be called under atomic context... to avoid possible racing conditio= n... */ struct wlan_network *_rtw_find_network(struct __queue *scanned_queue, u8 *= addr) { @@ -328,7 +328,7 @@ void rtw_free_network_queue(struct adapter *dev, u8 isf= reeall) /* return the wlan_network with the matching addr =20 - Shall be calle under atomic context... to avoid possible racing condition= ... + Shall be called under atomic context... to avoid possible racing conditio= n... */ struct wlan_network *rtw_find_network(struct __queue *scanned_queue, u8 *a= ddr) { @@ -911,7 +911,7 @@ static struct sta_info *rtw_joinbss_update_stainfo(stru= ct adapter *padapter, str memset((u8 *)&psta->dot11rxpn, 0, sizeof(union pn48)); } /* When doing the WPS, the wps_ie_len won't equal to 0 */ - /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitte= d. */ + /* And the Wi-Fi driver shouldn't allow the data packet to be transmitte= d. */ if (padapter->securitypriv.wps_ie_len !=3D 0) { psta->ieee8021x_blocked =3D true; padapter->securitypriv.wps_ie_len =3D 0; @@ -1305,7 +1305,7 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) } =20 /* -* _rtw_join_timeout_handler - Timeout/faliure handler for CMD JoinBss +* _rtw_join_timeout_handler - Timeout/failure handler for CMD JoinBss * @adapter: pointer to struct adapter structure */ void _rtw_join_timeout_handler (struct adapter *adapter) @@ -1340,7 +1340,7 @@ void _rtw_join_timeout_handler (struct adapter *adapt= er) } =20 /* -* rtw_scan_timeout_handler - Timeout/Faliure handler for CMD SiteSurvey +* rtw_scan_timeout_handler - Timeout/Failure handler for CMD SiteSurvey * @adapter: pointer to struct adapter structure */ void rtw_scan_timeout_handler (struct adapter *adapter) --=20 2.25.1 From nobody Sun May 10 22:39:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66B99C433EF for ; Thu, 21 Apr 2022 19:21:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391904AbiDUTYE (ORCPT ); Thu, 21 Apr 2022 15:24:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391880AbiDUTXi (ORCPT ); Thu, 21 Apr 2022 15:23:38 -0400 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1F5C4D25B for ; Thu, 21 Apr 2022 12:20:47 -0700 (PDT) Received: by mail-qt1-x831.google.com with SMTP id hh4so3999109qtb.10 for ; Thu, 21 Apr 2022 12:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=waPvZGOg2+RC3HM/74+dHiUU2qD9NP4c44RrV5MzX3U=; b=W9ybfcqWpycDEozBpfQU6LFay8XtJafMWTs7wjxBUsAiHQCiVqgK/TTf5zf9GOI2pi sypB5HYbVxR6NS02HKa1y4yTaUDEZpGyl6by7caBkMBxSp7quXUzwAlbGR7eIDCb3eOS 8v+4VQ+TsK6VtBS5+1XHr5be7NbrKIH7M8czJl4o8/VbEU0pJIPrqdo223WjtQ/fGS7+ z3PMwJnGkXpW4Mhzrv/8GVLJBMUosYFa/A+c4xAfxbAhDTiUUVKD/NXCY6R22f6EYUtB lhF7YS3NHcNJmEdQz1yBlB5xtJiWU2fP+ybgvnNXJbaOx34zazR+j2dbpKGJFYBOfAb+ mzjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=waPvZGOg2+RC3HM/74+dHiUU2qD9NP4c44RrV5MzX3U=; b=W31zngE5vhkP+/7r6leUDYEiAgX8VTQUPqwVlYR8F9E8b2uCn3qoNKdHRYLtun1DgD MT9iKRCAv/4J3vMGzhTu7mdkvLabubWWoiLMStKhpy7TnemlTxEG1FTzMTb4fAnC3AGe sugTTnTkMTHbj/Vya9lYVqaLIh0VvpVlvgfOnKqE9uqAu1Fs2cTYELBIkjStUnmGCthr 7VxGLkBWg4e8uLClIxQNMu4v1Nz88hgoDO7eQK/0CbZti9wTGf040GdqbuRr7IpaIs+b GHhCIlS8QVANiMG93SseeQ61ZYc4o28TgwV8wMB+B/Jjx/KUEPOzPWDhwkU0WNtPiZsc ZWxQ== X-Gm-Message-State: AOAM530K0pD+buua3++v+jx0PhSW0+j/aEJvhewdzPILokZa0l0KoKss 3vLJjvOvfSXbrrLw0ZQQilM= X-Google-Smtp-Source: ABdhPJwh2SbVL0Zx5HMApclIxaVzYaeCo81OEwDlcihKTpvq1Bgtr7vbzN2dhgpj1kHLG+3mkF6ang== X-Received: by 2002:ac8:5f50:0:b0:2f2:1e88:f919 with SMTP id y16-20020ac85f50000000b002f21e88f919mr745715qta.535.1650568846914; Thu, 21 Apr 2022 12:20:46 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id l9-20020a05622a174900b002f34421b01csm2567736qtk.23.2022.04.21.12.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 12:20:46 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com, Pavel Skripkin Subject: [PATCH v4 7/7] staging: r8188eu: remove unused else condition Date: Thu, 21 Apr 2022 15:20:32 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" s_ret cannot return '2' so this else condition is unused. Remove this unnecessary else statement. Suggested-by: Pavel Skripkin Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index d422ce87ba7c..29b8b101180b 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -723,9 +723,6 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) s_ret =3D rtw_select_and_join_from_scanned_queue(pmlmepriv); if (s_ret =3D=3D _SUCCESS) { _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); - } else if (s_ret =3D=3D 2) { /* there is no need to wait for join */ - _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); - rtw_indicate_connect(adapter); } else { if (rtw_to_roaming(adapter) !=3D 0) { if (--pmlmepriv->to_roaming =3D=3D 0 || --=20 2.25.1