From nobody Mon May 11 02:55:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0367EC433F5 for ; Thu, 21 Apr 2022 14:58:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353404AbiDUPBX (ORCPT ); Thu, 21 Apr 2022 11:01:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1389760AbiDUPBV (ORCPT ); Thu, 21 Apr 2022 11:01:21 -0400 Received: from m228-62.mailgun.net (m228-62.mailgun.net [159.135.228.62]) by lindbergh.monkeyblade.net (Postfix) with UTF8SMTPS id 05290443FA for ; Thu, 21 Apr 2022 07:58:30 -0700 (PDT) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=codeagain.dev; q=dns/txt; s=smtp; t=1650553111; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Subject: To: To: From: From: Date: Sender: Sender; bh=U/Vuirm1Cqyi/duus9t1K0iWa5RpNfzC2Qa3t1+CPI0=; b=DVW7nbbfNSi6yIlzzPu30eEnoM7ChbeBZqyI9ULLsDOex7GUGCn1DooHCj5T0Dd42FlO9mOE MDGG4BC1hEOGibhmF9MJjwTb8E7z8UGZmYx1/PNSVJVryGo0giMoVXbK/efuBcKS/M5Adl/f 7TQRfWcEIbisgfV+JFnf69WZZlpOQlHmUayP7zyP8C4aKV7UMdN9cM0i5yrsE7MuKfF5H+ay ZHHqNdS1y2gQwJn5qcWOeJ6S28z66j72FMHGPkjUdpAZnbO9X2EittVk6jVN6xB88Z6NO7vf E6MpBRatz6I4faHY/3FKqITySJkWxCZRrsjtYBcs0oyI3DIA5dpV0A== X-Mailgun-Sending-Ip: 159.135.228.62 X-Mailgun-Sid: WyJkNDU4NiIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWM2ZCJd Received: from AN5Bruno (dynamic-user.170.84.57.33.mhnet.com.br [170.84.57.33]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 62617115b77b16c56e3cd5b4 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Thu, 21 Apr 2022 14:58:29 GMT Sender: codeagain@codeagain.dev Date: Thu, 21 Apr 2022 11:58:24 -0300 From: Bruno Moreira-Guedes To: Greg Kroah-Hartman , Martyn Welch , Manohar Vanga , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Bruno's Patch Watchbox Subject: [PATCH v4 1/3] staging: vme: Move vme_user to staging KConfig Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ph7ogsyaq3uoqzth" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ph7ogsyaq3uoqzth Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Currently, the VME_USER driver is in the staging tree Kconfig, unlike other VME drivers already moved to the main portions of the kernel tree. Its configuration is, however, nested into the VME_BUS config option, which might be misleading. Since the staging tree "[...] is used to hold stand-alone drivers and filesystem that are not ready to be merged into the main portion of the Linux kernel tree [...]"(from=20 https://lore.kernel.org/all/20090320172502.GA14647@kroah.com/T/), staging drivers should appear nested into the Main Menu -> Device Drivers -> Staging Drivers to make sure the user don't pick it without being fully aware of its staging status as it could be the case in Menu -> Device Drivers -> VME bridge support (the current location). With this change menuconfig users will clearly know this is not a driver in the main portion of the kernel tree and decide whether to build it or not with that clearly in mind. This change goes into the same direction of commit <4b4cdf3979c32fa3d042d150f49449c74d048553> ("STAGING: Move staging drivers back to staging-specific menu") Signed-off-by: Bruno Moreira-Guedes --- drivers/staging/Kconfig | 2 ++ drivers/vme/Kconfig | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index fc274737053d..e4dcf411030d 100644 --- a/drivers/staging/Kconfig +++ b/drivers/staging/Kconfig @@ -87,4 +87,6 @@ source "drivers/staging/fieldbus/Kconfig" source "drivers/staging/qlge/Kconfig" =20 =20 +source "drivers/staging/vme/devices/Kconfig" + endif # STAGING diff --git a/drivers/vme/Kconfig b/drivers/vme/Kconfig index 936392ca3c8c..c13dd9d2a604 100644 --- a/drivers/vme/Kconfig +++ b/drivers/vme/Kconfig @@ -15,6 +15,4 @@ source "drivers/vme/bridges/Kconfig" =20 source "drivers/vme/boards/Kconfig" =20 -source "drivers/staging/vme/devices/Kconfig" - endif # VME --=20 2.35.3 =20 --ph7ogsyaq3uoqzth Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQTUrsHCxGmQ5vyKRAZtd3tyEY2kgUCYmFxEAAKCRAZtd3tyEY2 kiYGAQC0UB23/zTeMNGsmstonBCPQn7kvL+I1+TFiNqL10revgEAg3IToC3wNxPY noWc9tzu42u/MJUsu7ElW7Dx+j3cyQs= =j63k -----END PGP SIGNATURE----- --ph7ogsyaq3uoqzth-- From nobody Mon May 11 02:55:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E95B7C433EF for ; Thu, 21 Apr 2022 14:59:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389797AbiDUPB7 (ORCPT ); Thu, 21 Apr 2022 11:01:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231559AbiDUPB6 (ORCPT ); Thu, 21 Apr 2022 11:01:58 -0400 Received: from m228-13.mailgun.net (m228-13.mailgun.net [159.135.228.13]) by lindbergh.monkeyblade.net (Postfix) with UTF8SMTPS id 7D0D5443F0 for ; Thu, 21 Apr 2022 07:59:08 -0700 (PDT) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=codeagain.dev; q=dns/txt; s=smtp; t=1650553148; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Subject: To: To: From: From: Date: Sender: Sender; bh=jxjD/BGpP33jL+RkZPJr5Lov9+ps4iGN0RwXmAZSh/4=; b=IpHmuKZ/BDsjjfWG1abuQ8M7A07yB6JQE2qtdIv3V65KzR7vAcRUcb5NBWE+4NepBHy4Xhx0 X2KwTsHtVZpctZ/aSzA7S0twTdS4+iJQ6aQiEdODPZ5aQ0RO5Xvf1feXng6c+eGhOt6y+bLL cuB7CIZCtNbhsIIkiqwrhzuYjq3GllRjaOW2eVk1sBe5CupYjjJklF2aV2Ss/aGfHvgQSP9H lAhuU9+IlFDbo1YnSKtUHkSFYgNlal74+NjKo0ICszg7RAD05BDsxhf80joiBH50LSQUR2al zFseFxXBMXUuF85v+3zNx21pGBuhf0rdiItw+wyXORLEm+H/0Baqxw== X-Mailgun-Sending-Ip: 159.135.228.13 X-Mailgun-Sid: WyJkNDU4NiIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWM2ZCJd Received: from AN5Bruno (dynamic-user.170.84.57.33.mhnet.com.br [170.84.57.33]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 6261713b2491c3e6d5b0d3a5 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Thu, 21 Apr 2022 14:59:07 GMT Sender: codeagain@codeagain.dev Date: Thu, 21 Apr 2022 11:59:02 -0300 From: Bruno Moreira-Guedes To: Greg Kroah-Hartman , Martyn Welch , Manohar Vanga , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Bruno's Patch Watchbox Subject: [PATCH v4 2/3] staging: vme: Add VME_BUS dependency to Kconfig Message-ID: <00de5644d7c2f8c8878eccf86b761e0602732089.1650544175.git.codeagain@codeagain.dev> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ohvy3oop3iuwcwi5" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ohvy3oop3iuwcwi5 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The KConfig file for VME_USER ('drivers/staging/vme/devices/Kconfig') sourced at "drivers/vme/boards/KConfig" misses a `depends on` line for VME_BUS, which is unnoticeable for menuconfig users who aren't be able to select it through this interface without setting the CONFIG_VME_BUS option because it's nested on VME_BUS menu entry. A patch to move appropriately this driver to the "Staging" submenu ([PATCH 1/3], originally sent as a single patch submitted at https://lore.kernel.org/linux-staging/3fbc5325e94b9ae0666a1f5a56a4e5372bfce= a1d.camel@codeagain.dev/T/#t), however, unveiled this missing `depends on` line, since it moved the `source` line for VME_USER's KConfig to somewhere else, allowing it to be compiled without the support for VME_BUS. While it compiles fine and seems to initialize the driver fine (tested both as module and as built- in), it seems to make no sense having VME_USER without VME_BUS. This patches addresses it by adding the VME_BUS to the `depends on` line at "drivers/staging/vme/devices/Kconfig". Signed-off-by: Bruno Moreira-Guedes --- drivers/staging/vme/devices/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme/devi= ces/Kconfig index 5651bb16b28b..e8b4461bf27f 100644 --- a/drivers/staging/vme/devices/Kconfig +++ b/drivers/staging/vme/devices/Kconfig @@ -3,7 +3,7 @@ comment "VME Device Drivers" =20 config VME_USER tristate "VME user space access driver" - depends on STAGING + depends on STAGING && VME_BUS help If you say Y here you want to be able to access a limited number of VME windows in a manner at least semi-compatible with the interface --=20 2.35.3 --ohvy3oop3iuwcwi5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQTUrsHCxGmQ5vyKRAZtd3tyEY2kgUCYmFxNgAKCRAZtd3tyEY2 krkrAP9vWAmZIIj6NA8HbLw+GMYp9wQ5BlflzgrnP/2yy93TqQD/QQNtmFw6kXlN QcKpNPAPEMDwVfroXGiVaqvlYxgj1Ac= =TL3i -----END PGP SIGNATURE----- --ohvy3oop3iuwcwi5-- From nobody Mon May 11 02:55:13 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7841C433EF for ; Thu, 21 Apr 2022 15:00:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389817AbiDUPDD (ORCPT ); Thu, 21 Apr 2022 11:03:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231559AbiDUPC3 (ORCPT ); Thu, 21 Apr 2022 11:02:29 -0400 Received: from m228-62.mailgun.net (m228-62.mailgun.net [159.135.228.62]) by lindbergh.monkeyblade.net (Postfix) with UTF8SMTPS id 51C724550D for ; Thu, 21 Apr 2022 07:59:39 -0700 (PDT) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=codeagain.dev; q=dns/txt; s=smtp; t=1650553179; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Subject: To: To: From: From: Date: Sender: Sender; bh=2FfySmyUi61V40qd9e4vY+mMpu2WKzNDDsFY/pOvwG8=; b=DSmjlPIcVdLExJVg97Q5KGee/NX7gkkXivuTasF9zAzftf4olyEnnxW7TrOiFrgVqp0JKfgZ wpPNSMV7nrse4ygpriYE40mnGTOQy+yoPY9uPYem899BZFlvKha/WHDdFVDvmG20mZYqdcFi XaQdseHuZbCNV8itLfIP8NUDAbxVK4S+eqAuFJs3dqETpzBTcv42hLJ9wq8Ip9KWQxhW/sXn uKrSP5bxC2fRnYK/0qn7a7A4F9zbgAVRFSclNLV09/LKtAkKNFhxKbOhPzys+2a5QnP9PT+D le043xMvPzhtuAyLIKNYlrc4sXfPy1e32oCAmn6Wq0JReIsF9VS8PA== X-Mailgun-Sending-Ip: 159.135.228.62 X-Mailgun-Sid: WyJkNDU4NiIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWM2ZCJd Received: from AN5Bruno (dynamic-user.170.84.57.33.mhnet.com.br [170.84.57.33]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 6261715ab77b16c56e3e69e1 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Thu, 21 Apr 2022 14:59:38 GMT Sender: codeagain@codeagain.dev Date: Thu, 21 Apr 2022 11:59:34 -0300 From: Bruno Moreira-Guedes To: Greg Kroah-Hartman , Martyn Welch , Manohar Vanga , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Bruno's Patch Watchbox Subject: [PATCH v4 3/3] staging: vme: Move 'vme/devices/' to 'vme_user/' Message-ID: <2cd7de9a426c443a5ea618682d605ecfd751d798.1650544175.git.codeagain@codeagain.dev> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ysqdnui3ra2l3lsk" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ysqdnui3ra2l3lsk Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In ("Staging: VME: move VME=20 drivers out of staging") the vme code, board and bridge drivers were moved out of the staging tree, remaining only the VME user device=20 driver. Since this driver is the only one remaining in staging, such multi-level structure confuses more than helps. The current structure is as follows: - drivers/staging/vme/ Makefile devices/ Kconfig Makefile vme_user.c vme_user.h The top-level Makefile has the only function of calling another Makefile into the devices/ subdirectory. This latter only compiles the vme_user=20 driver, since there is no other in the staging tree. This patch removes the unnecessary Makefile from the 'vme/' dir, move the contents of 'vme/devices' into the 'vme/' dir, and renames it to 'vme_user/' (the driver name), allowing a straightforward understanding of this driver's contents. Furthermore, it updates the MAINTAINERS file to properly reflect the new paths. Signed-off-by: Bruno Moreira-Guedes --- MAINTAINERS | 2 +- drivers/staging/Kconfig | 3 +-- drivers/staging/Makefile | 2 +- drivers/staging/vme/Makefile | 2 -- drivers/staging/{vme/devices =3D> vme_user}/Kconfig | 0 drivers/staging/{vme/devices =3D> vme_user}/Makefile | 0 drivers/staging/{vme/devices =3D> vme_user}/vme_user.c | 0 drivers/staging/{vme/devices =3D> vme_user}/vme_user.h | 0 8 files changed, 3 insertions(+), 6 deletions(-) delete mode 100644 drivers/staging/vme/Makefile rename drivers/staging/{vme/devices =3D> vme_user}/Kconfig (100%) rename drivers/staging/{vme/devices =3D> vme_user}/Makefile (100%) rename drivers/staging/{vme/devices =3D> vme_user}/vme_user.c (100%) rename drivers/staging/{vme/devices =3D> vme_user}/vme_user.h (100%) diff --git a/MAINTAINERS b/MAINTAINERS index 3ed62dcd144e..efc38961f792 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21010,7 +21010,7 @@ L: linux-kernel@vger.kernel.org S: Maintained T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git F: Documentation/driver-api/vme.rst -F: drivers/staging/vme/ +F: drivers/staging/vme_user/ F: drivers/vme/ F: include/linux/vme* =20 diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index e4dcf411030d..e117811ec832 100644 --- a/drivers/staging/Kconfig +++ b/drivers/staging/Kconfig @@ -86,7 +86,6 @@ source "drivers/staging/fieldbus/Kconfig" =20 source "drivers/staging/qlge/Kconfig" =20 - -source "drivers/staging/vme/devices/Kconfig" +source "drivers/staging/vme_user/Kconfig" =20 endif # STAGING diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile index 65e317922e3f..db7287de0faf 100644 --- a/drivers/staging/Makefile +++ b/drivers/staging/Makefile @@ -14,7 +14,7 @@ obj-$(CONFIG_OCTEON_ETHERNET) +=3D octeon/ obj-$(CONFIG_OCTEON_USB) +=3D octeon-usb/ obj-$(CONFIG_VT6655) +=3D vt6655/ obj-$(CONFIG_VT6656) +=3D vt6656/ -obj-$(CONFIG_VME_BUS) +=3D vme/ +obj-$(CONFIG_VME_BUS) +=3D vme_user/ obj-$(CONFIG_IIO) +=3D iio/ obj-$(CONFIG_FB_SM750) +=3D sm750fb/ obj-$(CONFIG_USB_EMXX) +=3D emxx_udc/ diff --git a/drivers/staging/vme/Makefile b/drivers/staging/vme/Makefile deleted file mode 100644 index cf2f686ccffe..000000000000 --- a/drivers/staging/vme/Makefile +++ /dev/null @@ -1,2 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -obj-y +=3D devices/ diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme_user= /Kconfig similarity index 100% rename from drivers/staging/vme/devices/Kconfig rename to drivers/staging/vme_user/Kconfig diff --git a/drivers/staging/vme/devices/Makefile b/drivers/staging/vme_use= r/Makefile similarity index 100% rename from drivers/staging/vme/devices/Makefile rename to drivers/staging/vme_user/Makefile diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme_u= ser/vme_user.c similarity index 100% rename from drivers/staging/vme/devices/vme_user.c rename to drivers/staging/vme_user/vme_user.c diff --git a/drivers/staging/vme/devices/vme_user.h b/drivers/staging/vme_u= ser/vme_user.h similarity index 100% rename from drivers/staging/vme/devices/vme_user.h rename to drivers/staging/vme_user/vme_user.h --=20 2.35.3 =20 --ysqdnui3ra2l3lsk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQTUrsHCxGmQ5vyKRAZtd3tyEY2kgUCYmFxVgAKCRAZtd3tyEY2 krlvAQDDn7lzGOuuR0sliolPWkeZtxB1Nst95cgEgmdl85zMYQD9E9OZC1NeH2NY /pqn13eWXlOs9OWZWrKcf26A/h57QwU= =JZHj -----END PGP SIGNATURE----- --ysqdnui3ra2l3lsk--