From nobody Mon May 11 00:47:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D4C9C433EF for ; Tue, 19 Apr 2022 18:28:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357168AbiDSSan (ORCPT ); Tue, 19 Apr 2022 14:30:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357351AbiDSS2C (ORCPT ); Tue, 19 Apr 2022 14:28:02 -0400 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02075D70 for ; Tue, 19 Apr 2022 11:19:48 -0700 (PDT) Received: by mail-qt1-x832.google.com with SMTP id bb21so3984422qtb.3 for ; Tue, 19 Apr 2022 11:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TsS6c/RnnW8N28Uqgbk6xNjG2rAtG4yyJqhZPCFyu68=; b=a0X4omet7ubwepI7Sjq1GKWazDAR1sokGbqsF2O9SYrR/5aybF/+dqcutAJ4hSLFDY bQ5EY2/ufswhxA8QIWGeRgngEYDAJuXeMOk2K09O7GN5G9sfoceLBhIac6OEnUv0xIbR jSqTQ8mdx2ehVp7LMxd9ir62r9npohwyda3GsBbiEjQ0icSm/UMTTMNLCDRos5YrCUWn 9HcgWTPZ5l9e2dEAtLcB7fygjCtb5NVtnk+u44cwVTXiEqmB982JAZ0FxwPU4zuUMvFc nBBFMf8yrpBe/9pApKfrmZcMuKY0rPQ8TGDEL95ptt7rP2Mk7ZP0Hk/gtNveCte/P6C3 a7oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TsS6c/RnnW8N28Uqgbk6xNjG2rAtG4yyJqhZPCFyu68=; b=clryae5BZawXCxmLXaz/zRrGCxccPEht8epMKqaBbgPviW1yRMOiFLR0MSJgXl3jb7 La7Z1iysJLfJNj14bSoG5bCNPp+H+KqBHAn6Xz80R6sUOxmNWLiIzymROZyxgYkvDaVi 5U2qez0cSiW6tzP3hBAoYBGR5sO32AKrGzu4ZNOZU5db0fBpwyoLDYLrnANAZKpVnH10 W8Re+p6hP6FYF1dm+a8gQ6TO+ygmeHVfJeMLLXuFEchgBzZ7M5nlbfm0zghbFEuqIDJU eZlyFtyjBeo38NoQcoxpuApK4p5jc8PmZ7Crvqc+2EcQ9JV70hCcSAOeQZ6GPbRHhoO9 68aA== X-Gm-Message-State: AOAM532bjtEmSFasIay8wOSKCepOcmU7ZT46lrF+WECscWTUPwicx468 PyENXtqJEXC+giKdY2u0iTQ= X-Google-Smtp-Source: ABdhPJxrlyYuX/eLyo4aukz0bVgPyF+C57SnMVxkrDap85pqIY+pyePm5XZh0i/1LddBILjTx5eyLw== X-Received: by 2002:a05:622a:1792:b0:2f3:3a82:b15e with SMTP id s18-20020a05622a179200b002f33a82b15emr2286518qtk.246.1650392387084; Tue, 19 Apr 2022 11:19:47 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id e126-20020a376984000000b0069c86b28524sm373334qkc.19.2022.04.19.11.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 11:19:45 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com, Pavel Skripkin Subject: [PATCH v3 1/7] staging: r8188eu: remove unused member free_bss_buf Date: Tue, 19 Apr 2022 14:19:32 -0400 Message-Id: <3c5a510938ac395a13bb09c0de1868cce8ca3dd8.1650392020.git.jhpark1013@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The free_bss_buf member of pmlmepriv is unused. Remove all related lines. Suggested-by: Pavel Skripkin Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/include/rtw_mlme.h | 1 - drivers/staging/r8188eu/core/rtw_mlme.c | 21 +-------------------- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/staging/r8188eu/include/rtw_mlme.h b/drivers/staging/r= 8188eu/include/rtw_mlme.h index 1dc1fbf049af..0f03ac43079c 100644 --- a/drivers/staging/r8188eu/include/rtw_mlme.h +++ b/drivers/staging/r8188eu/include/rtw_mlme.h @@ -319,7 +319,6 @@ struct mlme_priv { struct list_head *pscanned; struct __queue free_bss_pool; struct __queue scanned_queue; - u8 *free_bss_buf; u8 key_mask; /* use to restore wep key after hal_init */ u32 num_of_scanned; =20 diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 3e9882f89f76..8af11626a3e7 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -33,8 +33,7 @@ u8 rtw_to_roaming(struct adapter *adapter) static int _rtw_init_mlme_priv(struct adapter *padapter) { int i; - u8 *pbuf; - struct wlan_network *pnetwork; + struct wlan_network *pnetwork =3D NULL; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; int res =3D _SUCCESS; =20 @@ -55,16 +54,6 @@ static int _rtw_init_mlme_priv(struct adapter *padapter) =20 memset(&pmlmepriv->assoc_ssid, 0, sizeof(struct ndis_802_11_ssid)); =20 - pbuf =3D vzalloc(MAX_BSS_CNT * (sizeof(struct wlan_network))); - - if (!pbuf) { - res =3D _FAIL; - goto exit; - } - pmlmepriv->free_bss_buf =3D pbuf; - - pnetwork =3D (struct wlan_network *)pbuf; - for (i =3D 0; i < MAX_BSS_CNT; i++) { INIT_LIST_HEAD(&pnetwork->list); =20 @@ -79,8 +68,6 @@ static int _rtw_init_mlme_priv(struct adapter *padapter) =20 rtw_init_mlme_timer(padapter); =20 -exit: - return res; } =20 @@ -109,13 +96,7 @@ void rtw_free_mlme_priv_ie_data(struct mlme_priv *pmlme= priv) =20 void _rtw_free_mlme_priv(struct mlme_priv *pmlmepriv) { - rtw_free_mlme_priv_ie_data(pmlmepriv); - - if (pmlmepriv) { - vfree(pmlmepriv->free_bss_buf); - } - } =20 struct wlan_network *_rtw_alloc_network(struct mlme_priv *pmlmepriv)/* _qu= eue *free_queue) */ --=20 2.25.1 From nobody Mon May 11 00:47:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB10C433F5 for ; Tue, 19 Apr 2022 18:28:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357320AbiDSSb2 (ORCPT ); Tue, 19 Apr 2022 14:31:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357355AbiDSS2C (ORCPT ); Tue, 19 Apr 2022 14:28:02 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6380F2A for ; Tue, 19 Apr 2022 11:19:49 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id f22so3695914qtp.13 for ; Tue, 19 Apr 2022 11:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XSg9NHRu+GinF4s8/icuB36rUFEij5QIkSvezyRfTkQ=; b=kyt7keqdox5sCDgMehjinLNgkpUGGZ8Db0wu4OjgV5ZdSGNuAwqfsgFqJlHysFdfi+ HLT23tQu7IZYDF/kPQDUNW9vNa5o9/LQkvwusOavQdf7zG/4wmmrJJQtN0wZ6eSPl7HN AaRt/09ZvYj09MVEZOTK4D/Zh8HsMz74RH1OYwC1LlsMyQdKYLFIY7Ynxjk83FX3MjwF RjHqcm9UKv2/n5b/+ZweuOE+d+nnocJub6eXLhPXyfTlMI/Ldo0LY4N/CCpiRfYvUW9S cHO2j7JkUbax8D1Ux9i1GdfzK9laHU/STcGCt8fJbHv8OC+qP/7C11QuhYnPcptcyC9Y aVdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XSg9NHRu+GinF4s8/icuB36rUFEij5QIkSvezyRfTkQ=; b=qEJbK+u3582iiBZlULTz2RMMk5Ntx8XyiEjSkk7rZrHOgmRbcfj9hMAgCMK+bXEu63 DM0/xpFHrbWOupxmfI6hgfJ0g6SIlrs+cEH0mxDbXN4/CxoW0q1rpvgHDg8mVKk7d9F5 89S9ZbQviQ7vV+PV10slS4fvZGdJzkXnyj9pu/IbL3kHYnBkZkA4XiSq8E7L71mMzgEB 9A+iP91qJ+hFKmZjXjjYRsdYjX/0caeGV1Aup3+HlWILfgOjlTMPcjnFvqpqgXG6yDAN uyb5Xpdzkl5OuH/ly+U/twTO+vmiPB+I1MEjZZBuMlKc1Nq9fUuq67b3h/DrhLN/lk4C QTLw== X-Gm-Message-State: AOAM532NoXggZiyHLbiov9w6XuUt1E2f22DpVjYkPzE4XhRcvEup69wo e7SoPJuNs9uw6h0DIQ/jXHrohHh5tpc1Anz8 X-Google-Smtp-Source: ABdhPJznnjG2Alx/CXED04SbSCzRXNOHcagsZnIEhYgl2TeoeWGFAejCFvsjZiVGqKG38ckdNL3QNA== X-Received: by 2002:ac8:5f8d:0:b0:2f3:3f9a:d5bb with SMTP id j13-20020ac85f8d000000b002f33f9ad5bbmr62282qta.314.1650392388318; Tue, 19 Apr 2022 11:19:48 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id e126-20020a376984000000b0069c86b28524sm373334qkc.19.2022.04.19.11.19.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 11:19:47 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH v3 2/7] staging: r8188eu: remove spaces before tabs Date: Tue, 19 Apr 2022 14:19:33 -0400 Message-Id: <5e16b9df1b5ce3a754a8f71c35cf4d55777e19cf.1650392020.git.jhpark1013@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Delete spaces before tabs in the comments. Issue found with checkpatch. WARNING: please, no space before tabs Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 8af11626a3e7..72963ed7b665 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -555,8 +555,8 @@ static void rtw_add_network(struct adapter *adapter, =20 /* select the desired network based on the capability of the (i)bss. */ /* check items: (1) security */ -/* (2) network_type */ -/* (3) WMM */ +/* (2) network_type */ +/* (3) WMM */ /* (4) HT */ /* (5) others */ static bool rtw_is_desired_network(struct adapter *adapter, struct wlan_ne= twork *pnetwork) @@ -891,9 +891,9 @@ static struct sta_info *rtw_joinbss_update_stainfo(stru= ct adapter *padapter, str memset((u8 *)&psta->dot11txpn, 0, sizeof(union pn48)); memset((u8 *)&psta->dot11rxpn, 0, sizeof(union pn48)); } - /* Commented by Albert 2012/07/21 */ - /* When doing the WPS, the wps_ie_len won't equal to 0 */ - /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitt= ed. */ + /* Commented by Albert 2012/07/21 */ + /* When doing the WPS, the wps_ie_len won't equal to 0 */ + /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitte= d. */ if (padapter->securitypriv.wps_ie_len !=3D 0) { psta->ieee8021x_blocked =3D true; padapter->securitypriv.wps_ie_len =3D 0; @@ -1616,8 +1616,8 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ /* */ /* Search by BSSID, */ /* Return Value: */ -/* -1 :if there is no pre-auth key in the table */ -/* >=3D 0 :if there is pre-auth key, and return the entry id */ +/* -1 :if there is no pre-auth key in the table */ +/* >=3D 0 :if there is pre-auth key, and return the entry id */ /* */ /* */ =20 --=20 2.25.1 From nobody Mon May 11 00:47:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B60B0C433F5 for ; Tue, 19 Apr 2022 18:28:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357197AbiDSSbb (ORCPT ); Tue, 19 Apr 2022 14:31:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357364AbiDSS2D (ORCPT ); Tue, 19 Apr 2022 14:28:03 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6CE6101C for ; Tue, 19 Apr 2022 11:19:50 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id x24so4477498qtq.11 for ; Tue, 19 Apr 2022 11:19:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zAEWfiSxwr2Il19zyqW+S8ONLOaXBz+c5Ud0bIaAXWg=; b=IxLrn3O0wpui7HsyiCQ+VSsXdeY4MZ3MV2nsNb6ykBxKxnQTRond47N06Nn/FFNwsD nMIA1MmhCc01FPfh1wQLL50iq/cDc9lGGGAgd/xCFqsw33CCu1LR3AVaO5aLrYK9e8EZ IQ0hQ/DqZ1m8+bIN4qDI8h3ohDnQiZU09EURm+m8TrwJqN2Cog19Jrm6ovFmOWKmmiEQ o77/l8blGpVO1bbfxN8nkqj4S9+EM1E4D6E/rjN5CcXMcBJ1UMvTEFw12fW4Im2+o42U 0KQPBDPaHp64UvPO7gkR34+aJY92TOeNMR6/uC5/rMjs2lRfZELEA4WYS3yRUe7l1Kub ajwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zAEWfiSxwr2Il19zyqW+S8ONLOaXBz+c5Ud0bIaAXWg=; b=uKjYoE+htMLyMKhJjxn0PCxxMzpLfNjC0JuX2+sySUrViEegOWnJ8A9bqKAoYztVnu Ck6OV4P8jB5JcNu/iYZxHh9mtNwp0aXSxeKB0gxmBw/aNTtM6kjabKCjTvwBJGESAKZj nTEaegShtCWyefuqAkjEyVnYVYs2dCUrh/uTuifXTSZtLLxJhI84jKyfBfQTYMdM+HxL p1OPloZ2NuCz0WMkkhzOpYwk/T3n2mSKcJcIq98mWNBf5XxwIipuVB5kria64Vg3XYDD J9Y8rHrCYsvkmQC2VrfbADqG+nVKTatkylmnloGHtGXxQl8DKgSAUc8xwaagap7Faj3j Dvyw== X-Gm-Message-State: AOAM531oRS45qfzhKVaab0MbZM3WgC0KJ+hWO0tOGlX8sHDAR6LIrUdu vylCNnBCSms1oJcOd6KHXM4= X-Google-Smtp-Source: ABdhPJyCQuDGwrjDv5Mynk98pWFI0CjX4ZZdb9g3WEcuWhKRC7H6R2h+Y3gBstV0smAuwS3n9aGr5w== X-Received: by 2002:ac8:7e89:0:b0:2f1:e3b4:d596 with SMTP id w9-20020ac87e89000000b002f1e3b4d596mr11701645qtj.432.1650392389685; Tue, 19 Apr 2022 11:19:49 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id e126-20020a376984000000b0069c86b28524sm373334qkc.19.2022.04.19.11.19.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 11:19:49 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com, Alison Schofield Subject: [PATCH v3 3/7] staging: r8188eu: remove 'added by' author comments Date: Tue, 19 Apr 2022 14:19:34 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Author comments "Added by Albert" and "Added by Annie" are sprinkled through the file. These comments are not useful and can be removed. Suggested-by: Alison Schofield Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 72963ed7b665..47f528c14b25 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -891,7 +891,6 @@ static struct sta_info *rtw_joinbss_update_stainfo(stru= ct adapter *padapter, str memset((u8 *)&psta->dot11txpn, 0, sizeof(union pn48)); memset((u8 *)&psta->dot11rxpn, 0, sizeof(union pn48)); } - /* Commented by Albert 2012/07/21 */ /* When doing the WPS, the wps_ie_len won't equal to 0 */ /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitte= d. */ if (padapter->securitypriv.wps_ie_len !=3D 0) { @@ -1610,9 +1609,6 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ return ielength; } =20 -/* */ -/* Ported from 8185: IsInPreAuthKeyList(). (Renamed from SecIsInPreAuthKe= yList(), 2006-10-13.) */ -/* Added by Annie, 2006-05-07. */ /* */ /* Search by BSSID, */ /* Return Value: */ --=20 2.25.1 From nobody Mon May 11 00:47:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27328C433F5 for ; Tue, 19 Apr 2022 18:28:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357298AbiDSSbM (ORCPT ); Tue, 19 Apr 2022 14:31:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357370AbiDSS2D (ORCPT ); Tue, 19 Apr 2022 14:28:03 -0400 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EB32636A for ; Tue, 19 Apr 2022 11:19:52 -0700 (PDT) Received: by mail-qk1-x736.google.com with SMTP id d19so6324657qko.3 for ; Tue, 19 Apr 2022 11:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eTY41j92DVLNXeSt4o0nuA9rJQeUxDOxu+njnckXIDQ=; b=LTl9kT3xpYL6VGEy2O5G2D/KacFzBLapBCcpa8SVQcm/vTgM1g2taCae9ti31ZnUnP jQ3wMxvJsuD3S5QQDIAo61l28GRuHnj+rQYPOxxH59K9KxAhQ6DOeh+H2v7m9F1WBJrU 1cE6HGebZfiVlUTpQtUvgzZAhJPIjP70k53nd6Hh8mWk0ZTJJ4P+q1CcETzFGx+5Mxdr UM8BMo3myP85dULJVvG7tmEtEPGh42u/6Q6NuWuCAYq5gnXuauYPwWQFBrAf29ZR/ZAd nrEodCYgzqC5VptflF042txhrU25aUwKKluUY6nmnjT7yF5ZbL84tiYCyYDPbiaX/7oo GVEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eTY41j92DVLNXeSt4o0nuA9rJQeUxDOxu+njnckXIDQ=; b=C3wRJ1x79wsRg4aU9DAlanoC13UxkZ3R1nrHFF2T/6UrizN+JbCJX1FrPhibjjy6pk Hfj+M9EpGZ5XoPwucxBmiJ7V4PBCdkWGpyZ4/9BxWeHWkPrUQ2xoIzcvMSCMw2X7RQz3 e8WjG9Bp1oSMpiAL/9Vj3uAfs1/haew3GMGTGl3SUqWOSC8GSaSOCXMJ9N3Lf57Ismse cdV5aCEKR154NDh0KBG98WDA3OM7cOcMTAlkm8OcLTMoI2bw/o1zyFicsE4anyJigSic UdBj8Bu2D5gaI7fh96mZXPxgbFK6kxI1IZ5RwyjMaD2DKLgaaJDfFOhDQ8ATFkkRJDHd yYGA== X-Gm-Message-State: AOAM5323VIZTlmVwXzF/wdsoyM7e+h38nbJcGJFpIsr6MxD/PnQDvMIQ BGa9hJtPVuewFDQwJA4tk/s= X-Google-Smtp-Source: ABdhPJy7FqTgL+ZMMB+LutLXJ2/U/G82goC/xh9N3tuArQF8jIEzE5CndILEgQbLcUQNdwFSzoHjlA== X-Received: by 2002:a37:8ac1:0:b0:69b:ef34:2655 with SMTP id m184-20020a378ac1000000b0069bef342655mr10460110qkd.336.1650392391091; Tue, 19 Apr 2022 11:19:51 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id e126-20020a376984000000b0069c86b28524sm373334qkc.19.2022.04.19.11.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 11:19:50 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH v3 4/7] staging: r8188eu: place constants on the right side of tests Date: Tue, 19 Apr 2022 14:19:35 -0400 Message-Id: <31d2a118c5d797a2df7428aa701afe46cbbc1d19.1650392020.git.jhpark1013@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" To comply with the linux coding style, place constants on the right side of the test in comparisons. Issue found with checkpatch. WARNING: Comparisons should place the constant on the right side of the test. Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 47f528c14b25..adaf0f813a97 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -703,7 +703,7 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) set_fwstate(pmlmepriv, _FW_UNDER_LINKING); pmlmepriv->to_join =3D false; s_ret =3D rtw_select_and_join_from_scanned_queue(pmlmepriv); - if (_SUCCESS =3D=3D s_ret) { + if (s_ret =3D=3D _SUCCESS) { _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else if (s_ret =3D=3D 2) { /* there is no need to wait for join */ _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); @@ -711,7 +711,8 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) } else { if (rtw_to_roaming(adapter) !=3D 0) { if (--pmlmepriv->to_roaming =3D=3D 0 || - _SUCCESS !=3D rtw_sitesurvey_cmd(adapter, &pmlmepriv->assoc_ssid,= 1, NULL, 0)) { + rtw_sitesurvey_cmd(adapter, &pmlmepriv->assoc_ssid, + 1, NULL, 0) !=3D _SUCCESS) { rtw_set_roaming(adapter, 0); rtw_free_assoc_resources(adapter, 1); rtw_indicate_disconnect(adapter); @@ -1952,7 +1953,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr issued =3D (phtpriv->agg_enable_bitmap >> priority) & 0x1; issued |=3D (phtpriv->candidate_tid_bitmap >> priority) & 0x1; =20 - if (0 =3D=3D issued) { + if (issued =3D=3D 0) { psta->htpriv.candidate_tid_bitmap |=3D BIT((u8)priority); rtw_addbareq_cmd(padapter, (u8)priority, pattrib->ra); } @@ -1979,19 +1980,19 @@ void _rtw_roaming(struct adapter *padapter, struct = wlan_network *tgt_network) else pnetwork =3D &pmlmepriv->cur_network; =20 - if (0 < rtw_to_roaming(padapter)) { + if (rtw_to_roaming(padapter) > 0) { memcpy(&pmlmepriv->assoc_ssid, &pnetwork->network.Ssid, sizeof(struct nd= is_802_11_ssid)); =20 pmlmepriv->assoc_by_bssid =3D false; =20 while (1) { do_join_r =3D rtw_do_join(padapter); - if (_SUCCESS =3D=3D do_join_r) { + if (do_join_r =3D=3D _SUCCESS) { break; } else { pmlmepriv->to_roaming--; =20 - if (0 < pmlmepriv->to_roaming) { + if (pmlmepriv->to_roaming > 0) { continue; } else { rtw_indicate_disconnect(padapter); --=20 2.25.1 From nobody Mon May 11 00:47:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A80D9C433F5 for ; Tue, 19 Apr 2022 18:28:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357307AbiDSSbU (ORCPT ); Tue, 19 Apr 2022 14:31:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357373AbiDSS2D (ORCPT ); Tue, 19 Apr 2022 14:28:03 -0400 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51C53DF5F for ; Tue, 19 Apr 2022 11:19:53 -0700 (PDT) Received: by mail-qv1-xf34.google.com with SMTP id dw17so2263162qvb.9 for ; Tue, 19 Apr 2022 11:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M1/ie4QuWSXXgB+xp4DMhBE7HLrajOsmWcuUCsf6X4I=; b=hdaKTXpzMgU7K+djFEqGEew0POFWTwy/yslxAuKNMD0SaPrYTGwDse6J9unjK/yYxf AzS+9BkBWpKwFPb4/aIKs8q7UvilGIyCwj2WD+n/jWJxeWhJalWfhaWW8hArwixxnnJ0 eVRAcApf3qBVWKS8MaMqxYL84fMNZRMfBH8H2jGJ1y2iTyFmAJjQv23fMYDdx8sMj6Pt cZxwt/kcmcvqIsDghKsSDTUCoNUhm3zWRKjYGjbamswqYxwjTVzhxKJ8Qa4HwrBM0B2D xNWNc0zxv6VNqUMMC8nTUg5HY0jX0rR/V0nFtUlxsKed8aawq3f4S0OYyBpnWS93/WZv FeSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M1/ie4QuWSXXgB+xp4DMhBE7HLrajOsmWcuUCsf6X4I=; b=4baGQLMQ/Mq/a364cJpLJ2ROaP3uCRWWXgwJHu1DwiWbNCdmz8+vRrk1o/kPDsnTHT bLpipjvqpZlecWJiaX/KssJlz3gIL43YWj8gFUrrrQvI826wlZOcbX18zQBKp+VoNdtb 2ViDEOk5mX1PWf6wZRFWZs1CkVvbo4D7PvKD+UklVbVAgOfgmBmkHvECVwUDPtBafgWn WFyTjgEE4zJZSBWFLp1udVr1a4pqQAqHyiU3zzlUh4lKQtKHLFzeAZC79iiYltiN650g sQJmNDRvmMOupIo0RX31hYPcUHvBTm+Py3gwXAv28gZcPGqugQJRrlp12ALiKrC1iuQe /hiw== X-Gm-Message-State: AOAM532z2lbuGv6JtWjGU5GB/ddk9fnV0HhsNm3pc84kCJwOJXVKl6CP 0/vwrYqQ2R0kQ3ZhT5DHHRZlIv2Q80OP5C6a X-Google-Smtp-Source: ABdhPJwJtueRCrxqkAyYZLYLe58f+CxKoMRLxIKN75UObTXcycf/iTcnWI6/CrsTLzO4xhztd5vGNQ== X-Received: by 2002:a05:6214:262c:b0:446:3464:57cd with SMTP id gv12-20020a056214262c00b00446346457cdmr12636468qvb.89.1650392392426; Tue, 19 Apr 2022 11:19:52 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id e126-20020a376984000000b0069c86b28524sm373334qkc.19.2022.04.19.11.19.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 11:19:51 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH v3 5/7] staging: r8188eu: replace spaces with tabs Date: Tue, 19 Apr 2022 14:19:36 -0400 Message-Id: <48b324c1be1c26f34d793a0b5cf7933b41882a26.1650392020.git.jhpark1013@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use tabs instead of spaces. Issue found with checkpatch. WARNING: suspect code indent for conditional statements Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index adaf0f813a97..173754c127e3 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -704,7 +704,7 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) pmlmepriv->to_join =3D false; s_ret =3D rtw_select_and_join_from_scanned_queue(pmlmepriv); if (s_ret =3D=3D _SUCCESS) { - _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); + _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else if (s_ret =3D=3D 2) { /* there is no need to wait for join */ _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); rtw_indicate_connect(adapter); --=20 2.25.1 From nobody Mon May 11 00:47:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0DF1C4332F for ; Tue, 19 Apr 2022 18:28:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357261AbiDSSax (ORCPT ); Tue, 19 Apr 2022 14:30:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357376AbiDSS2D (ORCPT ); Tue, 19 Apr 2022 14:28:03 -0400 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55EB913F32 for ; Tue, 19 Apr 2022 11:19:55 -0700 (PDT) Received: by mail-qv1-xf2b.google.com with SMTP id d9so13825489qvm.4 for ; Tue, 19 Apr 2022 11:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fhC3X2SyiyAl+npbfkVlNLSTyoSpgwtiZmqJs5lxBc4=; b=OPKv+zXzIulJ/bChAz/N/BvFQIw/GcXNMZhcMI98zHKajTluQf7i4EbuvdfwwS2jGY /buH9ZVrWciy6p8exI4Uk6zeeDkzxqbd2gpMbUMJMVIZLogmAKVkumWSjBO04KFXhSWp 0i0+gqMZKsS7E+F657CgSYirCWN32nFnRePZKrEm6eZEkr3MWKRLnZ3YH1Bd/JxSksvm mHFl+3PrAKqLXd996WL9Ol/hSDiJfX/BWXJ0VgB/RMh9MBUe18X/1JG6IT5dlSzJAeyZ nats29XlJRMqJBfBO+22dPnPArkE3TR09ZPC4WgEgA2tksfuDiNDsRCIz7Iuze/0Jf/M I55A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fhC3X2SyiyAl+npbfkVlNLSTyoSpgwtiZmqJs5lxBc4=; b=zsj6JRVS0ZFAaC/8d3AXO0CMV7H6amcs8exJIPIOymzd01unWQad3bqGAgJ9aDJIDf WeTP8ZJt48LhfqO5vXEToTstgWZZwf57r04zmSGCDQJ9KBeA80jm135Kdolaru4Sw3qV XUAERdxL3hkhSc+hhxPTBeWTXtGFnkZhdK4REOG8HhhThBZCoKLblfBVSDwEaa9zlH2W 1V9xmiLhIEqmddtqb0tgiF+NCcnAI4gKXHJ7IlgUlCMzRT0sKcpRIPw+2Ccq5nw6P1tg H01ZO5y3p5vkbkkRBeOrFSApTAYMxcQkmfHatVFD5tUYWElB6r0Kaj5bN1zzO06yd9HM YxGw== X-Gm-Message-State: AOAM531xJ96xB3ccYnNSSmd3H0Lv90AAvIEHW9TdvCvf34MgRO+RhZTD MizoQ0te9JOUKbgrPn58Qy0= X-Google-Smtp-Source: ABdhPJwL1/XGUDSeSF2YDZwjDMQcm7h/PtbdT22eCAuEiEDQTwr9gswRBWcSUzRdoEyWVWt7j97EsQ== X-Received: by 2002:a05:6214:18c4:b0:444:39f6:b328 with SMTP id cy4-20020a05621418c400b0044439f6b328mr12820589qvb.51.1650392394335; Tue, 19 Apr 2022 11:19:54 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id e126-20020a376984000000b0069c86b28524sm373334qkc.19.2022.04.19.11.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 11:19:53 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH v3 6/7] staging: r8188eu: correct typo in comments Date: Tue, 19 Apr 2022 14:19:37 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Correct misspellings in the comments. Issue found with checkpatch. Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 173754c127e3..5ada336ac723 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -174,7 +174,7 @@ void _rtw_free_network_nolock(struct mlme_priv *pmlmepr= iv, struct wlan_network * /* return the wlan_network with the matching addr =20 - Shall be calle under atomic context... to avoid possible racing condition= ... + Shall be called under atomic context... to avoid possible racing conditio= n... */ struct wlan_network *_rtw_find_network(struct __queue *scanned_queue, u8 *= addr) { @@ -310,7 +310,7 @@ void rtw_free_network_queue(struct adapter *dev, u8 isf= reeall) /* return the wlan_network with the matching addr =20 - Shall be calle under atomic context... to avoid possible racing condition= ... + Shall be called under atomic context... to avoid possible racing conditio= n... */ struct wlan_network *rtw_find_network(struct __queue *scanned_queue, u8 *a= ddr) { @@ -893,7 +893,7 @@ static struct sta_info *rtw_joinbss_update_stainfo(stru= ct adapter *padapter, str memset((u8 *)&psta->dot11rxpn, 0, sizeof(union pn48)); } /* When doing the WPS, the wps_ie_len won't equal to 0 */ - /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitte= d. */ + /* And the Wi-Fi driver shouldn't allow the data packet to be transmitte= d. */ if (padapter->securitypriv.wps_ie_len !=3D 0) { psta->ieee8021x_blocked =3D true; padapter->securitypriv.wps_ie_len =3D 0; @@ -1287,7 +1287,7 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) } =20 /* -* _rtw_join_timeout_handler - Timeout/faliure handler for CMD JoinBss +* _rtw_join_timeout_handler - Timeout/failure handler for CMD JoinBss * @adapter: pointer to struct adapter structure */ void _rtw_join_timeout_handler (struct adapter *adapter) @@ -1322,7 +1322,7 @@ void _rtw_join_timeout_handler (struct adapter *adapt= er) } =20 /* -* rtw_scan_timeout_handler - Timeout/Faliure handler for CMD SiteSurvey +* rtw_scan_timeout_handler - Timeout/Failure handler for CMD SiteSurvey * @adapter: pointer to struct adapter structure */ void rtw_scan_timeout_handler (struct adapter *adapter) --=20 2.25.1 From nobody Mon May 11 00:47:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7763EC433EF for ; Tue, 19 Apr 2022 18:28:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356580AbiDSSa5 (ORCPT ); Tue, 19 Apr 2022 14:30:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357380AbiDSS2E (ORCPT ); Tue, 19 Apr 2022 14:28:04 -0400 Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7443B58 for ; Tue, 19 Apr 2022 11:19:56 -0700 (PDT) Received: by mail-qv1-xf36.google.com with SMTP id x20so13766968qvl.10 for ; Tue, 19 Apr 2022 11:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tyQuLgB/CsR0aLvsOUcIg9iM46ZFr1ZTjXluFgbi8lw=; b=B20wYfz4Hb1BxrL/fu4aESxQ/t/xR+m+o443keOeSDnjV4EYZheiiNJhYlrKqhzE/w MvOWfD9K/i6kV7XDjTOT+BDRT9FTmdkB8a/fiYAky8GYsMX7BOMr4NAYJSyNV3EDwPg/ fveSD6KO/2zu7LGV4GZ6+5fNYMb/co3/HUn4xN7ng8vai1aNRx24VJcwcYzrkfzheG30 1/dq9xMW3haQNinqSuGFm3+RlkSckt6Cgbk9rPUssKpnzgP73OEcFggPpQ7vo/OmYATc lXjgc284WdMf72s9QxrY/OQvy1L3DAskNf/2YEgLsQuA7QFapsbjkbBmBXPYCZdJ9cts 2kag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tyQuLgB/CsR0aLvsOUcIg9iM46ZFr1ZTjXluFgbi8lw=; b=pzDqA0TpyfM2PgiaI0I3H4YJlfRo++qT4SBNFrLV0iYdT7dSEKGHYEUonExfKylhXm G1gKesXs51e4+XPRkLXyU1F+TLKZlIHf7WgTrI6sUgOyewWD5vRi6IiVa6QDp+VMWMO3 +3ToaBoYWWjr20AIZtoK1qahlL+FY+dULxOI7DuIH7HpxTK9liES3kB18kC/ekdcH3kf Y8Spm5Mt6zpcjNeA0kdgq8IyelRfqrRImTFSbvQo0jSSXXLnqFfPEEiga3xeY9VV5+ik w+pyYahS2Oxh5/JQjnYnScca0pamr945Xfr2SKK498fmAHtzksfJ+NtVrIOmGnwuQiG3 XJRg== X-Gm-Message-State: AOAM533WSHgauD/zwfdTUB9lEh8ZhR/9Jd2njj0qdAuANQT8rtRj/z3s GVGHgXqMistqn7x5Djb9lVc= X-Google-Smtp-Source: ABdhPJxGveIMiH2/+BpxOK75542t0CmkWxPvzYE3z6vxlXQaMUeiB4aOiBvi3H8WlyWRA3nMyPSdMA== X-Received: by 2002:a05:6214:29eb:b0:446:5742:1748 with SMTP id jv11-20020a05621429eb00b0044657421748mr8864930qvb.24.1650392396067; Tue, 19 Apr 2022 11:19:56 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id e126-20020a376984000000b0069c86b28524sm373334qkc.19.2022.04.19.11.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 11:19:55 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com, Pavel Skripkin Subject: [PATCH v3 7/7] staging: r8188eu: remove unused else condition Date: Tue, 19 Apr 2022 14:19:38 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" s_ret cannot return '2' so this else condition is unused. Remove this unnecessary else statement. Suggested-by: Pavel Skripkin Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 5ada336ac723..e60e1903950f 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -705,9 +705,6 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) s_ret =3D rtw_select_and_join_from_scanned_queue(pmlmepriv); if (s_ret =3D=3D _SUCCESS) { _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); - } else if (s_ret =3D=3D 2) { /* there is no need to wait for join */ - _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); - rtw_indicate_connect(adapter); } else { if (rtw_to_roaming(adapter) !=3D 0) { if (--pmlmepriv->to_roaming =3D=3D 0 || --=20 2.25.1