From nobody Mon May 11 04:09:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80090C433EF for ; Fri, 15 Apr 2022 02:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349014AbiDOCva (ORCPT ); Thu, 14 Apr 2022 22:51:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349112AbiDOCvQ (ORCPT ); Thu, 14 Apr 2022 22:51:16 -0400 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66F2AB3697 for ; Thu, 14 Apr 2022 19:48:45 -0700 (PDT) Received: by mail-qt1-x833.google.com with SMTP id t2so3327068qta.5 for ; Thu, 14 Apr 2022 19:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fqkAa0xDrLSxFAeOhD4dr36p7/F0dV1HG8oV8HDPNB8=; b=WlMDhbSX4y+lb1Nsiiuf/Cuc2eHIAw+CSaCHR0Ri0OAHahn6QuwAhOjhaDnASaEIIw 6Jpx7fOUliznPDroTk0iFfV5hbfPacaNZQHslC/57B1jP+yYfhv1/AvFp4d76PpPRgHQ D/O3ytuYuLIPFvuEN83kpzHh6ZCJ7Qg+1AOOwokcpEpY3+Bm7HTSyzkv4nu8dfNwIZ2S tp8V/F9bAU8CIkw3cXt5Jw8aEhbHZgNdBRGfgMyshZTVRS+axX72ZJ3nPnS0u8vzisxa rVQ5c7zhLZezX50SJy3xu6J3hfpOBO+qNuxip5pfM9rsKDgmOk+iJipQOrupJxtUXmBU 0B1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fqkAa0xDrLSxFAeOhD4dr36p7/F0dV1HG8oV8HDPNB8=; b=JMPT/r40/i3lieWfRgFdYjMXeO+HX9pv2IMelNu7JcIVHGPoCwTxSD/Q7aTHKFw9Fe qhLJaBrPbOn3jkMjExppJUOcbPp/Fk0UH4lB3l1w2lgo+4yJJgD20eLa5UNsWb3YFBNi syuEhQhmv3/ALfukUNij0q2Q2RZyln6soKUlGnYY0RUzsmsy7j/vc+DaGo+OLxMco7Ak /f9nWd9C/aixQMu+dBRb3TddO3nT4V2bcoh0lEprlLBmgajwwbPIV3sxq3z+QRWOeOMO RkdlRn18FH9yzupg+qWhm60oqw6wYcWJAm2Pmsf703KelGqaqbBBAu9GEFZt/ge2wbxW PpyA== X-Gm-Message-State: AOAM530jW5JHg2DmyRwuy3Cq0qEW96OjxSE21esy1g5gRENmH0XhQuBi IZ1GX4Ywut3ddiRX3QaBAbEtv2RWnIPYHvN7 X-Google-Smtp-Source: ABdhPJwqZmj0qfgUb0PIyWQKSkAGo3aGIiwqrMOqrEBaiKBaOHLJA3RT1XS74B6DOSUOSsx4eSKqyA== X-Received: by 2002:ac8:464e:0:b0:2f1:e40e:6e80 with SMTP id f14-20020ac8464e000000b002f1e40e6e80mr3452448qto.587.1649990924575; Thu, 14 Apr 2022 19:48:44 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.lan ([2607:fb90:1b7a:2349:50b1:5db4:a2d5:7054]) by smtp.gmail.com with ESMTPSA id p7-20020a05620a22a700b0069c37e2c473sm1800085qkh.94.2022.04.14.19.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 19:48:43 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com, Pavel Skripkin Subject: [PATCH v2 1/6] staging: r8188eu: remove unused member free_bss_buf Date: Thu, 14 Apr 2022 22:48:32 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The free_bss_buf member of pmlmepriv is unused. Remove all related lines. Suggested-by: Pavel Skripkin Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/include/rtw_mlme.h | 1 - drivers/staging/r8188eu/core/rtw_mlme.c | 7 ------- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/r8188eu/include/rtw_mlme.h b/drivers/staging/r= 8188eu/include/rtw_mlme.h index 1dc1fbf049af..0f03ac43079c 100644 --- a/drivers/staging/r8188eu/include/rtw_mlme.h +++ b/drivers/staging/r8188eu/include/rtw_mlme.h @@ -319,7 +319,6 @@ struct mlme_priv { struct list_head *pscanned; struct __queue free_bss_pool; struct __queue scanned_queue; - u8 *free_bss_buf; u8 key_mask; /* use to restore wep key after hal_init */ u32 num_of_scanned; =20 diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 3e9882f89f76..aed868d1d47b 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -61,7 +61,6 @@ static int _rtw_init_mlme_priv(struct adapter *padapter) res =3D _FAIL; goto exit; } - pmlmepriv->free_bss_buf =3D pbuf; =20 pnetwork =3D (struct wlan_network *)pbuf; =20 @@ -109,13 +108,7 @@ void rtw_free_mlme_priv_ie_data(struct mlme_priv *pmlm= epriv) =20 void _rtw_free_mlme_priv(struct mlme_priv *pmlmepriv) { - rtw_free_mlme_priv_ie_data(pmlmepriv); - - if (pmlmepriv) { - vfree(pmlmepriv->free_bss_buf); - } - } =20 struct wlan_network *_rtw_alloc_network(struct mlme_priv *pmlmepriv)/* _qu= eue *free_queue) */ --=20 2.25.1 From nobody Mon May 11 04:09:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E07C433F5 for ; Fri, 15 Apr 2022 02:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348858AbiDOCvk (ORCPT ); Thu, 14 Apr 2022 22:51:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348994AbiDOCvR (ORCPT ); Thu, 14 Apr 2022 22:51:17 -0400 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EB22B368C for ; Thu, 14 Apr 2022 19:48:47 -0700 (PDT) Received: by mail-qv1-xf34.google.com with SMTP id a10so5742202qvm.8 for ; Thu, 14 Apr 2022 19:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Jl8cA15AhHC5y4h+FeNERnQbKM+f37jdKRIZJGm/yhE=; b=L1WFgpZkQlF23uXoOfCCxu1h881F8755tMZldHEjaZbD4Afdt+/aOmDAZyoSWO5Uys TkkLFEGSZV4hhWg9ukWsCrTkJr6ImRLDrpI0OU+sqKadGebIDrEfgCXJZfy23Oe1f1ec DF6r1vW8cPZQgbSOWLLdRYaypN5fyVcAdEh+w0VeKgr9pMXAvpH0Ks7oIN6B28/4Cpm4 NkN2qc6QerfhQyiQRe9DDLXm7qlz0vJgvbxhvClsHNy9ZqlGetQMXtyh4BXjnh+MibPA 7EVnR+sblEXvRNsNbER9r2sg8DOCLcqc8xgVu2Lusua4LqieYqm6sh1FiYTIuIbUUB2c QTmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Jl8cA15AhHC5y4h+FeNERnQbKM+f37jdKRIZJGm/yhE=; b=eha+hke6QKmOdfdfukpTGfB3OhPE8zinbAhidNbnm/GK8D2Z3G1j/kPrdhHFKC/fBk ds29RixSoB8wsYyAlbZZgcusLf498b5+5MQS/oSK34/83m+B2PoC6512cHqpOm0hrtpI ph5QhaHPNzrF+Q+Q+TKB+/v0g7RvMmxtUKHqGmo3cCCpFxYJSCa/Qy2O0xcUgNpzWyEE YaF0MvPWkv8xj8oQJWL84/SZ8UD+B2mbdvnCYY/GVwEI6vLEIjaz/A+/1zwGm0pWC1KO WjV/XzWkfGaGZFjBd69Z2+RkH2boZRWEvLMd4Pzo9AyOvTaUETS3pkATMgLaHjjobMgl 0R0A== X-Gm-Message-State: AOAM531uCqa16TkX/6DJL29BzH9sWnmep1evNzE+c2C5BgDBaI+DGKiS z+rigBkY5W7O7bN0/OmDTjcO6/hJ8xfh1oKN X-Google-Smtp-Source: ABdhPJzlkp+L8XmPEEo671yAb3XgFN78LTs8FO4w3iGvK1FiTeC2Wf7DWE/jJh4wdVsqeqZyg+9bqw== X-Received: by 2002:a05:6214:622:b0:441:2825:c288 with SMTP id a2-20020a056214062200b004412825c288mr6051916qvx.79.1649990926337; Thu, 14 Apr 2022 19:48:46 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.lan ([2607:fb90:1b7a:2349:50b1:5db4:a2d5:7054]) by smtp.gmail.com with ESMTPSA id p7-20020a05620a22a700b0069c37e2c473sm1800085qkh.94.2022.04.14.19.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 19:48:45 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH v2 2/6] staging: r8188eu: remove spaces before tabs Date: Thu, 14 Apr 2022 22:48:33 -0400 Message-Id: <16fc136092cb89e6a819afe2de69edb96ca7c68a.1649990500.git.jhpark1013@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Delete spaces before tabs in the comments. Issue found with checkpatch. WARNING: please, no space before tabs Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index aed868d1d47b..1620ca181bf7 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -567,8 +567,8 @@ static void rtw_add_network(struct adapter *adapter, =20 /* select the desired network based on the capability of the (i)bss. */ /* check items: (1) security */ -/* (2) network_type */ -/* (3) WMM */ +/* (2) network_type */ +/* (3) WMM */ /* (4) HT */ /* (5) others */ static bool rtw_is_desired_network(struct adapter *adapter, struct wlan_ne= twork *pnetwork) @@ -903,9 +903,9 @@ static struct sta_info *rtw_joinbss_update_stainfo(stru= ct adapter *padapter, str memset((u8 *)&psta->dot11txpn, 0, sizeof(union pn48)); memset((u8 *)&psta->dot11rxpn, 0, sizeof(union pn48)); } - /* Commented by Albert 2012/07/21 */ - /* When doing the WPS, the wps_ie_len won't equal to 0 */ - /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitt= ed. */ + /* Commented by Albert 2012/07/21 */ + /* When doing the WPS, the wps_ie_len won't equal to 0 */ + /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitte= d. */ if (padapter->securitypriv.wps_ie_len !=3D 0) { psta->ieee8021x_blocked =3D true; padapter->securitypriv.wps_ie_len =3D 0; @@ -1628,8 +1628,8 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ /* */ /* Search by BSSID, */ /* Return Value: */ -/* -1 :if there is no pre-auth key in the table */ -/* >=3D 0 :if there is pre-auth key, and return the entry id */ +/* -1 :if there is no pre-auth key in the table */ +/* >=3D 0 :if there is pre-auth key, and return the entry id */ /* */ /* */ =20 --=20 2.25.1 From nobody Mon May 11 04:09:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BE63C433F5 for ; Fri, 15 Apr 2022 02:49:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348966AbiDOCvp (ORCPT ); Thu, 14 Apr 2022 22:51:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348991AbiDOCvR (ORCPT ); Thu, 14 Apr 2022 22:51:17 -0400 Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1410CB3DE7 for ; Thu, 14 Apr 2022 19:48:49 -0700 (PDT) Received: by mail-qv1-xf2c.google.com with SMTP id b17so5726586qvf.12 for ; Thu, 14 Apr 2022 19:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5A0iA12DjE2Xj3oy9Ql9XeQvXRDjoLwHOA0RLzS8BtA=; b=Kt3n3LeBcKw1ZOw7sJPczy6niRGgP1zaVmb1h2ZKFd7Trl5hILhNxeAwpliosVYxfB rX9hRaoJWi/By5k1bWGtDyL9Wa4Skl6p/qG9S5EsZst4JfDiS+ENNJoADRE7L5sRUQcm 8ncR+ehvbPsk3Jr8mQCrj+/zDjwtr4j5ADKT+B5VrFwKzCi9Tjapju8cpyjW1kaVMfSO 53OwU8UazEpaA+zZXOmiV5EJu0AUWx49LNhxdt/H3HAuJtFXWCyv6uPMyowmltlv1dTF p2FencsA92C2GO5NPWZkCMijo4xCeDeaK1sas8n43uU8PjbMgA32ETBWrko8oPtmSZ7B E5hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5A0iA12DjE2Xj3oy9Ql9XeQvXRDjoLwHOA0RLzS8BtA=; b=uGbq+Do0fGzx2nuq7AOuDsWJscUf1AvUC9EjyYlllZUTcYJEEMxFEqI0K0KR4UJfdb jtvUSyHRX5N/RCZhQbRpDtzsPxKLfgIiNh+bWoJnyoO6HB/hXR7JlLg23ARkNfuY4VKS 8SpzSmEBwwHF7gPQzDPC9SkRzVAZ1aDPbrdddCk/+RehG8OQVET+Ke0fFXDM+QY7xW4c kRprsbI971dOWnQwgLyLZy9aNtkcPN4N8943O++Vrnu/YunpVZwsm2zjIdtN5CVbEzKE E3dnPc2+Timw/cUaBZ103sGKKy6IvMhDSDQ5GQfg3eFhVNOmhA/qsmZZqTZWMvRZ3c5X hOhw== X-Gm-Message-State: AOAM5329x5Pli7rLWf9wRg4AK1TOtmu5md7TDCz4BtnUNB8t/5qXsLTQ tTIp2EYa2Bddth/clz+xiag= X-Google-Smtp-Source: ABdhPJz1dzwq53DhHYwCxThDEjWcaTnzYPO2a0RsEGbxEj+H71G9rhqjxIqxyJwnTkp1ohzCNfJzPw== X-Received: by 2002:ad4:5dc9:0:b0:443:b9e9:31ee with SMTP id m9-20020ad45dc9000000b00443b9e931eemr6088842qvh.111.1649990928205; Thu, 14 Apr 2022 19:48:48 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.lan ([2607:fb90:1b7a:2349:50b1:5db4:a2d5:7054]) by smtp.gmail.com with ESMTPSA id p7-20020a05620a22a700b0069c37e2c473sm1800085qkh.94.2022.04.14.19.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 19:48:47 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com, Pavel Skripkin , Alison Schofield Subject: [PATCH v2 3/6] staging: r8188eu: remove 'added by' author comments Date: Thu, 14 Apr 2022 22:48:34 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Author comments "Added by Albert" and "Added by Annie" are sprinkled through the file. These comments are not useful and can be removed. Reviewed-by: Pavel Skripkin Suggested-by: Alison Schofield Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 1620ca181bf7..bb9d595a90b9 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -903,7 +903,6 @@ static struct sta_info *rtw_joinbss_update_stainfo(stru= ct adapter *padapter, str memset((u8 *)&psta->dot11txpn, 0, sizeof(union pn48)); memset((u8 *)&psta->dot11rxpn, 0, sizeof(union pn48)); } - /* Commented by Albert 2012/07/21 */ /* When doing the WPS, the wps_ie_len won't equal to 0 */ /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitte= d. */ if (padapter->securitypriv.wps_ie_len !=3D 0) { @@ -1622,9 +1621,6 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ return ielength; } =20 -/* */ -/* Ported from 8185: IsInPreAuthKeyList(). (Renamed from SecIsInPreAuthKe= yList(), 2006-10-13.) */ -/* Added by Annie, 2006-05-07. */ /* */ /* Search by BSSID, */ /* Return Value: */ --=20 2.25.1 From nobody Mon May 11 04:09:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0859BC433EF for ; Fri, 15 Apr 2022 02:49:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348949AbiDOCvt (ORCPT ); Thu, 14 Apr 2022 22:51:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348989AbiDOCvR (ORCPT ); Thu, 14 Apr 2022 22:51:17 -0400 Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A603CB645F for ; Thu, 14 Apr 2022 19:48:50 -0700 (PDT) Received: by mail-qv1-xf33.google.com with SMTP id x20so5734110qvl.10 for ; Thu, 14 Apr 2022 19:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5Mc5RpUXea4SRPDeY1qeGl0bCped7ZnWWdOYH5iSbns=; b=h+6MCgqU+1gY93wXDbjOD3yeEt4oSm86gR8dYLMSQ5ontZUs7pHreKh6u8S9E7+8M9 rzG0d7uPGLmq0zgra31/y9DxTKn62SJryyXirRt3Q7dK9jOH0yvBCspl0TBcSVJNfmlr MuIr3C0hjDCSAkJfpoqwHM4RMAOSUGmW1cJxCyNavW8QdOP5khWN1zvH0PLgKDau7UGA z+nE60WMXRi2i8bHZextSl/Er27QHvLgmzISa14d9mhgbZ0llHrD6VduLHaMr4hqThWx bsbGP98jLUCCfQf9DDIgM+lpDcfax6T+Buz7M2T53ylKiRt2O1SUFpmyuj7nDCgN4GQy 3law== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5Mc5RpUXea4SRPDeY1qeGl0bCped7ZnWWdOYH5iSbns=; b=iGNGNLruqiAHLW39U/ZB46QK+AeiuepMDZj/36/KI+O1xwa8B0EDW/WbapOm06aN51 UoBDr00fgc55eDNpzGeOemQOhkB5cxj1kA4w5Si9O/NHx8oWKOH45c77xnCXDTEueycr bey5MKRTNOYTrLOSGAneNeNqKXO8r+kGsZLuvkJ7oKLFWvQ2jxzzvTFrCKf982AvUkha PtYb4XmiwIjNyo672H+O1cPk+UP+GGlu9oK62BL/mOcqY/Lp1iX4bYWdqXVnMcQktcwF JaaUGkb/SsXVrxAxISPt6mJmfg3BvDkSG7qPVVKxEBSeqh7pmxJcyx6q5k7wsiuW69qI oj2g== X-Gm-Message-State: AOAM532WQ06ZBhAHuWoO94P3tl96Sl/K4Ef1Md5t8hwJXHqLGUUPqmK0 uXzU/+JKE7T+YrGwWd6gxsY= X-Google-Smtp-Source: ABdhPJxWU4j21dPv9kXNTFNN4dy5rZpviBfSXSQmwgLz0JoRPXD0oZQB6WvoXjkL+dmsgsJ2EgK+Cw== X-Received: by 2002:a05:6214:f01:b0:443:a990:4ea4 with SMTP id gw1-20020a0562140f0100b00443a9904ea4mr6125752qvb.42.1649990929819; Thu, 14 Apr 2022 19:48:49 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.lan ([2607:fb90:1b7a:2349:50b1:5db4:a2d5:7054]) by smtp.gmail.com with ESMTPSA id p7-20020a05620a22a700b0069c37e2c473sm1800085qkh.94.2022.04.14.19.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 19:48:49 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH v2 4/6] staging: r8188eu: place constants on the right side of tests Date: Thu, 14 Apr 2022 22:48:35 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" To comply with the linux coding style, place constants on the right side of the test in comparisons. Issue found with checkpatch. WARNING: Comparisons should place the constant on the right side of the test. Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index bb9d595a90b9..d57f2ffa069e 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -715,7 +715,7 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) set_fwstate(pmlmepriv, _FW_UNDER_LINKING); pmlmepriv->to_join =3D false; s_ret =3D rtw_select_and_join_from_scanned_queue(pmlmepriv); - if (_SUCCESS =3D=3D s_ret) { + if (s_ret =3D=3D _SUCCESS) { _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else if (s_ret =3D=3D 2) { /* there is no need to wait for join */ _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); @@ -723,7 +723,8 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) } else { if (rtw_to_roaming(adapter) !=3D 0) { if (--pmlmepriv->to_roaming =3D=3D 0 || - _SUCCESS !=3D rtw_sitesurvey_cmd(adapter, &pmlmepriv->assoc_ssid,= 1, NULL, 0)) { + rtw_sitesurvey_cmd(adapter, &pmlmepriv->assoc_ssid, + 1, NULL, 0) !=3D _SUCCESS) { rtw_set_roaming(adapter, 0); rtw_free_assoc_resources(adapter, 1); rtw_indicate_disconnect(adapter); @@ -1964,7 +1965,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr issued =3D (phtpriv->agg_enable_bitmap >> priority) & 0x1; issued |=3D (phtpriv->candidate_tid_bitmap >> priority) & 0x1; =20 - if (0 =3D=3D issued) { + if (issued =3D=3D 0) { psta->htpriv.candidate_tid_bitmap |=3D BIT((u8)priority); rtw_addbareq_cmd(padapter, (u8)priority, pattrib->ra); } @@ -1991,19 +1992,19 @@ void _rtw_roaming(struct adapter *padapter, struct = wlan_network *tgt_network) else pnetwork =3D &pmlmepriv->cur_network; =20 - if (0 < rtw_to_roaming(padapter)) { + if (rtw_to_roaming(padapter) > 0) { memcpy(&pmlmepriv->assoc_ssid, &pnetwork->network.Ssid, sizeof(struct nd= is_802_11_ssid)); =20 pmlmepriv->assoc_by_bssid =3D false; =20 while (1) { do_join_r =3D rtw_do_join(padapter); - if (_SUCCESS =3D=3D do_join_r) { + if (do_join_r =3D=3D _SUCCESS) { break; } else { pmlmepriv->to_roaming--; =20 - if (0 < pmlmepriv->to_roaming) { + if (pmlmepriv->to_roaming > 0) { continue; } else { rtw_indicate_disconnect(padapter); --=20 2.25.1 From nobody Mon May 11 04:09:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 178E9C433F5 for ; Fri, 15 Apr 2022 02:49:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349044AbiDOCv7 (ORCPT ); Thu, 14 Apr 2022 22:51:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348975AbiDOCvT (ORCPT ); Thu, 14 Apr 2022 22:51:19 -0400 Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C61BB646A for ; Thu, 14 Apr 2022 19:48:52 -0700 (PDT) Received: by mail-qk1-x72e.google.com with SMTP id j6so5879149qkp.9 for ; Thu, 14 Apr 2022 19:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8uW8HDovjcYWMlVuqX7cK2tEDuwELYOJWlsZgLOTezY=; b=T9pY4aJr/Tpd8Txacuo9ZZRry1/sEf67pUNRbc9AgSvFHBDXD9KgEqMqwl+/FTbSRC Hy6xLkqluMcBP9tB4nwS35Ztr6NKZ2fK8iWm80EBvtrIWirwHuJDeLar30ggQzlHlXOl 4ycHils44jiXtdhQ25ZT8M8u/XCpHhXBXxn/9k/33xuhYmvGE2CbfypC6/wUvpdhoeVy qta80dlGApRL085+rfDV/VxmHAiAthkesg/RmYLGyLwibK0g6A4l2GJ+biooHJL5I9Dd Nt8wn6V74bJMdKBvk0GevW1fFpZMErgg1gkW5tWOwkrPn4fSV7fkakUPbzAphdtUuvAf yp0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8uW8HDovjcYWMlVuqX7cK2tEDuwELYOJWlsZgLOTezY=; b=FjkqR1pemFYe27A91D7mC6SXsWploif/yos3NzTUHEMALBNDm48UVdeh9uM0AfJ/xL 4dC+daq1cwegNCZYlAXFZOidXl+5hqhER7qJIuVM/cvz8ucd9A4VrqUC1lhisINFDD3a JQXZ9LiLbbOVmS18Xlxc7v/fLFtXR9wJPdk9QrhlwaICjPcaYK+ZKt9GJJWaQQPkJSan 32Xiawio/1o9sQrQnAGDrebVEuwYlccuQQRfuySbsSlWD4epbXE+Tw2OsgeLawPHTVDm 60wvroQurPkOoEqPNxWQJEQcUlgmDruE6oS0SwYJvwEz0jeuHkjQx+pegzULGDMEVFw0 +VaA== X-Gm-Message-State: AOAM530DFPhU93g/ErV23I6PFXyNqV6gc0a00xwqajr/gvxHnTsCtozz 9qKPRseglBXvurINRJhkT+g= X-Google-Smtp-Source: ABdhPJxBOZ/V3SpJWAh6t0TYcIQfFR8yObffl/ZuJG7zbcCFMc6wg0JEa6zEUgOsI2TfP+uJYVH7dg== X-Received: by 2002:a05:620a:2889:b0:699:bbc5:9b4b with SMTP id j9-20020a05620a288900b00699bbc59b4bmr4202038qkp.712.1649990931638; Thu, 14 Apr 2022 19:48:51 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.lan ([2607:fb90:1b7a:2349:50b1:5db4:a2d5:7054]) by smtp.gmail.com with ESMTPSA id p7-20020a05620a22a700b0069c37e2c473sm1800085qkh.94.2022.04.14.19.48.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 19:48:50 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH v2 5/6] staging: r8188eu: replace spaces with tabs Date: Thu, 14 Apr 2022 22:48:36 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use tabs instead of spaces. Issue found with checkpatch. WARNING: suspect code indent for conditional statements Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index d57f2ffa069e..38ae8be675c4 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -716,7 +716,7 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) pmlmepriv->to_join =3D false; s_ret =3D rtw_select_and_join_from_scanned_queue(pmlmepriv); if (s_ret =3D=3D _SUCCESS) { - _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); + _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else if (s_ret =3D=3D 2) { /* there is no need to wait for join */ _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); rtw_indicate_connect(adapter); --=20 2.25.1 From nobody Mon May 11 04:09:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF67C433F5 for ; Fri, 15 Apr 2022 02:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349025AbiDOCvx (ORCPT ); Thu, 14 Apr 2022 22:51:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348826AbiDOCvU (ORCPT ); Thu, 14 Apr 2022 22:51:20 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35933B53C2 for ; Thu, 14 Apr 2022 19:48:54 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id 3so5895419qkj.5 for ; Thu, 14 Apr 2022 19:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CKsPSzbdQxvHGjzHjwaUIzUGXMHlds2Vm+4c+Y0wyWg=; b=krNK/VQ+kVTKoPRnjaavol+6At8xRhgnz9BihNOArwhl5zTUEwXrg6CBipRyQsMU3c Oze96XQ8+P7KgwrKHO7MQUUkMSX6LEFHaQ93qfRtN8/vhAxS9p4QwUQ7FIzhOURbD3wf WX1JTHuCBh5IJv1v3UB8I1tWpqNJsWLqNpn/kaAH4sRQXLkgS0D7KT2/iagPiWawtCRn TUz0XS2hwaujZlBDju61US1NswuEj2TKIG85ZXbgLg1GvwftbcL892kJtr1E7VcZh9Jk 1gHBC3AE+iyfzIhcCZoblhIpJBHAZbOjP++OVxuefX2AH+/dM4clcE5nJhoaU0XsFiPu avww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CKsPSzbdQxvHGjzHjwaUIzUGXMHlds2Vm+4c+Y0wyWg=; b=o63Xaac1SW2fVj7mbiDQIvqgKJ+FqxH07GKmghJRyWUmPxzOJqV7ZfEummlP9xvjNM txHWBYHg7cRI2nQflWimodtafjAuyvMnUNtcTtcOzVcZa2ynUQWJP0x3aN3hJwYn5n8v 0Wt3sK+EKwgW0DpUTbXuhb4ExdFpOJ3FzB+4BUXL1NHUxmJC6GKI91SFvVl+67hNVc/Y S5blXcdISPF+8M/5swY29sVZ9Vb6mLjzsXBalrtKLF4fcVKuP+8cjizbXSXk639m84ev vhaabfNIbK6WW9IQIABdJEVAX8LRBs740o3Jr/mxd06y+GI5k6mL2Wdoi/GadK2xfmbX kQtQ== X-Gm-Message-State: AOAM532Qx5J9+hfggN1LRDV5/giiJi9oNe62gTS1gISlsaR56ldo93LL 4sAIaBEI+gUIkM2tXqS1u3w= X-Google-Smtp-Source: ABdhPJxmlagFCkqQolzg6U7aFXJnV+1Lr8Si2ywcY/BsE5JOOXCI5SlzAXt1V03EuIhyQqPEFbzlRg== X-Received: by 2002:ae9:ef8a:0:b0:69c:1015:3383 with SMTP id d132-20020ae9ef8a000000b0069c10153383mr4222123qkg.492.1649990933357; Thu, 14 Apr 2022 19:48:53 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.lan ([2607:fb90:1b7a:2349:50b1:5db4:a2d5:7054]) by smtp.gmail.com with ESMTPSA id p7-20020a05620a22a700b0069c37e2c473sm1800085qkh.94.2022.04.14.19.48.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 19:48:52 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH v2 6/6] staging: r8188eu: correct typo in comments Date: Thu, 14 Apr 2022 22:48:37 -0400 Message-Id: <080ec2f68f6558af098918e3b8e69a2d3529cb3f.1649990500.git.jhpark1013@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Correct misspellings in the comments. Issue found with checkpatch. Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 38ae8be675c4..58c7d6cc4a3f 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -186,7 +186,7 @@ void _rtw_free_network_nolock(struct mlme_priv *pmlmepr= iv, struct wlan_network * /* return the wlan_network with the matching addr =20 - Shall be calle under atomic context... to avoid possible racing condition= ... + Shall be called under atomic context... to avoid possible racing conditio= n... */ struct wlan_network *_rtw_find_network(struct __queue *scanned_queue, u8 *= addr) { @@ -322,7 +322,7 @@ void rtw_free_network_queue(struct adapter *dev, u8 isf= reeall) /* return the wlan_network with the matching addr =20 - Shall be calle under atomic context... to avoid possible racing condition= ... + Shall be called under atomic context... to avoid possible racing conditio= n... */ struct wlan_network *rtw_find_network(struct __queue *scanned_queue, u8 *a= ddr) { @@ -905,7 +905,7 @@ static struct sta_info *rtw_joinbss_update_stainfo(stru= ct adapter *padapter, str memset((u8 *)&psta->dot11rxpn, 0, sizeof(union pn48)); } /* When doing the WPS, the wps_ie_len won't equal to 0 */ - /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitte= d. */ + /* And the Wi-Fi driver shouldn't allow the data packet to be transmitte= d. */ if (padapter->securitypriv.wps_ie_len !=3D 0) { psta->ieee8021x_blocked =3D true; padapter->securitypriv.wps_ie_len =3D 0; @@ -1299,7 +1299,7 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) } =20 /* -* _rtw_join_timeout_handler - Timeout/faliure handler for CMD JoinBss +* _rtw_join_timeout_handler - Timeout/failure handler for CMD JoinBss * @adapter: pointer to struct adapter structure */ void _rtw_join_timeout_handler (struct adapter *adapter) @@ -1334,7 +1334,7 @@ void _rtw_join_timeout_handler (struct adapter *adapt= er) } =20 /* -* rtw_scan_timeout_handler - Timeout/Faliure handler for CMD SiteSurvey +* rtw_scan_timeout_handler - Timeout/Failure handler for CMD SiteSurvey * @adapter: pointer to struct adapter structure */ void rtw_scan_timeout_handler (struct adapter *adapter) --=20 2.25.1