From nobody Mon May 11 05:34:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94AD1C433F5 for ; Wed, 13 Apr 2022 20:11:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237635AbiDMUOJ (ORCPT ); Wed, 13 Apr 2022 16:14:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236376AbiDMUOG (ORCPT ); Wed, 13 Apr 2022 16:14:06 -0400 Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 638857CB24 for ; Wed, 13 Apr 2022 13:11:44 -0700 (PDT) Received: by mail-qt1-x82e.google.com with SMTP id hf18so1719652qtb.0 for ; Wed, 13 Apr 2022 13:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B8hL0jBT5xZ4aSX/GQ3ksV9bgLPofPyPWC/LZsNauFo=; b=Fvco4OsoRe9//Bop+KfXjpKPJGHg+bRdqjIjlvrvP3icpf1wlted+OlJEW64lm15es 7FLfGw6tH6FRHiffjDad3H2s8uLQpfwJuR/tP3uCofwmODJj6wbaQSsB+QgWHuDksjYD wtFHOvIyMQ4db1QT0cjQTfUn5fIR0/G+BwRWxhz7Ztz0naDzTbwjxq/14hPz5gnPrLqw kVBg+PMXkvFMDKZ1xrsMR3GWPoV2mh7rR/aGoXBL/MKSFZWbauVD5By0MuATi0F1Xzo/ nT8uglCRy9V9tulKuBcuoZFioLXGvRwD5dmwBod45tgX0tZ9uV2h74mCse8CkuXq1qsZ r1Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B8hL0jBT5xZ4aSX/GQ3ksV9bgLPofPyPWC/LZsNauFo=; b=uknhyUBCraPmHQWZ3pXPdFUQNVxcTGCX1MmBiCV8Q+bsQCmFHQ1C0wp9CHjD6HdQxz UEsLnLTfYH27qzyZ2ywpbTR4knKn187NeIsZysC3cPI8IWqstJ1vQ5TvJVrahubp/Pyq LKZo0MxShYZ/fylFIKC45WwGN+/0UlDFoPs0w6DgzNvRAmYEjz5k2AsEldb6awrnUWTK +G2HEdA4hZcjwdTnGk5/Vq68teCEvONNmUItPZPi+IXniymL2GmiIEGPEqSKJswThDwD /Bafv3wnS8v9cFCnEXzh0Hnt/wwZZIVTpmsir5AYPE/M7th5TlCCcHKYw3VIfULVatis rghA== X-Gm-Message-State: AOAM531Uhcva6QeK/2+MrtQzp13v0BsOIZSOxB3mWGZD94IPUeAcFf4w bM7AJm580ieDyLR738skHRM= X-Google-Smtp-Source: ABdhPJztoHGzRxQSLTi5Pjyws08NIOE9mJO0O3azoPPDeWOKUAl4LGSLQOpS892tebrsrhzUL0aQlQ== X-Received: by 2002:ac8:604b:0:b0:2f1:d064:35c with SMTP id k11-20020ac8604b000000b002f1d064035cmr3610036qtm.162.1649880703506; Wed, 13 Apr 2022 13:11:43 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id 7-20020a370907000000b0069c5598584esm1469827qkj.105.2022.04.13.13.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 13:11:42 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH 1/6] staging: r8188eu: remove unnecessary braces in single statement block Date: Wed, 13 Apr 2022 16:11:29 -0400 Message-Id: <4a0f2a0f24321c5b2039f0f8e6132cec4a2ef068.1649880454.git.jhpark1013@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove braces for single statement block to minimize the number of empty lines, without loss of readability. Issue found with checkpatch. WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 3e9882f89f76..d3f4d7cdfa08 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -112,9 +112,8 @@ void _rtw_free_mlme_priv(struct mlme_priv *pmlmepriv) =20 rtw_free_mlme_priv_ie_data(pmlmepriv); =20 - if (pmlmepriv) { + if (pmlmepriv) vfree(pmlmepriv->free_bss_buf); - } =20 } =20 --=20 2.25.1 From nobody Mon May 11 05:34:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC74FC433F5 for ; Wed, 13 Apr 2022 20:11:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238644AbiDMUON (ORCPT ); Wed, 13 Apr 2022 16:14:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237193AbiDMUOH (ORCPT ); Wed, 13 Apr 2022 16:14:07 -0400 Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACC9A7CB24 for ; Wed, 13 Apr 2022 13:11:45 -0700 (PDT) Received: by mail-qk1-x72b.google.com with SMTP id c1so2325748qkf.13 for ; Wed, 13 Apr 2022 13:11:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fZneH4LjchLUspCBR6Lavef7yu8zFb5eswSR3q4Bedk=; b=kKCkE1mTU+DdqnCj8NCQAqkogQ028mQ2y6QjWGNcQr+hrftJSy+u3+nzCJ96AwSM4r oz96E17JiW+6xRft7KWEPXYIXgSI3M2+Zd1m39eXd0OoMk+awKUvRfjMe+u58DEReZb3 nXiKIewoKfdO217K5vJ3TnVUsXa1Zs4AAYzDJMp7OM4t8wB74i/Io/Gpw+maRs8wxuXz cqTNeTYXEq9CB99afzfBBNKUQQTq1ssFY/Lorgn45Ad0Qst4E+bs0vUOm4ukni9WXVk8 V9g5fXIwL2JNWAnnoXSIxF+vFl2vKeBov44HfZ7GAGB456+rllUtmPNZTUfQ+qu8JWoi ZFYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fZneH4LjchLUspCBR6Lavef7yu8zFb5eswSR3q4Bedk=; b=fEl6/JacYKOX/eTok28nXIHX4whHov3lFaqtwJOlPHq39UsU/rSoWA5x9tAgyXd7EY GxdPX+XCsOBBJL8GkXvZFsGqqeQrh2VrJ0EEPoplXZVy90PS7XN8Nswvc1oJxZdYx/5Z OroZspqBkDTemSh4p0BVArCXYMnZ6v614dEc2hv3YGJCm9DugCGAz7n0E0w2aZ44yL/a AqN+tQIynhnvC76q3Nu+NHDMKD57YdgeU4eVP139QJibpHzoPuJr9u6f6BfwjHm54dRy L6tMSQtaipKZFJAc9s1/GuKqTwlFm8SvM2arlGPTCqKaWVCarsKAgfSsKC0HG4INhbk/ b0UA== X-Gm-Message-State: AOAM5306b7qhCUsCn/5WzhibuXlVDlvRcOQqLP9epdjVk2SqbRabMLD7 umsdtZrah+gs42hjBubm0+A= X-Google-Smtp-Source: ABdhPJy9A6fW1l4McT2TwRVX5CNaNpmRadFkLVNz0G3g8v7kVVnnqa4vb8jKg7THdaJd4RxkGE8h/g== X-Received: by 2002:a05:620a:4154:b0:69c:6976:1ee4 with SMTP id k20-20020a05620a415400b0069c69761ee4mr551891qko.463.1649880704808; Wed, 13 Apr 2022 13:11:44 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id 7-20020a370907000000b0069c5598584esm1469827qkj.105.2022.04.13.13.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 13:11:44 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH 2/6] staging: r8188eu: remove spaces before tabs Date: Wed, 13 Apr 2022 16:11:30 -0400 Message-Id: <9bad09e5de45ce0c369e9eb26c98d0662219e6e3.1649880454.git.jhpark1013@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Delete spaces before tabs in the comments. Issue found with checkpatch. WARNING: please, no space before tabs Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index d3f4d7cdfa08..2cfd8e8d74a4 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -573,8 +573,8 @@ static void rtw_add_network(struct adapter *adapter, =20 /* select the desired network based on the capability of the (i)bss. */ /* check items: (1) security */ -/* (2) network_type */ -/* (3) WMM */ +/* (2) network_type */ +/* (3) WMM */ /* (4) HT */ /* (5) others */ static bool rtw_is_desired_network(struct adapter *adapter, struct wlan_ne= twork *pnetwork) @@ -909,9 +909,9 @@ static struct sta_info *rtw_joinbss_update_stainfo(stru= ct adapter *padapter, str memset((u8 *)&psta->dot11txpn, 0, sizeof(union pn48)); memset((u8 *)&psta->dot11rxpn, 0, sizeof(union pn48)); } - /* Commented by Albert 2012/07/21 */ - /* When doing the WPS, the wps_ie_len won't equal to 0 */ - /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitt= ed. */ + /* Commented by Albert 2012/07/21 */ + /* When doing the WPS, the wps_ie_len won't equal to 0 */ + /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitte= d. */ if (padapter->securitypriv.wps_ie_len !=3D 0) { psta->ieee8021x_blocked =3D true; padapter->securitypriv.wps_ie_len =3D 0; @@ -1634,8 +1634,8 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ /* */ /* Search by BSSID, */ /* Return Value: */ -/* -1 :if there is no pre-auth key in the table */ -/* >=3D 0 :if there is pre-auth key, and return the entry id */ +/* -1 :if there is no pre-auth key in the table */ +/* >=3D 0 :if there is pre-auth key, and return the entry id */ /* */ /* */ =20 --=20 2.25.1 From nobody Mon May 11 05:34:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4EA3C433EF for ; Wed, 13 Apr 2022 20:11:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238660AbiDMUOQ (ORCPT ); Wed, 13 Apr 2022 16:14:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237250AbiDMUOI (ORCPT ); Wed, 13 Apr 2022 16:14:08 -0400 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB8BF7CB24 for ; Wed, 13 Apr 2022 13:11:46 -0700 (PDT) Received: by mail-qt1-x834.google.com with SMTP id o18so2191848qtk.7 for ; Wed, 13 Apr 2022 13:11:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Mu1OAjP3SMnZkiz81iTb0qSVH6tSWJDl8+n68t1vXxE=; b=BvJqGIXBkaxZ6cFuP/skqWxhW0WFquWrQFsXQyCwtTZDbrsG7wPCFnMl9VAo1hRimX 5K4rp/x3o6C2ap3DrWJculrIIVqUrjX4f2Z5EBQAzoamuHRAB5jxD3z2l0nwzgunCtwi buWTwmi9fLz09m6yv/ENfSUlEwADTUpUeQesL+JCgKyT6LqcZa9yK0dRabPg67s/nLmr clYqTZFuFcTn8xL31/iIhirgMMZq8/9p+j+do206zI8XSNr1a7jfRFlYteLTMK82xQtk /wNUqhrx3gPIEEBhtUEXJ/bmZ9K1TIyI+0ufOFWsjpdbRnOwbxgUbpcLGPQqBqkZiEA0 fnWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Mu1OAjP3SMnZkiz81iTb0qSVH6tSWJDl8+n68t1vXxE=; b=lozzwQenzVXSvZsT4HJnJcWVJjq++BW5duQ3hgT2SbwqtekIFbNnVe4S660USuj8wj qW1FRKRHRR7nxelbNXSIavoY1cEgR71HXLTpmxJ1Y9uX9w8JyQLsK4JHmCk6vIE91Mpx Dd4hNbEVTXyMmFBmrbiSZ+Fhk3X02psxcTGZ6H5+D+T2GdZ5pAknwsO5/ia7EBNDBRcx U0R6EnbtFR3MqmtDd/UuBRlwoAKXjG7A864RfRSLWxISYADpVOI5A/A5qrwmw1LfVTqJ Gqp6jHtLCC3uIE9GIHvsDCBMKl1X6r2Wb3dTLs+wH5KOhBfcqZ+ZBj30e+B/BUVNQO/R qMzQ== X-Gm-Message-State: AOAM532ic7oxwzTiZwNDcuQrsqULwqDRvyLjjc/cmOYdxHNpGCvhbjw8 ao/1P55ce02v5mhG2mbOaAI= X-Google-Smtp-Source: ABdhPJzWCouMMzzabzOWqJItVPit5N6AJ34ifKNKxlogdLuP54DDtWbfXAVgf9JrI/WQqR5+J+CISg== X-Received: by 2002:ac8:5f46:0:b0:2e1:da61:9734 with SMTP id y6-20020ac85f46000000b002e1da619734mr8625056qta.205.1649880705951; Wed, 13 Apr 2022 13:11:45 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id 7-20020a370907000000b0069c5598584esm1469827qkj.105.2022.04.13.13.11.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 13:11:45 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com, Alison Schofield Subject: [PATCH 3/6] staging: r8188eu: remove 'added by' author comments Date: Wed, 13 Apr 2022 16:11:31 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Author comments "Added by Albert" and "Added by Annie" are sprinkled through the file. Git will keep history so these comments can be removed from the code. Suggested-by: Alison Schofield Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 2cfd8e8d74a4..5adef9b9108d 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -909,7 +909,6 @@ static struct sta_info *rtw_joinbss_update_stainfo(stru= ct adapter *padapter, str memset((u8 *)&psta->dot11txpn, 0, sizeof(union pn48)); memset((u8 *)&psta->dot11rxpn, 0, sizeof(union pn48)); } - /* Commented by Albert 2012/07/21 */ /* When doing the WPS, the wps_ie_len won't equal to 0 */ /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitte= d. */ if (padapter->securitypriv.wps_ie_len !=3D 0) { @@ -1628,9 +1627,6 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ return ielength; } =20 -/* */ -/* Ported from 8185: IsInPreAuthKeyList(). (Renamed from SecIsInPreAuthKe= yList(), 2006-10-13.) */ -/* Added by Annie, 2006-05-07. */ /* */ /* Search by BSSID, */ /* Return Value: */ --=20 2.25.1 From nobody Mon May 11 05:34:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32488C433EF for ; Wed, 13 Apr 2022 20:12:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238692AbiDMUOV (ORCPT ); Wed, 13 Apr 2022 16:14:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238027AbiDMUOK (ORCPT ); Wed, 13 Apr 2022 16:14:10 -0400 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22ACA7EB1E for ; Wed, 13 Apr 2022 13:11:48 -0700 (PDT) Received: by mail-qt1-x836.google.com with SMTP id o18so2191900qtk.7 for ; Wed, 13 Apr 2022 13:11:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RsvCyHjEEdexsUzersCRTZshhGaPsOo9bh7mou5OagQ=; b=WBa6NhY5yXEgT+Gqpg+Z7tCpNTFJgemPs7PlszxJc+y7RgCQdhK3PHMpWMCOk4HXxv szv9jgCdUdjpfOHPHmysqL8OCRpRqphSnFGz4ckaxREtKkGKS18cIvQTrf8R1oOS1Pr7 w5ZJFzSotN/sRNntDULkFrstvVE2nyyFM080AYpX+qDRp72nu3WE+/DsTgvFIPoAWpvN s2X87tdyLY4Nzi4ADA0uS5TNH29UGIEiOZxe1ciYtRVkUpeiem+yzwh5Z//7xg+g78/X PARTVv5/SHKxHUGsvkGJnhpSakxSd20oenlW0nN2juDh/dbHchU2IH89ebTAdWYXp/qR 4EVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RsvCyHjEEdexsUzersCRTZshhGaPsOo9bh7mou5OagQ=; b=BxWODsv8fqCUDcXCZVZg2sPoIzzBvr8k1oNGcCRzSkdFQvM6sXLMz5VhOTXenU4etl nG4i+CVd366HIlIPILBMEPMkZaZN7gq+x1oWDJv9ZUu2/kzCFBd85cm4Wv07PPHCVdpC R6y9lMAsh/DyXUNZfgAKsZ1GgLI1JnvjR8KGrdwkfDtzm3K1L4aCqLazW1oYWuDorJ0+ LkOyJZ2dTYLacAx4tHr2AvW8sey5EUZLPtSFLe554uyMN+j6o56oEUuCXdJzHg59TN+k 142bk2jxBRr4rG6b7eBWKIsU18aJxzzNRQQUetwFd9p9N6/yg4uhjdwSFAu594oe1DKm uKlw== X-Gm-Message-State: AOAM5321TJ/JzFbCtpheT6HoksSAgPKF6xT4YhZ/4iSI8QVyTbVQK3Fc XVkhfhlVvsMmvtHFJqD+qLQ= X-Google-Smtp-Source: ABdhPJxaQNRyxc9Zpj6FjipuAcabNJxruD2Sgxd4BAP+w78VhMt55IcS0VntKwyV96blPz/x50H1eg== X-Received: by 2002:ac8:698a:0:b0:2ed:260f:b751 with SMTP id o10-20020ac8698a000000b002ed260fb751mr8403327qtq.89.1649880707276; Wed, 13 Apr 2022 13:11:47 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id 7-20020a370907000000b0069c5598584esm1469827qkj.105.2022.04.13.13.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 13:11:46 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH 4/6] staging: r8188eu: place constants on the right side of tests Date: Wed, 13 Apr 2022 16:11:32 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" To comply with the linux coding style, place constants on the right side of the test in comparisons. Issue found with checkpatch. WARNING: Comparisons should place the constant on the right side of the test. Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 5adef9b9108d..b943fb190e4c 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -721,7 +721,7 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) set_fwstate(pmlmepriv, _FW_UNDER_LINKING); pmlmepriv->to_join =3D false; s_ret =3D rtw_select_and_join_from_scanned_queue(pmlmepriv); - if (_SUCCESS =3D=3D s_ret) { + if (s_ret =3D=3D _SUCCESS) { _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else if (s_ret =3D=3D 2) { /* there is no need to wait for join */ _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); @@ -729,7 +729,8 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) } else { if (rtw_to_roaming(adapter) !=3D 0) { if (--pmlmepriv->to_roaming =3D=3D 0 || - _SUCCESS !=3D rtw_sitesurvey_cmd(adapter, &pmlmepriv->assoc_ssid,= 1, NULL, 0)) { + rtw_sitesurvey_cmd(adapter, &pmlmepriv->assoc_ssid, + 1, NULL, 0) !=3D _SUCCESS) { rtw_set_roaming(adapter, 0); rtw_free_assoc_resources(adapter, 1); rtw_indicate_disconnect(adapter); @@ -1970,7 +1971,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr issued =3D (phtpriv->agg_enable_bitmap >> priority) & 0x1; issued |=3D (phtpriv->candidate_tid_bitmap >> priority) & 0x1; =20 - if (0 =3D=3D issued) { + if (issued =3D=3D 0) { psta->htpriv.candidate_tid_bitmap |=3D BIT((u8)priority); rtw_addbareq_cmd(padapter, (u8)priority, pattrib->ra); } @@ -1997,19 +1998,19 @@ void _rtw_roaming(struct adapter *padapter, struct = wlan_network *tgt_network) else pnetwork =3D &pmlmepriv->cur_network; =20 - if (0 < rtw_to_roaming(padapter)) { + if (rtw_to_roaming(padapter) > 0) { memcpy(&pmlmepriv->assoc_ssid, &pnetwork->network.Ssid, sizeof(struct nd= is_802_11_ssid)); =20 pmlmepriv->assoc_by_bssid =3D false; =20 while (1) { do_join_r =3D rtw_do_join(padapter); - if (_SUCCESS =3D=3D do_join_r) { + if (do_join_r =3D=3D _SUCCESS) { break; } else { pmlmepriv->to_roaming--; =20 - if (0 < pmlmepriv->to_roaming) { + if (pmlmepriv->to_roaming > 0) { continue; } else { rtw_indicate_disconnect(padapter); --=20 2.25.1 From nobody Mon May 11 05:34:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF50C433F5 for ; Wed, 13 Apr 2022 20:12:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237775AbiDMUO0 (ORCPT ); Wed, 13 Apr 2022 16:14:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238343AbiDMUOL (ORCPT ); Wed, 13 Apr 2022 16:14:11 -0400 Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 289727EA33 for ; Wed, 13 Apr 2022 13:11:49 -0700 (PDT) Received: by mail-qt1-x82b.google.com with SMTP id z16so2196842qtq.6 for ; Wed, 13 Apr 2022 13:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ul9FGVJ1sqTdARK0mUZLH5+vAqXgfv1Osb8Y+BayvnA=; b=g3gjqqtdqKQE5IGicT5Wjd9h3ncG7DVCNTkMIk04qmTIFPfSPARDB83o4ujZ/aj4BW 1Ziuz0voyvAICrIB0yVPtQMS5aEEyJsViQkfhCuBv2rFF2P6KAlcUpGIfSQuwOjSAg9+ PoyxmZghi/DZFjwjf7KINxaxqWt02zgrnI4bz5GtcJTQ2iAz7Z/lAgVks8UJPzzGp0vR O6YdTukXugvGAKbCAJHdei/PAAX9L0dr+/v6acnR6iuk3/kdXqHLFmvmZ9yE1Uc4KKgE wO4qkmrufxD+mJhNQenzel3OKXg57IvUXg536Dgbh6dnNlQDSPstmwjlENL4fSy59SlU UO0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ul9FGVJ1sqTdARK0mUZLH5+vAqXgfv1Osb8Y+BayvnA=; b=iXwgx+GNrqaRnjb0kDBKnOpnb3Fz9P+Ke5IM451pWa/wyzssff/7v/PtskaCGVgOAQ 7xQ9ukEhaPmJX4q2uMFJcoEPhVDi/pB8IlXit9ox/pn1u5zkWbxNnicXwgs0P1Oj5nxF aKkvc6NDpJEY2gKO2FGDUr7W8BcUpNv8FmJQbbcKF3GkhrGw5ok6pzQra60pqXSSuZZa J2uTnSusrXienqeLrLqdcH9cGrXX5tNOTZh5oDSiq0HSHTCR+fTnhwX1CzIvUCWzWeAh tfwR3BuZJI6/QPSW3jXNVtOvayBSQMFOIJJpNECHXFCL+g3+Q/0RXPWocAidVdh9inu6 Lyhw== X-Gm-Message-State: AOAM532CirMeNnLJEFyIOuKnhxrpE9UpFvlF0iaUTa0N4uFR0aKV6bI8 W7H4VV6wGTje6X+1B4v4Ay8= X-Google-Smtp-Source: ABdhPJzfi6bbVPouWPiwjX4RCv+GQvPEnn27rrOjadz/T8qn0tC/JtVXXDXSE2vWCCCbYKdHSZ36SA== X-Received: by 2002:a05:622a:408f:b0:2ed:12b7:2e9c with SMTP id cg15-20020a05622a408f00b002ed12b72e9cmr8351994qtb.309.1649880708326; Wed, 13 Apr 2022 13:11:48 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id 7-20020a370907000000b0069c5598584esm1469827qkj.105.2022.04.13.13.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 13:11:47 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH 5/6] staging: r8188eu: replace spaces with tabs Date: Wed, 13 Apr 2022 16:11:33 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use tabs instead of spaces. Issue found with checkpatch. WARNING: suspect code indent for conditional statements Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index b943fb190e4c..7a90fe826d1d 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -722,7 +722,7 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) pmlmepriv->to_join =3D false; s_ret =3D rtw_select_and_join_from_scanned_queue(pmlmepriv); if (s_ret =3D=3D _SUCCESS) { - _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); + _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else if (s_ret =3D=3D 2) { /* there is no need to wait for join */ _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); rtw_indicate_connect(adapter); --=20 2.25.1 From nobody Mon May 11 05:34:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B68C433F5 for ; Wed, 13 Apr 2022 20:12:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238714AbiDMUOd (ORCPT ); Wed, 13 Apr 2022 16:14:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238629AbiDMUOM (ORCPT ); Wed, 13 Apr 2022 16:14:12 -0400 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A03AF7EB2A for ; Wed, 13 Apr 2022 13:11:50 -0700 (PDT) Received: by mail-qv1-xf35.google.com with SMTP id b17so2444511qvf.12 for ; Wed, 13 Apr 2022 13:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NMYq8qcFTxh0xZzr+s+ajhPy8SCulftSg3sqVf1Tdxo=; b=oYhBgOSuosl6tL48jTUohiHOpUf+YjueYnMYdwuKylf3p7YWpj1FOXPT2pIUio/kik sYD8+KyL+GtLbTg2+kmbODB2pglVR+1LR1koJ/BEl6ntVqI3SEuSHDVkeqMwS5eolv6E J6jCQUKYhkfju81I83DDmPIEFvcI+xDve2lSMat6lyYmw0IFWUcyLJEBjIwAPji95MAW 3s9Su3v/mSWoqn9gVwQnVZlyVvcMd03WhS6BYHfuh1WbN9s15MYG5+WfNV2oyvI6ARVt hTm5WDUPPtvH+6EUbq1eXWr/O+55a8JxCwwf2vsh1yOtSkKhum8QnYWpzd3F8lc9slLt GxGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NMYq8qcFTxh0xZzr+s+ajhPy8SCulftSg3sqVf1Tdxo=; b=rVF1FUuLR4F/eK9AC5ZGkIaq0j3HgcdUrD7aN2JTeXmqN9W2t5U8QXoEy4q5Qqm62h wRv6eiitDXGpzDdGuartcD47aM1jDI0gpUCRoZ3NO8+5XCoibVWo5swkWXpXYsTV+YqK hJmEkrjQA6m2MJWt/gqdalEhftrxTn7moGN+q9lfrBXBq/nZf/C9wAT4iXRbarRwNExx RXUDZ0pWEOZ7xUhq5n4eYwg4UrF0AcdYSAQWtDW8DSWWFLBpfIY12N8W+c4AXvd4n0Gl dRdP/V46fpInp1qaMkv+h4yBr/6Sd3mtSW2HSjo0zhMg4wZKekvdoyAoLuJpxbtOK1Fi 2N0g== X-Gm-Message-State: AOAM532t1Gx7l0gSpQrlTfkX44gFibLqM+3aUtX2oRfAbRR/uVfv7uvf l0hwcAW8HY5dmLOQeMtZH60= X-Google-Smtp-Source: ABdhPJy0EsEhPQ/ILFgSmyz6uo6YpNecGOiFrkVwEzNx23WvjkMRvqdLlxdZsF0Cts/4ng4i7j133A== X-Received: by 2002:a05:6214:18c4:b0:444:39f6:b328 with SMTP id cy4-20020a05621418c400b0044439f6b328mr10001532qvb.51.1649880709390; Wed, 13 Apr 2022 13:11:49 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme.wework.com ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id 7-20020a370907000000b0069c5598584esm1469827qkj.105.2022.04.13.13.11.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 13:11:48 -0700 (PDT) From: Jaehee Park To: Larry.Finger@lwfinger.net Cc: phil@philpotter.co.uk, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, jhpark1013@gmail.com Subject: [PATCH 6/6] staging: r8188eu: correct typo in comments Date: Wed, 13 Apr 2022 16:11:34 -0400 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Correct misspellings in the comments. Issue found with checkpatch. Signed-off-by: Jaehee Park --- drivers/staging/r8188eu/core/rtw_mlme.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r818= 8eu/core/rtw_mlme.c index 7a90fe826d1d..d422ce87ba7c 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme.c +++ b/drivers/staging/r8188eu/core/rtw_mlme.c @@ -192,7 +192,7 @@ void _rtw_free_network_nolock(struct mlme_priv *pmlmepr= iv, struct wlan_network * /* return the wlan_network with the matching addr =20 - Shall be calle under atomic context... to avoid possible racing condition= ... + Shall be called under atomic context... to avoid possible racing conditio= n... */ struct wlan_network *_rtw_find_network(struct __queue *scanned_queue, u8 *= addr) { @@ -328,7 +328,7 @@ void rtw_free_network_queue(struct adapter *dev, u8 isf= reeall) /* return the wlan_network with the matching addr =20 - Shall be calle under atomic context... to avoid possible racing condition= ... + Shall be called under atomic context... to avoid possible racing conditio= n... */ struct wlan_network *rtw_find_network(struct __queue *scanned_queue, u8 *a= ddr) { @@ -911,7 +911,7 @@ static struct sta_info *rtw_joinbss_update_stainfo(stru= ct adapter *padapter, str memset((u8 *)&psta->dot11rxpn, 0, sizeof(union pn48)); } /* When doing the WPS, the wps_ie_len won't equal to 0 */ - /* And the Wi-Fi driver shouldn't allow the data packet to be tramsmitte= d. */ + /* And the Wi-Fi driver shouldn't allow the data packet to be transmitte= d. */ if (padapter->securitypriv.wps_ie_len !=3D 0) { psta->ieee8021x_blocked =3D true; padapter->securitypriv.wps_ie_len =3D 0; @@ -1305,7 +1305,7 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) } =20 /* -* _rtw_join_timeout_handler - Timeout/faliure handler for CMD JoinBss +* _rtw_join_timeout_handler - Timeout/failure handler for CMD JoinBss * @adapter: pointer to struct adapter structure */ void _rtw_join_timeout_handler (struct adapter *adapter) @@ -1340,7 +1340,7 @@ void _rtw_join_timeout_handler (struct adapter *adapt= er) } =20 /* -* rtw_scan_timeout_handler - Timeout/Faliure handler for CMD SiteSurvey +* rtw_scan_timeout_handler - Timeout/Failure handler for CMD SiteSurvey * @adapter: pointer to struct adapter structure */ void rtw_scan_timeout_handler (struct adapter *adapter) --=20 2.25.1