From nobody Mon May 11 09:09:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A53C5C4707A for ; Tue, 12 Apr 2022 07:45:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356892AbiDLHjc (ORCPT ); Tue, 12 Apr 2022 03:39:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352948AbiDLHOl (ORCPT ); Tue, 12 Apr 2022 03:14:41 -0400 Received: from m228-62.mailgun.net (m228-62.mailgun.net [159.135.228.62]) by lindbergh.monkeyblade.net (Postfix) with UTF8SMTPS id 9B88225585 for ; Mon, 11 Apr 2022 23:55:30 -0700 (PDT) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=codeagain.dev; q=dns/txt; s=smtp; t=1649746529; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Subject: Cc: To: To: From: From: Date: Sender: Sender; bh=AiF//WsDF45djMQx3YL7cf1DqVbLJ96Fuowq5Sohtcs=; b=htNuHUv++i/778aYMWWPRBZYNRjhV0zzqQE08NLy6zBBxq0izCVTJ7ecdew6ffgXowXNGJnQ A0QdNQONrb3YMRe4Ct4HpdGtG4FkHcYQCQCPCum1a0Y4cT1EmM8GIGZ+LqWv/R/qY8QfBqPP 2mdichIi1MDhaZTDwj29Ws6nAl0i11imkfvpGQBqqGrXFsVyaR+H0gYmQ9Sv0uwd9S99Yrb1 jXAyB7MvF15w1gI0VIUXaMDubmedK5gCtYAcffYHy1cMYVNGwhPpu7ELkhMR1tp63zX7iGiK Zul2ZncAhBt77sWvquNQkCi9CYW+ZynArVPsp9UY+3LYdm859wSXbg== X-Mailgun-Sending-Ip: 159.135.228.62 X-Mailgun-Sid: WyJkNDU4NiIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWM2ZCJd Received: from AN5Bruno (186-250-90-1.mhnet.com.br [186.250.90.1]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 62552261c172fc50663e09b1 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Tue, 12 Apr 2022 06:55:29 GMT Sender: codeagain@codeagain.dev Date: Tue, 12 Apr 2022 03:55:21 -0300 From: Bruno Moreira-Guedes To: Greg Kroah-Hartman , Martyn Welch , Manohar Vanga , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Cc: Bruno's Patch Watchbox Subject: [PATCH v2 1/3] staging: vme: Adjusted VME_USER in Kconfig Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k7jdtsdktb7p5dg6" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --k7jdtsdktb7p5dg6 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Currently, the VME_USER driver is in the staging tree Kconfig, unlike other VME drivers already moved to the main portions of the kernel tree. Its configuration is, however, nested into the VME_BUS config option, which might be misleading. Since the staging tree "[...] is used to hold stand-alone[1] drivers and filesystem that are not ready to be merged into the main portion of the Linux kernel tree [...]"[1], IMHO all staging drivers should appear nested into the Main Menu -> Device Drivers -> Staging Drivers to make sure the user don't pick it without being fully aware of its staging status as it could be the case in Menu -> Device Drivers -> VME bridge support (the current location). With this change menuconfig users will clearly know this is not a driver in the main portion of the kernel tree and decide whether to build it or not with that clearly in mind. This change goes into the same direction of commit 4b4cdf3979c3 ("STAGING: Move staging drivers back to staging-specific menu") CHANGELOG v1: - Sourced "drivers/staging/vme/devices/Kconfig" in "drivers/staging/Kconfig" and unsourced in "drivers/vme/Kconfig". v2: - Turned into a patchset to (1) fix missing "depends on" missing entry in config VME_USER at "drivers/staging/vme/devices/Kconfig", affecting the behavior of this patch, and (2) fix unnecessary remaining files from the time the whole vme subtree was in staging. REFERENCES [1] https://lkml.org/lkml/2009/3/18/314 Signed-off-by: Bruno Moreira-Guedes --- drivers/staging/Kconfig | 2 ++ drivers/vme/Kconfig | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index 932acb4e8cbc..0545850eb2ff 100644 --- a/drivers/staging/Kconfig +++ b/drivers/staging/Kconfig @@ -88,4 +88,6 @@ source "drivers/staging/qlge/Kconfig" =20 source "drivers/staging/wfx/Kconfig" =20 +source "drivers/staging/vme/devices/Kconfig" + endif # STAGING diff --git a/drivers/vme/Kconfig b/drivers/vme/Kconfig index 936392ca3c8c..c13dd9d2a604 100644 --- a/drivers/vme/Kconfig +++ b/drivers/vme/Kconfig @@ -15,6 +15,4 @@ source "drivers/vme/bridges/Kconfig" =20 source "drivers/vme/boards/Kconfig" =20 -source "drivers/staging/vme/devices/Kconfig" - endif # VME --=20 2.35.1 --k7jdtsdktb7p5dg6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQTUrsHCxGmQ5vyKRAZtd3tyEY2kgUCYlUiWQAKCRAZtd3tyEY2 kpxJAP9hu/i4d9Z8AbbgwkQWiib5YTG002x5B+eV30eRlzxbaQEAjDgQoeYmJy3v 4JHNz9sr3f3NQzeAHgF0Smo48q1HzQA= =Mbz3 -----END PGP SIGNATURE----- --k7jdtsdktb7p5dg6-- From nobody Mon May 11 09:09:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F902C4332F for ; Tue, 12 Apr 2022 08:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357815AbiDLITO (ORCPT ); Tue, 12 Apr 2022 04:19:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354953AbiDLH1A (ORCPT ); Tue, 12 Apr 2022 03:27:00 -0400 Received: from m228-62.mailgun.net (m228-62.mailgun.net [159.135.228.62]) by lindbergh.monkeyblade.net (Postfix) with UTF8SMTPS id D139247553 for ; Tue, 12 Apr 2022 00:06:55 -0700 (PDT) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=codeagain.dev; q=dns/txt; s=smtp; t=1649747215; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Subject: Cc: To: To: From: From: Date: Sender: Sender; bh=fvgEOeU8QI1dhGiQvK+nRA/UPCGXfJKOpsdVofoakIo=; b=NvGv8dEjAAp3+VikOfUObAxYtrnLW9QAOOGMeh/7ELD/XyzyaKSNVHMn0CATTdFo76WVcK5F u9wE02pYhBY8/XWTK6F846LO3zgn7wIvmlyEZsLgctaLPYn6w9TX3TWgZS69ZaI3XrE968qv 8oKDBGa99Hyrmw+lOyc8yQTX7qATSRxUX2SRLpl0AukHcM0HrRYcnOpVcoEhg+XBW9Gg8XLf guUPLpQTfhqAERLhzrqrRMP2K04yuZ8UztSOAxKyxK5CWvjGRWd90eqzFaIMCW2hXqZ4TgOQ rOTnEAZLAGJRtzG+Y3B+c/l+uEgFtfR/9cDyaAQYGJ27Kn/YhwB8FQ== X-Mailgun-Sending-Ip: 159.135.228.62 X-Mailgun-Sid: WyJkNDU4NiIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWM2ZCJd Received: from AN5Bruno (186-250-90-1.mhnet.com.br [186.250.90.1]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 625522b5487c9ee854845f89 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Tue, 12 Apr 2022 06:56:53 GMT Sender: codeagain@codeagain.dev Date: Tue, 12 Apr 2022 03:56:43 -0300 From: Bruno Moreira-Guedes To: Greg Kroah-Hartman , Martyn Welch , Manohar Vanga , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Cc: Bruno's Patch Watchbox Subject: [PATCH v2 2/3] staging: vme: Fix missing `depends on` at KConfig Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r67e4p532boyyctc" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --r67e4p532boyyctc Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Originally, the KConfig file for VME_USER ("drivers/staging/vme/devices/Kconfig") was sourced at "drivers/vme/boards/KConfig". It misses a `depends on` line for VME_BUS, which went unnoticeable for a menuconfig user who wouldn't be able to select it through this interface without selecting the CONFIG_VME_BUS option because it was nested on its menu. A patch to move appropriately this driver to the "Staging" submenu[1], however, unveiled this missing `depends on` line, since it moved the `source` line for VME_USER's KConfig to somewhere else, allowing it to be compiled without the support for VME_BRIDGE. While it compiles fine and seems to initialize the driver fine[2], it seems to make no sense having VME_USER without VME_BUS. This patches addresses it by adding the VME_BUS to the `depends on` line at "drivers/staging/vme/devices/Kconfig". CHANGELOG: v2: - Added this patch to the patchset REFERENCES AND NOTES [1] First commit in this patch, originally submitted at https://lore.kernel.org/linux-staging/3fbc5325e94b9ae0666a1f5a56a4e5372bfce= a1d.camel@codeagain.dev/T/#t [2] Tested both as module and as built-in. Signed-off-by: Bruno Moreira-Guedes --- drivers/staging/vme/devices/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme/devi= ces/Kconfig index 5651bb16b28b..e8b4461bf27f 100644 --- a/drivers/staging/vme/devices/Kconfig +++ b/drivers/staging/vme/devices/Kconfig @@ -3,7 +3,7 @@ comment "VME Device Drivers" =20 config VME_USER tristate "VME user space access driver" - depends on STAGING + depends on STAGING && VME_BUS help If you say Y here you want to be able to access a limited number of VME windows in a manner at least semi-compatible with the interface --=20 2.35.1 --r67e4p532boyyctc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQTUrsHCxGmQ5vyKRAZtd3tyEY2kgUCYlUiqwAKCRAZtd3tyEY2 kh7WAQDnPJNUjIPGKOS6iN5nijD+bLt8dlNylHDXGzcDp/x21QEAttFRYM5TnNEi Wn7P5NtTX55JavXFp1wmv2lUDtDWZww= =So4f -----END PGP SIGNATURE----- --r67e4p532boyyctc-- From nobody Mon May 11 09:09:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 593B0C4167D for ; Tue, 12 Apr 2022 07:45:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376413AbiDLHoB (ORCPT ); Tue, 12 Apr 2022 03:44:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354204AbiDLHRO (ORCPT ); Tue, 12 Apr 2022 03:17:14 -0400 Received: from m228-62.mailgun.net (m228-62.mailgun.net [159.135.228.62]) by lindbergh.monkeyblade.net (Postfix) with UTF8SMTPS id 725064B852 for ; Mon, 11 Apr 2022 23:58:31 -0700 (PDT) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=codeagain.dev; q=dns/txt; s=smtp; t=1649746711; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Subject: Cc: To: To: From: From: Date: Sender: Sender; bh=xpRZFsxytzgneOlsluEhnk6HH0jkgAUHzKO26/lNTYc=; b=Hf8fbU6shRw/5GzEsg4siGkpvS5qED3RnAsyTq+SMio33TKrDfogCJRbgXRsm4IzotFdGMJe ZFytFAFwncMwl4C0EMk/iFqu1swVQTRyGZMOzeP6nxbYRRR2f8Vk3igOHbUQnKHcauuiThtX gFNkSizsr/UrisgZWox2kwGAQHYTGr1XDWmpDzE8b//Gp/ejtHXrT2NfSE47piFBMwWX7nk6 PBFonWd75EQqvyB+x+G8SQKjB2AmddyLXqAXcQIJHoht6kQBI99C092MMuIzpcvGZiamln17 HI7K5K5TJ8yra5ta0gJH/LKbaytdsn6wH2UnYqVUNxeZo66s9ysmbQ== X-Mailgun-Sending-Ip: 159.135.228.62 X-Mailgun-Sid: WyJkNDU4NiIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWM2ZCJd Received: from AN5Bruno (186-250-90-1.mhnet.com.br [186.250.90.1]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 625523167a6ca2b683fc51ef (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Tue, 12 Apr 2022 06:58:29 GMT Sender: codeagain@codeagain.dev Date: Tue, 12 Apr 2022 03:58:25 -0300 From: Bruno Moreira-Guedes To: Greg Kroah-Hartman , Martyn Welch , Manohar Vanga , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Cc: Bruno's Patch Watchbox Subject: [PATCH v2 3/3] staging: vme: "drivers/staging/vme" tree cleanup Message-ID: <142698e3761c1e7ba8b17cdd9dc077472ef81668.1649721450.git.codeagain@codeagain.dev> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iejrtspvkosvtjkp" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --iejrtspvkosvtjkp Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In ("Staging: VME: move VME drivers out of staging") the vme code, board and bridge drivers were moved out of the staging tree, remaining only the VME user device driver. Since this driver is the only one remaining in staging, such multi-level struct confuses more than helps. The current structure is as follows: - drivers/staging/vme/ +Makefile +devices/ +Kconfig +Makefile +vme_user.c +vme_user.h The root Makefile has the only function of calling the other Makefile into the devices/ subdirectory. This latter only compiles the vme_user driver, since there is no other. This patch allows a more straightforward understanding of this driver's contents by removing the unnecessary Makefile from the 'vme/' subdir, moving the contents of 'vme/devices' straight into 'vme/', and renaming 'vme/' to 'vme_user' (the driver name). It also adjusts the Kconfig and the Makefile from drivers/staging to properly reflect the new structure. CHANGELOG v2: - Added this patch to the patchset Signed-off-by: Bruno Moreira-Guedes --- MAINTAINERS | 2 +- drivers/staging/Kconfig | 2 +- drivers/staging/Makefile | 2 +- drivers/staging/vme/Makefile | 2 -- drivers/staging/{vme/devices =3D> vme_user}/Kconfig | 0 drivers/staging/{vme/devices =3D> vme_user}/Makefile | 0 drivers/staging/{vme/devices =3D> vme_user}/vme_user.c | 0 drivers/staging/{vme/devices =3D> vme_user}/vme_user.h | 0 8 files changed, 3 insertions(+), 5 deletions(-) delete mode 100644 drivers/staging/vme/Makefile rename drivers/staging/{vme/devices =3D> vme_user}/Kconfig (100%) rename drivers/staging/{vme/devices =3D> vme_user}/Makefile (100%) rename drivers/staging/{vme/devices =3D> vme_user}/vme_user.c (100%) rename drivers/staging/{vme/devices =3D> vme_user}/vme_user.h (100%) diff --git a/MAINTAINERS b/MAINTAINERS index fd768d43e048..88423218e5e6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21014,7 +21014,7 @@ L: linux-kernel@vger.kernel.org S: Maintained T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git F: Documentation/driver-api/vme.rst -F: drivers/staging/vme/ +F: drivers/staging/vme_user/ F: drivers/vme/ F: include/linux/vme* =20 diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index 0545850eb2ff..9f11592336f8 100644 --- a/drivers/staging/Kconfig +++ b/drivers/staging/Kconfig @@ -88,6 +88,6 @@ source "drivers/staging/qlge/Kconfig" =20 source "drivers/staging/wfx/Kconfig" =20 -source "drivers/staging/vme/devices/Kconfig" +source "drivers/staging/vme_user/Kconfig" =20 endif # STAGING diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile index 3ffb35ccfae2..1dffa02121ee 100644 --- a/drivers/staging/Makefile +++ b/drivers/staging/Makefile @@ -14,7 +14,7 @@ obj-$(CONFIG_OCTEON_ETHERNET) +=3D octeon/ obj-$(CONFIG_OCTEON_USB) +=3D octeon-usb/ obj-$(CONFIG_VT6655) +=3D vt6655/ obj-$(CONFIG_VT6656) +=3D vt6656/ -obj-$(CONFIG_VME_BUS) +=3D vme/ +obj-$(CONFIG_VME_BUS) +=3D vme_user/ obj-$(CONFIG_IIO) +=3D iio/ obj-$(CONFIG_FB_SM750) +=3D sm750fb/ obj-$(CONFIG_USB_EMXX) +=3D emxx_udc/ diff --git a/drivers/staging/vme/Makefile b/drivers/staging/vme/Makefile deleted file mode 100644 index cf2f686ccffe..000000000000 --- a/drivers/staging/vme/Makefile +++ /dev/null @@ -1,2 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -obj-y +=3D devices/ diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme_user= /Kconfig similarity index 100% rename from drivers/staging/vme/devices/Kconfig rename to drivers/staging/vme_user/Kconfig diff --git a/drivers/staging/vme/devices/Makefile b/drivers/staging/vme_use= r/Makefile similarity index 100% rename from drivers/staging/vme/devices/Makefile rename to drivers/staging/vme_user/Makefile diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme_u= ser/vme_user.c similarity index 100% rename from drivers/staging/vme/devices/vme_user.c rename to drivers/staging/vme_user/vme_user.c diff --git a/drivers/staging/vme/devices/vme_user.h b/drivers/staging/vme_u= ser/vme_user.h similarity index 100% rename from drivers/staging/vme/devices/vme_user.h rename to drivers/staging/vme_user/vme_user.h --=20 2.35.1 --iejrtspvkosvtjkp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQTUrsHCxGmQ5vyKRAZtd3tyEY2kgUCYlUjEQAKCRAZtd3tyEY2 kl8eAP4snnu7VXp+5WvEdegb9U/Z3NohM0xIqXwMgaQE2l2o+AEA6FZFKAx2mukA Rl951E2lmtYRuXPD2OZSk6mgMUWzGQg= =sCQP -----END PGP SIGNATURE----- --iejrtspvkosvtjkp--