From nobody Fri Jun 19 08:29:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CB1CC433F5 for ; Wed, 6 Apr 2022 12:34:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230327AbiDFMfl (ORCPT ); Wed, 6 Apr 2022 08:35:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233407AbiDFMdJ (ORCPT ); Wed, 6 Apr 2022 08:33:09 -0400 Received: from mail-oa1-x42.google.com (mail-oa1-x42.google.com [IPv6:2001:4860:4864:20::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0686B286A4F for ; Wed, 6 Apr 2022 01:31:19 -0700 (PDT) Received: by mail-oa1-x42.google.com with SMTP id 586e51a60fabf-de3ca1efbaso2148376fac.9 for ; Wed, 06 Apr 2022 01:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CbQxzsG90z/JAl+WL+UN3YQnw6GKHPn4W6/z3zTcYNI=; b=bDK9rgrwMdYaTfZncsYLB1OVeHWvUHfcWrQ29VZ53/xLdP9LJ/OUGh0tLfPFxFFQai 2xffbgBMJ0tckWZWmopgZS1PXHBHn8STAgZA4Hs0m3IGNqNDPd9u7tIzJ0mC3gVtrzbT yU6RIx91qw4kbbOcSni4Vy8hOCVbyKPnQZx5v1PghB8gkpf9A5z1WK7ZZOrOCNeeu2nS AolCaBhaYTvWEJOOVNa0ifJGteo17plWdV8adfWQGFzOq9ko1ZrnmYlwUuUxDZpdIEEo 3AXQaLsqUVQwvNpxFVFLasmTbCIasrvyxMa/B9iwL+tZXrCyHXqYdc5456WvTaQx1T+V +o8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CbQxzsG90z/JAl+WL+UN3YQnw6GKHPn4W6/z3zTcYNI=; b=JAvmB04k+34K2KMfB4MYxNGs/MbG0qHR9QAETrUcDbU0QF2V9LtyrNDlEcuaynhOP/ +cy+qnM6O68kqFj0LfdbMKyFsBEvNwFuzzNNotT1v1LsUk6QgCcGLErkhqdMqGQOYOVE JIEPXegyhDUMCyKhd5SoCqUiVc2C3E73D1/zqbO0rVYXd3FXX4UpVeIRau2Cn1l3AsBX Cv8lcRawZ6uaRyNknwh8DWIQlUzsWflpryc5Q2O5lhsa1ksUsUSM/i5dKOcsWZP8nar/ qvzCb6LtENnN+82BxAoD7ov8o8hK8Ex1X0GfV82qwkaFcL/+dK6M3N7L3XpzFS+sV2xf xWlw== X-Gm-Message-State: AOAM530A9xp8IyRvY+B+8c6Yp6n44w3nJqSNiXZbBnj9AeO05ATtzyzL Ta4ZR0YwCEP6mvl37Lt26XKc5WzIBO9yPw== X-Google-Smtp-Source: ABdhPJzeu6rL8xM16P/CSl2BL/IvijdU41KyHbFI7UbHBlymYBFyb1IXHhHDomzTCEjCCDRTNA5u6Q== X-Received: by 2002:a05:6870:610d:b0:e1:f70a:9e8a with SMTP id s13-20020a056870610d00b000e1f70a9e8amr3517070oae.120.1649233878429; Wed, 06 Apr 2022 01:31:18 -0700 (PDT) Received: from bertie ([172.58.102.145]) by smtp.gmail.com with ESMTPSA id n6-20020a9d6f06000000b005b266e43c92sm6534725otq.73.2022.04.06.01.31.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 01:31:18 -0700 (PDT) From: Rebecca Mckeever To: outreachy@lists.linux.dev Cc: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rebecca Mckeever Subject: [PATCH 1/4] staging: r8188eu: format comments in drivers/net style Date: Wed, 6 Apr 2022 03:30:57 -0500 Message-Id: X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Format comments according to the Linux kernerl coding style for drivers/net so they do not need to be reformatted after this driver is accepted into the drivers/net tree. Suggested-by: Larry Finger Signed-off-by: Rebecca Mckeever --- drivers/staging/r8188eu/core/rtw_cmd.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188= eu/core/rtw_cmd.c index 9b53b92c6795..9f5ece52bd39 100644 --- a/drivers/staging/r8188eu/core/rtw_cmd.c +++ b/drivers/staging/r8188eu/core/rtw_cmd.c @@ -11,8 +11,7 @@ #include "../include/rtw_mlme_ext.h" #include "../include/rtl8188e_dm.h" =20 -/* - * Caller and the rtw_cmd_thread can protect cmd_q by spin_lock. +/* Caller and the rtw_cmd_thread can protect cmd_q by spin_lock. * No irqsave is necessary. */ =20 @@ -96,8 +95,7 @@ static void _rtw_free_cmd_priv(struct cmd_priv *pcmdpriv) } } =20 -/* - * Calling Context: +/* Calling Context: * * rtw_enqueue_cmd can only be called between kernel thread, * since only spin_lock is used. @@ -317,8 +315,7 @@ int rtw_cmd_thread(void *context) return 0; } =20 -/* - * rtw_sitesurvey_cmd(~) +/* rtw_sitesurvey_cmd(~) * ### NOTE:#### (!!!!) * MUST TAKE CARE THAT BEFORE CALLING THIS FUNC, YOU SHOULD HAVE LOCKED pm= lmepriv->lock */ --=20 2.32.0 From nobody Fri Jun 19 08:29:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF11C433EF for ; Wed, 6 Apr 2022 12:34:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230382AbiDFMgB (ORCPT ); Wed, 6 Apr 2022 08:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233456AbiDFMdL (ORCPT ); Wed, 6 Apr 2022 08:33:11 -0400 Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B3E52CCB11 for ; Wed, 6 Apr 2022 01:31:22 -0700 (PDT) Received: by mail-oi1-x244.google.com with SMTP id t21so1665560oie.11 for ; Wed, 06 Apr 2022 01:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fx+PuhUmntAQYILd3k06PDbFUSS94nXmjRNZJ6v+95g=; b=HKuwVS9lBQumFrTvaBXETrUzSjYqNbjMNl7pjRJxlNVTM0LSCYzaoeuEG8wBiaBFh2 I95AWspuU1BhMxIJhwNJX5y+fgLxiysM0gGct2bDvLaOcaG/5esK2fH7GiynQDEv6ymA 9cVpFqDzbROrLCp3g2i7+cZp6Z5uA+Lviekv+ntvXIKi6ub2jBVcaFPOizk3j3PAXzPe jfcdjfQ9f0eH4a6/7Fdlhk25lXsmBeimghJ97EVtMjPmeSrBmPYU8zCMtANGZ8h/2CeV 8T2lxja9RJc9fbJHs11wVPP9sBEicq8ycbAJ7+Je1Hg49ZNob/GJn/mnBNsh14C2RlTY BRUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fx+PuhUmntAQYILd3k06PDbFUSS94nXmjRNZJ6v+95g=; b=M802F6HZ8cDler95k84VgBPnjl6dlLfaQMI32bm0JVYTAw0aIykLvYlzCN9wNLUWIv UB8pDkFi4iJQwCg5Yuc+Ke8iWKnekZy1ykudaHK9AhbgUWehABAKXYKZRLJ6blh7Mnhe aDki7xWyvkR4Fo38TzgkR+c4ZUc2PsO9+xWYkSeDvZvTVjkoYDIRmKVyiFtl2L71h70Q tub05r1Ml48JfgWtX0YN4sI8fnwa/jsf7j8JXJLoZmRUf/3s4lly71b8HpEgBZC9PD0H vNu3tKvWFpEMjnASVKhtuay8yPJYfxD1M6cqo9Dv+5ihHiWtWU2H9Int+HMm7MtctniW cYKA== X-Gm-Message-State: AOAM5305BtFtcU0JDJoEcmiB2+7bUrL7jeGuHx968rQSIT3pr7Hwi5r0 MoH/q6NTq7udrznGV8e2ZEU= X-Google-Smtp-Source: ABdhPJwqQwGchpMu2EMqAUxEdYcA9AXmytNB8OfGtkuDjeuI+izYShm5jyAzP89LrhVRvqqlRT7Y0A== X-Received: by 2002:a54:4518:0:b0:2ef:8719:b041 with SMTP id l24-20020a544518000000b002ef8719b041mr3263934oil.188.1649233881904; Wed, 06 Apr 2022 01:31:21 -0700 (PDT) Received: from bertie ([172.58.102.145]) by smtp.gmail.com with ESMTPSA id i28-20020a9d4a9c000000b005ce06a77de2sm6938116otf.48.2022.04.06.01.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 01:31:21 -0700 (PDT) From: Rebecca Mckeever To: outreachy@lists.linux.dev Cc: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rebecca Mckeever Subject: [PATCH 2/4] staging: r8188eu: remove extra 'the' Date: Wed, 6 Apr 2022 03:30:58 -0500 Message-Id: X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove repeated 'the' in comment to be grammatically correct and conform to Linux kernel coding style. Found with checkpatch: WARNING: Possible repeated word: 'the' Signed-off-by: Rebecca Mckeever --- drivers/staging/r8188eu/core/rtw_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188= eu/core/rtw_cmd.c index 9f5ece52bd39..cd20811ae152 100644 --- a/drivers/staging/r8188eu/core/rtw_cmd.c +++ b/drivers/staging/r8188eu/core/rtw_cmd.c @@ -519,7 +519,7 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wl= an_network *pnetwork) =20 psecnetwork->IELength =3D 0; /* Added by Albert 2009/02/18 */ - /* If the the driver wants to use the bssid to create the connection. */ + /* If the driver wants to use the bssid to create the connection. */ /* If not, we have to copy the connecting AP's MAC address to it so tha= t */ /* the driver just has the bssid information for PMKIDList searching. */ =20 --=20 2.32.0 From nobody Fri Jun 19 08:29:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75BF5C43219 for ; Wed, 6 Apr 2022 12:33:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232076AbiDFMey (ORCPT ); Wed, 6 Apr 2022 08:34:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233462AbiDFMdL (ORCPT ); Wed, 6 Apr 2022 08:33:11 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D62830AD9D for ; Wed, 6 Apr 2022 01:31:26 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id i11-20020a9d4a8b000000b005cda3b9754aso1245018otf.12 for ; Wed, 06 Apr 2022 01:31:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e2nIgPNh3LZLtjXU7XO/QsmWtjivZoy3EzJLLI+3/RM=; b=GzXIj9P51h2wKssIFpZU6VktIrPFOKUFfby38bTBRySx0eRoIGPrId2GUiPWIiEMeE OJ8yJvfDsmS5BptMR5Wz0Pfxau9wqrCmZYiyCL/SlO23cyUgvuUhwjidVX2qNpuKaA90 QkHPW2Rjp/8+w0S2n57adAl23CQ2GnQss6q1lUDOeKdOZ5wb3+n2hppUtC5oDWFB0vsa VPcQvsdb1KIf0iLdiEZn2cToz2bXUHhS9D+gpExEoCTRK8xqCJVZB2cc+/Zi9XYAQixJ 9EA/xE17zxKmzq04uPrLWE8l27kHJ+VsaBMtlCqCvEVheqeremAYugdoaq0+DKnin3gt uvFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e2nIgPNh3LZLtjXU7XO/QsmWtjivZoy3EzJLLI+3/RM=; b=taZRwepBIqLecRLed3PqkKd/77HUBTYLhZ9bQVEntQjihQiPSIHhZqpo4NzZ3qcfWD ZOAV22z/7JQhWtF3BNhITLjPH4KTKKdADHvgaLS90hnPdwIvwEK9tJ2PyAnsq6e2cZe3 E5CNJYhPSXj1Sp4ApxWDJg+ho45ss4OCO8RaDiWTXiRd7Ymc0hJNyTsF2k2vPv5Sd068 Pbx7fm34SObvDiv7N7UFYz/4zXQXba1zqUib3lV93gi6xKrfEoiBxcHiLzR/nFORJsAB mMZ6HguoOB8HZycD5pnxttwBG0Sm+3KB6fO3Ec7hghbYpvNn0r/gSE1z46951U0fd6Bd +7dA== X-Gm-Message-State: AOAM531o7DEk/B7k1MASnsTrB5O58PAYQtv7WQNhxY/smsIN1jD+CqhR xZ7V/RsUpHMWB/zcQEJVaDU= X-Google-Smtp-Source: ABdhPJzHhSgEnNlc69E9Z7Tfy3nTedvFPS05swID/wqc4IRETGcRigFh2BUGlaUy0LCA0mCqbdVKDA== X-Received: by 2002:a05:6830:201a:b0:5e6:8de6:9922 with SMTP id e26-20020a056830201a00b005e68de69922mr2543389otp.3.1649233885645; Wed, 06 Apr 2022 01:31:25 -0700 (PDT) Received: from bertie ([172.58.102.145]) by smtp.gmail.com with ESMTPSA id u22-20020a4ae696000000b0032158ab4ce9sm5877502oot.26.2022.04.06.01.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 01:31:25 -0700 (PDT) From: Rebecca Mckeever To: outreachy@lists.linux.dev Cc: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rebecca Mckeever , Dan Carpenter Subject: [PATCH 3/4] staging: r8188eu: correct misspelling in comment 'tppe' -> 'type' Date: Wed, 6 Apr 2022 03:30:59 -0500 Message-Id: X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Correct spelling typo. Suggested-by: Dan Carpenter Signed-off-by: Rebecca Mckeever --- drivers/staging/r8188eu/core/rtw_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188= eu/core/rtw_cmd.c index cd20811ae152..f4a277e6b654 100644 --- a/drivers/staging/r8188eu/core/rtw_cmd.c +++ b/drivers/staging/r8188eu/core/rtw_cmd.c @@ -1162,7 +1162,7 @@ u8 p2p_protocol_wk_cmd(struct adapter *padapter, int = intCmdType) } =20 pdrvextra_cmd_parm->ec_id =3D P2P_PROTO_WK_CID; - pdrvextra_cmd_parm->type_size =3D intCmdType; /* As the command tppe. */ + pdrvextra_cmd_parm->type_size =3D intCmdType; /* As the command type. */ pdrvextra_cmd_parm->pbuf =3D NULL; /* Must be NULL here */ =20 init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, GEN_CMD_CODE(_Set_Dr= v_Extra)); --=20 2.32.0 From nobody Fri Jun 19 08:29:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A747C433F5 for ; Wed, 6 Apr 2022 12:33:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231903AbiDFMeb (ORCPT ); Wed, 6 Apr 2022 08:34:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233469AbiDFMdM (ORCPT ); Wed, 6 Apr 2022 08:33:12 -0400 Received: from mail-oa1-x44.google.com (mail-oa1-x44.google.com [IPv6:2001:4860:4864:20::44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA5921DFDE6 for ; Wed, 6 Apr 2022 01:31:29 -0700 (PDT) Received: by mail-oa1-x44.google.com with SMTP id 586e51a60fabf-e1e5e8d9faso2172890fac.4 for ; Wed, 06 Apr 2022 01:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qrs+CFWmrW8BeESnOm/6cRIphI8Wl9VDHYuHbUM3OO4=; b=RORbisXWSMCQFYIFBfrpeCMwr6DsmVVdhLIStqeO9ldOQf3FAVH/P4CO0SqUK3kdQ2 PkArFpxrsdtjhuq1anbVuTAWRea9iDs3/ppC53RrfoBoryg66DS2jVwfpa9PjuktWnAq 4K9W76QM3hxCIV4IHeMZmOOD2uIJhuWxjWPA6wX56DhsyFg0Dp3Wva++8BHgP5SpyPlT rlA1P+HLOfNgO3rI26tNIp1l2GyamMnMguQP/29HLP/k+V4mDt4mOXu1IGOuQklWx2cq pQVx4ow2vtfm32r45vSAIGJtfMCq9ElNmlElf8Abkx+H51LQMXZdZuyQZ0fyptR0IcP9 SudA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qrs+CFWmrW8BeESnOm/6cRIphI8Wl9VDHYuHbUM3OO4=; b=t5Cyfnwz6eYT8VgnYNxhTbTQ2wNbvgVvBWXTONR57egaGmoU23eu94w5nJHW8pR+Rq 8S3KmuM/EdpQsmm5tjDzU/MdzhxOvRE0XN04IV245/xT7K6ZIZu418yR7QdjM8Fen+8/ pnujRko7wG62TNNNKcYH/gumiKmyxL841bDHv2dj7LeYzFPW2s4SWjQEcZCTl7EmPIQA uoSc87fC/EJJky6J5K8PQpdFhb7Yy6vdgWhM4tN2BcsKspOdjg2Olhx9pHyzMlcnWNcR +o0LRtOd+ZuDozfttN3DJafvzCD4rGVACw5dIIW2HGeCnQ5Ahe/1IkXVzTOyR4M/YqIX yIEQ== X-Gm-Message-State: AOAM530WfPACpMACtvJzdjozaZB2t5J9XYxxZNKsvNSFKDVrXgSOCx+N l/s0X667HhPy/mA9Qhd2g5s= X-Google-Smtp-Source: ABdhPJybWLBDvyaNTwqZZZ4PT6DF2PcM3Vg7gZhU9/SelxXcndU8UVYVwmUzYaZZX78gRgHAIO9+og== X-Received: by 2002:a05:6870:b6a6:b0:dd:999f:6596 with SMTP id cy38-20020a056870b6a600b000dd999f6596mr3384235oab.106.1649233889106; Wed, 06 Apr 2022 01:31:29 -0700 (PDT) Received: from bertie ([172.58.102.145]) by smtp.gmail.com with ESMTPSA id 190-20020a4a0dc7000000b003244ae0bbd5sm5835478oob.7.2022.04.06.01.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 01:31:28 -0700 (PDT) From: Rebecca Mckeever To: outreachy@lists.linux.dev Cc: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rebecca Mckeever Subject: [PATCH 4/4] staging: r8188eu: use sizeof(*pvar) for allocating structs Date: Wed, 6 Apr 2022 03:31:00 -0500 Message-Id: <5b526d8c178d89328de935ff4ff57651bdd8379b.1649233201.git.remckee0@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use sizeof(*pvar) instead of sizeof(struct var) when allocating memory. This conforms to Linux kernel coding style, improves readability, and decreases the opportunity for bugs if the pointer variable type is changed. Issue found by checkpatch messages of the following format: CHECK: Prefer kzalloc(sizeof(*pvar)...) over kzalloc(sizeof(struct var)...) Signed-off-by: Rebecca Mckeever Reviewed-by: Ira Weiny --- drivers/staging/r8188eu/core/rtw_cmd.c | 68 +++++++++++++------------- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188= eu/core/rtw_cmd.c index f4a277e6b654..110959148648 100644 --- a/drivers/staging/r8188eu/core/rtw_cmd.c +++ b/drivers/staging/r8188eu/core/rtw_cmd.c @@ -334,11 +334,11 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, stru= ct ndis_802_11_ssid *ssid, if (check_fwstate(pmlmepriv, _FW_LINKED)) p2p_ps_wk_cmd(padapter, P2P_PS_SCAN, 1); =20 - ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); + ph2c =3D kzalloc(sizeof(*ph2c), GFP_ATOMIC); if (!ph2c) return _FAIL; =20 - psurveyPara =3D kzalloc(sizeof(struct sitesurvey_parm), GFP_ATOMIC); + psurveyPara =3D kzalloc(sizeof(*psurveyPara), GFP_ATOMIC); if (!psurveyPara) { kfree(ph2c); return _FAIL; @@ -399,13 +399,13 @@ u8 rtw_setdatarate_cmd(struct adapter *padapter, u8 *= rateset) struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; u8 res =3D _SUCCESS; =20 - ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); + ph2c =3D kzalloc(sizeof(*ph2c), GFP_ATOMIC); if (!ph2c) { res =3D _FAIL; goto exit; } =20 - pbsetdataratepara =3D kzalloc(sizeof(struct setdatarate_parm), GFP_ATOMIC= ); + pbsetdataratepara =3D kzalloc(sizeof(*pbsetdataratepara), GFP_ATOMIC); if (!pbsetdataratepara) { kfree(ph2c); res =3D _FAIL; @@ -438,7 +438,7 @@ u8 rtw_createbss_cmd(struct adapter *padapter) =20 rtw_led_control(padapter, LED_CTL_START_TO_LINK); =20 - pcmd =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); + pcmd =3D kzalloc(sizeof(*pcmd), GFP_ATOMIC); if (!pcmd) { res =3D _FAIL; goto exit; @@ -475,7 +475,7 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wl= an_network *pnetwork) =20 rtw_led_control(padapter, LED_CTL_START_TO_LINK); =20 - pcmd =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); + pcmd =3D kzalloc(sizeof(*pcmd), GFP_ATOMIC); if (!pcmd) { res =3D _FAIL; goto exit; @@ -624,12 +624,12 @@ u8 rtw_setopmode_cmd(struct adapter *padapter, enum = ndis_802_11_network_infra n struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; u8 res =3D _SUCCESS; =20 - ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_KERNEL); + ph2c =3D kzalloc(sizeof(*ph2c), GFP_KERNEL); if (!ph2c) { res =3D false; goto exit; } - psetop =3D kzalloc(sizeof(struct setopmode_parm), GFP_KERNEL); + psetop =3D kzalloc(sizeof(*psetop), GFP_KERNEL); =20 if (!psetop) { kfree(ph2c); @@ -659,20 +659,20 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, u8 *ps= ta, u8 unicast_key) struct sta_info *sta =3D (struct sta_info *)psta; u8 res =3D _SUCCESS; =20 - ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_KERNEL); + ph2c =3D kzalloc(sizeof(*ph2c), GFP_KERNEL); if (!ph2c) { res =3D _FAIL; goto exit; } =20 - psetstakey_para =3D kzalloc(sizeof(struct set_stakey_parm), GFP_KERNEL); + psetstakey_para =3D kzalloc(sizeof(*psetstakey_para), GFP_KERNEL); if (!psetstakey_para) { kfree(ph2c); res =3D _FAIL; goto exit; } =20 - psetstakey_rsp =3D kzalloc(sizeof(struct set_stakey_rsp), GFP_KERNEL); + psetstakey_rsp =3D kzalloc(sizeof(*psetstakey_rsp), GFP_KERNEL); if (!psetstakey_rsp) { kfree(ph2c); kfree(psetstakey_para); @@ -718,13 +718,13 @@ u8 rtw_clearstakey_cmd(struct adapter *padapter, u8 *= psta, u8 entry, u8 enqueue) if (!enqueue) { clear_cam_entry(padapter, entry); } else { - ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); + ph2c =3D kzalloc(sizeof(*ph2c), GFP_ATOMIC); if (!ph2c) { res =3D _FAIL; goto exit; } =20 - psetstakey_para =3D kzalloc(sizeof(struct set_stakey_parm), + psetstakey_para =3D kzalloc(sizeof(*psetstakey_para), GFP_ATOMIC); if (!psetstakey_para) { kfree(ph2c); @@ -732,7 +732,7 @@ u8 rtw_clearstakey_cmd(struct adapter *padapter, u8 *ps= ta, u8 entry, u8 enqueue) goto exit; } =20 - psetstakey_rsp =3D kzalloc(sizeof(struct set_stakey_rsp), + psetstakey_rsp =3D kzalloc(sizeof(*psetstakey_rsp), GFP_ATOMIC); if (!psetstakey_rsp) { kfree(ph2c); @@ -765,13 +765,13 @@ u8 rtw_addbareq_cmd(struct adapter *padapter, u8 tid,= u8 *addr) struct addBaReq_parm *paddbareq_parm; u8 res =3D _SUCCESS; =20 - ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); + ph2c =3D kzalloc(sizeof(*ph2c), GFP_ATOMIC); if (!ph2c) { res =3D _FAIL; goto exit; } =20 - paddbareq_parm =3D kzalloc(sizeof(struct addBaReq_parm), GFP_ATOMIC); + paddbareq_parm =3D kzalloc(sizeof(*paddbareq_parm), GFP_ATOMIC); if (!paddbareq_parm) { kfree(ph2c); res =3D _FAIL; @@ -798,13 +798,13 @@ u8 rtw_dynamic_chk_wk_cmd(struct adapter *padapter) struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; u8 res =3D _SUCCESS; =20 - ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); + ph2c =3D kzalloc(sizeof(*ph2c), GFP_ATOMIC); if (!ph2c) { res =3D _FAIL; goto exit; } =20 - pdrvextra_cmd_parm =3D kzalloc(sizeof(struct drvextra_cmd_parm), GFP_ATOM= IC); + pdrvextra_cmd_parm =3D kzalloc(sizeof(*pdrvextra_cmd_parm), GFP_ATOMIC); if (!pdrvextra_cmd_parm) { kfree(ph2c); res =3D _FAIL; @@ -839,7 +839,7 @@ u8 rtw_set_chplan_cmd(struct adapter *padapter, u8 chpl= an) } =20 /* prepare cmd parameter */ - setChannelPlan_param =3D kzalloc(sizeof(struct SetChannelPlan_param), + setChannelPlan_param =3D kzalloc(sizeof(*setChannelPlan_param), GFP_KERNEL); if (!setChannelPlan_param) { res =3D _FAIL; @@ -848,7 +848,7 @@ u8 rtw_set_chplan_cmd(struct adapter *padapter, u8 chpl= an) setChannelPlan_param->channel_plan =3D chplan; =20 /* need enqueue, prepare cmd_obj and enqueue */ - pcmdobj =3D kzalloc(sizeof(struct cmd_obj), GFP_KERNEL); + pcmdobj =3D kzalloc(sizeof(*pcmdobj), GFP_KERNEL); if (!pcmdobj) { kfree(setChannelPlan_param); res =3D _FAIL; @@ -1010,13 +1010,13 @@ u8 rtw_lps_ctrl_wk_cmd(struct adapter *padapter, u8= lps_ctrl_type, u8 enqueue) /* return res; */ =20 if (enqueue) { - ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); + ph2c =3D kzalloc(sizeof(*ph2c), GFP_ATOMIC); if (!ph2c) { res =3D _FAIL; goto exit; } =20 - pdrvextra_cmd_parm =3D kzalloc(sizeof(struct drvextra_cmd_parm), + pdrvextra_cmd_parm =3D kzalloc(sizeof(*pdrvextra_cmd_parm), GFP_ATOMIC); if (!pdrvextra_cmd_parm) { kfree(ph2c); @@ -1056,13 +1056,13 @@ u8 rtw_rpt_timer_cfg_cmd(struct adapter *padapter, = u16 min_time) =20 u8 res =3D _SUCCESS; =20 - ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); + ph2c =3D kzalloc(sizeof(*ph2c), GFP_ATOMIC); if (!ph2c) { res =3D _FAIL; goto exit; } =20 - pdrvextra_cmd_parm =3D kzalloc(sizeof(struct drvextra_cmd_parm), + pdrvextra_cmd_parm =3D kzalloc(sizeof(*pdrvextra_cmd_parm), GFP_ATOMIC); if (!pdrvextra_cmd_parm) { kfree(ph2c); @@ -1109,13 +1109,13 @@ u8 rtw_antenna_select_cmd(struct adapter *padapter,= u8 antenna, u8 enqueue) return res; =20 if (enqueue) { - ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_KERNEL); + ph2c =3D kzalloc(sizeof(*ph2c), GFP_KERNEL); if (!ph2c) { res =3D _FAIL; goto exit; } =20 - pdrvextra_cmd_parm =3D kzalloc(sizeof(struct drvextra_cmd_parm), + pdrvextra_cmd_parm =3D kzalloc(sizeof(*pdrvextra_cmd_parm), GFP_KERNEL); if (!pdrvextra_cmd_parm) { kfree(ph2c); @@ -1148,13 +1148,13 @@ u8 p2p_protocol_wk_cmd(struct adapter *padapter, in= t intCmdType) if (rtw_p2p_chk_state(pwdinfo, P2P_STATE_NONE)) return res; =20 - ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); + ph2c =3D kzalloc(sizeof(*ph2c), GFP_ATOMIC); if (!ph2c) { res =3D _FAIL; goto exit; } =20 - pdrvextra_cmd_parm =3D kzalloc(sizeof(struct drvextra_cmd_parm), GFP_ATOM= IC); + pdrvextra_cmd_parm =3D kzalloc(sizeof(*pdrvextra_cmd_parm), GFP_ATOMIC); if (!pdrvextra_cmd_parm) { kfree(ph2c); res =3D _FAIL; @@ -1182,13 +1182,13 @@ u8 rtw_ps_cmd(struct adapter *padapter) =20 u8 res =3D _SUCCESS; =20 - ppscmd =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); + ppscmd =3D kzalloc(sizeof(*ppscmd), GFP_ATOMIC); if (!ppscmd) { res =3D _FAIL; goto exit; } =20 - pdrvextra_cmd_parm =3D kzalloc(sizeof(struct drvextra_cmd_parm), GFP_ATOM= IC); + pdrvextra_cmd_parm =3D kzalloc(sizeof(*pdrvextra_cmd_parm), GFP_ATOMIC); if (!pdrvextra_cmd_parm) { kfree(ppscmd); res =3D _FAIL; @@ -1253,13 +1253,13 @@ u8 rtw_chk_hi_queue_cmd(struct adapter *padapter) struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; u8 res =3D _SUCCESS; =20 - ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); + ph2c =3D kzalloc(sizeof(*ph2c), GFP_ATOMIC); if (!ph2c) { res =3D _FAIL; goto exit; } =20 - pdrvextra_cmd_parm =3D kzalloc(sizeof(struct drvextra_cmd_parm), GFP_ATOM= IC); + pdrvextra_cmd_parm =3D kzalloc(sizeof(*pdrvextra_cmd_parm), GFP_ATOMIC); if (!pdrvextra_cmd_parm) { kfree(ph2c); res =3D _FAIL; @@ -1284,13 +1284,13 @@ u8 rtw_c2h_wk_cmd(struct adapter *padapter, u8 *c2h= _evt) struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; u8 res =3D _SUCCESS; =20 - ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); + ph2c =3D kzalloc(sizeof(*ph2c), GFP_ATOMIC); if (!ph2c) { res =3D _FAIL; goto exit; } =20 - pdrvextra_cmd_parm =3D kzalloc(sizeof(struct drvextra_cmd_parm), GFP_ATOM= IC); + pdrvextra_cmd_parm =3D kzalloc(sizeof(*pdrvextra_cmd_parm), GFP_ATOMIC); if (!pdrvextra_cmd_parm) { kfree(ph2c); res =3D _FAIL; --=20 2.32.0