From nobody Fri Jun 19 14:32:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A914DC433F5 for ; Sat, 2 Apr 2022 08:51:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353929AbiDBIxM (ORCPT ); Sat, 2 Apr 2022 04:53:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353915AbiDBIxB (ORCPT ); Sat, 2 Apr 2022 04:53:01 -0400 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D048014966C for ; Sat, 2 Apr 2022 01:51:10 -0700 (PDT) Received: by mail-oi1-x241.google.com with SMTP id j83so5069947oih.6 for ; Sat, 02 Apr 2022 01:51:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9I03BMhkhj8iUIyy6XKaip4rxh8dASQlWGBFPFtcJdU=; b=FTQnQB4RlP3zZc8B3BA+1eM/3K0wyc2lKQ8spNFzXfOuhkw+LPAo3EenZqAm3VsLNG O6MYIFrLuWy/9kEp8Fx5FPl4IJyWLlWRnaRJIR4xYrBPv21tH9G8DR6tIYqxLf5ohudb 4VOxLKrfGtiCogxWe5huTcVVtFWVLWJ9gWyxAbPm0Hvb6Cc1JA2BzYyv1GDxzTgN6cR5 snTCDBmZN1gTH9c9pkUFjpWEJNg6Qj0R2FK8XjwXQN7wb4l1gES6PkoQhqWpJq92rSK8 eWJdudwWL3Bvpsx33/QU0sW6fLMdy+3SUGV8C0jJGZ1ROd/nYZiLdBCHHu+FhkdZdg3R pm8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9I03BMhkhj8iUIyy6XKaip4rxh8dASQlWGBFPFtcJdU=; b=e8CZ8x+IYJQBSWv/6B1gCq5GTv4yzz1vUrqjFKacUiBLhAIRwQWgsPY0Mb5QOpgV0L QebzI6mVlEDTyIMGtn7ZXCvZ9hJ8wQYCn3eb7cbhbuZf5ycDCjAp4hP8TUEXjvufpC7n AssKiQN3lcDECeZoQPGGK4Al8ckV4z7TCJPu/CXKX/ela48fTVS4b0ktGiL5evAnsvjR R+6ljUYDXLv9Y1BrjAl5i0uKHgoYzsfDZkP/dux7+CEVMQ+f7YaBLdtD1JhbsBmLUf63 4IGfdYbJpsqcUpc/BEbKuicYG4vNOh6LxgrHqoN4ThU+3wed+8c15Itqj7sdAjpQSg2E z1uQ== X-Gm-Message-State: AOAM533tDBqaOLf8BLijVnFF8Xy7IczvrvY1VPL9Qts8KPQ38EH6bdVS nH8FNxeroKsWzIDeU6ITaY15vYxfUe3OTA== X-Google-Smtp-Source: ABdhPJxcoDXIsrCQCP2NXq0IjEK+agNI7HeBDOb9L7IomsnximUZErN4osvarEdwaze5cYmP7ka5bw== X-Received: by 2002:a05:6808:9ae:b0:2d9:a01a:4bf4 with SMTP id e14-20020a05680809ae00b002d9a01a4bf4mr6201939oig.283.1648889470205; Sat, 02 Apr 2022 01:51:10 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id o18-20020a9d7652000000b005cbf6f5d7c5sm2146637otl.21.2022.04.02.01.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Apr 2022 01:51:09 -0700 (PDT) From: Rebecca Mckeever To: outreachy@lists.linux.dev Cc: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rebecca Mckeever Subject: [PATCH 1/6] staging: r8188eu: place constants on the right side of tests Date: Sat, 2 Apr 2022 03:50:43 -0500 Message-Id: <0f3db3586b3668d6d784e075bc52ffd88b0920d2.1648888461.git.remckee0@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Conform to Linux kernel coding style. Reported by checkpatch: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: Rebecca Mckeever --- drivers/staging/r8188eu/core/rtw_cmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188= eu/core/rtw_cmd.c index 4fda2fe07ecc..3b282c387282 100644 --- a/drivers/staging/r8188eu/core/rtw_cmd.c +++ b/drivers/staging/r8188eu/core/rtw_cmd.c @@ -189,7 +189,7 @@ u32 rtw_enqueue_cmd(struct cmd_priv *pcmdpriv, struct c= md_obj *cmd_obj) cmd_obj->padapter =3D padapter; =20 res =3D rtw_cmd_filter(pcmdpriv, cmd_obj); - if (_FAIL =3D=3D res) { + if (res =3D=3D _FAIL) { rtw_free_cmd_obj(cmd_obj); goto exit; } @@ -260,7 +260,7 @@ int rtw_cmd_thread(void *context) if (!pcmd) continue; =20 - if (_FAIL =3D=3D rtw_cmd_filter(pcmdpriv, pcmd)) { + if (rtw_cmd_filter(pcmdpriv, pcmd) =3D=3D _FAIL) { pcmd->res =3D H2C_DROPPED; goto post_process; } @@ -613,7 +613,7 @@ u8 rtw_disassoc_cmd(struct adapter *padapter, u32 deaut= h_timeout_ms, bool enqueu res =3D rtw_enqueue_cmd(cmdpriv, cmdobj); } else { /* no need to enqueue, do the cmd hdl directly and free cmd parameter */ - if (H2C_SUCCESS !=3D disconnect_hdl(padapter, (u8 *)param)) + if (disconnect_hdl(padapter, (u8 *)param) !=3D H2C_SUCCESS) res =3D _FAIL; kfree(param); } --=20 2.32.0 From nobody Fri Jun 19 14:32:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B5ACC433F5 for ; Sat, 2 Apr 2022 08:51:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353956AbiDBIxQ (ORCPT ); Sat, 2 Apr 2022 04:53:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353934AbiDBIxG (ORCPT ); Sat, 2 Apr 2022 04:53:06 -0400 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9351314FFD1 for ; Sat, 2 Apr 2022 01:51:14 -0700 (PDT) Received: by mail-oi1-x243.google.com with SMTP id w127so5045634oig.10 for ; Sat, 02 Apr 2022 01:51:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MnmEBkloSHxQt/4YP7PohGytgpfueUHdKvsK8QotGQ0=; b=bSUF+T6m6TZymW/6Wb3e8wkKFvcZMEkZvwlXT+EzejOuvoApmEaDlLRib5EjIP5xBp LHZjSri2RAUbsK0VbAujyS5fmXDRCCSxqgs2FzLzkVXnsKMHpeg6pdGdOIFlGEgmI4Ju /OihV5mpOOlvMAPKev2s7vQTIOAakWpFrk40DXNLPrT6H2HSREZ4orVymdr/n4zjXxth IQgRWyzFBVFrHZjAt2AsaSnbEJuLjCidXcEFk8JTWvlIxyeP6xAEVqe1/p0HmnP30U/B 1yy+NbCsSXOX9MWaX+fpUzhlnkvMInsRpeDg8WWeqnnaVdRoQewnQFG1rehzWpbljkKj 8M2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MnmEBkloSHxQt/4YP7PohGytgpfueUHdKvsK8QotGQ0=; b=NE9+SaKS0roNJ0CX6SSOZZaXmKLBtkd16KUvLiTdafu9XcNwC1PG9y4g+K5H1kviAW hONSBJ6eYGLGpgDDdHxRrjg2oQkQlaFId8rW5/NIeJ4NeYiWGnB6P2HmHDSoGmcP++nz swy/XYDQ8nKgjETJMZTVXGe9otCg9F7GYAXRpwfeXgJ545OMaHnKDx6fSCr/NlmYhyD7 ZeMznpLDafu0CvCvTGgBEJMQF1ne5cIg7sdKJu5G3TIDS1xpQ65gYZvtPRhHJYUH/gfC DkgPZWlXZgbwwEl56UFK6VjWYlcDe3NT2JoUeggfXTKjcjIOfmeCk/7umGXB6A3uF5y0 fZTA== X-Gm-Message-State: AOAM5311Hh+73RK3CN31jKa3LCXqKgOd4ZQXeHg3tjzn1/BG/NxnQ2mZ Tu0ys3ni/YbR9g5pxzuAH/A= X-Google-Smtp-Source: ABdhPJx9yj1rO/Fdh8dSjci4ZXIejhpZSiiX374O4S5O1esXJBrQRrMtoB1jCwL7nKArO6F3UoeXHg== X-Received: by 2002:a05:6808:ec3:b0:2ef:895e:752a with SMTP id q3-20020a0568080ec300b002ef895e752amr6373419oiv.12.1648889473986; Sat, 02 Apr 2022 01:51:13 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id x18-20020a056830245200b005ce01c28c77sm2108550otr.1.2022.04.02.01.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Apr 2022 01:51:13 -0700 (PDT) From: Rebecca Mckeever To: outreachy@lists.linux.dev Cc: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rebecca Mckeever Subject: [PATCH 2/6] staging: r8188eu: remove else after return Date: Sat, 2 Apr 2022 03:50:44 -0500 Message-Id: <84db0348481b54f58cb0b6200fa9ae471ee06b3b.1648888461.git.remckee0@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Conform to Linux kernel coding style. Reported by checkpatch: WARNING: else is not generally useful after a break or return Signed-off-by: Rebecca Mckeever --- drivers/staging/r8188eu/core/rtw_cmd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188= eu/core/rtw_cmd.c index 3b282c387282..09fde5b23ce2 100644 --- a/drivers/staging/r8188eu/core/rtw_cmd.c +++ b/drivers/staging/r8188eu/core/rtw_cmd.c @@ -1427,8 +1427,10 @@ void rtw_disassoc_cmd_callback(struct adapter *padap= ter, struct cmd_obj *pcmd) spin_unlock_bh(&pmlmepriv->lock); =20 return; - } else /* clear bridge database */ - nat25_db_cleanup(padapter); + } + + /* clear bridge database */ + nat25_db_cleanup(padapter); =20 /* free cmd */ rtw_free_cmd_obj(pcmd); --=20 2.32.0 From nobody Fri Jun 19 14:32:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A02CDC433F5 for ; Sat, 2 Apr 2022 08:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353970AbiDBIxX (ORCPT ); Sat, 2 Apr 2022 04:53:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353945AbiDBIxK (ORCPT ); Sat, 2 Apr 2022 04:53:10 -0400 Received: from mail-oa1-x41.google.com (mail-oa1-x41.google.com [IPv6:2001:4860:4864:20::41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E4081544BC for ; Sat, 2 Apr 2022 01:51:18 -0700 (PDT) Received: by mail-oa1-x41.google.com with SMTP id 586e51a60fabf-de48295467so5195495fac.2 for ; Sat, 02 Apr 2022 01:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vf9XrnRNNEu/g7WX3Cp+ZJwmHe6lW1eduApC7K6BbhE=; b=j4xXeAsTbXwdT377xyxJfFrgd59iWXp7ELSyJv/EanKnQ6DUqM7TKGIHzdUAJwBhho IfP92/Mu4xkb7coNtVbXepdb/BDiVtnO/ri84k0s5IenWecqphAeZiDhCpKLiikTU+Le iJxeo8FeZ5r55plXaqBWsRyfw9tioVsq2pyYtxMggElcaVnSqMJ4rjjgn1lnJ2bmnACv m6HfGppRv2L5jJYOFopWEj9iTHX1qjv1kHfy3BOqaZg1vPUL6Vwx7TQ48KeRQfZmrEc9 8p8IPjIaOIflSh+Klx1YPKYCicJ4SqF7Ep6mWy6uzd/Tur6gHbU4eZjvbZwcukbbeZBb t+mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vf9XrnRNNEu/g7WX3Cp+ZJwmHe6lW1eduApC7K6BbhE=; b=2MgqSbUSEk8FOF29ZnkHsY0RzNK9RlJ18zpReLeg39s9JpgAVWqaAz2+nJ3JPiJULt tl9Mx3mJrtn8upsTrrm8jrFMCo3FNnzohAnHU8X2Z/K51VPmQNB1T/RSgej1f09MTjrr TYelcVPE0Upi7xBHLvqtUKyy+ZwJF/ChTIZEDOLOxy4M+Pk9z9haTHQa5goOSD8tHYLq I2BBJ3a6bMklCtCtTdBaF188yybvhAloFJnOzrj8Tj8oKC5aIJBgrwXxbQZ+mk2WxJ5W oTypWMPp7PmACoFd8/d6rj1sQpl/3ioz2OpJMK60STVSP7beb8hW27yUDGmT/OWaJRZB lXwQ== X-Gm-Message-State: AOAM531ep+DVE0tad62DCnmke/ApjxJVzgmocDsmU7Td5sOx/tgDb9l4 i8h2GAuU1v/pjiZ1zilKxqJ5QWzaY+F+EA== X-Google-Smtp-Source: ABdhPJz0isEyVWmgEv8MhEfi7jtm1pbgdsRBYf6wjvSELYX1zdlwt+fTQ0mw2iorYuRZP969f1KQXw== X-Received: by 2002:a05:6871:787:b0:df:f1a:2d9c with SMTP id o7-20020a056871078700b000df0f1a2d9cmr6599085oap.1.1648889477542; Sat, 02 Apr 2022 01:51:17 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id bg39-20020a056820082700b00324c8eba341sm2074930oob.18.2022.04.02.01.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Apr 2022 01:51:17 -0700 (PDT) From: Rebecca Mckeever To: outreachy@lists.linux.dev Cc: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rebecca Mckeever Subject: [PATCH 3/6] staging: r8188eu: correct misspelling in comment "conider" -> "consider" Date: Sat, 2 Apr 2022 03:50:45 -0500 Message-Id: <5799315f84e50db2a7d05b74cd4ed9ec2f28a8e2.1648888461.git.remckee0@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Correct spelling typo. Reported by checkpatch: CHECK: 'conider' may be misspelled - perhaps 'consider'? Signed-off-by: Rebecca Mckeever --- drivers/staging/r8188eu/core/rtw_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188= eu/core/rtw_cmd.c index 09fde5b23ce2..2e135bbd836a 100644 --- a/drivers/staging/r8188eu/core/rtw_cmd.c +++ b/drivers/staging/r8188eu/core/rtw_cmd.c @@ -293,7 +293,7 @@ int rtw_cmd_thread(void *context) rtw_free_cmd_obj(pcmd); else /* todo: !!! fill rsp_buf to pcmd->rsp if (pcmd->rsp!=3D NULL) */ - pcmd_callback(pcmd->padapter, pcmd);/* need conider that free cmd_obj = in rtw_cmd_callback */ + pcmd_callback(pcmd->padapter, pcmd);/* need consider that free cmd_obj= in rtw_cmd_callback */ } else { rtw_free_cmd_obj(pcmd); } --=20 2.32.0 From nobody Fri Jun 19 14:32:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC80C433F5 for ; Sat, 2 Apr 2022 08:51:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353981AbiDBIx0 (ORCPT ); Sat, 2 Apr 2022 04:53:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353946AbiDBIxM (ORCPT ); Sat, 2 Apr 2022 04:53:12 -0400 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE3E41544BC for ; Sat, 2 Apr 2022 01:51:20 -0700 (PDT) Received: by mail-oi1-x241.google.com with SMTP id i7so5060806oie.7 for ; Sat, 02 Apr 2022 01:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dsvg2OPb+FuOq6QpPd6PmHwu11pbVJX0wlikRs5/Wus=; b=RGOfLxghPwV+kPX7AQTR+zDf/CJEWHKRESbsvHUIpiBM6PEga0LCzHFs66cHxpzgKm jsvZLVPrNUTRm9n52Qz8RmGluY2lEVgCxoko5jofqv3ei1S9+m9iOOmQuxP8GBZPaxQX YCOLiVl9utI4JNC9PuBKgqa6Ynmy5nwIlJloCA+DwI4Pf8n1oWzWz+u0aMfOpLIuRGje POK1WBHC+bKlEVFdyqS7U7YsAWSKOnNtTecYR830P3bwcWQCGH8NmZ29MoHBMtTDn/mx OORf/gDhMe1uKP0C96pbWUUWdE8WP3ak5JdiTaS5luhJIje71/O4hXJFXhKbm7tUMiMH UCaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dsvg2OPb+FuOq6QpPd6PmHwu11pbVJX0wlikRs5/Wus=; b=YErGdGVW0tg1VUWNK3jD9/rMXP0LMGCKKRcUCFgmm1SpHmz29UDkDTHksfDQEovMWy cDqaQ2CVZV19/dKRKmsCyUg8EUtvVgSJpAtQPg7KfHWeEFSbsNvq6V3Itu39WaQyDkgl gCAJy9+ZdQys3C8h9hLOEiq2w8LODF6H30kv0vqUgruuX3lGNd6ocPU+ZrLP03IjonXk doNLZUEjG/U3YvWdDBKXCDW645uFD0WpruyGIJBrH5vztzxJ2Az2HlMmkTghP76tKOGq 9IkhuvWYKUlXMW8mMKRZR3OPaBalKtlTV11YtIEjdbyL2kOtkH3Ly9BiWTH/WYyNSuP2 //FA== X-Gm-Message-State: AOAM532LR/XIVQyA+N/Oa6Lvomp7sXvPR+XEqY09K/LVnS7HtotE2myg khVOedt+JnpgiY7Fbc14sb8= X-Google-Smtp-Source: ABdhPJwoPr/yNxlNco+MBnjGbe6z2GYhCoF34vsMysOvLuORVPIv7QjCe6vQqUcHd8o8Nyro437AZw== X-Received: by 2002:a05:6808:1883:b0:2da:3ed2:68cf with SMTP id bi3-20020a056808188300b002da3ed268cfmr6561466oib.204.1648889480241; Sat, 02 Apr 2022 01:51:20 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id q11-20020a4a330b000000b003289cbe97c6sm2057675ooq.13.2022.04.02.01.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Apr 2022 01:51:19 -0700 (PDT) From: Rebecca Mckeever To: outreachy@lists.linux.dev Cc: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rebecca Mckeever Subject: [PATCH 4/6] staging: r8188eu: format block comments Date: Sat, 2 Apr 2022 03:50:46 -0500 Message-Id: <0387f3df49d89c17acf96cf072e70c98e81e58f7.1648888462.git.remckee0@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add ' * ' or ' ' to beginning of block comment lines to conform to Linux kernel coding style. Reported by checkpatch: WARNING: Block comments use * on subsequent lines Signed-off-by: Rebecca Mckeever --- drivers/staging/r8188eu/core/rtw_cmd.c | 29 +++++++++++++------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188= eu/core/rtw_cmd.c index 2e135bbd836a..0c659b40aa1c 100644 --- a/drivers/staging/r8188eu/core/rtw_cmd.c +++ b/drivers/staging/r8188eu/core/rtw_cmd.c @@ -12,9 +12,9 @@ #include "../include/rtl8188e_dm.h" =20 /* -Caller and the rtw_cmd_thread can protect cmd_q by spin_lock. -No irqsave is necessary. -*/ + * Caller and the rtw_cmd_thread can protect cmd_q by spin_lock. + * No irqsave is necessary. + */ =20 static int _rtw_init_cmd_priv(struct cmd_priv *pcmdpriv) { @@ -97,14 +97,13 @@ static void _rtw_free_cmd_priv(struct cmd_priv *pcmdpri= v) } =20 /* -Calling Context: - -rtw_enqueue_cmd can only be called between kernel thread, -since only spin_lock is used. - -ISR/Call-Back functions can't call this sub-function. - -*/ + * Calling Context: + * + * rtw_enqueue_cmd can only be called between kernel thread, + * since only spin_lock is used. + * + * ISR/Call-Back functions can't call this sub-function. + */ =20 static int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj) { @@ -319,10 +318,10 @@ int rtw_cmd_thread(void *context) } =20 /* -rtw_sitesurvey_cmd(~) - ### NOTE:#### (!!!!) - MUST TAKE CARE THAT BEFORE CALLING THIS FUNC, YOU SHOULD HAVE LOCKED pmlm= epriv->lock -*/ + * rtw_sitesurvey_cmd(~) + * ### NOTE:#### (!!!!) + * MUST TAKE CARE THAT BEFORE CALLING THIS FUNC, YOU SHOULD HAVE LOCKED pm= lmepriv->lock + */ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *= ssid, int ssid_num, struct rtw_ieee80211_channel *ch, int ch_num) { --=20 2.32.0 From nobody Fri Jun 19 14:32:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AFABC433F5 for ; Sat, 2 Apr 2022 08:51:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354021AbiDBIx3 (ORCPT ); Sat, 2 Apr 2022 04:53:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353950AbiDBIxO (ORCPT ); Sat, 2 Apr 2022 04:53:14 -0400 Received: from mail-oa1-x41.google.com (mail-oa1-x41.google.com [IPv6:2001:4860:4864:20::41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F374156C5D for ; Sat, 2 Apr 2022 01:51:23 -0700 (PDT) Received: by mail-oa1-x41.google.com with SMTP id 586e51a60fabf-deb9295679so5170751fac.6 for ; Sat, 02 Apr 2022 01:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CwyPQSB+WJYU+JkcFUBBvDrf5lBS4YcYc8z0W7DhRMo=; b=DubTEXg4Iq97boyWsG+ES8tg2dBvQdNgO7s3bOR3PAhTsUm1TPc9GqibMunWyFkQi1 PAI1grvSPXOAr+LAkhzoE9m4j2fFaPhxX5+pBWv+ACUTBfb7C3yN6RBFKN904E1kcd7E Ii2z18jwsn2VBVRFK9WpYDgT8sWHlPTjAymqlKRf3WZMpwBY6kqAkxnZpgOkewJEI9KD pGuZspgQa779EjH7glXXnpPTH6sfDvaz3p6wgmYX4cKAGwKUlVhq/q61A4HTKuOW3GMC wPeeeX5IayCzDGxTxIq9aO/n8Bw6x/82NDSVwTKaXJI9R+K0X64ucEL8MsA0Ye2Vm1IF gmMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CwyPQSB+WJYU+JkcFUBBvDrf5lBS4YcYc8z0W7DhRMo=; b=XFQDBRLY4n0M++qB8iJKU4ViULTvkSxEkzou/ygCInXunYf60zMN9z4Ee2QdRkHR2U lJO6yyxnXxUyi4RRpQ4qNeikSlznp5t/8sgZFPbb412eMWq3cqaWrpeb21tJCi+M1Qeb uKxbW9gBpPixnZD9XIZxpFL/+1kFTsdwoPxArxFJSWdhGfxSglreBWLvCZq/osoOmpaq aTBmwxNeG/EzeZj+u2HI6ycqI8RrPzxuGmghJnjZMAdwoodDtztGszIsXN5yMdO0NoYF eHmkyu3X07C4WHqL+XSZTTDdOUU81ZZuq3FtKL/7Xa3rdyrMlEzJTAQdXfy4A6uk9jdf uzwQ== X-Gm-Message-State: AOAM533VXHXlTXcmAnTjE5J3PekBJcXJvc11F7VXfCmk0O3UB9yeb272 cFLzfQQFzysocXJUiJhdZQE= X-Google-Smtp-Source: ABdhPJwHvzC34/jLXSMJglm+fac8tsDNLvgYbrYDMZAEB1F1P7UFN/NhraLjOGiAk2qNsFmMimowsQ== X-Received: by 2002:a05:6870:e2c9:b0:dd:b78a:82cd with SMTP id w9-20020a056870e2c900b000ddb78a82cdmr6912349oad.50.1648889482790; Sat, 02 Apr 2022 01:51:22 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id m5-20020a056870194500b000d9a0818925sm1911593oak.25.2022.04.02.01.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Apr 2022 01:51:22 -0700 (PDT) From: Rebecca Mckeever To: outreachy@lists.linux.dev Cc: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rebecca Mckeever Subject: [PATCH 5/6] staging: r8188eu: remove unnecessary braces in conditional statements Date: Sat, 2 Apr 2022 03:50:47 -0500 Message-Id: <2b46501bb3965a8cf27e7134407c50551c36b7e8.1648888462.git.remckee0@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Conform to Linux kernel coding style. Reported by checkpatch: WARNING: braces {} are not necessary for single statement blocks WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Rebecca Mckeever --- drivers/staging/r8188eu/core/rtw_cmd.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188= eu/core/rtw_cmd.c index 0c659b40aa1c..832bf25b1a83 100644 --- a/drivers/staging/r8188eu/core/rtw_cmd.c +++ b/drivers/staging/r8188eu/core/rtw_cmd.c @@ -331,13 +331,11 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, stru= ct ndis_802_11_ssid *ssid, struct cmd_priv *pcmdpriv =3D &padapter->cmdpriv; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 - if (check_fwstate(pmlmepriv, _FW_LINKED)) { + if (check_fwstate(pmlmepriv, _FW_LINKED)) rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_SCAN, 1); - } =20 - if (check_fwstate(pmlmepriv, _FW_LINKED)) { + if (check_fwstate(pmlmepriv, _FW_LINKED)) p2p_ps_wk_cmd(padapter, P2P_PS_SCAN, 1); - } =20 ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); if (!ph2c) @@ -517,11 +515,10 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct = wlan_network *pnetwork) =20 psecuritypriv->authenticator_ie[0] =3D (unsigned char)psecnetwork->IELeng= th; =20 - if (psecnetwork->IELength - 12 < 255) { + if (psecnetwork->IELength - 12 < 255) memcpy(&psecuritypriv->authenticator_ie[1], &psecnetwork->IEs[12], psecn= etwork->IELength - 12); - } else { + else memcpy(&psecuritypriv->authenticator_ie[1], &psecnetwork->IEs[12], 255); - } =20 psecnetwork->IELength =3D 0; /* Added by Albert 2009/02/18 */ --=20 2.32.0 From nobody Fri Jun 19 14:32:31 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 306ECC433EF for ; Sat, 2 Apr 2022 08:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353987AbiDBIxc (ORCPT ); Sat, 2 Apr 2022 04:53:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353961AbiDBIxS (ORCPT ); Sat, 2 Apr 2022 04:53:18 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB650156C7D for ; Sat, 2 Apr 2022 01:51:25 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id o20-20020a9d7194000000b005cb20cf4f1bso3692790otj.7 for ; Sat, 02 Apr 2022 01:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ldid4ljpTipmsQhOv6JPWoqFhKtbXsLDYhk2KntAovc=; b=KAFQGvZ0NJ9rVgGYrPkiRPInodeyew81EEkXVadDRY8N6ktZRH5Iqs0gGptd9EAKuV 6DEo+8wnwOddDm5nibVVRniAPDTbdG17FbEYMgEA+AbRQwJ/wzei2H3fxkHWEZ0ULFis KOZsrbpkCnfNEPpgbO4LXQnlQHw7QBL18Yqo0mPBEYs2rv1vhRW/sz59H95Jdsh4F6NO pPxC15AqnyFI8YjGJhBU6ekW88/fQk015anivwUZIZeIvTB6Rh0RCsp+bXIi0/ua1ZTl hOaPZC82HOlxvXkey8SypmVvqqbyOcrjYe9WUxDANfP0q7Y9QWCn1RQQxfWn7gNRG+5Q 807Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ldid4ljpTipmsQhOv6JPWoqFhKtbXsLDYhk2KntAovc=; b=KlXW3xDgEKkFeSGyyBq8VBuJ6yWNXzMT0QtLb8vPgHiw+Onz9NFL0ZTpj6qYwSPgfN PT6b4+xt0OdogxZkVQISKDaSd4wLNuNAGVtfd6JlILwAs9N2BdXnQIHmPglU1+qY4RjN 3inS52C5FpNMVbZDjoYexsBI63HxyYszrq1Hrcy6ovh/ZAqm2GKgcBTrgDeLdz2kst/A 1tVE0ckaKn/VCSrhUMctICUBQ9LPWaIzrWpNQgOrUwkeZhSJSZvXobriwchhcz7nPDB/ 6iCMeAT9IKmhf9dglfDM/1cy+rzcY1h+rMvy/kiAlPI1OayAiZQ95mi6wG1xRRfVBYPv 4LXA== X-Gm-Message-State: AOAM530B/RgXnTkmctntMOFFQI3zNo7yAqU6nBVmwt2hnfHIkcER5HDO jZJHnpJDUonRyvekcznXyHqHnEifWhqtdA== X-Google-Smtp-Source: ABdhPJzJtFaXbMcy+64yaYYRroXmyTyK8j8Gkg7Uj2Kv573XC8okNjixo4oiA7R0G6MyTG46ipjrAQ== X-Received: by 2002:a9d:7d96:0:b0:5cd:ae1e:3043 with SMTP id j22-20020a9d7d96000000b005cdae1e3043mr8942959otn.284.1648889485183; Sat, 02 Apr 2022 01:51:25 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id g25-20020a544f99000000b002da70c710b8sm1947556oiy.54.2022.04.02.01.51.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Apr 2022 01:51:24 -0700 (PDT) From: Rebecca Mckeever To: outreachy@lists.linux.dev Cc: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rebecca Mckeever Subject: [PATCH 6/6] staging: r8188eu: remove spaces before tabs Date: Sat, 2 Apr 2022 03:50:48 -0500 Message-Id: <2fd10f393e3bc7381a85d0bfc1ec04a80af4eabb.1648888462.git.remckee0@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Conform to Linux kernel coding style. Reported by checkpatch: WARNING: please, no space before tabs Signed-off-by: Rebecca Mckeever Acked-by: Larry Finger --- drivers/staging/r8188eu/core/rtw_cmd.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188= eu/core/rtw_cmd.c index 832bf25b1a83..8ae25cb4246b 100644 --- a/drivers/staging/r8188eu/core/rtw_cmd.c +++ b/drivers/staging/r8188eu/core/rtw_cmd.c @@ -548,9 +548,9 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wl= an_network *pnetwork) =20 phtpriv->ht_option =3D false; if (pregistrypriv->ht_enable) { - /* Added by Albert 2010/06/23 */ - /* For the WEP mode, we will use the bg mode to do the connection to av= oid some IOT issue. */ - /* Especially for Realtek 8192u SoftAP. */ + /* Added by Albert 2010/06/23 */ + /* For the WEP mode, we will use the bg mode to do the connection to avo= id some IOT issue. */ + /* Especially for Realtek 8192u SoftAP. */ if ((padapter->securitypriv.dot11PrivacyAlgrthm !=3D _WEP40_) && (padapter->securitypriv.dot11PrivacyAlgrthm !=3D _WEP104_) && (padapter->securitypriv.dot11PrivacyAlgrthm !=3D _TKIP_)) { @@ -1010,7 +1010,7 @@ u8 rtw_lps_ctrl_wk_cmd(struct adapter *padapter, u8 l= ps_ctrl_type, u8 enqueue) u8 res =3D _SUCCESS; =20 /* if (!pwrctrlpriv->bLeisurePs) */ - /* return res; */ + /* return res; */ =20 if (enqueue) { ph2c =3D kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC); @@ -1151,8 +1151,8 @@ u8 p2p_protocol_wk_cmd(struct adapter *padapter, int = intCmdType) } =20 pdrvextra_cmd_parm->ec_id =3D P2P_PROTO_WK_CID; - pdrvextra_cmd_parm->type_size =3D intCmdType; /* As the command tppe. */ - pdrvextra_cmd_parm->pbuf =3D NULL; /* Must be NULL here */ + pdrvextra_cmd_parm->type_size =3D intCmdType; /* As the command tppe. */ + pdrvextra_cmd_parm->pbuf =3D NULL; /* Must be NULL here */ =20 init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, GEN_CMD_CODE(_Set_Dr= v_Extra)); =20 @@ -1378,8 +1378,8 @@ u8 rtw_drvextra_cmd_hdl(struct adapter *padapter, uns= igned char *pbuf) p2p_ps_wk_hdl(padapter, pdrvextra_cmd->type_size); break; case P2P_PROTO_WK_CID: - /* Commented by Albert 2011/07/01 */ - /* I used the type_size as the type command */ + /* Commented by Albert 2011/07/01 */ + /* I used the type_size as the type command */ p2p_protocol_wk_hdl(padapter, pdrvextra_cmd->type_size); break; case CHECK_HIQ_WK_CID: --=20 2.32.0