From nobody Sat Jun 27 20:24:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFE88C433F5 for ; Sun, 20 Feb 2022 20:30:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244873AbiBTUa5 (ORCPT ); Sun, 20 Feb 2022 15:30:57 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233790AbiBTUay (ORCPT ); Sun, 20 Feb 2022 15:30:54 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E438C522D4 for ; Sun, 20 Feb 2022 12:30:32 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id m17so25259314edc.13 for ; Sun, 20 Feb 2022 12:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ElSqKc4cA4ptRtjuOUBsN95Rc6vUSk4leDCw/n+cQR8=; b=FcRiLkds7TS4z1hAlP1NFZaxrhQumregUC5nFy9a5g/mlr/4eB+FsrQ9fXBbZHUrSh ivZ5QBs65fPFGN+iQkLYAk5Rf5hlQzWjqWdqMnxrTcSc2VfWILm6RbcUqZoPcmCIH26t MhXrz8YlX1Y/eALUsDrie9HcU1wkCZZLiQL5GDWU7jFxVFZW/XlZUNuNK0k+UlWnHG2J /UniKJrTq14ENhTeNUxuE9LbDud4A69UXjK7PnHSMzBN/ji1yOL1gf1u2Bfchrx8iSsm t5Zm0VbnrXtFLMwOMUphR5ksoNcsAxG4wB9soVjA9YJv9Tj3aG2uad1tELrEcIn+ANJB L33A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ElSqKc4cA4ptRtjuOUBsN95Rc6vUSk4leDCw/n+cQR8=; b=2g9N/AHJ5wzujfOnCkOIqJzfNhcpTZwoKmTc1SrunvWu4yFcM+hdS05UAMwRzlnYuH SAJs0CZUtjGON7aui4cMDwts5RzB8/5UhVw/+yKKQsKxRup30gz65kYcpTIGj87Obewo heygJbq7+Vkt6lJjWWAcYbBgMJHdtfiQWCZHfrpGBulHEAWS0oXdLUUxFsgYRcIf20aw NhD34C4sX3mLhuVhJgFZncgkelE7mPthv4w90vXQMnjWwF85kK8uZ7Kciz699+KlBvMd jF/s6ThVSFchnRE5JCLJs767Bh3seG7wBYa6p6K79QGc88fqlpztZD0WfjmZSS+0blgE Ce4Q== X-Gm-Message-State: AOAM530Qgcpa8xZ8KCUK5YYP7swluwtOKvgAv/KkKYq1GSDO23Hf/OVP 81KoXKUOVnXxgalVQFvdbv0= X-Google-Smtp-Source: ABdhPJzJNCyTmTZ4lJrH1ReCXIi2yG0+Pz7XO3TAI4DqwWkh+ufNdxeEO+t13WVBVwqodJVVPUR+FA== X-Received: by 2002:aa7:c789:0:b0:410:dd40:d458 with SMTP id n9-20020aa7c789000000b00410dd40d458mr19087589eds.3.1645389031467; Sun, 20 Feb 2022 12:30:31 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935aa6.dip0.t-ipconnect.de. [87.147.90.166]) by smtp.gmail.com with ESMTPSA id p25sm4443953ejn.33.2022.02.20.12.30.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 12:30:31 -0800 (PST) Date: Sun, 20 Feb 2022 21:30:29 +0100 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] staging: vt6656: Fix CamelCase warnings in mac.h and mac.c Message-ID: <505ae2999ea93318e3745c69d8e36e2c108d9fd0.1645386791.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes the checkpatch.pl warnings like: CHECK: Avoid CamelCase: 175: FILE: drivers/staging/vt6656/mac.h:175: +#define EnCFG_BBType_a 0x00 and affected places in mac.c Signed-off-by: Philipp Hortmann --- drivers/staging/vt6656/mac.c | 14 +++++++------- drivers/staging/vt6656/mac.h | 22 +++++++++++----------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/vt6656/mac.c b/drivers/staging/vt6656/mac.c index 4f1f9b03a678..49430c0a99b8 100644 --- a/drivers/staging/vt6656/mac.c +++ b/drivers/staging/vt6656/mac.c @@ -39,7 +39,7 @@ int vnt_mac_set_bb_type(struct vnt_private *priv, u8 type) u8 data[2]; =20 data[0] =3D type; - data[1] =3D EnCFG_BBType_MASK; + data[1] =3D EN_CFG_BB_TYPE_MASK; =20 return vnt_control_out(priv, MESSAGE_TYPE_WRITE_MASK, MAC_REG_ENCFG0, MESSAGE_REQUEST_MACREG, ARRAY_SIZE(data), @@ -120,8 +120,8 @@ int vnt_mac_enable_protect_mode(struct vnt_private *pri= v) { u8 data[2]; =20 - data[0] =3D EnCFG_ProtectMd; - data[1] =3D EnCFG_ProtectMd; + data[0] =3D EN_CFG_PROTECT_MD; + data[1] =3D EN_CFG_PROTECT_MD; =20 return vnt_control_out(priv, MESSAGE_TYPE_WRITE_MASK, MAC_REG_ENCFG0, MESSAGE_REQUEST_MACREG, ARRAY_SIZE(data), data); @@ -132,7 +132,7 @@ int vnt_mac_disable_protect_mode(struct vnt_private *pr= iv) u8 data[2]; =20 data[0] =3D 0; - data[1] =3D EnCFG_ProtectMd; + data[1] =3D EN_CFG_PROTECT_MD; =20 return vnt_control_out(priv, MESSAGE_TYPE_WRITE_MASK, MAC_REG_ENCFG0, MESSAGE_REQUEST_MACREG, ARRAY_SIZE(data), data); @@ -142,8 +142,8 @@ int vnt_mac_enable_barker_preamble_mode(struct vnt_priv= ate *priv) { u8 data[2]; =20 - data[0] =3D EnCFG_BarkerPream; - data[1] =3D EnCFG_BarkerPream; + data[0] =3D EN_CFG_BARKER_PREAM; + data[1] =3D EN_CFG_BARKER_PREAM; =20 return vnt_control_out(priv, MESSAGE_TYPE_WRITE_MASK, MAC_REG_ENCFG2, MESSAGE_REQUEST_MACREG, ARRAY_SIZE(data), data); @@ -154,7 +154,7 @@ int vnt_mac_disable_barker_preamble_mode(struct vnt_pri= vate *priv) u8 data[2]; =20 data[0] =3D 0; - data[1] =3D EnCFG_BarkerPream; + data[1] =3D EN_CFG_BARKER_PREAM; =20 return vnt_control_out(priv, MESSAGE_TYPE_WRITE_MASK, MAC_REG_ENCFG2, MESSAGE_REQUEST_MACREG, ARRAY_SIZE(data), data); diff --git a/drivers/staging/vt6656/mac.h b/drivers/staging/vt6656/mac.h index 05af9ca7d69c..4ceecee3e82a 100644 --- a/drivers/staging/vt6656/mac.h +++ b/drivers/staging/vt6656/mac.h @@ -172,20 +172,20 @@ #define TFTCTL_TSFCNTREN BIT(0) =20 /* Bits in the EnhanceCFG_0 register */ -#define EnCFG_BBType_a 0x00 -#define EnCFG_BBType_b BIT(0) -#define EnCFG_BBType_g BIT(1) -#define EnCFG_BBType_MASK (EnCFG_BBType_b | EnCFG_BBType_g) -#define EnCFG_ProtectMd BIT(5) +#define EN_CFG_BB_TYPE_A 0x00 +#define EN_CFG_BB_TYPE_B BIT(0) +#define EN_CFG_BB_TYPE_G BIT(1) +#define EN_CFG_BB_TYPE_MASK (EN_CFG_BB_TYPE_B | EN_CFG_BB_TYPE_G) +#define EN_CFG_PROTECT_MD BIT(5) =20 /* Bits in the EnhanceCFG_1 register */ -#define EnCFG_BcnSusInd BIT(0) -#define EnCFG_BcnSusClr BIT(1) +#define EN_CFG_BCN_SUS_IND BIT(0) +#define EN_CFG_BCN_SUS_CLR BIT(1) =20 /* Bits in the EnhanceCFG_2 register */ -#define EnCFG_NXTBTTCFPSTR BIT(0) -#define EnCFG_BarkerPream BIT(1) -#define EnCFG_PktBurstMode BIT(2) +#define EN_CFG_NXTBTTCFPSTR BIT(0) +#define EN_CFG_BARKER_PREAM BIT(1) +#define EN_CFG_PKT_BURST_MO BIT(2) =20 /* Bits in the CFG register */ #define CFG_TKIPOPT BIT(7) @@ -333,7 +333,7 @@ #define PKT_TYPE_ERROR_CRC BIT(1) #define PKT_TYPE_BSSID BIT(0) =20 -#define Default_BI 0x200 +#define DEFAULT_BI 0x200 =20 /* MiscFIFO Offset */ #define MISCFIFO_KEYETRY0 32 --=20 2.25.1 From nobody Sat Jun 27 20:24:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 335B0C433EF for ; Sun, 20 Feb 2022 20:30:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244924AbiBTUbF (ORCPT ); Sun, 20 Feb 2022 15:31:05 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244837AbiBTUbB (ORCPT ); Sun, 20 Feb 2022 15:31:01 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41612522DA for ; Sun, 20 Feb 2022 12:30:40 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id s14so7948106edw.0 for ; Sun, 20 Feb 2022 12:30:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=M3kDsmJgJhsx/BhUSBxKGZ3EihcGTlnZeIezNsAFAOY=; b=lQheRnjSoixYPLG1T0TtX2WAKuabcn/5uNflh3mJIom7wOn+XmtH6cNrWYiYURQfvW fsz/KhJV736abErFOmT/dkn+mIp132/U1WuzER8aBs/ftVnTt58niL2PweIhJePrtlB3 srFrjVouVnxtoD8KUpB7nNYW6McBjovvfCcPHVsUVE3wib0RErDFv86B1fslPRPwCK6W 9FOkAW5hn0TVo0TyQR3OKOb7Cdx+otB3PncfOOqH8URsFFHAs3HHn7p4t00iD7cIEuIi T7cBzHkP3gGKrTdDUy4gMi/+Hw1E+YoBH8R4AeX2GiqWBbeV/0UTt6j1x6vYwM9P7nTb EwHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M3kDsmJgJhsx/BhUSBxKGZ3EihcGTlnZeIezNsAFAOY=; b=LViK4dTCLF5OmHOyh5cIxgBlG55ES7NiGNHVliiEBbnUqybHuSbbQl82sZ5/xyjVnO NOJ68FcvVOTmm4YYMzb1tMlYZXKtckQeHQYtGux2DW0ecANnPXJybsCUzIumjGOOlKV6 mf9jFuwKzXdHLetcghW++YJBWGfMcSiQF6OJq4VpouI1RR/vgHJW4J/2HaKVZiqGEile 6Ku924esl6hJk++TeIE1mnBK3nJZpg4ko/PBeyUWQhIaqsS/srLG0QKvmC4/kFwzxlwj bY9o6E5omdMstOCx15np7PEXzcRaqIoKxHR67NEfQ92GxRUGpqiJG/JLmWWhkmK+L6ar 1y4Q== X-Gm-Message-State: AOAM530rxoL97MshXnxh2+KPpgrE9KFOSjKSrBqK6hmwQaVc98SjPtO4 8XTunN3zVfU6+LjGQ/m4T1c= X-Google-Smtp-Source: ABdhPJyg2dUSIoT8ZcdvaDBMvkxd/zPwsTUJeAOAvD1jq0FKJDzSI1BlzAxKpFskkYtO4rGvzKtFaQ== X-Received: by 2002:a05:6402:358c:b0:412:e44e:f62c with SMTP id y12-20020a056402358c00b00412e44ef62cmr7422797edc.206.1645389038839; Sun, 20 Feb 2022 12:30:38 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935aa6.dip0.t-ipconnect.de. [87.147.90.166]) by smtp.gmail.com with ESMTPSA id u2sm4390282eje.119.2022.02.20.12.30.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 12:30:38 -0800 (PST) Date: Sun, 20 Feb 2022 21:30:36 +0100 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] staging: vt6656: Add comment and change macro to function Message-ID: <3eb14cfaa3f97695bd4db0dd75ac78408c557821.1645386791.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes the checkpatch.pl warnings like: - CHECK: spinlock_t definition without comment - CHECK: Avoid CamelCase: - CHECK: Macro argument reuse 'uVar' - possible side-effects? and moved the only twice used macro to a function in the file where the function is used. Signed-off-by: Philipp Hortmann --- drivers/staging/vt6656/device.h | 11 ++--------- drivers/staging/vt6656/wcmd.c | 13 +++++++++++-- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/devic= e.h index 8b6623a751f0..eb84590d5eeb 100644 --- a/drivers/staging/vt6656/device.h +++ b/drivers/staging/vt6656/device.h @@ -268,8 +268,8 @@ struct vnt_private { u32 rx_buf_sz; int mc_list_count; =20 - spinlock_t lock; - struct mutex usb_lock; + spinlock_t lock; /*prepare tx USB URB*/ + struct mutex usb_lock; /*USB control messages*/ =20 unsigned long flags; =20 @@ -381,13 +381,6 @@ struct vnt_private { struct ieee80211_low_level_stats low_stats; }; =20 -#define ADD_ONE_WITH_WRAP_AROUND(uVar, uModulo) { \ - if ((uVar) >=3D ((uModulo) - 1)) \ - (uVar) =3D 0; \ - else \ - (uVar)++; \ -} - int vnt_init(struct vnt_private *priv); =20 #endif diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c index e8ee2fbee76c..77c6d898f660 100644 --- a/drivers/staging/vt6656/wcmd.c +++ b/drivers/staging/vt6656/wcmd.c @@ -31,6 +31,15 @@ static void vnt_cmd_timer_wait(struct vnt_private *priv,= unsigned long msecs) schedule_delayed_work(&priv->run_command_work, msecs_to_jiffies(msecs)); } =20 +static u32 add_one_with_wrap_around(u32 u_var, u8 u_modulo) +{ + if (u_var >=3D (u_modulo - 1)) + u_var =3D 0; + else + u_var++; + return u_var; +} + static int vnt_cmd_complete(struct vnt_private *priv) { priv->command_state =3D WLAN_CMD_IDLE; @@ -42,7 +51,7 @@ static int vnt_cmd_complete(struct vnt_private *priv) =20 priv->command =3D priv->cmd_queue[priv->cmd_dequeue_idx]; =20 - ADD_ONE_WITH_WRAP_AROUND(priv->cmd_dequeue_idx, CMD_Q_SIZE); + priv->cmd_dequeue_idx =3D add_one_with_wrap_around(priv->cmd_dequeue_idx,= CMD_Q_SIZE); priv->free_cmd_queue++; priv->cmd_running =3D true; =20 @@ -157,7 +166,7 @@ int vnt_schedule_command(struct vnt_private *priv, enum= vnt_cmd command) =20 priv->cmd_queue[priv->cmd_enqueue_idx] =3D command; =20 - ADD_ONE_WITH_WRAP_AROUND(priv->cmd_enqueue_idx, CMD_Q_SIZE); + priv->cmd_enqueue_idx =3D add_one_with_wrap_around(priv->cmd_enqueue_idx,= CMD_Q_SIZE); priv->free_cmd_queue--; =20 if (!priv->cmd_running) --=20 2.25.1 From nobody Sat Jun 27 20:24:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 452CBC433F5 for ; Sun, 20 Feb 2022 20:30:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244949AbiBTUbP (ORCPT ); Sun, 20 Feb 2022 15:31:15 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243959AbiBTUbH (ORCPT ); Sun, 20 Feb 2022 15:31:07 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C838522D7 for ; Sun, 20 Feb 2022 12:30:45 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id a23so27908791eju.3 for ; Sun, 20 Feb 2022 12:30:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=duxIQa38l5Vx3zHZUfG7pCHqZ11ClbH921hoe86DwF4=; b=nFgg1jcLmoGkjXe/yOB2v3smQ01rvtMIvZJssfGp537oqtgrI2qeupJqHr++hHinPf uzA4DQ5tXoN4PLkRRvYH5Kj1xa6f9uWRY02L66BSGxRysSE2m8r3GYBx0AnUffg6SV3I A7lrnSZQSuQ9NP59c5tZNfLx7ZAoSclot7i8jf31LlLvHf44rm4sw1C/0snqwrGvHBHv Q+rvSvwSFpq49rqhMvfuuGIb/xwinrY3Q8FQSCIR8ZzGUyTCLYFBHNwyo1vJ8afYWzyM +ptGIL85FFls03r75ByEQt4h4Q+vhH0KKTqT5HSfwid2NT4XQO1n1XmA9B9xX4XvG5NB RvLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=duxIQa38l5Vx3zHZUfG7pCHqZ11ClbH921hoe86DwF4=; b=6ZHHDaIFSS2PfI2u/T4sHdNEimqfLUUWXkVowqJgW08Q2q0VxTCckCRx+ntIXIH2Bo C6xUmHK10MeTjvKBOKf+xRNXrv3gNQD56+YTdc74GB7HMWu4husY1x+CCME7LSfNUQZt ropUweQzpZtJFMpq6AddeDMLkQg50+xIs9W77tmWjF2vMvoH8PEaxFimII9fGr3kDOzL CqgxdcIlSXCiyPPYJqGvHeGyZMek5Qjn54KAAjw7ziSqBlZLJK+P7qFZWbZpdeF8Cm1E CIND2yXb0lVKSnlURQLnllbF0VZcuzfAnZpQqjJ1mTglZ+27JLTd7m4hyyvqn8g6MMWi BTGw== X-Gm-Message-State: AOAM532ER0emkIapcZb44Iw4ZbviGJiU+tgTzr4HaU7kW5v2Rq977EFj NgXc4SJzMZkGsSjnuFTqfac= X-Google-Smtp-Source: ABdhPJxD4menECLdNo3bqpMdiBcTjMPRE/sq2Rb0w0RTZm6w9cKCyMknqWyWde40kCYB+YiV1QW3kA== X-Received: by 2002:a17:907:788c:b0:6ce:29d5:c075 with SMTP id ku12-20020a170907788c00b006ce29d5c075mr14028590ejc.407.1645389044574; Sun, 20 Feb 2022 12:30:44 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935aa6.dip0.t-ipconnect.de. [87.147.90.166]) by smtp.gmail.com with ESMTPSA id r3sm4493631ejd.129.2022.02.20.12.30.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Feb 2022 12:30:44 -0800 (PST) Date: Sun, 20 Feb 2022 21:30:42 +0100 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] staging: vt6656: Remove ftrace-like logging and unnecessary line breaks Message-ID: <44f469737b788d1012943eb4e95997d40a947f04.1645386791.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes the checkpatch.pl warnings like: WARNING: Unnecessary ftrace-like logging - prefer using ftrace CHECK: Lines should not end with a '(' Signed-off-by: Philipp Hortmann --- drivers/staging/vt6656/rxtx.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index a31947f2620d..4d29f8ebb393 100644 --- a/drivers/staging/vt6656/rxtx.c +++ b/drivers/staging/vt6656/rxtx.c @@ -58,8 +58,6 @@ static struct vnt_usb_send_context struct vnt_usb_send_context *context =3D NULL; int ii; =20 - dev_dbg(&priv->usb->dev, "%s\n", __func__); - for (ii =3D 0; ii < priv->num_tx_context; ii++) { if (!priv->tx_context[ii]) return NULL; @@ -355,10 +353,8 @@ static bool vnt_fill_txkey(struct vnt_tx_buffer *tx_bu= ffer, struct sk_buff *skb) ether_addr_copy(mic_hdr->addr2, hdr->addr2); ether_addr_copy(mic_hdr->addr3, hdr->addr3); =20 - mic_hdr->frame_control =3D cpu_to_le16( - le16_to_cpu(hdr->frame_control) & 0xc78f); - mic_hdr->seq_ctrl =3D cpu_to_le16( - le16_to_cpu(hdr->seq_ctrl) & 0xf); + mic_hdr->frame_control =3D cpu_to_le16(le16_to_cpu(hdr->frame_control) &= 0xc78f); + mic_hdr->seq_ctrl =3D cpu_to_le16(le16_to_cpu(hdr->seq_ctrl) & 0xf); =20 if (ieee80211_has_a4(hdr->frame_control)) ether_addr_copy(mic_hdr->addr4, hdr->addr4); --=20 2.25.1