From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8905BC433F5 for ; Sat, 29 Jan 2022 16:05:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351568AbiA2QFq (ORCPT ); Sat, 29 Jan 2022 11:05:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351513AbiA2QFn (ORCPT ); Sat, 29 Jan 2022 11:05:43 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B480C061714 for ; Sat, 29 Jan 2022 08:05:43 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id h14so8849027plf.1 for ; Sat, 29 Jan 2022 08:05:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PnbU93vWGV651EUjlzxYJgD/J8Jnot+F9jtiMaEhyAI=; b=DoCu4VSTL/VXy1qaQWua2z8oAd/y6fgGWU7W5ZR8KskvW8xP480BlgXc3FL7fAoc1A LKKK5eZ0XC3o/3q2ykRBc30nfyHVbmLcfT0OwIcjFrQ1FfgK/mLyBwoiwlMJ2O/4WDeY cuzIcYgZ++sYothW7hU3FUsb6yehknz49JTflbzwmPoKttL/r67dTwcGmiRP2QhmN3ZB DMdhY2v6W4ikEqfYad2LIB+2Fw+9O60CiE+DrLZvtw3tWIX7svbZrj2CYX59AsHRaHdO xfTbho91ruL2hPmGNjOdQyjIyLwRluI1ihrde2hTA2lX8S5Yw/7O+lToCwUzQee0tVao JQzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PnbU93vWGV651EUjlzxYJgD/J8Jnot+F9jtiMaEhyAI=; b=oPZumd2WmuLpR9Fh2E1k2DoMBY9AP1HrKWZdr5BjvoXeiWfXuv5X5c9EYmPCTxol+/ t7qCZpkLOMRXT/sMAo1QYCoMKXdrcPccnummBOcQ8aUvO8q4bnjkiWRjtQ5be77xsRus nnZAo42bVOc4s9vhsifpkJslfZzJ7NxJ+GUh2JUm6duBrs6xO8+v9VllVafhai5nWyF8 +J+gAeyIgiLX0wDupl5FzczDMFsse7dpDHMvcrvxE3vfSOF+LVv5bP4+sxRQQ1DeTy/m B18Uol5C2wu8svbVfwsGmGZ2jFQ4DM1Tm7ag4a0c25ubDidjsbxIi2nTi0U+qTkspfqa gcjQ== X-Gm-Message-State: AOAM53000Ul8npjyLsSuk5j8qteLO3BQu3q2giXGSlkl/DzfQVsinxV1 11k6w/mZofySnnOt+fLrlyk= X-Google-Smtp-Source: ABdhPJyUB/YePSOX4rrwQOnm1FOUbvi5tDeD6LRqBCNKxaRa588oXCVIUfazXLkuNrGtoVcuJzywPA== X-Received: by 2002:a17:90b:17c4:: with SMTP id me4mr15556737pjb.243.1643472342592; Sat, 29 Jan 2022 08:05:42 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id t9sm5672868pjg.44.2022.01.29.08.05.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:05:42 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 01/23] staging: r8188eu: remove unneeded variable in rtw_wx_get_essid Date: Sat, 29 Jan 2022 21:34:07 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unneeded return variable that is initialized to 0 and not assigned after. Found using Coccinelle Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index b9f9698d70cf..3a60e1f81592 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -1383,7 +1383,7 @@ static int rtw_wx_get_essid(struct net_device *dev, struct iw_request_info *a, union iwreq_data *wrqu, char *extra) { - u32 len, ret =3D 0; + u32 len; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct wlan_bssid_ex *pcur_bss =3D &pmlmepriv->cur_network.network; @@ -1399,7 +1399,7 @@ static int rtw_wx_get_essid(struct net_device *dev, wrqu->essid.length =3D len; wrqu->essid.flags =3D 1; =20 - return ret; + return 0; } =20 static int rtw_wx_set_rate(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07BC3C433F5 for ; Sat, 29 Jan 2022 16:05:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351693AbiA2QFu (ORCPT ); Sat, 29 Jan 2022 11:05:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351673AbiA2QFq (ORCPT ); Sat, 29 Jan 2022 11:05:46 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39CBDC061714 for ; Sat, 29 Jan 2022 08:05:46 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id r59so9417436pjg.4 for ; Sat, 29 Jan 2022 08:05:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Xa9/uQimRO4U5DdZfy5OHCYx6e+VSAPR4ymHWAiOiFc=; b=nitZL45Jd8jjpmzytmvzZg4RNy1iCWk6koqbhkdU1VvecYhAnNMJIExE7JcVSBVnkU khBVIo/39rVRwuAUJAHUdiuvYXA4DoqN9hIb4W56m34+quB80y8obNhshlBxcBwwb188 T+e+kie/Geu4QFabfsT40lKBOyY26ijKOpL+rxEyn0hSk86kkNXdmwYcLDKsG2/AE+Mc 2Y0zv7OkmR8j2Qb4KdENcjqEn+rM8X1f7whpg4Q8eSlEWjBpxDIn+rTwyyL5ICZaTlrJ 5UmWwAWdg7GpPQ+3CXsJtbzvejV+5LipP+U+chLXcwBrf3to+Cxfxk1aoWgydyga/ItY j4+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xa9/uQimRO4U5DdZfy5OHCYx6e+VSAPR4ymHWAiOiFc=; b=QlRX0KmmoUuEnzC32e6sxs4yE9Xor4NxK5Pj+6Jj4Ejc+N1sMoGOZfPhYZ8LNWEBPi Yp3vHMgn/Z3J99IMP74OPJ9n/MfPJWJeszORV/mGCo6lP69JmQ5yQA69evJbmke4vfhH 0+sc5gcd4ITG7cJqxkw3zh5bICWv3qb0Xcbn0sNf6NM4ObZBiVDdrIlo743pcXSpSvCX tDm7j1bd26B/iPASONcODlTPKrEAf23q9EatohEsAbMCMGtUttrlwtVC8H6KlxQKLpGM qbgWmoSjVJ9rFIQ6iKPZrVbMhu3SpMGrMJhp/AKflASaHK5ZK8SSfwNEvmReVwJR2V7t 7C8A== X-Gm-Message-State: AOAM530aXGbg7gS378HmIh2dBV2Zxf41njzNzjDY2WpqfAvXhczxYDWm gZssGCLohMHvcxje3Wggq0s= X-Google-Smtp-Source: ABdhPJyiCGW59QHIl7TaXuJn+iXBBjkYu4OgfUAwdBNc3X9SDa9676AKvhMF8dkYwjmEhbT8AzGJTw== X-Received: by 2002:a17:902:e746:: with SMTP id p6mr13199995plf.78.1643472345817; Sat, 29 Jan 2022 08:05:45 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id t9sm5672868pjg.44.2022.01.29.08.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:05:45 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 02/23] staging: r8188eu: remove unneeded variable in rtw_wx_get_enc Date: Sat, 29 Jan 2022 21:34:08 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unneeded return variable that is initialized to 0 and not assigned after. Found using Coccinelle Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index 3a60e1f81592..f99942417a71 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -1717,7 +1717,7 @@ static int rtw_wx_get_enc(struct net_device *dev, struct iw_request_info *info, union iwreq_data *wrqu, char *keybuf) { - uint key, ret =3D 0; + uint key; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct iw_point *erq =3D &wrqu->encoding; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -1778,7 +1778,7 @@ static int rtw_wx_get_enc(struct net_device *dev, } =20 =20 - return ret; + return 0; } =20 static int rtw_wx_get_power(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F631C433F5 for ; Sat, 29 Jan 2022 16:31:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352616AbiA2QbY (ORCPT ); Sat, 29 Jan 2022 11:31:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240653AbiA2QbV (ORCPT ); Sat, 29 Jan 2022 11:31:21 -0500 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4ED1C061714 for ; Sat, 29 Jan 2022 08:31:21 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id z10-20020a17090acb0a00b001b520826011so13876765pjt.5 for ; Sat, 29 Jan 2022 08:31:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6zjHCA2mlhxhOhnGWQKP59mu6FW4vaokSvYIkJkIJG4=; b=NWXU90bGfAUDA6hnvcDB5yiOVHb+f9xHcauQTwA8xma4HVI6f85R1CSe5QwHGt93UF hYkCtOtC1zkTgqdFTuVkozOgwh/ZP/3xhmwWvEMRSqkGNMoxYWbmnyWajPXkzYEQPj+Y k5d8KOEDxUIQ+FyY+drr/o1eCPdqEoD0rgXDbPGjrm+VdfeXD3kvVlDifqKyYFmE2Hl3 23cM3m3Q/Mb+VH4NxUWko8dDRsEpYFugSblIxuo76jWrNlZKe8TQEyzvW5/MTm1YDibx UcUDnSOfpuVTjXacv+0KPW8veRh6vqfPTIlhdtyuVEgE8p4gvStyP+3AiD0D9JGAEljl mL3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6zjHCA2mlhxhOhnGWQKP59mu6FW4vaokSvYIkJkIJG4=; b=5AnBFHTJ48JyDtwwmcdw5HQYtJifUCb5c6xocRZwSoxZfA/IFiKu4bQxzAb+nyqjGT TrFyWopobjPEIg6o+UX+mvOtGkHDDIiPy8Pc8aYS4iJe8PYQetOKq4AmnTlx1UoMNH/b bbqcZCbiwiDDkRISh6TMAls1LfYX/lGhTNhg3e3JsXtjLOHBl5AXKdxkod6qpiQ6FqYp Hx4SXJ2ApASA90TP5pVysLRVsTVmMkkJiFc7XGnRHHdIPg2o71w66XP0B7rly9CmATH6 DlBeOYD9Gc+BozFgz9fRRv4GL1Kz+gyLqG0xWaHBhb+EVgdm/omGjtu2anpApniK5nhx 14cA== X-Gm-Message-State: AOAM533E+nrqJDZUGIqZ9UjZldk4kbfZZbd25PT2TZ4aMuidoDjhn/FS +D1zJdQvEe67yiUWSIR9Rqo= X-Google-Smtp-Source: ABdhPJyQSOi4W71WzoPSJo03LOFHDk6YD4WNRlSITcWcGAElPRpQy9HNiRGkqU01AEMV+9nqf9YmNQ== X-Received: by 2002:a17:902:e746:: with SMTP id p6mr13284175plf.78.1643473881469; Sat, 29 Jan 2022 08:31:21 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.29.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:31:20 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 03/23] staging: r8188eu: remove unneeded variable in rtw_p2p_get Date: Sat, 29 Jan 2022 21:57:55 +0530 Message-Id: <6c992e9481c7481aa5931635e162dd7a4400a2e2.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unneeded return variable that is initialized to 0 and not assigned after. Found using Coccinelle Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index f99942417a71..bc5c8454ebcf 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -3422,8 +3422,6 @@ static int rtw_p2p_get(struct net_device *dev, struct iw_request_info *info, union iwreq_data *wrqu, char *extra) { - int ret =3D 0; - struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); =20 if (padapter->bShowGetP2PState) @@ -3447,7 +3445,7 @@ static int rtw_p2p_get(struct net_device *dev, } else if (!memcmp(wrqu->data.pointer, "op_ch", 5)) { rtw_p2p_get_op_ch(dev, info, wrqu, extra); } - return ret; + return 0; } =20 static int rtw_p2p_get2(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A31C433F5 for ; Sat, 29 Jan 2022 16:31:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352647AbiA2Qb1 (ORCPT ); Sat, 29 Jan 2022 11:31:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352633AbiA2QbZ (ORCPT ); Sat, 29 Jan 2022 11:31:25 -0500 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57361C06173B for ; Sat, 29 Jan 2022 08:31:25 -0800 (PST) Received: by mail-pg1-x529.google.com with SMTP id q75so8058879pgq.5 for ; Sat, 29 Jan 2022 08:31:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p/iheAiKRNX/zYagp3+t2KC4OOAuSnRdRHqutW+clxo=; b=nA9IWgTDotqfDmoKv7jAI40+lzrUkh+z9+by6wqMk3ljCJWHMfYRuOKbEgxC3QXYNU cLxIFWe3VDoFvyXN+NEnEeXa5PGl/JhZxp1uL9qyXgBwV4Gc4JaeZJg701RiSJ1Brmfm c4c6tghq3u47UHWKPJ+dhriE+YAsbkcuZvAQraS3a32ctt7gzXEswiEWiuGG/FRDzbUB 9mZ4GQ/xYJtzqxzd/AxDefH/6GzK+IeSVogximlCfD6mroROHp7F2KS5HsMS4IqRvB5Y sotf/jQ52nBLP4A0ulProHB9hFZpUF5x/CbW7Jr6zegbWyW5EmRcreszwX8wYZNg/YNl 5Blw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p/iheAiKRNX/zYagp3+t2KC4OOAuSnRdRHqutW+clxo=; b=xENKGdDNmpCn+bVvwqZhx4MpqX4IeE61xrpIzgRE5dVIkbIbjfCsDpr4Hvavt7J8wc Sn2myUEXZR5Ogz4BWsvb+rpK8hcmUKH9xawf1HjQduYaeRvAuEpe5QZCQyU1Wr6UzZaR +w2gF1qWZcivJO/TkqtMBn+Wp+tM9waK2iA0sEoj/GbSYKEdFP+V6b9Nf7ZlGe0NwjuJ 31gLx5r2XppcmRRkC21IPnp1nk2kNZzxw8YPiQreC8Qo4YPqIrpMn2o5PvaG09JChWyY 8ysCZoaDRVBXSAJsKHbE4/H7CuwupJhJbw5tCNiiZuFE4MmTBH06oyaSq13Dcff6Xacq VTHw== X-Gm-Message-State: AOAM531M/D7OxSXiETVUJ9OYb6dfn5z1v/ucyYvBu6oTaNRhr94bYWrt Hto09GeeNHtPymQg22rqXRs= X-Google-Smtp-Source: ABdhPJzZnyEB0ENS44pWvYySVcUEPE95WuntkwrZCiIALKslTQeB6dmyt4rVhh6TwqCRfbnEiQHhRA== X-Received: by 2002:a62:1643:: with SMTP id 64mr13019916pfw.55.1643473884798; Sat, 29 Jan 2022 08:31:24 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:31:24 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 04/23] staging: r8188eu: remove unneeded variable in rtw_p2p_get_wps_configmethod Date: Sat, 29 Jan 2022 21:57:56 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unneeded return variable that is initialized to 0 and not assigned after. Found using Coccinelle Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index bc5c8454ebcf..b0f78673d9b7 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2620,7 +2620,6 @@ static int rtw_p2p_get_wps_configmethod(struct net_de= vice *dev, struct iw_request_info *info, union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); u8 peerMAC[ETH_ALEN] =3D {0x00}; int jj, kk; @@ -2681,7 +2680,7 @@ static int rtw_p2p_get_wps_configmethod(struct net_de= vice *dev, =20 if (copy_to_user(wrqu->data.pointer, attr_content_str, 6 + 17)) return -EFAULT; - return ret; + return 0; } =20 static int rtw_p2p_get_go_device_address(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6BA2C433EF for ; Sat, 29 Jan 2022 16:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352662AbiA2Qbd (ORCPT ); Sat, 29 Jan 2022 11:31:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352665AbiA2Qb3 (ORCPT ); Sat, 29 Jan 2022 11:31:29 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AA04C06173B for ; Sat, 29 Jan 2022 08:31:29 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id i186so6501504pfe.0 for ; Sat, 29 Jan 2022 08:31:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XPVQMO6visW/k5DSDZIWEQ4IZV34Wlm68x5zMJm/R0I=; b=WSDNrWKl8naM+RFgkzSqxqTkKDc1jpU7DZOBA/NEBqu/I/rykIr9Yyjj2OBwDb5oLg Hf446toFtvEF3ub5mBeQYpLxbztATMtEsqE8aSDBCvkD+yuPFYtsQG+V89Qh4N6zOqxf vSjB6N7BtsMUp/JuNcqLI+QHYX6z7zfd6zbiOxkbHv4+HVqeD68zMYbag2bOCMNTG8di jb7RCfqjDFDftbr0nuNC+7QqxZWDvzYysxMWdKB6lsgfKoXXIUwR5MwynE+yBFrQeKDZ PDdp0VkzGxMFOwEMGiA/LPo/mtjIQ5UPr02BC1DSt94Fc8ldIDX4JPif97C109OEj5LK yEyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XPVQMO6visW/k5DSDZIWEQ4IZV34Wlm68x5zMJm/R0I=; b=RxtRDa76g/NyuZujOJIcjlKEHc2K7/nrhsrkqQCP/gx/nvDKc3yUtfcr5UTW6exUSK pZWgt1jtzdr2Q57sLL/SPnoF0kZIqdPBLwU3M2l7wM4nsL0ENbLOINHI0voK3g1360hD WUXmOagxG/V0gNFI4wtu+ws/R3PLX62sAsC4OC5ErNr/D/teu9v3HcbOA/0Qu1SH047d /srcy/OfN9t4CxeRzvb1doDydbGW7z5Z6YlYc4teAH+by+eo46iC+U2mdd6MNasScPZB 3i2Rrww2Y7ZRR1XEJNF3IKatPSuwEZD2/O9zd9ldAFfyWhn8j+b1tQlyU6Bc675QYWnh vo/A== X-Gm-Message-State: AOAM532vrxXmyq4c6IYMY72gkEbBc875IxtQ7eSdsEB5/Bby2IhQNcTY 29175nF749Gyth2f/B9kgKY= X-Google-Smtp-Source: ABdhPJyerL4RXYIUlTQj9uW1X/4hRF6FpxS55GEMsr3DNoFwOBFgWPe+ixX32fFaLTsXMJLuk/9rGw== X-Received: by 2002:a62:8183:: with SMTP id t125mr13046503pfd.41.1643473888852; Sat, 29 Jan 2022 08:31:28 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:31:28 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 05/23] staging: r8188eu: remove unneeded variable in rtw_p2p_get_go_device_address Date: Sat, 29 Jan 2022 21:57:57 +0530 Message-Id: <26a84fbef7e06d518efc29d2cd9e3dd685c96e0d.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unneeded return variable that is initialized to 0 and not assigned after. Found using Coccinelle Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index b0f78673d9b7..b093430ff744 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2687,7 +2687,6 @@ static int rtw_p2p_get_go_device_address(struct net_d= evice *dev, struct iw_request_info *info, union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); u8 peerMAC[ETH_ALEN] =3D {0x00}; int jj, kk; @@ -2763,7 +2762,7 @@ static int rtw_p2p_get_go_device_address(struct net_d= evice *dev, =20 if (copy_to_user(wrqu->data.pointer, go_devadd_str, 10 + 17)) return -EFAULT; - return ret; + return 0; } =20 static int rtw_p2p_get_device_type(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5864C433F5 for ; Sat, 29 Jan 2022 16:31:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352676AbiA2Qbh (ORCPT ); Sat, 29 Jan 2022 11:31:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352668AbiA2Qbd (ORCPT ); Sat, 29 Jan 2022 11:31:33 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABDC0C061741 for ; Sat, 29 Jan 2022 08:31:33 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id 133so8099138pgb.0 for ; Sat, 29 Jan 2022 08:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6bf6lhHbgkl3pCSqm/k2iChu7YEwDY7WU7VmbDU3O3o=; b=dAdoYV5mtnPLehk0FRM4X0AdM8jKLGQFg0jMR+yN5Z5ih+CeKbXRjwBPd2qH4e0B2H V+FXAjqf/+SSNo+YVyVYCmjt/MjApPsDSMnS0k+6Pox/4Xkgr1SAE+BviaGXjgoiF5Aq lBFDjZie4YiXcpQEa8gfHb63GYizTeLovnGa9OqokDBAxxYCgCmPxhJqwQYGO8ev0S3N sYL/I+Az1cO4wHR5ee8g6kS1bUpEmBbReZvolJx65i86JjltY4hvL1PoBi8uA9K7DrXs A7LdUQ0md+KZKKnQbwAOYMJPioB7Si7rNHCYV4vIlXNe7ocbYerTjJqOKeL7TTEASZx+ Caow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6bf6lhHbgkl3pCSqm/k2iChu7YEwDY7WU7VmbDU3O3o=; b=RSUB1r1MHbx5EPehUk8hZSDaq0rHxXJQd1Qmoeljyyigc/nVDTuKPVR1e5FHHL7aTQ RDJ5SCCOHiarzrSf156p5wi9iBmA7ebdWA1C5giZzJtmOuvsvyQq2RHOIvBQUFYE7yV5 XlFG4n7kpVoDEms/BX/ZGJQxce4YNt0B91z4PqQZtWTfBu1T5B8mySFd0EkKcrSn2AJp 75CRRVfNsry2xzxnEJ6rj4BPHttrUgeb4TQQos0Mhuy7hmTj9tJ6x44rkfagP64FPeI4 u4i6VFWNgKY2907yImdJcDtw6S+UrezHjvyN44ajLMZ7Vd8kBc03EJScz4PJ9uum08A+ sg3g== X-Gm-Message-State: AOAM530NTMY3R9yyOPZKO2Ywdb2zWc/fHdPWlN2J68kvBaPthMU/GOt8 8/DPl2yj+2wiqskrY9xm220= X-Google-Smtp-Source: ABdhPJwKSvI9hGklRZ4LetcksI2zs63WhOMTuytmMMX+51ZZT0rkLUIdmTFvLeTa/j/lxaf24oZ9FA== X-Received: by 2002:a63:2ad6:: with SMTP id q205mr9014100pgq.46.1643473893318; Sat, 29 Jan 2022 08:31:33 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.31.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:31:32 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 06/23] staging: r8188eu: remove unneeded variable in rtw_p2p_get_device_type Date: Sat, 29 Jan 2022 21:57:58 +0530 Message-Id: <83609e3c75a0bde4be612d32d76eaed6a26f72aa.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unneeded return variable that is initialized to 0 and not assigned after. Found using Coccinelle Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index b093430ff744..6d72b15541ab 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2769,7 +2769,6 @@ static int rtw_p2p_get_device_type(struct net_device = *dev, struct iw_request_info *info, union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); u8 peerMAC[ETH_ALEN] =3D {0x00}; int jj, kk; @@ -2838,7 +2837,7 @@ static int rtw_p2p_get_device_type(struct net_device = *dev, return -EFAULT; } =20 - return ret; + return 0; } =20 static int rtw_p2p_get_device_name(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D05CAC433EF for ; Sat, 29 Jan 2022 16:31:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352677AbiA2Qbk (ORCPT ); Sat, 29 Jan 2022 11:31:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352668AbiA2Qbh (ORCPT ); Sat, 29 Jan 2022 11:31:37 -0500 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69F9CC061714 for ; Sat, 29 Jan 2022 08:31:37 -0800 (PST) Received: by mail-pf1-x432.google.com with SMTP id 192so8978741pfz.3 for ; Sat, 29 Jan 2022 08:31:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o6tVV3EV5GZ5J/+KxHkNVwDUV3xfQLU/3YBnbUf4aGM=; b=hCgYXrv6DRbcOuxqv2dfwWHpSTMEEg8Mpui5vyFv4gqzTslH62lPPj3eU3lPodSzzj 20JNikaM7qrs5UqzNvhdJl2HKidG0ehRxcTX/Szw1ZtFQ5eonVSrc6SM7qd7TfYyN9R4 fMswRD1VjIl6WZoJ9U4Uo5szk31jVCfL/Rp/9JpWcfJvZZyAg+4ZlUqF2yqBAx1vJJ8Y 6ETl1ssSso0uV8KSoRFJBjFVwlgfb7s+Q9v33Ezd0zAM0tfa7JlB8qwxU9X6fYc+VJK0 pIklOaTv6E2+//ppXK5jjQRBlA8xXkGg5zvqXaZk1eHptON7+6cW7DWRsSp1DrGq4xIq sYGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o6tVV3EV5GZ5J/+KxHkNVwDUV3xfQLU/3YBnbUf4aGM=; b=Di6cqMM9PJ4jZpUU69abvdHynTfwbF8OFxBTqdwJZj4yuivwSEUB/nQ9v0Wh6Jrgof GTCf+43y5ZQBycexDR9sUX9X+zwHQR/qxT1CpZlP5g+XGOS3og1eCBb5yUKxEUa0sfxv WyXuKX+LnlYtk8B+MqFU9i/SCF37JziJJuRR8tTocIxctc+pwbgE8nkTq+pBrvLwO70b ka0wspaxCF0InXVKvCImFg1FFSVvkUarglJAqZYA5/K2Ry1xGyDUkcnMn3emZhnvlFHl EOnFHZwMx9Yq/Zyy8FHfLJ5ZxQol+Oojea1BjDO0wAASXZc3EQhiJN7BSJfiP0FRvRIw cePg== X-Gm-Message-State: AOAM530NbM5ihUGAAEuBTYGP28+mzcFnr9JJV/WbJ7duOL/xxydFBomJ nob5sOFwfUlgKlPgmK/DhAU= X-Google-Smtp-Source: ABdhPJxvSzeza5iycL4aC4oHZRG2A7r2dKzZSFqF4ywHytGL0mAiZoaR2F6CsnK03S0PwkJr7xmO5A== X-Received: by 2002:a05:6a00:1ac8:: with SMTP id f8mr12890844pfv.7.1643473896998; Sat, 29 Jan 2022 08:31:36 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:31:36 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 07/23] staging: r8188eu: remove unneeded variable in rtw_p2p_get_device_name Date: Sat, 29 Jan 2022 21:57:59 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unneeded return variable that is initialized to 0 and not assigned after. Found using Coccinelle Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index 6d72b15541ab..33fe8e944df4 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2844,7 +2844,6 @@ static int rtw_p2p_get_device_name(struct net_device = *dev, struct iw_request_info *info, union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); u8 peerMAC[ETH_ALEN] =3D {0x00}; int jj, kk; @@ -2903,7 +2902,7 @@ static int rtw_p2p_get_device_name(struct net_device = *dev, =20 if (copy_to_user(wrqu->data.pointer, dev_name_str, 5 + ((dev_len > 17) ? = dev_len : 17))) return -EFAULT; - return ret; + return 0; } =20 static int rtw_p2p_get_invitation_procedure(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E35E9C433F5 for ; Sat, 29 Jan 2022 16:31:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352693AbiA2Qbs (ORCPT ); Sat, 29 Jan 2022 11:31:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352680AbiA2Qbl (ORCPT ); Sat, 29 Jan 2022 11:31:41 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED2DEC061714 for ; Sat, 29 Jan 2022 08:31:40 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id d1so8824805plh.10 for ; Sat, 29 Jan 2022 08:31:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=59y5lHN2gs000ZG3867tBGbxqegY+PjUJ9DhuQ1m6Jw=; b=aYzc9UvQSShqFwuvEjSRpqL3kkzYaXWL+Ree2TKSdMdJNBPEszjHEr1ooczhTLiViA 9AL3SFb0m71oDA1HVJnS1CsabRvU52TE6q8DjmFv1IBTtoY0enJU28aa4O/HN/++lbCd Bcto+8k0kGA+p4p1ID9sEVbu9FfMCD5fWVTG7L/+Z319LYewY7wGeDjO7sHDV86FfwPy iTXD0Ailil1nr/wPzSH5eazOxOPBoqIvC1ux2wBbkT3v0prFchv2dLLwEIdyASqjeUX4 6fCwxB6vltJ1qvGe3CTDCP7ylmvPeUcztnV7E8VFUO3DB19d7hj7xAQpQmdD/lPFWLsq KOeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=59y5lHN2gs000ZG3867tBGbxqegY+PjUJ9DhuQ1m6Jw=; b=t5Zd45sRE2Z14ATQWqexeVhzG/JM+9cvaETuYwte0GTsyOWKpKwn+8E/JctzvxHU5c jX8zwW7aPrVLnrsQegVw/DP16pcqDqC2Sh9km4sQrvQ0X4xQaOSEzIuyJvLUYnyk1LM2 EpkXZqhB3rDu9Uvs9HigZxXw3kxSdJsJc7duTGSv7w3SubhZBGUz3IH0ugGHa+gRDCsT HtZTsfuf4Buxxj16mGuKEGrG8VmQBIBeyvhT1lzHmU3x8ODLoTTA9NKTz4HV40ZABtIv cj5xPYyHAG0um1vvOiQgKhshrO9pUzXmZEkiPJ3GIkK0UqLx0lzyOnbwLgD/d/HJqdxz nZCQ== X-Gm-Message-State: AOAM532vZuoeNyfE4+KPRKOY4jpz8NPcTOXfew900rqDAUNbR8Q4Yw28 R4d4qOfBsPUxGLCbEj9nEpk= X-Google-Smtp-Source: ABdhPJzlcsQcJTyZjb2jsvBoGjUiiqasO3bAH1sR2Gsy8SPZdD9o91H91k1sgJMO3O0MOfjcheJt4Q== X-Received: by 2002:a17:90b:4d84:: with SMTP id oj4mr15684253pjb.192.1643473900489; Sat, 29 Jan 2022 08:31:40 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.31.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:31:39 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 08/23] staging: r8188eu: remove unneeded variable in rtw_p2p_get_invitation_procedure Date: Sat, 29 Jan 2022 21:58:00 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Remove unneeded return variable that is initialized to 0 and not assigned after. Found using Coccinelle Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index 33fe8e944df4..35f7ba66a7cf 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2909,7 +2909,6 @@ static int rtw_p2p_get_invitation_procedure(struct ne= t_device *dev, struct iw_request_info *info, union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); u8 peerMAC[ETH_ALEN] =3D {0x00}; int jj, kk; @@ -2978,7 +2977,7 @@ static int rtw_p2p_get_invitation_procedure(struct ne= t_device *dev, } if (copy_to_user(wrqu->data.pointer, inv_proc_str, 8 + 17)) return -EFAULT; - return ret; + return 0; } =20 static int rtw_p2p_connect(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A064C433F5 for ; Sat, 29 Jan 2022 16:31:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352707AbiA2Qbu (ORCPT ); Sat, 29 Jan 2022 11:31:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352711AbiA2Qbq (ORCPT ); Sat, 29 Jan 2022 11:31:46 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3B52C06174E for ; Sat, 29 Jan 2022 08:31:44 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id g15-20020a17090a67cf00b001b7d5b6bedaso182687pjm.4 for ; Sat, 29 Jan 2022 08:31:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=31GtAtozxIAbYu2fcxuIJ0ssFhQMM45afowSfajVZ7k=; b=dfS2BCG1tJ1YlJ8hD0HkFk8j+DSZ4faQbbQrySqr+fx9awuWxbsRaR9+AoIOQyj/oB C2Py6wKfw0AIDfbzJUp7DFxSEgiFhZ5LF798yGGVmJ6EEXO9p81yqgyllc7wFOkQ8+ay ETwn3V3GopEg4peLiZ11vbOWtiIlqAg2xb73euxynkqHeUqKdIneFymqPS3H6/1ULp85 NkNMCOMxJGs8JZdFuMfzeAd+VyiqzqIGg+WlrqhtIpqETDAhdd+SYQmHjYErLKABARIe bvpABVN/8a/l/yQwtt+cRtXedv8sfNLGWqdZqfLlCczpqVWNu+jbgMtjp7aAG0wfo4HG TAaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=31GtAtozxIAbYu2fcxuIJ0ssFhQMM45afowSfajVZ7k=; b=iLJHiOSEI8DoaIJxeiu404YiErJe32qfWKyeAvmo/91UGtOAIXxp01yJBltib8ryHo AJHEmiI73VIyLolq8D256iI7yOlDGqTwuce5AOFj1GJ6oA/owwVb697Etj1DWhNlva+B +Vw+zSNTSWaKS5F3iT13Gsm5yAFW3ADE/Mi0EYPMvZyOgOFS2/muR7vWVcUF8Rkp+9OG TkBCt0xObEI4Jgdi5uUN0UAP44h1wWsqZBOZSlauNk+tyRGcwXvNjsRtCBMFYpZVKMv/ rKLe3dgZaiIJbGHd6ADKBwS2i0nzxD5ZQLwMpW8h24d4Tnwk7e03Rh4eXWuowkvKouUa kmww== X-Gm-Message-State: AOAM530qGJ9AHqqpmKC4yby4UwwVvhgvt0Hrng92oBAeezh/uXJUilz7 7xDe2ZfSlBhttFg18dHmeVaJjVANLo8= X-Google-Smtp-Source: ABdhPJxtO8DiEZcoOTpV5REIv5alM0Q6jY679YqiEc/Mqly/lKm1FbLOkrvIO5JJSdKwBsGTDNk9JQ== X-Received: by 2002:a17:90b:1912:: with SMTP id mp18mr25454989pjb.152.1643473904583; Sat, 29 Jan 2022 08:31:44 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:31:44 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 09/23] staging: r8188eu: propagate error code in rtw_p2p_get2 Date: Sat, 29 Jan 2022 21:58:01 +0530 Message-Id: <818aad89738b66942bb66568081f1953a9494078.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_get2 calls functions that can fail with -EFAULT. Return the error code from the called functions. Signed-off-by: Abdun Nihaal --- - Newly added in V4 drivers/staging/r8188eu/os_dep/ioctl_linux.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index 35f7ba66a7cf..99c7f9369d2a 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -3452,19 +3452,19 @@ static int rtw_p2p_get2(struct net_device *dev, DBG_88E("[%s] extra =3D %s\n", __func__, (char *)wrqu->data.pointer); if (!memcmp(extra, "wpsCM =3D", 6)) { wrqu->data.length -=3D 6; - rtw_p2p_get_wps_configmethod(dev, info, wrqu, &extra[6]); + ret =3D rtw_p2p_get_wps_configmethod(dev, info, wrqu, &extra[6]); } else if (!memcmp(extra, "devN =3D", 5)) { wrqu->data.length -=3D 5; - rtw_p2p_get_device_name(dev, info, wrqu, &extra[5]); + ret =3D rtw_p2p_get_device_name(dev, info, wrqu, &extra[5]); } else if (!memcmp(extra, "dev_type =3D", 9)) { wrqu->data.length -=3D 9; - rtw_p2p_get_device_type(dev, info, wrqu, &extra[9]); + ret =3D rtw_p2p_get_device_type(dev, info, wrqu, &extra[9]); } else if (!memcmp(extra, "go_devadd =3D", 10)) { wrqu->data.length -=3D 10; - rtw_p2p_get_go_device_address(dev, info, wrqu, &extra[10]); + ret =3D rtw_p2p_get_go_device_address(dev, info, wrqu, &extra[10]); } else if (!memcmp(extra, "InvProc =3D", 8)) { wrqu->data.length -=3D 8; - rtw_p2p_get_invitation_procedure(dev, info, wrqu, &extra[8]); + ret =3D rtw_p2p_get_invitation_procedure(dev, info, wrqu, &extra[8]); } =20 return ret; --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E23D9C433EF for ; Sat, 29 Jan 2022 16:31:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352710AbiA2Qbw (ORCPT ); Sat, 29 Jan 2022 11:31:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352674AbiA2Qbt (ORCPT ); Sat, 29 Jan 2022 11:31:49 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03E5FC061714 for ; Sat, 29 Jan 2022 08:31:49 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id h14so8883298plf.1 for ; Sat, 29 Jan 2022 08:31:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Th8PVyYelZWCsFcO3s4hWSpijYoiPjQX9yudaKFZQco=; b=UTdYPZZph8EsAJuRqYnss+oruj9Z7o1I+TKpquPsJv5MGwF93vsHmNWTUr/hutsjJg Dge+8mILBYWEOKQMnzqXz8x5W3xIRUdZYk6x0YabTfDtCQAt/ddIpaE+op9XV+fk9MMe PER/0j6n9askSdZgwS1tPC/MOWkQe94pMafJMb9vpuJ+0CzxnC6dpOYpDc5cxyNDDqQw vwRrVaSvgpxK24Vn2orj2sDPZ2WoIwVARu0kBBkIpCHX7t1cn+eqXonzJY06hzV55Ryu MjCsP3/B2y8dvNqpgJxr0D0P6fAp8QIk9BQ3QBatZ00HTvcOx0uHKd+uS/REfV4h33++ 14pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Th8PVyYelZWCsFcO3s4hWSpijYoiPjQX9yudaKFZQco=; b=IRv+Bj+FesFdW4a6KN9X/WonMIFwlv5oTrDXdeE/LJAbR4jPeJIvCGlXv1JI1XFRGo 8TTBHa7tXC1lxNKclzBAcTzZ8c7Ki/Lj1JBBYHgxeHlYOTD2X2C2G7wIrmJJBl7JMQrd 2Oyte6Z2M3kBuiOn0ROZPqBsx0v293r9H81+58qN2BKXIWet3umMeNDPmLzB1mFrZSmu 7CLdrEpJPiYOISLLz4b1EVb5WmEkauxCZZusi40m599XRYzVYMUQbbP+wH6liRw+96Xx CAqKfXL1Ad9y0S6sTgytfiGluwQTO5aMUzwt2CjzoDN9mQwIrK0Ll4lU44fAqKuSMMSz JA6A== X-Gm-Message-State: AOAM530jyOxYnX1w0yYKD9Rz2nR5yyFrM17eXX4oXS1iiel4o2AlEE/R NRnX5D+uAQA7Y2DNsEozpzI= X-Google-Smtp-Source: ABdhPJynPVtFor8dKoPc0tEvfK703tA77lIEm8g7DHSvdjqcOn/m9uN8N6N1EB9qisseLzWkLIjj7w== X-Received: by 2002:a17:902:758c:: with SMTP id j12mr13491819pll.34.1643473908565; Sat, 29 Jan 2022 08:31:48 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:31:48 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 10/23] staging: r8188eu: convert rtw_p2p_set_go_nego_ssid to return void Date: Sat, 29 Jan 2022 21:58:02 +0530 Message-Id: <90e2b3e4ff99131423c11b8f9206916791f742d9.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_set_go_nego_ssid always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index 99c7f9369d2a..c761c06cf6e8 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2308,19 +2308,16 @@ static int rtw_wext_p2p_enable(struct net_device *d= ev, return ret; } =20 -static int rtw_p2p_set_go_nego_ssid(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_set_go_nego_ssid(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; =20 DBG_88E("[%s] ssid =3D %s, len =3D %zu\n", __func__, extra, strlen(extra)= ); memcpy(pwdinfo->nego_ssid, extra, strlen(extra)); pwdinfo->nego_ssidlen =3D strlen(extra); - - return ret; } =20 static int rtw_p2p_set_intent(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3217EC433F5 for ; Sat, 29 Jan 2022 16:31:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352726AbiA2Qb4 (ORCPT ); Sat, 29 Jan 2022 11:31:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352674AbiA2Qbw (ORCPT ); Sat, 29 Jan 2022 11:31:52 -0500 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A62E5C061741 for ; Sat, 29 Jan 2022 08:31:52 -0800 (PST) Received: by mail-pg1-x531.google.com with SMTP id v3so8084812pgc.1 for ; Sat, 29 Jan 2022 08:31:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=so3gw6VeXNqJCoBkFVd/9SWWTHocd9ttgxTU3TJ1cFo=; b=oRj7oImpt5kKgtkq/LCUN0tJ7NlEILepU9GYvZ5DFC5dRAQu6kJRcLlDWjrfV5/Ni0 UJLuQoQEIqHVG88zLmWY1Fhi6ibc4strwuB3wH15IjXjbYSaJ0fBig0tQp2yhIIyiYT0 hsRbIf7PbIsYwnjOenN/RRQKjWzeytRJxnXgjo2z/iYgTI6inEtoR/1Rvi2TRY75Q/78 4fMtN8wzn47m5g2qpKOrAHl5D2B/cRK/ShFEiOXr1TFCo+9QJQbiZMEXKTPfzx9rn/3s VgP4lUoReDS5mwgkWHpo6Y5FEqfk+CxA4RtswHKEHWZVereHfeUAqRWLUb/5CHV3ZIeA B2OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=so3gw6VeXNqJCoBkFVd/9SWWTHocd9ttgxTU3TJ1cFo=; b=7tx00GqwztMrGE9BaJKVswWgLm3ep4yWmeqYmO/k3rFsQQ+5bNMpTEU/QasMwMRHj3 42IgIecAGpg/1bVz69nqjEyu+ebd3U1POnXdgXnHZqXZ8XhQ7+hdZy6H6qrgWGW3BoHi 88nUA37Eb/flttZqaqwIEe1iEh4wDBmMXTnkMqmP0ENVGS2lgSYHaiWHroXKtQdt23Gd 0iS4RlEgF3Q5Pm8IUbf6fh5PUqa6GXQiD1zYRcJqHW0lmvcMYMT7OzhC7EK7AvDoUp/N oh0ABO4zu+ZuaaHj5a2fXdiugvd9OXgacsAYlW3lunNhyXnE8XZb46ZoHekJahmU3ydP W3BQ== X-Gm-Message-State: AOAM531Y0pm7K6RnI4rLfsnhrYVro7hl2ZGqzKjpnZHGkQD2ui7CAjS4 W9R5QMyzbfSO2FP+8aGi3Ws= X-Google-Smtp-Source: ABdhPJywahgk5tKO254vtnIjqc/UN165qbWeHmM9qQZ35ol/dR9A8AnVb08DAERzjSIEU641plBRiA== X-Received: by 2002:a63:8ac9:: with SMTP id y192mr10727739pgd.598.1643473912229; Sat, 29 Jan 2022 08:31:52 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.31.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:31:51 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 11/23] staging: r8188eu: convert rtw_p2p_setDN to return void Date: Sat, 29 Jan 2022 21:58:03 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_setDN always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index c761c06cf6e8..daaf808ca23e 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2453,11 +2453,10 @@ static int rtw_p2p_profilefound(struct net_device *= dev, return ret; } =20 -static int rtw_p2p_setDN(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_setDN(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; =20 @@ -2465,8 +2464,6 @@ static int rtw_p2p_setDN(struct net_device *dev, memset(pwdinfo->device_name, 0x00, WPS_MAX_DEVICE_NAME_LEN); memcpy(pwdinfo->device_name, extra, wrqu->data.length - 1); pwdinfo->device_name_len =3D wrqu->data.length - 1; - - return ret; } =20 static int rtw_p2p_get_status(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA965C433F5 for ; Sat, 29 Jan 2022 16:32:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352765AbiA2QcH (ORCPT ); Sat, 29 Jan 2022 11:32:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352680AbiA2Qbz (ORCPT ); Sat, 29 Jan 2022 11:31:55 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8CB6C06173B for ; Sat, 29 Jan 2022 08:31:55 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id z10-20020a17090acb0a00b001b520826011so13877599pjt.5 for ; Sat, 29 Jan 2022 08:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Mb5XVHLKhEOk/yXbWKnvcJOWOr308i/Z4c3YSiAFsaE=; b=IGwznrlFjCc7Dg4W52xaVzurlktI52HRfbLK9uZGBriiRCmHwDjyrTIDngntLnD5Wy tQJ8fV+eI9rQcWg41pGN1UMiCcoStZ1eRc4GTXIpll7qSdAvju7car9E8iM6GJJ9jBMx NrHJOPPbjM6qziCidMobsW890nVXnH/O264sHOm77x2BhQe95LlePPsST4coKgPn8C8e 1tVXZd1zIGOGR1HogxjBn8Ka3u9rVK3Uj7V0bpgSvFyDrgJ+YU+0M8xoa4956KkSMwr+ p2hxd00y+O/7Vz8lrIM3VfP6iUnxab3uT45rkASZz2i2NIkLt0wVKBM5uFDzq1k7ihWG Vdzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Mb5XVHLKhEOk/yXbWKnvcJOWOr308i/Z4c3YSiAFsaE=; b=YzhGQkNw/y7x3vWxxm090MZjmhEbX3oCgfUoyZDhP0CkCAZVKab9di5Z8NKJQTe63I ldirln5O6C467i3A1iOPkywhg1wVklxzUn5lbrCDfGW75JkWkiHbNX2R0NGT0aOCelMj vDhUUk6Nks/SVc2kafuIP+FZWg9lYh6tgEp72MTKLGeJm0Bu0Q6NI8N3JimMIpWLeqdt cJqOE/2UCgDfJnG7wZBlvKmSY596ZT55FzmufXQeCGobC+c9ystg4bkUe6LK/jxku/Ac 6CZizYUG4jzVfkivlsMz20bv1OhQs/Z91qPg30rwGNQQZeuc4850uw8CTZjB3rVABI4N f/Gg== X-Gm-Message-State: AOAM532MyEt13iruFQr7NZYO89wt0sEeuuyw/D6G8wMFN69MLuRF5V5N to9n/beh1okTMVZjfYXxmXM= X-Google-Smtp-Source: ABdhPJw2IiTmH5NvdXBTOeBunxNR1XG9f7yxZXqajR8wJRRPTbz0cOcO+ge+HIZF+vnHreJxnQMFtQ== X-Received: by 2002:a17:90b:4b52:: with SMTP id mi18mr15810316pjb.74.1643473915390; Sat, 29 Jan 2022 08:31:55 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:31:54 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 12/23] staging: r8188eu: convert rtw_p2p_get_status to return void Date: Sat, 29 Jan 2022 21:58:04 +0530 Message-Id: <832c53cc201111449fccb40326084d20f676e722.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_get_status always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index daaf808ca23e..d2db2117abc3 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2466,11 +2466,10 @@ static void rtw_p2p_setDN(struct net_device *dev, pwdinfo->device_name_len =3D wrqu->data.length - 1; } =20 -static int rtw_p2p_get_status(struct net_device *dev, +static void rtw_p2p_get_status(struct net_device *dev, struct iw_request_info *info, union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; =20 @@ -2484,8 +2483,6 @@ static int rtw_p2p_get_status(struct net_device *dev, /* About the "Role" information, we will use the new private IOCTL to get= the "Role" information. */ sprintf(extra, "\n\nStatus =3D%.2d\n", rtw_p2p_state(pwdinfo)); wrqu->data.length =3D strlen(extra); - - return ret; } =20 /* Commented by Albert 20110520 */ --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E4BC433EF for ; Sat, 29 Jan 2022 16:32:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352692AbiA2QcT (ORCPT ); Sat, 29 Jan 2022 11:32:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352760AbiA2QcH (ORCPT ); Sat, 29 Jan 2022 11:32:07 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D22FAC06174E for ; Sat, 29 Jan 2022 08:31:59 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id q63so9470169pja.1 for ; Sat, 29 Jan 2022 08:31:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3R4owqSK8BZyMrVti/Fku5/LEyT/MxkNC0b3ePI8Qs8=; b=l+/M0MUhMI5QsI0GpFoQHwMBb4SgBKO+/mxajCAtm1jCQ1dNRzJNbXwYihGCBDFU7F 9TZVsu7EkDDTltV2A9NsxPXPJN4SXjK5dsqgH3oRClEGnYPrxpnmsJCqviSnPKrPd31Z sqlz8eLKR5O00hpwc05vAl8/lqUIICxWPkK1tV+Imm8FPLDZkckMEhs41N7b1mF+jry3 U11MwbRJYDGFdcx/hTj276sdVHAWBSyMRCfsGmJPbf3+vzCE4J+LfTDgsj/ZfWQR6qk3 XO1VtRBCKsNhaeU4htYhDrxgwyofBmaB1LITsj6WCmMQzLIpA1zDV1Ry4lMkUayPrgcs 767Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3R4owqSK8BZyMrVti/Fku5/LEyT/MxkNC0b3ePI8Qs8=; b=2LPuMWHG1hhd1QlpdEP49wqH3FZ95U/Ug7KwZ1vyqXXX6d64uwuq2gJKVSu+S0OmS+ RKYy92wfq37Lev6+5sdbBJcVlguyyo2oRZwfGIwOu1h8D6d0dx6Y8IJvJOFtUn6EEP1T H3iRgfvAJvPI7G25dK/wcKepBzH4z5p9n7NXux2SdUE5GkxRklLcIUQUWF/RiAjlWPVv SegPg5ve5BjNJCxNzv+QlUMJ2N/QljS5S64SC0e0RmOf0hsPRZ6kNpFqsr7fMKPBeJoj i4K/b4w7SIljmrbgDqA3ic13nfYuOvwSyLt4wgNBKyH+BiOVvsXpfeXuQt1BKa4S65gM 2axg== X-Gm-Message-State: AOAM533MIjNvsyprt+mC1lqw/dy7AO7qzmjIVURWgxSGjah9IpDkbBsT Sza8WaqcKrARF/k0rFJ8EZQ= X-Google-Smtp-Source: ABdhPJxv7jM9zR68yPUTZ1ABwepRcoIi01irtYsmbM5yehKnXPibQnNeXxRQs8j5IpLbKm+DAHmtvA== X-Received: by 2002:a17:90b:17c1:: with SMTP id me1mr23507307pjb.182.1643473919419; Sat, 29 Jan 2022 08:31:59 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.31.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:31:58 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 13/23] staging: r8188eu: convert rtw_p2p_get_req_cm to return void Date: Sat, 29 Jan 2022 21:58:05 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_get_req_cm always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index d2db2117abc3..ba0f42ca36e3 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2490,17 +2490,15 @@ static void rtw_p2p_get_status(struct net_device *d= ev, /* This config method description will show us which config method the rem= ote P2P device is intended to use */ /* by sending the provisioning discovery request frame. */ =20 -static int rtw_p2p_get_req_cm(struct net_device *dev, +static void rtw_p2p_get_req_cm(struct net_device *dev, struct iw_request_info *info, union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; =20 sprintf(extra, "\n\nCM =3D%s\n", pwdinfo->rx_prov_disc_info.strconfig_met= hod_desc_of_prov_disc_req); wrqu->data.length =3D strlen(extra); - return ret; } =20 static int rtw_p2p_get_role(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE13C433EF for ; Sat, 29 Jan 2022 16:32:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352772AbiA2Qc2 (ORCPT ); Sat, 29 Jan 2022 11:32:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352762AbiA2QcH (ORCPT ); Sat, 29 Jan 2022 11:32:07 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED339C061753 for ; Sat, 29 Jan 2022 08:32:03 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id qe6-20020a17090b4f8600b001b7aaad65b9so3272617pjb.2 for ; Sat, 29 Jan 2022 08:32:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hU0AyPSwzXrTCpt2UBSbf+u4PcwXegon4P9WmWniS1g=; b=IICEJbqNAWzJcp8cdThF7LoXbzH50La22u0YiOoneBeq2Enxqnv9A7w5vC6xMft6sT epjSGYgO5VIHAsFw7ZsX4Qi7teSRkrcCK5UlBeWnFuE528FJLwEBaDmgaLBV2Z49l46F RxEH9fNXlEeEDyWBCphfup6jcpxZ1vU0eGZH5i7+cwnGgdFNbKyeN2ZvFPPRt/kk4iK4 22bYR1hyIopigEelA7qrgOmCoJ4+U4wm436hhHVZfQ+Lv0XuqQkGGYeqQl/0C2fEVmY4 PQB0aVVtR3f+ZC8huszc32kkrmol2CbLrst3NHaPvmc4aypFCAxFSD1o7ShHlCVSXWIR KAdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hU0AyPSwzXrTCpt2UBSbf+u4PcwXegon4P9WmWniS1g=; b=cHiSMjsnBO/r3yB8Xv3xnaYJZhqTS60Rt8CtzOD6DWLF69fDBGn6ESA4Qv0uNw1iur IRrJzjso5KjdTbwYF0b82T2zzfbw/YPmekjK0SLIkZaoQSgjxuQzrx9V6z4adfbmfktq b14JYe/RI2HzypvZVnXpQBvNwOdCOtgrL8iwn/XCmyhlMAHQ0PhEdY+uqqqk1zHLNpmu kjwm5oxT3b1hoI1BzJ+lDJPtsOEbxsDIWjFWVCpEWxus197yO7KmtNC3G4JrlkLSvoXY PubWrdsleVo3vnluPij4mxPEFaCQ7Ob8kRMYsGim9c8MDd12MICPtEtFTf73RfFB9k+x ygIg== X-Gm-Message-State: AOAM531EDPxTCoq5+QXA3x5qD+3A12N/bcn3wkgTQpyww+WN3DX9qyOC /u8gjxaO8Q5laaH26I/hwqs= X-Google-Smtp-Source: ABdhPJxwu0xEHWqGbZdvrUpXDJ2Y9bcRKty9vlked20WesWeLW3I0jh3WJseAbC2Rw2R3xTvMFPpxg== X-Received: by 2002:a17:90b:1e42:: with SMTP id pi2mr15927775pjb.176.1643473923554; Sat, 29 Jan 2022 08:32:03 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:32:03 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 14/23] staging: r8188eu: convert rtw_p2p_get_role to return void Date: Sat, 29 Jan 2022 21:58:06 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_get_role always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index ba0f42ca36e3..343b4ad6ce65 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2501,11 +2501,10 @@ static void rtw_p2p_get_req_cm(struct net_device *d= ev, wrqu->data.length =3D strlen(extra); } =20 -static int rtw_p2p_get_role(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_get_role(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; =20 @@ -2515,7 +2514,6 @@ static int rtw_p2p_get_role(struct net_device *dev, =20 sprintf(extra, "\n\nRole =3D%.2d\n", rtw_p2p_role(pwdinfo)); wrqu->data.length =3D strlen(extra); - return ret; } =20 static int rtw_p2p_get_peer_ifaddr(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5412CC433F5 for ; Sat, 29 Jan 2022 16:32:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352802AbiA2Qch (ORCPT ); Sat, 29 Jan 2022 11:32:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352780AbiA2QcO (ORCPT ); Sat, 29 Jan 2022 11:32:14 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE458C06173B for ; Sat, 29 Jan 2022 08:32:07 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id s6so3316309plg.12 for ; Sat, 29 Jan 2022 08:32:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k1fC8pgJCKW2AtBxBMf1LhdlL3aFtmP7ejxI3861g2c=; b=UaZWcvkx9dAVtN7KfWy0oIgSfqKPRE2rClc31qACpThl9h9edITZpYue6sqp45SIfG 5hVx/tvB7ovb76LJzfmvtyqrvk6NPGIcz/U0Z+4f/hrYV08laT83kIorCEj5tdBV0zxh 9/VRkIS8ig6fDWhYa1rxgq6sVdQOpFk6wwIH7q0NDNYzIPHVfd3sfObcaGdKNAoYtRQT UFxp/8Jd9FcF4Z7g9ExOLk5utUhiMAVMtvZfovXLALdhE+uSEa27oNGBMutMCTFr3vQH nO6CShVQRzisz6UOHsK6GIDxyESb49cWA2stlgYpX5GAiECB2mFE76kF33bYzOYrD+2H oxag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k1fC8pgJCKW2AtBxBMf1LhdlL3aFtmP7ejxI3861g2c=; b=a9I+yUoIzQqoDxLOFdcsFafLUHXvTcr2DUbczhwtcyVaZjVnErO4rHvGYw5W5UfE29 iV4569SQO/DnJCdsaikGlSzc38yLaNl1Vdmrdh212ppcAmPijr3LE/5ZiOuUyKnxpBh3 4NLwmrdJKHzbhAsYUpdCHvaoJuvHI3AcnDYNHdZZge1c96NsoloIbQQJ/czG3ElpbROV Og4k+0UEl2U9dXCJNHo29qPqjYK5Y5SkayCDki1dygpi+jYj/FiK/2bRe2sNJhK6tpFN xx+O5bDgdw0PSc45uZlCV6KIbTFF4C3oqm4/z251aCNWGhF2Vo9J0tsbmBECNHaokuJL YMNg== X-Gm-Message-State: AOAM530RAZq1Bq89/MYgQau15GyFJ7mz4qPMCzr0+ZsjrhKQQoAXOK22 jrQ0DDGRyp981c6HWVMAey8= X-Google-Smtp-Source: ABdhPJzmjnVf1GtaWXbEHiR/JpFr0sMrmNCzNXhzdcRWm/GBgDs9eNIBrK0x2/eOo511US5xXe4fDg== X-Received: by 2002:a17:902:f205:: with SMTP id m5mr13573098plc.71.1643473927298; Sat, 29 Jan 2022 08:32:07 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:32:06 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 15/23] staging: r8188eu: convert rtw_p2p_get_peer_ifaddr to return void Date: Sat, 29 Jan 2022 21:58:07 +0530 Message-Id: <4a51963ce86a5f6bed4c07e545cd64091eeb0a8a.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_get_peer_ifaddr always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index 343b4ad6ce65..1f89f4fe4d8e 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2516,11 +2516,10 @@ static void rtw_p2p_get_role(struct net_device *dev, wrqu->data.length =3D strlen(extra); } =20 -static int rtw_p2p_get_peer_ifaddr(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_get_peer_ifaddr(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; =20 @@ -2530,7 +2529,6 @@ static int rtw_p2p_get_peer_ifaddr(struct net_device = *dev, sprintf(extra, "\nMAC %pM", pwdinfo->p2p_peer_interface_addr); wrqu->data.length =3D strlen(extra); - return ret; } =20 static int rtw_p2p_get_peer_devaddr(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C8A6C433EF for ; Sat, 29 Jan 2022 16:32:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352831AbiA2Qcr (ORCPT ); Sat, 29 Jan 2022 11:32:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352728AbiA2QcP (ORCPT ); Sat, 29 Jan 2022 11:32:15 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB768C061757 for ; Sat, 29 Jan 2022 08:32:11 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id c9so8829434plg.11 for ; Sat, 29 Jan 2022 08:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VBYOJsyQo0pB3WhiZOo7z3RxhrzkZJZf25jJVH/qEs8=; b=bU0csZXhAShQ5Mt6KL1xFYVQo0e1TbiTW1dlUovLLfZsYO1YbjGwMgQ67WxCu1dNtD w3MuG5YhCVScXkKIB5iiBnK8Y8mWF7PygPQKH0LM4r+H5cuUFCSaZvzGAj1ibWOZWXwy whtC4QoCHf+GfiEt2KtKShj59gjQx6LwxXCRtxwHHG+k39EgvvIiQtIVLVPoFWFkmvA0 AwEkAPNmvG/9Luo27HcanC+dJn/QWAdAvGVkuCfhk58uV4XXp28Fuh3fT0O7K8MF5qju Bo3tK11V500KVJ7mdm23ch01hTCf8FDSFX+uRYACgvTje7fjGrwLuAydq9wXqWEO8LSM p81g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VBYOJsyQo0pB3WhiZOo7z3RxhrzkZJZf25jJVH/qEs8=; b=NMPcIt+FzmNkxjw8H10JKne2lBvYwaGb8/aMuKGIuMoB+wWNu99SueBNeO/Jfd4H/C LOM9+McZMCVnuoO/h7Cd6zLOFq4D4h9VwKxaDXhaY/mn3xbUWzXtXsyIRBmSyvXSFWI2 E6p9ysVWaukL6Ch3eZNGelKmGy4K2xWm2J3WFvjSDd5SxrhdDzHi5vXDXoeDw7NXQAJR OuFtxLMQfLcpjLXpFWy2k9WS5QV4wZOP6Vt43MN6CQZmYJ66VrYR90WOIbgpydIOxZxt 1t7nBzBbpZbFLNcQhE1ugKTacL5BVsG6xKmQVFHFZxky0DDeFlsFMZiZAnkGRxbfpt5X 6zMg== X-Gm-Message-State: AOAM532e2XErlAaCZT4M22FsEMzZzYRf0ieoVoQpE3/TTTUarg+8y3mp 4yVmAb/Gm2MnzXwva+lRxxc= X-Google-Smtp-Source: ABdhPJwd9x7z5p8k1SYwXF6Kgtt4b67Lz+PACdx3SAFvvaLqdjz5YlrBmMpslukdZw/Q/OH3VsaPoQ== X-Received: by 2002:a17:90b:3886:: with SMTP id mu6mr8528799pjb.231.1643473931209; Sat, 29 Jan 2022 08:32:11 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:32:10 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 16/23] staging: r8188eu: convert rtw_p2p_get_peer_devaddr to return void Date: Sat, 29 Jan 2022 21:58:08 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_get_peer_devaddr always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index 1f89f4fe4d8e..dfd19a649803 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2531,12 +2531,11 @@ static void rtw_p2p_get_peer_ifaddr(struct net_devi= ce *dev, wrqu->data.length =3D strlen(extra); } =20 -static int rtw_p2p_get_peer_devaddr(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_get_peer_devaddr(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) =20 { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; =20 @@ -2546,7 +2545,6 @@ static int rtw_p2p_get_peer_devaddr(struct net_device= *dev, sprintf(extra, "\n%pM", pwdinfo->rx_prov_disc_info.peerDevAddr); wrqu->data.length =3D strlen(extra); - return ret; } =20 static int rtw_p2p_get_peer_devaddr_by_invitation(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D24E6C433F5 for ; Sat, 29 Jan 2022 16:33:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352865AbiA2QdJ (ORCPT ); Sat, 29 Jan 2022 11:33:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352644AbiA2QcS (ORCPT ); Sat, 29 Jan 2022 11:32:18 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5CF7C061748 for ; Sat, 29 Jan 2022 08:32:15 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id c3so8860433pls.5 for ; Sat, 29 Jan 2022 08:32:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mk12BTSCM2+mq3xJbziWeOLcSVGsDqsbYqmoTpChlQM=; b=ae1z82YShCLldmO4lu1B2Nf5vJMnS3IS+SkfIuouT3SGDC0i92Joxo5b9sAR3T4s/u xMQnB7RCnrAhj3b3w348Ql6yn3+xLjWBotBRShWZjexpKPhom4EUeL0KzUVgEYDNvEOs nB3ZR9IHqdXYBEW1n9kzavhQJ1d5w/swDuzgzEbKXNSAHxpnOgnc39NCuq6MpEzBSsC8 wogeK7lBFtuV6n+XcsFnuThxAb6IWLH7KNqsi/sQ7g8xYoBQq7M/abJm6srYn9EQTGGm K2NE0b96HY6MAN6i6FkP4M3MD+4dtJeikuu0k+8mfscxfj03bmt+rLoBrkX3t7vqprsB UEGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mk12BTSCM2+mq3xJbziWeOLcSVGsDqsbYqmoTpChlQM=; b=eax4e3sMJx48l/cLVPCRrAxvA4qmtpbkSBibR90f1RG4G8l+xCzQrr/LQfM2/hw8SM opGvQpVwdibs5gSasgrjy/8WnzhY/HvaoDVIkbjkCb4BAEGO+/2sXBwigAb5ehHVG+N7 5lGoQjjTUXEe8RHwOVVPAy0zp75DafMx66t4tqMwZnrw9YlN7fpSf6bYyStFIr06W1pb AtXq+K7Y+SRJa65piRj2PcTFFJSjb6ZjAURzJLQ5ZyhoNd4Xv3dekfg43dOr+o6syX0s hibK/ZVqWEKTuxmvGxkKNal56glv+EDIb/c7xzMjasXJMGa3ZgWgV0A56dnyyGZgg4P2 n3aw== X-Gm-Message-State: AOAM532VW3PlALN/zYonc39MTBNi9O5N9KPDsBSxeKJQ938PDMBGkwC4 8Jast6aB672CaWXdej3MlFprXHjxwGw= X-Google-Smtp-Source: ABdhPJzcbwCW28uzSi7lJtVO/GFRCtdb7QsA72O+86uRV+z2LRZ28M2NQj9hsr9czem5ajQi2YT6yA== X-Received: by 2002:a17:90a:a385:: with SMTP id x5mr17242737pjp.129.1643473935287; Sat, 29 Jan 2022 08:32:15 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.32.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:32:14 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 17/23] staging: r8188eu: convert rtw_p2p_get_peer_devaddr_by_invitation to return void Date: Sat, 29 Jan 2022 21:58:09 +0530 Message-Id: <06e2dce5de14c1abe457a40ec9ca597a06095437.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_get_peer_devaddr_by_invitation always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index dfd19a649803..9ee647de5ba7 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2547,12 +2547,12 @@ static void rtw_p2p_get_peer_devaddr(struct net_dev= ice *dev, wrqu->data.length =3D strlen(extra); } =20 -static int rtw_p2p_get_peer_devaddr_by_invitation(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_get_peer_devaddr_by_invitation(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, + char *extra) =20 { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; =20 @@ -2562,7 +2562,6 @@ static int rtw_p2p_get_peer_devaddr_by_invitation(str= uct net_device *dev, sprintf(extra, "\nMAC %pM", pwdinfo->p2p_peer_device_addr); wrqu->data.length =3D strlen(extra); - return ret; } =20 static int rtw_p2p_get_groupid(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A37FC433F5 for ; Sat, 29 Jan 2022 16:33:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352880AbiA2QdT (ORCPT ); Sat, 29 Jan 2022 11:33:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352738AbiA2QcT (ORCPT ); Sat, 29 Jan 2022 11:32:19 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA6F5C061749 for ; Sat, 29 Jan 2022 08:32:19 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id h23so8036974pgk.11 for ; Sat, 29 Jan 2022 08:32:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VpVRaJzkm+JbIjqlEl728sQqMfSlR+afyO5cWMLCT/U=; b=ZZQAq/ag6BwNihmNPCYUtvhU11+52KEkNN0Gqs6Q/mrsVMdpr/RVp9bEOEnl7IgWNH EIgA02xreBYGRLTBtAnKgXO3RIVM8sTeUQ6BVRTdFQeFpF7fZw1JJFeeT1xVVSFs4A8f zD+E/mGoQvNX1Y1Lcslyejr1mvHULEquMkjiSxSMmtsRTMMtl4NC9s0wsd5lUn4RaB1z IRGo5WB7gYRfrOzTOJB76AN4T4BWi8EyodgP+KojS1yCu+0GUSQoFwS6uo3HvQ0+FDup rJwAND2V5r8AbprT89qgQ/G3TWYDf7ieNwKhwZ9HBTG2KqU9quTFT+2zyAGuhyMZYicM cTnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VpVRaJzkm+JbIjqlEl728sQqMfSlR+afyO5cWMLCT/U=; b=w0YkKPfNPicUjTb2GDk2jyhB/zh0B+Qz82jJzFIEC2L+dH4MgN5eIeqCzUfeJgrWpu D15RurDy6s64SmKmhlGyT9o2mCjYUeGSmqRDTy37A4hyO2W+1A12COonwcbTKQS+ozJx BuLWMrF1Mk9CLmdekLLDW1a7dH/Mcc+CBatgpu+Kou2mH2YMRKyk+FRLhKUGA3C8KFag a87YzZKOs4QOg9oqbH94sNc2C0NmKUxzhYNpYuCkBNLkUhlD1TlYlhxzmFSxEVBe7ZZs LEMGtyA42yhwtf+6Zmx51IlceLa5CVpMFejowR+WnArfCHTFmhq/0xJmhXiyuaVr+6v2 Sk/g== X-Gm-Message-State: AOAM531VUXEU0VEMVa9lzy5s9NamZc6U+V56FvyvaJx1y6Xx2822pUsZ QmzC0jgp5wPik2ap6AwdW+U= X-Google-Smtp-Source: ABdhPJyZgPBeUbsqNw8SEUrpjXlSFPO2IQ+BX9zynOH5EahF7aZT22Ef7+6ytTWwooExE48tL8c6HQ== X-Received: by 2002:a65:538e:: with SMTP id x14mr10615001pgq.58.1643473939501; Sat, 29 Jan 2022 08:32:19 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.32.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:32:19 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 18/23] staging: r8188eu: convert rtw_p2p_get_groupid to return void Date: Sat, 29 Jan 2022 21:58:10 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_get_groupid always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index 9ee647de5ba7..4c47e9bb7fc3 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2564,12 +2564,11 @@ static void rtw_p2p_get_peer_devaddr_by_invitation(= struct net_device *dev, wrqu->data.length =3D strlen(extra); } =20 -static int rtw_p2p_get_groupid(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_get_groupid(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) =20 { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; =20 @@ -2579,7 +2578,6 @@ static int rtw_p2p_get_groupid(struct net_device *dev, pwdinfo->groupid_info.go_device_addr[4], pwdinfo->groupid_info.go_device= _addr[5], pwdinfo->groupid_info.ssid); wrqu->data.length =3D strlen(extra); - return ret; } =20 static int rtw_p2p_get_op_ch(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21ACEC433F5 for ; Sat, 29 Jan 2022 16:33:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352893AbiA2Qd1 (ORCPT ); Sat, 29 Jan 2022 11:33:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352754AbiA2QcY (ORCPT ); Sat, 29 Jan 2022 11:32:24 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2A49C061751 for ; Sat, 29 Jan 2022 08:32:23 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id my12-20020a17090b4c8c00b001b528ba1cd7so9403085pjb.1 for ; Sat, 29 Jan 2022 08:32:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7YT3Q4CQUgdlYmGODWsqMTkvALuQeDNDukSqX/SKoEs=; b=UJ9gHF+mZhKou88TjeyQUzHoDkNLxfp5fo2k8OhyxVsJWI6Xhl9ucMZhNJcIZ4CC5E /fZK/VH2++EuTiOSuQevZE37cLPg9I7tHUVJlLZulJ++wwu3W1Xq3KVY4MS+wa3unclo /MDnXfXWJX13tOMsp/IyOWwH5cC0DmQcSPSEW81vFk+5oecEUijY3Ir28Mp072ZCDVcL q4z2gQeHVM1YltwR6O7Rx/spxNekLZDeuwvR7R/+3W290AZ28LTs/AcrndGWNoAHsh+U t5XvMlEr5vlySue0Vw/he0eIsUgyhEHoQCie95Nu1jnaYtLZWYUp76svAUdfInP4QmIX 6q2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7YT3Q4CQUgdlYmGODWsqMTkvALuQeDNDukSqX/SKoEs=; b=TfX7/E6dDG0PO37vV58KVe7TKBnqTfzqJryTdekEHd+3ddbbt+9C5p+VH06CVD5tRG 9Mo5c6nZGEpNyyRh5ZofaVKxrnRAZql+0Qh3yRuznsDc7T8Y9eJWatGMxsFrc3AOu5ZT vxAY56Nf7FGwU5Cq8zpuNfZg/FxuUK+7IuFSYber8zQAoitb3RZjfkPFfl4E2cAgjncM 6ehbd6x56azEl+O261Zj5CQa//0sCHrORp24mg+xSpxs/FXKPe4DMLN+pCfmoCUeB/2x +bhMCfssxWUIq5XzL4Fdo5Ydd2o38UOGHHrpCI6h9Nxws0MOSp/hFYvIyJ5ktm+A8vxM sEow== X-Gm-Message-State: AOAM532JNlbjMeXAWWhrD5j+L8ZrUCyrCkfDtvnCMYMSTz5NNVcMIAgg e4/3RZdNBGBWTVUsy0x9SmE= X-Google-Smtp-Source: ABdhPJxowfEqLA8zSYaQUOWqpgaObNqnKf143vzS75ugBMx1F8ZqDp8AlbsLF5VwCLq3T2W7sT++OQ== X-Received: by 2002:a17:902:8d81:: with SMTP id v1mr13593010plo.20.1643473943346; Sat, 29 Jan 2022 08:32:23 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.32.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:32:22 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 19/23] staging: r8188eu: convert rtw_p2p_get_op_ch to return void Date: Sat, 29 Jan 2022 21:58:11 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_get_op_ch always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index 4c47e9bb7fc3..f533f709ead5 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -2580,12 +2580,11 @@ static void rtw_p2p_get_groupid(struct net_device *= dev, wrqu->data.length =3D strlen(extra); } =20 -static int rtw_p2p_get_op_ch(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_get_op_ch(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) =20 { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; =20 @@ -2593,7 +2592,6 @@ static int rtw_p2p_get_op_ch(struct net_device *dev, =20 sprintf(extra, "\n\nOp_ch =3D%.2d\n", pwdinfo->operating_channel); wrqu->data.length =3D strlen(extra); - return ret; } =20 static int rtw_p2p_get_wps_configmethod(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09D31C433EF for ; Sat, 29 Jan 2022 16:33:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352813AbiA2Qdb (ORCPT ); Sat, 29 Jan 2022 11:33:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352784AbiA2Qc1 (ORCPT ); Sat, 29 Jan 2022 11:32:27 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7864CC061755 for ; Sat, 29 Jan 2022 08:32:27 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id e28so8979939pfj.5 for ; Sat, 29 Jan 2022 08:32:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BnoXAnXc7/IIDarFMwEmp9tL1k9KPEgWxwtn8l7GULc=; b=Zsa/gs4ZU47pZFFCHFUEFfOWyOLuFJ1RiRoMESPYwpbEzhHcyzYSELyD4qM1Nq9t5K K7NBPzURaI6f9zk4s98j07QJ24qwCSKwbHtjwuiG8mY7EhhL/hxeCe/lhSN0sQ/CYAaL ZFQf7kgWh6KE/42Wgq0BGfpQYCFqe543B8tP9cqaBbzi7tdWAHBkUVdqDLc6lucH9gVb 55ciqv/u2GnqPhBvVU5ipGf6o2NykKk/m+lpOLzlnVizcgBQvUXPRdyZYQmxnsEPBNY9 UtnbBHHIDUfkkTTFc6AAfBnRHcDh/ED4M24HigLcxB0yHB5yUpE5/AVbwUHp0vXd586b gbqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BnoXAnXc7/IIDarFMwEmp9tL1k9KPEgWxwtn8l7GULc=; b=Ut2Os37lgU2V7MnXSXhkQTNtPnQC4BIWcEB86q/oDUyxax2HPcMvLWLpkmOJTPLEXH ErP1avm3UzFvIhPgPzD++aURqFI1Jui+lOM7jUZwBdl4QMTTjDRjkRH99jIWRmXnUfTM 5zuI/+dN0EaCbOFPhsHPWmv4AXG0yalmDsLXs24FRPjBWOl0Zeo58EIg/lIKcSDXwazN 1iS+x/GiNgUKHfBozz+FCFrRCAhRdotUC7JGtYPkOiHQGvbN3sMnxhksROwZGNLIf1/W GTQOKBOA9A6mRWXBayD6r7wKpxA9aCGOZyzu5V1MrigoTBmqtXreerV3vLBEj6+Sk6as zoKA== X-Gm-Message-State: AOAM532s3W+xeDRQ/w1vQjAlWyJblk8Jf9QLo4ZG+rLv8A64gXEPEMDs VW6lm5KNgB+cXtwgWRwg+MI= X-Google-Smtp-Source: ABdhPJzRcGKjBKM430X6B5REQ9rLilY5C1qwlhWgHKtdvey+khbdxfzmo+T1DQ5zuZfN5OqiqiiNgg== X-Received: by 2002:a65:51cd:: with SMTP id i13mr10666141pgq.412.1643473947056; Sat, 29 Jan 2022 08:32:27 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.32.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:32:26 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 20/23] staging: r8188eu: convert rtw_p2p_invite_req to return void Date: Sat, 29 Jan 2022 21:58:12 +0530 Message-Id: <059a21d40a5c6cbe621ca969f9d32ea89bc9a977.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_invite_req always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index f533f709ead5..6375b3776168 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -3037,11 +3037,10 @@ static int rtw_p2p_connect(struct net_device *dev, return ret; } =20 -static int rtw_p2p_invite_req(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_invite_req(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; int jj, kk; @@ -3065,12 +3064,12 @@ static int rtw_p2p_invite_req(struct net_device *de= v, =20 if (wrqu->data.length <=3D 37) { DBG_88E("[%s] Wrong format!\n", __func__); - return ret; + return; } =20 if (rtw_p2p_chk_state(pwdinfo, P2P_STATE_NONE)) { DBG_88E("[%s] WiFi Direct is disable!\n", __func__); - return ret; + return; } else { /* Reset the content of struct tx_invite_req_info */ pinvite_req_info->benable =3D false; @@ -3143,7 +3142,6 @@ static int rtw_p2p_invite_req(struct net_device *dev, } else { DBG_88E("[%s] NOT Found in the Scanning Queue!\n", __func__); } - return ret; } =20 static int rtw_p2p_set_persistent(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7FCAC433EF for ; Sat, 29 Jan 2022 16:33:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352748AbiA2Qd5 (ORCPT ); Sat, 29 Jan 2022 11:33:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352790AbiA2Qcc (ORCPT ); Sat, 29 Jan 2022 11:32:32 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45582C061741 for ; Sat, 29 Jan 2022 08:32:31 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id my12-20020a17090b4c8c00b001b528ba1cd7so9403262pjb.1 for ; Sat, 29 Jan 2022 08:32:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QgVStoddJ2w47VmtVxqI0lQhmbBW93rYRLMmc+SnhhA=; b=dZ2KT1HoDao2BU7s+nRlVVTxk67LlW7tVY2D9+NzUgmfbrcJLsJuoJnrNpsq/tKPPf iW2X+7Upl5AIsACBgMXIXYqzoH0M2G02SPWEz9ooXvbJjiuR8ChropZBxbZoo3qlcEFI vNY9UcM9Z8stYlzPxupg4am9gbkA7liF0Q9nW1b8hT3U0Lz48dWy5P/yRgDRDgvfteIs 4C4kJUdE0ktoTfPAMFNZfBA+vdkWgZV/SlG7Z+2YNnsgtOx4bA9LIJcpgq5jFJb21GpB JKzPO7iyRyow/wbo28tCk3eKtXToSgykkwa/nngH/GXchhMIjmsBoKyFdaGgwgSkOLH3 bh0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QgVStoddJ2w47VmtVxqI0lQhmbBW93rYRLMmc+SnhhA=; b=iLrvjrksnl7XRBODh0oOhib++hRjW+TQQJvxqst5J5yXj5fUQ09rZRFzCJmRtZt4eM D8BSTLBp/TWY9TCFew7TkF4SRjN6hEYumA16vQuQlmf2Ch2fpeaakwiJpjTHjf/ADJIJ VUiIuN9lb5wnlF/j0mpIonK1vLH1YToWU9HVmn52TtVe92XzOmdKiitAIlrmIrUtPBrI 3Xo9yD4uAs9QOn/iWUb7h1woBX6PpGaEdbRoL8aCR1rsrg7nIcstxjT+XQpYoOyaSkiW R9RrVVjw9woRf95ejmBnTgTU26M5xiM2oNcdSW9ikGXDIecGZH82CFp9mB/eMd9AnXlT X7Tg== X-Gm-Message-State: AOAM530c2OEefMezkTOw9NMLYwrfTkmoyKJvg/EYKadqxNbIsg5svHAX 1MiWOvLV0gsVAOozE7EnHHE= X-Google-Smtp-Source: ABdhPJzrR1aBjCtdoMyzZpJiMv34QFkG2JXs5DuRUtQ86k4ciiGJBedk3DvpJ0S3xxraUZ0oxzt42A== X-Received: by 2002:a17:902:ab46:: with SMTP id ij6mr13774843plb.164.1643473950855; Sat, 29 Jan 2022 08:32:30 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:32:30 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 21/23] staging: r8188eu: convert rtw_p2p_set_persistent to return void Date: Sat, 29 Jan 2022 21:58:13 +0530 Message-Id: <2f23981bcdf4177327b9a29e88540380ef627aab.1643466748.git.abdun.nihaal@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_set_persistent always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index 6375b3776168..4c778cf92680 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -3144,11 +3144,10 @@ static void rtw_p2p_invite_req(struct net_device *d= ev, } } =20 -static int rtw_p2p_set_persistent(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_set_persistent(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; =20 @@ -3160,7 +3159,7 @@ static int rtw_p2p_set_persistent(struct net_device *= dev, =20 if (rtw_p2p_chk_state(pwdinfo, P2P_STATE_NONE)) { DBG_88E("[%s] WiFi Direct is disable!\n", __func__); - return ret; + return; } else { if (extra[0] =3D=3D '0') /* Disable the persistent group function. */ pwdinfo->persistent_supported =3D false; @@ -3170,7 +3169,6 @@ static int rtw_p2p_set_persistent(struct net_device *= dev, pwdinfo->persistent_supported =3D false; } pr_info("[%s] persistent_supported =3D %d\n", __func__, pwdinfo->persiste= nt_supported); - return ret; } =20 static int rtw_p2p_prov_disc(struct net_device *dev, --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9092AC433EF for ; Sat, 29 Jan 2022 16:33:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352915AbiA2Qdu (ORCPT ); Sat, 29 Jan 2022 11:33:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352798AbiA2Qcf (ORCPT ); Sat, 29 Jan 2022 11:32:35 -0500 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44A51C06175A for ; Sat, 29 Jan 2022 08:32:35 -0800 (PST) Received: by mail-pg1-x531.google.com with SMTP id p125so8069725pga.2 for ; Sat, 29 Jan 2022 08:32:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tUqRPe41F16/TIkhlkuc7qmLwMC4mtGG1eE6VsNQEHg=; b=hoQaPDvZJtvTfDY93i9UWOxAzo0ximI8UhHMz9knb5tN2mgJdK3tHbm3Z+JqTLJUn5 ZRASzabEZmVdWhAfO0HZRzMi/VH0cCL4nT9c3CgtGCFz/aKl7c/qu6Te4CMVKllHU8bq 4436LAqwlFPZATaOB8VuyjkKMo9/pfpqwIsaQe4fjIrxq9d3AhE4zVHqrrE2WcdcJIXR 4DuX0TvgR569/hPKUiq5GiV3iECFwy+32x2WZKyk/qklI/32D4ImdaPuPXvnvbhT0TYK ZP8r1zWWSfKQr0se+5925WlhSbaMRBAgg9yhT4DnQV6lL6m+yq8rlK0xWiclfwcStyhp qWvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tUqRPe41F16/TIkhlkuc7qmLwMC4mtGG1eE6VsNQEHg=; b=YuCDIG1kjBtYSz/pG9XVrbnqIZUSopyh1tpJFAVnExbndqgYyXGVYyjj4vAK1YAlYj fbBi0Kdjyk+Yr7KWzBSC0j8vzMEjtkQujQFS3ZeqNfZ8s3UnzeJJFg2I0kuKGJZ7erZO 0Bi6wN29ghhExXrahepkBfn4nZEBCSMIbU04v2DBZx5axOttSDCuLfT/6DAWBnSiKBY3 nUtnX248o+ouJ/H26b3SGz4gPGLX0zQNlayxcyvLz3MjsjyKS9H3ZZNjuc88qQSMABKG GjSgN7ByH2NvnGdlr61TbRVWTENTP9GoL1XCw28ZsQnGuiuy4fFoQE1CnALqlAQYFNhm wikw== X-Gm-Message-State: AOAM532T1knyssJa/WXfW7eCSyzKIq9RdT3X1baLb48QPoG/8f8dVkRb JrMVBNW7pO6mtuJK6q2D+eQ= X-Google-Smtp-Source: ABdhPJzS/o1IrVP/jXSHA0oN1aBVQvMIWvShKO6zWQKGwSfSnLIHw+mKYeKqbtKYTNGouUDkNBpbwA== X-Received: by 2002:a63:5908:: with SMTP id n8mr10606724pgb.390.1643473954849; Sat, 29 Jan 2022 08:32:34 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.32.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:32:34 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 22/23] staging: r8188eu: convert rtw_p2p_prov_disc to return void Date: Sat, 29 Jan 2022 21:58:14 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_prov_disc always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index 4c778cf92680..1af8b2c068b8 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -3171,11 +3171,10 @@ static void rtw_p2p_set_persistent(struct net_devic= e *dev, pr_info("[%s] persistent_supported =3D %d\n", __func__, pwdinfo->persiste= nt_supported); } =20 -static int rtw_p2p_prov_disc(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_prov_disc(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; u8 peerMAC[ETH_ALEN] =3D {0x00}; @@ -3201,7 +3200,7 @@ static int rtw_p2p_prov_disc(struct net_device *dev, =20 if (pwdinfo->p2p_state =3D=3D P2P_STATE_NONE) { DBG_88E("[%s] WiFi Direct is disable!\n", __func__); - return ret; + return; } else { /* Reset the content of struct tx_provdisc_req_info excluded the wps_con= fig_method_request. */ memset(pwdinfo->tx_prov_disc_info.peerDevAddr, 0x00, ETH_ALEN); @@ -3225,7 +3224,7 @@ static int rtw_p2p_prov_disc(struct net_device *dev, pwdinfo->tx_prov_disc_info.wps_config_method_request =3D WPS_CM_LABEL; } else { DBG_88E("[%s] Unknown WPS config methodn", __func__); - return ret; + return; } =20 spin_lock_bh(&pmlmepriv->scanned_queue.lock); @@ -3297,7 +3296,6 @@ static int rtw_p2p_prov_disc(struct net_device *dev, } else { DBG_88E("[%s] NOT Found in the Scanning Queue!\n", __func__); } - return ret; } =20 /* This function is used to inform the driver the user had specified the p= in code value or pbc */ --=20 2.34.1 From nobody Mon Jun 29 23:56:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2437DC433EF for ; Sat, 29 Jan 2022 16:33:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352845AbiA2Qdj (ORCPT ); Sat, 29 Jan 2022 11:33:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352848AbiA2Qc6 (ORCPT ); Sat, 29 Jan 2022 11:32:58 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1048DC06175C for ; Sat, 29 Jan 2022 08:32:39 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id b15so8881443plg.3 for ; Sat, 29 Jan 2022 08:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HB3rD200TcYiLs5tsvdXeI+ibi+B/S+l18YmlgU5fCE=; b=FF2HNd+zuYsbL5g/5i0PUuE/ezTQauFPKnMkcuHyUpOqAdAwCchqRXMueOaHkx0NQZ zQa/r14k1efRYzFBX/9va6h7buyryd2qCHowI4pQ6meFEEP9W/4WINrUV0K967c+1b1R rFn1Nhq5VLKzmxzBpngECcLDPYMYZWO7GOeP2t+U7l0zZWE5GSF/oCEe0G/jdCCuIVfy dkn7BwizAj+c5mvHdKHh9dGzs9ebOrdyR15GDBYGFw9PbsD0dR7TBSQHmA1w0KHb0cER cdRGIfuf3ythKCscRz4IkUpseDFmbIMpifltGQCfgJNcttJPr8gmXZK8WxnJppX713V6 Dzvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HB3rD200TcYiLs5tsvdXeI+ibi+B/S+l18YmlgU5fCE=; b=UC6/SUYWSDqpUaiJUZILSJZTziV/2594CysOpyvU1yuBjW/0BZ/Xc1pDKEOoyutUjM elaO860piPGIm8BDUxSSxTOY5hftwhhsReAKf9RDtwAcJOT5P10+kC44CEODVe5Ciav/ R3tcyGdlYIisAheC1vnFc3cH9o8OIFBO6nNIuTDdcqYm3ucxEnj4i1ET+WtdSM/X4Wyy 9O08Tn2Vux2RqxVogdWUUyxzcjlUPVXfJWzkCTzgB6JXTGRPHIU+cTaS8sbh0p7Xha7Q p3r2YIJRbmsIEUXZGmJSqJdeUwRRs92p1W8VBBe3+DovH3pMMuOTR0bmt79t5BaUAzxA yZxw== X-Gm-Message-State: AOAM530hDFbNncXQX+XCcLz5wjxcOjEg7okjEQdQa+bgcQuuyr14zBFP DXOJh+1UB1/7INPETnrvCDM= X-Google-Smtp-Source: ABdhPJwzF4IZ8/LW/oEI2adx+41W+RVXEkFWhs93pWHft5RlATLB++QwJKhjwvXdCOrCOg3y50ndvg== X-Received: by 2002:a17:90b:1983:: with SMTP id mv3mr15877594pjb.222.1643473958680; Sat, 29 Jan 2022 08:32:38 -0800 (PST) Received: from localhost.localdomain ([171.78.146.184]) by smtp.googlemail.com with ESMTPSA id q13sm1893528pfj.44.2022.01.29.08.32.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jan 2022 08:32:38 -0800 (PST) From: Abdun Nihaal To: gregkh@linuxfoundation.org Cc: Abdun Nihaal , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 23/23] staging: r8188eu: convert rtw_p2p_got_wpsinfo to return void Date: Sat, 29 Jan 2022 21:58:15 +0530 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rtw_p2p_got_wpsinfo always returns 0 and it's return value is not used. Convert it to return void. Suggested-by: Greg Kroah-Hartman Signed-off-by: Abdun Nihaal --- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging= /r8188eu/os_dep/ioctl_linux.c index 1af8b2c068b8..c54ec5602ddf 100644 --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c @@ -3301,11 +3301,10 @@ static void rtw_p2p_prov_disc(struct net_device *de= v, /* This function is used to inform the driver the user had specified the p= in code value or pbc */ /* to application. */ =20 -static int rtw_p2p_got_wpsinfo(struct net_device *dev, - struct iw_request_info *info, - union iwreq_data *wrqu, char *extra) +static void rtw_p2p_got_wpsinfo(struct net_device *dev, + struct iw_request_info *info, + union iwreq_data *wrqu, char *extra) { - int ret =3D 0; struct adapter *padapter =3D (struct adapter *)rtw_netdev_priv(dev); struct wifidirect_info *pwdinfo =3D &padapter->wdinfo; =20 @@ -3326,7 +3325,6 @@ static int rtw_p2p_got_wpsinfo(struct net_device *dev, pwdinfo->ui_got_wps_info =3D P2P_GOT_WPSINFO_PBC; else pwdinfo->ui_got_wps_info =3D P2P_NO_WPSINFO; - return ret; } =20 static int rtw_p2p_set(struct net_device *dev, --=20 2.34.1