From nobody Wed Jul 1 00:46:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEFD3C433EF for ; Wed, 5 Jan 2022 20:36:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244087AbiAEUgj (ORCPT ); Wed, 5 Jan 2022 15:36:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244036AbiAEUgi (ORCPT ); Wed, 5 Jan 2022 15:36:38 -0500 Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FC8DC061245 for ; Wed, 5 Jan 2022 12:36:38 -0800 (PST) Received: by mail-ua1-x934.google.com with SMTP id y4so673631uad.1 for ; Wed, 05 Jan 2022 12:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5gb7wMy8ZrLt7CBYzP3rVZ32f9z9T6WftfdAjyIQOBo=; b=igYfSkah7NMeAEGpYRe72E98mSwU65Uxq1dOX9EfS5GCNIKO7+McYEFMaHbIMsvT2I 6p8tUwC1Ox62vSux9bAnRFOJVdea6ot00wyHCoZcRuA2Lt73tbK1jWOrN43F2Daw2a0A +ly23bjLw8diKVlPgOWIsVA3201K+GWdbr8aD6f+4A7WJUd+85o7b188jZJ5OblRbNKS zJ0ACJQdqxDGzf9hX33DmylfSCm7Y98Fos/SThGpV88JJJ4McStO7DIFG+6wzNpUDQ49 cJTOXxckhF+0nypYda30g6zfHqAqXyjS1l7mIvW7Hx1KpFGTWvQJpVzV9yur6/OIpXkP HfLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5gb7wMy8ZrLt7CBYzP3rVZ32f9z9T6WftfdAjyIQOBo=; b=TFJKRxSC57WVbb7RkOOEDmhHz0EWlEC1sDXtAQPJZ/ekOo3rELgFORw7BZKBIqHSRF rHWeiARaSUzS1pfd56fU97+sLnehEKsMW1+GrM1aCwLP4Ji0Y71rkeX7Pu2mZAkfmq3a 27jha389XoEJo3b2exk7Fv155yAO6f/BUtvDebqlrsPtLL96u2y9PkPmuO6HmwvxXJEz pdKu8fZn0h1a7CGEGi4H+UaMeMzGJOuoepEuVYmssZuTFuyltMcWb51RlDFv/v6IRbBx YbPPmcU+BfcK7850J1Rmm69GOWw6dmTQrTEX0KO2N/Rtxay0sFzzAxngg2OxzdZitCXy AXag== X-Gm-Message-State: AOAM531ZfJO5gFzzcQF7SxYfwW7sFqkBg7x2Ka4M32v+MRBuj9Cpv/dV znE521XHaEhU2smU3zHUHgY= X-Google-Smtp-Source: ABdhPJxZVI4ORTO8tgh27G9/+Z97ze3uXHBH7Yrmv1eKh2ao1x86MrTYtC+8pgw9B7LwNMRiG2x/Mg== X-Received: by 2002:a05:6102:548c:: with SMTP id bk12mr17253687vsb.87.1641414997273; Wed, 05 Jan 2022 12:36:37 -0800 (PST) Received: from localhost.localdomain ([181.22.170.52]) by smtp.gmail.com with ESMTPSA id t130sm7860vkc.32.2022.01.05.12.36.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 12:36:36 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, len.baker@gmx.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 1/6] staging: vc04_services: rename structures bm2835_mmal_dev and bm2835_mmal_v4l2_ctrl Date: Wed, 5 Jan 2022 17:35:43 -0300 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In the kernel, all names related to the chip BCM2835 are always named bcm2835_*. To avoid confusion, and to make things more consistent, rename the structures bm2835_mmal_dev and bm2835_mmal_v4l2_ctrl accordingly. While at it, one realignment was made to improve readability. Suggested-by: Stefan Wahren Signed-off-by: Gaston Gonzalez --- .../bcm2835-camera/bcm2835-camera.c | 68 ++++++------- .../bcm2835-camera/bcm2835-camera.h | 8 +- .../vc04_services/bcm2835-camera/controls.c | 99 +++++++++---------- 3 files changed, 87 insertions(+), 88 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c = b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index 1b184d5c6b82..109021643c3f 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -64,7 +64,7 @@ MODULE_PARM_DESC(max_video_height, "Threshold for video m= ode"); static atomic_t camera_instance =3D ATOMIC_INIT(0); =20 /* global device data array */ -static struct bm2835_mmal_dev *gdev[MAX_BCM2835_CAMERAS]; +static struct bcm2835_mmal_dev *gdev[MAX_BCM2835_CAMERAS]; =20 #define FPS_MIN 1 #define FPS_MAX 90 @@ -210,7 +210,7 @@ static int queue_setup(struct vb2_queue *vq, unsigned int *nbuffers, unsigned int *nplanes, unsigned int sizes[], struct device *alloc_ctxs[]) { - struct bm2835_mmal_dev *dev =3D vb2_get_drv_priv(vq); + struct bcm2835_mmal_dev *dev =3D vb2_get_drv_priv(vq); unsigned long size; =20 /* refuse queue setup if port is not configured */ @@ -265,7 +265,7 @@ static int queue_setup(struct vb2_queue *vq, =20 static int buffer_init(struct vb2_buffer *vb) { - struct bm2835_mmal_dev *dev =3D vb2_get_drv_priv(vb->vb2_queue); + struct bcm2835_mmal_dev *dev =3D vb2_get_drv_priv(vb->vb2_queue); struct vb2_v4l2_buffer *vb2 =3D to_vb2_v4l2_buffer(vb); struct vb2_mmal_buffer *buf =3D container_of(vb2, struct vb2_mmal_buffer, vb); @@ -280,7 +280,7 @@ static int buffer_init(struct vb2_buffer *vb) =20 static int buffer_prepare(struct vb2_buffer *vb) { - struct bm2835_mmal_dev *dev =3D vb2_get_drv_priv(vb->vb2_queue); + struct bcm2835_mmal_dev *dev =3D vb2_get_drv_priv(vb->vb2_queue); unsigned long size; =20 v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, "%s: dev:%p, vb %p\n", @@ -302,7 +302,7 @@ static int buffer_prepare(struct vb2_buffer *vb) =20 static void buffer_cleanup(struct vb2_buffer *vb) { - struct bm2835_mmal_dev *dev =3D vb2_get_drv_priv(vb->vb2_queue); + struct bcm2835_mmal_dev *dev =3D vb2_get_drv_priv(vb->vb2_queue); struct vb2_v4l2_buffer *vb2 =3D to_vb2_v4l2_buffer(vb); struct vb2_mmal_buffer *buf =3D container_of(vb2, struct vb2_mmal_buffer, vb); @@ -313,7 +313,7 @@ static void buffer_cleanup(struct vb2_buffer *vb) mmal_vchi_buffer_cleanup(&buf->mmal); } =20 -static inline bool is_capturing(struct bm2835_mmal_dev *dev) +static inline bool is_capturing(struct bcm2835_mmal_dev *dev) { return dev->capture.camera_port =3D=3D &dev->component[COMP_CAMERA]->output[CAM_PORT_CAPTURE]; @@ -324,7 +324,7 @@ static void buffer_cb(struct vchiq_mmal_instance *insta= nce, int status, struct mmal_buffer *mmal_buf) { - struct bm2835_mmal_dev *dev =3D port->cb_ctx; + struct bcm2835_mmal_dev *dev =3D port->cb_ctx; struct vb2_mmal_buffer *buf =3D container_of(mmal_buf, struct vb2_mmal_buffer, mmal); =20 @@ -416,7 +416,7 @@ static void buffer_cb(struct vchiq_mmal_instance *insta= nce, } } =20 -static int enable_camera(struct bm2835_mmal_dev *dev) +static int enable_camera(struct bcm2835_mmal_dev *dev) { int ret; =20 @@ -447,7 +447,7 @@ static int enable_camera(struct bm2835_mmal_dev *dev) return 0; } =20 -static int disable_camera(struct bm2835_mmal_dev *dev) +static int disable_camera(struct bcm2835_mmal_dev *dev) { int ret; =20 @@ -482,7 +482,7 @@ static int disable_camera(struct bm2835_mmal_dev *dev) =20 static void buffer_queue(struct vb2_buffer *vb) { - struct bm2835_mmal_dev *dev =3D vb2_get_drv_priv(vb->vb2_queue); + struct bcm2835_mmal_dev *dev =3D vb2_get_drv_priv(vb->vb2_queue); struct vb2_v4l2_buffer *vb2 =3D to_vb2_v4l2_buffer(vb); struct vb2_mmal_buffer *buf =3D container_of(vb2, struct vb2_mmal_buffer, vb); @@ -501,7 +501,7 @@ static void buffer_queue(struct vb2_buffer *vb) =20 static int start_streaming(struct vb2_queue *vq, unsigned int count) { - struct bm2835_mmal_dev *dev =3D vb2_get_drv_priv(vq); + struct bcm2835_mmal_dev *dev =3D vb2_get_drv_priv(vq); int ret; u32 parameter_size; =20 @@ -596,7 +596,7 @@ static void stop_streaming(struct vb2_queue *vq) { int ret; unsigned long timeout; - struct bm2835_mmal_dev *dev =3D vb2_get_drv_priv(vq); + struct bcm2835_mmal_dev *dev =3D vb2_get_drv_priv(vq); struct vchiq_mmal_port *port =3D dev->capture.port; =20 v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, "%s: dev:%p\n", @@ -671,7 +671,7 @@ static const struct vb2_ops bm2835_mmal_video_qops =3D { * ------------------------------------------------------------------ */ =20 -static int set_overlay_params(struct bm2835_mmal_dev *dev, +static int set_overlay_params(struct bcm2835_mmal_dev *dev, struct vchiq_mmal_port *port) { struct mmal_parameter_displayregion prev_config =3D { @@ -713,7 +713,7 @@ static int vidioc_enum_fmt_vid_overlay(struct file *fil= e, void *priv, static int vidioc_g_fmt_vid_overlay(struct file *file, void *priv, struct v4l2_format *f) { - struct bm2835_mmal_dev *dev =3D video_drvdata(file); + struct bcm2835_mmal_dev *dev =3D video_drvdata(file); =20 f->fmt.win =3D dev->overlay; =20 @@ -723,7 +723,7 @@ static int vidioc_g_fmt_vid_overlay(struct file *file, = void *priv, static int vidioc_try_fmt_vid_overlay(struct file *file, void *priv, struct v4l2_format *f) { - struct bm2835_mmal_dev *dev =3D video_drvdata(file); + struct bcm2835_mmal_dev *dev =3D video_drvdata(file); =20 f->fmt.win.field =3D V4L2_FIELD_NONE; f->fmt.win.chromakey =3D 0; @@ -754,7 +754,7 @@ static int vidioc_try_fmt_vid_overlay(struct file *file= , void *priv, static int vidioc_s_fmt_vid_overlay(struct file *file, void *priv, struct v4l2_format *f) { - struct bm2835_mmal_dev *dev =3D video_drvdata(file); + struct bcm2835_mmal_dev *dev =3D video_drvdata(file); =20 vidioc_try_fmt_vid_overlay(file, priv, f); =20 @@ -770,7 +770,7 @@ static int vidioc_s_fmt_vid_overlay(struct file *file, = void *priv, static int vidioc_overlay(struct file *file, void *f, unsigned int on) { int ret; - struct bm2835_mmal_dev *dev =3D video_drvdata(file); + struct bcm2835_mmal_dev *dev =3D video_drvdata(file); struct vchiq_mmal_port *src; struct vchiq_mmal_port *dst; =20 @@ -829,7 +829,7 @@ static int vidioc_g_fbuf(struct file *file, void *fh, /* The video overlay must stay within the framebuffer and can't be * positioned independently. */ - struct bm2835_mmal_dev *dev =3D video_drvdata(file); + struct bcm2835_mmal_dev *dev =3D video_drvdata(file); struct vchiq_mmal_port *preview_port =3D &dev->component[COMP_CAMERA]->output[CAM_PORT_PREVIEW]; =20 @@ -878,7 +878,7 @@ static int vidioc_s_input(struct file *file, void *priv= , unsigned int i) static int vidioc_querycap(struct file *file, void *priv, struct v4l2_capability *cap) { - struct bm2835_mmal_dev *dev =3D video_drvdata(file); + struct bcm2835_mmal_dev *dev =3D video_drvdata(file); u32 major; u32 minor; =20 @@ -911,7 +911,7 @@ static int vidioc_enum_fmt_vid_cap(struct file *file, v= oid *priv, static int vidioc_g_fmt_vid_cap(struct file *file, void *priv, struct v4l2_format *f) { - struct bm2835_mmal_dev *dev =3D video_drvdata(file); + struct bcm2835_mmal_dev *dev =3D video_drvdata(file); =20 f->fmt.pix.width =3D dev->capture.width; f->fmt.pix.height =3D dev->capture.height; @@ -936,7 +936,7 @@ static int vidioc_g_fmt_vid_cap(struct file *file, void= *priv, static int vidioc_try_fmt_vid_cap(struct file *file, void *priv, struct v4l2_format *f) { - struct bm2835_mmal_dev *dev =3D video_drvdata(file); + struct bcm2835_mmal_dev *dev =3D video_drvdata(file); struct mmal_fmt *mfmt; =20 mfmt =3D get_format(f); @@ -1010,7 +1010,7 @@ static int vidioc_try_fmt_vid_cap(struct file *file, = void *priv, } =20 =20 -static int mmal_setup_video_component(struct bm2835_mmal_dev *dev, +static int mmal_setup_video_component(struct bcm2835_mmal_dev *dev, struct v4l2_format *f) { bool overlay_enabled =3D !!dev->component[COMP_PREVIEW]->enabled; @@ -1056,7 +1056,7 @@ static int mmal_setup_video_component(struct bm2835_m= mal_dev *dev, return ret; } =20 -static int mmal_setup_encode_component(struct bm2835_mmal_dev *dev, +static int mmal_setup_encode_component(struct bcm2835_mmal_dev *dev, struct v4l2_format *f, struct vchiq_mmal_port *port, struct vchiq_mmal_port *camera_port, @@ -1144,7 +1144,7 @@ static int mmal_setup_encode_component(struct bm2835_= mmal_dev *dev, return 0; } =20 -static int mmal_setup_components(struct bm2835_mmal_dev *dev, +static int mmal_setup_components(struct bcm2835_mmal_dev *dev, struct v4l2_format *f) { int ret; @@ -1290,7 +1290,7 @@ static int vidioc_s_fmt_vid_cap(struct file *file, vo= id *priv, struct v4l2_format *f) { int ret; - struct bm2835_mmal_dev *dev =3D video_drvdata(file); + struct bcm2835_mmal_dev *dev =3D video_drvdata(file); struct mmal_fmt *mfmt; =20 /* try the format to set valid parameters */ @@ -1333,7 +1333,7 @@ static int vidioc_s_fmt_vid_cap(struct file *file, vo= id *priv, static int vidioc_enum_framesizes(struct file *file, void *fh, struct v4l2_frmsizeenum *fsize) { - struct bm2835_mmal_dev *dev =3D video_drvdata(file); + struct bcm2835_mmal_dev *dev =3D video_drvdata(file); static const struct v4l2_frmsize_stepwise sizes =3D { MIN_WIDTH, 0, 2, MIN_HEIGHT, 0, 2 @@ -1358,7 +1358,7 @@ static int vidioc_enum_framesizes(struct file *file, = void *fh, static int vidioc_enum_frameintervals(struct file *file, void *priv, struct v4l2_frmivalenum *fival) { - struct bm2835_mmal_dev *dev =3D video_drvdata(file); + struct bcm2835_mmal_dev *dev =3D video_drvdata(file); int i; =20 if (fival->index) @@ -1388,7 +1388,7 @@ static int vidioc_enum_frameintervals(struct file *fi= le, void *priv, static int vidioc_g_parm(struct file *file, void *priv, struct v4l2_streamparm *parm) { - struct bm2835_mmal_dev *dev =3D video_drvdata(file); + struct bcm2835_mmal_dev *dev =3D video_drvdata(file); =20 if (parm->type !=3D V4L2_BUF_TYPE_VIDEO_CAPTURE) return -EINVAL; @@ -1402,7 +1402,7 @@ static int vidioc_g_parm(struct file *file, void *pri= v, static int vidioc_s_parm(struct file *file, void *priv, struct v4l2_streamparm *parm) { - struct bm2835_mmal_dev *dev =3D video_drvdata(file); + struct bcm2835_mmal_dev *dev =3D video_drvdata(file); struct v4l2_fract tpf; =20 if (parm->type !=3D V4L2_BUF_TYPE_VIDEO_CAPTURE) @@ -1530,7 +1530,7 @@ static int get_num_cameras(struct vchiq_mmal_instance= *instance, =20 static int set_camera_parameters(struct vchiq_mmal_instance *instance, struct vchiq_mmal_component *camera, - struct bm2835_mmal_dev *dev) + struct bcm2835_mmal_dev *dev) { struct mmal_parameter_camera_config cam_config =3D { .max_stills_w =3D dev->max_width, @@ -1555,7 +1555,7 @@ static int set_camera_parameters(struct vchiq_mmal_in= stance *instance, #define MAX_SUPPORTED_ENCODINGS 20 =20 /* MMAL instance and component init */ -static int mmal_init(struct bm2835_mmal_dev *dev) +static int mmal_init(struct bcm2835_mmal_dev *dev) { int ret; struct mmal_es_format_local *format; @@ -1769,7 +1769,7 @@ static int mmal_init(struct bm2835_mmal_dev *dev) return ret; } =20 -static int bm2835_mmal_init_device(struct bm2835_mmal_dev *dev, +static int bm2835_mmal_init_device(struct bcm2835_mmal_dev *dev, struct video_device *vfd) { int ret; @@ -1798,7 +1798,7 @@ static int bm2835_mmal_init_device(struct bm2835_mmal= _dev *dev, return 0; } =20 -static void bcm2835_cleanup_instance(struct bm2835_mmal_dev *dev) +static void bcm2835_cleanup_instance(struct bcm2835_mmal_dev *dev) { if (!dev) return; @@ -1849,7 +1849,7 @@ static struct v4l2_format default_v4l2_format =3D { static int bcm2835_mmal_probe(struct platform_device *pdev) { int ret; - struct bm2835_mmal_dev *dev; + struct bcm2835_mmal_dev *dev; struct vb2_queue *q; int camera; unsigned int num_cameras; diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h = b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h index 75524adff0f5..338b7c142ae3 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h @@ -32,7 +32,7 @@ enum { =20 extern int bcm2835_v4l2_debug; =20 -struct bm2835_mmal_dev { +struct bcm2835_mmal_dev { /* v4l2 devices */ struct v4l2_device v4l2_dev; struct video_device vdev; @@ -111,11 +111,11 @@ struct bm2835_mmal_dev { }; =20 int bm2835_mmal_init_controls( - struct bm2835_mmal_dev *dev, + struct bcm2835_mmal_dev *dev, struct v4l2_ctrl_handler *hdl); =20 -int bm2835_mmal_set_all_camera_controls(struct bm2835_mmal_dev *dev); -int set_framerate_params(struct bm2835_mmal_dev *dev); +int bm2835_mmal_set_all_camera_controls(struct bcm2835_mmal_dev *dev); +int set_framerate_params(struct bcm2835_mmal_dev *dev); =20 /* Debug helpers */ =20 diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/driv= ers/staging/vc04_services/bcm2835-camera/controls.c index 3696dfb5a020..03967a7d99a0 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -65,7 +65,7 @@ enum bm2835_mmal_ctrl_type { MMAL_CONTROL_TYPE_CLUSTER, /* special cluster entry */ }; =20 -struct bm2835_mmal_v4l2_ctrl { +struct bcm2835_mmal_v4l2_ctrl { u32 id; /* v4l2 control identifier */ enum bm2835_mmal_ctrl_type type; /* control minimum value or @@ -77,8 +77,8 @@ struct bm2835_mmal_v4l2_ctrl { u64 step; /* step size of the control */ const s64 *imenu; /* integer menu array */ u32 mmal_id; /* mmal parameter id */ - int (*setter)(struct bm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl); + int (*setter)(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl); }; =20 struct v4l2_to_mmal_effects_setting { @@ -150,9 +150,9 @@ static const struct v4l2_mmal_scene_config scene_config= s[] =3D { =20 /* control handlers*/ =20 -static int ctrl_set_rational(struct bm2835_mmal_dev *dev, +static int ctrl_set_rational(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { struct mmal_parameter_rational rational_value; struct vchiq_mmal_port *control; @@ -168,9 +168,9 @@ static int ctrl_set_rational(struct bm2835_mmal_dev *de= v, sizeof(rational_value)); } =20 -static int ctrl_set_value(struct bm2835_mmal_dev *dev, +static int ctrl_set_value(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { u32 u32_value; struct vchiq_mmal_port *control; @@ -184,9 +184,9 @@ static int ctrl_set_value(struct bm2835_mmal_dev *dev, &u32_value, sizeof(u32_value)); } =20 -static int ctrl_set_iso(struct bm2835_mmal_dev *dev, +static int ctrl_set_iso(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { u32 u32_value; struct vchiq_mmal_port *control; @@ -212,9 +212,9 @@ static int ctrl_set_iso(struct bm2835_mmal_dev *dev, &u32_value, sizeof(u32_value)); } =20 -static int ctrl_set_value_ev(struct bm2835_mmal_dev *dev, +static int ctrl_set_value_ev(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { s32 s32_value; struct vchiq_mmal_port *control; @@ -228,9 +228,9 @@ static int ctrl_set_value_ev(struct bm2835_mmal_dev *de= v, &s32_value, sizeof(s32_value)); } =20 -static int ctrl_set_rotate(struct bm2835_mmal_dev *dev, +static int ctrl_set_rotate(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { int ret; u32 u32_value; @@ -257,9 +257,9 @@ static int ctrl_set_rotate(struct bm2835_mmal_dev *dev, &u32_value, sizeof(u32_value)); } =20 -static int ctrl_set_flip(struct bm2835_mmal_dev *dev, +static int ctrl_set_flip(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { int ret; u32 u32_value; @@ -298,9 +298,9 @@ static int ctrl_set_flip(struct bm2835_mmal_dev *dev, &u32_value, sizeof(u32_value)); } =20 -static int ctrl_set_exposure(struct bm2835_mmal_dev *dev, +static int ctrl_set_exposure(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { enum mmal_parameter_exposuremode exp_mode =3D dev->exposure_mode_user; u32 shutter_speed =3D 0; @@ -354,9 +354,9 @@ static int ctrl_set_exposure(struct bm2835_mmal_dev *de= v, return ret; } =20 -static int ctrl_set_metering_mode(struct bm2835_mmal_dev *dev, +static int ctrl_set_metering_mode(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { switch (ctrl->val) { case V4L2_EXPOSURE_METERING_AVERAGE: @@ -390,9 +390,9 @@ static int ctrl_set_metering_mode(struct bm2835_mmal_de= v *dev, } } =20 -static int ctrl_set_flicker_avoidance(struct bm2835_mmal_dev *dev, +static int ctrl_set_flicker_avoidance(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { u32 u32_value; struct vchiq_mmal_port *control; @@ -419,9 +419,9 @@ static int ctrl_set_flicker_avoidance(struct bm2835_mma= l_dev *dev, &u32_value, sizeof(u32_value)); } =20 -static int ctrl_set_awb_mode(struct bm2835_mmal_dev *dev, +static int ctrl_set_awb_mode(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { u32 u32_value; struct vchiq_mmal_port *control; @@ -475,9 +475,9 @@ static int ctrl_set_awb_mode(struct bm2835_mmal_dev *de= v, &u32_value, sizeof(u32_value)); } =20 -static int ctrl_set_awb_gains(struct bm2835_mmal_dev *dev, +static int ctrl_set_awb_gains(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { struct vchiq_mmal_port *control; struct mmal_parameter_awbgains gains; @@ -498,9 +498,9 @@ static int ctrl_set_awb_gains(struct bm2835_mmal_dev *d= ev, &gains, sizeof(gains)); } =20 -static int ctrl_set_image_effect(struct bm2835_mmal_dev *dev, +static int ctrl_set_image_effect(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { int ret =3D -EINVAL; int i, j; @@ -555,9 +555,9 @@ static int ctrl_set_image_effect(struct bm2835_mmal_dev= *dev, return (ret =3D=3D 0 ? 0 : -EINVAL); } =20 -static int ctrl_set_colfx(struct bm2835_mmal_dev *dev, +static int ctrl_set_colfx(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { int ret; struct vchiq_mmal_port *control; @@ -579,9 +579,9 @@ static int ctrl_set_colfx(struct bm2835_mmal_dev *dev, return (ret =3D=3D 0 ? 0 : -EINVAL); } =20 -static int ctrl_set_bitrate(struct bm2835_mmal_dev *dev, +static int ctrl_set_bitrate(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { int ret; struct vchiq_mmal_port *encoder_out; @@ -607,9 +607,9 @@ static int ctrl_set_bitrate(struct bm2835_mmal_dev *dev, return 0; } =20 -static int ctrl_set_bitrate_mode(struct bm2835_mmal_dev *dev, +static int ctrl_set_bitrate_mode(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { u32 bitrate_mode; struct vchiq_mmal_port *encoder_out; @@ -634,9 +634,9 @@ static int ctrl_set_bitrate_mode(struct bm2835_mmal_dev= *dev, return 0; } =20 -static int ctrl_set_image_encode_output(struct bm2835_mmal_dev *dev, +static int ctrl_set_image_encode_output(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { u32 u32_value; struct vchiq_mmal_port *jpeg_out; @@ -650,9 +650,9 @@ static int ctrl_set_image_encode_output(struct bm2835_m= mal_dev *dev, &u32_value, sizeof(u32_value)); } =20 -static int ctrl_set_video_encode_param_output(struct bm2835_mmal_dev *dev, +static int ctrl_set_video_encode_param_output(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { u32 u32_value; struct vchiq_mmal_port *vid_enc_ctl; @@ -666,9 +666,9 @@ static int ctrl_set_video_encode_param_output(struct bm= 2835_mmal_dev *dev, &u32_value, sizeof(u32_value)); } =20 -static int ctrl_set_video_encode_profile_level(struct bm2835_mmal_dev *dev, +static int ctrl_set_video_encode_profile_level(struct bcm2835_mmal_dev *de= v, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { struct mmal_parameter_video_profile param; int ret =3D 0; @@ -777,9 +777,9 @@ static int ctrl_set_video_encode_profile_level(struct b= m2835_mmal_dev *dev, return ret; } =20 -static int ctrl_set_scene_mode(struct bm2835_mmal_dev *dev, +static int ctrl_set_scene_mode(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl) + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl) { int ret =3D 0; int shutter_speed; @@ -886,10 +886,9 @@ static int ctrl_set_scene_mode(struct bm2835_mmal_dev = *dev, =20 static int bm2835_mmal_s_ctrl(struct v4l2_ctrl *ctrl) { - struct bm2835_mmal_dev *dev =3D - container_of(ctrl->handler, struct bm2835_mmal_dev, - ctrl_handler); - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl =3D ctrl->priv; + struct bcm2835_mmal_dev *dev =3D container_of(ctrl->handler, struct bcm28= 35_mmal_dev, + ctrl_handler); + const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl =3D ctrl->priv; int ret; =20 if (!mmal_ctrl || mmal_ctrl->id !=3D ctrl->id || !mmal_ctrl->setter) { @@ -908,7 +907,7 @@ static const struct v4l2_ctrl_ops bm2835_mmal_ctrl_ops = =3D { .s_ctrl =3D bm2835_mmal_s_ctrl, }; =20 -static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[V4L2_CTRL_COUNT] =3D { +static const struct bcm2835_mmal_v4l2_ctrl v4l2_ctrls[V4L2_CTRL_COUNT] =3D= { { .id =3D V4L2_CID_SATURATION, .type =3D MMAL_CONTROL_TYPE_STD, @@ -1247,7 +1246,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { }, }; =20 -int bm2835_mmal_set_all_camera_controls(struct bm2835_mmal_dev *dev) +int bm2835_mmal_set_all_camera_controls(struct bcm2835_mmal_dev *dev) { int c; int ret =3D 0; @@ -1267,7 +1266,7 @@ int bm2835_mmal_set_all_camera_controls(struct bm2835= _mmal_dev *dev) return ret; } =20 -int set_framerate_params(struct bm2835_mmal_dev *dev) +int set_framerate_params(struct bcm2835_mmal_dev *dev) { struct mmal_parameter_fps_range fps_range; int ret; @@ -1312,11 +1311,11 @@ int set_framerate_params(struct bm2835_mmal_dev *de= v) return ret; } =20 -int bm2835_mmal_init_controls(struct bm2835_mmal_dev *dev, +int bm2835_mmal_init_controls(struct bcm2835_mmal_dev *dev, struct v4l2_ctrl_handler *hdl) { int c; - const struct bm2835_mmal_v4l2_ctrl *ctrl; + const struct bcm2835_mmal_v4l2_ctrl *ctrl; =20 v4l2_ctrl_handler_init(hdl, V4L2_CTRL_COUNT); =20 --=20 2.34.1 From nobody Wed Jul 1 00:46:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B6A4C433EF for ; Wed, 5 Jan 2022 20:37:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244111AbiAEUhK (ORCPT ); Wed, 5 Jan 2022 15:37:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244092AbiAEUgu (ORCPT ); Wed, 5 Jan 2022 15:36:50 -0500 Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9A6EC061212 for ; Wed, 5 Jan 2022 12:36:49 -0800 (PST) Received: by mail-ua1-x92b.google.com with SMTP id u6so733376uaq.0 for ; Wed, 05 Jan 2022 12:36:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=836CBDGgLoHqJrgB5kmQKKUyQ8f2Pjj7U9sJ+wlw5Ks=; b=op2tTAluLlXpi73l63bd8H6LIC3NZXyjd7FcX93LNvwSK/cwQAjkxr2Y4lCGdAnrCy 2P4foNdWT8S8IOeQLvuQ68oIKNfKbTHeyRqRCJZ7XKvlBXGFY677RbJU+uCOnB313oes UU6Gqi2iLYJ8Tngr2xayMylLJ9P4GkqK43QFK+U/QXxxaWWlHJdg4Lr6kUji+ULnofpR /wW2aFXHqBCwF+yhlnULisOVwf+VurI4ZwxjPrthK3s7wAM5J7IF+scJRQYaFhF9ZWmK WH12tpgc8X63hxf5YQUomqW05SUdDiJWNSQKCA8QLTxonZ9OOmK2/Pt5irlwysC1kXH6 jRVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=836CBDGgLoHqJrgB5kmQKKUyQ8f2Pjj7U9sJ+wlw5Ks=; b=wE0PZw9mjFIbnQrh+39Af1j6a8y5rV9kWxE19l1OrxumiTs5AFQwD6ABwJqN6XBa47 ZEgHjfECaYMd0Crm2uZNG/So0XVo6Lvf7D4dpXL3pOlCwSH5wDMP7GIBXdX49TsMaeBS A7e8UD8YoZV6UVtKFlfrqYMq4K9h9H06xYEpePT2qd831ZUCSd1mrGD1dElLpx8ogFGO lge/IJIWjImDlpS+N5BnGH5MsPsP9kU5auNzryMcPGgId7tWMx1Z9RtNW/CvPKdOQGz0 t0Yac+FoVm4Mkero0qfKytkdd3ql3hhrfrblYMbhMlFnFxVEdb9aZCNSJwMe6h9mMLhX OqvQ== X-Gm-Message-State: AOAM531+nPImFEecXrFBKMwK9HZ9mqTRklm7FKVn8m0bBA/gaR7ndjND 6L4sNglmtz72W0Z+MvY4SCY= X-Google-Smtp-Source: ABdhPJzOsjmNyjvD9eh8RW9ZrC9OqH+ROs6XuW3xkLWcicFQUnDLHWvMBuHJuYHUAHcvzjiIXPGnYg== X-Received: by 2002:ab0:3730:: with SMTP id s16mr4598247uag.83.1641415009126; Wed, 05 Jan 2022 12:36:49 -0800 (PST) Received: from localhost.localdomain ([181.22.170.52]) by smtp.gmail.com with ESMTPSA id t130sm7860vkc.32.2022.01.05.12.36.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 12:36:48 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, len.baker@gmx.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 2/6] staging: vc04_services: rename functions containing bm2835_* to bcm2835_* Date: Wed, 5 Jan 2022 17:35:44 -0300 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In the kernel, all names related to the chip BCM2835 are always named bcm2835_*. To avoid confusion, and to make things more consistent, rename functions using bm2835_* to bcm2835_*. While at it, some realignments were made to improve readability. Suggested-by: Stefan Wahren Signed-off-by: Gaston Gonzalez --- .../vc04_services/bcm2835-camera/bcm2835-camera.c | 9 ++++----- .../vc04_services/bcm2835-camera/bcm2835-camera.h | 6 ++---- drivers/staging/vc04_services/bcm2835-camera/controls.c | 9 ++++----- 3 files changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c = b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index 109021643c3f..159ac600d11e 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -1735,7 +1735,7 @@ static int mmal_init(struct bcm2835_mmal_dev *dev) &enable, sizeof(enable)); } - ret =3D bm2835_mmal_set_all_camera_controls(dev); + ret =3D bcm2835_mmal_set_all_camera_controls(dev); if (ret < 0) { v4l2_err(&dev->v4l2_dev, "%s: failed to set all camera controls: %d\n", __func__, ret); @@ -1769,8 +1769,7 @@ static int mmal_init(struct bcm2835_mmal_dev *dev) return ret; } =20 -static int bm2835_mmal_init_device(struct bcm2835_mmal_dev *dev, - struct video_device *vfd) +static int bcm2835_mmal_init_device(struct bcm2835_mmal_dev *dev, struct v= ideo_device *vfd) { int ret; =20 @@ -1908,7 +1907,7 @@ static int bcm2835_mmal_probe(struct platform_device = *pdev) } =20 /* setup v4l controls */ - ret =3D bm2835_mmal_init_controls(dev, &dev->ctrl_handler); + ret =3D bcm2835_mmal_init_controls(dev, &dev->ctrl_handler); if (ret < 0) { v4l2_err(&dev->v4l2_dev, "%s: could not init controls: %d\n", __func__, ret); @@ -1940,7 +1939,7 @@ static int bcm2835_mmal_probe(struct platform_device = *pdev) goto unreg_dev; =20 /* initialise video devices */ - ret =3D bm2835_mmal_init_device(dev, &dev->vdev); + ret =3D bcm2835_mmal_init_device(dev, &dev->vdev); if (ret < 0) { v4l2_err(&dev->v4l2_dev, "%s: could not init device: %d\n", __func__, ret); diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h = b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h index 338b7c142ae3..84ba789af120 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h @@ -110,11 +110,9 @@ struct bcm2835_mmal_dev { unsigned int rgb_bgr_swapped; }; =20 -int bm2835_mmal_init_controls( - struct bcm2835_mmal_dev *dev, - struct v4l2_ctrl_handler *hdl); +int bcm2835_mmal_init_controls(struct bcm2835_mmal_dev *dev, struct v4l2_c= trl_handler *hdl); =20 -int bm2835_mmal_set_all_camera_controls(struct bcm2835_mmal_dev *dev); +int bcm2835_mmal_set_all_camera_controls(struct bcm2835_mmal_dev *dev); int set_framerate_params(struct bcm2835_mmal_dev *dev); =20 /* Debug helpers */ diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/driv= ers/staging/vc04_services/bcm2835-camera/controls.c index 03967a7d99a0..08fadc164b02 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -884,7 +884,7 @@ static int ctrl_set_scene_mode(struct bcm2835_mmal_dev = *dev, return 0; } =20 -static int bm2835_mmal_s_ctrl(struct v4l2_ctrl *ctrl) +static int bcm2835_mmal_s_ctrl(struct v4l2_ctrl *ctrl) { struct bcm2835_mmal_dev *dev =3D container_of(ctrl->handler, struct bcm28= 35_mmal_dev, ctrl_handler); @@ -904,7 +904,7 @@ static int bm2835_mmal_s_ctrl(struct v4l2_ctrl *ctrl) } =20 static const struct v4l2_ctrl_ops bm2835_mmal_ctrl_ops =3D { - .s_ctrl =3D bm2835_mmal_s_ctrl, + .s_ctrl =3D bcm2835_mmal_s_ctrl, }; =20 static const struct bcm2835_mmal_v4l2_ctrl v4l2_ctrls[V4L2_CTRL_COUNT] =3D= { @@ -1246,7 +1246,7 @@ static const struct bcm2835_mmal_v4l2_ctrl v4l2_ctrls= [V4L2_CTRL_COUNT] =3D { }, }; =20 -int bm2835_mmal_set_all_camera_controls(struct bcm2835_mmal_dev *dev) +int bcm2835_mmal_set_all_camera_controls(struct bcm2835_mmal_dev *dev) { int c; int ret =3D 0; @@ -1311,8 +1311,7 @@ int set_framerate_params(struct bcm2835_mmal_dev *dev) return ret; } =20 -int bm2835_mmal_init_controls(struct bcm2835_mmal_dev *dev, - struct v4l2_ctrl_handler *hdl) +int bcm2835_mmal_init_controls(struct bcm2835_mmal_dev *dev, struct v4l2_c= trl_handler *hdl) { int c; const struct bcm2835_mmal_v4l2_ctrl *ctrl; --=20 2.34.1 From nobody Wed Jul 1 00:46:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A5FC433F5 for ; Wed, 5 Jan 2022 20:37:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244123AbiAEUhT (ORCPT ); Wed, 5 Jan 2022 15:37:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244093AbiAEUgy (ORCPT ); Wed, 5 Jan 2022 15:36:54 -0500 Received: from mail-vk1-xa2e.google.com (mail-vk1-xa2e.google.com [IPv6:2607:f8b0:4864:20::a2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8A00C0611FF for ; Wed, 5 Jan 2022 12:36:53 -0800 (PST) Received: by mail-vk1-xa2e.google.com with SMTP id s72so379604vks.9 for ; Wed, 05 Jan 2022 12:36:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w8EkkzNdsrnEqk2YciotM6EW2MTmAWF34zyjUlKhtkA=; b=ZNc0HGk+uxnzavqym+yTYhAXq6lmiJDpCdpKcUPhQpQ/v2s4ijDX9M5lpO0rIoGrpJ LM7uKW7jEV7HAOHBSFUeXVXpWz64sVUn1X5MKD6cgMaaDg73+OvohMoBQj6LbL8tE1Am Lrs9k7h8tjjT6wj3JHf8VNAECHiuhnZuazD3uMpQ8nb6Sbe+HhcCxNyGTy3/VbJHow0k qjGgN2oGeRHbSncqbVdp8Wk/gf/RBr/87y5qT1nPinyl1+SCL24kBbP27F7+2TTyiTgp gbxEL2khEgn6GbzZHNCV9ey9U2ybbpJ11eIDxpqA3+zAjG+l2pHyHbvtS7FXoF4vybsh WZpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w8EkkzNdsrnEqk2YciotM6EW2MTmAWF34zyjUlKhtkA=; b=UR6aArNOsbq+hO//eOK1UCDdy3uuXlBsyq6P2ogJ+S3AAazY4SJFEdYMdEfrjPRk5U 1ZLa9gWp496Zg2FLiIgTqtxd1j0TpnsAynShEQzuhhsxG2zZfrp/M6l3KdKksVgiusXV WUo6v7kM4+i2OSNGpkwQA6/3ersIWWxChrhw1HOTo0GOyoHmz99ymJnucZc15I/peoGa tdob+qHstiu3ESB2JNdIXkiLLT5eAAJgG0eq1BBYTieo2vg2RQuJDESDrBGFQXxqmNKa TjziCVKAjKtVnADqdd5ucRUwlau3P5wqkkrgeeE+Rnxk5gXhdSSxU4tur20CyyY/UGDb 9Ghw== X-Gm-Message-State: AOAM531eWgD8c4pa7NZidQ7THIgLxTwJmhiCynSNkjrahG5hVMgEND/E PJmnJp6WQEo6nvPGb4CZDsk= X-Google-Smtp-Source: ABdhPJwhC9Ue0swAVd5zzL/J9JY/4NkVzVDYQvA6vAzqJIfw57q1jDgz+w3yei7bb9hr/ez3NXKRBg== X-Received: by 2002:a05:6122:8c6:: with SMTP id 6mr18487538vkg.33.1641415012981; Wed, 05 Jan 2022 12:36:52 -0800 (PST) Received: from localhost.localdomain ([181.22.170.52]) by smtp.gmail.com with ESMTPSA id t130sm7860vkc.32.2022.01.05.12.36.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 12:36:52 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, len.baker@gmx.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 3/6] staging: vc04_services: rename variables containing bm2835_* to bcm2835_* Date: Wed, 5 Jan 2022 17:35:45 -0300 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In the kernel, all names related to the chip BCM2835 are always named bcm2835_*. To avoid confusion, and to make things more consistent, rename all variables using bm2835_* to bcm2835_*. While at it, some realignments were made to improve readability. Suggested-by: Stefan Wahren Signed-off-by: Gaston Gonzalez --- .../bcm2835-camera/bcm2835-camera.c | 4 +-- .../vc04_services/bcm2835-camera/controls.c | 31 +++++++------------ 2 files changed, 14 insertions(+), 21 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c = b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index 159ac600d11e..cbc881e19f65 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -654,7 +654,7 @@ static void stop_streaming(struct vb2_queue *vq) v4l2_err(&dev->v4l2_dev, "Failed to disable camera\n"); } =20 -static const struct vb2_ops bm2835_mmal_video_qops =3D { +static const struct vb2_ops bcm2835_mmal_video_qops =3D { .queue_setup =3D queue_setup, .buf_init =3D buffer_init, .buf_prepare =3D buffer_prepare, @@ -1930,7 +1930,7 @@ static int bcm2835_mmal_probe(struct platform_device = *pdev) q->io_modes =3D VB2_MMAP | VB2_USERPTR | VB2_READ; q->drv_priv =3D dev; q->buf_struct_size =3D sizeof(struct vb2_mmal_buffer); - q->ops =3D &bm2835_mmal_video_qops; + q->ops =3D &bcm2835_mmal_video_qops; q->mem_ops =3D &vb2_vmalloc_memops; q->timestamp_flags =3D V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; q->lock =3D &dev->mutex; diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/driv= ers/staging/vc04_services/bcm2835-camera/controls.c index 08fadc164b02..178fb310b89a 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -58,7 +58,7 @@ static const u32 iso_values[] =3D { 0, 100, 200, 400, 800, }; =20 -enum bm2835_mmal_ctrl_type { +enum bcm2835_mmal_ctrl_type { MMAL_CONTROL_TYPE_STD, MMAL_CONTROL_TYPE_STD_MENU, MMAL_CONTROL_TYPE_INT_MENU, @@ -67,7 +67,7 @@ enum bm2835_mmal_ctrl_type { =20 struct bcm2835_mmal_v4l2_ctrl { u32 id; /* v4l2 control identifier */ - enum bm2835_mmal_ctrl_type type; + enum bcm2835_mmal_ctrl_type type; /* control minimum value or * mask for MMAL_CONTROL_TYPE_STD_MENU */ @@ -903,7 +903,7 @@ static int bcm2835_mmal_s_ctrl(struct v4l2_ctrl *ctrl) return ret; } =20 -static const struct v4l2_ctrl_ops bm2835_mmal_ctrl_ops =3D { +static const struct v4l2_ctrl_ops bcm2835_mmal_ctrl_ops =3D { .s_ctrl =3D bcm2835_mmal_s_ctrl, }; =20 @@ -1323,12 +1323,9 @@ int bcm2835_mmal_init_controls(struct bcm2835_mmal_d= ev *dev, struct v4l2_ctrl_ha =20 switch (ctrl->type) { case MMAL_CONTROL_TYPE_STD: - dev->ctrls[c] =3D - v4l2_ctrl_new_std(hdl, - &bm2835_mmal_ctrl_ops, - ctrl->id, ctrl->min, - ctrl->max, ctrl->step, - ctrl->def); + dev->ctrls[c] =3D v4l2_ctrl_new_std(hdl, &bcm2835_mmal_ctrl_ops, + ctrl->id, ctrl->min, ctrl->max, + ctrl->step, ctrl->def); break; =20 case MMAL_CONTROL_TYPE_STD_MENU: @@ -1352,20 +1349,16 @@ int bcm2835_mmal_init_controls(struct bcm2835_mmal_= dev *dev, struct v4l2_ctrl_ha mask =3D ~mask; } =20 - dev->ctrls[c] =3D - v4l2_ctrl_new_std_menu(hdl, - &bm2835_mmal_ctrl_ops, - ctrl->id, ctrl->max, - mask, ctrl->def); + dev->ctrls[c] =3D v4l2_ctrl_new_std_menu(hdl, &bcm2835_mmal_ctrl_ops, + ctrl->id, ctrl->max, mask, + ctrl->def); break; } =20 case MMAL_CONTROL_TYPE_INT_MENU: - dev->ctrls[c] =3D - v4l2_ctrl_new_int_menu(hdl, - &bm2835_mmal_ctrl_ops, - ctrl->id, ctrl->max, - ctrl->def, ctrl->imenu); + dev->ctrls[c] =3D v4l2_ctrl_new_int_menu(hdl, &bcm2835_mmal_ctrl_ops, + ctrl->id, ctrl->max, + ctrl->def, ctrl->imenu); break; =20 case MMAL_CONTROL_TYPE_CLUSTER: --=20 2.34.1 From nobody Wed Jul 1 00:46:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE089C433EF for ; Wed, 5 Jan 2022 20:37:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244108AbiAEUh1 (ORCPT ); Wed, 5 Jan 2022 15:37:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244103AbiAEUg5 (ORCPT ); Wed, 5 Jan 2022 15:36:57 -0500 Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [IPv6:2607:f8b0:4864:20::a29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B990C061245 for ; Wed, 5 Jan 2022 12:36:57 -0800 (PST) Received: by mail-vk1-xa29.google.com with SMTP id l68so396983vkh.4 for ; Wed, 05 Jan 2022 12:36:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PFpxL8eNjWfN9L9+3lNFj3nd+2+vNaUo9b7OlF5oUWU=; b=MOzaZyxBX3Mcp7NycsdG6RBaO+0oKmPOdqDAe0sh0Ods0J5BVgNQd6WTsHq2z1dTNR 0Hcz5XTpa1HDn+ljXWi3Ene9RxrMrhMORzMtuo07KYswBrsYQoLvVp+VEhJ9G+8W3uTY 9Xog4dUYCz+RzTl5ZFiABiDCkHGiIo273jK8g73H+BXwGqg7uzbTyHbGBngCabCI8W1l v08A9+HNolepnYcvf1WKrgMKMDiCBNCWbVXeDBS7/axpTkNuep8e9tVZkSw5oM9qYCkP XTwlaov9v8uFIu1QBUYUc1Cyy5L5gV7G3tGqBci2Ms/IPXOeGkeiISEh7OzAVhDU3Dj5 Tg6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PFpxL8eNjWfN9L9+3lNFj3nd+2+vNaUo9b7OlF5oUWU=; b=3OZQj/AJSJ1+pu/kcKeIW7kE7ba4/EPDl5m2EKXJeKL/FGQE4VCQzDP8WlX/oki7ef Wx0iVSWr/uDPR+jIYxzcyT+h7PsP+5AcnazBixDGuvk7wSuw4WmM/ye5rNbJjvQH9nBq bSEz+vXjB2IdxBk8PoXXJedfWbIQ9aNay8gyAjObW8msBHzaDn9jpbEMhDcfO9hv2rhE Q+lleyyAh7vnKX3dpnZvas9eWvAV+7AcLLqUuhq2NuTF7dm5A/fd9u2xGim3SBIONBl4 yl5ogMAPspCanRqgjQBMyhyvvqqnJ9JFdB1PGA73eafn4NayzE+QlrOKOwNF9nbYIyFR I1WA== X-Gm-Message-State: AOAM531FvqaPy2QXogDZW4xXgPzhPLBnSBKRnZGrtuDsdVOz36QleIVd 7H6P53hJjKK7L9Y61YrxnRs= X-Google-Smtp-Source: ABdhPJwDAuwT6naxOjUL5AyLq0SJlsEUSbEgq7WuMoQW8aEYk8+Vovkwf4Cg53hxRuabgFrryic7GA== X-Received: by 2002:a05:6122:d0f:: with SMTP id az15mr20333761vkb.28.1641415016836; Wed, 05 Jan 2022 12:36:56 -0800 (PST) Received: from localhost.localdomain ([181.22.170.52]) by smtp.gmail.com with ESMTPSA id t130sm7860vkc.32.2022.01.05.12.36.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 12:36:56 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, len.baker@gmx.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 4/6] staging: vc04_services: rename string literal containing bm2835_* to bcm2835*_ Date: Wed, 5 Jan 2022 17:35:46 -0300 Message-Id: <91caae07fce0e4511f283388304e935526ba29ed.1641414449.git.gascoar@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In the kernel, all names related to the chip BCM2835 are always named bcm2835_*. To avoid confusion, and to make things more consistent, rename the string term bm2835_* to bcm2835_*. While at it, some realignments were made to improve readability. Suggested-by: Stefan Wahren Signed-off-by: Gaston Gonzalez --- .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c = b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index cbc881e19f65..aaf529f2186c 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -884,12 +884,10 @@ static int vidioc_querycap(struct file *file, void *p= riv, =20 vchiq_mmal_version(dev->instance, &major, &minor); =20 - strscpy(cap->driver, "bm2835 mmal", sizeof(cap->driver)); - snprintf((char *)cap->card, sizeof(cap->card), "mmal service %d.%d", - major, minor); + strscpy(cap->driver, "bcm2835 mmal", sizeof(cap->driver)); + snprintf((char *)cap->card, sizeof(cap->card), "mmal service %d.%d", majo= r, minor); =20 - snprintf((char *)cap->bus_info, sizeof(cap->bus_info), - "platform:%s", dev->v4l2_dev.name); + snprintf((char *)cap->bus_info, sizeof(cap->bus_info), "platform:%s", dev= ->v4l2_dev.name); return 0; } =20 --=20 2.34.1 From nobody Wed Jul 1 00:46:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EA5AC433FE for ; Wed, 5 Jan 2022 20:37:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244153AbiAEUh3 (ORCPT ); Wed, 5 Jan 2022 15:37:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244091AbiAEUhC (ORCPT ); Wed, 5 Jan 2022 15:37:02 -0500 Received: from mail-vk1-xa32.google.com (mail-vk1-xa32.google.com [IPv6:2607:f8b0:4864:20::a32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B15BEC061201 for ; Wed, 5 Jan 2022 12:37:01 -0800 (PST) Received: by mail-vk1-xa32.google.com with SMTP id s144so384094vkb.8 for ; Wed, 05 Jan 2022 12:37:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KryD1Tl4pz4bryw9HstBOCtF+w+P5fB9bwLkC/bWiN4=; b=EzFZZCOcqu47YWlPxyWloqUhnXhBHkzNud9oApmsxTR5gEwY+MdHJodVtinVV/tFKR B0K3yGExKPNVNmhnB+3MVzd4MTfS/JYT95XVBnxv0/By6zd4EZrxI88txVrS1MOUfzgZ 40MkCvMZDNZRBzXDqqBnP67PegVsz/eo06SWfsRBXCIf/5nObawnvUmAG732L8SMLBQf H34Cbkvqw2or1LKXgqPy79TLdPZyGQb7bXjkv/4jV+Tg+FYNzAdt8t5hjQAJvayFQwQB f2+Mz077GxH3ZEhovFoqjSobiW2BTRj/HrFiFIJ96BAaOMtjzSjtNV8g94PN1aDv139w dYJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KryD1Tl4pz4bryw9HstBOCtF+w+P5fB9bwLkC/bWiN4=; b=ahTGxL7m8l0ZDxx4yHx+PdK2+UWBPlppdM7l97rrsnrphZkHAPT5N2xLt39OJVwjZm 6wuZqxagv5HWQ/7jnjHZqNODfIvgL6iJ+GxguMqQjD836rqWMOG4l+59MrAQ9BKghXZ5 Jg+i9gvbGO3hu2pmYsMo0T+8reKaggulerhePuYSVy4LbbVsweMoNatw+BM+4VcBano5 WRkCvQfHsWZBQg2JeYzLwuTfdhecihDJAPskqSE9CbtrzQ+qLJu2WRYnfuOLqnbEY8zw 3IqQJXw2I6uCcbibuYi55fmIkImG0HuCuxJfEqWNMEJT27QjlixI4EOk1Xjc+7DXZ/gh OM1w== X-Gm-Message-State: AOAM530RkpcO4eOv/eJutD2TkoOA0LWDHIkCzM0+S+SADdQ71y6cakMC mf6AapEPF4+zDPKUTv+mogI= X-Google-Smtp-Source: ABdhPJzh6vlJ1UUpbhGlxH4d5ijjrmyFqAgWJh8jBQzLMTaS+R7qaF/7mZV+RahkDhpqG+nJ4I8eXw== X-Received: by 2002:a05:6122:d07:: with SMTP id az7mr19249968vkb.9.1641415020584; Wed, 05 Jan 2022 12:37:00 -0800 (PST) Received: from localhost.localdomain ([181.22.170.52]) by smtp.gmail.com with ESMTPSA id t130sm7860vkc.32.2022.01.05.12.36.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 12:37:00 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, len.baker@gmx.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 5/6] staging: vc04_services: rename macros BM2835_MMAL_VERSION and BM2835_MMAL_MODULE_NAME Date: Wed, 5 Jan 2022 17:35:47 -0300 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In the kernel, all names related to the chip BCM2835 are always named bcm2835_*. To avoid confusion, and to make things more consistent, rename the macros BM2835_MMAL_VERSION and BM2835_MMAL_MODULE_NAME accordingly. While at it, some realignments were made to improve readability. Suggested-by: Stefan Wahren Signed-off-by: Gaston Gonzalez --- .../vc04_services/bcm2835-camera/bcm2835-camera.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c = b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index aaf529f2186c..c729b1b7de71 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -33,8 +33,8 @@ #include "mmal-parameters.h" #include "bcm2835-camera.h" =20 -#define BM2835_MMAL_VERSION "0.0.2" -#define BM2835_MMAL_MODULE_NAME "bcm2835-v4l2" +#define BCM2835_MMAL_VERSION "0.0.2" +#define BCM2835_MMAL_MODULE_NAME "bcm2835-v4l2" #define MIN_WIDTH 32 #define MIN_HEIGHT 32 #define MIN_BUFFER_SIZE (80 * 1024) @@ -1894,8 +1894,7 @@ static int bcm2835_mmal_probe(struct platform_device = *pdev) dev->capture.fmt =3D &formats[3]; /* JPEG */ =20 /* v4l device registration */ - dev->camera_num =3D v4l2_device_set_name(&dev->v4l2_dev, - BM2835_MMAL_MODULE_NAME, + dev->camera_num =3D v4l2_device_set_name(&dev->v4l2_dev, BCM2835_MMAL_MO= DULE_NAME, &camera_instance); ret =3D v4l2_device_register(NULL, &dev->v4l2_dev); if (ret) { @@ -1954,9 +1953,8 @@ static int bcm2835_mmal_probe(struct platform_device = *pdev) goto unreg_dev; } =20 - v4l2_info(&dev->v4l2_dev, - "Broadcom 2835 MMAL video capture ver %s loaded.\n", - BM2835_MMAL_VERSION); + v4l2_info(&dev->v4l2_dev, "Broadcom 2835 MMAL video capture ver %s loade= d.\n", + BCM2835_MMAL_VERSION); =20 gdev[camera] =3D dev; } @@ -2008,5 +2006,5 @@ module_platform_driver(bcm2835_camera_driver) MODULE_DESCRIPTION("Broadcom 2835 MMAL video capture"); MODULE_AUTHOR("Vincent Sanders"); MODULE_LICENSE("GPL"); -MODULE_VERSION(BM2835_MMAL_VERSION); +MODULE_VERSION(BCM2835_MMAL_VERSION); MODULE_ALIAS("platform:bcm2835-camera"); --=20 2.34.1 From nobody Wed Jul 1 00:46:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F21D8C433F5 for ; Wed, 5 Jan 2022 20:37:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244166AbiAEUha (ORCPT ); Wed, 5 Jan 2022 15:37:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244100AbiAEUhG (ORCPT ); Wed, 5 Jan 2022 15:37:06 -0500 Received: from mail-vk1-xa2d.google.com (mail-vk1-xa2d.google.com [IPv6:2607:f8b0:4864:20::a2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B88CBC061212 for ; Wed, 5 Jan 2022 12:37:05 -0800 (PST) Received: by mail-vk1-xa2d.google.com with SMTP id b77so372544vka.11 for ; Wed, 05 Jan 2022 12:37:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=58UUNS0DgBb5XBf4k5/ZZBZVEZ/F2R7SYVQLoWIj1HA=; b=fX+lEplRyG8vV/rbGDaMDBkro3Dd7ZReV90UVRE16HASlm8S2TnG4eyO36HxLagfxC DKWGqgcWRiZ+6vA1oIKqF70eJJDmgTsyqY3R+5YVbLBpN/Ixl4BQm+9k/kT+Ucu3ya3a 1oEfbOmfvc/F4Q+KE7et3tbzzSUXPsaE4QC3y2rsRnpActB5nRvxDH3OIQfc5C77RIfZ RVbJbe6PLBKWvXevVtrm4hCR6NA+368cVHGv7ddjtn4CpTXvrGwPnHIR0n01yS46SpWe X0RwQ6zc+NVXrmVCiX1Ef89lgdkwvoCWkqeDwx1keXJvJp/yYEZr0zFOfYganynJfhtk FOng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=58UUNS0DgBb5XBf4k5/ZZBZVEZ/F2R7SYVQLoWIj1HA=; b=KqQa7n3ZJCGf+CfOU8FJPvcBPMIoUFv/MOSya2/2VjAr7mKg6ELV+96OdAAnP5aXit L826nr4Pc9lyIE9wldv2U5G18eQZnbPtfGMzumwsgxSosIkirHKEL45wgj+r5zB/yfrT pb0rI+RDHKcT2Z69pyzjfeYGGTZVw7DXqCQiHixrPZ5oNvUm3jJL+aRpMRJpjmmR4HBG VDL79uAOC75e4yR8kMs4IFTx0Kpabc+oO7orElMZn3TKoMGwEPjUID74LgJW5AAckL6R VKvvhdZyNTppRcBJ7fi8a+5xaChTv+jdebDVnQLgXefbNrpLapX0Zh7HY/TxdHwhI9dc 41uQ== X-Gm-Message-State: AOAM530ulnIUeFZoN6ESmCGFYpCIJDufowYVIkTeU1PI5vhVu3hG+aC2 X3Us6r8X3kLflsS4GNYm8L8= X-Google-Smtp-Source: ABdhPJy7ViyvCGvd5plXY6x2N828NyNFgLUBwtfksiRWcyFa4kHPgvShSwmH3dvex5TRUXalSxLdrw== X-Received: by 2002:a1f:218e:: with SMTP id h136mr19995820vkh.41.1641415024917; Wed, 05 Jan 2022 12:37:04 -0800 (PST) Received: from localhost.localdomain ([181.22.170.52]) by smtp.gmail.com with ESMTPSA id t130sm7860vkc.32.2022.01.05.12.37.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 12:37:04 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, len.baker@gmx.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 6/6] staging: vc04_services: rename BM2835 to BCM2835 in headers comments Date: Wed, 5 Jan 2022 17:35:48 -0300 Message-Id: <19acea9e9da0d3ebb1a7e6bce511a3c09e8c80c3.1641414449.git.gascoar@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the kernel, when referring to the chip BCM2835, it is more suitable to use BCM2835 to BM2835. To avoid confusion, and to make things more consistent, rename the headers titles accordingly. Suggested-by: Stefan Wahren Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 2 +- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h | 2 +- drivers/staging/vc04_services/bcm2835-camera/controls.c | 2 +- drivers/staging/vc04_services/vchiq-mmal/mmal-common.h | 2 +- drivers/staging/vc04_services/vchiq-mmal/mmal-encodings.h | 2 +- drivers/staging/vc04_services/vchiq-mmal/mmal-msg-common.h | 2 +- drivers/staging/vc04_services/vchiq-mmal/mmal-msg-format.h | 2 +- drivers/staging/vc04_services/vchiq-mmal/mmal-msg-port.h | 2 +- drivers/staging/vc04_services/vchiq-mmal/mmal-msg.h | 2 +- drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h | 2 +- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 2 +- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c = b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index c729b1b7de71..597c51e8ddf4 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Broadcom BM2835 V4L2 driver + * Broadcom BCM2835 V4L2 driver * * Copyright =C2=A9 2013 Raspberry Pi (Trading) Ltd. * diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h = b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h index 84ba789af120..0f0c6f7a3764 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * Broadcom BM2835 V4L2 driver + * Broadcom BCM2835 V4L2 driver * * Copyright =C2=A9 2013 Raspberry Pi (Trading) Ltd. * diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/driv= ers/staging/vc04_services/bcm2835-camera/controls.c index 178fb310b89a..eb722f16fb91 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Broadcom BM2835 V4L2 driver + * Broadcom BCM2835 V4L2 driver * * Copyright =C2=A9 2013 Raspberry Pi (Trading) Ltd. * diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h b/drive= rs/staging/vc04_services/vchiq-mmal/mmal-common.h index 5bd7410a034a..b33129403a30 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * Broadcom BM2835 V4L2 driver + * Broadcom BCM2835 V4L2 driver * * Copyright =C2=A9 2013 Raspberry Pi (Trading) Ltd. * diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-encodings.h b/dr= ivers/staging/vc04_services/vchiq-mmal/mmal-encodings.h index 2be9941a1f30..e15ae7b24f73 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-encodings.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-encodings.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * Broadcom BM2835 V4L2 driver + * Broadcom BCM2835 V4L2 driver * * Copyright =C2=A9 2013 Raspberry Pi (Trading) Ltd. * diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-msg-common.h b/d= rivers/staging/vc04_services/vchiq-mmal/mmal-msg-common.h index 342c9b670f7e..d77e15f25dda 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-msg-common.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-msg-common.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * Broadcom BM2835 V4L2 driver + * Broadcom BCM2835 V4L2 driver * * Copyright =C2=A9 2013 Raspberry Pi (Trading) Ltd. * diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-msg-format.h b/d= rivers/staging/vc04_services/vchiq-mmal/mmal-msg-format.h index a118efd21d98..1e996d8cd283 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-msg-format.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-msg-format.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * Broadcom BM2835 V4L2 driver + * Broadcom BCM2835 V4L2 driver * * Copyright =C2=A9 2013 Raspberry Pi (Trading) Ltd. * diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-msg-port.h b/dri= vers/staging/vc04_services/vchiq-mmal/mmal-msg-port.h index 3fa3f2a578f0..6ee4c1ed7f19 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-msg-port.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-msg-port.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * Broadcom BM2835 V4L2 driver + * Broadcom BCM2835 V4L2 driver * * Copyright =C2=A9 2013 Raspberry Pi (Trading) Ltd. * diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-msg.h b/drivers/= staging/vc04_services/vchiq-mmal/mmal-msg.h index b636e889c8a1..471413248a14 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-msg.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-msg.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * Broadcom BM2835 V4L2 driver + * Broadcom BCM2835 V4L2 driver * * Copyright =C2=A9 2013 Raspberry Pi (Trading) Ltd. * diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h b/d= rivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h index a1e39b1b1701..2277e05b1e31 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * Broadcom BM2835 V4L2 driver + * Broadcom BCM2835 V4L2 driver * * Copyright =C2=A9 2013 Raspberry Pi (Trading) Ltd. * diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/driver= s/staging/vc04_services/vchiq-mmal/mmal-vchiq.c index 76d3f0399964..cb6cdbfaf6ec 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Broadcom BM2835 V4L2 driver + * Broadcom BCM2835 V4L2 driver * * Copyright =C2=A9 2013 Raspberry Pi (Trading) Ltd. * diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h b/driver= s/staging/vc04_services/vchiq-mmal/mmal-vchiq.h index 1dc81ecf9268..6006e29232b3 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* - * Broadcom BM2835 V4L2 driver + * Broadcom BCM2835 V4L2 driver * * Copyright =C2=A9 2013 Raspberry Pi (Trading) Ltd. * --=20 2.34.1