From nobody Wed Jul 1 03:04:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A1B4C433FE for ; Mon, 3 Jan 2022 16:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233578AbiACQm7 (ORCPT ); Mon, 3 Jan 2022 11:42:59 -0500 Received: from mout-y-209.mailbox.org ([91.198.250.237]:13554 "EHLO mout-y-209.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbiACQmy (ORCPT ); Mon, 3 Jan 2022 11:42:54 -0500 X-Greylist: delayed 477 seconds by postgrey-1.27 at vger.kernel.org; Mon, 03 Jan 2022 11:42:54 EST Received: from smtp202.mailbox.org (unknown [91.198.250.118]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-209.mailbox.org (Postfix) with ESMTPS id 4JSLv342gWzQl13; Mon, 3 Jan 2022 17:34:55 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sylv.io; s=MBO0001; t=1641227691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eVaFMeMetbF2chCKkaAP7mGT+Mpn+9qurXFgcY31yEw=; b=RELAq90Z9vHK6rkuZ9Ko8eYCR/XT4rUj1XVatTCXJqLGU/4D80DcXLRJjMkrPm+ZYIP0Pc 4kkEsZmydu18ideLPYCbFl1HHuvSGENl2UNlHaoHZI3AVxNrsHp2fTxzVbDcg3m3j5b1n3 BMuerl5u61AhnAauFenAJC2ptVaTsBn4CYROOHyOit2nMFyuCX9LTJAZPTKej/Y9qz1mlj X8OVOpXBCJG8K8GneLhhCFQmOY/++15bfxKhvVJnJSo7Z7aecZqwyLUq6JD0/17x4F8qt5 +U8STaWb0lY4FzwJNpf9rPfiBq8AdNLHJmNnESGa5wp9uf2NQ68669TwPLoFgg== From: Marcello Sylvester Bauer To: linux-hwmon@vger.kernel.org Cc: Marcello Sylvester Bauer , Patrick Rudolph , Jean Delvare , Guenter Roeck , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/4] hwmon: (max6639) Update Datasheet URL Date: Mon, 3 Jan 2022 17:33:46 +0100 Message-ID: <9de5b23396e4031158a68bfbd47d370b50080e43.1641224715.git.sylv@sylv.io> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20220103163346.GUOb9GrIUkt88oI7umNYX2_stsYkAgTiHFfbx-wqzaI@z> Content-Type: text/plain; charset="utf-8" The old Datasheet does not exist anymore. Signed-off-by: Marcello Sylvester Bauer --- Documentation/hwmon/max6639.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/hwmon/max6639.rst b/Documentation/hwmon/max6639.= rst index 3da54225f83c..c85d285a3489 100644 --- a/Documentation/hwmon/max6639.rst +++ b/Documentation/hwmon/max6639.rst @@ -9,7 +9,7 @@ Supported chips: =20 Addresses scanned: I2C 0x2c, 0x2e, 0x2f =20 - Datasheet: http://pdfserv.maxim-ic.com/en/ds/MAX6639.pdf + Datasheet: https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX663= 9F.pdf =20 Authors: - He Changqing --=20 2.33.1 From nobody Wed Jul 1 03:04:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F392C433F5 for ; Mon, 3 Jan 2022 16:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234653AbiACQnA (ORCPT ); Mon, 3 Jan 2022 11:43:00 -0500 Received: from mout-y-209.mailbox.org ([91.198.250.237]:13558 "EHLO mout-y-209.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231509AbiACQmy (ORCPT ); Mon, 3 Jan 2022 11:42:54 -0500 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-209.mailbox.org (Postfix) with ESMTPS id 4JSLv267SbzQkmM; Mon, 3 Jan 2022 17:34:54 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sylv.io; s=MBO0001; t=1641227694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gy/SaMPYaRnqLDcyWl/RE0Zx5SaX9Qnp25v+7IjRdcc=; b=fSlNrREeNCx7SCBx4B9exzqYLdnYuXiAUZgjV40/3JQ8OHjtoLMUzNkfMgM67GzafNwH5r bYK6R3Slfm0/PNA31r1zGwBNafx0ud9ZCxC9+v9onINzi/Alo2dNC8llvFQafwPzh7vD1Z uMbIktEK06z47knFhk7WhccxnULYFHMxjlXoy1bIp88FrhAz5RARSthf1hjCBoGh0nBEF5 AVemu8EA4OcPnYG1vdZCVGXDyGv71PNgKAvhZrEqtQVWLLTI+fuY1ITqtKFgI2FQGun0uJ NmVVRHe9lc+K+jyH0myEwcyuKFyfELozIRXDUxN1BdBYMHo9CWP2D+JNMs1n2g== From: Marcello Sylvester Bauer To: linux-hwmon@vger.kernel.org Cc: Marcello Sylvester Bauer , Patrick Rudolph , Jean Delvare , Guenter Roeck , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: [PATCH v1 2/4] hwmon: (max6639) Add regulator support Date: Mon, 3 Jan 2022 17:33:47 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20220103163347.72EDpI-HyoX_XTdJKn2QLnKx_QQDOT37KmvvogxPdJo@z> Content-Type: text/plain; charset="utf-8" Add regulator support for boards where the fan-supply have to be powered up before it can be used. Signed-off-by: Patrick Rudolph Signed-off-by: Marcello Sylvester Bauer --- drivers/hwmon/max6639.c | 75 ++++++++++++++++++++++++++++++++++++----- 1 file changed, 67 insertions(+), 8 deletions(-) diff --git a/drivers/hwmon/max6639.c b/drivers/hwmon/max6639.c index ccc0f047bd44..d733c35b5bcf 100644 --- a/drivers/hwmon/max6639.c +++ b/drivers/hwmon/max6639.c @@ -87,6 +87,9 @@ struct max6639_data { /* Register values initialized only once */ u8 ppr; /* Pulses per rotation 0..3 for 1..4 ppr */ u8 rpm_range; /* Index in above rpm_ranges table */ + + /* Optional regulator for FAN supply */ + struct regulator *reg; }; =20 static struct max6639_data *max6639_update_device(struct device *dev) @@ -296,6 +299,17 @@ static ssize_t pwm_store(struct device *dev, return res; =20 val =3D clamp_val(val, 0, 255); + if (data->reg) { + res =3D 0; + if (val =3D=3D 0) + res =3D regulator_disable(data->reg); + else + res =3D regulator_enable(data->reg); + if (res) { + dev_err(dev, "Failed to operate fan supply: %d\n", res); + return res; + } + } =20 mutex_lock(&data->update_lock); data->pwm[attr->index] =3D (u8)(val * 120 / 255); @@ -516,6 +530,11 @@ static int max6639_detect(struct i2c_client *client, return 0; } =20 +static void max6639_regulator_disable(void *data) +{ + regulator_disable(data); +} + static int max6639_probe(struct i2c_client *client) { struct device *dev =3D &client->dev; @@ -528,6 +547,30 @@ static int max6639_probe(struct i2c_client *client) return -ENOMEM; =20 data->client =3D client; + + data->reg =3D devm_regulator_get_optional(dev, "fan"); + if (IS_ERR(data->reg)) { + if (PTR_ERR(data->reg) !=3D -ENODEV) { + err =3D (int)PTR_ERR(data->reg); + dev_warn(dev, "Failed looking up fan supply: %d\n", err); + return err; + } + data->reg =3D NULL; + } else { + /* Spin up fans */ + err =3D regulator_enable(data->reg); + if (err) { + dev_err(dev, "Failed to enable fan supply: %d\n", err); + return err; + } + err =3D devm_add_action_or_reset(dev, max6639_regulator_disable, + data->reg); + if (err) { + dev_err(dev, "Failed to register action: %d\n", err); + return err; + } + } + mutex_init(&data->update_lock); =20 /* Initialize the max6639 chip */ @@ -545,23 +588,39 @@ static int max6639_probe(struct i2c_client *client) static int max6639_suspend(struct device *dev) { struct i2c_client *client =3D to_i2c_client(dev); - int data =3D i2c_smbus_read_byte_data(client, MAX6639_REG_GCONFIG); - if (data < 0) - return data; + struct max6639_data *data =3D dev_get_drvdata(dev); + int ret =3D i2c_smbus_read_byte_data(client, MAX6639_REG_GCONFIG); + + if (ret < 0) + return ret; + + if (data->reg) + regulator_disable(data->reg); =20 return i2c_smbus_write_byte_data(client, - MAX6639_REG_GCONFIG, data | MAX6639_GCONFIG_STANDBY); + MAX6639_REG_GCONFIG, ret | MAX6639_GCONFIG_STANDBY); } =20 static int max6639_resume(struct device *dev) { struct i2c_client *client =3D to_i2c_client(dev); - int data =3D i2c_smbus_read_byte_data(client, MAX6639_REG_GCONFIG); - if (data < 0) - return data; + struct max6639_data *data =3D dev_get_drvdata(dev); + int ret; + + if (data->reg) { + ret =3D regulator_enable(data->reg); + if (ret) { + dev_err(dev, "Failed to enable fan supply: %d\n", ret); + return ret; + } + } + + ret =3D i2c_smbus_read_byte_data(client, MAX6639_REG_GCONFIG); + if (ret < 0) + return ret; =20 return i2c_smbus_write_byte_data(client, - MAX6639_REG_GCONFIG, data & ~MAX6639_GCONFIG_STANDBY); + MAX6639_REG_GCONFIG, ret & ~MAX6639_GCONFIG_STANDBY); } #endif /* CONFIG_PM_SLEEP */ =20 --=20 2.33.1 From nobody Wed Jul 1 03:04:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B94D2C433EF for ; Mon, 3 Jan 2022 16:41:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234625AbiACQls (ORCPT ); Mon, 3 Jan 2022 11:41:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231146AbiACQlk (ORCPT ); Mon, 3 Jan 2022 11:41:40 -0500 X-Greylist: delayed 399 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 03 Jan 2022 08:41:40 PST Received: from mout-y-111.mailbox.org (mout-y-111.mailbox.org [IPv6:2001:67c:2050:1::465:111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2042EC061785; Mon, 3 Jan 2022 08:41:40 -0800 (PST) Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-111.mailbox.org (Postfix) with ESMTPS id 4JSLv74cSrzQlLN; Mon, 3 Jan 2022 17:34:59 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sylv.io; s=MBO0001; t=1641227697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xMrRSAFFQ28kkRErHsEHfo+NPf5sueFwy0kVjjKr9jw=; b=obmSI9kz6ea/GSHI0nlpnkgVVFZvRG7UR6KcbP+zmWhL6YWTZRWBw6qdiWEhe6Igx31Wtf kMLxDAuNsTo+oPbVD3l7l24xmxDbx1H9PcItAV/wR6SW/BU9yONh6YvYW8c1LBgHwU2MDN mCw6Cp/K3LFYFnNk0OtB0IAXi1vloGfVWQ9Zx63j5N2MzXfcxy70C8FNJhjduskXT2SUv1 tyiio4Zy2uzgqkMAxd92twhu4Bvjj2T9DXIuuELRnlQYPfFr5Rl2nWXQaUN6QWe6ADGehU fohDY6khF3GZtZvgG9zff99oSpqu/FlvdbBycEKaCJ50JqW6iZhnnEa+LHHPkg== From: Marcello Sylvester Bauer To: linux-hwmon@vger.kernel.org Cc: Marcello Sylvester Bauer , Patrick Rudolph , Jean Delvare , Guenter Roeck , Rob Herring , Roland Stigge , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 3/4] dt-bindings: hwmon: Add binding for max6639 Date: Mon, 3 Jan 2022 17:33:48 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20220103163348.YJYr9nAD5bIZUULP10GoPBvF3vK3w5Hpb-CbnS2j7-A@z> Content-Type: text/plain; charset="utf-8" Add Devicetree binding documentation for Maxim MAX6639 temperature monitor with PWM fan-speed controller. The devicetree documentation for the SD3078 device tree. Signed-off-by: Marcello Sylvester Bauer --- .../bindings/hwmon/maxim,max6639.yaml | 71 +++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.y= aml diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/D= ocumentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file mode 100644 index 000000000000..136ed37b6aac --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml @@ -0,0 +1,71 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim max6639 + +maintainers: + - Roland Stigge + +description: | + The MAX6639 is a 2-channel temperature monitor with dual, automatic, PWM + fan-speed controller. It monitors its own temperature and one external + diode-connected transistor or the temperatures of two external diode-con= nected + transistors, typically available in CPUs, FPGAs, or GPUs. + + Datasheets: + https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf + +properties: + compatible: + enum: + - maxim,max6639 + + reg: + maxItems: 1 + + polarity: + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 1] + description: + PWM output is low at 100% duty cycle when this bit is set to zero. P= WM + output is high at 100% duty cycle when this bit is set to 1. + Fans PWM polarity is set to high (1) by default. + + pulses-per-revolution: + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [1, 2, 3, 4] + description: + Value specifying the number of pulses per revolution of the controll= ed + FAN. + + rpm-range: + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [2000, 4000, 8000, 16000] + description: + Scales the tachometer counter by setting the maximum (full-scale) va= lue + of the RPM range. + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + max6639@10 { + compatible =3D "maxim,max6639"; + reg =3D <0x10>; + polarity =3D <1>; + pulses-per-revolution =3D <2>; + rpm-range =3D <4000>; + }; + }; --=20 2.33.1 From nobody Wed Jul 1 03:04:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 802EAC433F5 for ; Mon, 3 Jan 2022 16:41:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234632AbiACQlu (ORCPT ); Mon, 3 Jan 2022 11:41:50 -0500 Received: from mout-y-111.mailbox.org ([91.198.250.236]:47506 "EHLO mout-y-111.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231614AbiACQll (ORCPT ); Mon, 3 Jan 2022 11:41:41 -0500 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-y-111.mailbox.org (Postfix) with ESMTPS id 4JSLv634ZYzQk9k; Mon, 3 Jan 2022 17:34:58 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sylv.io; s=MBO0001; t=1641227698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jGg109/SdVHAGsrAmpzH9OY+vbgtukVPEWTK0WDru0U=; b=X6Nlz27buP8i9o6PFocqdelqz2TasN39CkF4YEJ5nHXhcMEAlX3NdXwLEvONKHzxtw27fl s5XPTjN9zxuHvrXljbt7ZswAKXM2TB4F2g3r+MHlaWNRH08dvkyohDpCDOhCg9CfK06ET1 5foM6SomWd/Ps8TM7YcTSSfP+6LFOLbtxFKywiI4jPEGtq7PRWlx7tTgrtELJVJuEDsd+g XzBW1HgcJIh0pkwn32iM3YJpWIYq/N3wB/ODZCpqts1iF6/6LD8bFgouEqtolqp4G30hfN lZo5fqHLTCTtfjfjJyHYH9TLheEoB8R2SIxZq8MxCv3YzLalwjBO1py9+wHeLw== From: Marcello Sylvester Bauer To: linux-hwmon@vger.kernel.org Cc: Marcello Sylvester Bauer , Patrick Rudolph , Jean Delvare , Guenter Roeck , linux-kernel@vger.kernel.org Subject: [PATCH v1 4/4] hwmon: (max6639) Add devicetree support Date: Mon, 3 Jan 2022 17:33:49 +0100 Message-ID: <18f099abda66841042d71739c6ffd41c84434106.1641224715.git.sylv@sylv.io> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20220103163349.b39LmClJFeonHytp487m9x-dIM6EZti89IapHNRytDU@z> Content-Type: text/plain; charset="utf-8" Allow the driver to work with device tree support. Signed-off-by: Marcello Sylvester Bauer --- drivers/hwmon/max6639.c | 47 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/drivers/hwmon/max6639.c b/drivers/hwmon/max6639.c index d733c35b5bcf..f84ee4a05f80 100644 --- a/drivers/hwmon/max6639.c +++ b/drivers/hwmon/max6639.c @@ -412,6 +412,38 @@ static int rpm_range_to_reg(int range) return 1; /* default: 4000 RPM */ } =20 +static struct max6639_platform_data *get_pdata_from_dt_node(struct device = *dev) +{ + struct max6639_platform_data *pdata; + u32 pol, ppr, rpm; + int ret; + + pdata =3D devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); + if (!pdata) + return ERR_PTR(-ENOMEM); + + pdata->pwm_polarity =3D true; + ret =3D of_property_read_u32(dev->of_node, "polarity", &pol); + if (!ret && !pol) + pdata->pwm_polarity =3D false; + + ret =3D of_property_read_u32(dev->of_node, "pulses-per-revolution", &ppr); + if (ret < 0) + dev_warn(dev, "No pulses-per-revolution property\n"); + else + pdata->ppr =3D ppr; + + ret =3D of_property_read_u32(dev->of_node, "rpm-range", &rpm); + if (ret < 0) { + dev_warn(dev, "no rpm-range property\n"); + pdata->rpm_range =3D 4000; + } else { + pdata->rpm_range =3D rpm; + } + + return pdata; +} + static int max6639_init_client(struct i2c_client *client, struct max6639_data *data) { @@ -421,6 +453,12 @@ static int max6639_init_client(struct i2c_client *clie= nt, int rpm_range =3D 1; /* default: 4000 RPM */ int err; =20 + if (!max6639_info && client->dev.of_node) { + max6639_info =3D get_pdata_from_dt_node(&client->dev); + if (IS_ERR(max6639_info)) + return PTR_ERR(max6639_info); + } + /* Reset chip to default values, see below for GCONFIG setup */ err =3D i2c_smbus_write_byte_data(client, MAX6639_REG_GCONFIG, MAX6639_GCONFIG_POR); @@ -631,6 +669,14 @@ static const struct i2c_device_id max6639_id[] =3D { =20 MODULE_DEVICE_TABLE(i2c, max6639_id); =20 +#ifdef CONFIG_OF +static const struct of_device_id maxim_of_platform_match[] =3D { + {.compatible =3D "maxim,max6639"}, + {}, +}; +MODULE_DEVICE_TABLE(of, maxim_of_platform_match); +#endif + static SIMPLE_DEV_PM_OPS(max6639_pm_ops, max6639_suspend, max6639_resume); =20 static struct i2c_driver max6639_driver =3D { @@ -638,6 +684,7 @@ static struct i2c_driver max6639_driver =3D { .driver =3D { .name =3D "max6639", .pm =3D &max6639_pm_ops, + .of_match_table =3D of_match_ptr(maxim_of_platform_match), }, .probe_new =3D max6639_probe, .id_table =3D max6639_id, --=20 2.33.1