From nobody Wed Jul 1 13:23:44 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F2ABC433F5 for ; Mon, 20 Dec 2021 21:31:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231426AbhLTVbL (ORCPT ); Mon, 20 Dec 2021 16:31:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231395AbhLTVbJ (ORCPT ); Mon, 20 Dec 2021 16:31:09 -0500 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAC7CC061574 for ; Mon, 20 Dec 2021 13:31:08 -0800 (PST) Received: by mail-qv1-xf32.google.com with SMTP id kj16so6632415qvb.2 for ; Mon, 20 Dec 2021 13:31:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XbS9uErZ5c4CCSbiHzp6Nqw9oW8CSOfv3JYeCjB7h/s=; b=ZV2zXZFTlYuITazlNNWKKFxASGrjAHJze0zJTlYdiCD8QL/zjDYWvNbY89WdPJUoIA 3xQzH1UtKZ/YIx6tIJu0P1FrudhMy2ldKE/xmX+EyXAmTBKmTxpwDwYlR22hue7Z2Mww 48be5SJ4bIqXnix7MHQcP7SJ/2Ief5l6Jzlai0SakgOPciszJfpca8I+76Wa8u+rsroT 1CMUKoIen4vDITSx6ohEk37N2tEbM+CA+GPvSpnOs3TN4JLirGOrDJ/DdEecSoN2KuIK TNYK4/xW++y9I5wgSK8tmgpfu8igpAJA2Vrhu6a4KtysUxkGT9g8rCrQ32teNyXw+GrX skwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XbS9uErZ5c4CCSbiHzp6Nqw9oW8CSOfv3JYeCjB7h/s=; b=Mkx7kHAMkdaQhH5/IlC0cGtWjVvCh9UaBDEzzfRzhCuHWTNIoewkVM6xXj/uTeJpZj 76845n+tImAtUS5U09Dw1NvGzxGOrNMVsnA3VATGzsvZkvPb1XF9S3btUDNRln6NstKg MntOigB4cAA/QS/BuIKEtfgEflKQKaM9TsoRm+FXRJ7jEi0njkE7rfgx1J7fD1ciIcei GKasHXdj2XzuZZcQexDN/5uLmMDlA6PSs3c16qcgkWXmwrOBXBV7eBhge7yd09s4Gzmx dAWrKC0O2F3X6grNC3tIhlIU0Par5k6RL0xIo3GS9ShNFk81xUGkAUqTHGRhg9l/Zizy d70g== X-Gm-Message-State: AOAM532GgONT75UdG5YsQoIb60ntfEq4qRv7fKC+Gl3Lh09yeacK3eoy sQ6NHU2RD+dRCvMSVLPnqtk= X-Google-Smtp-Source: ABdhPJxKZCXLVtjy5SJQkGzGpUEqkJD9cq5OV6++SDXZLl1EbbJvmvvBInFUzc53pV55WkgBljI9Rg== X-Received: by 2002:a05:6214:20e9:: with SMTP id 9mr14767113qvk.28.1640035868201; Mon, 20 Dec 2021 13:31:08 -0800 (PST) Received: from localhost.localdomain ([181.23.83.92]) by smtp.gmail.com with ESMTPSA id s20sm16132210qtc.75.2021.12.20.13.31.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 13:31:07 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 1/4] staging: vc04_services: avoid the use of typedef for function pointers Date: Mon, 20 Dec 2021 18:29:11 -0300 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Replace typedefs bcm2835_audio_newpcm_func and bcm2835_audio_newctl_func with equivalent declarations to better align with the linux kernel coding style. As the '_func' in the function names is somehow reduntant, it was dropped in favour of the shorter names: 'bcm2835_audio_newpcm' and 'bcm2835_audio_newctl' Signed-off-by: Gaston Gonzalez --- .../vc04_services/bcm2835-audio/bcm2835.c | 28 ++++++++----------- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c b/driver= s/staging/vc04_services/bcm2835-audio/bcm2835.c index c250fbef2fa3..412342d5b6c9 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c @@ -52,20 +52,14 @@ static int bcm2835_devm_add_vchi_ctx(struct device *dev) return 0; } =20 -typedef int (*bcm2835_audio_newpcm_func)(struct bcm2835_chip *chip, - const char *name, - enum snd_bcm2835_route route, - u32 numchannels); - -typedef int (*bcm2835_audio_newctl_func)(struct bcm2835_chip *chip); - struct bcm2835_audio_driver { struct device_driver driver; const char *shortname; const char *longname; int minchannels; - bcm2835_audio_newpcm_func newpcm; - bcm2835_audio_newctl_func newctl; + int (*bcm2835_audio_newpcm)(struct bcm2835_chip *chip, const char *name, + enum snd_bcm2835_route route, u32 numchannels); + int (*bcm2835_audio_newctl)(struct bcm2835_chip *chip); enum snd_bcm2835_route route; }; =20 @@ -104,8 +98,8 @@ static struct bcm2835_audio_driver bcm2835_audio_alsa = =3D { .shortname =3D "bcm2835 ALSA", .longname =3D "bcm2835 ALSA", .minchannels =3D 2, - .newpcm =3D bcm2835_audio_alsa_newpcm, - .newctl =3D snd_bcm2835_new_ctl, + .bcm2835_audio_newpcm =3D bcm2835_audio_alsa_newpcm, + .bcm2835_audio_newctl =3D snd_bcm2835_new_ctl, }; =20 static struct bcm2835_audio_driver bcm2835_audio_hdmi =3D { @@ -116,8 +110,8 @@ static struct bcm2835_audio_driver bcm2835_audio_hdmi = =3D { .shortname =3D "bcm2835 HDMI", .longname =3D "bcm2835 HDMI", .minchannels =3D 1, - .newpcm =3D bcm2835_audio_simple_newpcm, - .newctl =3D snd_bcm2835_new_hdmi_ctl, + .bcm2835_audio_newpcm =3D bcm2835_audio_simple_newpcm, + .bcm2835_audio_newctl =3D snd_bcm2835_new_hdmi_ctl, .route =3D AUDIO_DEST_HDMI }; =20 @@ -129,8 +123,8 @@ static struct bcm2835_audio_driver bcm2835_audio_headph= ones =3D { .shortname =3D "bcm2835 Headphones", .longname =3D "bcm2835 Headphones", .minchannels =3D 1, - .newpcm =3D bcm2835_audio_simple_newpcm, - .newctl =3D snd_bcm2835_new_headphones_ctl, + .bcm2835_audio_newpcm =3D bcm2835_audio_simple_newpcm, + .bcm2835_audio_newctl =3D snd_bcm2835_new_headphones_ctl, .route =3D AUDIO_DEST_HEADPHONES }; =20 @@ -189,7 +183,7 @@ static int snd_add_child_device(struct device *dev, strscpy(card->shortname, audio_driver->shortname, sizeof(card->shortname)= ); strscpy(card->longname, audio_driver->longname, sizeof(card->longname)); =20 - err =3D audio_driver->newpcm(chip, audio_driver->shortname, + err =3D audio_driver->bcm2835_audio_newpcm(chip, audio_driver->shortname, audio_driver->route, numchans); if (err) { @@ -197,7 +191,7 @@ static int snd_add_child_device(struct device *dev, goto error; } =20 - err =3D audio_driver->newctl(chip); + err =3D audio_driver->bcm2835_audio_newctl(chip); if (err) { dev_err(dev, "Failed to create controls, error %d\n", err); goto error; --=20 2.34.1 From nobody Wed Jul 1 13:23:44 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB67AC433EF for ; Mon, 20 Dec 2021 21:31:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231453AbhLTVbY (ORCPT ); Mon, 20 Dec 2021 16:31:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231428AbhLTVbV (ORCPT ); Mon, 20 Dec 2021 16:31:21 -0500 Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62390C061574 for ; Mon, 20 Dec 2021 13:31:21 -0800 (PST) Received: by mail-qt1-x82e.google.com with SMTP id m25so11059105qtq.13 for ; Mon, 20 Dec 2021 13:31:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hHGHF/771v/lWlHIpIBMgn0pJ2OF4beYEH9R0ZP6Heo=; b=GOztQB5WaoE24sEWGlnVpZkWx2AyyVC9XzzBKIsDrkDAWZa+49Qx8gfIezCdcqahTC rzEO0lK0h38kLkhlAN182np60N4wYxXZPqHdetD/9SZhLPGa4wctdhxkjOQV5za6W0Pi Ihj2LRv4ccblWuqYM9VkozQ9c/9JA3awsnudBreEck7RrU6snyayJ5Gu1KmB5L5xO1tp 0yB14Ngzfpah5gEWWm20xqbfknoJrQMlAqILi8GUkuSozNla3UxQ3qKKQ1th4NJQ176X JAfuSfzrKOWK9nTtw/W3jh+FVK7g31sGyaTlbSyUAFbxWrw8EB2A+H8kOgwyp0QkjjBZ B/yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hHGHF/771v/lWlHIpIBMgn0pJ2OF4beYEH9R0ZP6Heo=; b=r11IwxTe+jV0SotRNkBP9k+xaitcqs6pPrRkzuxo+Rd4LSfBrgZhCL0iEN7enansl1 8KLK655MK4LyWlt43P/ttldd4MYs+MBXLeYTI/xbAVHboWYstykF1jJT7/sMWjnZj15e j894VDt8xgbVW7A9O8PiFX+nn1OU8LmnZm0znLgDmShai4kFkaYUpnVycltU5inY9WMh FnwobBsvXEYSYmp6wVGmM3EcXfUCMIZp2a6i1nWPAl6m4XZGUHYEM+ubID9s0MAXx+1r zSXHJFlHrC/ndU9H738R/lwVSZH98QBpm1XuFK1QtnmJGUMsEUvPnD07B7aHy5nTK9Kw 9tKg== X-Gm-Message-State: AOAM53073gfMSQrIqRHyJFwmyhbqBBEojh+MqYozD+qtMEHcmjKF8Th0 DbYs4W+JOXTMdJ+nBf6o3J8= X-Google-Smtp-Source: ABdhPJzEtJ9Sg4a2vOVNIx/4lbdFVp/bxHtTeMpseOoJWPVQCChWxpxX20RMHtpkvjPjfkA+EYpI9w== X-Received: by 2002:ac8:5dcf:: with SMTP id e15mr14402883qtx.567.1640035880556; Mon, 20 Dec 2021 13:31:20 -0800 (PST) Received: from localhost.localdomain ([181.23.83.92]) by smtp.gmail.com with ESMTPSA id s20sm16132210qtc.75.2021.12.20.13.31.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 13:31:20 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 2/4] staging: vc04_services: avoid the use of typedef for function pointers Date: Mon, 20 Dec 2021 18:29:12 -0300 Message-Id: <7f681ccee713ef8600f40c765b6a59e119c6bf2c.1639858361.git.gascoar@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Replace typedef bm2835_mmal_v4l2_ctrl_cb with equivalent declaration to better align with the linux kernel coding style. Signed-off-by: Gaston Gonzalez --- .../vc04_services/bcm2835-camera/controls.c | 76 +++++++++---------- 1 file changed, 35 insertions(+), 41 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/driv= ers/staging/vc04_services/bcm2835-camera/controls.c index b096a12387f7..7782742396fc 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -65,13 +65,6 @@ enum bm2835_mmal_ctrl_type { MMAL_CONTROL_TYPE_CLUSTER, /* special cluster entry */ }; =20 -struct bm2835_mmal_v4l2_ctrl; - -typedef int(bm2835_mmal_v4l2_ctrl_cb)( - struct bm2835_mmal_dev *dev, - struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl); - struct bm2835_mmal_v4l2_ctrl { u32 id; /* v4l2 control identifier */ enum bm2835_mmal_ctrl_type type; @@ -84,7 +77,8 @@ struct bm2835_mmal_v4l2_ctrl { u64 step; /* step size of the control */ const s64 *imenu; /* integer menu array */ u32 mmal_id; /* mmal parameter id */ - bm2835_mmal_v4l2_ctrl_cb *setter; + int (*bm2835_mmal_v4l2_ctrl_cb)(struct bm2835_mmal_dev *dev, struct v4l2_= ctrl *ctrl, + const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl); }; =20 struct v4l2_to_mmal_effects_setting { @@ -898,12 +892,12 @@ static int bm2835_mmal_s_ctrl(struct v4l2_ctrl *ctrl) const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl =3D ctrl->priv; int ret; =20 - if (!mmal_ctrl || mmal_ctrl->id !=3D ctrl->id || !mmal_ctrl->setter) { + if (!mmal_ctrl || mmal_ctrl->id !=3D ctrl->id || !mmal_ctrl->bm2835_mmal_= v4l2_ctrl_cb) { pr_warn("mmal_ctrl:%p ctrl id:%d\n", mmal_ctrl, ctrl->id); return -EINVAL; } =20 - ret =3D mmal_ctrl->setter(dev, ctrl, mmal_ctrl); + ret =3D mmal_ctrl->bm2835_mmal_v4l2_ctrl_cb(dev, ctrl, mmal_ctrl); if (ret) pr_warn("ctrl id:%d/MMAL param %08X- returned ret %d\n", ctrl->id, mmal_ctrl->mmal_id, ret); @@ -924,7 +918,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[V4= L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_SATURATION, - .setter =3D ctrl_set_rational, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_rational, }, { .id =3D V4L2_CID_SHARPNESS, @@ -935,7 +929,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[V4= L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_SHARPNESS, - .setter =3D ctrl_set_rational, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_rational, }, { .id =3D V4L2_CID_CONTRAST, @@ -946,7 +940,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[V4= L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_CONTRAST, - .setter =3D ctrl_set_rational, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_rational, }, { .id =3D V4L2_CID_BRIGHTNESS, @@ -957,7 +951,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[V4= L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_BRIGHTNESS, - .setter =3D ctrl_set_rational, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_rational, }, { .id =3D V4L2_CID_ISO_SENSITIVITY, @@ -968,7 +962,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[V4= L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D iso_qmenu, .mmal_id =3D MMAL_PARAMETER_ISO, - .setter =3D ctrl_set_iso, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_iso, }, { .id =3D V4L2_CID_ISO_SENSITIVITY_AUTO, @@ -979,7 +973,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[V4= L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_ISO, - .setter =3D ctrl_set_iso, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_iso, }, { .id =3D V4L2_CID_IMAGE_STABILIZATION, @@ -990,7 +984,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[V4= L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_VIDEO_STABILISATION, - .setter =3D ctrl_set_value, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_value, }, { .id =3D V4L2_CID_EXPOSURE_AUTO, @@ -1001,7 +995,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[V= 4L2_CTRL_COUNT] =3D { .step =3D 0, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_EXPOSURE_MODE, - .setter =3D ctrl_set_exposure, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_exposure, }, { .id =3D V4L2_CID_EXPOSURE_ABSOLUTE, @@ -1013,7 +1007,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_SHUTTER_SPEED, - .setter =3D ctrl_set_exposure, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_exposure, }, { .id =3D V4L2_CID_AUTO_EXPOSURE_BIAS, @@ -1024,7 +1018,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 0, .imenu =3D ev_bias_qmenu, .mmal_id =3D MMAL_PARAMETER_EXPOSURE_COMP, - .setter =3D ctrl_set_value_ev, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_value_ev, }, { .id =3D V4L2_CID_EXPOSURE_AUTO_PRIORITY, @@ -1036,7 +1030,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .imenu =3D NULL, /* Dummy MMAL ID as it gets mapped into FPS range */ .mmal_id =3D 0, - .setter =3D ctrl_set_exposure, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_exposure, }, { .id =3D V4L2_CID_EXPOSURE_METERING, @@ -1047,7 +1041,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 0, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_EXP_METERING_MODE, - .setter =3D ctrl_set_metering_mode, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_metering_mode, }, { .id =3D V4L2_CID_AUTO_N_PRESET_WHITE_BALANCE, @@ -1058,7 +1052,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 0, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_AWB_MODE, - .setter =3D ctrl_set_awb_mode, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_awb_mode, }, { .id =3D V4L2_CID_RED_BALANCE, @@ -1069,7 +1063,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_CUSTOM_AWB_GAINS, - .setter =3D ctrl_set_awb_gains, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_awb_gains, }, { .id =3D V4L2_CID_BLUE_BALANCE, @@ -1080,7 +1074,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_CUSTOM_AWB_GAINS, - .setter =3D ctrl_set_awb_gains, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_awb_gains, }, { .id =3D V4L2_CID_COLORFX, @@ -1091,7 +1085,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 0, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_IMAGE_EFFECT, - .setter =3D ctrl_set_image_effect, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_image_effect, }, { .id =3D V4L2_CID_COLORFX_CBCR, @@ -1102,7 +1096,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_COLOUR_EFFECT, - .setter =3D ctrl_set_colfx, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_colfx, }, { .id =3D V4L2_CID_ROTATE, @@ -1113,7 +1107,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 90, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_ROTATION, - .setter =3D ctrl_set_rotate, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_rotate, }, { .id =3D V4L2_CID_HFLIP, @@ -1124,7 +1118,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_MIRROR, - .setter =3D ctrl_set_flip, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_flip, }, { .id =3D V4L2_CID_VFLIP, @@ -1135,7 +1129,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_MIRROR, - .setter =3D ctrl_set_flip, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_flip, }, { .id =3D V4L2_CID_MPEG_VIDEO_BITRATE_MODE, @@ -1146,7 +1140,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 0, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_RATECONTROL, - .setter =3D ctrl_set_bitrate_mode, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_bitrate_mode, }, { .id =3D V4L2_CID_MPEG_VIDEO_BITRATE, @@ -1157,7 +1151,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 25 * 1000, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_VIDEO_BIT_RATE, - .setter =3D ctrl_set_bitrate, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_bitrate, }, { .id =3D V4L2_CID_JPEG_COMPRESSION_QUALITY, @@ -1168,7 +1162,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_JPEG_Q_FACTOR, - .setter =3D ctrl_set_image_encode_output, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_image_encode_output, }, { .id =3D V4L2_CID_POWER_LINE_FREQUENCY, @@ -1179,7 +1173,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_FLICKER_AVOID, - .setter =3D ctrl_set_flicker_avoidance, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_flicker_avoidance, }, { .id =3D V4L2_CID_MPEG_VIDEO_REPEAT_SEQ_HEADER, @@ -1190,7 +1184,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_VIDEO_ENCODE_INLINE_HEADER, - .setter =3D ctrl_set_video_encode_param_output, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_video_encode_param_output, }, { .id =3D V4L2_CID_MPEG_VIDEO_H264_PROFILE, @@ -1204,7 +1198,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_PROFILE, - .setter =3D ctrl_set_video_encode_profile_level, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_video_encode_profile_level, }, { .id =3D V4L2_CID_MPEG_VIDEO_H264_LEVEL, @@ -1226,7 +1220,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_PROFILE, - .setter =3D ctrl_set_video_encode_profile_level, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_video_encode_profile_level, }, { .id =3D V4L2_CID_SCENE_MODE, @@ -1238,7 +1232,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_PROFILE, - .setter =3D ctrl_set_scene_mode, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_scene_mode, }, { .id =3D V4L2_CID_MPEG_VIDEO_H264_I_PERIOD, @@ -1249,7 +1243,7 @@ static const struct bm2835_mmal_v4l2_ctrl v4l2_ctrls[= V4L2_CTRL_COUNT] =3D { .step =3D 1, .imenu =3D NULL, .mmal_id =3D MMAL_PARAMETER_INTRAPERIOD, - .setter =3D ctrl_set_video_encode_param_output, + .bm2835_mmal_v4l2_ctrl_cb =3D ctrl_set_video_encode_param_output, }, }; =20 @@ -1259,8 +1253,8 @@ int bm2835_mmal_set_all_camera_controls(struct bm2835= _mmal_dev *dev) int ret =3D 0; =20 for (c =3D 0; c < V4L2_CTRL_COUNT; c++) { - if ((dev->ctrls[c]) && (v4l2_ctrls[c].setter)) { - ret =3D v4l2_ctrls[c].setter(dev, dev->ctrls[c], + if ((dev->ctrls[c]) && (v4l2_ctrls[c].bm2835_mmal_v4l2_ctrl_cb)) { + ret =3D v4l2_ctrls[c].bm2835_mmal_v4l2_ctrl_cb(dev, dev->ctrls[c], &v4l2_ctrls[c]); if (ret) { v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev, --=20 2.34.1 From nobody Wed Jul 1 13:23:44 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B3BC433EF for ; Mon, 20 Dec 2021 21:31:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231482AbhLTVb2 (ORCPT ); Mon, 20 Dec 2021 16:31:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231454AbhLTVb0 (ORCPT ); Mon, 20 Dec 2021 16:31:26 -0500 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54E66C061574 for ; Mon, 20 Dec 2021 13:31:26 -0800 (PST) Received: by mail-qv1-xf29.google.com with SMTP id kj16so6633075qvb.2 for ; Mon, 20 Dec 2021 13:31:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3TZsqgcnexho8xD1nxnnl9R0Pkmm2FcWy2QDii/7Sys=; b=n7n49IRDQvxi7CHuTHh+u+OuE171gKGZZ7wBNG9SVgP38qEBz6+/x1F90nKaiV8OR0 Wgke/xLnpPtMYahVI6VTnKVS8h/pfBCINkn05Sl4blF9cx+mjPjwMYprlCp5h2T2HsTZ LVYtvBMKom+l8h1LcausygllYlzPVz5DfaAgxCTTA/Jg8T9SAMKWuj1VAOnrUPgftosv b3awbxGC2I0RLoqfzUfYnZlMUPjAimgzb78J7XCGrtPg7bTSrWFcwga6oKYpdS01H9Ho hGTyLu+V6ap9V+bAMbm+jtp7RuyNDryH/G/8UHie+aqJbqYse+CzgO1MlUaVEgbL5+Ll QGAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3TZsqgcnexho8xD1nxnnl9R0Pkmm2FcWy2QDii/7Sys=; b=C7W6D/Tn2u8k3H3XdoQUE5vVcGA4PQr/JNsn/wiDhabAXklxl1ZSOkWCMQ2GMUUgRG 1GyWedwpf1adP8IZUeaqxybYDdOdSit1Y/lIgr6GujlolW9bklw3DgiunJi5SjdroOU2 sGxgp4lo99FIuANztCc7hU3vJ/R4T26yfz1UtrviLTbX5dWsgiwkvCtZJv4BpZW7E+Sv jSmD3vo05EmmlBYbGcKs+2PrT6GCZ+JwLzmULnhuJdEAUXwiY+1u89uyN5pbo4ft2Q7X tU99jhxKfPqgx335k64jgfdy2gD3S+dPmECBBXHt22xkY0Cy7axAdcS7DICKrAV0wigQ v5Cg== X-Gm-Message-State: AOAM531tsiOknvRAISGbmxsIf1dXxXbuANJ0NLtOgVNNAZjxtHVfVL1u RmdRC7wx9DFQWOrkszqsCdo= X-Google-Smtp-Source: ABdhPJy805I2vaVWrMqFtSrfyvP2UMaV1jMyh9EYwgEB2ksQ59Z01784aSMHQfsx1wy4tIwFV0eJNA== X-Received: by 2002:a05:6214:500f:: with SMTP id jo15mr39831qvb.64.1640035885582; Mon, 20 Dec 2021 13:31:25 -0800 (PST) Received: from localhost.localdomain ([181.23.83.92]) by smtp.gmail.com with ESMTPSA id s20sm16132210qtc.75.2021.12.20.13.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 13:31:25 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 3/4] staging: vc04_services: avoid the use of typedef for function pointers Date: Mon, 20 Dec 2021 18:29:13 -0300 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Replace the function pointer typedef vchiq_mmal_buffer_cb with equivalent declaration to better align with the linux kernel coding style. While at it, realignments were done in some touched lines. Signed-off-by: Gaston Gonzalez --- .../vc04_services/vchiq-mmal/mmal-vchiq.c | 24 +++++++++---------- .../vc04_services/vchiq-mmal/mmal-vchiq.h | 13 +++++----- 2 files changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/driver= s/staging/vc04_services/vchiq-mmal/mmal-vchiq.c index 76d3f0399964..54e5ce245ae7 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c @@ -269,10 +269,10 @@ static void buffer_work_cb(struct work_struct *work) =20 atomic_dec(&msg_context->u.bulk.port->buffers_with_vpu); =20 - msg_context->u.bulk.port->buffer_cb(msg_context->u.bulk.instance, - msg_context->u.bulk.port, - msg_context->u.bulk.status, - msg_context->u.bulk.buffer); + msg_context->u.bulk.port->vchiq_mmal_buffer_cb(msg_context->u.bulk.instan= ce, + msg_context->u.bulk.port, + msg_context->u.bulk.status, + msg_context->u.bulk.buffer); } =20 /* workqueue scheduled callback to handle receiving buffers @@ -1327,13 +1327,12 @@ static int port_disable(struct vchiq_mmal_instance = *instance, mmalbuf =3D list_entry(buf_head, struct mmal_buffer, list); list_del(buf_head); - if (port->buffer_cb) { + if (port->vchiq_mmal_buffer_cb) { mmalbuf->length =3D 0; mmalbuf->mmal_flags =3D 0; mmalbuf->dts =3D MMAL_TIME_UNKNOWN; mmalbuf->pts =3D MMAL_TIME_UNKNOWN; - port->buffer_cb(instance, - port, 0, mmalbuf); + port->vchiq_mmal_buffer_cb(instance, port, 0, mmalbuf); } } =20 @@ -1363,7 +1362,7 @@ static int port_enable(struct vchiq_mmal_instance *in= stance, =20 port->enabled =3D 1; =20 - if (port->buffer_cb) { + if (port->vchiq_mmal_buffer_cb) { /* send buffer headers to videocore */ hdr_count =3D 1; list_for_each_safe(buf_head, q, &port->buffers) { @@ -1454,9 +1453,10 @@ EXPORT_SYMBOL_GPL(vchiq_mmal_port_parameter_get); * enables a port and queues buffers for satisfying callbacks if we * provide a callback handler */ -int vchiq_mmal_port_enable(struct vchiq_mmal_instance *instance, - struct vchiq_mmal_port *port, - vchiq_mmal_buffer_cb buffer_cb) +int vchiq_mmal_port_enable(struct vchiq_mmal_instance *instance, struct vc= hiq_mmal_port *port, + void (*vchiq_mmal_buffer_cb)(struct vchiq_mmal_instance *instance, + struct vchiq_mmal_port *port, int status, + struct mmal_buffer *buffer)) { int ret; =20 @@ -1469,7 +1469,7 @@ int vchiq_mmal_port_enable(struct vchiq_mmal_instance= *instance, goto unlock; } =20 - port->buffer_cb =3D buffer_cb; + port->vchiq_mmal_buffer_cb =3D vchiq_mmal_buffer_cb; =20 ret =3D port_enable(instance, port); =20 diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h b/driver= s/staging/vc04_services/vchiq-mmal/mmal-vchiq.h index 1dc81ecf9268..39615ce6584a 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h @@ -42,11 +42,6 @@ struct vchiq_mmal_port_buffer { =20 struct vchiq_mmal_port; =20 -typedef void (*vchiq_mmal_buffer_cb)( - struct vchiq_mmal_instance *instance, - struct vchiq_mmal_port *port, - int status, struct mmal_buffer *buffer); - struct vchiq_mmal_port { u32 enabled:1; u32 handle; @@ -76,7 +71,9 @@ struct vchiq_mmal_port { /* Count of buffers the VPU has yet to return */ atomic_t buffers_with_vpu; /* callback on buffer completion */ - vchiq_mmal_buffer_cb buffer_cb; + void (*vchiq_mmal_buffer_cb)(struct vchiq_mmal_instance *instance, + struct vchiq_mmal_port *port, int status, + struct mmal_buffer *buffer); /* callback context */ void *cb_ctx; }; @@ -126,7 +123,9 @@ int vchiq_mmal_component_disable( int vchiq_mmal_port_enable( struct vchiq_mmal_instance *instance, struct vchiq_mmal_port *port, - vchiq_mmal_buffer_cb buffer_cb); + void (*vchiq_mmal_buffer_cb)(struct vchiq_mmal_instance *instance, + struct vchiq_mmal_port *port, int status, + struct mmal_buffer *buffer)); =20 /* disable a port * --=20 2.34.1 From nobody Wed Jul 1 13:23:44 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D3EC433F5 for ; Mon, 20 Dec 2021 21:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231473AbhLTVbh (ORCPT ); Mon, 20 Dec 2021 16:31:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231488AbhLTVbb (ORCPT ); Mon, 20 Dec 2021 16:31:31 -0500 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B9A5C06173E for ; Mon, 20 Dec 2021 13:31:31 -0800 (PST) Received: by mail-qk1-x72c.google.com with SMTP id t83so10688367qke.8 for ; Mon, 20 Dec 2021 13:31:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zj4Z1AB35wd1vTKNBKFRSR6CiKchENns4ZR0v8Fns04=; b=GOR0MBa/Xmy00Aw3b2EieHWd7CevEII7rqbIH1TFVHaFKdc+fYX+8ELGhF9kBQtlPp z0ZPRv2mu7C/hIKRpXtuSChBuzewZU5PA/E+WbUVDvS0Vbv+PlYrCXHXwV+0KE7VOjUv BvFP75ohX2KULNxqsZtMK/IbRDn0q+xXgfL3zW26AgCdM4+c4042iC9UGvKARh1RdUjm qFteVVxJEVQaRld6ohFMOt0yS6Bw65KMFIr8nOX2uyUsZhvfKAFzRh/VGOAAO/pear3x iUVJKfQ3jmuTFf6MkSoD2SKUe+SzDE2BRv2JjKT37jhC6xChgxDbv6r8dt5BHDT8Ktya DFQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zj4Z1AB35wd1vTKNBKFRSR6CiKchENns4ZR0v8Fns04=; b=Yc4zW4w1bA+zHY74v+Kxx1EHDzFhW/nNRNntdvy6XysZfm4zp1p9VMR5CWkkw9Etmh ZJAnXz3oR1qFKTRLpFwE2+ZMcWIOLgMHj31vJOYcaJyVSXB7WP2jahlQlBGSWTed3qvF 7eD780VC6GXRhd1MHy1PK9lMhplmdBWTCB+tkdl3BlXl+ytHPiurKm7hE7no/3MBB075 wHLASp2hOu74ebxZsX9NZeDLzp5hPuKzVNQxnMIUB+RkM4R+Vz9GhGfKLf8D1DLdSmQl 2iq5NbVKZM513hdj62U+LElTiTDKtAViIsnt/Bup7DUr1TnM5CqaX4q1BDVkIbPCgr6a 9DZA== X-Gm-Message-State: AOAM531frXs+XlYEkJTbgWxItqRjYwOY8cVw0jxmU8nahWxyKuuh+4Nw pzj16xxTaaXlYgTYbEGrHrk= X-Google-Smtp-Source: ABdhPJwt6/EGrHzCkJ2tXvrtDivRehX0CRfFibm2LENvRbcLBNB+fSJskiTi96LHjFD+g7S7ssn5rQ== X-Received: by 2002:a37:9ed5:: with SMTP id h204mr76593qke.35.1640035890318; Mon, 20 Dec 2021 13:31:30 -0800 (PST) Received: from localhost.localdomain ([181.23.83.92]) by smtp.gmail.com with ESMTPSA id s20sm16132210qtc.75.2021.12.20.13.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 13:31:30 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 4/4] staging: vc04_services: update TODO file Date: Mon, 20 Dec 2021 18:29:14 -0300 Message-Id: <53c397198ee5f0294b88452cfe24321829a0837d.1639858361.git.gascoar@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There are no typedef remaining under vc04_services/. Hence, remove the task from the TODO file. While at it, fix the items sequential numbering. Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/TODO | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging= /vc04_services/interface/TODO index 39810ce017cd..241ca004735c 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -80,11 +80,7 @@ vchiq-core.ko and vchiq-dev.ko. This would also ease the= upstreaming process. =20 The code in vchiq_bcm2835_arm.c should fit in the generic platform file. =20 -12) Get rid of all the struct typedefs - -Most structs are typedefd, it's not encouraged in the kernel. - -13) Get rid of all non essential global structures and create a proper per +11) Get rid of all non essential global structures and create a proper per device structure =20 The first thing one generally sees in a probe function is a memory allocat= ion @@ -92,6 +88,6 @@ for all the device specific data. This structure is then = passed all over the driver. This is good practice since it makes the driver work regardless of= the number of devices probed. =20 -14) Clean up Sparse warnings from __user annotations. See +12) Clean up Sparse warnings from __user annotations. See vchiq_irq_queue_bulk_tx_rx(). Ensure that the address of "&waiter->bulk_wa= iter" is never disclosed to userspace. --=20 2.34.1