From nobody Wed Feb 11 16:10:49 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE852C77B75 for ; Mon, 8 May 2023 12:36:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234037AbjEHMg4 (ORCPT ); Mon, 8 May 2023 08:36:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233918AbjEHMgo (ORCPT ); Mon, 8 May 2023 08:36:44 -0400 Received: from relayaws-01.paragon-software.com (relayaws-01.paragon-software.com [35.157.23.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4986D391BE; Mon, 8 May 2023 05:36:39 -0700 (PDT) Received: from relayfre-01.paragon-software.com (unknown [172.30.72.12]) by relayaws-01.paragon-software.com (Postfix) with ESMTPS id 8DF8E21C3; Mon, 8 May 2023 12:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paragon-software.com; s=mail; t=1683549110; bh=h5cbTykc9cuI68jfwGBg6SVUQfDSQ4DeVKUgsn+zaao=; h=Date:Subject:From:To:CC:References:In-Reply-To; b=IrRYPMph4pWjLaHDypU5B9Y9R8yzwcToPVA1MQT0qienyTf8C7Jc/lyXDBRspjxm3 xBjgaKNCbXDoM4ITCj4bNnfrFkSulkmJlrN1KvGcO16aiOWNnJ/YQhrWutKP5hdwFd f+Js0zqSZmcLd9I6q7WK31VNpe0aZbd0Rtd1hXRM= Received: from dlg2.mail.paragon-software.com (vdlg-exch-02.paragon-software.com [172.30.1.105]) by relayfre-01.paragon-software.com (Postfix) with ESMTPS id 3F15B2191; Mon, 8 May 2023 12:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paragon-software.com; s=mail; t=1683549397; bh=h5cbTykc9cuI68jfwGBg6SVUQfDSQ4DeVKUgsn+zaao=; h=Date:Subject:From:To:CC:References:In-Reply-To; b=hm7oaKhjn6FnPfk/UtGsGFWrGvBA3FZap6DH8mF8yNUveTW8HtyndqQPBPLq0ejLy WPcBcwjAY7MnJdaxo42FUMZr12HEfrb37EbjxJ54u171P56ki/U8JhYVPTp1BxIE9j NoRKwmUiiObDkS0+UUxS6B5laYvBTH6CFeDXKSLc= Received: from [192.168.211.146] (192.168.211.146) by vdlg-exch-02.paragon-software.com (172.30.1.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Mon, 8 May 2023 15:36:36 +0300 Message-ID: Date: Mon, 8 May 2023 16:36:36 +0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH 02/10] fs/ntfs3: Fix ntfs_atomic_open Content-Language: en-US From: Konstantin Komarov To: CC: Linux Kernel Mailing List , References: In-Reply-To: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [192.168.211.146] X-ClientProxiedBy: vobn-exch-01.paragon-software.com (172.30.72.13) To vdlg-exch-02.paragon-software.com (172.30.1.105) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fixes xfstest 633/696. Signed-off-by: Konstantin Komarov --- =C2=A0fs/ntfs3/namei.c | 15 +++------------ =C2=A01 file changed, 3 insertions(+), 12 deletions(-) diff --git a/fs/ntfs3/namei.c b/fs/ntfs3/namei.c index 9736b1e4a0f6..343bce6da58a 100644 --- a/fs/ntfs3/namei.c +++ b/fs/ntfs3/namei.c @@ -422,19 +422,10 @@ static int ntfs_atomic_open(struct inode *dir,=20 struct dentry *dentry, =C2=A0=C2=A0=C2=A0 =C2=A0 * fnd contains tree's path to insert to. =C2=A0=C2=A0=C2=A0 =C2=A0 * If fnd is not NULL then dir is locked. =C2=A0=C2=A0=C2=A0 =C2=A0 */ - -=C2=A0=C2=A0 =C2=A0/* -=C2=A0=C2=A0 =C2=A0 * Unfortunately I don't know how to get here correct '= struct=20 nameidata *nd' -=C2=A0=C2=A0 =C2=A0 * or 'struct mnt_idmap *idmap'. -=C2=A0=C2=A0 =C2=A0 * See atomic_open in fs/namei.c. -=C2=A0=C2=A0 =C2=A0 * This is why xfstest/633 failed. -=C2=A0=C2=A0 =C2=A0 * Looks like ntfs_atomic_open must accept 'struct mnt_= idmap=20 *idmap' as argument. -=C2=A0=C2=A0 =C2=A0 */ - -=C2=A0=C2=A0 =C2=A0inode =3D ntfs_create_inode(&nop_mnt_idmap, dir, dentry= , uni, mode, 0, -=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2= =A0=C2=A0 NULL, 0, fnd); +=C2=A0=C2=A0 =C2=A0inode =3D ntfs_create_inode(mnt_idmap(file->f_path.mnt)= , dir, dentry,=20 uni, +=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2= =A0=C2=A0 mode, 0, NULL, 0, fnd); =C2=A0=C2=A0=C2=A0 =C2=A0err =3D IS_ERR(inode) ? PTR_ERR(inode) : -=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2= =A0=C2=A0=C2=A0=C2=A0 finish_open(file, dentry, ntfs_file_open); +=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 finish_open(file, dentry, ntfs_file_open); =C2=A0=C2=A0=C2=A0 =C2=A0dput(d); =C2=A0out2: --=20 2.34.1