From nobody Fri Apr 3 19:10:26 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E8CA314A83 for ; Mon, 23 Mar 2026 19:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292483; cv=none; b=dmoy6LbyE5acfGHMlgmBQ0YwLtJnnXRq6RSGz/nmieioXovHFdX861+iGLd3Vb3m/qZsvuDCJiJCRwTJbAADQAiUlYuUoKPf4f23MxcsWPVVpArt5jrao1GTKdbHUaJD9DWnd5ki2oxK3tYLv8DvgDyQamr4NB2+zXGnV4uKXw8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292483; c=relaxed/simple; bh=9ndQcMnASHDbDGInbvhNloK+6vYvAxVufHQrRaTqfBY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MecNSNoIT8ty4Ozj65JeTsnK5Gr8q7SCJwnYxFMaHjbc8YhatewXT2dpKJeVOAPv6eNWyovEOLhFbmE2g9/ohBfqujT4aZIqGBtYFfRshOO0Yd4uOsXNH2oRr9/ehoioLu9RJAGELgDDbhG1MNt8+vuyyAoDBDG0aG/IEfaG4GQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lfaTK2Lk; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lfaTK2Lk" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4853e1ce427so32827555e9.3 for ; Mon, 23 Mar 2026 12:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774292480; x=1774897280; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cYNDUizmJ/rKIkz2DY5qa0t62hb9uVCR9S4PHSBe3sY=; b=lfaTK2LkXzYhLRsZbF2zfeQEHweoJBNUrcrF6XswHplYxJvc1x1kegGN3P/7U7AW3K NGlVFGjTaFHUReqAv4s6PSYKqx2WVAR0cM1Jc/1BZa1qM9OLFbuXRZMYF+4m74QvMX36 0z3hn4aPY+2C537MufwQg4eSJy8h+3gDeSPcl2kPGgkgqVAODD9htDBNTbf3Fr884I+N ttC08fyUjUM/Gm0/8bqOSauVUohP6ATr3Phw8Wwgq595I1Sgbak57LlbQMA0INgcDtzI Bbl0xaCbrp7amKEMSoPv6gaf+9dSxKQ7F/zQ6QmUS80pJnnCNTwgh4icvRbAErZU/BNz s6hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774292480; x=1774897280; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cYNDUizmJ/rKIkz2DY5qa0t62hb9uVCR9S4PHSBe3sY=; b=GWcEiRxzS7LNSyE9+tLbv+PU8NIbg+l5APrUCRDyt0XLxpmgpsIH7MRLRYP9vZPwF9 ecVFvxybhA6vSgfG1hkIGX7BAP3P/EE5aCB2QS8EjrWSkafirMsWePOLxolQ9VgHNeJV HdSi+EXYBsQChdg6aKefnP4LHwPxohOceXvRflIIPyGQHcfrKzrRswdawS+GgFwE/Q15 C9K/64k2LepI5rNAuTP7KKH7N3FxgURFpO5APZIevAt3y04FSKYwOOlRUy5Lo6VDQ1Kl /htbapnPTS/z1JO6qYlgX/j2ELyl7K3wt2OgH/BRbDq5qgullz1whxbt+K1aibkYZzgJ cIuA== X-Forwarded-Encrypted: i=1; AJvYcCXJ1QGaMCu0JUc123NU6g9uMZpxkDGALTcI+xJPyqIzDE+p3D+lMDjQzWS3bDA8ah1S5JoyurOiYzQXT48=@vger.kernel.org X-Gm-Message-State: AOJu0YwsB5uGeInZ9Hz5KgaIOOT+giwVxl2va/ibBymMFC8W6RDdOP0K Xl8Fak5dcL1cj7kg3hNXTDFRnl27L9zE89Pa4op8I08RDQyWE1Pbg9oxDgrw9xnXRG4= X-Gm-Gg: ATEYQzyk3zmb0Hh72uu9LjflAOCRgEsPB5iVHPOK6JqYaxu22Ef5KAFwN4RFY89mHx1 +W11VsCOoQDAjjxfHAzhWCMBml5PfUrqMGHsIR79TQ7j/ZtAUG9UzPBSUDR20iIcDgGjvVruE71 bzgp00HBz6GglrY5jpNbIU/me4pHFUpKcZ7odDGIOUYSVxhjaz4s/o2VOmqJG9enJBaqimZSbRy eQLJmtSVFg5d6Fg8e4uPno9og6o/kooB+hKzavvzU2ZIHDm9lDd3fZSszK4030mfwqf126Lyo4i VSV80lrvbM7XuxGFWBftjiF0zkHTTVxtEy2hZNYHli5oIQWWixz3b8RmWTQ/LwC8Nsetem4EKda k0QBbyit+SQw6C51LTPrBbPaQsn2JZehqrDSxoX7jW/dwcSmynH5JaqH5vT3lXNNxBS+CK15fDj ZCDD8Foi+BXTsW95fAeVC+M4cJOSuZ X-Received: by 2002:a05:6000:4382:b0:43b:5192:894b with SMTP id ffacd0b85a97d-43b642426afmr20898486f8f.23.1774292479509; Mon, 23 Mar 2026 12:01:19 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644ae16fsm32522970f8f.8.2026.03.23.12.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 12:01:19 -0700 (PDT) Date: Mon, 23 Mar 2026 22:01:15 +0300 From: Dan Carpenter To: Sudeep Holla , AKASHI Takahiro Cc: Cristian Marussi , Linus Walleij , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Bartosz Golaszewski , Vincent Guittot , Khaled Ali Ahmed , Michal Simek Subject: [PATCH v6 2/7] pinctrl: scmi: Add SCMI_PIN_INPUT_VALUE Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The PIN_CONFIG_LEVEL parameter represents the value of the pin, whether reading or writing to the pin. In SCMI, the parameter is represented by two different values SCMI_PIN_OUTPUT_VALUE for writing to a pin and SCMI_PIN_INPUT_VALUE for reading. The current code translates PIN_CONFIG_LEVEL as SCMI_PIN_OUTPUT_VALUE (writing). Add a function to translate it to either INPUT or OUTPUT depending on whether it is called from a _get or _set() operation. Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Acked-by: Sudeep Holla --- v5: no change v4: add r-b tags v3: new patch drivers/pinctrl/pinctrl-scmi.c | 33 ++++++++++++++++++++++++++------- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c index f4f296e07be5..5d347e6b2e4c 100644 --- a/drivers/pinctrl/pinctrl-scmi.c +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -251,9 +251,6 @@ static int pinctrl_scmi_map_pinconf_type(enum pin_confi= g_param param, case PIN_CONFIG_MODE_LOW_POWER: *type =3D SCMI_PIN_LOW_POWER_MODE; break; - case PIN_CONFIG_LEVEL: - *type =3D SCMI_PIN_OUTPUT_VALUE; - break; case PIN_CONFIG_OUTPUT_ENABLE: *type =3D SCMI_PIN_OUTPUT_MODE; break; @@ -276,6 +273,28 @@ static int pinctrl_scmi_map_pinconf_type(enum pin_conf= ig_param param, return 0; } =20 +static int pinctrl_scmi_map_pinconf_type_get(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + if (param =3D=3D PIN_CONFIG_LEVEL) { + *type =3D SCMI_PIN_INPUT_VALUE; + return 0; + } + + return pinctrl_scmi_map_pinconf_type(param, type); +} + +static int pinctrl_scmi_map_pinconf_type_set(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + if (param =3D=3D PIN_CONFIG_LEVEL) { + *type =3D SCMI_PIN_OUTPUT_VALUE; + return 0; + } + + return pinctrl_scmi_map_pinconf_type(param, type); +} + static int pinctrl_scmi_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin, unsigned long *config) { @@ -290,7 +309,7 @@ static int pinctrl_scmi_pinconf_get(struct pinctrl_dev = *pctldev, =20 config_type =3D pinconf_to_config_param(*config); =20 - ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + ret =3D pinctrl_scmi_map_pinconf_type_get(config_type, &type); if (ret) return ret; =20 @@ -363,7 +382,7 @@ static int pinctrl_scmi_pinconf_set(struct pinctrl_dev = *pctldev, =20 for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); - ret =3D pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[i]); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); goto free_config; @@ -405,7 +424,7 @@ static int pinctrl_scmi_pinconf_group_set(struct pinctr= l_dev *pctldev, =20 for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); - ret =3D pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[i]); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); goto free_config; @@ -440,7 +459,7 @@ static int pinctrl_scmi_pinconf_group_get(struct pinctr= l_dev *pctldev, return -EINVAL; =20 config_type =3D pinconf_to_config_param(*config); - ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + ret =3D pinctrl_scmi_map_pinconf_type_get(config_type, &type); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); return ret; --=20 2.53.0