From nobody Tue Apr 7 21:25:30 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 246472FE58F for ; Wed, 11 Mar 2026 19:38:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773257904; cv=none; b=sh+QfIGkiZyQl7ao+xdlqA1GKmNmEjMikm2Yb4geoVltzaVYVXVUnMcHyW5Wo1SmH78oebg1tZlMDT8PL0NB0EhOycvfxOPMh+x9HkPw+HW0iPViCSmtPwUQZWaQyuP58nn14KtQduhnH4XkoixhiJNB1X8/sXvwluLQoSvKbVQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773257904; c=relaxed/simple; bh=jNLbaa/EdHOV24YnPDzn3wt5qXtVOjsJPr+S7zUA+TI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kFyKMiDTIjHwySH6Hic4kZ0PMZJ256wJqzeUdd1PuJeEcuxLO5qQt0KeaOk2jusYCQjhgTtnhjzGtEzqfR22I7fHshjWHmlTfb3FzV/zxtH2L+saA8iVBGc4bhcC4P6rPg+Mv/yzBKFegVWlhftZkEPAnQQyWzADpFlaFBHJtx4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eAg4UdIA; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eAg4UdIA" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4853f2826f7so1851205e9.1 for ; Wed, 11 Mar 2026 12:38:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773257900; x=1773862700; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O5jKa1mhx8JE7wb9TTu7vy92JT5A3X2bElgi3jOUD4I=; b=eAg4UdIAJa9z/d11Pa7zVO9wdlPLstLSppd3cFqP7WDW7msRVgPXciDvGoEKv6TDaV qNRf+wO1CpbLrIZO91W74RQ1BvUqFiCK7duPMkNn7EYfvQrEC1ZL24e/fhm37tUuetsd KpkioWSKSFpPrI4KRlUI5L6CnPSdEpRGtGFiztIdrjnUw/+KqI88E4MLBjNAGnLrV9Rt /tQXkvYx+NVo4mD4IoltOP06AVkJlclrs/H/1ph270oSyi+AGBzcXa/hfV8q57UKrySV LXRUNg+sipW14TJs36v3DiSyAj94hT7MHUbQeYUdRWa0VZb1Os9LSX0nwVqQ4O0nzgGt 9ZqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773257900; x=1773862700; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O5jKa1mhx8JE7wb9TTu7vy92JT5A3X2bElgi3jOUD4I=; b=SCbBeT75hnTbQl+8u93DjyySxKNre2/XatUzyyfMcG1zE9YReB8ERQo8n9agxJjM59 LW3RMYIVdPaxBe6H4ARSDmwXFwHdOKElryI/+9FPFjBsqj06DOZfslqFZOWj7jP++XQR MlMbx9QOmAcBroqxTrlvxJso0uX6kdMpdLVll9WWQTZm2anIOob3kZQq923/yANu9Ui5 neCGQld5Vyn72SWdQODoCxgGyUCuAexabtZaQpBIX/i1rcANbbazqT9zpGIbK2+BnkEv Fo2vWIC+59imO1eQx4BCBqXO8ib56FMS14gsTQ5R1PurLs25YbcveD9bZyA+NjQllSSD iIvg== X-Forwarded-Encrypted: i=1; AJvYcCXc3XWtLvTIlTWb2EArcqDsenb2YEhAe1+aN7SkSuEe8GDhRVjJJfPxrwHWFE+sAtD9ucsunb6m44U1N+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YweZtpsck+PhZub3cjR0Acu50HnZqeJf/+2aPAHWQOVa8EYH8S3 yGTa1vZL+NAwsCafttz87WirKOq22YfaA8d5iHNuR5T+3wizPQrTJ2E7/Fc4JMd/00i28CsRahK B4dyk X-Gm-Gg: ATEYQzzivXxMjV2p7iSiD4LeTPyXd5jNOCbz7fYhvFNkvEhnb7HjZNao6oJMGkn3vDN TS0EZCgYnnLRSR11gv9U6JWeq0+B3D9s9512Lt6mfYjdUBB1W+74IGaMwO0wLE8Q0W0tLFDLpyI poFIKoyqLFxnvFB6R/w97h1O1SECHn9DH8gESTeSp1VepQn0cLNTeEsHm7/nLH1/kIMR01rB3l9 0bD2ktDZ+0Hr17TFyezEPk9EO+OoyX2lmlPdUNW4haefCQOHi02lTyCS8J2DAD8i6hTmvN0DQq8 CnlMBb7S6ieRinTZqnuORuIp70yLXFPD9MJV9D+gsb9Y5XVJDWNsl17VrcRyyM0ozGUutywTHcs COlYK1d9u+Uzs7SA943j7yvMQLo6EL3QZsRFHJ/pvMudCD5rGftfrqtzDajjA6arPQcXcMoZHRB QGNJ2zbM6OkzL/d+BUwfDwIHP3pKZR X-Received: by 2002:a05:600c:608c:b0:485:34b3:8589 with SMTP id 5b1f17b1804b1-4854b136ae3mr63730725e9.31.1773257900308; Wed, 11 Mar 2026 12:38:20 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe2187aasm1506034f8f.30.2026.03.11.12.38.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 12:38:19 -0700 (PDT) Date: Wed, 11 Mar 2026 22:38:16 +0300 From: Dan Carpenter To: Sudeep Holla , AKASHI Takahiro Cc: Cristian Marussi , Linus Walleij , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Bartosz Golaszewski Subject: [PATCH v3 2/7] pinctrl: scmi: Add SCMI_PIN_INPUT_VALUE Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The PIN_CONFIG_LEVEL parameter represents the value of the pin, whether reading or writing to the pin. In SCMI, the parameter is represented by two different values SCMI_PIN_OUTPUT_VALUE for writing to a pin and SCMI_PIN_INPUT_VALUE for reading. The current code translates PIN_CONFIG_LEVEL as SCMI_PIN_OUTPUT_VALUE (writing). Add a function to translate it to either INPUT or OUTPUT depending on whether it is called from a _get or _set() operation. Signed-off-by: Dan Carpenter Acked-by: Sudeep Holla Reviewed-by: Linus Walleij --- drivers/pinctrl/pinctrl-scmi.c | 33 ++++++++++++++++++++++++++------- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c index f4f296e07be5..5d347e6b2e4c 100644 --- a/drivers/pinctrl/pinctrl-scmi.c +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -251,9 +251,6 @@ static int pinctrl_scmi_map_pinconf_type(enum pin_confi= g_param param, case PIN_CONFIG_MODE_LOW_POWER: *type =3D SCMI_PIN_LOW_POWER_MODE; break; - case PIN_CONFIG_LEVEL: - *type =3D SCMI_PIN_OUTPUT_VALUE; - break; case PIN_CONFIG_OUTPUT_ENABLE: *type =3D SCMI_PIN_OUTPUT_MODE; break; @@ -276,6 +273,28 @@ static int pinctrl_scmi_map_pinconf_type(enum pin_conf= ig_param param, return 0; } =20 +static int pinctrl_scmi_map_pinconf_type_get(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + if (param =3D=3D PIN_CONFIG_LEVEL) { + *type =3D SCMI_PIN_INPUT_VALUE; + return 0; + } + + return pinctrl_scmi_map_pinconf_type(param, type); +} + +static int pinctrl_scmi_map_pinconf_type_set(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + if (param =3D=3D PIN_CONFIG_LEVEL) { + *type =3D SCMI_PIN_OUTPUT_VALUE; + return 0; + } + + return pinctrl_scmi_map_pinconf_type(param, type); +} + static int pinctrl_scmi_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin, unsigned long *config) { @@ -290,7 +309,7 @@ static int pinctrl_scmi_pinconf_get(struct pinctrl_dev = *pctldev, =20 config_type =3D pinconf_to_config_param(*config); =20 - ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + ret =3D pinctrl_scmi_map_pinconf_type_get(config_type, &type); if (ret) return ret; =20 @@ -363,7 +382,7 @@ static int pinctrl_scmi_pinconf_set(struct pinctrl_dev = *pctldev, =20 for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); - ret =3D pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[i]); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); goto free_config; @@ -405,7 +424,7 @@ static int pinctrl_scmi_pinconf_group_set(struct pinctr= l_dev *pctldev, =20 for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); - ret =3D pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[i]); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); goto free_config; @@ -440,7 +459,7 @@ static int pinctrl_scmi_pinconf_group_get(struct pinctr= l_dev *pctldev, return -EINVAL; =20 config_type =3D pinconf_to_config_param(*config); - ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + ret =3D pinctrl_scmi_map_pinconf_type_get(config_type, &type); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); return ret; --=20 2.51.0