From nobody Thu Oct 2 02:05:48 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 057CE252900 for ; Tue, 23 Sep 2025 21:47:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758664081; cv=none; b=T0OL0erL/98aJPHSKEthdjehnjKuQ/1no2e+AbD8sRIeGe2IGgAs8u3ENZbgFrA4yf/fC/BkCdoJ4wMHvWikHa96L4i+fFOc3bX2HSZ6ASp3/azEInnaNXJotW49uIkX11mSeM4kYY4nZ8a9I1QLQo7FHTbmb+ha2byj9hQkNYU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758664081; c=relaxed/simple; bh=ueTXvYOaTGFnlsHbGUKhUluBx5Uj1EtJeF74+R0Vgys=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Ls6H74a2S2iQu4SPNR+1KynobQcZLOm+4LU7bilS9kRTd0/qyWXiUYi2qrENHQqsL+rdAFTcysbGfoSiOXtYWoBcl39idBXz+DHhh/b8tc1IxQQHXJaOO5guntr2SjhP/Y9ehhwo1Ebdgw8bUJa45YTWidstleh86bcUiGRLvKg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ATrY/tpm; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ATrY/tpm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758664078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=gE1p9jvRg0lKTpk9XpwlgaFgqtSuJtcDtsDSqLMg4mo=; b=ATrY/tpm6rFJ55hsbZsuP7MWrDIKs6uzwmNjzAh41YItDjwItOTTNx8zqbF5iNtUN1fqnd 5doIpvG/U+jFBheT3VkG9jLOtASL5fx6GDuufMLzQ7SCqk2wi4JbKto/RJKJcBkggNOkgK wzZYTvxQG3iCfqkF3O3H5bXAkiw+cWA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-454-MIr2Qxj5O3arFcyHoabWdQ-1; Tue, 23 Sep 2025 17:47:57 -0400 X-MC-Unique: MIr2Qxj5O3arFcyHoabWdQ-1 X-Mimecast-MFC-AGG-ID: MIr2Qxj5O3arFcyHoabWdQ_1758664076 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3ee888281c3so3071237f8f.3 for ; Tue, 23 Sep 2025 14:47:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758664076; x=1759268876; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gE1p9jvRg0lKTpk9XpwlgaFgqtSuJtcDtsDSqLMg4mo=; b=t8CtcCNCz4P5dmYwJSnJVpjP5Y4jdhAbQrBJYdl+Uo5aCi8nfDK4Fd/IMZyzOviF3Y jesMMZeCDg6C7A+W31Co/hoRhcbs0wuxCJtQ6zEStWpDg3Mv3z6MniSdaXHT/yMO+W9i OXaR/jwxnNVlVTlsgqXoic5tJC4imRzCx8iSb5qJfNOird0m9/IlChKM4UL+GmjDHzQC nBNPvlZTKdweMD0aH/5ItTQMb+LvzZaoifRLLF6yJOi25Mg0tK3ucDEXsSf2tafe9CCw vJY6eKxQ2EcpmQ5uQoWBtNHj3XfY9xKGgZruBBnmR5dw0Nm4YiryQ8rms8XBdI3QyF52 hsjQ== X-Gm-Message-State: AOJu0YxpZ5b2Tt6vsrJendq5qT7+/3+tMsO29yjdUEogNnQ//EiXhiY1 Y8Jn7C9sxytGZlOf7or3Qe0+/2CVyaqTp7fZCl3nZ9tg8Eqg2EoFPSNxWOd04bBhXNgpXCI+8ve QUMGmojeTHEg32l2CLpw6F0sRJBjXA4YMSC6EfNUdrYABwTGiDLAfx4QSD7G4Cr/yxEAkVn239G ygQyyxDdv6zVHsdWF7zDSXa6kw0eO0BwtMOd0fuJO3sF8= X-Gm-Gg: ASbGncsiFVM3NdKvoPq7DvUPTDP7qZewdxRhjgx6N7fvoR5dmH+hHNOIKw95VS84t7w BRsg0Pee7ImVHadbA8LUPOVOBZbZ0EQQH0ES2XGmU+OIR8F5b8OEzLJI9x+i36fAdcbImF3rvP4 6Cj3uULxFr+K7IKd5DlNKplXVF7djuqMtGg323zqJ7BdVjB1De6rTn37cYbouYoAOGf6BY1qiNN iE02PzPIoEp8oDsEsZ7XfT6FMRRNvNogAtkB+A7uPBe/gDxWv/AGYboDFffKe6+GBIvn3z5tQlq B1bvdhTTdc1G5qFTw4wbH4syzY2/tdj3LmM= X-Received: by 2002:a05:6000:1885:b0:3cd:ef83:a9a1 with SMTP id ffacd0b85a97d-405c6751cabmr3721726f8f.20.1758664075858; Tue, 23 Sep 2025 14:47:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETV4Q7KUf/fsmOmIwTE27eO2P2KhRHj2pOb3/FmZCSUNeq3z+t0xn78V0pxCEhXhxYrElaFg== X-Received: by 2002:a05:6000:1885:b0:3cd:ef83:a9a1 with SMTP id ffacd0b85a97d-405c6751cabmr3721711f8f.20.1758664075279; Tue, 23 Sep 2025 14:47:55 -0700 (PDT) Received: from redhat.com ([2a06:c701:73ea:f900:52ee:df2b:4811:77e0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3f61703b206sm15270816f8f.6.2025.09.23.14.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 14:47:54 -0700 (PDT) Date: Tue, 23 Sep 2025 17:47:53 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: zhang jiao , Jason Wang , Eugenio =?utf-8?B?UMOpcmV6?= , kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org Subject: [PATCH] vhost: vringh: Fix copy_to_iter return value check Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The return value of copy_to_iter can't be negative, check whether the copied length is equal to the requested length instead of checking for negative values. Cc: zhang jiao Link: https://lore.kernel.org/all/20250910091739.2999-1-zhangjiao2@cmss.chi= namobile.com Signed-off-by: Michael S. Tsirkin Acked-by: Jason Wang Tested-by: Lei Yang --- Lightly tested. zhang jiao could you pls also test, either ack or fold into your patch? drivers/vhost/vringh.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c index 0c8a17cbb22e..925858cc6096 100644 --- a/drivers/vhost/vringh.c +++ b/drivers/vhost/vringh.c @@ -1162,6 +1162,7 @@ static inline int copy_to_iotlb(const struct vringh *= vrh, void *dst, struct iov_iter iter; u64 translated; int ret; + size_t size; =20 ret =3D iotlb_translate(vrh, (u64)(uintptr_t)dst, len - total_translated, &translated, @@ -1179,9 +1180,9 @@ static inline int copy_to_iotlb(const struct vringh *= vrh, void *dst, translated); } =20 - ret =3D copy_to_iter(src, translated, &iter); - if (ret < 0) - return ret; + size =3D copy_to_iter(src, translated, &iter); + if (size !=3D translated) + return -EFAULT; =20 src +=3D translated; dst +=3D translated; --=20 MST