From nobody Thu Feb 12 23:05:24 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAB651BEF84 for ; Fri, 3 Jan 2025 07:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735887911; cv=none; b=bGwwHSOIeWYySfbrIM+mVrSHOzh3F2qF3p4VPmY0jgAC4dV/5dXJJkb5kAAD9hWIzdK5p5iyA5PAKKVsdrLwT9HwqDAqBJ5kUOfU2KexCTKfAJzm3/+Z+ttQ2R78OYOlV0wBYwEJpY+l6ybTTFStC4VwvNrv38G6qovu/OFKWGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735887911; c=relaxed/simple; bh=WBoTA7749kvARatnW/bMXAHQeWrnZl9r0XW4s5VJKe4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=cYX0riY7tIDAksawRgqvrUk1AlLeIKUMCxY0YsBt+Csc1EszmqCmKaoq4+p5ejFv1byWO4zSjYtwh1N3su/9bA5430Lr8Lr5NVAzCbZkwkJ40JurL5Pjei18OaCM/QjHiP69A5q5hh1BTQbrOGq1uJ6Wm+tF+hM0UUa3N9ymTSo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 0a865faec9a111efa216b1d71e6e1362-20250103 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CTE_8B, HR_CTT_MISS HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_DIGIT_LEN, HR_FROM_NAME HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS UD_TRUSTED, CIE_BAD, CIE_GOOD_SPF, GTI_FG_BS, GTI_C_CI GTI_FG_IT, GTI_RG_INFO, GTI_C_BU, AMN_T1, AMN_GOOD AMN_C_TI, AMN_C_BU X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.41,REQID:5f9a3d6a-64dd-4210-b7e9-a469b8ddd7dc,IP:0,U RL:0,TC:0,Content:-25,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-30 X-CID-INFO: VERSION:1.1.41,REQID:5f9a3d6a-64dd-4210-b7e9-a469b8ddd7dc,IP:0,URL :0,TC:0,Content:-25,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-30 X-CID-META: VersionHash:6dc6a47,CLOUDID:9d66e899d98ff0d1340f3d054793c144,BulkI D:250103150500FRZZXSRL,BulkQuantity:0,Recheck:0,SF:17|19|38|66|78|102,TC:n il,Content:0|50,EDM:-3,IP:nil,URL:1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:ni l,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_ULS,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-UUID: 0a865faec9a111efa216b1d71e6e1362-20250103 X-User: xiaopei01@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 48703414; Fri, 03 Jan 2025 15:04:57 +0800 From: Pei Xiao To: linux-rockchip@lists.infradead.org, cassel@kernel.org, linux-kernel@vger.kernel.org Cc: Pei Xiao , kernel test robot Subject: [PATCH] PCI: dw-rockchip: remove redundant dev_err Date: Fri, 3 Jan 2025 15:04:52 +0800 Message-Id: X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dev_err is redundant because platform_get_irq_byname() already prints an error. cocci warnings: drivers/pci/controller/dwc/pcie-dw-rockchip.c:454:2-9:line 454 is redundant because platform_get_irq() already prints an error so remove redundant dev_err. Fixes: 8719dbc54668 ("PCI: dw-rockchip: Enumerate endpoints based on dll_li= nk_up irq in the combined sys irq") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202412312343.najrW1Db-lkp@int= el.com/ Signed-off-by: Pei Xiao Reviewed-by: Niklas Cassel --- drivers/pci/controller/dwc/pcie-dw-rockchip.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/co= ntroller/dwc/pcie-dw-rockchip.c index ce4b511bff9b..a9795866e915 100644 --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c @@ -458,10 +458,8 @@ static int rockchip_pcie_configure_rc(struct platform_= device *pdev, return -ENODEV; =20 irq =3D platform_get_irq_byname(pdev, "sys"); - if (irq < 0) { - dev_err(dev, "missing sys IRQ resource\n"); + if (irq < 0) return irq; - } =20 ret =3D devm_request_threaded_irq(dev, irq, NULL, rockchip_pcie_rc_sys_irq_thread, @@ -504,10 +502,8 @@ static int rockchip_pcie_configure_ep(struct platform_= device *pdev, return -ENODEV; =20 irq =3D platform_get_irq_byname(pdev, "sys"); - if (irq < 0) { - dev_err(dev, "missing sys IRQ resource\n"); + if (irq < 0) return irq; - } =20 ret =3D devm_request_threaded_irq(dev, irq, NULL, rockchip_pcie_ep_sys_irq_thread, --=20 2.25.1