From nobody Sat Feb 7 16:06:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D67FEB64D9 for ; Tue, 11 Jul 2023 02:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbjGKCqH (ORCPT ); Mon, 10 Jul 2023 22:46:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjGKCqF (ORCPT ); Mon, 10 Jul 2023 22:46:05 -0400 Received: from mail.208.org (unknown [183.242.55.162]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6740D188 for ; Mon, 10 Jul 2023 19:46:02 -0700 (PDT) Received: from mail.208.org (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTP id 4R0QGt2L7BzBHXkP for ; Tue, 11 Jul 2023 10:45:58 +0800 (CST) Authentication-Results: mail.208.org (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=208.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=208.org; h= content-transfer-encoding:content-type:message-id:user-agent :references:in-reply-to:subject:to:from:date:mime-version; s= dkim; t=1689043558; x=1691635559; bh=yMCbkMYiTyHC8803omIwa+cF847 f+Xrhh1yZkyU7z/8=; b=o86gB03IoDt9VawXYng14a/StUEWudAL3zo+6d9xiYP B8D9se2Nr7rFzLc++MViJlPz2DVjYiW21SJ9+KCugoWbBs7iTm2MMbYshZe6uPv6 /cqTexnDOb9zTtJvfwp0vuF6RvhodvCmItUynCYeDI21yFBosiYIGrTuql7sMB58 4PmiaN4i+fXE5rnBulekExwxdguH3Nf/hjhglEQPkZg/XX63SDO1+HNl8E8Vq/mw 3A27ilU4OAzK7s9XSb67LjrShnBRvV5VKSMroTXrfSg2U/ZCceL6ahU6TkMnkSCD yyXqf/vOlSbMhFgJ12lFFgiKc1BoaoX9PLcJDyf0kqg== X-Virus-Scanned: amavisd-new at mail.208.org Received: from mail.208.org ([127.0.0.1]) by mail.208.org (mail.208.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id YCFy2nwXfar2 for ; Tue, 11 Jul 2023 10:45:58 +0800 (CST) Received: from localhost (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTPSA id 4R0QGs6Z1XzBHXhc; Tue, 11 Jul 2023 10:45:57 +0800 (CST) MIME-Version: 1.0 Date: Tue, 11 Jul 2023 10:45:57 +0800 From: sunran001@208suo.com To: airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/nouveau/devinit: Move assignment outside if condition In-Reply-To: <20230711024429.78508-1-xujianghui@cdjrlc.com> References: <20230711024429.78508-1-xujianghui@cdjrlc.com> User-Agent: Roundcube Webmail Message-ID: X-Sender: sunran001@208suo.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8"; format="flowed" Fixes the following checkpatch errors: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c=20 b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c index 1410befd2285..8185e10efc49 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c @@ -61,7 +61,8 @@ nv05_devinit_meminit(struct nvkm_devinit *init) } strap =3D (nvkm_rd32(device, 0x101000) & 0x0000003c) >> 2; - if ((data =3D bmp_mem_init_table(bios))) { + data =3D bmp_mem_init_table(bios); + if (data) { ramcfg[0] =3D nvbios_rd08(bios, data + 2 * strap + 0); ramcfg[1] =3D nvbios_rd08(bios, data + 2 * strap + 1); } else {