From nobody Sun Feb 8 12:31:46 2026 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FE917DA7B for ; Thu, 15 Aug 2024 11:25:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723721124; cv=none; b=CZkyIV67FGm9hMKVxYzBj0WOi4GZ7Os2sV6xSxt0y1ZaPoShLB2qmTSS/yOb+E4I/MOnYg9M7CrzByJC6zLLlg2dcxiISsDOys96ZA0tYfV/5dPRpjASB2vPHYocm3S9MufEtpwopKpb6UoI3UakVWDdVb1jvNKIDb4/0xn5TYE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723721124; c=relaxed/simple; bh=9r69U4+Vlyv0XEbqFBAdBfxH7OVJ2VXkioo1Q5babH8=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=uiXupWC6upljJtwcb0z32qsDItbDmGPZqkvurUozpywHpTLORfOiXOIY5E843RGCfyT3k8D0OUE4K0UbjsuBXAGqEqZe7OyGvi5elHf+XYezB8ghep78GbvK3WSbxu5Sx5xsGqLP/PvoP0dnSmkFcEDI/wrLBChWvFRUjxh9eCg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nqnjnnJf; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nqnjnnJf" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a7a8caef11fso110881366b.0 for ; Thu, 15 Aug 2024 04:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723721121; x=1724325921; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=qswmFLJc+rRJnvMK5o1RhUuE0PL9fCewlpe2LTSF+JQ=; b=nqnjnnJf1rHF/uJZn/spsnW74eBXGyx7YH9gvunkPJUwrsWFb+eglQrIXF6ACVucY3 WAxYb7UHO4uJUFMaiASIx4AonUjmgQdA5yDOjm0jTaHl5iFc5yw9HWNWbqTkkkSr2BUz LZHStdI41ipF4c1OHTL/G1dodqC/u1TwmQHbvREf3piAWFUcJ2M4j3ycWvpiKRw4QXSm 5SkwevxcA+yGdpbrB7w1pNUKQ3aalop59RXyBRwAODkeNb60eOhm7cQ9pHYTWLLdCypl Ugd4zSSmDpqFRUjlByl6zkpJRpj2/2GUrxKj5rhCNi5lKSNSSFLCRfCfaDDe3Urjc+Cj yQtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723721121; x=1724325921; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qswmFLJc+rRJnvMK5o1RhUuE0PL9fCewlpe2LTSF+JQ=; b=KGF0nFQ6d0r9XZO4UnpPDnmauSCEafevvb3v7OOxwSF/Y5vzbgFEFtfIfYKpC6kWOL jw7K9jGbdIZ9nOPl1IGYUF4sqqq+Gd9wlgeFFWwKoxsCK4D69b1ePF2cvVDzN3vXoWi8 9OREeihLBDT/C9698Bm4zUUmyCDaoSAqt09yNzpSYpBIR6mq7ibALLxxmGzRJGKZGn0M /Bxr4RuuLii+LhHDyv6raag0QGZO6Q3I0xFTnz/2sT2WIdJA3BqmXq5R2rutK46sedRi mitZrDkiA2/lwb5/tiBp3PRleddevGYW/jL/eZb4Wad7UNbonr4qFlRVSd+l/Eq/9IRq UHvg== X-Forwarded-Encrypted: i=1; AJvYcCWo4Oq0rPbV2au338fl+RgwtJm6B/1QJUJzhcHZEaxyH6aOc6F2tNjRyUxkZsKM9Zvgth6lDoLHo1yNI3X813ZjObBnaYlRb2/6QrB1 X-Gm-Message-State: AOJu0YweVT79j0ljXjp823j8A6QimFcW3q7wMQY/GGCIiyPFR3uNkW9U r1Wu8UGAtbCVZ4igSRzdjosfJHk5OCahIap+5HzAOzgiQigvXTgs+XjUAB0II6A= X-Google-Smtp-Source: AGHT+IE04IYzhOFDEe/StHeMv+I9KreAuEIMLJabn0MgWVsiJJeJsCqyh9XE5pP5z25EACFGgtwnLA== X-Received: by 2002:a17:907:f1d4:b0:a77:e1fb:7de9 with SMTP id a640c23a62f3a-a8366c0f0e2mr501782366b.5.1723721120636; Thu, 15 Aug 2024 04:25:20 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a838396ce0asm85941166b.206.2024.08.15.04.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2024 04:25:20 -0700 (PDT) Date: Thu, 15 Aug 2024 14:25:08 +0300 From: Dan Carpenter To: Richard Zhu Cc: Damien Le Moal , Niklas Cassel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , linux-ide@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] ata: ahci_imx: Fix error code in probe() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return a negative error code if devm_clk_get() fails. Don't return success. Fixes: 3156e1b2c071 ("ata: ahci_imx: AHB clock rate setting is not required= on i.MX8QM AHCI SATA") Signed-off-by: Dan Carpenter --- drivers/ata/ahci_imx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c index 65f98e8fdf07..6f955e9105e8 100644 --- a/drivers/ata/ahci_imx.c +++ b/drivers/ata/ahci_imx.c @@ -963,6 +963,7 @@ static int imx_ahci_probe(struct platform_device *pdev) imxpriv->ahb_clk =3D devm_clk_get(dev, "ahb"); if (IS_ERR(imxpriv->ahb_clk)) { dev_err(dev, "Failed to get ahb clock\n"); + ret =3D PTR_ERR(imxpriv->ahb_clk); goto disable_sata; } reg_val =3D clk_get_rate(imxpriv->ahb_clk) / 1000; --=20 2.43.0