From nobody Wed Apr 8 01:35:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A3FEC433FE for ; Thu, 20 Oct 2022 18:30:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229519AbiJTSaL (ORCPT ); Thu, 20 Oct 2022 14:30:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbiJTS3t (ORCPT ); Thu, 20 Oct 2022 14:29:49 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D484541502 for ; Thu, 20 Oct 2022 11:29:47 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id g1so821337lfu.12 for ; Thu, 20 Oct 2022 11:29:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H7IxJfQYGufvahI+8q4Dz6LMvBxctykZ1GGtydHvATw=; b=H7967F9S03AMlK7QJoC47R/2WJIfJoAexwxCmi3WndYfREI0b41xaKhbDKoUG9C464 I5Ws0NmJPdUV+IxMoASL68O2dORKinmBKaHwlu0tmD6GgvyUWNiKJcKTuKiUM3jgjnr5 F9VG1sJK7TyT/l5m0XaQrsA3StWc5d4hufaviC2FE8DcXiSZSVPXutt1O9JiMByz0rTG 7TdH56bdoQuLev5ANjGjhekLaO5CdSbpo3C0r/iCSDkgATSV0ognzKMhsZgvxpqkQX33 yEyAXCjPtlEZUu44Q0uP+dzrKsQuceq0QdG8G3PKmu9Q5LiPOoNxrUBXHh9XgcgOJ8ru Vx8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H7IxJfQYGufvahI+8q4Dz6LMvBxctykZ1GGtydHvATw=; b=GRY3C276KaSYj7zL/JBC0BUTjGRJnCnehIe+6YTewjHqPXsLELom30TLATVLwP/5Rq wn6eZ6NUQSU9EmF/jcBLQy/Q9XhN4r1wkSCgo1S8lbgk2GMuHJGDUetzEgyBB5HWNe0f tEfwGIzDx8lXicv2xEQe68MLdsyDN23hRbF3sLIcBnAlSiCa6a+3b4IijUrXG/WPher7 zw80CAGe3ELBZFiN+4lDdq9OUzDrRkQt0UaNTA0F8G4iJ4xrVxqZ2jJlroAg5P0Yj4/N oGHr2J82Bh44orYm7iMW0q89iVO+izOyl+6baH6Mwkbdj2zKYl/j60AK/RoFm3X/xvgt XaxA== X-Gm-Message-State: ACrzQf0jqXjWXlY2yhxm+0qI88ISOsHX/UFptCHoiI3Rqjm7cp2leDx1 mWoG1R+EfB6/THN4/s9nwmHBjYtjXbUxGZZp X-Google-Smtp-Source: AMsMyM7kJye3P2KI77EljgQUEw0IotfVBUMK0CBpL5EPAtdjGIvxOHJogv1N4zTIidIbDVlARN+7/Q== X-Received: by 2002:a19:a406:0:b0:4a5:feb1:af0d with SMTP id q6-20020a19a406000000b004a5feb1af0dmr3208221lfc.401.1666290586194; Thu, 20 Oct 2022 11:29:46 -0700 (PDT) Received: from elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net ([20.240.130.248]) by smtp.googlemail.com with ESMTPSA id h10-20020a0565123c8a00b00497a3e11608sm2797216lfv.303.2022.10.20.11.29.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 11:29:45 -0700 (PDT) From: Tanjuate Brunostar To: forest@alittletooquiet.net Cc: greg@kroah.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Tanjuate Brunostar Subject: [PATCH 5/6] staging: vt6655: refactor long lines of code in the rest of the file Date: Thu, 20 Oct 2022 18:27:45 +0000 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" fix checkpatch errors by refactoring long lines of code in the rest of the file Signed-off-by: Tanjuate Brunostar --- drivers/staging/vt6655/rxtx.c | 105 ++++++++++++++++++++++------------ 1 file changed, 67 insertions(+), 38 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 42f4261293ba..b8b21cd39534 100644 --- a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c @@ -1106,44 +1106,60 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsi= gned char byPktType, if (byFBOption =3D=3D AUTO_FB_NONE) { if (bRTS) {/* RTS_need */ pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + size= of(struct vnt_rrv_time_rts)); - pvRTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rr= v_time_rts) + cbMICHDR); + pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_rts)); + pvRTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); pvCTS =3D NULL; - pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct v= nt_rrv_time_rts) + - cbMICHDR + sizeof(struct vnt_rts_g)); - cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_rts) + - cbMICHDR + sizeof(struct vnt_rts_g) + - sizeof(struct vnt_tx_datahead_g); + pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_rts) + + cbMICHDR + sizeof(struct vnt_rts_g)); + cbHeaderLength =3D + wTxBufSize + sizeof(struct vnt_rrv_time_rts) + + cbMICHDR + sizeof(struct vnt_rts_g) + + sizeof(struct vnt_tx_datahead_g); } else { /* RTS_needless */ pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + size= of(struct vnt_rrv_time_cts)); + pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_cts)); pvRTS =3D NULL; - pvCTS =3D (void *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_r= rv_time_cts) + cbMICHDR); + pvCTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_cts) + cbMICHDR); pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + - sizeof(struct vnt_rrv_time_cts) + cbMICHDR + sizeof(struct vnt_cts)); + sizeof(struct vnt_rrv_time_cts) + + cbMICHDR + sizeof(struct vnt_cts)); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_cts) + - cbMICHDR + sizeof(struct vnt_cts) + sizeof(struct vnt_tx_datahead_g= ); + cbMICHDR + sizeof(struct vnt_cts) + + sizeof(struct vnt_tx_datahead_g); } } else { /* Auto Fall Back */ if (bRTS) {/* RTS_need */ pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + size= of(struct vnt_rrv_time_rts)); - pvRTS =3D (void *) (pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_r= rv_time_rts) + cbMICHDR); + pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_rts)); + pvRTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_rts) + cbMICHDR); pvCTS =3D NULL; - pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct v= nt_rrv_time_rts) + + pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_rts) + cbMICHDR + sizeof(struct vnt_rts_g_fb)); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_rts) + - cbMICHDR + sizeof(struct vnt_rts_g_fb) + sizeof(struct vnt_tx_datahea= d_g_fb); + cbMICHDR + sizeof(struct vnt_rts_g_fb) + + sizeof(struct vnt_tx_datahead_g_fb); } else { /* RTS_needless */ pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + size= of(struct vnt_rrv_time_cts)); + pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_cts)); pvRTS =3D NULL; - pvCTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rr= v_time_cts) + cbMICHDR); - pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct = vnt_rrv_time_cts) + - cbMICHDR + sizeof(struct vnt_cts_fb)); + pvCTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_cts) + cbMICHDR); + pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_cts) + + cbMICHDR + sizeof(struct vnt_cts_fb)); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_cts) + - cbMICHDR + sizeof(struct vnt_cts_fb) + sizeof(struct vnt_tx_datahead_= g_fb); + cbMICHDR + sizeof(struct vnt_cts_fb) + + sizeof(struct vnt_tx_datahead_g_fb); } } /* Auto Fall Back */ } else {/* 802.11a/b packet */ @@ -1151,19 +1167,25 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsi= gned char byPktType, if (byFBOption =3D=3D AUTO_FB_NONE) { if (bRTS) { pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + size= of(struct vnt_rrv_time_ab)); - pvRTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rr= v_time_ab) + cbMICHDR); + pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_ab)); + pvRTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); pvCTS =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + - sizeof(struct vnt_rrv_time_ab) + cbMICHDR + sizeof(struct vnt_rts_ab)= ); + sizeof(struct vnt_rrv_time_ab) + cbMICHDR + + sizeof(struct vnt_rts_ab)); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_ab) + - cbMICHDR + sizeof(struct vnt_rts_ab) + sizeof(struct vnt_tx_datahead_= ab); + cbMICHDR + sizeof(struct vnt_rts_ab) + + sizeof(struct vnt_tx_datahead_ab); } else { /* RTS_needless, need MICHDR */ pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + size= of(struct vnt_rrv_time_ab)); + pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_ab)); pvRTS =3D NULL; pvCTS =3D NULL; - pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct v= nt_rrv_time_ab) + cbMICHDR); + pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR + sizeof(struct vnt_tx_datahead_ab); } @@ -1171,19 +1193,25 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsi= gned char byPktType, /* Auto Fall Back */ if (bRTS) { /* RTS_need */ pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + size= of(struct vnt_rrv_time_ab)); - pvRTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct vnt_rr= v_time_ab) + cbMICHDR); + pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_ab)); + pvRTS =3D (void *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); pvCTS =3D NULL; pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + - sizeof(struct vnt_rrv_time_ab) + cbMICHDR + sizeof(struct vnt_rts_a_f= b)); + sizeof(struct vnt_rrv_time_ab) + cbMICHDR + + sizeof(struct vnt_rts_a_fb)); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_ab) + - cbMICHDR + sizeof(struct vnt_rts_a_fb) + sizeof(struct vnt_tx_datahea= d_a_fb); + cbMICHDR + sizeof(struct vnt_rts_a_fb) + + sizeof(struct vnt_tx_datahead_a_fb); } else { /* RTS_needless */ pvRrvTime =3D (void *)(pbyTxBufferAddr + wTxBufSize); - pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + size= of(struct vnt_rrv_time_ab)); + pMICHDR =3D (struct vnt_mic_hdr *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_ab)); pvRTS =3D NULL; pvCTS =3D NULL; - pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + sizeof(struct v= nt_rrv_time_ab) + cbMICHDR); + pvTxDataHd =3D (void *)(pbyTxBufferAddr + wTxBufSize + + sizeof(struct vnt_rrv_time_ab) + cbMICHDR); cbHeaderLength =3D wTxBufSize + sizeof(struct vnt_rrv_time_ab) + cbMICHDR + sizeof(struct vnt_tx_datahead_a_fb); } @@ -1198,8 +1226,9 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsign= ed char byPktType, s_vGenerateTxParameter(pDevice, byPktType, tx_buffer_head, pvRrvTime, pvR= TS, pvCTS, cbFrameSize, bNeedACK, uDMAIdx, hdr, pDevice->wCurrentRate); /* Fill DataHead */ - uDuration =3D s_uFillDataHead(pDevice, byPktType, pvTxDataHd, cbFrameSize= , uDMAIdx, bNeedACK, - 0, 0, uMACfragNum, byFBOption, pDevice->wCurrentRate, is_pspoll); + uDuration =3D s_uFillDataHead(pDevice, byPktType, pvTxDataHd, cbFrameSize, + uDMAIdx, bNeedACK, 0, 0, uMACfragNum, byFBOption, + pDevice->wCurrentRate, is_pspoll); =20 hdr->duration_id =3D uDuration; =20 @@ -1447,8 +1476,8 @@ static int vnt_beacon_xmit(struct vnt_private *priv, /* Get Duration and TimeStampOff */ short_head->duration =3D cpu_to_le16((u16)s_uGetDataDuration(priv, DATADUR_B, - frame_size, PK_TYPE_11A, current_rate, - false, 0, 0, 1, AUTO_FB_NONE)); + frame_size, PK_TYPE_11A, current_rate, + false, 0, 0, 1, AUTO_FB_NONE)); =20 short_head->time_stamp_off =3D vnt_time_stamp_off(priv, current_rate); @@ -1463,8 +1492,8 @@ static int vnt_beacon_xmit(struct vnt_private *priv, /* Get Duration and TimeStampOff */ short_head->duration =3D cpu_to_le16((u16)s_uGetDataDuration(priv, DATADUR_B, - frame_size, PK_TYPE_11B, current_rate, - false, 0, 0, 1, AUTO_FB_NONE)); + frame_size, PK_TYPE_11B, current_rate, + false, 0, 0, 1, AUTO_FB_NONE)); =20 short_head->time_stamp_off =3D vnt_time_stamp_off(priv, current_rate); --=20 2.34.1