From nobody Wed Feb 11 05:42:07 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43B530CD80; Tue, 10 Feb 2026 16:36:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770741389; cv=none; b=jj/tiCT6fDoyKzVN2lgS5tS80D4LC+dJioROal56CovQPIUCMJotLxL+ljjAOoxWyYm8LrmM+W7nlHOP3aPtyXX4qWJOD163aoHle1xsOLWBt2+FGrlpso/cbJ0CfyKYqI7sa5WuFGfsQif2Atu3nCJU8BClX54kKA2s2q3xFRU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770741389; c=relaxed/simple; bh=3ef+JIZyk1BCpaoxZjYIa2McjH4xu833l3yMdDsAq/Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PYw/VbayyGMeSm9SFl0kfho2B27yVCJfMTkZSj3z9ezQ3MWN8Pg3D26m0+yIgkSjJyl5Uc6dcZGIopdAG8AQcftYjUZlLLD/FqhEGjC4t5eKOJuZJAb9GhJULaRxHKWq2c8bQ18+x9QldWKhTmuZhEfF7OZGn/6HNDpcAu31e80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ld8iDx7d; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ld8iDx7d" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770741388; x=1802277388; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3ef+JIZyk1BCpaoxZjYIa2McjH4xu833l3yMdDsAq/Y=; b=ld8iDx7do3zfDvJlXVC8j987GDK0vSOpML18L8QCBcwlk+iLmk5tOKTC gl6BumWL6hxu1+IV/17r8E55aHgZojrnYUAYFDyQ0jxFO6UgK+oNDdDEV semuY4rMtvQSFLn8guFUISEkhAGW47Fg82nNz9aTWtqmRzpxJUGRpQqON 72gfhflKzSa9Z/UpucaNEpl3HQZDJLVK4QV9aHfq1L7xd/TdO1xGkuFxA 4MNspO6xLVKdbSRk7OVHAzl2USPgoCHewqs8YhPaLUIkq9LC1MmY/GmXi PIMF5FOc7/NsFw0hlUazwk6buur43xSmByyQjk/7NF9628Vmkr1cdEmue A==; X-CSE-ConnectionGUID: 5xDPU6fBT8aP15AJve4qIA== X-CSE-MsgGUID: Dsb1LQQPS3Osg5wsKIa/ew== X-IronPort-AV: E=McAfee;i="6800,10657,11697"; a="74476822" X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="74476822" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2026 08:36:27 -0800 X-CSE-ConnectionGUID: YMCSJ/bjSEeqsKMHZ8nHqg== X-CSE-MsgGUID: cavmhqYVSBW8yQyiAUPhgQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,283,1763452800"; d="scan'208";a="212003454" Received: from rchatre-desk1.jf.intel.com ([10.165.154.99]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2026 08:36:26 -0800 From: Reinette Chatre To: shuah@kernel.org, Dave.Martin@arm.com, james.morse@arm.com, tony.luck@intel.com, peternewman@google.com, babu.moger@amd.com, ilpo.jarvinen@linux.intel.com Cc: zide.chen@intel.com, dapeng1.mi@linux.intel.com, fenghuay@nvidia.com, reinette.chatre@intel.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev Subject: [PATCH 1/8] selftests/resctrl: Do not store iMC counter value in counter config structure Date: Tue, 10 Feb 2026 08:50:40 -0800 Message-ID: X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The MBM and MBA tests compare MBM memory bandwidth measurements against the memory bandwidth event values obtained from each memory controller's PMU. The memory bandwidth event settings are discovered from the memory controller details found in /sys/bus/event_source/devices/uncore_imc_N and stored in struct imc_counter_config. In addition to event settings struct imc_counter_config contains imc_counter_config::return_value in which the associated event value is stored on every read. The event value is consumed and immediately recorded at regular intervals. The stored value is never consumed afterwards, making its storage as part of event configuration unnecessary. Remove the return_value member from struct imc_counter_config. Instead just use a local variable for use during event reading. Signed-off-by: Reinette Chatre --- tools/testing/selftests/resctrl/resctrl_val.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/resctrl/resctrl_val.c b/tools/testing/= selftests/resctrl/resctrl_val.c index a5a8badb83d4..2cc22f61a1f8 100644 --- a/tools/testing/selftests/resctrl/resctrl_val.c +++ b/tools/testing/selftests/resctrl/resctrl_val.c @@ -32,7 +32,6 @@ struct imc_counter_config { __u64 event; __u64 umask; struct perf_event_attr pe; - struct membw_read_format return_value; int fd; }; =20 @@ -312,23 +311,23 @@ static int get_read_mem_bw_imc(float *bw_imc) * Take overflow into consideration before calculating total bandwidth. */ for (imc =3D 0; imc < imcs; imc++) { + struct membw_read_format return_value; struct imc_counter_config *r =3D &imc_counters_config[imc]; =20 - if (read(r->fd, &r->return_value, - sizeof(struct membw_read_format)) =3D=3D -1) { + if (read(r->fd, &return_value, sizeof(return_value)) =3D=3D -1) { ksft_perror("Couldn't get read bandwidth through iMC"); return -1; } =20 - __u64 r_time_enabled =3D r->return_value.time_enabled; - __u64 r_time_running =3D r->return_value.time_running; + __u64 r_time_enabled =3D return_value.time_enabled; + __u64 r_time_running =3D return_value.time_running; =20 if (r_time_enabled !=3D r_time_running) of_mul_read =3D (float)r_time_enabled / (float)r_time_running; =20 - reads +=3D r->return_value.value * of_mul_read * SCALE; + reads +=3D return_value.value * of_mul_read * SCALE; } =20 *bw_imc =3D reads; --=20 2.50.1