From nobody Wed Dec 17 20:42:19 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31E1F207A02 for ; Fri, 14 Mar 2025 19:29:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741980571; cv=none; b=EIJeap3f/F4s6lr0pN2cM6wXHifJIxvxKuQjrpriv5lSWnpRmc/hhxMX2AH5qpjrrFNhrIAAsilWchdrM8OgRGazR3mQbg6to1QtVXPizf99xeqm0wm6P4OqndKDOgMa+UY3Y9HSG9OKkHULBdrSKquzdtvSkTGH1jw5TnFKaP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741980571; c=relaxed/simple; bh=+NCq00Wy+1YJBoI8XRnsTBTKxGLAtQEKm5X7Ld5eVHs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eJUEf0QcHsdcvobt/yoXzVUxY/H4S2MStCMcwYkOTUHGnNUeJf1LVHLUx3c+txDgvYxocNHpfyl75CIINBV+4Kjw3Age8ZdcqEODdcy7yo8D04EBJwWPyJAXFlZhXn5pRKJc9FRZ4L0oiI3XMtcKaSs0BGBTXocHkBbcJc58ZUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J91zde2B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J91zde2B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D02AAC4CEEE; Fri, 14 Mar 2025 19:29:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741980571; bh=+NCq00Wy+1YJBoI8XRnsTBTKxGLAtQEKm5X7Ld5eVHs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J91zde2BBPnL+pJPtNfs0OzE+ts38HR2LixL2bFq9vML0VFsF3juMh9cuMLlCyXN2 +xz0RNNuq28au5/RWJb06Id3J1jubDWS6WroGOWIDZn2mYdrDjEhZoop0w/h+dd/1w 37D+612v3SFvZURb2g7soQL4r+3BVGiRK2Prvht2wh4p3Rp+svWHXtds/AqMsxSGD3 7DyNiRla5FiowRj3xn9RL8zUv1Bq+zeR+/RAY9ZI+BM7dEUvM3++tRo0G0tKE0oq39 77FP/nXkQdLTHc5pkUblXn61JkjVRgnOY6saMLkEq9bj9VFzAgVHD3As+zilF8xEzT KBftWbQF0QbTA== From: Josh Poimboeuf To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Brendan Jackman , Nathan Chancellor Subject: [PATCH 06/13] objtool: Remove --unret dependency on --rethunk Date: Fri, 14 Mar 2025 12:29:04 -0700 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" With unret validation enabled and IBT/LTO disabled, objtool runs on TUs with --rethunk and on vmlinux.o with --unret. So this dependency isn't valid as they don't always run on the same object. This error never triggered before because --unret is always coupled with --noinstr, so the first conditional in opts_valid() returns early due to opts.noinstr being true. Signed-off-by: Josh Poimboeuf --- tools/objtool/builtin-check.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tools/objtool/builtin-check.c b/tools/objtool/builtin-check.c index 387d56a7f5fb..c7275cf7641b 100644 --- a/tools/objtool/builtin-check.c +++ b/tools/objtool/builtin-check.c @@ -151,11 +151,6 @@ static bool opts_valid(void) return true; } =20 - if (opts.unret && !opts.rethunk) { - ERROR("--unret requires --rethunk"); - return false; - } - if (opts.dump_orc) return true; =20 --=20 2.48.1