From nobody Thu Dec 18 20:17:51 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 743F8EE14AA for ; Sat, 9 Sep 2023 18:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239023AbjIISUZ (ORCPT ); Sat, 9 Sep 2023 14:20:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239009AbjIISUU (ORCPT ); Sat, 9 Sep 2023 14:20:20 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D6F210F3 for ; Sat, 9 Sep 2023 11:19:51 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3fe4f3b5f25so8896865e9.0 for ; Sat, 09 Sep 2023 11:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694283590; x=1694888390; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GpwmshN/SnkxoMv0hgadPL0UXh7rR+Fy3DtPmnciQb0=; b=VPa5MSphjh++SdAtit7iu3Awzeqd/iCCJHCeF0aanPN2vJJ571CXfF2YjBgKtJrZIj uvMaZwguc5dE3WO6hptDKJOo/rpXsrmNFRUbkTSgdwQnEmYLYb+VssNumtfOIdGUFSTN gpqjDAkVZ+V7YzdZFp6z54zya8cYM5vm3C+8GNzdLVLXOoVH9nDhiH3GvSxZ62fJRufs rYK7GQJWZ/5Bq0PPCLBlUlmJuctEPMbnHyuMrKNjAYfhmNaTn96CBzPko5ylbmYtsLNa lBUBTtHMWzA1VjftzDpjHA2fA8KQmgi+x13nOaVa2uQP968cn2t+1AVKvhXmQI2oSwlW WF0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694283590; x=1694888390; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GpwmshN/SnkxoMv0hgadPL0UXh7rR+Fy3DtPmnciQb0=; b=YDSw6kIcEWHMd7HPVmH+dprPxRXrTNFKeRxaQ8nxA38UF3nSpZ/7Nu5eoxaVdUU9Ye B2qk35+OimQfncBBMPq99wzND2gC12WlDGNo1hQNCw0ZCfq0uUQ1Z6RucmssgEP+k6Er 4AHUPB6NgvsnDLcTitP12b7EhlVabr2IvslwIG+vDWquqdtMPJ5jp2rjfrt4OuAjq6bt Qngo7VFr9Z0zE/fcRnvXdRlO2N3JFcU/g5xo5GaRWlIfMvMX8mf7zt1WpQBypCG9w/bN BJiVIMqSd2CctnPJ+O/ORx6qFFphfr4x6lDXZmE8KagaN/UK/RVao6fYOktagE3CPLsO U9ug== X-Gm-Message-State: AOJu0YzJvCivLSZ8jGns5B4jsFJ8OI8kyYE85rDj6WoDuJFhu7jZCHty LdYMtgWhXMlN2BKXKTjZ2Fk= X-Google-Smtp-Source: AGHT+IHLt3smwCNceCgJThJzA35FlMq7WPqfvXc8OO+RfHKvxUVXmcgCPYlMvVJBJCWColdkWAkbzQ== X-Received: by 2002:a05:600c:1d0a:b0:401:c6a2:3cd5 with SMTP id l10-20020a05600c1d0a00b00401c6a23cd5mr4916064wms.2.1694283589687; Sat, 09 Sep 2023 11:19:49 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p579356c7.dip0.t-ipconnect.de. [87.147.86.199]) by smtp.gmail.com with ESMTPSA id l10-20020a1c790a000000b003fed70fb09dsm5232607wme.26.2023.09.09.11.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Sep 2023 11:19:49 -0700 (PDT) Date: Sat, 9 Sep 2023 20:19:47 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 4/8] staging: rtl8192e: Use standard function in rtllib_rx_check_duplicate() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use standard function ieee80211_is_beacon() to avoid proprietary code and to increase readability. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_rx.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 89c8d66765fe..80eee43ee444 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -904,11 +904,8 @@ static int rtllib_rx_check_duplicate(struct rtllib_dev= ice *ieee, { struct rtllib_hdr_4addr *hdr =3D (struct rtllib_hdr_4addr *)skb->data; u16 fc, sc; - u8 frag, type, stype; + u8 frag; =20 - fc =3D le16_to_cpu(hdr->frame_ctl); - type =3D WLAN_FC_GET_TYPE(fc); - stype =3D WLAN_FC_GET_STYPE(fc); sc =3D le16_to_cpu(hdr->seq_ctl); frag =3D WLAN_GET_SEQ_FRAG(sc); =20 @@ -916,8 +913,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_devi= ce *ieee, !ieee->current_network.qos_data.active || !IsDataFrame(skb->data) || IsLegacyDataFrame(skb->data)) { - if (!((type =3D=3D RTLLIB_FTYPE_MGMT) && - (stype =3D=3D RTLLIB_STYPE_BEACON))) { + if (!ieee80211_is_beacon(hdr->frame_ctl)) { if (is_duplicate_packet(ieee, hdr)) return -1; } --=20 2.41.0