From nobody Thu Dec 18 14:29:40 2025 Received: from mail.universe-factory.net (osgiliath.universe-factory.net [141.95.161.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E71F070810; Tue, 8 Apr 2025 16:01:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=141.95.161.142 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744128074; cv=none; b=GxeeVh5kgnksEOYKiupMROlpacmJFFiUeRdnUrGF/QBOHT3zU6lb8W93I4sxj4+EV1cQHDOgJeDHe7ZUtqPL1vBws20Eb+p2s9YTR/gVGe8IamS4m2Iz0QA8Ke+5u30ugt2LscGL1wh/8SATh5FEm9IbbaPEbuowRiHqse/iBWg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744128074; c=relaxed/simple; bh=AGxAgyVrVRh+SYfrJt/CAVOzkf/RxSxQTPG6Xnsz5ro=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=k3BX0mEuaZuJzJPUWGmRfXXbgm0o/YG0/bsghJ4GNl99JNbvgb/QNEhATkR0UunyKCTfeRvOaAjH3tQ8e6mIvVS/STe8Jv7LDgy6vpa6OXC0Zn/4guTO4HyAuFEeqnWikskZV4hSZIbx2gSvzo5G/MHrZsCCCCfle5Pj2Ba+PPw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=universe-factory.net; spf=pass smtp.mailfrom=universe-factory.net; dkim=pass (2048-bit key) header.d=universe-factory.net header.i=@universe-factory.net header.b=XtdI8usb; arc=none smtp.client-ip=141.95.161.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=universe-factory.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=universe-factory.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=universe-factory.net header.i=@universe-factory.net header.b="XtdI8usb" From: Matthias Schiffer DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=universe-factory.net; s=dkim; t=1744127659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=OHKKJGQMaL8g2OEp8XjLpUph+kOsUS2Z1oSy6oV7E8M=; b=XtdI8usbHZnsiMYM/CuWz+HhhoMcnD7SUR5y6FaCvqjcXjLBeoFej06tEvVnDqWJ4kNGWe /zqBNWDxyAccMn2Lr1YpqTyoUYt6P9Ge2eNbQEKSG8uLTf7BjZ3VYGIFHVJ7YRTr6BzZZ8 +nmlF43ygqk4t4dUSynNLy8LekNx/S5eWKWdnH4S7PYJl7JJ4gnMuTgFhxM/2QyFgBZSSv z3gUIHmliWGMkUdDnpvKNKRhqlmqx/liBezQEHtf+rYLwocXlfwPQN8h9/D3znJNBtbf+S t15V41d86qPHcLzFFyO06Jcyy3GY6lORzauxc4+Q9hr1t9q8+dkh5dqUVjRDFA== Authentication-Results: mail.universe-factory.net; auth=pass smtp.mailfrom=mschiffer@universe-factory.net To: Marek Lindner , Simon Wunderlich , Antonio Quartulli , Sven Eckelmann Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Schiffer Subject: [PATCH net-next] net: batman-adv: constify and move broadcast addr definition Date: Tue, 8 Apr 2025 17:53:36 +0200 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: - Content-Type: text/plain; charset="utf-8" The variable is used only once and is read-only. Make it a const local variable. Signed-off-by: Matthias Schiffer --- net/batman-adv/main.c | 2 -- net/batman-adv/main.h | 1 - net/batman-adv/send.c | 4 +++- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c index a08132888a3d..e41f816f0887 100644 --- a/net/batman-adv/main.c +++ b/net/batman-adv/main.c @@ -69,8 +69,6 @@ unsigned int batadv_hardif_generation; static int (*batadv_rx_handler[256])(struct sk_buff *skb, struct batadv_hard_iface *recv_if); =20 -unsigned char batadv_broadcast_addr[] =3D {0xff, 0xff, 0xff, 0xff, 0xff, 0= xff}; - struct workqueue_struct *batadv_event_workqueue; =20 static void batadv_recv_handler_init(void); diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index 67af435ee04e..bfe90a888af4 100644 --- a/net/batman-adv/main.h +++ b/net/batman-adv/main.h @@ -235,7 +235,6 @@ static inline int batadv_print_vid(unsigned short vid) extern struct list_head batadv_hardif_list; extern unsigned int batadv_hardif_generation; =20 -extern unsigned char batadv_broadcast_addr[]; extern struct workqueue_struct *batadv_event_workqueue; =20 int batadv_mesh_init(struct net_device *mesh_iface); diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c index 735ac8077821..90356b622a48 100644 --- a/net/batman-adv/send.c +++ b/net/batman-adv/send.c @@ -124,7 +124,9 @@ int batadv_send_skb_packet(struct sk_buff *skb, int batadv_send_broadcast_skb(struct sk_buff *skb, struct batadv_hard_iface *hard_iface) { - return batadv_send_skb_packet(skb, hard_iface, batadv_broadcast_addr); + const u8 broadcast_addr[] =3D {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; + + return batadv_send_skb_packet(skb, hard_iface, broadcast_addr); } =20 /** --=20 2.49.0