From nobody Sun Feb 8 14:31:27 2026 Received: from fhigh-b5-smtp.messagingengine.com (fhigh-b5-smtp.messagingengine.com [202.12.124.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF7E42F39A4; Mon, 20 Oct 2025 22:36:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.156 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760999780; cv=none; b=uHSUVSEgARs9SzYSn+KktUFrFhb+6puT4w0ttlqCyods4xcC/u6bGJBbqwBdyGyjq6wiDq+5ATj1seSvfq40dWzjSxlstrp1p5F68QaP7D0fL65nwUjEJszrPZXM1qqUfZlZlH1gsWW56TkfU23ao8hs4+SSw6DZaPVL66xOzyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760999780; c=relaxed/simple; bh=Ds40lvVQ8ct4/JMQM6+DhsSpkMtda2d+9Lt4Ht9DnyM=; h=To:Cc:Message-ID:In-Reply-To:References:From:Subject:Date; b=YwvtfJJGL5eiNUECS2fmW8MX5DO1/IfPk1W3InpZT08B2LIG0u9R5qD/1rGQVRU5adH4Ivdwy35kF3YJ0Bs0eg16+5OlJSqryjRP1LuXF5nB2VjovgcqEyoaIkPlAuXKGPlgYav9G2fduym7tzeTtONCaIiDhNDWtRx0UzQlUzg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=none smtp.mailfrom=linux-m68k.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=bjxMXWw6; arc=none smtp.client-ip=202.12.124.156 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="bjxMXWw6" Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id B6DC57A0133; Mon, 20 Oct 2025 18:36:16 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Mon, 20 Oct 2025 18:36:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1760999776; x= 1761086176; bh=sCEkbZKrl8bKnVzNmi1Kw704fMBYVAIdlc+QSCIPujs=; b=b jxMXWw6NFgPgWlWIleVc5chc/9HyOBYg4QfUexgH7mW9G7DwDFLUs6WoHP7R8Dtr vZ1mpPHNEO32cKKWTGz5KkSxj44VP8A6DpSnDmkPiKfj1Grh3g09d7BRvr6Osl1J lMNhboHYycxPoMbgkR62/+qKldWsgONUhK23vIp40NmiInBmAQ3os+OKu0S/ZIjX OZ0y+ebfoFVEJ3GZNVg4s6YEVxGyX+UYwOu8WAiJVRQT+SBayG3j8VlW918OCzQ9 O2KB2EHehfsoBCiQBzNmqFTn6prHdQrPOVziONsj1xuvjC0fFbLRspfC576OYlOD RiZHjWcrhJpSw2GuHEedw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddufeeltdegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepvfevkfgjfhfhufffsedttdertddttddtnecuhfhrohhmpefhihhnnhcuvfhhrghi nhcuoehfthhhrghinheslhhinhhugidqmheikehkrdhorhhgqeenucggtffrrghtthgvrh hnpeevgffgtdfhhfefveeuudfgtdeugfeftedtveekieeggfduleetgeegueehgeffffen ucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehfthhhrg hinheslhhinhhugidqmheikehkrdhorhhgpdhnsggprhgtphhtthhopedufedpmhhouggv pehsmhhtphhouhhtpdhrtghpthhtohepphgvthgvrhiisehinhhfrhgruggvrggurdhorh hgpdhrtghpthhtohepfihilhhlsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehjrghm vghsrdgsohhtthhomhhlvgihsehhrghnshgvnhhprghrthhnvghrshhhihhprdgtohhmpd hrtghpthhtohepuggvlhhlvghrsehgmhigrdguvgdprhgtphhtthhopegrkhhpmheslhhi nhhugidqfhhouhhnuggrthhiohhnrdhorhhgpdhrtghpthhtoheprghrnhgusegrrhhnug gsrdguvgdprhgtphhtthhopegsohhquhhnrdhfvghnghesghhmrghilhdrtghomhdprhgt phhtthhopehgvggvrhhtsehlihhnuhigqdhmieekkhdrohhrghdprhgtphhtthhopehlih hnuhigqdgrrhgthhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i58a146ae:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Oct 2025 18:36:13 -0400 (EDT) To: Peter Zijlstra , Will Deacon , "James E.J. Bottomley" , Helge Deller Cc: Andrew Morton , Arnd Bergmann , Boqun Feng , Geert Uytterhoeven , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org, Mark Rutland , linux-parisc@vger.kernel.org Message-ID: In-Reply-To: References: From: Finn Thain Subject: [RFC v4 2/5] parisc: Drop linux/kernel.h include from asm/bug.h header Date: Tue, 21 Oct 2025 09:28:04 +1100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch series will add WARN_ON_ONCE() calls to the header file linux/instrumented.h. That requires including linux/bug.h, but doing so causes the following compiler error on parisc: In file included from ./include/linux/atomic/atomic-instrumented.h:17, from ./include/linux/atomic.h:82, from ./arch/parisc/include/asm/bitops.h:13, from ./include/linux/bitops.h:67, from ./include/linux/kernel.h:23, from ./arch/parisc/include/asm/bug.h:5, from ./include/linux/bug.h:5, from ./include/linux/page-flags.h:10, from kernel/bounds.c:10: ./include/linux/instrumented.h: In function 'instrument_atomic_alignment_ch= eck': ./include/linux/instrumented.h:69:9: error: implicit declaration of functio= n 'WARN_ON_ONCE' [-Werror=3Dimplicit-function-declaration] 69 | WARN_ON_ONCE((unsigned long)v & (size - 1)); | ^~~~~~~~~~~~ cc1: some warnings being treated as errors make[3]: *** [scripts/Makefile.build:182: kernel/bounds.s] Error 1 The problem is, asm/bug.h indirectly includes atomic-instrumented.h, which means a new cycle appeared in the graph of #includes. And because some headers in the cycle can't see all definitions, WARN_ON_ONCE() appears to be an undeclared function. This only happens on parisc and it's easy to fix. In the error message above, linux/kernel.h is included by asm/bug.h. But it's no longer needed there, so remove it. The comment about needing BUGFLAG_TAINT seems to be incorrect as of commit 19d436268dde ("debug: Add _ONCE() logic to report_bug()"). Also, a comment in linux/kernel.h strongly discourages its use here. Compile-tested only. Acked-by: Helge Deller # parisc --- arch/parisc/include/asm/bug.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/parisc/include/asm/bug.h b/arch/parisc/include/asm/bug.h index 833555f74ffa..dbf65623c513 100644 --- a/arch/parisc/include/asm/bug.h +++ b/arch/parisc/include/asm/bug.h @@ -2,8 +2,6 @@ #ifndef _PARISC_BUG_H #define _PARISC_BUG_H =20 -#include /* for BUGFLAG_TAINT */ - /* * Tell the user there is some problem. * The offending file and line are encoded in the __bug_table section. --=20 2.49.1