From nobody Thu Nov 14 07:07:51 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A1FC53210 for ; Tue, 3 Jan 2023 07:01:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236890AbjACHBA (ORCPT ); Tue, 3 Jan 2023 02:01:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236878AbjACHAw (ORCPT ); Tue, 3 Jan 2023 02:00:52 -0500 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43051B78; Mon, 2 Jan 2023 23:00:50 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id ge16so28374325pjb.5; Mon, 02 Jan 2023 23:00:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q3YCncKGxSIefGdnjUXlLzFdqiLRBnN+g1pS8Gtkdlo=; b=Y8dIfW5mHs77/lcxmB12HpuRKnTUiAhYl66l0cwy4Mbr8ac39/AyLtJp96xVInmggM GeelrxfPKlSR8/cYGdrFxMpbfAQE4YGm9l6rN6mfYQjdtsihbMpS15gB+tUbDdr7LK2K /jfqc125li+h+4x3oyJIE7JEk8XFEpxLXje09dpHryvEf8Q4FzLJPcCg9Z7PEdIMYtgT h9rmZspcpQbaXcrjv5lsRO0VcTPGrC3s3g1JKnQdz4lE1/8xzwimE2VRydBYLxJoPY76 N5Zzx+ny55EQeiWkY2eGDaYISnCCTYBn8CoCMvWjsTtTaMqIiY+3/krm53hQqwxMoK7F Kl0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q3YCncKGxSIefGdnjUXlLzFdqiLRBnN+g1pS8Gtkdlo=; b=TSnSPS1ws7N5FwFx958lwXpWDKEho2e99sCtfpOxIK6OBz6ahgXkeWHZMIe+SEMjJ+ WjsaKkl0JYPrOE+8uB2iOYAFDBckCzyA93PXKhbMmd3xAtzZKSryBrKnAr6g8cRzupu9 vV3uSjEuyV/jYvAh6Y8BQ+tOB2Jq+WeF1Q4dCYSUmkX2z4o0Slly+yOdf0kySqHS6KJX g8N7UGiovfaNqJPDHPiaHDXVtDabH1Qb6KpSQxXgX+Kb0Pwi5KJzbqHr3jlPjUYRN1nb hz1pd+UxChwarsjqs4ZRMPY4FsH9rwrRXIaIiCFb4N5ZpQflhRtukqlE7ej80+l9R9/V uGtg== X-Gm-Message-State: AFqh2kqaQlIKUAnR6jPCs8ovHgwN+WLATJRotc4nT4JY/o/E/8UZz5u0 rTDNVhxhZd7MM7oOPpbHlSU= X-Google-Smtp-Source: AMrXdXtABMPVAODxU0ELDXgl3fggGPYdVDSrn7QcEH3i3wqLfXKM8+hR18bmeqJAsqutVvSkftibCA== X-Received: by 2002:a17:902:854b:b0:192:903c:3726 with SMTP id d11-20020a170902854b00b00192903c3726mr23118048plo.28.1672729249626; Mon, 02 Jan 2023 23:00:49 -0800 (PST) Received: from RD-3580-24288.rt.l (42-73-255-34.emome-ip.hinet.net. [42.73.255.34]) by smtp.gmail.com with ESMTPSA id jj13-20020a170903048d00b00192aecb231asm7769648plb.121.2023.01.02.23.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 23:00:49 -0800 (PST) From: ChiaEn Wu To: pavel@ucw.cz, lee@kernel.org, matthias.bgg@gmail.com, andriy.shevchenko@linux.intel.com Cc: chiaen_wu@richtek.com, cy_huang@richtek.com, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, szunichen@gmail.com, Alice Chen , AngeloGioacchino Del Regno Subject: [PATCH v15 RESEND 2/2] leds: flash: mt6370: Add MediaTek MT6370 flashlight support Date: Tue, 3 Jan 2023 15:00:09 +0800 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Alice Chen The MediaTek MT6370 is a highly-integrated smart power management IC, which includes a single cell Li-Ion/Li-Polymer switching battery charger, a USB Type-C & Power Delivery (PD) controller, dual Flash LED current sources, a RGB LED driver, a backlight WLED driver, a display bias driver and a general LDO for portable devices. Add support for the MT6370 Flash LED driver. Flash LED in MT6370 has 2 channels and support torch/strobe mode. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Alice Chen Signed-off-by: ChiaEn Wu --- drivers/leds/flash/Kconfig | 13 + drivers/leds/flash/Makefile | 1 + drivers/leds/flash/leds-mt6370-flash.c | 631 +++++++++++++++++++++++++ 3 files changed, 645 insertions(+) create mode 100644 drivers/leds/flash/leds-mt6370-flash.c diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig index d3eb689b193c..49d8922b1117 100644 --- a/drivers/leds/flash/Kconfig +++ b/drivers/leds/flash/Kconfig @@ -61,6 +61,19 @@ config LEDS_MT6360 Independent current sources supply for each flash LED support torch and strobe mode. =20 +config LEDS_MT6370_FLASH + tristate "Flash LED Support for MediaTek MT6370 PMIC" + depends on LEDS_CLASS + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS + depends on MFD_MT6370 + help + Support 2 channels and torch/strobe mode. + Say Y here to enable support for + MT6370_FLASH_LED device. + + This driver can also be built as a module. If so, the module + will be called "leds-mt6370-flash". + config LEDS_RT4505 tristate "LED support for RT4505 flashlight controller" depends on I2C && OF diff --git a/drivers/leds/flash/Makefile b/drivers/leds/flash/Makefile index 0acbddc0b91b..0c1f3c5ffe41 100644 --- a/drivers/leds/flash/Makefile +++ b/drivers/leds/flash/Makefile @@ -9,3 +9,4 @@ obj-$(CONFIG_LEDS_MAX77693) +=3D leds-max77693.o obj-$(CONFIG_LEDS_RT4505) +=3D leds-rt4505.o obj-$(CONFIG_LEDS_RT8515) +=3D leds-rt8515.o obj-$(CONFIG_LEDS_SGM3140) +=3D leds-sgm3140.o +obj-$(CONFIG_LEDS_MT6370_FLASH) +=3D leds-mt6370-flash.o diff --git a/drivers/leds/flash/leds-mt6370-flash.c b/drivers/leds/flash/le= ds-mt6370-flash.c new file mode 100644 index 000000000000..bd4bfb9b5a86 --- /dev/null +++ b/drivers/leds/flash/leds-mt6370-flash.c @@ -0,0 +1,631 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (C) 2022 Richtek Technology Corp. + * + * Author: Alice Chen + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +enum { + MT6370_LED_FLASH1, + MT6370_LED_FLASH2, + MT6370_MAX_LEDS +}; + +/* Virtual definition for multicolor */ + +#define MT6370_REG_FLEDEN 0x17E +#define MT6370_REG_STRBTO 0x173 +#define MT6370_REG_CHGSTAT2 0x1D1 +#define MT6370_REG_FLEDSTAT1 0x1D9 +#define MT6370_REG_FLEDISTRB(_id) (0x174 + 4 * (_id)) +#define MT6370_REG_FLEDITOR(_id) (0x175 + 4 * (_id)) +#define MT6370_ITORCH_MASK GENMASK(4, 0) +#define MT6370_ISTROBE_MASK GENMASK(6, 0) +#define MT6370_STRBTO_MASK GENMASK(6, 0) +#define MT6370_TORCHEN_MASK BIT(3) +#define MT6370_STROBEN_MASK BIT(2) +#define MT6370_FLCSEN_MASK(_id) BIT(MT6370_LED_FLASH2 - (_id)) +#define MT6370_FLCSEN_MASK_ALL GENMASK(1, 0) +#define MT6370_FLEDCHGVINOVP_MASK BIT(3) +#define MT6370_FLED1STRBTO_MASK BIT(11) +#define MT6370_FLED2STRBTO_MASK BIT(10) +#define MT6370_FLED1STRB_MASK BIT(9) +#define MT6370_FLED2STRB_MASK BIT(8) +#define MT6370_FLED1SHORT_MASK BIT(7) +#define MT6370_FLED2SHORT_MASK BIT(6) +#define MT6370_FLEDLVF_MASK BIT(3) + +#define MT6370_LED_JOINT 2 +#define MT6370_RANGE_FLED_REG 4 +#define MT6370_ITORCH_MIN_uA 25000 +#define MT6370_ITORCH_STEP_uA 12500 +#define MT6370_ITORCH_MAX_uA 400000 +#define MT6370_ITORCH_DOUBLE_MAX_uA 800000 +#define MT6370_ISTRB_MIN_uA 50000 +#define MT6370_ISTRB_STEP_uA 12500 +#define MT6370_ISTRB_MAX_uA 1500000 +#define MT6370_ISTRB_DOUBLE_MAX_uA 3000000 +#define MT6370_STRBTO_MIN_US 64000 +#define MT6370_STRBTO_STEP_US 32000 +#define MT6370_STRBTO_MAX_US 2432000 + +#define STATE_OFF 0 +#define STATE_KEEP 1 +#define STATE_ON 2 + +#define to_mt6370_led(ptr, member) container_of(ptr, struct mt6370_led, me= mber) + +struct mt6370_led { + struct led_classdev_flash flash; + struct v4l2_flash *v4l2_flash; + struct mt6370_priv *priv; + enum led_default_state default_state; + u8 led_no; +}; + +struct mt6370_priv { + struct device *dev; + struct regmap *regmap; + struct mutex lock; + unsigned int fled_strobe_used; + unsigned int fled_torch_used; + unsigned int leds_active; + unsigned int leds_count; + struct mt6370_led leds[]; +}; + +static int mt6370_torch_brightness_set(struct led_classdev *lcdev, + enum led_brightness level) +{ + struct mt6370_led *led =3D to_mt6370_led(lcdev, flash.led_cdev); + struct mt6370_priv *priv =3D led->priv; + u32 led_enable_mask =3D (led->led_no =3D=3D MT6370_LED_JOINT) ? + MT6370_FLCSEN_MASK_ALL : + MT6370_FLCSEN_MASK(led->led_no); + u32 enable_mask =3D MT6370_TORCHEN_MASK | led_enable_mask; + u32 val =3D level ? led_enable_mask : 0; + u32 curr; + int ret, i; + + mutex_lock(&priv->lock); + + /* + * There is only one set of flash control logic, and this + * flag is used to check if 'strobe' is currently being used. + */ + if (priv->fled_strobe_used) { + dev_warn(lcdev->dev, "Please disable strobe first [%d]\n", + priv->fled_strobe_used); + ret =3D -EBUSY; + goto unlock; + } + + if (level) + curr =3D priv->fled_torch_used | BIT(led->led_no); + else + curr =3D priv->fled_torch_used & ~BIT(led->led_no); + + if (curr) + val |=3D MT6370_TORCHEN_MASK; + + if (level) { + level -=3D 1; + if (led->led_no =3D=3D MT6370_LED_JOINT) { + u32 flevel[MT6370_MAX_LEDS]; + + flevel[0] =3D level / 2; + flevel[1] =3D level - flevel[0]; + for (i =3D 0; i < MT6370_MAX_LEDS; i++) { + ret =3D regmap_update_bits(priv->regmap, + MT6370_REG_FLEDITOR(i), + MT6370_ITORCH_MASK, flevel[i]); + if (ret) + goto unlock; + } + } else { + ret =3D regmap_update_bits(priv->regmap, + MT6370_REG_FLEDITOR(led->led_no), + MT6370_ITORCH_MASK, level); + if (ret) + goto unlock; + } + } + + ret =3D regmap_update_bits(priv->regmap, MT6370_REG_FLEDEN, + enable_mask, val); + if (ret) + goto unlock; + + priv->fled_torch_used =3D curr; + +unlock: + mutex_unlock(&priv->lock); + return ret; +} + +static int mt6370_flash_brightness_set(struct led_classdev_flash *fl_cdev, + u32 brightness) +{ + /* + * Because of the current spikes when turning on the flash, + * the brightness should be kept by the LED framework. This + * empty function is used to prevent checking failure when + * led_classdev_flash registers ops. + */ + return 0; +} + +static int _mt6370_flash_brightness_set(struct led_classdev_flash *fl_cdev, + u32 brightness) +{ + struct mt6370_led *led =3D to_mt6370_led(fl_cdev, flash); + struct mt6370_priv *priv =3D led->priv; + struct led_flash_setting *setting =3D &fl_cdev->brightness; + u32 val =3D (brightness - setting->min) / setting->step; + int ret, i; + + if (led->led_no =3D=3D MT6370_LED_JOINT) { + u32 flevel[MT6370_MAX_LEDS]; + + flevel[0] =3D val / 2; + flevel[1] =3D val - flevel[0]; + for (i =3D 0; i < MT6370_MAX_LEDS; i++) { + ret =3D regmap_update_bits(priv->regmap, + MT6370_REG_FLEDISTRB(i), + MT6370_ISTROBE_MASK, flevel[i]); + if (ret) + break; + } + + return ret; + } else { + return regmap_update_bits(priv->regmap, + MT6370_REG_FLEDISTRB(led->led_no), + MT6370_ISTROBE_MASK, val); + } +} + +static int mt6370_strobe_set(struct led_classdev_flash *fl_cdev, bool stat= e) +{ + struct mt6370_led *led =3D to_mt6370_led(fl_cdev, flash); + struct mt6370_priv *priv =3D led->priv; + struct led_classdev *lcdev =3D &fl_cdev->led_cdev; + struct led_flash_setting *setting =3D &fl_cdev->brightness; + u32 led_enable_mask =3D (led->led_no =3D=3D MT6370_LED_JOINT) ? + MT6370_FLCSEN_MASK_ALL : + MT6370_FLCSEN_MASK(led->led_no); + u32 enable_mask =3D MT6370_STROBEN_MASK | led_enable_mask; + u32 val =3D state ? led_enable_mask : 0; + u32 curr; + int ret; + + mutex_lock(&priv->lock); + + /* + * There is only one set of flash control logic, and this + * flag is used to check if 'torch' is currently being used. + */ + if (priv->fled_torch_used) { + dev_warn(lcdev->dev, "Please disable torch first [0x%x]\n", + priv->fled_torch_used); + ret =3D -EBUSY; + goto unlock; + } + + if (state) + curr =3D priv->fled_strobe_used | BIT(led->led_no); + else + curr =3D priv->fled_strobe_used & ~BIT(led->led_no); + + if (curr) + val |=3D MT6370_STROBEN_MASK; + + ret =3D regmap_update_bits(priv->regmap, MT6370_REG_FLEDEN, enable_mask, + val); + if (ret) { + dev_err(lcdev->dev, "[%d] control current source %d fail\n", + led->led_no, state); + goto unlock; + } + + /* + * If the flash needs to turn on, configure the flash current to + * ramp up to the setting value. Otherwise, always revert to the + * minimum one. + */ + ret =3D _mt6370_flash_brightness_set(fl_cdev, state ? setting->val : sett= ing->min); + if (ret) { + dev_err(lcdev->dev, "[%d] Failed to set brightness\n", led->led_no); + goto out_revert_state; + } + + /* + * For the flash to turn on/off, we must wait for HW ramping + * up/down time 5ms/500us to prevent the unexpected problem. + */ + if (!priv->fled_strobe_used && curr) + usleep_range(5000, 6000); + else if (priv->fled_strobe_used && !curr) + usleep_range(500, 600); + + priv->fled_strobe_used =3D curr; + +out_revert_state: + if (state) + curr =3D priv->fled_strobe_used & ~BIT(led->led_no); + else + curr =3D priv->fled_strobe_used | BIT(led->led_no); + + if (curr) + val |=3D MT6370_STROBEN_MASK; + + ret =3D regmap_update_bits(priv->regmap, MT6370_REG_FLEDEN, enable_mask, + val); + if (ret) + dev_err(lcdev->dev, "[%d] revert current source fail\n", led->led_no); +unlock: + mutex_unlock(&priv->lock); + return ret; +} + +static int mt6370_strobe_get(struct led_classdev_flash *fl_cdev, bool *sta= te) +{ + struct mt6370_led *led =3D to_mt6370_led(fl_cdev, flash); + struct mt6370_priv *priv =3D led->priv; + + mutex_lock(&priv->lock); + *state =3D !!(priv->fled_strobe_used & BIT(led->led_no)); + mutex_unlock(&priv->lock); + + return 0; +} + +static int mt6370_timeout_set(struct led_classdev_flash *fl_cdev, u32 time= out) +{ + struct mt6370_led *led =3D to_mt6370_led(fl_cdev, flash); + struct mt6370_priv *priv =3D led->priv; + struct led_flash_setting *setting =3D &fl_cdev->timeout; + u32 val =3D (timeout - setting->min) / setting->step; + int ret; + + mutex_lock(&priv->lock); + ret =3D regmap_update_bits(priv->regmap, MT6370_REG_STRBTO, + MT6370_STRBTO_MASK, val); + mutex_unlock(&priv->lock); + + return ret; +} + +static int mt6370_fault_get(struct led_classdev_flash *fl_cdev, u32 *fault) +{ + struct mt6370_led *led =3D to_mt6370_led(fl_cdev, flash); + struct mt6370_priv *priv =3D led->priv; + u16 fled_stat; + unsigned int chg_stat, strobe_timeout_mask, fled_short_mask; + u32 rfault =3D 0; + int ret; + + mutex_lock(&priv->lock); + ret =3D regmap_read(priv->regmap, MT6370_REG_CHGSTAT2, &chg_stat); + if (ret) + goto unlock; + + ret =3D regmap_raw_read(priv->regmap, MT6370_REG_FLEDSTAT1, &fled_stat, + sizeof(fled_stat)); + if (ret) + goto unlock; + + switch (led->led_no) { + case MT6370_LED_FLASH1: + strobe_timeout_mask =3D MT6370_FLED1STRBTO_MASK; + fled_short_mask =3D MT6370_FLED1SHORT_MASK; + break; + + case MT6370_LED_FLASH2: + strobe_timeout_mask =3D MT6370_FLED2STRBTO_MASK; + fled_short_mask =3D MT6370_FLED2SHORT_MASK; + break; + + case MT6370_LED_JOINT: + strobe_timeout_mask =3D MT6370_FLED1STRBTO_MASK | + MT6370_FLED2STRBTO_MASK; + fled_short_mask =3D MT6370_FLED1SHORT_MASK | + MT6370_FLED2SHORT_MASK; + } + + if (chg_stat & MT6370_FLEDCHGVINOVP_MASK) + rfault |=3D LED_FAULT_INPUT_VOLTAGE; + + if (fled_stat & strobe_timeout_mask) + rfault |=3D LED_FAULT_TIMEOUT; + + if (fled_stat & fled_short_mask) + rfault |=3D LED_FAULT_SHORT_CIRCUIT; + + if (fled_stat & MT6370_FLEDLVF_MASK) + rfault |=3D LED_FAULT_UNDER_VOLTAGE; + + *fault =3D rfault; +unlock: + mutex_unlock(&priv->lock); + return ret; +} + +static const struct led_flash_ops mt6370_flash_ops =3D { + .flash_brightness_set =3D mt6370_flash_brightness_set, + .strobe_set =3D mt6370_strobe_set, + .strobe_get =3D mt6370_strobe_get, + .timeout_set =3D mt6370_timeout_set, + .fault_get =3D mt6370_fault_get, +}; + +#if IS_ENABLED(CONFIG_V4L2_FLASH_LED_CLASS) +static int mt6370_flash_external_strobe_set(struct v4l2_flash *v4l2_flash, + bool enable) +{ + struct led_classdev_flash *flash =3D v4l2_flash->fled_cdev; + struct mt6370_led *led =3D to_mt6370_led(flash, flash); + struct mt6370_priv *priv =3D led->priv; + u32 mask =3D (led->led_no =3D=3D MT6370_LED_JOINT) ? MT6370_FLCSEN_MASK_A= LL : + MT6370_FLCSEN_MASK(led->led_no); + u32 val =3D enable ? mask : 0; + int ret; + + mutex_lock(&priv->lock); + ret =3D regmap_update_bits(priv->regmap, MT6370_REG_FLEDEN, mask, val); + if (ret) + goto unlock; + + if (enable) + priv->fled_strobe_used |=3D BIT(led->led_no); + else + priv->fled_strobe_used &=3D ~BIT(led->led_no); + +unlock: + mutex_unlock(&priv->lock); + return ret; +} + +static const struct v4l2_flash_ops v4l2_flash_ops =3D { + .external_strobe_set =3D mt6370_flash_external_strobe_set, +}; + +static void mt6370_init_v4l2_flash_config(struct mt6370_led *led, + struct v4l2_flash_config *config) +{ + struct led_classdev *lcdev; + struct led_flash_setting *setting =3D &config->intensity; + + lcdev =3D &led->flash.led_cdev; + + setting->min =3D MT6370_ITORCH_MIN_uA; + setting->step =3D MT6370_ITORCH_STEP_uA; + setting->max =3D setting->min + (lcdev->max_brightness - 1) * setting->st= ep; + setting->val =3D setting->max; + + config->has_external_strobe =3D 1; + strscpy(config->dev_name, lcdev->dev->kobj.name, + sizeof(config->dev_name)); + + config->flash_faults =3D LED_FAULT_SHORT_CIRCUIT | LED_FAULT_TIMEOUT | + LED_FAULT_INPUT_VOLTAGE | + LED_FAULT_UNDER_VOLTAGE; +} +#else +static const struct v4l2_flash_ops v4l2_flash_ops; +static void mt6370_init_v4l2_flash_config(struct mt6370_led *led, + struct v4l2_flash_config *config) +{ +} +#endif + +static void mt6370_v4l2_flash_release(void *v4l2_flash) +{ + v4l2_flash_release(v4l2_flash); +} + +static int mt6370_led_register(struct device *parent, struct mt6370_led *l= ed, + struct led_init_data *init_data) +{ + struct v4l2_flash_config v4l2_config =3D {}; + int ret; + + ret =3D devm_led_classdev_flash_register_ext(parent, &led->flash, + init_data); + if (ret) + return dev_err_probe(parent, ret, + "Couldn't register flash %d\n", led->led_no); + + mt6370_init_v4l2_flash_config(led, &v4l2_config); + led->v4l2_flash =3D v4l2_flash_init(parent, init_data->fwnode, + &led->flash, &v4l2_flash_ops, + &v4l2_config); + if (IS_ERR(led->v4l2_flash)) + return dev_err_probe(parent, PTR_ERR(led->v4l2_flash), + "Failed to register %d v4l2 sd\n", led->led_no); + + return devm_add_action_or_reset(parent, mt6370_v4l2_flash_release, + led->v4l2_flash); +} + +static u32 mt6370_clamp(u32 val, u32 min, u32 max, u32 step) +{ + u32 retval; + + retval =3D clamp_val(val, min, max); + if (step > 1) + retval =3D rounddown(retval - min, step) + min; + + return retval; +} + +static int mt6370_init_flash_properties(struct mt6370_led *led, + struct led_init_data *init_data) +{ + struct led_classdev_flash *flash =3D &led->flash; + struct led_classdev *lcdev =3D &flash->led_cdev; + struct mt6370_priv *priv =3D led->priv; + struct led_flash_setting *setting; + u32 sources[MT6370_MAX_LEDS]; + u32 max_ua, val; + int i, ret, num; + + num =3D fwnode_property_count_u32(init_data->fwnode, "led-sources"); + if (num < 1 || num > MT6370_MAX_LEDS) + return dev_err_probe(priv->dev, -EINVAL, + "Not specified or wrong number of led-sources\n"); + + ret =3D fwnode_property_read_u32_array(init_data->fwnode, "led-sources", = sources, num); + if (ret) + return ret; + + for (i =3D 0; i < num; i++) { + if (sources[i] >=3D MT6370_MAX_LEDS) + return -EINVAL; + if (priv->leds_active & BIT(sources[i])) + return -EINVAL; + priv->leds_active |=3D BIT(sources[i]); + + } + led->led_no =3D (num =3D=3D MT6370_MAX_LEDS) ? MT6370_LED_JOINT : + sources[0]; + + max_ua =3D (num =3D=3D 2) ? MT6370_ITORCH_DOUBLE_MAX_uA : MT6370_ITORCH_M= AX_uA; + ret =3D fwnode_property_read_u32(init_data->fwnode, "led-max-microamp", &= val); + if (ret) { + dev_info(priv->dev, + "Not specified led-max-microamp, config to the minimum\n"); + val =3D MT6370_ITORCH_MIN_uA; + } else { + val =3D mt6370_clamp(val, MT6370_ITORCH_MIN_uA, max_ua, + MT6370_ITORCH_STEP_uA); + } + + lcdev->max_brightness =3D (val - MT6370_ITORCH_MIN_uA) / + MT6370_ITORCH_STEP_uA + 1; + lcdev->brightness_set_blocking =3D mt6370_torch_brightness_set; + lcdev->flags |=3D LED_DEV_CAP_FLASH; + + max_ua =3D (num =3D=3D 2) ? MT6370_ISTRB_DOUBLE_MAX_uA : MT6370_ISTRB_MAX= _uA; + ret =3D fwnode_property_read_u32(init_data->fwnode, "flash-max-microamp",= &val); + if (ret) { + dev_info(priv->dev, + "Not specified flash-max-microamp, config to the minimum\n"); + val =3D MT6370_ISTRB_MIN_uA; + } else { + val =3D mt6370_clamp(val, MT6370_ISTRB_MIN_uA, max_ua, + MT6370_ISTRB_STEP_uA); + } + + setting =3D &flash->brightness; + setting->min =3D MT6370_ISTRB_MIN_uA; + setting->step =3D MT6370_ISTRB_STEP_uA; + setting->val =3D setting->max =3D val; + + /* + * Always configure to the minimum level when + * off to prevent flash current spikes. + */ + ret =3D _mt6370_flash_brightness_set(flash, setting->min); + if (ret) + return ret; + + ret =3D fwnode_property_read_u32(init_data->fwnode, + "flash-max-timeout-us", &val); + if (ret) { + dev_info(priv->dev, + "Not specified flash-max-timeout-us, config to the minimum\n"); + val =3D MT6370_STRBTO_MIN_US; + } else { + val =3D mt6370_clamp(val, MT6370_STRBTO_MIN_US, + MT6370_STRBTO_MAX_US, MT6370_STRBTO_STEP_US); + } + + setting =3D &flash->timeout; + setting->min =3D MT6370_STRBTO_MIN_US; + setting->step =3D MT6370_STRBTO_STEP_US; + setting->val =3D setting->max =3D val; + + flash->ops =3D &mt6370_flash_ops; + + return 0; +} + +static int mt6370_led_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct mt6370_priv *priv; + struct fwnode_handle *child; + size_t count; + int i =3D 0, ret; + + count =3D device_get_child_node_count(dev); + if (!count || count > MT6370_MAX_LEDS) + return dev_err_probe(dev, -EINVAL, + "No child node or node count over max led number %zu\n", count); + + priv =3D devm_kzalloc(dev, struct_size(priv, leds, count), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->leds_count =3D count; + priv->dev =3D dev; + mutex_init(&priv->lock); + + priv->regmap =3D dev_get_regmap(dev->parent, NULL); + if (!priv->regmap) + return dev_err_probe(dev, -ENODEV, "Failed to get parent regmap\n"); + + device_for_each_child_node(dev, child) { + struct mt6370_led *led =3D priv->leds + i; + struct led_init_data init_data =3D { .fwnode =3D child, }; + + led->priv =3D priv; + led->default_state =3D led_init_default_state_get(init_data.fwnode); + + ret =3D mt6370_init_flash_properties(led, &init_data); + if (ret) + return ret; + + ret =3D mt6370_led_register(dev, led, &init_data); + if (ret) + return ret; + + i++; + } + + return 0; +} + +static const struct of_device_id mt6370_led_of_id[] =3D { + { .compatible =3D "mediatek,mt6370-flashlight" }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, mt6370_led_of_id); + +static struct platform_driver mt6370_led_driver =3D { + .driver =3D { + .name =3D "mt6370-flashlight", + .of_match_table =3D mt6370_led_of_id, + }, + .probe =3D mt6370_led_probe, +}; +module_platform_driver(mt6370_led_driver); + +MODULE_AUTHOR("Alice Chen "); +MODULE_DESCRIPTION("MT6370 FLASH LED Driver"); +MODULE_LICENSE("GPL v2"); --=20 2.25.1