From nobody Mon Dec 1 23:33:35 2025 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCE1B30E0C3; Wed, 26 Nov 2025 03:26:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764127622; cv=none; b=ETStB7mwBHHZ/um6ENoyywQBe5o16noV/yCyCH5DO0hkvOsIuzqiMsBAWiaoQ9lHADKD9eC8iSr5/bntsvNYEIucYfmnn+PVnzF7CNBBzTiHneK/GcXz9AYvKKh8Yvboh9uxhI3+rReaaqmUYkwdD1bKd8ftBHSs+kvmkfd7q9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764127622; c=relaxed/simple; bh=QvQWNTzAha/pjhXOIsexT1PVcm/R9MAVan25HFoMY7Q=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=eUrPpgbYFbyobufETaz84Zu3rNMz77gpPpoanz1CMNoDGQnqE23rzRaVt92SOhhhjYqoRqxvamNFJhjp5zQdUEUKPZGegH/LTpIJgSMJ0W79F1XoeKKh9VVo0DmFMW3LJgZ7gesqZXIg2WQIAEnQ8d+OyLUhL6JJaY1bl/Oq9/8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b=qOIlFFCj; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b="qOIlFFCj" X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 5AQ3QaMhA107475, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realtek.com; s=dkim; t=1764127596; bh=QvQWNTzAha/pjhXOIsexT1PVcm/R9MAVan25HFoMY7Q=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:Content-Transfer-Encoding:MIME-Version; b=qOIlFFCjWZGiS8RXDqPig1idzUEoU9U3Fe3hvajmp12Yh+7Js2V74wTOGNgyk6Iz4 CIxNj30cleJK94o84d7iQfxrYix7MTMOPlH098J8sSrbDMlpJGp585Ku5BvMQjcoJQ E7UG+0In8+C3Sv2sftBdO5Re4zXuJnMgjgs4bB2Ge0qA9AKDs9YyFe23ib8ahbCWKh 0x6xOfFXjxtw5yilf322C1sFas36KQuwklT1ziSpwpKoxuRo3lJP3w7n2nXiIYE+Uk cEs1FNfTNlzyKBy7LeQm/mcXDMoGcMS+z1yKl/Y4UeXJEW7GJm3e7irCUclJU2i8Lu J7cK2lFvwfteg== Received: from mail.realtek.com (rtkexhmbs03.realtek.com.tw[10.21.1.53]) by rtits2.realtek.com.tw (8.15.2/3.21/5.94) with ESMTPS id 5AQ3QaMhA107475 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Nov 2025 11:26:36 +0800 Received: from RTKEXHMBS01.realtek.com.tw (172.21.6.40) by RTKEXHMBS03.realtek.com.tw (10.21.1.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.27; Wed, 26 Nov 2025 11:26:37 +0800 Received: from RTKEXHMBS06.realtek.com.tw (10.21.1.56) by RTKEXHMBS01.realtek.com.tw (172.21.6.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.27; Wed, 26 Nov 2025 11:26:36 +0800 Received: from RTKEXHMBS06.realtek.com.tw ([::1]) by RTKEXHMBS06.realtek.com.tw ([fe80::744:4bc9:832c:9b7e%10]) with mapi id 15.02.1544.027; Wed, 26 Nov 2025 11:26:36 +0800 From: Ping-Ke Shih To: Bitterblue Smith , Zenm Chen , "gustavo@embeddedor.com" CC: "Jes.Sorensen@gmail.com" , "gustavoars@kernel.org" , "linux-hardening@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-wireless@vger.kernel.org" Subject: RE: [PATCH][next] wifi: rtl8xxxu: Avoid -Wflex-array-member-not-at-end warnings Thread-Topic: [PATCH][next] wifi: rtl8xxxu: Avoid -Wflex-array-member-not-at-end warnings Thread-Index: AQHcWTQWm+ekto8gdkOtuZTX88y/HbT8ZJsAgAADogCAAA5sgIADwJWAgAQc65A= Date: Wed, 26 Nov 2025 03:26:36 +0000 Message-ID: References: <20251121111132.4435-1-zenmchen@gmail.com> <475b4336-eed0-4fae-848f-aae26f109606@gmail.com> In-Reply-To: <475b4336-eed0-4fae-848f-aae26f109606@gmail.com> Accept-Language: en-US, zh-TW Content-Language: zh-TW Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Bitterblue, Bitterblue Smith wrote: > On 21/11/2025 13:11, Zenm Chen wrote: > > Gustavo A. R. Silva =E6=96=BC 2025=E5=B9=B411= =E6=9C=8821=E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=886:20=E5=AF=AB=E9= =81=93=EF=BC=9A > >> > >> Hi, > >> > >> On 11/21/25 19:06, Zenm Chen wrote: > >>> Dear maintainers, > >>> > >>> With this patch applied, my system always freezes right after the rtl= 8xxxu > >>> driver is loaded. is it normal? > >> > >> I don't think so... It probably means that struct urb urb; cannot real= ly be > >> moved to the end of struct rtl8xxxu_rx_urb or struct rtl8xxxu_tx_urb? > >> > >> It'd be great if you could share a log. > >> > > > > Hi, > > > > Nothing helpful found from the kernel log. Maybe Realtek drivers mainta= iner > > Ping-Ke could take a look what is wrong next Monday. > > > [...] >=20 > I got something. In my case everything seemed fine until I unplugged the > wifi adapter. And then the system still worked for a few minutes before > it froze. >=20 Zenm and I tested below changes which can also reproduce the symptom, so I wonder driver might assume urb is the first member of struct, but=20 unfortunately I can't find that. Could you also help to review if something I missed? Thanks. --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h @@ -1942,15 +1942,19 @@ struct rtl8xxxu_vif { }; struct rtl8xxxu_rx_urb { + u8 pad[128]; struct urb urb; struct ieee80211_hw *hw; struct list_head list; }; struct rtl8xxxu_tx_urb { + u8 pad[128]; struct urb urb; struct ieee80211_hw *hw; struct list_head list; }; struct rtl8xxxu_fileops {