From nobody Wed Apr 1 09:47:51 2026 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023139.outbound.protection.outlook.com [40.107.159.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8AA133FE0A; Mon, 30 Mar 2026 15:33:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.139 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774884804; cv=fail; b=mHwjPJce/0kOzN/772Dr+lT7R5oKH/RQVbVTrFxUoJxmG2KGhlP2/+UjbSxFK6mabgbTFRUJ6IdNoei9jhGx08zjAKtnl5oH7z7hBeotTsQ/AfBaZtLzakGCb/Ca6ir1l0ZMWPUCTfZVhIAJzC6YJF3xLQ9VGvfhnl+Gd55/FSo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774884804; c=relaxed/simple; bh=4WjsRUp3JppEulvBbPgXVqZZdmqV+8A/N+x9bAuWW0I=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=HFx59va146HL8r4olN8K+VZrhpDNUCMGQBv3FNQsRWJQM+9uH8DdNnQa0JKmReUljGZPZ9127aTg0euiTmA6XM1mSpzIViI0G/WUnZCkeC3kucibGZbTj/xLv1bLlmqaiIpDUFWR/jChXvO1bXpzzujZRExH6VeMhdsZsQ+Nx68= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=1seal.org; spf=pass smtp.mailfrom=1seal.org; dkim=pass (2048-bit key) header.d=1seal.org header.i=@1seal.org header.b=WxETJgYF; arc=fail smtp.client-ip=40.107.159.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=1seal.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1seal.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=1seal.org header.i=@1seal.org header.b="WxETJgYF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xkZS/bWkJ6XLldCaLQaMPA9Lty+Uq33J4RZn0rH2k3vEUYhVFoeF9nPJGGsrbGZA3USsfiIG8mphsyR5Jp2as3QG8WPSBQbosHi/GfbtyxebIHzAxPayOEfUADQN+OQIdPnwydh2Qfb+KWunFPd7hofNEACSEk5aWhQqv4AVdr27YLv2w4M72paWIsmIShfxLvigM/uz0MmrHh1TtE8KgaAHIievisAizcGv+062C2KJqRF2AkqjVr8buKLpysAFGh5wj1MP8SrEC/7gctu+wSJZWedB1BpL/ZYgLk2GUQmpL+a+nZsUQ4pgKFtZZH4jquJS9IFvFl/Q1wdIjuvoSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4WjsRUp3JppEulvBbPgXVqZZdmqV+8A/N+x9bAuWW0I=; b=scNwixqUdBipEX34Vcx5YQBLUeXYsq9V/9DyqETEKZZ9VBimWY4QtpkJrBBSzGeWWhoffd/1LmyMocdz45zlMonajWBmM4X5MspqUS/qNSHgmWk0eR73KAd/D7JfmOfRn0WpN0DGKpcnOPlzJIen8Jc2pKWq01Y0A9OyCZNcMpuTbuXRrKICT3PtxQTi9pYRuTmfgjOyGjBIDzqTXAQAekYygz5fR0HDF8aC4T+eaCNCQXGP/rwHrQr05i2kdmRQ9zO90pb2kCdw5ftf1Ni4bW6QO0sErOWR8mcqOEPOt9Sb/wk5k+MdTXCmrmJRrU1gRFrXh5qLOXWkixjXQnpIMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=1seal.org; dmarc=pass action=none header.from=1seal.org; dkim=pass header.d=1seal.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1seal.org; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4WjsRUp3JppEulvBbPgXVqZZdmqV+8A/N+x9bAuWW0I=; b=WxETJgYFZIO0f/vkhFr+wvNP2YEbzXhmC0b6TLzoHDoyCY1u8nBL23essHLCvJn0dPSKiQcsX7l6Evox4srDLdkQeXBDfvbK14efoP9UbSzFqyF1pGmvZuz+gnYN+uMcAvqNm2NweECKaQ6NlTfMnnekYXQkX9bRzgMehQHPm755xsRCyJWq5ekoi3BYRnQCFkd4KCDNE7UKr0lzKj6P2490cXt3qvWyusyWWcy72OzF1fXPl7kvvjOsFtx2762qqGSarz3ADXNAKxjHdHkGyhElZfeQl+utbPUp27c2JwM/St7DBy0mBurzpMjkXBbszuhDcbHFqbHCT/Vtb2eJpg== Received: from DBBPR04MB7673.eurprd04.prod.outlook.com (2603:10a6:10:202::5) by PA1PR04MB10099.eurprd04.prod.outlook.com (2603:10a6:102:45d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Mon, 30 Mar 2026 15:33:19 +0000 Received: from DBBPR04MB7673.eurprd04.prod.outlook.com ([fe80::cf39:9ba0:2b9c:419]) by DBBPR04MB7673.eurprd04.prod.outlook.com ([fe80::cf39:9ba0:2b9c:419%3]) with mapi id 15.20.9745.027; Mon, 30 Mar 2026 15:33:19 +0000 From: Oleh Konko To: "linux-bluetooth@vger.kernel.org" CC: "marcel@holtmann.org" , "luiz.dentz@gmail.com" , "linux-kernel@vger.kernel.org" Subject: [PATCH v3 1/2] Bluetooth: SMP: honor local HIGH security when selecting legacy pairing method Thread-Topic: [PATCH v3 1/2] Bluetooth: SMP: honor local HIGH security when selecting legacy pairing method Thread-Index: AQHcwFqIovupBjPvE0q94pJqy0uNGw== Date: Mon, 30 Mar 2026 15:33:19 +0000 Message-ID: <78570f37f1da48f38336480ba61e29d9.security@1seal.org> References: In-Reply-To: Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=1seal.org; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DBBPR04MB7673:EE_|PA1PR04MB10099:EE_ x-ms-office365-filtering-correlation-id: 0f75bc83-d7df-4308-83d2-08de8e71ab8d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7055299006|38070700021|18002099003|56012099003|22082099003; x-microsoft-antispam-message-info: sYR+uEmgOXUdtHnT/Kj4bhnloesLxrMs8KmauIUnFJN6g1xFMKULAueGtiWrj+THtBz/ZrvMDub5adxPylCuQa6s3iOskv4m8gHcTjuWJ9FbrHv5mB3xTeyjYjfXdWFWh+8ZoaC89tqsP4lRRBfTxyczmN+AUtcdK0cW0wdyZbGsP7uEHQYRYU01CoefNbljnNygYIuplG+cL7l1kn5ExUyJvJlIjwYOCM8whrVdk1T1Anmmx4bunnJjLBM3BPJYJ3HFnPt764lcu8plFPgQDEmoggWsjpaz5HxN/DTA8wlzfV3rMflhIP70o7isG2kZwR3/p9XBMhDQK6ZoImdQieL5R/1lSQ7SigH8lmdNIhkIxsIqczclduYb2HAgBxh1VawL9wgXgwH2UQt2CEvMX2sLgbgm/dwlcfJthjl8K6NQGpBZjNzCVNPz4TcK+WYH1aGMkNLTULhtX390kctX84dRjMG4HKlDDfUYYVagWskN23p9W7EwUtwPmxAriKD12pShyAukC/g9Gp4Y1KlSuke/DAx2IuRiUhYealeaAEDRxvvDtOPi9q+cbCxSq49iXPPq5OQuU3tVN7URg78s4TLs1JI1WoplWUM4tzdYclN+X7W4sAA+a/1uVlA+NQ4Ba4Wtz7OxvZS0Vjl6CSDaTXHIM2r4qvH4+Gc5qD4rso0Yl4KzEYK2vnDcYs26h5tXGQ1Erb9ARQoKa+xEzBqZkn3xGlnLlpFT/VrC6urEZROxXrZT0pIhJyMv25WS5ZoiO7P4EZeUuDRNLD2zMUjP3fLhHn/CGxzNypAwOKMAQpGDAJJ30u5sF85BfDU9XJHw x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBBPR04MB7673.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7055299006)(38070700021)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZnpiSUoweStlTndjWk8vSEQ0OUdNeCtqRHJSQ3NIeEYwK2dOV2d0TGY4elRV?= =?utf-8?B?TGI1WTZWWUJWOVBBa1lvS3o0TUVCV2dJL1VQWHhETm4zdS9DdWRZNUIwT0pC?= =?utf-8?B?N01kUW1jY0xrbERxSlRza2dtdWJUenoyaHBDQ2xwN1dUVDBhd1hyMWY1M0cx?= =?utf-8?B?aHE2bllHVDhqODhCK0E5QzJhaDJDNDlzVjhzWUgxSWJNYU1rUTg4UXRabktU?= =?utf-8?B?OVIvUHJDVGNkZkFHSmRuTWlqeFFQakl2REltcy91VzBVT1NqNUxDeW1yOG1i?= =?utf-8?B?dHd1enUwVFQyS2Jsak9LbW1UOW9KeDJLM09PWkpxVGF3Smg3SUJFQklMNVRO?= =?utf-8?B?L0NYTHdnd0pNNkc4NS83THY2NXQzL0g1VlU3Z1BreU83OHM2WjRMWWVtL3Ar?= =?utf-8?B?UjRKVjRFUTdnY2pxbFJmRkpDSUFUZE9pZVgzWjJ2RFJTVWQvNU4wS2NMWlpy?= =?utf-8?B?NU9VTTJSRTVPQlVjMThnaE9ZRXdWM3RuZXFza3dHUEI0QzRCZWlRaFZQVEFr?= =?utf-8?B?YWR4R0VwbDRSdS95QVJaNnVxeFVPeU1JQ3NEYS96eDY0OUYrZjJvakdHZWJy?= =?utf-8?B?SjJxSVdMNmtQSnJhYm1UTTE4YmxOMXJYYkNydUUvTWZyeDZiKzQweVhFRWhL?= =?utf-8?B?RjhGWndrWWZGRjNObWxKa3RhTEQ3NG1tdVdwWUpwRk9rS21UUXduMWFBYXhx?= =?utf-8?B?Uk43YUY4S0hmQnhteE9sYmhLQk1HZ1k5dkNpdGZKZVVNNlJWWlYwUFE1a3JE?= =?utf-8?B?TnV3dHNRaGlMa0IrU1g5T0ZDayt6cG1FZVMxb05XbzVQdU93My9xbUJPUVF0?= =?utf-8?B?emY0U3c5YXBwV2U3R29jL3BoV2JqcnBPUVM3bERmODFmRDJYOHVTNkxCR0h6?= =?utf-8?B?ckRrUU4yMDJOU3dTREdtVDVEME5IMHF2QkRyN3RyaUJUZHcrRVRrZy80elor?= =?utf-8?B?K1dHT003d0ZoLzNjMGEyN2pMQTF4cDM5WGhYc1NCclhkQlQ3OXdpMmNOb0tG?= =?utf-8?B?ejZ5Ym4zb200MGp2TVVIejA0UHRac05Md1BrTHNoSENuWWRCallQNmtkQUtI?= =?utf-8?B?RXc0VmpmdUM2MlEzRktJNk1qTVRrekVyWE50NFZtY0JhZmV2eGZuT1EvR25k?= =?utf-8?B?VWdndStyd1UyN3d6MC9LUGowT1B0cmgrZ0RqcGlMazEvQ1d2SWh5NVA1bjRx?= =?utf-8?B?K0VnMjBEUjd3dVArbFcyVnVCYjZRcUYzUEdYblFNc2Y3bnBmU0wrOURtVlB2?= =?utf-8?B?NTNIeU9FdXJJMklPb2IvM29PNmxuOXgyUThkV3hsV2toT2lDQVcyRVJITy9l?= =?utf-8?B?ek5oT3pSQUpiUzRRdHNsUjJ1NWpKREJBT0RaWHVzSkJKRkZycUExS0ZkZ3VM?= =?utf-8?B?QlJWSEdzbCsrNVlBSkpYVzRONUMvNTAwanlBSXpCazdobTVkcHNNQUx0dFVE?= =?utf-8?B?UkZab2dkL1c1NTBMSlBUaDQvTk15WnRYcFArcUFGZmsrbUc4dllBb3BXSFlj?= =?utf-8?B?VFI3dlhpZngra2g3dVhGTGNHQ1h5c1lQSDBDeHI3VTBwa2V6YXhxV0pIRjg5?= =?utf-8?B?UkkwcmJUc2ZOUkhCdTdQcnd1SkozU2gzeW9kdi9Ncll3MDBLS3BYMlRrWU1v?= =?utf-8?B?a3JJdXVXbURmUDBjS1J5UG1KTWVVUEFxU0g0WGpqSWp0aEt3ZHgwWDU2bk4z?= =?utf-8?B?ZHhNajI3azIwYm1FT0pvWDRYeDl2NkMwVzREZ3A5Wk1kUlRGaWRXVld1dkkr?= =?utf-8?B?WGFBUzljMDMrN2trZElMUmF5QWZXUWVhcExhTnFYOFB3bW9GSEJQTnlGc3Bx?= =?utf-8?B?MVRkRGVWdHdONEVxaHc2ZGRSejRYT0lGbzJSbDc4MmZid3ZyUytQM3pBM2E2?= =?utf-8?B?SUZGLzJNbG41bmxPK0h4NlNMVzJrTit1emJrNW53YnRzdWYzMWlnM0RzSmJu?= =?utf-8?B?czAyTHdYZ3d1SnBZSVZBM0w2Q2VRQlcrTDFCdHlGR1dhRlpjUW5FekFaZEhz?= =?utf-8?B?L1orSzFPMnJhT1Q4TVF2SUpWRGhCNWRHcGU1REdEUEdTaGp0cGI5QjUrVkRh?= =?utf-8?B?SE1sOFk4cmZCQ0RjNFp3S1FSM1Rzb3hzSHFaZlAvdGpYNDJrakhPMzBTNC8x?= =?utf-8?B?cU1UbGhaZ3RNZjE3L2tHMWRTUDBUVTdkMG5uenZPN2VoQ1lQV3ZFL3U3U0pQ?= =?utf-8?B?cDhjRTBncFNLMGlvS05OckwzeUdhcTFSRStVQ0tmS1UwK0xxeGhnNzBRNUgy?= =?utf-8?B?T2dtV1Fvcy9jS3U5NGxrU1pZdnFvQi9jN1ZzWXF5amNQK1VvdmQzZ0MybGx1?= =?utf-8?Q?a4QBiEA+2scQDrxbpy?= Content-Type: text/plain; charset="utf-8" Content-ID: <7DDC6C7F6EF60B4BBFBBD9D503D32666@eurprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: 1seal.org X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DBBPR04MB7673.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f75bc83-d7df-4308-83d2-08de8e71ab8d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2026 15:33:19.0354 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e701d992-0f02-433e-a019-4256abe96ea1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p7udZ+lfKTWHz9EKb9WG96MC0YlICYROvJo6Iyl9BkSX2Oy9i2O+omn1DpwDBBJWeQGWehDJISCPj2e6fpJPWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10099 tk_request() currently forces JUST_CFM whenever the remote auth_req omits SMP_AUTH_MITM. That ignores the local pending_sec_level, even though the responder may still require BT_SECURITY_HIGH. The pairing-request path already rejects JUST_WORKS/JUST_CFM when pending_sec_level >=3D BT_SECURITY_HIGH, so letting tk_request() ignore the local MITM requirement can make method selection inconsistent with the policy the stack already enforces. Only select JUST_CFM when the remote does not request MITM and the local side does not require HIGH security. Otherwise, derive the method from the IO capability table. Fixes: 2b64d153a0cc ("Bluetooth: Add MITM mechanism to LE-SMP") Cc: stable@vger.kernel.org Suggested-by: Luiz Augusto von Dentz Signed-off-by: Oleh Konko --- net/bluetooth/smp.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c index e67bf7b34ea..a9fb9b513d6 100644 --- a/net/bluetooth/smp.c +++ b/net/bluetooth/smp.c @@ -863,13 +863,14 @@ static int tk_request(struct l2cap_conn *conn, u8 rem= ote_oob, u8 auth, bt_dev_dbg(hcon->hdev, "auth:%u lcl:%u rem:%u", auth, local_io, remote_io); =20 - /* If neither side wants MITM, either "just" confirm an incoming - * request or use just-works for outgoing ones. The JUST_CFM - * will be converted to JUST_WORKS if necessary later in this - * function. If either side has MITM look up the method from the - * table. + /* If the remote doesn't request MITM and the local side doesn't + * require HIGH security, either "just" confirm an incoming request + * or use just-works for outgoing ones. The JUST_CFM will be + * converted to JUST_WORKS if necessary later in this function. + * Otherwise, look up the method from the table. */ - if (!(auth & SMP_AUTH_MITM)) + if (!(auth & SMP_AUTH_MITM) && + hcon->pending_sec_level < BT_SECURITY_HIGH) smp->method =3D JUST_CFM; else smp->method =3D get_auth_method(smp, local_io, remote_io); --=20 2.50.0 From nobody Wed Apr 1 09:47:51 2026 Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11023104.outbound.protection.outlook.com [52.101.83.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C95B7346FA7; Mon, 30 Mar 2026 15:33:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.83.104 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774884805; cv=fail; b=dDn+S+66mpxZB9mvNywN+IAJS/u8zu7DjzrlJYP8alqVIxOkLIvJiW2ZfE+0OKmIG79VnUyGidroZfYIbXaqbyLj0XsyeZyVKQzslXiSXOpdIX5nMTPLF1RXnYVptmQH/GR7dgqQ3EZL21+Jat9J8rb6+pOd8L1JboOrOlwPfxg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774884805; c=relaxed/simple; bh=LUICsXv/hGkJYL1h0rtVlNtMzTikxm2y2BtsRvgFVdY=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=THzHTzfaiWD79BhtWtSZ0oCTHV69vEKL1Kyg/pAFAjnh6aPduMoNs/bWGM+cOTtnldp4CgGQmfDqRJEzww+i/7RRsLhGGhtbdYvS5DluVOOyh2xE3oPbnXPYFttjipWJdD+eyooWQhlrbJJtwBjX01Qc23MnrhyD/z/hOC8uirA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=1seal.org; spf=pass smtp.mailfrom=1seal.org; dkim=pass (2048-bit key) header.d=1seal.org header.i=@1seal.org header.b=hf31jjwq; arc=fail smtp.client-ip=52.101.83.104 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=1seal.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1seal.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=1seal.org header.i=@1seal.org header.b="hf31jjwq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HSgE6jZ/4/UYzYR4EvH7sn0vhxUFdA3txTFN5oKMYgxbdO6Mw6KDCM9TjRh8fkrPZnmPRCu9Doiwhq/bWROEFmnTnB2cMIso0ZaziznEe01cvpC/rdNF+IX+ajv7ubBPgGD130PZGPJM5leLfJhz3w21CTkWax9a0b/1h/FMi6bJmwtlAIXEfJcYpnqd9cYSiXTsLywir1gzRxQI3gbcUwAAqPvD8WY/DHZ76A9piHsMhT8C+71RTV+Fa8TRpNisbIVYCUbQ6jWRxmmStXVL1he4S44wJSl0MIHl1RHiEeagPd94T4usH6SIPqeZluMUOr6DyTDtJWuZfakK7m3yKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LUICsXv/hGkJYL1h0rtVlNtMzTikxm2y2BtsRvgFVdY=; b=lRTyztlWY9LBIN3k+1krYelT++T5lj55I2zBi3OG6lP3UpvrKYI3IMdFdv4jnWmaQBLekP2WUNJhjsjgt4nzGQXxrH+/vA0iDkeN6xHZmy+eoZNGkniZE+SwKwZP1IOk6bqEyTkuTQ34NY6mfga1tCpWV+DXmPBazHdzp4ByX8WMfnqM3neRV0bBW8i6K03wGm714Lkvln9hTPADZdG2aybIuu8OfXfIiUh2SRevl8b0VzUeZLsY/jlkMWWDvcQWQAmTkXQfjIEABY/0SI8m/1j548tk5vLniaHIawllIb+N/OCu8wUG/eWPcyHHYN/PQRnME1DVENta++ysQaR1Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=1seal.org; dmarc=pass action=none header.from=1seal.org; dkim=pass header.d=1seal.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1seal.org; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LUICsXv/hGkJYL1h0rtVlNtMzTikxm2y2BtsRvgFVdY=; b=hf31jjwqz5l5WZLtBM/CQMwSEkJgzDT/ZFjQP8JPi050CKIKxfIxwVSjzD5s8qQ5/dUmpTeCFoXGyZkJSbfEXVlCFFTCeIY/xkQO+pS4IY0BsZcz4c8eJjW1uNOR3eTXAKCx3JCcpW/6WGLtI+2cszaY5NQtVX284FI2Omjm2q1MgdHp/h6Hooaf052uL1hkUMMV7hSFaSK4KqQ1nXtCGdQCCEKEND86QUh5C5APzWJnEgimCiVM5Rz6c/WSdntkbPtK23shsfw3dnaVLVTb09y+GmeKs2Rg4FVC0vAoYNBW5JtSV9s08RdFpkCBK4/h+5qd3F+4pq45O15KH0LvRQ== Received: from DBBPR04MB7673.eurprd04.prod.outlook.com (2603:10a6:10:202::5) by GV1PR04MB10584.eurprd04.prod.outlook.com (2603:10a6:150:210::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Mon, 30 Mar 2026 15:33:19 +0000 Received: from DBBPR04MB7673.eurprd04.prod.outlook.com ([fe80::cf39:9ba0:2b9c:419]) by DBBPR04MB7673.eurprd04.prod.outlook.com ([fe80::cf39:9ba0:2b9c:419%3]) with mapi id 15.20.9745.027; Mon, 30 Mar 2026 15:33:19 +0000 From: Oleh Konko To: "linux-bluetooth@vger.kernel.org" CC: "marcel@holtmann.org" , "luiz.dentz@gmail.com" , "linux-kernel@vger.kernel.org" Subject: [PATCH v3 2/2] Bluetooth: SMP: derive legacy responder STK authentication from MITM state Thread-Topic: [PATCH v3 2/2] Bluetooth: SMP: derive legacy responder STK authentication from MITM state Thread-Index: AQHcwFqJQtrYh5hoSEmSk6KlINzJ+Q== Date: Mon, 30 Mar 2026 15:33:19 +0000 Message-ID: References: In-Reply-To: Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=1seal.org; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DBBPR04MB7673:EE_|GV1PR04MB10584:EE_ x-ms-office365-filtering-correlation-id: de92fc76-a48f-4304-048e-08de8e71abd9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|1800799024|376014|38070700021|22082099003|56012099003|18002099003|7055299006; x-microsoft-antispam-message-info: 4jOcakEY3JwjCKzKa2rmugd9GmYEf8Bo97cRjn1BCExof179AWCKW+NsRhiYT5sINLsnaW49jRCyss8n/h/SzRNI181oZ4bm46++gR6sG1Y4UdxFOkV9qD75RnsIc9jD9yzTwOYxESpWfDYM0x1hmI/fKrjI7iJDJlcB4vwz6Mtt9DKmOT5jySSWsptXVUI1Nr76s0yF9taxAXxSVCQ5dzxl4yULn3isZPrjjOlH5mYtxKPm63F4x1IrFdWZAUEy1i+qWs3viVPqYNa/nd1FjgaUYhAeQT/THCqcsoDfxANsDSGyqS+W8bvm2wZZQP3GcDgN3lWLGNMpb1C9X6ITAFZKVz6db7Hi1UEapoTLzdRGw54W3EzeU0MJzwzQo8qOJBPBSa2oZGgQ/mi7R3UNfH8S++RmctbhM5L3p7XJYiTF0ZD6YyFK0NmcbJqRJOMo7jn9Jxxex3DDlSwZ2CtqmlzVbPtkPegCBs2ZxEHC879cS3TsrshiM64JUfKaqNX7UJyhPPXwJfaf8TdNxAuiyAsayj4BuRoS5tJlxKowI70v29AiIBbymN0e3Vc7ciFJw61+z6p8Fbs9hvl/ytsmqVtmeFGZMxotwi/wtZD+tjbOdNyYCbDpYwzUKqt4SnCYGBHFY+xxa+dZfqxtP/mgWluOm3w9z2Kpqg84F+ZyJ35S5lPt3sgKFmbWu0tfShzNMT7QuXY9oRW2YyYjABSKTFFGU7ZLFiyTAxhmvBgn/gJhbosqrFziEBTCPp4XkksOI2rP7pMleDQUeSrJpfL1bXDfPr0g5v+3j1zCxy7H2gDZnUlci/LEsUoFTGi9ioSb x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBBPR04MB7673.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(22082099003)(56012099003)(18002099003)(7055299006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SS83NWc5dlAyeWQ5cUpiWktvNkFZN0crbWNtQXc3UzN0b2htQ3J2ZTFTRlFw?= =?utf-8?B?RWZ6WjhjMmpxWnBrdnh5QUV3TEd5N1FLR00ybHp1dzhWb05UMm1YWHRTdFFn?= =?utf-8?B?K2VvK1I3NytXM2VQU0VGYnUzd0pOVEN5eXJPZjZ3clM3NUVRL0tYNU92bnV0?= =?utf-8?B?Q2gyRXU5K3hYWlZ5c1pKLy8wWGErdFZjL2xMUlpRUmpLdVBLY3R1eVIxR1R0?= =?utf-8?B?bGVESUNUWU5NRE5qd0RwVXpNVVROK0hWQU1KNlM5bG01MTRXT2REQUovc3gv?= =?utf-8?B?TkhQeWo0bGZRcUp4b1NGVXZqa3pPTlBjMEswNjF2UGlyUDM0bXBrMnQvZFpF?= =?utf-8?B?MGtETzFUZVJGV1JuZmQ4TjFqTzl4UjZ5UW1BZmErK2FMSU1WaWZsdVpUQ054?= =?utf-8?B?MkNjTkFwQ1B6S1JSMWw2L3V6QUhLN2M5OEM0d0JZT0R3VjU1K3U0WUdlQWVK?= =?utf-8?B?bXNpcHJmRkx5dkgwY3pFK2x3U25XQTFHWXhRS2R6VkFzQ2oyS3VlUXpiMkFh?= =?utf-8?B?dEdpc2ZWREpONU5uY3VLaVZGM3JBSXdoUGpxdU5yVDN6RlduUzhOMEZhRDQ1?= =?utf-8?B?eXovMzNmL3Z4ZzR6NWtrdTYxejdXcTlCcGRLSzdtYXhZQzhrNVQ3S2Q5aVRX?= =?utf-8?B?czhSSzRLYzNISTIySjJtUStaR1pKekZhbER5eWFwVDVWcTlSenRwVzhiOGFG?= =?utf-8?B?Q2kzazJsWElFNWd4ckdwM2x1V3pPdGc2bm5IM25DaTE1V0VhNXlHMGoxdDdV?= =?utf-8?B?Vkt5VVBaUXdYbDI1REI2Y3RqU1I2RGlSTDFGWkN4TWFlMEtVU01vSTJOOGc4?= =?utf-8?B?RjdHNTNDdmpDTTY1RFgxMlI1a01JSEVJMnhIV3VVeWVYVWFtQmJReTY5L09I?= =?utf-8?B?K1hoT0I5UzRaMTk5OXRCMjQ0aG9xdVBmODl6N1UyNDVjUWM0Z0d1bDV5LzFF?= =?utf-8?B?VjVxNkg2bnA0U0lsckdhVE5ROHhyTG44bngwcDFCYncxYWVNQTFwZ1lEOUFL?= =?utf-8?B?d0dFM1NpSmQrT2RrQ3ZtOEpyT2o2RDcxSGZaK0QvQmVRRm5nN0c4T1hUOUJ2?= =?utf-8?B?aHVyS1hndUtIUS9LallnNHBCelAwWlJkNnVFUlZBK2hYRGN5eEdBSEtuekk5?= =?utf-8?B?YWs3dVcxaHZkOU5kem1KZHExVG91ZGx4WjBhT3Z0bXRuSjRWUjFjSFozbzNN?= =?utf-8?B?OVo5M0NvNHZMNnhPQisvOGpmK2lYZ3R0MjRMRHNNNGhhK1dqQkdFUnNiZHN2?= =?utf-8?B?T2IvcWRFZ3kxZXFBTmVyL0svcENwOEJVSWhiQ2gyU1YrM0tLZzN2ekwrVFJH?= =?utf-8?B?cHFrZUdBRGxtQmhVTEdVQ25lWFptU1kvQ1N1ajhwV1dMWVMwbnM2R05PSFhs?= =?utf-8?B?UEZDdHRWSGdVdnA3ODYvUHJRalc2MEM3UGpBUXhacWMyVUdybnpUMjNhSjBl?= =?utf-8?B?S2NWOVVjMVo0UVhPeTJ4L3ovVVRMMEZ0SFdieVRnYkxHb0g3M0R6T2Q4ZmNL?= =?utf-8?B?ZzM4NUJVVFFpUmtycjhldm12TUpXczcvVzFqRHV4NUQyemxnbU44QXk1OExp?= =?utf-8?B?RUwwZ2VkMjRaMjJQWXZhWHBHTjZib3Q4ZFozWUd6S2E5M2NNVWQ4ci92VVl5?= =?utf-8?B?cklvY2tJMnVNVFpoUld1ZUJObEZjSXJhaUdMQzhOUW4zUDY3eWE2Q0lIU0dH?= =?utf-8?B?SGhvM3Q0Wng2eUxyZ0JWMVhQS2lkVmw2eGk2ajFzSXh2KzZqKzZvd2h2cEVK?= =?utf-8?B?Uk1ITE5Ja3cyRFY2bWJGWitOazBhcno2V25qNnFlTkR1eWdvemhsQ1lhOU1k?= =?utf-8?B?R0cvd09ram9mVjNDQ0NFcm00OHd4TWM1WUwxcUFQdDNDR0s0cForU1RPbTZu?= =?utf-8?B?ZSthMVhUb1QrUHN6SEZTY3dESWtlMHZ1azBNZWpadzk0bUZWcit4Rm1OU2Jo?= =?utf-8?B?NHVidkxyNk12ZDJKcjhZZWFBZDlvRHBNdGkyVXFJa3NaSnovSEdLMk0zZUhI?= =?utf-8?B?MTZadmdxczdmT3hKQXZDUWNlajA5SVJINmJyRHduS1B1M2o1bGFGY2hHem5O?= =?utf-8?B?QmlLT3RpLzdjZFVZdXhLd1F5S1ZTMHRWS3JnNFpJekwrZVRXVVc3dzI0OStH?= =?utf-8?B?TTFBRW1xTnRidFZxdkQrMVdPaU9EYnJOMkptZnV4eUk0bjRFUFBJYXhIVW03?= =?utf-8?B?RkNNdWV0OVgxb2plTEJ0U1lVMkx6d1ZVYTlxVkJxa096RzViKzY3MHBWeTgx?= =?utf-8?B?OCtQdFpxaXFCeUV1M1U4L1lUQ1hNQzgvWUJHYWlKa29zZmZuUjJTNUxENnNq?= =?utf-8?Q?/wOvy1SqVZG/wmdcTA?= Content-Type: text/plain; charset="utf-8" Content-ID: <00C6091365371A4E8628585CA0288076@eurprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: 1seal.org X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DBBPR04MB7673.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de92fc76-a48f-4304-048e-08de8e71abd9 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2026 15:33:19.5703 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e701d992-0f02-433e-a019-4256abe96ea1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PR60uyK1AUswrTemSZ6JFQYX/hGO/5ckOxSkKJPO/f2vssF3uFc2LoP6D4Il6gTs47gv8oy4yyE/MH1/yBBPIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB10584 The legacy responder path in smp_random() currently labels the stored STK as authenticated whenever pending_sec_level is BT_SECURITY_HIGH. That reflects what the local service requested, not what the pairing flow actually achieved. For Just Works/Confirm legacy pairing, SMP_FLAG_MITM_AUTH stays clear and the resulting STK should remain unauthenticated even if the local side requested HIGH security. Use the established MITM state when storing the responder STK so the key metadata matches the pairing result. This also keeps the legacy path aligned with the Secure Connections code, which already treats JUST_WORKS/JUST_CFM as unauthenticated. Fixes: fff3490f4781 ("Bluetooth: Fix setting correct authentication informa= tion for SMP STK") Cc: stable@vger.kernel.org Signed-off-by: Oleh Konko --- net/bluetooth/smp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c index a9fb9b513d6..0e20497988e 100644 --- a/net/bluetooth/smp.c +++ b/net/bluetooth/smp.c @@ -1019,10 +1019,7 @@ static u8 smp_random(struct smp_chan *smp) =20 smp_s1(smp->tk, smp->prnd, smp->rrnd, stk); =20 - if (hcon->pending_sec_level =3D=3D BT_SECURITY_HIGH) - auth =3D 1; - else - auth =3D 0; + auth =3D test_bit(SMP_FLAG_MITM_AUTH, &smp->flags) ? 1 : 0; =20 /* Even though there's no _RESPONDER suffix this is the * responder STK we're adding for later lookup (the initiator --=20 2.50.0