From nobody Fri Feb 13 19:30:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1459AE7D0A2 for ; Thu, 21 Sep 2023 20:41:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232153AbjIUUlW (ORCPT ); Thu, 21 Sep 2023 16:41:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232245AbjIUUlF (ORCPT ); Thu, 21 Sep 2023 16:41:05 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E793199B; Thu, 21 Sep 2023 13:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695327289; x=1726863289; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=j8I9xEhVY8G4DBx7Fus59ORWF9OXOGvs193SinT1foI=; b=LwjCAnJ137rH5XRwhcftBz4jCl1S0nkY7prTsUCfMFCTDsRuhLhxu3Ku DJ1uKoTsBixOBKYKhKe3vkT5bWzroUTahGx+95DH/Pw02++eqAdqelvTR 9Uu7uYG7z6O+HQ6UZFYp2pJXPx6Stw8oXaQ+l06W61Fz8uSatYEEkvXcr cgRsuFjxkVpMcL3Iz4k8DU0EkYUbQL18PMOD9i+bN3JemwMyGGUQzEvpt OSZNyHnUMe8Kf3smRMduiqvXdxAutPq9mDzVksCcQFxo9J3stsh/YmDD1 SJmRDTk1rbDExScqTuhP9FrB1t3kTUdjBOoaZG+5QpyZ4FS03MPxV2LZo Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10840"; a="383401598" X-IronPort-AV: E=Sophos;i="6.03,166,1694761200"; d="scan'208";a="383401598" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 13:14:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10840"; a="696897787" X-IronPort-AV: E=Sophos;i="6.03,166,1694761200"; d="scan'208";a="696897787" Received: from ls.sc.intel.com (HELO localhost) ([172.25.112.31]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 13:14:46 -0700 From: isaku.yamahata@intel.com To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: isaku.yamahata@intel.com, isaku.yamahata@gmail.com, Michael Roth , Paolo Bonzini , Sean Christopherson , erdemaktas@google.com, Sagi Shahar , David Matlack , Kai Huang , Zhi Wang , chen.bo@intel.com, linux-coco@lists.linux.dev, Chao Peng , Ackerley Tng , Vishal Annapurve , Yuan Yao , Jarkko Sakkinen , Xu Yilun , Quentin Perret , wei.w.wang@intel.com, Fuad Tabba Subject: [RFC PATCH v2 2/6] KVM: selftests: Add negative test cases for punch hole for guest_memfd() Date: Thu, 21 Sep 2023 13:14:35 -0700 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Isaku Yamahata Add test cases to check for punch hole of guest_memfd to reject unaligned offset or size. Signed-off-by: Isaku Yamahata --- .../testing/selftests/kvm/guest_memfd_test.c | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing= /selftests/kvm/guest_memfd_test.c index 75073645aaa1..d5b4bfcdc3fe 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -91,6 +91,37 @@ static void test_fallocate(int fd, size_t page_size, siz= e_t total_size) TEST_ASSERT(!ret, "fallocate to restore punched hole should succeed"); } =20 +/* Negative tests */ +static void test_fallocate_fail(int fd, size_t page_size, size_t total_siz= e) +{ + struct { + off_t offset; + off_t len; + } cases[] =3D { + {0, 1}, + {0, page_size - 1}, + {0, page_size + 1}, + + {1, 1}, + {1, page_size - 1}, + {1, page_size}, + {1, page_size + 1}, + + {page_size, 1}, + {page_size, page_size - 1}, + {page_size, page_size + 1}, + }; + int ret; + int i; + + for (i =3D 0; i < ARRAY_SIZE(cases); i++) { + ret =3D fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, + cases[i].offset, cases[i].len); + TEST_ASSERT(ret =3D=3D -1, + "fallocate(PUNCH_HOLE) with unaligned offset and/or size should fai= l"); + } +} + static void test_create_guest_memfd_invalid(struct kvm_vm *vm) { uint64_t valid_flags =3D 0; @@ -160,6 +191,7 @@ int main(int argc, char *argv[]) test_mmap(fd, page_size); test_file_size(fd, page_size, total_size); test_fallocate(fd, page_size, total_size); + test_fallocate_fail(fd, page_size, total_size); =20 close(fd); } --=20 2.25.1