From nobody Sat Sep 21 09:46:13 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B08D4C4332F for ; Sun, 13 Nov 2022 11:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235174AbiKMLK4 (ORCPT ); Sun, 13 Nov 2022 06:10:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232799AbiKMLKy (ORCPT ); Sun, 13 Nov 2022 06:10:54 -0500 Received: from jari.cn (unknown [218.92.28.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E9F83FAEF; Sun, 13 Nov 2022 03:10:46 -0800 (PST) Received: by ajax-webmail-localhost.localdomain (Coremail) ; Sun, 13 Nov 2022 19:05:16 +0800 (GMT+08:00) X-Originating-IP: [182.148.14.167] Date: Sun, 13 Nov 2022 19:05:16 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: wangkailong@jari.cn To: mchehab@kernel.org, matthias.bgg@gmail.com, hverkuil-cisco@xs4all.nl, moudy.ho@mediatek.com, sunke32@huawei.com Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: platform: mtk-mdp3: add missing call to of_node_put() X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT6.0.1 build 20210329(c53f3fee) Copyright (c) 2002-2022 www.mailtech.cn mispb-4e503810-ca60-4ec8-a188-7102c18937cf-zhkzyfz.cn Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Message-ID: X-Coremail-Locale: zh_CN X-CM-TRANSID: AQAAfwCHj+Btz3BjBiIDAA--.63W X-CM-SenderInfo: 5zdqwypdlo00nj6mt2flof0/1tbiAQAEB2FEYx0DfwAhsE X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following coccicheck warning: drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c:892:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 914. drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c:892:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 920. drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c:951:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 993. Signed-off-by: KaiLong Wang --- drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c b/drivers= /media/platform/mediatek/mdp3/mtk-mdp3-comp.c index d3eaf8884412..4162fc732f38 100644 --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c @@ -908,6 +908,7 @@ static int mdp_comp_sub_create(struct mdp_dev *mdp) alias_id =3D mdp_comp_alias_id[type]; id =3D mdp_comp_get_id(type, alias_id); if (id < 0) { + of_node_put(node); dev_err(dev, "Fail to get sub comp. id: type %d alias %d\n", type, alias_id); @@ -916,8 +917,10 @@ static int mdp_comp_sub_create(struct mdp_dev *mdp) mdp_comp_alias_id[type]++; =20 comp =3D mdp_comp_create(mdp, node, id); - if (IS_ERR(comp)) + if (IS_ERR(comp)) { + of_node_put(node); return PTR_ERR(comp); + } } =20 return 0; @@ -988,6 +991,7 @@ int mdp_comp_config(struct mdp_dev *mdp) =20 pdev =3D of_find_device_by_node(node); if (!pdev) { + of_node_put(node); dev_warn(dev, "can't find platform device of node:%s\n", node->name); return -ENODEV; --=20 2.25.1