From nobody Mon Feb 9 08:30:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FEAEEB64DD for ; Tue, 25 Jul 2023 22:16:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231475AbjGYWQl (ORCPT ); Tue, 25 Jul 2023 18:16:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231186AbjGYWPl (ORCPT ); Tue, 25 Jul 2023 18:15:41 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DF45E47; Tue, 25 Jul 2023 15:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690323340; x=1721859340; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MkHfcpMwySOcGOfR6N8gvbfjq2Uw4EljfqsyyqkNNzc=; b=dKTqci6BL8cNhhwZQ/dgGUETXmdI6CyBD8rkg3FyvTH4tCMryM/DC8Pv E8ztLwB+oZ1TR1gCF+FO2lWowcLHmcD3utvRvo71KTYwUIVXgimQK3abr dSu2WiRu5RFKzZ7VvEUMZvIIDBQOHUL8ffzKvcPTMAhfV84nGvNRI03UO X3oUAAPVJQzAU6YwtP6an+YxhJOmOmzfGxEfYo86bWhOlNu8nzEkZ0wPZ Cm8IS3V67SPEVvpXBYwiJFt3B/wmsE/KwoldvNRT/aSditNRWXRaH1PXb 8apzf1KxVb/Ds8C7xdexUPumm2xDsvdB9Nmmm0gIWc/vyWdJZnwrhT1+/ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="357863087" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="357863087" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 15:15:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="1056938803" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="1056938803" Received: from ls.sc.intel.com (HELO localhost) ([172.25.112.31]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 15:15:19 -0700 From: isaku.yamahata@intel.com To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: isaku.yamahata@intel.com, isaku.yamahata@gmail.com, Paolo Bonzini , erdemaktas@google.com, Sean Christopherson , Sagi Shahar , David Matlack , Kai Huang , Zhi Wang , chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com Subject: [PATCH v15 012/115] KVM: TDX: Retry SEAMCALL on the lack of entropy error Date: Tue, 25 Jul 2023 15:13:23 -0700 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Isaku Yamahata Some SEAMCALL may return TDX_RND_NO_ENTROPY error when the entropy is lacking. Retry SEAMCALL on the error following rdrand_long() to retry RDRAND_RETRY_LOOPS times. Signed-off-by: Isaku Yamahata --- arch/x86/kvm/vmx/tdx_errno.h | 1 + arch/x86/kvm/vmx/tdx_ops.h | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx/tdx_errno.h b/arch/x86/kvm/vmx/tdx_errno.h index 56cfd2f558fa..53dc14ba9107 100644 --- a/arch/x86/kvm/vmx/tdx_errno.h +++ b/arch/x86/kvm/vmx/tdx_errno.h @@ -14,6 +14,7 @@ #define TDX_INTERRUPTED_RESUMABLE 0x8000000300000000ULL #define TDX_OPERAND_INVALID 0xC000010000000000ULL #define TDX_OPERAND_BUSY 0x8000020000000000ULL +#define TDX_RND_NO_ENTROPY 0x8000020300000000ULL #define TDX_VCPU_NOT_ASSOCIATED 0x8000070200000000ULL #define TDX_KEY_GENERATION_FAILED 0x8000080000000000ULL #define TDX_KEY_STATE_INCORRECT 0xC000081100000000ULL diff --git a/arch/x86/kvm/vmx/tdx_ops.h b/arch/x86/kvm/vmx/tdx_ops.h index 76eddecdca12..d588a5507f5a 100644 --- a/arch/x86/kvm/vmx/tdx_ops.h +++ b/arch/x86/kvm/vmx/tdx_ops.h @@ -6,6 +6,7 @@ =20 #include =20 +#include #include #include #include @@ -17,9 +18,14 @@ static inline u64 tdx_seamcall(u64 op, u64 rcx, u64 rdx, u64 r8, u64 r9, struct tdx_module_output *out) { + int retry; u64 ret; =20 - ret =3D __seamcall(op, rcx, rdx, r8, r9, out); + /* Mimic the existing rdrand_long() to retry RDRAND_RETRY_LOOPS times. */ + retry =3D RDRAND_RETRY_LOOPS; + do { + ret =3D __seamcall(op, rcx, rdx, r8, r9, out); + } while (unlikely(ret =3D=3D TDX_RND_NO_ENTROPY) && --retry); if (unlikely(ret =3D=3D TDX_SEAMCALL_UD)) { /* * SEAMCALLs fail with TDX_SEAMCALL_UD returned when VMX is off. --=20 2.25.1