From nobody Thu Apr 2 12:22:22 2026 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B37F34BA42 for ; Mon, 23 Feb 2026 07:34:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771832068; cv=none; b=cyZ72njV+tq11SiHyFHvPWUpPFyV1QZAnWRoOqLaxOdcDbMhHhbUqWA8QHZkh0D9VMSIJP0ZWXLzMyl1qozczvOm7UwzlYn4nQhu1kuR9QCHWuofdDvmFxeAOmuA2IFZGC+FfSWL4o52M6Cill0dHioZclBovLMJp6OveY6aGjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771832068; c=relaxed/simple; bh=iq53DsPecxUJv9f/n8TBeugQc53j2Da8dw7zuDKVyiI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=FeX37oQF9j/zYetEPb23xTePXR4dR9js2OgNHPAf/CZtsnyixWkUepfKa/UPhIIExVYfcrTM10UjnJ+j8fc6mJz6CcPLBwBbauuw3FzxsKH34SaAFbnbzC11n2irfHajDMUjkjRw/Yxh6xIAsfDtMzAq10hcHu4ZduuiL85edok= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Wr9mKf6G; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Wr9mKf6G" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-3562171b56dso4441513a91.2 for ; Sun, 22 Feb 2026 23:34:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771832066; x=1772436866; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=H4IDTTN2imEE24tZz4W9ct9niFiZM+M1v4/EEqKS/dA=; b=Wr9mKf6G1NW6hbUa9sz4KKHVwn2byXn5Bh8UQ9qmm3g8Gu0b+i8GaaDfqDiTs8og+E LuG0pXvdJN8s18X3ddmUEg24eUh3uYXd10a/BL4pknZKCHjGZ0RZ41mOasI/6V0gKb+2 5gXcvEtypUnCEjmd3h9sYWqB/TbQdbF08D/z5WNZGi4v9XdQ+yrqfTkP4TlR1YpOXjue lbuSZEyEz4q2EelKW8pT9QEtGTxgEW8kBTYxxCAHJaU4Ljz90PiHq0fEPXR82shLOCHb 6gWT7h6A6wh4jN61LBxwSJQZ0qs1muDPVMK2P64LFR5UtaaVeiz3VvGiqZzO+iTV/h7g FOjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771832066; x=1772436866; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H4IDTTN2imEE24tZz4W9ct9niFiZM+M1v4/EEqKS/dA=; b=exLuyfYzF9JIqdzryvVE227Q8TZVY/d8q7k1+ALRNsqysi1OIc7NIO8ZQi9kAaxJ2f rG7xh00ftf9Rt9cY6kNCBDK3COwIbB5nHs6FuzTi1MIeqMu03VRDRqR4e6QGwrjJMhtt a6qhPzhg6q8/3myaFwa1FhemZ+bVx+Wl5S/klSfLYwNbzQzTARn5oRMQUFp/+VqSlVQU HzKffwnv4ekqMOpM2jEBCCbhMPtZyYZEqtmCfJXaBUPwIa2RnTvEBozlJi+pzkxiBd+Z FqgfF/SeEUYLJagVJHDbrIHG3DGVFfMR6wuzF20yPuELeftS/ERjxSzwUTW/Iqgmpb6P H8Mg== X-Forwarded-Encrypted: i=1; AJvYcCUJ4igIVDqVkYeZEvIp6RoAJNRftclsRhO+P+ybLq+4PXJJYFJZCSgq37t2u7RFQxeBmXxym02VELzEMhA=@vger.kernel.org X-Gm-Message-State: AOJu0YzJ7nkCM9iRLmoF4u+i1iFpSVOY+ZWeDkG5zjmWmOaa/+GyLntr oEsPBnILyBDYWFiP15fcs3wZaRCTZfCmMbDPqpIH/vAKnra2IZgVuYlz5fSJTV38Vjc9OA92K88 7j2GwNlY9C7x7XWtMV0qcRXwH3Q== X-Received: from pjbbx20.prod.google.com ([2002:a17:90a:f494:b0:34c:dd6d:b10e]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:17c8:b0:353:6373:590b with SMTP id 98e67ed59e1d1-358ae7c352bmr6655610a91.7.1771832066318; Sun, 22 Feb 2026 23:34:26 -0800 (PST) Date: Mon, 23 Feb 2026 07:34:14 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.53.0.345.g96ddfc5eaa-goog Message-ID: Subject: [RFC PATCH v3 2/2] XArray tests: Verify xa_erase behavior in check_split From: Ackerley Tng To: willy@infradead.org, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: david@kernel.org, michael.roth@amd.com, dev.jain@arm.com, vannapurve@google.com, Ackerley Tng Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both __xa_store() and xa_erase() use xas_store() under the hood, but when the entry being stored is NULL (as in the case of xa_erase()), xas->xa_sibs (and max) is only checked if the next entry is not a sibling, hence allowing xas_store() to keep iterating, hence updating node->nr_values correctly. Add xa_erase() to check_split tests that verify functionality, with the added intent to illustrate the usage differences between __xa_store(), xas_store() and xa_erase() with regard to multi-index XArrays. Signed-off-by: Ackerley Tng --- lib/test_xarray.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/test_xarray.c b/lib/test_xarray.c index e71e8ff76900b..bb9471a3df65c 100644 --- a/lib/test_xarray.c +++ b/lib/test_xarray.c @@ -1874,6 +1874,10 @@ static void check_split_1(struct xarray *xa, unsigne= d long index, rcu_read_unlock(); XA_BUG_ON(xa, found !=3D 1 << (order - new_order)); =20 + for (i =3D 0; i < (1 << order); i +=3D (1 << new_order)) + xa_erase(xa, index + i); + XA_BUG_ON(xa, !xa_empty(xa)); + xa_destroy(xa); } =20 @@ -1926,6 +1930,10 @@ static void check_split_2(struct xarray *xa, unsigne= d long index, } rcu_read_unlock(); XA_BUG_ON(xa, found !=3D 1 << (order - new_order)); + + for (i =3D 0; i < (1 << order); i +=3D (1 << new_order)) + xa_erase(xa, index + i); + XA_BUG_ON(xa, !xa_empty(xa)); out: xas_destroy(&xas); xa_destroy(xa); --=20 2.53.0.345.g96ddfc5eaa-goog