From nobody Sun Dec 14 05:56:50 2025 Received: from mail-ed1-f74.google.com (mail-ed1-f74.google.com [209.85.208.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C25211DF240 for ; Fri, 7 Feb 2025 11:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738928482; cv=none; b=muPsKiqOQw/wdJIHay9PcuoLUMv1ucDDSEwbwsm1a6Nl8H6bgXrSeS7QOMS6bVT73yI+2VsykcASxU/OzzR39JSswGyaFD92LQ1U80Dwk401wysFkuhRemuKln9eMpUgay9aCAv+tZ+6iEjLRe1VadY6sHPqW9tUkqLthj3t124= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738928482; c=relaxed/simple; bh=JrTATGJXLXPnfT36NRdWEwRMkJqStLNhLoyrpg87QNc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=GfzDa83vfRfixsOe7HJMS+rv4G9aiCDSGDOydxVQzZUCm5Xk6+PnDF0MGIrEYR/HBsxAGZP12MHa7TX6GYvc22Gy5H0CjZfwFhaGkiFe316z/9TvP5kd58O5pKqx1IU81DS50TcBGhEjTmJYSu8HhW/MdVIGHt8gm/DFzGdzaWI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--dvyukov.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=na2zzlSX; arc=none smtp.client-ip=209.85.208.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--dvyukov.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="na2zzlSX" Received: by mail-ed1-f74.google.com with SMTP id 4fb4d7f45d1cf-5de4a465673so628145a12.2 for ; Fri, 07 Feb 2025 03:41:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738928479; x=1739533279; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mjAFE95s2BudHj4Rh3WJBU6cX4YpZYt+tVJ8vz3xHhE=; b=na2zzlSXYcHHR4lHoiGdO/j4aWe9LmrbRs6/Ys/1VRZJB7B/xVfTzivc2p7gBHTtre FvLpP4SD3NsKMf+r2jne2AeZVnDGidfIfNCLuOeFzk+SMbvQrv/fMbhSQRshvhMwENbF CwC2Mw7+MIymbMPMJ2YCiEe8vXkI+RCePs+CLgH0LJxeL7g51vnAlfQ6OJRSFeJnlIiu OTMIM9UfUxBC3GACwZ9KiOCYMeS9bGARAn85jF4ZAQh0DXPtc9soasCXoyDDruHGepL+ BeWGZyNITWbctDfq5fHC5fEoLj7sX4xrOt2QOrw865xZkpDPkRpGYaPyP2sJNBl5vdAZ ep2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738928479; x=1739533279; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mjAFE95s2BudHj4Rh3WJBU6cX4YpZYt+tVJ8vz3xHhE=; b=DcstEfK8DwvH6cCdziCt3fy7Abs+GXt5SMg2ADFWVL7C2hLRVT+1mjiGndYg0SVTOc R22Noe1WMXKxogp/kSzw8d2L1RoymmRhT/0tBl0PkuW7d1EBI8aYvfcMotS85aOX78R6 MphUOBvI7rLYkm7RFUafyFV1o2yJaWvATblrmgKhYGkYxKxfbMUQc4N9qc7nJsq5WvQ/ 4QdAWE+bOytVvX8PyLrg1Uf/tDpqhaiXkF3oTQD4kgh89FeGFY+6Ex9kAZ+3s9WYJaeI QZDyOP8z8ijR4T62WfULj/+/qUnXM9EXwZG7XI4Od9kSDCa88djkvEqs7r0XWM84X3pr a/gA== X-Forwarded-Encrypted: i=1; AJvYcCWUYBY+vUijQY3vCNfR3wSzSYcQwdstGDXJvklC1z+9y6PnTOAkvHoyrFDl8cWEveDgkEt3dHUlCHS+XnU=@vger.kernel.org X-Gm-Message-State: AOJu0YzgSA9q7rZpirX9e2duF3qA296VQ8nXZAFPkt/FH3NnXLuuqq+S scdhyU+l8qEG2NZrBs8f2IgC4qfLxbCKdK4IzXE8+LnPRhr2pjCwgkBtXYuRJ3ncB6yGaPzAE38 xyC4F8A== X-Google-Smtp-Source: AGHT+IHMCaxJwhN3b35vofvhjLQWUnuYR19i1hbqbz2zViRW2xF8n0bIBTGUvJ0aty3IvlWxGQQSnNt3z9Cv X-Received: from edat9.prod.google.com ([2002:a05:6402:2409:b0:5dc:de15:859c]) (user=dvyukov job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:210e:b0:5dc:ebf3:b967 with SMTP id 4fb4d7f45d1cf-5de451074f3mr3228263a12.23.1738928479229; Fri, 07 Feb 2025 03:41:19 -0800 (PST) Date: Fri, 7 Feb 2025 12:40:30 +0100 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.48.1.502.g6dc24dfdaf-goog Message-ID: Subject: [PATCH v6 3/9] perf report: Switch filtered from u8 to u16 From: Dmitry Vyukov To: namhyung@kernel.org, irogers@google.com, ak@linux.intel.com Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Vyukov , Arnaldo Carvalho de Melo Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We already have all u8 bits taken, adding one more filter leads to unpleasa= nt failure mode, where code compiles w/o warnings, but the last filters silent= ly don't work. Add a typedef and switch to u16. Signed-off-by: Dmitry Vyukov Cc: Namhyung Kim Cc: Arnaldo Carvalho de Melo Cc: Ian Rogers Cc: linux-perf-users@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- tools/perf/util/addr_location.h | 3 ++- tools/perf/util/hist.c | 2 +- tools/perf/util/hist.h | 4 +++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/addr_location.h b/tools/perf/util/addr_locatio= n.h index 36aaa45445f24..f83d74e370b2f 100644 --- a/tools/perf/util/addr_location.h +++ b/tools/perf/util/addr_location.h @@ -3,6 +3,7 @@ #define __PERF_ADDR_LOCATION 1 =20 #include +#include "hist.h" =20 struct thread; struct maps; @@ -17,7 +18,7 @@ struct addr_location { const char *srcline; u64 addr; char level; - u8 filtered; + filter_mask_t filtered; u8 cpumode; s32 cpu; s32 socket; diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index cafd693568189..6b8f8da8d3b66 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -585,7 +585,7 @@ static struct hist_entry *hist_entry__new(struct hist_e= ntry *template, return he; } =20 -static u8 symbol__parent_filter(const struct symbol *parent) +static filter_mask_t symbol__parent_filter(const struct symbol *parent) { if (symbol_conf.exclude_other && parent =3D=3D NULL) return 1 << HIST_FILTER__PARENT; diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h index a6e662d77dc24..4035106a74087 100644 --- a/tools/perf/util/hist.h +++ b/tools/perf/util/hist.h @@ -33,6 +33,8 @@ enum hist_filter { HIST_FILTER__C2C, }; =20 +typedef u16 filter_mask_t; + enum hist_column { HISTC_SYMBOL, HISTC_TIME, @@ -244,7 +246,7 @@ struct hist_entry { bool leaf; =20 char level; - u8 filtered; + filter_mask_t filtered; =20 u16 callchain_size; union { --=20 2.48.1.502.g6dc24dfdaf-goog