From nobody Wed Jun 17 07:35:24 2026 Received: from ha.d.sender-sib.com (ha.d.sender-sib.com [77.32.148.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 601E92F25F0 for ; Thu, 23 Apr 2026 19:32:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=77.32.148.27 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776972771; cv=none; b=cfjvR+EC1R1ISIr9UA+ZinRNG1k1J3tDrHJI1gzdMuGmteK5LvmeoiVKixZKvNjSnQvQEkkdpg6qAP7W81ffD6V5bYeMrTQNf/if6jV/JMuCMDe6nocc7bY1CJVefxJ+Nq5VHyQyjVHa3D6ArXb0gLQ+rFzCOlARwiVb3e7HBOA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776972771; c=relaxed/simple; bh=TJyFQDkT7b3c+oKe9CG3gPgrXFOx5h7CfyFvxRoK58w=; h=Cc:Message-Id:From:To:Date:Subject:Mime-Version; b=dTGGsLctk5jcJ8sP0oY7JwdukOoYPKCvO0TOoldB7k1xvSXQ6AAK+hOOyoPZ4pRKxtb4nyb4Tt4pK9vW/xRJBMnWqeHjA9e75VhqGUrCPtjF+cWHMT5Hy/ExcVimwZYrP/6o7o8Oc6yE49t0LmWDIhp4YWBYrURArYIsFudTtew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=unknownbbqr.xyz; spf=pass smtp.mailfrom=ha.d.sender-sib.com; dkim=pass (2048-bit key) header.d=unknownbbqr.xyz header.i=@unknownbbqr.xyz header.b=Xt6okq6M; arc=none smtp.client-ip=77.32.148.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=unknownbbqr.xyz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ha.d.sender-sib.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=unknownbbqr.xyz header.i=@unknownbbqr.xyz header.b="Xt6okq6M" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unknownbbqr.xyz; q=dns/txt; s=brevo1; bh=+fxAP06mWX2K+fo2gvpsSa8UERkEhD861J/6cN+s1N4=; h=from:subject:date:to:cc:mime-version:content-transfer-encoding:list-unsubscribe:x-csa-complaints:list-unsubscribe-post:message-id:x-sib-id:feedback-id; b=Xt6okq6MCJclWGSN1dKPGuY4UG4T9mmaee3njJ+fDCd8TDibfNUakpoqUwVNn8npBe12EmyMpf5h V1bkC7oh+EQYES80GSDo5JpN5m3C2cYVyisyAXjiYQqsmad8BiLILC7D9BMAxS9yHhQeAXUA+RPr ePASFWrHUqdfzCCExSwZvnTaZANIqTTlOi0doxY8neP744wOMmKeLtHFNkH2tfe7eDfmYPBuaOLf +CjtSjYDkkyWsPlfgARa2e+lhSgpNFQsSF+J3XaanTmxQW+D7EihTtQOo7M96/5C88VMzvCGWRrC uYDYyImU/i3xfAXOHlD4fux+UiJ8KCTUud7CSw== X-sib-id: glXlr8loqJ-OVQM5dqfvAtlUqv6Zk27VYXEhlbgUT23U55agUHC3zmwA-idbnJVSkyy2R-3ktiPFEDIpBmNj7Pg_tnWvBbZ08hkv3MHBosOIjNLH2Ab7S_sr1RjO0JNiDPCKxkWGTuXbmBa07AxmuF1J_78DzZefTjr1eeKe2wm-8QsHFiBD-wusfA Origin-messageId: <20260423193238.364-1-dev@unknownbbqr.xyz> List-Unsubscribe-Post: List-Unsubscribe=One-Click Feedback-ID: 77.32.148.27:10473219_-1:10473219:Sendinblue X-CSA-Complaints: csa-complaints@eco.de X-Mailin-EID: NDQzNzMzMzgyfmxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmd%2BPDIwMjYwNDIzMTkzMjM4LjM2NC0xLWRldkB1bmtub3duYmJxci54eXo%2BfmhhLmQuc2VuZGVyLXNpYi5jb20%3D Cc: , , "ali" Message-Id: From: "unknownbbqrx" To: Date: Thu, 23 Apr 2026 22:32:38 +0300 Subject: [PATCH v2] tools/power/x86/intel-speed-select: Harden daemon pidfile open Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.53.0 Content-Type: text/plain; charset="utf-8" From: ali Avoid symlink-based pidfile clobbering by opening the pidfile with O_NOFOLLOW and validating it with fstat() before locking/writing. The daemon currently uses a fixed pidfile path under /tmp. A local unprivileged user can pre-create a symlink at that path and cause a root-run daemon instance to write into an attacker-chosen file. Signed-off-by: ali --- tools/power/x86/intel-speed-select/isst-daemon.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tools/power/x86/intel-speed-select/isst-daemon.c b/tools/power= /x86/intel-speed-select/isst-daemon.c index 66df21b2b..4346b049d 100644 --- a/tools/power/x86/intel-speed-select/isst-daemon.c +++ b/tools/power/x86/intel-speed-select/isst-daemon.c @@ -200,11 +200,21 @@ static void daemonize(char *rundir, char *pidfile) if (ret =3D=3D -1) exit(EXIT_FAILURE); =20 - pid_file_handle =3D open(pidfile, O_RDWR | O_CREAT, 0600); + pid_file_handle =3D open(pidfile, O_RDWR | O_CREAT | O_NOFOLLOW, 0600); if (pid_file_handle =3D=3D -1) { /* Couldn't open lock file */ exit(1); } + + { + struct stat st; + + if (fstat(pid_file_handle, &st) =3D=3D -1) + exit(1); + + if (!S_ISREG(st.st_mode)) + exit(1); + } /* Try to lock file */ #ifdef LOCKF_SUPPORT if (lockf(pid_file_handle, F_TLOCK, 0) =3D=3D -1) { base-commit: 2e68039281932e6dc37718a1ea7cbb8e2cda42e6 --=20 2.53.0