From nobody Mon Apr 6 09:13:17 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 770E3244694 for ; Sat, 21 Mar 2026 10:13:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774088018; cv=none; b=lKIZjALR4GVp0Tc5zU+p4CpZQfJ5ERas3cEpxrs22Wl7nDXfA7YotywkWy+sIqKNw8GcyihOWoQlqVv4CGZaEjU25CWU65cGgLzukYVF81MHex9LeG5DzSZkfhrMRv8hKF4hDIQw9TBKS3H1Gm/9wX5VErEB65xnIxJ3qY+N0RI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774088018; c=relaxed/simple; bh=1uqFyv8sNbH4yrRykxbOsgxCTnxvIECLXyk/dbgpM28=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mApSnBjiPm6BB3PVPbMlt1a4wJPc7ZjtBbzs7jqC09I2ERu5rbBYzq4rkKHRof/A8lQedoxnuTfD1nK5dDqCURJBoGRZt+a0pzvgQ0j+1wsH6gngft/MBp6ve7Nq1fl1HXKU043DsxB0z4leg2cIWEB+KvnObndtlU+tU8McXCk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wJOEuiSS; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wJOEuiSS" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43b4fd681c2so2234604f8f.3 for ; Sat, 21 Mar 2026 03:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774088016; x=1774692816; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KBfrdJJUZs1LM9q6ioHXhMJzsujMA5jyt7cbTuG7Xhg=; b=wJOEuiSSowi0Q7rGHF2IV5nTSoGDk2ru12R/y58eR6M90/bxDs45Ddj/xTuHZM3i1V LjFfz3MPP5up7iXE7GMv64gx3T0RaaenFq8wG9CD7uZ1CLjA/QV2lQnMprAj/SLgEhqY YsncC5z86CYktnl/6zOus2Dn66antTwjGc1hy4hI8AAQiayVVNOQseS3DjVnHCFQmYrg vfgXgxYXwNQnBN2b71PMgQCQgAgLhumfPKPBa5niTO6o9QKDSTO7LQ231vOWLEMITwFB a9FpjAso7jGSE1RLjGLSftVZ3UlrrexXO6flZz0vfMkp4xjE1mmSsRYQbQhRlQFlDpUx WUYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774088016; x=1774692816; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KBfrdJJUZs1LM9q6ioHXhMJzsujMA5jyt7cbTuG7Xhg=; b=q+0P/PEPr3YLx9b0v42gUn29E5vBX9yHfGXk8GCSWVmX2QtT8U4dJbI05W8uJZAXL7 tBLAlcFCK8r1txM/cwJaHdRUgx9H2sF8Ua13nSuwTH/PcNctHo7q82BQmjawTZSVv7KQ DxP8SqYyIXpY+y2X7MxqlZsm2pbP9k7vBBKXJThmQTa3j/JqFyksqy5SmeE0v1lc3bSV /SRN1xZENOWqbYuqMOGaRYGwZU//hLDXRK9XpkXGiy3M/zV0ycYkg/SclZobTAjqrrQI NUwSh63VlX1fgLxvRAhmsEjATRtEdzCJa86DYVkEvb5Q+N94Xn3xn+WgSw62640rktVe HYSA== X-Forwarded-Encrypted: i=1; AJvYcCXkY8fESZE4gqjxIYTSZ+I5K7ElA9aRjuTTqQgcQ6BsdfRXstk75hR9KDKmeZ8r3zvSK5VSfgRViGJrKjo=@vger.kernel.org X-Gm-Message-State: AOJu0YxKiIh36esIn+r2hqFHhZCN+CWi++JKnORCuKjiA1bg8epby4lk vSFfo2JPmBliVUx/Q9N8RfPLjIyQpH3R/TcgNknXL95Bdf27zkXAOXBwtkocI0cs5no= X-Gm-Gg: ATEYQzzPdQUXXaOfDpUxptm9JF++3ZCobGaZBmGx/h+MNJdzYR4K0jmYUrKxDpu9V5X jeCGiDK6gVxldlbgkYjILXlrr0X4cBIGx69sB4X5yk/Y1Rd4npjBQ5MxYvQrBMO44uZuwLL2z/e bBjwOqDY2IIvjxlabwK3Xbws//m2AQq520D+0vfS1JNU/pwMHLJQneRka4R8Btd2rCmst2WlG1Z GQBi7AVS2Zc/igMBm2cNwYU4f8G8NYQSVit714CQVZF58cgnflqjE9O8TaFOHGvOlgu3+dcSgEJ 7e7ElFfbc9XsxX86SC2Ix5OOARv+ekmw9DwhJjoyHmoEUrbrK+Ri+js+8qJb6OdOSjAbiTEowub pjwkW2x/jN/AYvlLl9jbCUH0Vlzo8ar1Ia7J56qEBfwn3ZltMWRMLSpPBRDrRWLOdf3dsGNDX4p /49pIMx3jX02HT9Sc8xFk10MWGxkWjez3feuZSF1M= X-Received: by 2002:a05:600c:c16e:b0:485:4eaf:eb53 with SMTP id 5b1f17b1804b1-486fee0f975mr77117095e9.19.1774088015816; Sat, 21 Mar 2026 03:13:35 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-487004fee41sm47800325e9.3.2026.03.21.03.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 03:13:35 -0700 (PDT) Date: Sat, 21 Mar 2026 13:13:32 +0300 From: Dan Carpenter To: Sudeep Holla , AKASHI Takahiro Cc: Cristian Marussi , Linus Walleij , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Bartosz Golaszewski , Vincent Guittot , Khaled Ali Ahmed , Michal Simek Subject: [PATCH v5 2/7] pinctrl: scmi: Add SCMI_PIN_INPUT_VALUE Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The PIN_CONFIG_LEVEL parameter represents the value of the pin, whether reading or writing to the pin. In SCMI, the parameter is represented by two different values SCMI_PIN_OUTPUT_VALUE for writing to a pin and SCMI_PIN_INPUT_VALUE for reading. The current code translates PIN_CONFIG_LEVEL as SCMI_PIN_OUTPUT_VALUE (writing). Add a function to translate it to either INPUT or OUTPUT depending on whether it is called from a _get or _set() operation. Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Acked-by: Sudeep Holla --- v5: no change v4: add r-b tags v3: new patch drivers/pinctrl/pinctrl-scmi.c | 33 ++++++++++++++++++++++++++------- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c index f4f296e07be5..5d347e6b2e4c 100644 --- a/drivers/pinctrl/pinctrl-scmi.c +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -251,9 +251,6 @@ static int pinctrl_scmi_map_pinconf_type(enum pin_confi= g_param param, case PIN_CONFIG_MODE_LOW_POWER: *type =3D SCMI_PIN_LOW_POWER_MODE; break; - case PIN_CONFIG_LEVEL: - *type =3D SCMI_PIN_OUTPUT_VALUE; - break; case PIN_CONFIG_OUTPUT_ENABLE: *type =3D SCMI_PIN_OUTPUT_MODE; break; @@ -276,6 +273,28 @@ static int pinctrl_scmi_map_pinconf_type(enum pin_conf= ig_param param, return 0; } =20 +static int pinctrl_scmi_map_pinconf_type_get(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + if (param =3D=3D PIN_CONFIG_LEVEL) { + *type =3D SCMI_PIN_INPUT_VALUE; + return 0; + } + + return pinctrl_scmi_map_pinconf_type(param, type); +} + +static int pinctrl_scmi_map_pinconf_type_set(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + if (param =3D=3D PIN_CONFIG_LEVEL) { + *type =3D SCMI_PIN_OUTPUT_VALUE; + return 0; + } + + return pinctrl_scmi_map_pinconf_type(param, type); +} + static int pinctrl_scmi_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin, unsigned long *config) { @@ -290,7 +309,7 @@ static int pinctrl_scmi_pinconf_get(struct pinctrl_dev = *pctldev, =20 config_type =3D pinconf_to_config_param(*config); =20 - ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + ret =3D pinctrl_scmi_map_pinconf_type_get(config_type, &type); if (ret) return ret; =20 @@ -363,7 +382,7 @@ static int pinctrl_scmi_pinconf_set(struct pinctrl_dev = *pctldev, =20 for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); - ret =3D pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[i]); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); goto free_config; @@ -405,7 +424,7 @@ static int pinctrl_scmi_pinconf_group_set(struct pinctr= l_dev *pctldev, =20 for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); - ret =3D pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[i]); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); goto free_config; @@ -440,7 +459,7 @@ static int pinctrl_scmi_pinconf_group_get(struct pinctr= l_dev *pctldev, return -EINVAL; =20 config_type =3D pinconf_to_config_param(*config); - ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + ret =3D pinctrl_scmi_map_pinconf_type_get(config_type, &type); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); return ret; --=20 2.51.0