From nobody Sun Feb 8 15:46:19 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3705329A9E9 for ; Wed, 28 Jan 2026 09:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769594048; cv=none; b=XrMNBY4XagBc7XqOW00EUc0Bgii13WbwB6Tnd+BgaToJ+xVIg1ukg3Yrgv9VAMPRm2TVhWGpGTriASvmBCEzm7sWF76y4yA8qECLfRvTiAq5M9kUPutxhh9RR809F8wRR2GZBYI6afJAYQYdbPCd2oxmj0rF+EGiU9F12gPCmSg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769594048; c=relaxed/simple; bh=iUYNzaQn+dgqqmhuq2Vji7cyU4pKHLtBGG8gHzmw9NM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l/Tp0ZVw8Ut41PhP+zMKbYr9y8rTBbQkj8ych4iMg5Bs6m3x902Bml4qpZiZrGXnunOxWiVtzsAac+9tKeyJCuRgn7CtiYSDcbz/BhL0FXx89FloJ0kod6O89wrp+n1Sq5Qz3iBKf3Ov4bnzMTyw6ZJM4vsOo40872dK+2miIio= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SyWryHYQ; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SyWryHYQ" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-48039fdc8aeso35033995e9.3 for ; Wed, 28 Jan 2026 01:54:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769594045; x=1770198845; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/27C/CNBZB5U2mainQlNU7Fdsq/MruiST5P1Ff/65Ew=; b=SyWryHYQuKNBzalXBLMos7RsCjeBesQqIc4mQFkD50uKKKN49ufwSG5eYB/tDNkDCY VDtERV/SdQtK0/OpSFiTMZnqAgSfYynu9Pzjy+vKN426Rf9+Ls0oZcaROKdutaMy69qU lhQk+u6u1qCtCrnoccEa/1nONZxoVlVNTvJ2XuGS9bbKA1gRbeSuVx3hvSqC4w8SGfJw nWI6waavJza0Pzo5dHS7q9oidWjcZU7wPJHNusLQbtkZJBMPNNpstRGICwaBrYcO4TP6 wOkXgi6oP0Pp8pvV4OvEPo3Sl3tCvrVAGLSM8EfgAlz75FHfGlNrvDtJaZCJk4qp8aUX 5tMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769594045; x=1770198845; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/27C/CNBZB5U2mainQlNU7Fdsq/MruiST5P1Ff/65Ew=; b=q0h6Bf16rRSidgUFZvFEyOOY1uaw44+kTiEf18Ol4clDzSwUq17IcGsyTyZYXXYkif /3LgIt00KQ0B7JznG8DfVti/N6Nx2Fxaet7w+oiMrHXfqYha9sJ9rIL8tHDz+M5vA6sG 4Y+cIIYJ5Ia0TUBOaeZlDf82lRZ4sO838btnapqerqz8JbYyHXU7m5g4DrS+1dI1nY+a BFaKRL7vdCky8WSjTyqfdsCxQzxzx4rEPrhIKRIChEph5Se9fHn2mHtC9SBgk8irNU6i Y3GWBTn+Opq+1DvMu/D6Uw2ky3BgzCkLDTAJbzDWdtC+TkUUVSJaiVf0RCTYp+GUqH6H Rrog== X-Forwarded-Encrypted: i=1; AJvYcCWdoXhG1yeeXF9+7l4O+zfhJ8z9aSagORyz6PcqpSKT2vKRaNTf6m6KRp6x2n8WrRbl0vblYCBu6gsxZoQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywi3RAjZE4/TL8Px19oPlEfaS+jE/B/4r1iR3+VUFXwosV5sm4Z K/02OsXwQgpaj67zFWa6bRK/TiMKhfGuLK9eZ7x1VULRWicKBWt2QTiPcfuB6THHm+8= X-Gm-Gg: AZuq6aIVqhNUyIOYpmGgUAwpMlyCneLsA+ts02XAD5QPhRznpWn8gFCVEj9mKOErcVe zvHXRKU8mFJ2jyPEQGyxyeBJG4O7G9GiLR8pyfHCUHkF1AcLA080ZCInGV+QfR9T4AiAZvQK2S5 OCU6liuxEBTBesk/TvrIq9mTdWGjHfsNCBLLE93iXZdEuxkDAB4lISMAodPD9L2tQr1faoact1Z 2PlEbDCUywA4hlGfVUIgmUY6bPGQ7kM5PVPjoIqqOLQgyzcTikj/DB7dItU3L0bbcXdt6j144qj HyLCTtZtbHfG5Vkw1VhBL9FV4wzvkIzw6q5D0i7+AIHDOyhUcSFmuGLsCO7uFuGpSgxerP9udLt TJdHzDWeVF2zCFboVZGo5JP12o723RuxRXirCIW68Cdel5aEMdV+Z5TiuZavcDYUgRHC3pjzcs4 p+ko/jLs8M/wLV/Zr5 X-Received: by 2002:a05:600c:458a:b0:47b:e2a9:2bd7 with SMTP id 5b1f17b1804b1-48069c6970fmr53235125e9.19.1769594045452; Wed, 28 Jan 2026 01:54:05 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806ce4c3d1sm51986545e9.9.2026.01.28.01.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 01:54:05 -0800 (PST) Date: Wed, 28 Jan 2026 12:54:01 +0300 From: Dan Carpenter To: Jan Petrous Cc: s32@nxp.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-s32@linaro.org, imx@lists.linux.dev Subject: [PATCH v5 1/3] net: stmmac: s32: use a syscon for S32_PHY_INTF_SEL_RGMII Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On the s32 chipsets the GMAC_0_CTRL_STS register is in GPR region. Originally, accessing this register was done in a sort of ad-hoc way, but we want to use the syscon interface to do it. This is a little bit ugly because we have to maintain backwards compatibility to the old device trees so we have to support both ways to access this register. Signed-off-by: Dan Carpenter Reviewed-by: Jan Petrous (OSS) --- v5: Return an error if regmap_write() fails v4: no change v3: no change v2: Fix forward porting bug. s/PHY_INTF_SEL_RGMII/S32_PHY_INTF_SEL_RGMII/ .../net/ethernet/stmicro/stmmac/dwmac-s32.c | 28 +++++++++++++++---- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c b/drivers/net/= ethernet/stmicro/stmmac/dwmac-s32.c index 5a485ee98fa7..af594a096676 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c @@ -11,12 +11,14 @@ #include #include #include +#include #include #include #include #include #include #include +#include #include =20 #include "stmmac_platform.h" @@ -32,6 +34,8 @@ struct s32_priv_data { void __iomem *ioaddr; void __iomem *ctrl_sts; + struct regmap *sts_regmap; + unsigned int sts_offset; struct device *dev; phy_interface_t *intf_mode; struct clk *tx_clk; @@ -40,11 +44,17 @@ struct s32_priv_data { =20 static int s32_gmac_write_phy_intf_select(struct s32_priv_data *gmac) { - writel(S32_PHY_INTF_SEL_RGMII, gmac->ctrl_sts); + int ret =3D 0; + + if (gmac->ctrl_sts) + writel(S32_PHY_INTF_SEL_RGMII, gmac->ctrl_sts); + else + ret =3D regmap_write(gmac->sts_regmap, gmac->sts_offset, + S32_PHY_INTF_SEL_RGMII); =20 dev_dbg(gmac->dev, "PHY mode set to %s\n", phy_modes(*gmac->intf_mode)); =20 - return 0; + return ret; } =20 static int s32_gmac_init(struct device *dev, void *priv) @@ -125,10 +135,16 @@ static int s32_dwmac_probe(struct platform_device *pd= ev) "dt configuration failed\n"); =20 /* PHY interface mode control reg */ - gmac->ctrl_sts =3D devm_platform_get_and_ioremap_resource(pdev, 1, NULL); - if (IS_ERR(gmac->ctrl_sts)) - return dev_err_probe(dev, PTR_ERR(gmac->ctrl_sts), - "S32CC config region is missing\n"); + gmac->sts_regmap =3D syscon_regmap_lookup_by_phandle_args(dev->of_node, + "nxp,phy-sel", 1, &gmac->sts_offset); + if (gmac->sts_regmap =3D=3D ERR_PTR(-EPROBE_DEFER)) + return PTR_ERR(gmac->sts_regmap); + if (IS_ERR(gmac->sts_regmap)) { + gmac->ctrl_sts =3D devm_platform_get_and_ioremap_resource(pdev, 1, NULL); + if (IS_ERR(gmac->ctrl_sts)) + return dev_err_probe(dev, PTR_ERR(gmac->ctrl_sts), + "S32CC config region is missing\n"); + } =20 /* tx clock */ gmac->tx_clk =3D devm_clk_get(&pdev->dev, "tx"); --=20 2.51.0