From nobody Sat Feb 7 05:01:25 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81EA6280A52 for ; Mon, 5 Jan 2026 21:18:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767647921; cv=none; b=nWRGb/T1Oml6H0G2Yo5cKDSTmkfc4I2lxBnom7T0DtpHGyIdnMcH64JltwfPHwK+Vg0ndIQWnKQGR4ZHcKFHl9eYFxhan7k3L4dYP9/S7usBq6nMYu3I/ix9IyX1Wtidmp5WXH1YU+HlhIvxxyew0T1U8W7cHdxnTexKjEBkw7I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767647921; c=relaxed/simple; bh=tZlSnIVSv0dDh065Q2pVpdflh37FQX/rFwd6FXL6GQ4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=ca0t/+XUROlrngPEA5249/msV3uf/Hw/LUUXeC6CM9Vil/vq6gNUPS7jFixmfJl9WhMpTMJDxUNjgYGFaPvxlSJiuVfjZqKuh2ZUa7SuJqn4kQ3v4Qu6FkPeIMz8uavdM68Oz/S1MpQFY9oFhHRA3C7qmdzw8Ozi+cQNx4D9alc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=g8qXDfxB; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=tCOCFrI0; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g8qXDfxB"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="tCOCFrI0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767647918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=Hkv6lhcNZzti2jyKVbKKJQVamcc/9lt6nIQCCWnF4yA=; b=g8qXDfxBzK46C5n04zwjRTabbDChqxku2UHxvF2a5XLFLQNFo4q0lcyDsbzPDMbgd6J0Ud uKwIurDj38f0Af1ZYXGoo5Dg5mPogCuqq9kwwHCn84RJBt7TjsYeHvC23gXa6FJ0Q13F5S 0ShRyth1NrPFCfcEIkebZIT2+7T1bUE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-322-ePFkMw6JPv6yPgj8zKxH4w-1; Mon, 05 Jan 2026 16:18:37 -0500 X-MC-Unique: ePFkMw6JPv6yPgj8zKxH4w-1 X-Mimecast-MFC-AGG-ID: ePFkMw6JPv6yPgj8zKxH4w_1767647916 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4325aa61c6bso137598f8f.0 for ; Mon, 05 Jan 2026 13:18:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767647915; x=1768252715; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Hkv6lhcNZzti2jyKVbKKJQVamcc/9lt6nIQCCWnF4yA=; b=tCOCFrI0vBBdgB2Wzl0jaHbfchz4VG0dAjumfvrkgcAXJFw1uYQPWbWLgOgptDRicO CCG4XrV9FkyWNgmP83G8nGEZAcv75cv0zmVAGROb2KR1x9SXuKCLADHnAKPjycRi9+9A 77E5/9eIPvra5dbffqfbIx6B1l+Tqskiq4OxSx0tPs9jDn1iQKDW0OpIrF7MCFKLY4jo YLm0op5djLnBGXlhEvm12BoUlO18RprAlbDOwl47F5ZAQ6gSIeuPHhSvUVt7/6SvucvS bT/HjndDRjtSMj2k9CelfDS14Zs00Wq3y6xamExzCs87y9BG4/3fdd79d+UReP8KbrE6 FNkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767647915; x=1768252715; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hkv6lhcNZzti2jyKVbKKJQVamcc/9lt6nIQCCWnF4yA=; b=aAK+YzaiSCY5tWmb02NRnyv1p5ogQItX6vHAW8/iUK5G27ICHbiZ2f2swxlgQxKnDH hwKOxQO6BsDVao5cxa/7iKNv9C5g4iubyg6ncZ/WYc6wqzTx+dOm+k9FyjSA/CHMV3CQ NGc1pj3GJtF/VeZj/uYsun5ZLdSsRNe1TXBUkD5MAxnsahvGmqPTnjvhUXsjNWaO84cE nzHyhCp8g1Zd86nIyDnumeSsiUXMCJH2v3Qr2f50sJMWNgu9WS3X+7BiUC1Lv3jcAFXm nnMM9w9Zpit4CXYwoVPCQlTyUYMRWs6Vv6pFiYdtjczOECcnziWG//jM98ek+9qOqgKv sxVA== X-Gm-Message-State: AOJu0Yxq0sLo4ETc6Kv3AHXCifwrUPSv8rXGT/sjMrShRr0YnAnJKZ3C 65T30RXRcWSfv2KFXZg4+slX4Wyouf2x9Y9K9pvt2rrnhsu8EZyL3GbnTluKvAnxPLYUbLZj/w1 A2b4tppUBXRYfePZ+xp/JcW9RE4npTPRzgcrb8JaoKpKjnq2nOKw1czRVtq/ddyYns2i6DM0lm+ sqd7aDBWGw1lLUOq/7F5bpgEeeVginSvKhCdNmSCH14Wg= X-Gm-Gg: AY/fxX4rVCwIsHKyLt4DfWOvU6P/7XaF0QBh+Ohx16NAItGcnWS/XGezEqMLLlxALkC qjSJi7jLa5gf59HmDPntMfwF4bUO4RfIibTzdBBojGF86c4nrbvmWsimIIAXpR6ygDnKc5g2+Bk TlURr08/Ain6Ed129oGnBGBnGsHFb4JlVcrnHM5Iu8gNYrGrG6yp8oJ6nTETCNsBSjESs9ZXWlW mJl0rlO6Cm9xDmDGCKiYkRyuHRLXcaiu+xqpDjS98witAGlKq/2yPbe0Ijm35hnQAJuSEzKuIGw 5b4nsD4aqg6PD0ZXOqgDZk478PeN+ytuZgUIvTvBCpmX8JYN5Q+8teIsebOMGy0bSue4QT4TN1o frcao0nwQi/ipkxJ/XbuLIbSqewIMJq6TNQ== X-Received: by 2002:a05:6000:184a:b0:42f:edb6:3642 with SMTP id ffacd0b85a97d-432bca58c9amr1417231f8f.60.1767647915495; Mon, 05 Jan 2026 13:18:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IH5964Puiy8lhMVDcOQrq6mQOzp6QnhFL+cujoTXy/kvCQcRnOJ4EFH5gLyQHQ6qyBXmzMFog== X-Received: by 2002:a05:6000:184a:b0:42f:edb6:3642 with SMTP id ffacd0b85a97d-432bca58c9amr1417198f8f.60.1767647914957; Mon, 05 Jan 2026 13:18:34 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5dfa07sm569168f8f.25.2026.01.05.13.18.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 13:18:34 -0800 (PST) Date: Mon, 5 Jan 2026 16:18:32 -0500 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn Subject: [PATCH] checkpatch: special-case cacheline group macros Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, cacheline group macros trigger checkpatch warnings. For example: $ ./scripts/checkpatch.pl -g ba7e025a6c84aed012421468d83639e5dae982b0 WARNING: Missing a blank line after declarations #58: FILE: drivers/gpio/gpio-virtio.c:32: + struct virtio_gpio_response res; + __dma_from_device_group_end(); $ ./scripts/checkpatch.pl -g 5d4cc87414c5d11345c4b11d61377d351b5c28a2 WARNING: Missing a blank line after declarations #267: FILE: include/net/sock.h:431: + int sk_rcvlowat; + __cacheline_group_end(sock_read_rx); But these are not statements actually - the following macros all expand to zero-length fields: __cacheline_group_begin() __cacheline_group_end() __cacheline_group_begin_aligned() __cacheline_group_end_aligned() __dma_from_device_group_begin() __dma_from_device_group_end() Add them to $declaration_macros so checkpatch recognizes this fact. Signed-off-by: Michael S. Tsirkin --- Note: ba7e025a6c84aed012421468d83639e5dae982b0 is only in my tree at this point, but is intended for next. scripts/checkpatch.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c0250244cf7a..f71dd9cbddfb 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1100,7 +1100,9 @@ our $declaration_macros =3D qr{(?x: (?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+)= {1,6}\s*\(| (?:$Storage\s+)?[HLP]?LIST_HEAD\s*\(| (?:SKCIPHER_REQUEST|SHASH_DESC|AHASH_REQUEST)_ON_STACK\s*\(| - (?:$Storage\s+)?(?:XA_STATE|XA_STATE_ORDER)\s*\( + (?:$Storage\s+)?(?:XA_STATE|XA_STATE_ORDER)\s*\(| + __cacheline_group_(?:begin|end)(?:_aligned)?\s*\(| + __dma_from_device_group_(?:begin|end)\s*\( )}; =20 our %allow_repeated_words =3D ( --=20 MST