From nobody Wed Feb 11 05:13:58 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A16F326CE23 for ; Sat, 15 Nov 2025 09:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763197845; cv=none; b=JcZDNoF5uyAPdp2AB6Iklfzd/1VH6I6b9QDWODzQhndawNjIkITZWynTQmSu/e9rLkwlD8Z5hScTBFCwzHYOWDBVWsxGf8YxbljJ3NUZJ25Ydqv8AKKp2pYBYzxCXNcNigwb7YtBla/cy023W7fDxDPB4Dh8a1il3svlpcSg4x0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763197845; c=relaxed/simple; bh=aLENdR9BSNy1WQU19DJ52igohwKCfgQbrHgW6IuMOew=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IvrmHy7MuvxqP8Bd/Lgng/g1GjsM6LHT/55IpbQC3XoqSy62SedEy/I1luaZnUUDjz+oJwHZweIP1erkLg+TGXCHX9kQJQTW47OaUVLKl3jmUprDiRMqTOAF07MOmIlOvGhM59Lmb99yxnvBRX4uESQmjGg/XWkgHZADFmWJMVI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nqQ6DbKr; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nqQ6DbKr" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-b98983baeacso1134823a12.1 for ; Sat, 15 Nov 2025 01:10:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763197843; x=1763802643; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=43JeYWuHKtURhUFg3KcuzTVi7n2XDdHqu+mEl6pMXsI=; b=nqQ6DbKr69gy188vRPsydq4jQPVQ7FD0QJyyvri9d0uE7IK2QFa9xlrWh0l1LJmh9m CiJqAsns83qyQVXS65tm0wC4UnhlCKi3C/Ac3QC5I47omB5fSx675k90H/Hvd3s9MOyh bUcBf0RNaVwJWZLrpALCFh6ZmSPgTJ2Ytfo1Hd5Jp+McvsVXMH5h8Itobi6mBMnb3/tp 4QN7+djhcrECGamdVvmJKHuzFMKyVz4vq3SKV98hcIr6otRuqchM2X4anSYq7LNEIDzQ +KnoQYDOXEwOJIzDSIXFEIhapxDWQuS2ulg8bjqy908Jf2MahYf7YzZzloNqKTPg4ADQ iJtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763197843; x=1763802643; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=43JeYWuHKtURhUFg3KcuzTVi7n2XDdHqu+mEl6pMXsI=; b=OB0e006TgMMGEY0wpjBS1bx4vcbCkWEakJSOe8Ljeb4wfsuFuWosXE77ZIMFXzGI2l H+zCZFykgNauVrJAjibxQMM1i77FQ9/FboSPCw9t8FDFGatAVRajlYDXn+J0JbWm8E0v 2Og3kuPZTEhR3Bd9nfMcX4qjzFGaH5QNkOlyUAsjOFwAv7Nc0+xmiWSD8lQv8lEy5ATG 3wcux23aAfPYAALapSV5eJaU2ZE26gQBhVpCzXqHXoT63Esxnskmjc/XyRe/fJyrtzx0 HJpBHgQLVIssg/gYSkYyM9iNVGvWGY/7yb8UFvOWAMPTelsoVVRoB5XMJ3W87wEejLEu VRBg== X-Forwarded-Encrypted: i=1; AJvYcCV6jK2w9DvWnKUUNwaAYfvHKNkN2Lq2nKGX8MA4oOdPW1mTdPqmXWGEhyYUFm6Wzf31DsEMss6zx4CZFjA=@vger.kernel.org X-Gm-Message-State: AOJu0YxY2hX+oBAAIav1n6uwUrm/57gbkMxnSxoi942kRhDAhE7Pm0P9 Z48aUDWEeGb+P4H7ZvAEE8rutoy5GEmcOLTRfFDM6As/MmSQf8OZLVJ7 X-Gm-Gg: ASbGncvXzQkA0lTFMtoJ8d2xQtjbLiu8XdYb6rT1RFt57tfEd+RwFrRJiG1I0ydRekb DFlZh1B77DiQL5VGnLuKugWs5QErsv1PsPxw1ElUNzgm/KM0wEDQ9KZL/hgpZ2ZSbUYRa3Znguw xvEOu2c6e0XFBM9JAhXxyU97mlMu3rrW8BQMKbLHpVhaeQUC17pH8i3RLBF0dY6//MKTt3BZLPn 6Erx7zq8gHpax8+iw40hadFGNlc/3DhLrPes7PBOz/ang6W+79D0OPFeWCIm4dejNPspa9xq77C 1rdoonHZL/plOX60PEtgSmhS+uABWbQ7YQMIIKc8Qeo7FbX1rin1l1AT+lRsKuHgBDe3hAnYX+R USSRU6hzopFBfIpvYaDz5EFWosM6qUy1EyatKjRB6c+fd97U8GL4IhmNOLKIFK1jIU3wZhSMR0Q == X-Google-Smtp-Source: AGHT+IElHt3OAfMQunNnxmg0BPEu4aQyjchDbhYGwGxKZcOlUa5P+fzvsHcgcZg533YgbRMtBY3msQ== X-Received: by 2002:a05:7301:5787:b0:2a4:3593:ddd7 with SMTP id 5a478bee46e88-2a4abab9ccemr2414709eec.4.1763197842582; Sat, 15 Nov 2025 01:10:42 -0800 (PST) Received: from geday ([2804:7f2:800b:a07a::dead:c001]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49d695821sm22796380eec.0.2025.11.15.01.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Nov 2025 01:10:42 -0800 (PST) Date: Sat, 15 Nov 2025 06:10:36 -0300 From: Geraldo Nascimento To: linux-rockchip@lists.infradead.org Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , Conor Dooley , Johan Jonker , Geraldo Nascimento , Dragan Simic Subject: [PATCH 2/3] PCI: rockchip-host: comment danger of 5.0 GT/s speed Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" According to Rockchip sources, there is grave danger in enabling 5.0 GT/s speed for this core. Add a comment documenting that danger and discouraging end-users from forcing higher speed through DT changes. Link: https://lore.kernel.org/all/ffd05070-9879-4468-94e3-b88968b4c21b@rock= -chips.com/ Reported-by: Shawn Lin Signed-off-by: Geraldo Nascimento Reviewed-by: Dragan Simic --- drivers/pci/controller/pcie-rockchip-host.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index ee1822ca01db..7e6ff76466b7 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -332,6 +332,11 @@ static int rockchip_pcie_host_init_port(struct rockchi= p_pcie *rockchip) /* * Enable retrain for gen2. This should be configured only after * gen1 finished. + * + * According to Rockchip this path is dangerous and may lead to + * catastrophic failure. Even if the odds are small, users are + * still discouraged to engage the corresponding DT option. + * */ status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL2); status &=3D ~PCI_EXP_LNKCTL2_TLS; --=20 2.49.0