From nobody Thu Apr 2 13:51:12 2026 Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8BD2040DFD7; Sun, 29 Mar 2026 18:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.133.224.34 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774807664; cv=none; b=eaL5/SpNxl0QcpIjlWZJOfwIgPovGklpRj1SoWhCM9P7/0N2GLTdFiui31ZVsiVpzp88mIhgoQXPFIaUN3CJ4BMp/CscmjxHiz7rDn2RlrdPD6IDncSsnWZr0QbI/pOkQsYlze6V4wP2r0Ghkl1YXnqGzBOkFOA9FwFvsyATyXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774807664; c=relaxed/simple; bh=dbPO3jMraffT/PZ8T4+vw7HyjVm0Ny6QQi7W3LF92X0=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=OrHpRaeQ1+MslWMyaB1NZbnkIY7Un7IyTM05BKdK8i24XNME29zXQmEbeCtNk0nziov2YL2+yrUCrHgDdtX4P+7DpgsfiywGhlStxzXffD3eIJEDt1ajc6qeeBDj9x+pzvYTiqz7JdiVphf15k4qqze3TqXfguH/D2iMajuVBCs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk; spf=none smtp.mailfrom=orcam.me.uk; arc=none smtp.client-ip=78.133.224.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id AAC0C92009C; Sun, 29 Mar 2026 20:07:41 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id A634F92009B; Sun, 29 Mar 2026 19:07:41 +0100 (BST) Date: Sun, 29 Mar 2026 19:07:41 +0100 (BST) From: "Maciej W. Rozycki" To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 2/2] declance: Include the offending address with DMA errors In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The address latched in the I/O ASIC LANCE DMA Pointer Register uses the=20 TURBOchannel bus address encoding and therefore bits 33:29 of location=20 referred occupy bits 4:0, bits 28:2 are left-shifted by 3, and bits 1:0=20 are hardwired to zero. In reality no TURBOchannel system exceeds 1GiB=20 of RAM though, so the address reported will always fit in 8 hex digits. Signed-off-by: Maciej W. Rozycki --- Changes from v1: - s/16/8/ in the change description for the printed address width. --- drivers/net/ethernet/amd/declance.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) linux-declance-dma-merr-addr.diff Index: linux-macro/drivers/net/ethernet/amd/declance.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- linux-macro.orig/drivers/net/ethernet/amd/declance.c +++ linux-macro/drivers/net/ethernet/amd/declance.c @@ -726,8 +726,10 @@ static void lance_tx(struct net_device * static irqreturn_t lance_dma_merr_int(int irq, void *dev_id) { struct net_device *dev =3D dev_id; + u64 ldp =3D ioasic_read(IO_REG_LANCE_DMA_P); =20 - pr_err_ratelimited("%s: DMA error\n", dev->name); + pr_err_ratelimited("%s: DMA error at %#010llx\n", dev->name, + (ldp & 0x1f) << 29 | (ldp & 0xffffffe0) >> 3); return IRQ_HANDLED; }