From nobody Mon Feb 9 08:30:43 2026 Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B8A9A195F0D; Fri, 9 Aug 2024 13:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.133.224.34 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723209890; cv=none; b=a0qTYWDyiYtyxamgOx+xPpcp8Af5Irb7BDHuDBdyds5qocXWpEcn+8cPl6TD61pH4JOCwTqaZcdwTEQFXC74KCCfye2YDdlcHOckolaSx8yzwqYQv4rsnHV5etz8PWHs2vvsg6rfIyCXTgNhHCr2K0xoudWAA1nMcHbUh+CbHxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723209890; c=relaxed/simple; bh=Sce8NZSG+ZRrji36seXJJlUurv4MBemLC4XmM0+abh0=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=Yrj3Jf6+isqlg5j7jxbG7oicu+J6BVfOmTKXV6fEm6Mqm+dOKclKR60A3c3Wj1KRJ3CBbY0X+Sbjc7FTSR65hG3P4NpV/0NHiRaZXIHA8xp2PuliU1z3yYwzWhkbTlNX+bKrv992ll0tBDlKLnQrf0h880oLENh0+VxwOrm8ts0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk; spf=none smtp.mailfrom=orcam.me.uk; arc=none smtp.client-ip=78.133.224.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 94E4E92009E; Fri, 9 Aug 2024 15:24:46 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 8F3D392009D; Fri, 9 Aug 2024 14:24:46 +0100 (BST) Date: Fri, 9 Aug 2024 14:24:46 +0100 (BST) From: "Maciej W. Rozycki" To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Matthew W Carlis , Bjorn Helgaas cc: Mika Westerberg , Oliver O'Halloran , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/4] PCI: Clear the LBMS bit after a link retrain In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The LBMS bit, where implemented, is set by hardware either in response=20 to the completion of retraining caused by writing 1 to the Retrain Link=20 bit or whenever hardware has changed the link speed or width in attempt=20 to correct unreliable link operation. It is never cleared by hardware=20 other than by software writing 1 to the bit position in the Link Status=20 register and we never do such a write. We currently have two places, namely `apply_bad_link_workaround' and=20 `pcie_failed_link_retrain' in drivers/pci/controller/dwc/pcie-tegra194.c=20 and drivers/pci/quirks.c respectively where we check the state of the=20 LBMS bit and neither is interested in the state of the bit resulting=20 from the completion of retraining, both check for a link fault. And in particular `pcie_failed_link_retrain' causes issues consequently,=20 by trying to retrain a link where there's no downstream device anymore=20 and the state of 1 in the LBMS bit has been retained from when there was=20 a device downstream that has since been removed. Clear the LBMS bit then at the conclusion of `pcie_retrain_link', so=20 that we have a single place that controls it and that our code can track=20 link speed or width changes resulting from unreliable link operation. Fixes: a89c82249c37 ("PCI: Work around PCIe link training failures") Reported-by: Matthew W Carlis Link: https://lore.kernel.org/r/20240806000659.30859-1-mattc@purestorage.co= m/ Link: https://lore.kernel.org/r/20240722193407.23255-1-mattc@purestorage.co= m/ Signed-off-by: Maciej W. Rozycki Cc: stable@vger.kernel.org # v6.5+ --- New change in v2. --- drivers/pci/pci.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) linux-pcie-retrain-link-lbms-clear.diff Index: linux-macro/drivers/pci/pci.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- linux-macro.orig/drivers/pci/pci.c +++ linux-macro/drivers/pci/pci.c @@ -4718,7 +4718,15 @@ int pcie_retrain_link(struct pci_dev *pd pcie_capability_clear_word(pdev, PCI_EXP_LNKCTL, PCI_EXP_LNKCTL_RL); } =20 - return pcie_wait_for_link_status(pdev, use_lt, !use_lt); + rc =3D pcie_wait_for_link_status(pdev, use_lt, !use_lt); + + /* + * Clear LBMS after a manual retrain so that the bit can be used + * to track link speed or width changes made by hardware itself + * in attempt to correct unreliable link operation. + */ + pcie_capability_write_word(pdev, PCI_EXP_LNKSTA, PCI_EXP_LNKSTA_LBMS); + return rc; } =20 /** From nobody Mon Feb 9 08:30:43 2026 Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0EE1A194C7A; Fri, 9 Aug 2024 13:24:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.133.224.34 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723209894; cv=none; b=Ov3JAq3LG04cYIRtUoIzk5qPKnU4mLENKscQyUxO57t8LtoFRVAJ2rTFcqUPx2OrL1P+Ka9jDBTZBKIHZR2h8kM26Z85J3o161wjN0Dh5wlX374tqieyxtOkJqHtxRzRCOkh+VcrR/PkGY+FSsxncbpnwX9yAQdCtBaPahXTLQw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723209894; c=relaxed/simple; bh=u6rCZzVYDmS1EgHib/U42ns/paYCkHwdsSBnS1g3Z0A=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=ZAEQvJZlHiB9ltbExxVLMiJKpOy+N7cDSFBChHlgwlCz0MjI5iCV4skEaebYtQhD8VPDDNqGnlmfKEgkTYLFhEMrgV+ec2xEz3JUqbvRDHawCFaeEBk+b4nUM7cHQbYEZkH7CfmTp5JNFntpxzAI8TawbaDbDGgRvgNugyZQ9EY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk; spf=none smtp.mailfrom=orcam.me.uk; arc=none smtp.client-ip=78.133.224.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 6822B92009E; Fri, 9 Aug 2024 15:24:51 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 624FA92009D; Fri, 9 Aug 2024 14:24:51 +0100 (BST) Date: Fri, 9 Aug 2024 14:24:51 +0100 (BST) From: "Maciej W. Rozycki" To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Matthew W Carlis , Bjorn Helgaas cc: Mika Westerberg , Oliver O'Halloran , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] PCI: Revert to the original speed after PCIe failed link retraining In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When `pcie_failed_link_retrain' has failed to retrain the link by hand=20 it leaves the link speed restricted to 2.5GT/s, which will then affect=20 any device that has been plugged in later on, which may not suffer from=20 the problem that caused the speed restriction to have been attempted. =20 Consequently such a downstream device will suffer from an unnecessary=20 communication throughput limitation and therefore performance loss. Remove the speed restriction then and revert the Link Control 2 register=20 to its original state if link retraining with the speed restriction in=20 place has failed. Retrain the link again afterwards to remove any=20 residual state, ignoring the result as it's supposed to fail anyway. Fixes: a89c82249c37 ("PCI: Work around PCIe link training failures") Reported-by: Matthew W Carlis Link: https://lore.kernel.org/r/20240806000659.30859-1-mattc@purestorage.co= m/ Link: https://lore.kernel.org/r/20240722193407.23255-1-mattc@purestorage.co= m/ Signed-off-by: Maciej W. Rozycki Cc: stable@vger.kernel.org # v6.5+ Reviewed-by: Ilpo J=C3=A4rvinen Reviewed-by: Matthew Carlis --- New change in v2. --- drivers/pci/quirks.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) linux-pcie-failed-link-retrain-fail-unclamp.diff Index: linux-macro/drivers/pci/quirks.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- linux-macro.orig/drivers/pci/quirks.c +++ linux-macro/drivers/pci/quirks.c @@ -66,7 +66,7 @@ * apply this erratum workaround to any downstream ports as long as they * support Link Active reporting and have the Link Control 2 register. * Restrict the speed to 2.5GT/s then with the Target Link Speed field, - * request a retrain and wait 200ms for the data link to go up. + * request a retrain and check the result. * * If this turns out successful and we know by the Vendor:Device ID it is * safe to do so, then lift the restriction, letting the devices negotiate @@ -74,6 +74,10 @@ * firmware may have already arranged and lift it with ports that already * report their data link being up. * + * Otherwise revert the speed to the original setting and request a retrain + * again to remove any residual state, ignoring the result as it's supposed + * to fail anyway. + * * Return TRUE if the link has been successfully retrained, otherwise FALS= E. */ bool pcie_failed_link_retrain(struct pci_dev *dev) @@ -92,6 +96,8 @@ bool pcie_failed_link_retrain(struct pci pcie_capability_read_word(dev, PCI_EXP_LNKSTA, &lnksta); if ((lnksta & (PCI_EXP_LNKSTA_LBMS | PCI_EXP_LNKSTA_DLLLA)) =3D=3D PCI_EXP_LNKSTA_LBMS) { + u16 oldlnkctl2 =3D lnkctl2; + pci_info(dev, "broken device, retraining non-functional downstream link = at 2.5GT/s\n"); =20 lnkctl2 &=3D ~PCI_EXP_LNKCTL2_TLS; @@ -100,6 +106,9 @@ bool pcie_failed_link_retrain(struct pci =20 if (pcie_retrain_link(dev, false)) { pci_info(dev, "retraining failed\n"); + pcie_capability_write_word(dev, PCI_EXP_LNKCTL2, + oldlnkctl2); + pcie_retrain_link(dev, false); return false; } From nobody Mon Feb 9 08:30:43 2026 Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4CFC9194C7A; Fri, 9 Aug 2024 13:24:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.133.224.34 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723209899; cv=none; b=gX3Mbeen0kmeKzL9MkhDjo2FcXap3ttzv8oI3ma9i3hv55b9RTrW1bPfav95OVt76b3Yv/inGu1v3FfIVej6orcXsX1hU14kB5hMolyG77e6AqpJ0wW98/wM8r7T9aLD2BF/V4oWoOoZ6fx+J4CxyLBwfIJC29zism65V0gQBEc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723209899; c=relaxed/simple; bh=oO6MQTmjnJFu2xQCO9pfMWs7uWcsv46mOiTEEJUF6SA=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=ugSWWU0z28GaMSHbDuJeNOoslPSBl8kDabZjZCAdiEgZFopPUBimp5Gt6w5kw8LCrsNYnbeRVlvWCOWXiMiO+ZooJSvTtAKTzk82/ymtatCj5EOEMiVQ+uVyFXrhCEaIvwxGjneTWWRSF4X8c/ier/3+FSEGBVNIm16B2mURH+Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk; spf=none smtp.mailfrom=orcam.me.uk; arc=none smtp.client-ip=78.133.224.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 3000B9200BB; Fri, 9 Aug 2024 15:24:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 28B8D9200B4; Fri, 9 Aug 2024 14:24:56 +0100 (BST) Date: Fri, 9 Aug 2024 14:24:56 +0100 (BST) From: "Maciej W. Rozycki" To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Matthew W Carlis , Bjorn Helgaas cc: Mika Westerberg , Oliver O'Halloran , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/4] PCI: Correct error reporting with PCIe failed link retraining In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Only return successful completion status from `pcie_failed_link_retrain'=20 if retraining has actually been done, preventing excessive delays from=20 being triggered at call sites in a hope that communication will finally=20 be established with the downstream device where in fact nothing has been=20 done about the link in question that would justify such a hope. Fixes: a89c82249c37 ("PCI: Work around PCIe link training failures") Reported-by: Ilpo J=C3=A4rvinen Link: https://lore.kernel.org/r/aa2d1c4e-9961-d54a-00c7-ddf8e858a9b0@linux.= intel.com/ Signed-off-by: Maciej W. Rozycki Reviewed-by: Ilpo J=C3=A4rvinen Cc: stable@vger.kernel.org # v6.5+ --- Changes from v1 (superseding 1/2): - Regenerate on top of 2/4. - Reword the comment update for clarity. - Go back to returning explicit FALSE rather than `ret' where it is known=20 that we failed. --- drivers/pci/quirks.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) linux-pcie-failed-link-retrain-status-fix.diff Index: linux-macro/drivers/pci/quirks.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- linux-macro.orig/drivers/pci/quirks.c +++ linux-macro/drivers/pci/quirks.c @@ -78,7 +78,8 @@ * again to remove any residual state, ignoring the result as it's supposed * to fail anyway. * - * Return TRUE if the link has been successfully retrained, otherwise FALS= E. + * Return TRUE if the link has been successfully retrained. Return FALSE + * if retraining was not needed or we attempted a retrain and it failed. */ bool pcie_failed_link_retrain(struct pci_dev *dev) { @@ -87,6 +88,7 @@ bool pcie_failed_link_retrain(struct pci {} }; u16 lnksta, lnkctl2; + bool ret =3D false; =20 if (!pci_is_pcie(dev) || !pcie_downstream_port(dev) || !pcie_cap_has_lnkctl2(dev) || !dev->link_active_reporting) @@ -104,7 +106,8 @@ bool pcie_failed_link_retrain(struct pci lnkctl2 |=3D PCI_EXP_LNKCTL2_TLS_2_5GT; pcie_capability_write_word(dev, PCI_EXP_LNKCTL2, lnkctl2); =20 - if (pcie_retrain_link(dev, false)) { + ret =3D pcie_retrain_link(dev, false) =3D=3D 0; + if (!ret) { pci_info(dev, "retraining failed\n"); pcie_capability_write_word(dev, PCI_EXP_LNKCTL2, oldlnkctl2); @@ -126,13 +129,14 @@ bool pcie_failed_link_retrain(struct pci lnkctl2 |=3D lnkcap & PCI_EXP_LNKCAP_SLS; pcie_capability_write_word(dev, PCI_EXP_LNKCTL2, lnkctl2); =20 - if (pcie_retrain_link(dev, false)) { + ret =3D pcie_retrain_link(dev, false) =3D=3D 0; + if (!ret) { pci_info(dev, "retraining failed\n"); return false; } } =20 - return true; + return ret; } =20 static ktime_t fixup_debug_start(struct pci_dev *dev, From nobody Mon Feb 9 08:30:43 2026 Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DBCF619046B; Fri, 9 Aug 2024 13:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.133.224.34 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723209905; cv=none; b=OYHOhajZUKjqUHCM6ns6d9PbaRVYI3Oho9f3l/hvNrzSpvQX4K7tdeTE1aTDIpb+i/DKQ2sMWUgiXKpXv7g/rYDG8H8ZR8Jfknv2/GSzAWH4LDRBf8SSGJRhPfDW2OJ2q2Pnwv+YruWNBtTKcZfb05PxnhriuOps/jcK+JuxBSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723209905; c=relaxed/simple; bh=bYQp3ikYb6UcZmySu0y4CDyj2Cj43xHJvNAiV9OgIwc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=gNII4/yFrdF2FzbryynnlRsWeKveTogEnKQCzPZ4VguNtFfAqMlisjupM9+xbcLDNx3TuHu09FQ961/eO7VR4kGSSSjrG9oOFCwjrZiTe7f+4WdjFPhNPILGGp1Dg9R+osnjuu0ypGNxMfyBIBmOQayS4xn4y1EDvH5tvgdBKb4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk; spf=none smtp.mailfrom=orcam.me.uk; arc=none smtp.client-ip=78.133.224.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 167EC9200B3; Fri, 9 Aug 2024 15:25:03 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 0F82292009B; Fri, 9 Aug 2024 14:25:03 +0100 (BST) Date: Fri, 9 Aug 2024 14:25:02 +0100 (BST) From: "Maciej W. Rozycki" To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Matthew W Carlis , Bjorn Helgaas cc: Mika Westerberg , Oliver O'Halloran , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/4] PCI: Use an error code with PCIe failed link retraining In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Given how the call place in `pcie_wait_for_link_delay' got structured=20 now, and that `pcie_retrain_link' returns a potentially useful error=20 code, convert `pcie_failed_link_retrain' to return an error code rather=20 than a boolean status, fixing handling at the call site mentioned. =20 Update the other call site accordingly. Fixes: 1abb47390350 ("Merge branch 'pci/enumeration'") Reported-by: Ilpo J=C3=A4rvinen Link: https://lore.kernel.org/r/aa2d1c4e-9961-d54a-00c7-ddf8e858a9b0@linux.= intel.com/ Signed-off-by: Maciej W. Rozycki Reviewed-by: Ilpo J=C3=A4rvinen Cc: stable@vger.kernel.org # v6.5+ --- Changes from v1 (superseding 2/2): - Regenerate following changes to 3/4, no functional change. --- drivers/pci/pci.c | 2 +- drivers/pci/pci.h | 6 +++--- drivers/pci/quirks.c | 20 ++++++++++---------- 3 files changed, 14 insertions(+), 14 deletions(-) linux-pcie-failed-link-retrain-status-int.diff Index: linux-macro/drivers/pci/pci.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- linux-macro.orig/drivers/pci/pci.c +++ linux-macro/drivers/pci/pci.c @@ -1324,7 +1324,7 @@ static int pci_dev_wait(struct pci_dev * if (delay > PCI_RESET_WAIT) { if (retrain) { retrain =3D false; - if (pcie_failed_link_retrain(bridge)) { + if (pcie_failed_link_retrain(bridge) =3D=3D 0) { delay =3D 1; continue; } Index: linux-macro/drivers/pci/pci.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- linux-macro.orig/drivers/pci/pci.h +++ linux-macro/drivers/pci/pci.h @@ -606,7 +606,7 @@ void pci_acs_init(struct pci_dev *dev); int pci_dev_specific_acs_enabled(struct pci_dev *dev, u16 acs_flags); int pci_dev_specific_enable_acs(struct pci_dev *dev); int pci_dev_specific_disable_acs_redir(struct pci_dev *dev); -bool pcie_failed_link_retrain(struct pci_dev *dev); +int pcie_failed_link_retrain(struct pci_dev *dev); #else static inline int pci_dev_specific_acs_enabled(struct pci_dev *dev, u16 acs_flags) @@ -621,9 +621,9 @@ static inline int pci_dev_specific_disab { return -ENOTTY; } -static inline bool pcie_failed_link_retrain(struct pci_dev *dev) +static inline int pcie_failed_link_retrain(struct pci_dev *dev) { - return false; + return -ENOTTY; } #endif =20 Index: linux-macro/drivers/pci/quirks.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- linux-macro.orig/drivers/pci/quirks.c +++ linux-macro/drivers/pci/quirks.c @@ -78,21 +78,21 @@ * again to remove any residual state, ignoring the result as it's supposed * to fail anyway. * - * Return TRUE if the link has been successfully retrained. Return FALSE + * Return 0 if the link has been successfully retrained. Return an error * if retraining was not needed or we attempted a retrain and it failed. */ -bool pcie_failed_link_retrain(struct pci_dev *dev) +int pcie_failed_link_retrain(struct pci_dev *dev) { static const struct pci_device_id ids[] =3D { { PCI_VDEVICE(ASMEDIA, 0x2824) }, /* ASMedia ASM2824 */ {} }; u16 lnksta, lnkctl2; - bool ret =3D false; + int ret =3D -ENOTTY; =20 if (!pci_is_pcie(dev) || !pcie_downstream_port(dev) || !pcie_cap_has_lnkctl2(dev) || !dev->link_active_reporting) - return false; + return ret; =20 pcie_capability_read_word(dev, PCI_EXP_LNKCTL2, &lnkctl2); pcie_capability_read_word(dev, PCI_EXP_LNKSTA, &lnksta); @@ -106,13 +106,13 @@ bool pcie_failed_link_retrain(struct pci lnkctl2 |=3D PCI_EXP_LNKCTL2_TLS_2_5GT; pcie_capability_write_word(dev, PCI_EXP_LNKCTL2, lnkctl2); =20 - ret =3D pcie_retrain_link(dev, false) =3D=3D 0; - if (!ret) { + ret =3D pcie_retrain_link(dev, false); + if (ret) { pci_info(dev, "retraining failed\n"); pcie_capability_write_word(dev, PCI_EXP_LNKCTL2, oldlnkctl2); pcie_retrain_link(dev, false); - return false; + return ret; } =20 pcie_capability_read_word(dev, PCI_EXP_LNKSTA, &lnksta); @@ -129,10 +129,10 @@ bool pcie_failed_link_retrain(struct pci lnkctl2 |=3D lnkcap & PCI_EXP_LNKCAP_SLS; pcie_capability_write_word(dev, PCI_EXP_LNKCTL2, lnkctl2); =20 - ret =3D pcie_retrain_link(dev, false) =3D=3D 0; - if (!ret) { + ret =3D pcie_retrain_link(dev, false); + if (ret) { pci_info(dev, "retraining failed\n"); - return false; + return ret; } } =20