From nobody Mon Feb 9 13:26:06 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CE43EB64DA for ; Mon, 19 Jun 2023 01:01:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229567AbjFSBBO (ORCPT ); Sun, 18 Jun 2023 21:01:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjFSBBM (ORCPT ); Sun, 18 Jun 2023 21:01:12 -0400 Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C679DC4; Sun, 18 Jun 2023 18:01:06 -0700 (PDT) Received: by angie.orcam.me.uk (Postfix, from userid 500) id CE8BD92009C; Mon, 19 Jun 2023 03:01:05 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id BF91792009B; Mon, 19 Jun 2023 02:01:05 +0100 (BST) Date: Mon, 19 Jun 2023 02:01:05 +0100 (BST) From: "Maciej W. Rozycki" To: "David S. Miller" cc: Randy Dunlap , Sudip Mukherjee , Sam Ravnborg , sparclinux@vger.kernel.org, linux-parport@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] SPARC: Fix parport_pc support for 32-bit platforms Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" For 32-bit SPARC platforms PC-style parallel ports are only available as=20 PCI options. Adjust accordingly, fixing build errors: sparc-linux-gnu-ld: drivers/parport/parport_pc.o: in function `ecpp_remove': parport_pc.c:(.text+0x8f0): undefined reference to `ebus_dma_irq_enable' sparc-linux-gnu-ld: parport_pc.c:(.text+0x8f8): undefined reference to `ebu= s_dma_unregister' sparc-linux-gnu-ld: drivers/parport/parport_pc.o: in function `parport_pc_f= ifo_write_block_dma': parport_pc.c:(.text+0x1430): undefined reference to `ebus_dma_enable' sparc-linux-gnu-ld: parport_pc.c:(.text+0x1444): undefined reference to `eb= us_dma_prepare' sparc-linux-gnu-ld: parport_pc.c:(.text+0x14e4): undefined reference to `eb= us_dma_enable' sparc-linux-gnu-ld: parport_pc.c:(.text+0x14f4): undefined reference to `eb= us_dma_request' sparc-linux-gnu-ld: parport_pc.c:(.text+0x1584): undefined reference to `eb= us_dma_enable' sparc-linux-gnu-ld: parport_pc.c:(.text+0x1594): undefined reference to `eb= us_dma_residue' sparc-linux-gnu-ld: parport_pc.c:(.text+0x1608): undefined reference to `eb= us_dma_enable' sparc-linux-gnu-ld: parport_pc.c:(.text+0x1618): undefined reference to `eb= us_dma_residue' sparc-linux-gnu-ld: drivers/parport/parport_pc.o: in function `ecpp_probe': parport_pc.c:(.text+0x33a0): undefined reference to `ebus_dma_register' sparc-linux-gnu-ld: parport_pc.c:(.text+0x33b8): undefined reference to `eb= us_dma_irq_enable' sparc-linux-gnu-ld: parport_pc.c:(.text+0x34b0): undefined reference to `eb= us_dma_irq_enable' sparc-linux-gnu-ld: parport_pc.c:(.text+0x34bc): undefined reference to `eb= us_dma_unregister' Reported-by: Randy Dunlap =20 Closes: https://lore.kernel.org/r/20230406160548.25721-1-rdunlap@infradead.= org/ Signed-off-by: Maciej W. Rozycki Fixes: 66bcd06099bb ("parport_pc: Also enable driver for PCI systems") Cc: stable@vger.kernel.org # v5.18+ Acked-by: Randy Dunlap Tested-by: Randy Dunlap # build-tested --- NB by enabling CONFIG_WERROR I hit: sparc-linux-gnu-gcc -Wp,-MMD,kernel/.workqueue.o.d -nostdinc -I./arch/sp= arc/include -I./arch/sparc/include/generated -I./include -I./arch/sparc/in= clude/uapi -I./arch/sparc/include/generated/uapi -I./include/uapi -I./inclu= de/generated/uapi -include ./include/linux/compiler-version.h -include ./in= clude/linux/kconfig.h -include ./include/linux/compiler_types.h -D__KERNEL_= _ -Werror -fmacro-prefix-map=3D./=3D -Wall -Wundef -Werror=3Dstrict-prototy= pes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE = -Werror=3Dimplicit-function-declaration -Werror=3Dimplicit-int -Werror=3Dre= turn-type -Wno-format-security -funsigned-char -std=3Dgnu11 -m32 -mcpu=3Dv8= -pipe -mno-fpu -fcall-used-g5 -fcall-used-g7 -Wa,-Av8 -fno-delete-null-poi= nter-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow = -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-large= r-than=3D1024 -fno-stack-protector -Wno-main -Wno-unused-but-set-variable -= Wno-unused-const-variable -Wno-dangling-p ointer -fomit-frame-pointer -ftrivial-auto-var-init=3Dzero -fno-stack-clas= h-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-f= unction-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict = -Wno-maybe-uninitialized -Wno-array-bounds -Wno-alloc-size-larger-than -Wim= plicit-fallthrough=3D5 -fno-strict-overflow -fno-stack-check -fconserve-sta= ck -Werror=3Ddate-time -Werror=3Dincompatible-pointer-types -Werror=3Ddesig= nated-init -Wno-packed-not-aligned -DKBUILD_MODFILE=3D'"kernel/workqueue= "' -DKBUILD_BASENAME=3D'"workqueue"' -DKBUILD_MODNAME=3D'"workqueue"' -D__K= BUILD_MODNAME=3Dkmod_workqueue -c -o kernel/workqueue.o kernel/workqueue.c =20 kernel/workqueue.c: In function 'get_work_pwq': kernel/workqueue.c:713:24: error: cast to pointer from integer of different= size [-Werror=3Dint-to-pointer-cast] 713 | return (void *)(data & WORK_STRUCT_WQ_DATA_MASK); | ^ kernel/workqueue.c: In function 'get_work_pool': kernel/workqueue.c:741:25: error: cast to pointer from integer of different= size [-Werror=3Dint-to-pointer-cast] 741 | return ((struct pool_workqueue *) | ^ kernel/workqueue.c: In function 'get_work_pool_id': kernel/workqueue.c:763:25: error: cast to pointer from integer of different= size [-Werror=3Dint-to-pointer-cast] 763 | return ((struct pool_workqueue *) | ^ cc1: all warnings being treated as errors make[2]: *** [scripts/Makefile.build:252: kernel/workqueue.o] Error 1 make[1]: *** [scripts/Makefile.build:494: kernel] Error 2 make: *** [Makefile:2026: .] Error 2 with top of tree GCC 14 and even came up with a fix, but I can see the=20 issue is already being handled with an identical change from Arnd here:=20 , so=20 there's nothing to do about it; let's just wait for 6.5. Changes from v1: - Wrap `dma_spin_lock' into HAS_DMA to fix a "'dma_spin_lock' defined but=20 not used" warning. I think it's slightly cleaner this way compared to=20 wrapping the whole part into CONFIG_SPARC64, as this better reflects the=20 structure of the dependencies here. It also follows the structure of=20 parport_pc.c, which likewise has `parport_pc_fifo_write_block_dma' put=20 into CONFIG_PARPORT_PC_FIFO and then HAS_DMA conditionals. - Add Reported-by tag. --- arch/sparc/include/asm/parport.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) linux-sparc32-parport-pc.diff Index: linux-macro/arch/sparc/include/asm/parport.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- linux-macro.orig/arch/sparc/include/asm/parport.h +++ linux-macro/arch/sparc/include/asm/parport.h @@ -19,9 +19,11 @@ * While sparc64 doesn't have an ISA DMA API, we provide something that lo= oks * close enough to make parport_pc happy */ +#ifdef CONFIG_SPARC64 #define HAS_DMA +#endif =20 -#ifdef CONFIG_PARPORT_PC_FIFO +#if defined(CONFIG_PARPORT_PC_FIFO) && defined(HAS_DMA) static DEFINE_SPINLOCK(dma_spin_lock); =20 #define claim_dma_lock() \ @@ -249,7 +251,8 @@ static struct platform_driver ecpp_drive =20 static int parport_pc_find_nonpci_ports(int autoirq, int autodma) { - return platform_driver_register(&ecpp_driver); + return (IS_ENABLED(CONFIG_SPARC64) && + platform_driver_register(&ecpp_driver)); } =20 #endif /* !(_ASM_SPARC64_PARPORT_H */